mongo 2.13.0.beta1 → 2.13.0.rc1

data/spec/mongo/database_spec.rb

@@ -92,8 +92,8 @@ describe Mongo::Database do
     end
 
     before do
-      database[:users].drop
-      database[:users].create
+      database['users'].drop
+      database['users'].create
     end
 
     let(:actual) do
@@ -153,7 +153,80 @@ describe Mongo::Database do
         expect(collection_names).to include('0_dalmatians')
         expect(collection_names).to include('1_dalmatians')
       end
+    end
+
+    context 'when provided a filter' do
+      min_server_fcv '3.0'
+
+      before do
+        database['users2'].drop
+        database['users2'].create
+      end
+
+      let(:result) do
+        database.collection_names(filter: { name: 'users2' })
+      end
 
+      it 'returns users2 collection' do
+        expect(result.length).to eq(1)
+        expect(result.first).to eq('users2')
+      end
+    end
+
+    context 'when provided authorized_collections or not' do
+
+      context 'on server versions >= 4.0' do
+        min_server_fcv '4.0'
+
+        let(:database) do
+          described_class.new(client, SpecConfig.instance.test_db)
+        end
+
+        let(:subscriber) { EventSubscriber.new }
+
+        let(:client) do
+          authorized_client.tap do |client|
+            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+          end
+        end
+
+        context 'when authorized_collections is provided' do
+          let(:options) do
+            { authorized_collections: true }
+          end
+
+          let!(:result) do
+            database.collections(options)
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'passes authorized_collections to the server' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['authorizedCollections']).to eq(true)
+          end
+        end
+
+        context 'when no options are provided' do
+          let!(:result) do
+            database.collection_names
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'authorized_collections not passed to server' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['nameOnly']).to eq(true)
+            expect(command['authorizedCollections']).to be_nil
+          end
+        end
+      end
     end
   end
 
@@ -170,8 +243,8 @@ describe Mongo::Database do
     end
 
     before do
-      database[:acol].drop
-      database[:acol].create
+      database['acol'].drop
+      database['acol'].create
     end
 
     context 'server 3.0+' do
@@ -183,8 +256,8 @@ describe Mongo::Database do
 
       context 'with more than one collection' do
         before do
-          database[:anothercol].drop
-          database[:anothercol].create
+          database['anothercol'].drop
+          database['anothercol'].create
 
           expect(database.collections.length).to be > 1
         end
@@ -239,6 +312,85 @@ describe Mongo::Database do
         end
       end
     end
+
+    context 'when provided authorized_collections or name_only options or not' do
+
+      context 'on server versions >= 4.0' do
+        min_server_fcv '4.0'
+
+        let(:database) do
+          described_class.new(client, SpecConfig.instance.test_db)
+        end
+
+        let(:subscriber) { EventSubscriber.new }
+
+        let(:client) do
+          authorized_client.tap do |client|
+            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+          end
+        end
+
+        context 'when both are provided' do
+          let(:options) do
+            { name_only: true, authorized_collections: true }
+          end
+
+          let!(:result) do
+            database.list_collections(options)
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'passes original options to the server' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['nameOnly']).to eq(true)
+            expect(command['authorizedCollections']).to eq(true)
+          end
+        end
+
+        context 'when name_only is provided' do
+          let(:options) do
+            { name_only: false }
+          end
+
+          let!(:result) do
+            database.list_collections(options)
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'no options passed to server because false' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['nameOnly']).to be_nil
+            expect(command['authorizedCollections']).to be_nil
+          end
+        end
+
+        context 'when no options provided' do
+
+          let!(:result) do
+            database.list_collections
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'no options passed to server because none provided' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['nameOnly']).to be_nil
+            expect(command['authorizedCollections']).to be_nil
+          end
+        end
+      end
+    end
   end
 
   describe '#collections' do
@@ -254,8 +406,8 @@ describe Mongo::Database do
       end
 
       before do
-        database[:users].drop
-        database[:users].create
+        database['users'].drop
+        database['users'].create
       end
 
       it 'returns collection objects for each name' do
@@ -304,6 +456,91 @@ describe Mongo::Database do
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end
+
+    context 'when provided a filter' do
+      min_server_fcv '3.0'
+
+      let(:database) do
+        described_class.new(authorized_client, SpecConfig.instance.test_db)
+      end
+
+      let(:collection2) do
+        Mongo::Collection.new(database, 'users2')
+      end
+
+      before do
+        database['users1'].drop
+        database['users1'].create
+
+        database['users2'].drop
+        database['users2'].create
+      end
+
+      let(:result) do
+        database.collections(filter: { name: 'users2' })
+      end
+
+      it 'returns users2 collection' do
+        expect(result.length).to eq(1)
+        expect(database.collections).to include(collection2)
+      end
+    end
+
+    context 'when provided authorized_collections or not' do
+
+      context 'on server versions >= 4.0' do
+        min_server_fcv '4.0'
+
+        let(:database) do
+          described_class.new(client, SpecConfig.instance.test_db)
+        end
+
+        let(:subscriber) { EventSubscriber.new }
+
+        let(:client) do
+          authorized_client.tap do |client|
+            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+          end
+        end
+
+        context 'when authorized_collections are provided' do
+          let(:options) do
+            { authorized_collections: false }
+          end
+
+          let!(:result) do
+            database.collections(options)
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'authorized_collections not passed to server because false' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['nameOnly']).to eq(true)
+            expect(command['authorizedCollections']).to be_nil
+          end
+        end
+
+        context 'when no options are provided' do
+          let!(:result) do
+            database.collections
+          end
+
+          let(:events) do
+            subscriber.command_started_events('listCollections')
+          end
+
+          it 'authorized_collections not passed to server because not provided' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['authorizedCollections']).to be_nil
+          end
+        end
+      end
+    end
   end
 
   describe '#command' do

data/spec/mongo/distinguishing_semaphore_spec.rb

@@ -0,0 +1,63 @@
+require 'lite_spec_helper'
+
+describe Mongo::DistinguishingSemaphore do
+  let(:semaphore) do
+    described_class.new
+  end
+
+  it 'waits until signaled' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.signal
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'waits until broadcast' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.broadcast
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'times out' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(2)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    consumer.join
+
+    (Time.now - start_time).should > 1
+
+    result.should be false
+  end
+end

data/spec/mongo/error/operation_failure_spec.rb

@@ -227,6 +227,46 @@ describe Mongo::Error::OperationFailure do
         end
       end
 
+      context 'when the error code is 43 (CursorNotFound)' do
+        let(:error) { Mongo::Error::OperationFailure.new(nil, result, code: 43, code_name: 'CursorNotFound') }
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
+        context 'wire protocol < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
+        end
+
+        context 'wire protocol >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
+        end
+      end
+
       context 'not a getMore response' do
         let(:result) do
           Mongo::Operation::Result.new(

data/spec/mongo/index/view_spec.rb

@@ -261,7 +261,7 @@ describe Mongo::Index::View do
         context 'when commit quorum options are specified' do
           require_topology :replica_set, :sharded
           context 'on server versions >= 4.4' do
-            min_server_fcv '4.3'
+            min_server_fcv '4.4'
 
             let(:subscriber) { EventSubscriber.new }
 
@@ -776,7 +776,7 @@ describe Mongo::Index::View do
     context 'when providing commit_quorum option' do
       require_topology :replica_set, :sharded
       context 'on server versions >= 4.4' do
-        min_server_fcv '4.3'
+        min_server_fcv '4.4'
 
         let(:subscriber) { EventSubscriber.new }
 

data/spec/mongo/monitoring/event/server_description_changed_spec.rb

@@ -27,12 +27,9 @@ describe Mongo::Monitoring::Event::ServerDescriptionChanged do
   end
 
   describe '#summary' do
-    skip_if_linting
 
     it 'renders correctly' do
-      expect(topology).to receive(:server_descriptions).and_return({
-        '127.0.0.1:27017' => Mongo::Server::Description.new(Mongo::Address.new('127.0.0.1:27017'))})
-      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 topology=Unknown[127.0.0.1:27017] prev=#{previous_desc.inspect} new=#{updated_desc.inspect}>")
+      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 prev=UNKNOWN new=UNKNOWN>")
     end
   end
 end

data/spec/mongo/protocol/msg_spec.rb

@@ -425,6 +425,16 @@ describe Mongo::Protocol::Msg do
         expect(message.serialize).to be_a(BSON::ByteBuffer)
       end
     end
+
+    [:more_to_come, :exhaust_allowed].each do |flag|
+      context "with #{flag} flag" do
+        let(:flags) { [flag] }
+
+        it "round trips #{flag} flag" do
+          expect(deserialized.flags).to eq(flags)
+        end
+      end
+    end
   end
 
   describe '#deserialize' do