mongo 2.12.4 → 2.13.0.beta1

data/spec/mongo/collection_spec.rb

@@ -2,8 +2,18 @@ require 'spec_helper'
 
 describe Mongo::Collection do
 
+  let(:subscriber) { EventSubscriber.new }
+
+  let(:client) do
+    authorized_client.tap do |client|
+      client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+    end
+  end
+
+  let(:authorized_collection) { client['collection_spec'] }
+
   before do
-    authorized_collection.drop
+    authorized_client['collection_spec'].drop
   end
 
   let(:collection_invalid_write_concern) do
@@ -14,10 +24,6 @@ describe Mongo::Collection do
     authorized_client[:validating]
   end
 
-  let(:client) do
-    authorized_client
-  end
-
   describe '#==' do
 
     let(:database) do
@@ -246,6 +252,7 @@ describe Mongo::Collection do
           authorized_client.with(client_options).tap do |client|
             expect(client.options[:read]).to eq(Mongo::Options::Redacted.new(
               mode: :primary_preferred))
+            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
           end
         end
 
@@ -278,12 +285,6 @@ describe Mongo::Collection do
             {read: { mode: :primary_preferred }}
           end
 
-          let(:subscriber) { EventSubscriber.new }
-
-          before do
-            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
-          end
-
           shared_examples_for "uses collection's read preference when reading" do
             it "uses collection's read preference when reading" do
               expect do
@@ -940,30 +941,6 @@ describe Mongo::Collection do
         it_behaves_like 'a failed operation using a session'
       end
     end
-
-    context 'when collation has a strength' do
-      min_server_fcv '3.4'
-
-      let(:band_collection) do
-        described_class.new(database, :bands)
-      end
-
-      before do
-        band_collection.delete_many
-        band_collection.insert_many([{ name: "Depeche Mode" }, { name: "New Order" }])
-      end
-
-      let(:options) do
-        { collation: { locale: 'en_US', strength: 2 } }
-      end
-      let(:band_result) do
-        band_collection.find({ name: 'DEPECHE MODE' }, options)
-      end
-
-      it 'finds Capitalize from UPPER CASE' do
-        expect(band_result.count_documents).to eq(1)
-      end
-    end
   end
 
   describe '#drop' do
@@ -1230,10 +1207,6 @@ describe Mongo::Collection do
           { session: session }
         end
 
-        let(:client) do
-          subscribed_client
-        end
-
         let(:session) do
           client.start_session
         end
@@ -1244,7 +1217,7 @@ describe Mongo::Collection do
 
         let(:command) do
           client[TEST_COLL].find({}, session: session).explain
-          EventSubscriber.started_events.find { |c| c.command_name == 'explain' }.command
+          subscriber.started_events.find { |c| c.command_name == 'explain' }.command
         end
 
         it 'sends the session id' do
@@ -1261,7 +1234,7 @@ describe Mongo::Collection do
 
         let(:command) do
           operation
-          EventSubscriber.started_events.find { |cmd| cmd.command_name == 'find' }.command
+          subscriber.started_events.find { |cmd| cmd.command_name == 'find' }.command
         end
 
         it_behaves_like 'an operation supporting causally consistent reads'
@@ -1461,7 +1434,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -1543,20 +1516,16 @@ describe Mongo::Collection do
     context 'when the documents are sent with OP_MSG' do
       min_server_fcv '3.6'
 
-      let(:client) do
-        subscribed_client
-      end
-
       let(:documents) do
         [{ '_id' => 1, 'name' => '1'*16777191 }, { '_id' => 'y' }]
       end
 
       before do
-        client[TEST_COLL].insert_many(documents)
+        authorized_collection.insert_many(documents)
       end
 
       let(:insert_events) do
-        EventSubscriber.started_events.select { |e| e.command_name == 'insert' }
+        subscriber.started_events.select { |e| e.command_name == 'insert' }
       end
 
       it 'sends the documents in one OP_MSG' do
@@ -1704,7 +1673,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -1914,7 +1883,7 @@ describe Mongo::Collection do
 
       let(:command) do
         operation
-        EventSubscriber.started_events.find { |cmd| cmd.command_name == 'aggregate' }.command
+        subscriber.started_events.find { |cmd| cmd.command_name == 'aggregate' }.command
       end
 
       it_behaves_like 'an operation supporting causally consistent reads'
@@ -2119,7 +2088,7 @@ describe Mongo::Collection do
 
         let(:command) do
           operation
-          EventSubscriber.started_events.find { |cmd| cmd.command_name == 'count' }.command
+          subscriber.started_events.find { |cmd| cmd.command_name == 'count' }.command
         end
 
         it_behaves_like 'an operation supporting causally consistent reads'
@@ -2237,7 +2206,7 @@ describe Mongo::Collection do
 
       let(:command) do
         operation
-        EventSubscriber.started_events.find { |cmd| cmd.command_name == 'distinct' }.command
+        subscriber.started_events.find { |cmd| cmd.command_name == 'distinct' }.command
       end
 
       it_behaves_like 'an operation supporting causally consistent reads'
@@ -2399,7 +2368,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -2571,7 +2540,7 @@ describe Mongo::Collection do
       it_behaves_like 'a failed operation using a session'
     end
 
-    context 'when unacknowledged writes is used with an explicit session' do
+    context 'when unacknowledged writes are used with an explicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
         authorized_collection.with(write: { w: 0 })
@@ -2584,10 +2553,10 @@ describe Mongo::Collection do
       it_behaves_like 'an explicit session with an unacknowledged write'
     end
 
-    context 'when unacknowledged writes is used with an implicit session' do
+    context 'when unacknowledged writes are used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -2755,7 +2724,6 @@ describe Mongo::Collection do
     end
 
     context 'when a session is not provided' do
-      let(:client) { subscribed_client }
       let(:collection) { client['test'] }
 
       let(:cursors) do
@@ -2772,7 +2740,7 @@ describe Mongo::Collection do
 
       let(:command) do
         operation
-        event = EventSubscriber.started_events.find { |cmd| cmd.command_name == 'parallelCollectionScan' }
+        event = subscriber.started_events.find { |cmd| cmd.command_name == 'parallelCollectionScan' }
         expect(event).not_to be_nil
         event.command
       end
@@ -2794,7 +2762,7 @@ describe Mongo::Collection do
 
       let(:command) do
         operation
-        event = EventSubscriber.started_events.find { |cmd| cmd.command_name == 'parallelCollectionScan' }
+        event = subscriber.started_events.find { |cmd| cmd.command_name == 'parallelCollectionScan' }
         expect(event).not_to be_nil
         event.command
       end
@@ -3197,7 +3165,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -3619,7 +3587,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do
@@ -3977,10 +3945,6 @@ describe Mongo::Collection do
     context 'when the documents are sent with OP_MSG' do
       min_server_fcv '3.6'
 
-      let(:client) do
-        subscribed_client
-      end
-
       let(:documents) do
         [{ '_id' => 1, 'name' => '1'*16777191 }, { '_id' => 'y' }]
       end
@@ -3991,7 +3955,7 @@ describe Mongo::Collection do
       end
 
       let(:update_events) do
-        EventSubscriber.started_events.select { |e| e.command_name == 'update' }
+        subscriber.started_events.select { |e| e.command_name == 'update' }
       end
 
       it 'sends the documents in one OP_MSG' do
@@ -4041,7 +4005,7 @@ describe Mongo::Collection do
     context 'when unacknowledged writes is used with an implicit session' do
 
       let(:collection_with_unacknowledged_write_concern) do
-        subscribed_client.with(write: { w: 0 })[TEST_COLL]
+        client.with(write: { w: 0 })[TEST_COLL]
       end
 
       let(:operation) do

data/spec/mongo/cursor/builder/get_more_command_spec.rb

@@ -10,8 +10,13 @@ describe Mongo::Cursor::Builder::GetMoreCommand do
       end
     end
 
+    let(:description) do
+      Mongo::Server::Description.new(double('description address'),
+        'minWireVersion' => 0, 'maxWireVersion' => 2)
+    end
+
     let(:result) do
-      Mongo::Operation::Result.new(reply)
+      Mongo::Operation::Result.new(reply, description)
     end
 
     let(:cursor) do

data/spec/mongo/cursor/builder/op_get_more_spec.rb

@@ -10,8 +10,13 @@ describe Mongo::Cursor::Builder::OpGetMore do
       end
     end
 
+    let(:description) do
+      Mongo::Server::Description.new(double('description address'),
+        'minWireVersion' => 0, 'maxWireVersion' => 2)
+    end
+
     let(:result) do
-      Mongo::Operation::Result.new(reply)
+      Mongo::Operation::Result.new(reply, description)
     end
 
     let(:view) do

data/spec/mongo/cursor/builder/op_kill_cursors_spec.rb

@@ -8,8 +8,13 @@ describe Mongo::Cursor::Builder::OpKillCursors do
     end
   end
 
+  let(:description) do
+    Mongo::Server::Description.new(double('description address'),
+      'minWireVersion' => 0, 'maxWireVersion' => 2)
+  end
+
   let(:result) do
-    Mongo::Operation::Result.new(reply)
+    Mongo::Operation::Result.new(reply, description)
   end
 
   let(:view) do

data/spec/mongo/cursor_spec.rb

@@ -434,6 +434,14 @@ describe Mongo::Cursor do
   context 'when an implicit session is used' do
     min_server_fcv '3.6'
 
+    let(:subscriber) { EventSubscriber.new }
+
+    let(:subscribed_client) do
+      authorized_client.tap do |client|
+        client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+      end
+    end
+
     let(:collection) do
       subscribed_client[TEST_COLL]
     end
@@ -456,7 +464,7 @@ describe Mongo::Cursor do
     end
 
     let(:find_events) do
-      EventSubscriber.started_events.select { |e| e.command_name == "find" }
+      subscriber.started_events.select { |e| e.command_name == "find" }
     end
 
     context 'when all results are retrieved in the first response' do

data/spec/mongo/database_spec.rb

@@ -335,8 +335,12 @@ describe Mongo::Database do
         client.start_session
       end
 
+      let(:subscriber) { EventSubscriber.new }
+
       let(:client) do
-        subscribed_client
+        authorized_client.tap do |client|
+          client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+        end
       end
 
       it_behaves_like 'an operation using a session'
@@ -344,7 +348,7 @@ describe Mongo::Database do
 
 
       let(:full_command) do
-        EventSubscriber.started_events.find { |cmd| cmd.command_name == 'ismaster' }.command
+        subscriber.started_events.find { |cmd| cmd.command_name == 'ismaster' }.command
       end
 
       it 'does not add a afterClusterTime field' do

data/spec/mongo/error/operation_failure_heavy_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Mongo::Error::OperationFailure do
+
+  describe '#write_concern_error' do
+    # Fail point will work on 4.0 mongod but requires 4.2 for mongos
+    min_server_fcv '4.2'
+    # Fail point must be set on the same server to which the query is sent
+    require_no_multi_shard
+
+    # https://github.com/mongodb/specifications/commit/7745234f93039a83ae42589a6c0cdbefcffa32fa
+    let(:fail_point_command) do
+     {
+       "configureFailPoint": "failCommand",
+       "data": {
+         "failCommands": ["insert"],
+         "writeConcernError": {
+           "code": 100,
+           "codeName": "UnsatisfiableWriteConcern",
+           "errmsg": "Not enough data-bearing nodes",
+           "errInfo": {
+             "writeConcern": {
+               "w": 2,
+               "wtimeout": 0,
+               "provenance": "clientSupplied"
+             }
+           }
+         }
+       },
+       "mode": { "times": 1 }
+     }
+    end
+
+    it 'exposes all server-provided fields' do
+      authorized_client.use('admin').command(fail_point_command)
+
+      begin
+        authorized_client['foo'].insert_one(test: 1)
+      rescue Mongo::Error::OperationFailure => exc
+      else
+        fail 'Expected an OperationFailure'
+      end
+
+      exc.write_concern_error_document.should == {
+        'code' => 100,
+        'codeName' => 'UnsatisfiableWriteConcern',
+        'errmsg' => 'Not enough data-bearing nodes',
+        'errInfo' => {
+          'writeConcern' => {
+            'w' => 2,
+            'wtimeout' => 0,
+            'provenance' => 'clientSupplied',
+          },
+        },
+      }
+    end
+  end
+end

data/spec/mongo/error/operation_failure_spec.rb

@@ -69,77 +69,113 @@ describe Mongo::Error::OperationFailure do
   end
 
   describe '#change_stream_resumable?' do
-    context 'when there is a network error' do
-      context 'getMore' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: socket exception',
-          Mongo::Operation::GetMore::Result.new(nil)) }
-
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to be true
+    context 'when there is a resumable code' do
+      context 'getMore response' do
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
         end
-      end
 
-      context 'not getMore' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: socket exception', nil) }
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          result,
+          :code => 91, :code_name => 'ShutdownInProgress') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to be false
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            expect(error.change_stream_resumable?).to eql(true)
+          end
         end
-      end
-    end
-
-    context 'when there is a resumable message' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: node is recovering',
-          Mongo::Operation::GetMore::Result.new(nil)) }
 
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            # Error code is not consulted with wire version >= 9
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
 
       context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: node is recovering', nil) }
-
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
-        end
-      end
-    end
-
-    context 'when there is a resumable code' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
-          :code => 91, :code_name => 'ShutdownInProgress') }
-
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
         end
-      end
 
-      context 'not a getMore response' do
         let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
           :code => 91, :code_name => 'ShutdownInProgress') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
     end
 
     context 'when there is a non-resumable code' do
       context 'getMore response' do
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
         let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
+          result,
           :code => 136, :code_name => 'CappedPositionLost') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
+        end
+
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
 
       context 'not a getMore response' do
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
         let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
           :code => 136, :code_name => 'CappedPositionLost') }
 
@@ -151,46 +187,68 @@ describe Mongo::Error::OperationFailure do
 
     context 'when there is a non-resumable label' do
       context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
-          :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => ['NonResumableChangeStreamError']) }
-
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
         end
-      end
 
-      context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          result,
           :code => 91, :code_name => 'ShutdownInProgress',
           :labels => ['NonResumableChangeStreamError']) }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            # Error code is consulted => error is resumable
+            expect(error.change_stream_resumable?).to eql(true)
+          end
         end
-      end
-    end
-
-    context 'when there is another label' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
-          :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => %w(TransientTransactionError)) }
 
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            # Error code is not consulted, there is no resumable label =>
+            # error is not resumable
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
 
       context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          result,
           :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => %w(TransientTransactionError)) }
+          :labels => ['NonResumableChangeStreamError']) }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
     end
@@ -230,7 +288,7 @@ describe Mongo::Error::OperationFailure do
       end
 
       let(:result) do
-        Mongo::Operation::Result.new(reply)
+        Mongo::Operation::Result.new(reply, Mongo::Server::Description.new(''))
       end
 
       subject do