mongo 2.12.4 → 2.13.0.beta1

data/spec/mongo/collection/view/change_stream_spec.rb

@@ -467,324 +467,6 @@ describe Mongo::Collection::View::ChangeStream do
     end
   end
 
-  context 'when an error is encountered the first time the command is run' do
-    include PrimarySocket
-
-    before do
-      expect(primary_socket).to receive(:write).and_raise(error).once
-    end
-
-    let(:document) do
-      change_stream.to_enum.next
-    end
-
-    shared_examples_for 'a resumable change stream' do
-
-      before do
-        expect(view.send(:server_selector)).to receive(:select_server).twice.and_call_original
-        change_stream
-        collection.insert_one(a: 1)
-      end
-
-      it 'runs the command again while using the same read preference and caches the resume token' do
-        expect(document[:fullDocument][:a]).to eq(1)
-        expect(change_stream_document[:resumeAfter]).to eq(document[:_id])
-      end
-
-      context 'when provided a session' do
-
-        let(:options) do
-          { session: session}
-        end
-
-        let(:session) do
-          client.start_session
-        end
-
-        before do
-          change_stream.to_enum.next
-        end
-
-        it 'does not close the session' do
-          expect(session.ended?).to be(false)
-        end
-      end
-    end
-
-    shared_examples_for 'a non-resumed change stream' do
-      it 'does not run the command again and instead raises the error' do
-        expect do
-          document
-        end.to raise_exception(error)
-      end
-    end
-
-    context 'when the error is a resumable error' do
-
-      context 'when the error is a SocketError' do
-
-        let(:error) do
-          Mongo::Error::SocketError
-        end
-
-        it_behaves_like 'a non-resumed change stream'
-      end
-
-      context 'when the error is a SocketTimeoutError' do
-
-        let(:error) do
-          Mongo::Error::SocketTimeoutError
-        end
-
-        it_behaves_like 'a non-resumed change stream'
-      end
-
-      context "when the error is a 'not master' error" do
-
-        let(:error) do
-          Mongo::Error::OperationFailure.new('not master')
-        end
-
-        it_behaves_like 'a non-resumed change stream'
-      end
-
-      context "when the error is a 'node is recovering' error" do
-
-        let(:error) do
-          Mongo::Error::OperationFailure.new('node is recovering')
-        end
-
-        it_behaves_like 'a non-resumed change stream'
-      end
-    end
-
-    context 'when the error is another server error' do
-
-      let(:error) do
-        Mongo::Error::MissingResumeToken
-      end
-
-      before do
-        expect(view.send(:server_selector)).to receive(:select_server).and_call_original
-      end
-
-      it_behaves_like 'a non-resumed change stream'
-
-      context 'when provided a session' do
-
-        let(:options) do
-          { session: session}
-        end
-
-        let(:session) do
-          client.start_session
-        end
-
-        before do
-          expect do
-            change_stream
-          end.to raise_error(error)
-        end
-
-        it 'does not close the session' do
-          expect(session.ended?).to be(false)
-        end
-      end
-    end
-  end
-
-  context 'when a killCursors command is issued for the cursor' do
-    context 'using Enumerable' do
-      only_mri
-
-      before do
-        change_stream
-        collection.insert_one(a:1)
-        enum.next
-        collection.insert_one(a:2)
-      end
-
-      let(:enum) do
-        change_stream.to_enum
-      end
-
-      it 'should create a new cursor and resume' do
-        original_cursor_id = cursor.id
-
-        client.use(:admin).command({
-          killCursors: collection.name,
-          cursors: [cursor.id]
-        })
-
-        document = enum.next
-        expect(document[:fullDocument][:a]).to eq(2)
-
-        new_cursor_id = change_stream.instance_variable_get(:@cursor).id
-        expect(new_cursor_id).not_to eq(original_cursor_id)
-      end
-    end
-
-    context 'using try_next' do
-      before do
-        change_stream
-        collection.insert_one(a:1)
-        expect(change_stream.try_next).to be_a(BSON::Document)
-        collection.insert_one(a:2)
-      end
-
-      it 'should create a new cursor and resume' do
-        original_cursor_id = cursor.id
-
-        client.use(:admin).command({
-          killCursors: collection.name,
-          cursors: [cursor.id]
-        })
-
-        document = change_stream.try_next
-        expect(document).to be_a(BSON::Document)
-        expect(document[:fullDocument][:a]).to eq(2)
-
-        new_cursor_id = change_stream.instance_variable_get(:@cursor).id
-        expect(new_cursor_id).not_to eq(original_cursor_id)
-      end
-    end
-  end
-
-  context 'when a server error is encountered during a getMore' do
-    fails_on_jruby
-
-    context 'when the error is a resumable error' do
-
-      shared_examples_for 'a change stream that encounters an error from a getMore' do
-
-        before do
-          change_stream
-          collection.insert_one(a: 1)
-          enum.next
-          collection.insert_one(a: 2)
-          expect(cursor).to receive(:get_more).once.and_raise(error)
-          expect(cursor).to receive(:close).and_call_original
-          expect(view.send(:server_selector)).to receive(:select_server).once.and_call_original
-          expect(Mongo::Operation::Aggregate).to receive(:new).and_call_original
-        end
-
-        let(:enum) do
-          change_stream.to_enum
-        end
-
-        let(:document) do
-          enum.next
-        end
-
-        it 'runs the command again while using the same read preference and caching the resume token' do
-          expect(document[:fullDocument][:a]).to eq(2)
-          expect(change_stream_document[:resumeAfter]).to eq(document[:_id])
-        end
-
-        context 'when provided a session' do
-
-          let(:options) do
-            { session: session}
-          end
-
-          let(:session) do
-            client.start_session
-          end
-
-          before do
-            enum.next
-          end
-
-          it 'does not close the session' do
-            expect(session.ended?).to be(false)
-          end
-        end
-      end
-
-      context 'when the error is a SocketError' do
-
-        let(:error) do
-          Mongo::Error::SocketError
-        end
-
-        it_behaves_like 'a change stream that encounters an error from a getMore'
-      end
-
-      context 'when the error is a SocketTimeoutError' do
-
-        let(:error) do
-          Mongo::Error::SocketTimeoutError
-        end
-
-        it_behaves_like 'a change stream that encounters an error from a getMore'
-      end
-
-      context "when the error is 'not master'" do
-
-        let(:error) do
-          Mongo::Error::OperationFailure.new('not master',
-            Mongo::Operation::GetMore::Result.new(nil))
-        end
-
-        it_behaves_like 'a change stream that encounters an error from a getMore'
-      end
-
-      context "when the error is 'node is recovering'" do
-
-        let(:error) do
-          Mongo::Error::OperationFailure.new('node is recovering',
-            Mongo::Operation::GetMore::Result.new(nil))
-        end
-
-        it_behaves_like 'a change stream that encounters an error from a getMore'
-      end
-    end
-
-    context 'when the error is another server error' do
-
-      before do
-        change_stream
-        collection.insert_one(a: 1)
-        enum.next
-        collection.insert_one(a: 2)
-        expect(cursor).to receive(:get_more).and_raise(Mongo::Error::MissingResumeToken)
-        expect(cursor).to receive(:close).and_call_original
-        expect(Mongo::Operation::Aggregate).not_to receive(:new)
-      end
-
-      let(:enum) do
-        change_stream.to_enum
-      end
-
-      it 'does not run the command again and instead raises the error' do
-        expect {
-          enum.next
-        }.to raise_exception(Mongo::Error::MissingResumeToken)
-      end
-
-      context 'when provided a session' do
-
-        let(:options) do
-          { session: session}
-        end
-
-        let(:session) do
-          client.start_session
-        end
-
-        before do
-          expect do
-            enum.next
-          end.to raise_error(Mongo::Error::MissingResumeToken)
-        end
-
-        it 'does not close the session' do
-          expect(session.ended?).to be(false)
-        end
-      end
-    end
-  end
-
   describe '#inspect' do
 
     it 'includes the Ruby object_id in the formatted string' do

data/spec/mongo/collection/view/iterable_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Mongo::Collection::View::Iterable do
+  let(:selector) do
+    {}
+  end
+
+  let(:options) do
+    {}
+  end
+
+  let(:view) do
+    Mongo::Collection::View.new(authorized_collection, selector, options)
+  end
+
+  before do
+    authorized_collection.drop
+  end
+
+  describe '#each' do
+    context 'when allow_disk_use is provided' do
+      let(:options) { { allow_disk_use: true } }
+
+      # Other cases are adequately covered by spec tests.
+      context 'on server versions < 3.2' do
+        max_server_fcv '3.0'
+
+        it 'raises an exception' do
+          expect do
+            view.each do |document|
+              #Do nothing
+            end
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the allow_disk_use option on this command/)
+        end
+      end
+    end
+  end
+end

data/spec/mongo/collection/view/map_reduce_spec.rb

@@ -239,12 +239,16 @@ describe Mongo::Collection::View::MapReduce do
             Mongo::Collection::View.new(client[TEST_COLL], selector, view_options)
           end
 
+          let(:subscriber) { EventSubscriber.new }
+
           let(:client) do
-            subscribed_client
+            authorized_client.tap do |client|
+              client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+            end
           end
 
           let(:find_command) do
-            EventSubscriber.started_events[-1].command
+            subscriber.started_events[-1].command
           end
 
           before do

data/spec/mongo/collection/view/readable_spec.rb

@@ -68,6 +68,20 @@ describe Mongo::Collection::View::Readable do
     end
   end
 
+  describe '#allow_disk_use' do
+    let(:new_view) do
+      view.allow_disk_use
+    end
+
+    it 'sets the flag' do
+      expect(new_view.options[:allow_disk_use]).to be true
+    end
+
+    it 'returns the new View' do
+      expect(new_view).not_to be(view)
+    end
+  end
+
   describe '#aggregate' do
 
      let(:documents) do
@@ -192,7 +206,7 @@ describe Mongo::Collection::View::Readable do
 
       let(:command) do
         operation
-        EventSubscriber.started_events.find { |cmd| cmd.command_name == 'mapReduce' }.command
+        subscriber.started_events.find { |cmd| cmd.command_name == 'mapReduce' }.command
       end
 
       it_behaves_like 'an operation supporting causally consistent reads'

data/spec/mongo/collection/view/writable_spec.rb

@@ -10,8 +10,12 @@ describe Mongo::Collection::View::Writable do
     {}
   end
 
+  let(:view_collection) do
+    authorized_collection
+  end
+
   let(:view) do
-    Mongo::Collection::View.new(authorized_collection, selector, options)
+    Mongo::Collection::View.new(view_collection, selector, options)
   end
 
   before do
@@ -24,6 +28,32 @@ describe Mongo::Collection::View::Writable do
       authorized_collection.insert_many([{ field: 'test1' }])
     end
 
+    context 'when hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 4.2' do
+        max_server_fcv '4.0'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.find_one_and_delete(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.find_one_and_delete(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
+
     context 'when a matching document is found' do
 
       let(:selector) do
@@ -218,6 +248,32 @@ describe Mongo::Collection::View::Writable do
       authorized_collection.insert_many([{ field: 'test1', other: 'sth' }])
     end
 
+    context 'when hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 4.2' do
+        max_server_fcv '4.0'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.find_one_and_replace({ field: 'testing' }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.find_one_and_replace({ field: 'testing' }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
+
     context 'when a matching document is found' do
 
       let(:selector) do
@@ -435,6 +491,32 @@ describe Mongo::Collection::View::Writable do
       authorized_collection.insert_many([{ field: 'test1' }])
     end
 
+    context 'when hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 4.2' do
+        max_server_fcv '4.0'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.find_one_and_update({ '$set' => { field: 'testing' } }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.find_one_and_update({ '$set' => { field: 'testing' } }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
+
     context 'when a matching document is found' do
 
       let(:selector) do
@@ -625,6 +707,31 @@ describe Mongo::Collection::View::Writable do
   end
 
   describe '#delete_many' do
+    context 'when a hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 3.4' do
+        max_server_fcv '3.2'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.delete_many(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.delete_many(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
 
     context 'when a selector was provided' do
 
@@ -787,6 +894,31 @@ describe Mongo::Collection::View::Writable do
   end
 
   describe '#delete_one' do
+    context 'when a hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 3.4' do
+        max_server_fcv '3.2'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.delete_one(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.delete_many(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
 
     context 'when a selector was provided' do
 
@@ -950,6 +1082,31 @@ describe Mongo::Collection::View::Writable do
   end
 
   describe '#replace_one' do
+    context 'when a hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 3.4' do
+        max_server_fcv '3.2'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.replace_one({ field: 'testing' }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.delete_many(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
 
     context 'when a selector was provided' do
 
@@ -1182,6 +1339,31 @@ describe Mongo::Collection::View::Writable do
   end
 
   describe '#update_many' do
+    context 'when a hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 3.4' do
+        max_server_fcv '3.2'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.update_many({ '$set' => { field: 'testing' } }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.delete_many(hint: '_id_')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
 
     context 'when a selector was provided' do
 
@@ -1420,6 +1602,31 @@ describe Mongo::Collection::View::Writable do
   end
 
   describe '#update_one' do
+    context 'when a hint option is provided' do
+      # Functionality on more recent servers is sufficiently covered by spec tests.
+      context 'on server versions < 3.4' do
+        max_server_fcv '3.2'
+
+        it 'raises a client-side exception' do
+          expect do
+            view.update_one({ '$set' => { field: 'testing' } }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+        end
+      end
+
+      context 'when the write concern is unacknowledged' do
+        let(:view_collection) do
+          client = authorized_client.with(write_concern: { w: 0 })
+          client[authorized_collection.name]
+        end
+
+        it 'raises a client-side error' do
+          expect do
+            view.update_one({ '$set' => { field: 'testing' } }, { hint: '_id_' })
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+        end
+      end
+    end
 
     context 'when a selector was provided' do