mongo 2.12.1 → 2.13.0

data/spec/mongo/index/view_spec.rb

@@ -258,6 +258,148 @@ describe Mongo::Index::View do
           end
         end
 
+        context 'when commit quorum options are specified' do
+          require_topology :replica_set, :sharded
+          context 'on server versions >= 4.4' do
+            min_server_fcv '4.4'
+
+            let(:subscriber) { EventSubscriber.new }
+
+            let(:client) do
+              authorized_client.tap do |client|
+                client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+              end
+            end
+
+            let(:authorized_collection) { client['view-subscribed'] }
+
+            context 'when commit_quorum value is supported' do
+              let!(:result) do
+                view.create_many(
+                  { key: { random: 1 }, unique: true },
+                  { key: { testing: -1 }, unique: true },
+                  { commit_quorum: 'majority' }
+                )
+              end
+
+              let(:events) do
+                subscriber.command_started_events('createIndexes')
+              end
+
+              it 'returns ok' do
+                expect(result).to be_successful
+              end
+
+              it 'passes the commit_quorum option to the server' do
+                expect(events.length).to eq(1)
+                command = events.first.command
+                expect(command['commitQuorum']).to eq('majority')
+              end
+            end
+
+            context 'when commit_quorum value is not supported' do
+              it 'raises an exception' do
+                expect do
+                  view.create_many(
+                    { key: { random: 1 }, unique: true },
+                    { key: { testing: -1 }, unique: true },
+                    { commit_quorum: 'unsupported-value' }
+                  )
+                end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration/)
+              end
+            end
+          end
+
+          context 'on server versions < 4.4' do
+            max_server_fcv '4.2'
+
+            it 'raises an exception' do
+              expect do
+                view.create_many(
+                  { key: { random: 1 }, unique: true },
+                  { key: { testing: -1 }, unique: true },
+                  { commit_quorum: 'majority' }
+                )
+              end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the commit_quorum option/)
+            end
+          end
+        end
+
+        context 'when hidden is specified' do
+          let(:index) { view.get('with_hidden_1') }
+
+          context 'on server versions <= 3.2' do
+            # DRIVERS-1220 Server versions 3.2 and older do not perform any option
+            # checking on index creation. The server will allow the user to create
+            # the index with the hidden option, but the server does not support this
+            # option and will not use it.
+            max_server_fcv '3.2'
+
+            let!(:result) do
+              view.create_many({ key: { with_hidden: 1 }, hidden: true })
+            end
+
+            it 'returns ok' do
+              expect(result).to be_successful
+            end
+
+            it 'creates an index' do
+              expect(index).to_not be_nil
+            end
+          end
+
+          context 'on server versions between 3.4 and 4.2' do
+            max_server_fcv '4.2'
+            min_server_fcv '3.4'
+
+            it 'raises an exception' do
+              expect do
+                view.create_many({ key: { with_hidden: 1 }, hidden: true })
+              end.to raise_error(/The field 'hidden' is not valid for an index specification/)
+            end
+          end
+
+          context 'on server versions >= 4.4' do
+            min_server_fcv '4.4'
+
+            context 'when hidden is true' do
+              let!(:result) do
+                view.create_many({ key: { with_hidden: 1 }, hidden: true })
+              end
+
+              it 'returns ok' do
+                expect(result).to be_successful
+              end
+
+              it 'creates an index' do
+                expect(index).to_not be_nil
+              end
+
+              it 'applies the hidden option to the index' do
+                expect(index['hidden']).to be true
+              end
+            end
+
+            context 'when hidden is false' do
+              let!(:result) do
+                view.create_many({ key: { with_hidden: 1 }, hidden: false })
+              end
+
+              it 'returns ok' do
+                expect(result).to be_successful
+              end
+
+              it 'creates an index' do
+                expect(index).to_not be_nil
+              end
+
+              it 'does not apply the hidden option to the index' do
+                expect(index['hidden']).to be_nil
+              end
+            end
+          end
+        end
+
         context 'when collation is specified' do
           min_server_fcv '3.4'
 
@@ -505,6 +647,25 @@ describe Mongo::Index::View do
         end
       end
     end
+
+    context 'when using bucket option' do
+
+      let(:spec) do
+        { 'any' => 1 }
+      end
+
+      let(:result) do
+        view.create_many([key: spec, bucket_size: 1])
+      end
+
+      it 'warns of deprecation' do
+        RSpec::Mocks.with_temporary_scope do
+          view.client.should receive(:log_warn).and_call_original
+
+          result
+        end
+      end
+    end
   end
 
   describe '#create_one' do
@@ -592,6 +753,25 @@ describe Mongo::Index::View do
           expect(result).to be_successful
         end
       end
+
+      context 'when using bucket option' do
+
+        let(:spec) do
+          { 'any' => 1 }
+        end
+
+        let(:result) do
+          view.create_one(spec, bucket_size: 1)
+        end
+
+        it 'warns of deprecation' do
+          RSpec::Mocks.with_temporary_scope do
+            view.client.should receive(:log_warn).and_call_original
+
+            result
+          end
+        end
+      end
     end
 
     context 'when index creation fails' do
@@ -667,6 +847,138 @@ describe Mongo::Index::View do
         expect(indexes[:partialFilterExpression]).to eq(expression)
       end
     end
+
+    context 'when providing hidden option' do
+      let(:index) { view.get('with_hidden_1') }
+
+      context 'on server versions <= 3.2' do
+        # DRIVERS-1220 Server versions 3.2 and older do not perform any option
+        # checking on index creation. The server will allow the user to create
+        # the index with the hidden option, but the server does not support this
+        # option and will not use it.
+        max_server_fcv '3.2'
+
+        let!(:result) do
+          view.create_one({ 'with_hidden' => 1 }, { hidden: true })
+        end
+
+        it 'returns ok' do
+          expect(result).to be_successful
+        end
+
+        it 'creates an index' do
+          expect(index).to_not be_nil
+        end
+      end
+
+      context 'on server versions between 3.4 and 4.2' do
+        max_server_fcv '4.2'
+        min_server_fcv '3.4'
+
+        it 'raises an exception' do
+          expect do
+            view.create_one({ 'with_hidden' => 1 }, { hidden: true })
+          end.to raise_error(/The field 'hidden' is not valid for an index specification/)
+        end
+      end
+
+      context 'on server versions >= 4.4' do
+        min_server_fcv '4.4'
+
+        context 'when hidden is true' do
+          let!(:result) { view.create_one({ 'with_hidden' => 1 }, { hidden: true }) }
+
+          it 'returns ok' do
+            expect(result).to be_successful
+          end
+
+          it 'creates an index' do
+            expect(index).to_not be_nil
+          end
+
+          it 'applies the hidden option to the index' do
+            expect(index['hidden']).to be true
+          end
+        end
+
+        context 'when hidden is false' do
+          let!(:result) { view.create_one({ 'with_hidden' => 1 }, { hidden: false }) }
+
+          it 'returns ok' do
+            expect(result).to be_successful
+          end
+
+          it 'creates an index' do
+            expect(index).to_not be_nil
+          end
+
+          it 'does not apply the hidden option to the index' do
+            expect(index['hidden']).to be_nil
+          end
+        end
+      end
+    end
+
+    context 'when providing commit_quorum option' do
+      require_topology :replica_set, :sharded
+      context 'on server versions >= 4.4' do
+        min_server_fcv '4.4'
+
+        let(:subscriber) { EventSubscriber.new }
+
+        let(:client) do
+          authorized_client.tap do |client|
+            client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+          end
+        end
+
+        let(:authorized_collection) { client['view-subscribed'] }
+
+        let(:indexes) do
+          authorized_collection.indexes.get('x_1')
+        end
+
+        context 'when commit_quorum value is supported' do
+          let!(:result) { view.create_one({ 'x' => 1 }, commit_quorum: 'majority') }
+
+          it 'returns ok' do
+            expect(result).to be_successful
+          end
+
+          it 'creates an index' do
+            expect(indexes).to_not be_nil
+          end
+
+          let(:events) do
+            subscriber.command_started_events('createIndexes')
+          end
+
+          it 'passes the commit_quorum option to the server' do
+            expect(events.length).to eq(1)
+            command = events.first.command
+            expect(command['commitQuorum']).to eq('majority')
+          end
+        end
+
+        context 'when commit_quorum value is not supported' do
+          it 'raises an exception' do
+            expect do
+              view.create_one({ 'x' => 1 }, commit_quorum: 'unsupported-value')
+            end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration/)
+          end
+        end
+      end
+
+      context 'on server versions < 4.4' do
+        max_server_fcv '4.2'
+
+        it 'raises an exception' do
+          expect do
+            view.create_one({ 'x' => 1 }, commit_quorum: 'majority')
+          end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the commit_quorum option/)
+        end
+      end
+    end
   end
 
   describe '#get' do

data/spec/mongo/monitoring/event/server_description_changed_spec.rb

@@ -27,12 +27,9 @@ describe Mongo::Monitoring::Event::ServerDescriptionChanged do
   end
 
   describe '#summary' do
-    skip_if_linting
 
     it 'renders correctly' do
-      expect(topology).to receive(:server_descriptions).and_return({
-        '127.0.0.1:27017' => Mongo::Server::Description.new(Mongo::Address.new('127.0.0.1:27017'))})
-      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 topology=Unknown[127.0.0.1:27017] prev=#{previous_desc.inspect} new=#{updated_desc.inspect}>")
+      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 prev=UNKNOWN new=UNKNOWN>")
     end
   end
 end

data/spec/mongo/operation/aggregate/result_spec.rb

@@ -2,8 +2,13 @@ require 'spec_helper'
 
 describe Mongo::Operation::Aggregate::Result do
 
+  let(:description) do
+    Mongo::Server::Description.new(double('description address'),
+      'minWireVersion' => 0, 'maxWireVersion' => 2)
+  end
+
   let(:result) do
-    described_class.new(reply)
+    described_class.new(reply, description)
   end
 
   let(:cursor_id) { 0 }

data/spec/mongo/operation/delete/bulk_spec.rb

@@ -99,7 +99,9 @@ describe Mongo::Operation::Delete do
         end
 
         it 'deletes the document from the database' do
-          op.bulk_execute(authorized_primary, client: nil)
+          authorized_primary.with_connection do |connection|
+            op.bulk_execute(connection, client: nil)
+          end
           expect(authorized_collection.find.count).to eq(1)
         end
       end
@@ -122,7 +124,9 @@ describe Mongo::Operation::Delete do
         end
 
         it 'deletes the documents from the database' do
-          op.bulk_execute(authorized_primary, client: nil)
+          authorized_primary.with_connection do |connection|
+            op.bulk_execute(connection, client: nil)
+          end
           expect(authorized_collection.find.count).to eq(0)
         end
       end
@@ -157,7 +161,9 @@ describe Mongo::Operation::Delete do
           end
 
           it 'aborts after first error' do
-            failing_delete.bulk_execute(authorized_primary, client: nil)
+            authorized_primary.with_connection do |connection|
+              failing_delete.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find.count).to eq(2)
           end
         end
@@ -169,7 +175,9 @@ describe Mongo::Operation::Delete do
           end
 
           it 'aborts after first error' do
-            failing_delete.bulk_execute(authorized_primary, client: nil)
+            authorized_primary.with_connection do |connection|
+              failing_delete.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find.count).to eq(2)
           end
         end
@@ -205,7 +213,9 @@ describe Mongo::Operation::Delete do
           end
 
           it 'does not abort after first error' do
-            failing_delete.bulk_execute(authorized_primary, client: nil)
+            authorized_primary.with_connection do |connection|
+              failing_delete.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find.count).to eq(1)
           end
         end
@@ -217,7 +227,9 @@ describe Mongo::Operation::Delete do
           end
 
           it 'does not abort after first error' do
-            failing_delete.bulk_execute(authorized_primary, client: nil)
+            authorized_primary.with_connection do |connection|
+              failing_delete.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find.count).to eq(1)
           end
         end

data/spec/mongo/operation/delete/op_msg_spec.rb

@@ -20,6 +20,15 @@ describe Mongo::Operation::Delete::OpMsg do
 
   let(:op) { described_class.new(spec) }
 
+  let(:connection) do
+    double('connection').tap do |connection|
+      allow(connection).to receive(:server).and_return(authorized_primary)
+      allow(connection).to receive(:features).and_return(authorized_primary.features)
+      allow(connection).to receive(:description).and_return(authorized_primary.description)
+      allow(connection).to receive(:cluster_time).and_return(authorized_primary.cluster_time)
+    end
+  end
+
   describe '#initialize' do
 
     context 'spec' do
@@ -62,6 +71,8 @@ describe Mongo::Operation::Delete::OpMsg do
   end
 
   describe 'write concern' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when write concern is not specified' do
 
@@ -74,19 +85,21 @@ describe Mongo::Operation::Delete::OpMsg do
       end
 
       it 'does not include write concern in the selector' do
-        expect(op.send(:command, authorized_primary)[:writeConcern]).to be_nil
+        expect(op.send(:command, connection)[:writeConcern]).to be_nil
       end
     end
 
     context 'when write concern is specified' do
 
       it 'includes write concern in the selector' do
-        expect(op.send(:command, authorized_primary)[:writeConcern]).to eq(write_concern.options)
+        expect(op.send(:command, connection)[:writeConcern]).to eq(write_concern.options)
       end
     end
   end
 
   describe '#message' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when the server supports OP_MSG' do
 
@@ -119,7 +132,7 @@ describe Mongo::Operation::Delete::OpMsg do
         it 'creates the correct OP_MSG message' do
           authorized_client.command(ping:1)
           expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-          op.send(:message, authorized_primary)
+          op.send(:message, connection)
         end
       end
 
@@ -134,7 +147,7 @@ describe Mongo::Operation::Delete::OpMsg do
         it 'creates the correct OP_MSG message' do
           authorized_client.command(ping:1)
           expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-          op.send(:message, authorized_primary)
+          op.send(:message, connection)
         end
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
@@ -149,20 +162,15 @@ describe Mongo::Operation::Delete::OpMsg do
 
           before do
             session.instance_variable_set(:@options, { implicit: true })
-            # Topology is standalone, hence there is exactly one server
-            authorized_primary.monitor.stop!
           end
 
           it 'creates the correct OP_MSG message' do
             RSpec::Mocks.with_temporary_scope do
-              # Override description as it gets replaced on every connection
-              description = authorized_primary.description
-              allow(authorized_primary).to receive(:description).and_return(description)
-              allow(description.features).to receive(:sessions_enabled?).and_return(false)
+              expect(connection.features).to receive(:sessions_enabled?).and_return(false)
 
               expect(expected_global_args[:session]).to be nil
               expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end
@@ -195,7 +203,7 @@ describe Mongo::Operation::Delete::OpMsg do
             it 'does not send a session id in the command' do
               authorized_client.command(ping:1)
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
 
@@ -212,7 +220,7 @@ describe Mongo::Operation::Delete::OpMsg do
             it 'creates the correct OP_MSG message' do
               authorized_client.command(ping:1)
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end
@@ -236,7 +244,7 @@ describe Mongo::Operation::Delete::OpMsg do
             authorized_client.command(ping:1)
             RSpec::Mocks.with_temporary_scope do
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end