mongo 2.12.1 → 2.13.0

data/lib/mongo/collection/view/iterable.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2019 MongoDB, Inc.
+# Copyright (C) 2014-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -78,9 +78,15 @@ module Mongo
         private
 
         def initial_query_op(server, session)
-          if server.features.find_command_enabled?
+          if server.with_connection { |connection| connection.features }.find_command_enabled?
             initial_command_op(session)
           else
+            # Server versions that do not have the find command feature
+            # (versions older than 3.2) do not support the allow_disk_use option
+            # but perform no validation and will not raise an error if it is
+            # specified. If the allow_disk_use option is specified, raise an error
+            # to alert the user.
+            raise Error::UnsupportedOption.allow_disk_use_error if options.key?(:allow_disk_use)
             Operation::Find.new(Builder::OpQuery.new(self).specification)
           end
         end

data/lib/mongo/collection/view/map_reduce.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2019 MongoDB, Inc.
+# Copyright (C) 2014-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -225,7 +225,10 @@ module Mongo
         end
 
         def valid_server?(server)
-          server.standalone? || server.mongos? || server.primary? || secondary_ok?
+          description = server.with_connection do |connection|
+            connection.description
+          end
+          description.standalone? || description.mongos? || description.primary? || secondary_ok?
         end
 
         def secondary_ok?
@@ -251,7 +254,7 @@ module Mongo
         end
 
         def fetch_query_op(server, session)
-          if server.features.find_command_enabled?
+          if server.with_connection { |connection| connection.features }.find_command_enabled?
             Operation::Find.new(find_command_spec(session))
           else
             Operation::Find.new(fetch_query_spec)
@@ -263,7 +266,7 @@ module Mongo
         end
 
         def validate_collation!(server)
-          if (view.options[:collation] || options[:collation]) && !server.features.collation_enabled?
+          if (view.options[:collation] || options[:collation]) && !server.with_connection { |connection| connection.features }.collation_enabled?
             raise Error::UnsupportedCollation.new
           end
         end

data/lib/mongo/collection/view/readable.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2019 MongoDB, Inc.
+# Copyright (C) 2014-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -48,6 +48,14 @@ module Mongo
           Aggregation.new(self, pipeline, options)
         end
 
+        # Allows the server to write temporary data to disk while executing
+        # a find operation.
+        #
+        # @return [ View ] The new view.
+        def allow_disk_use
+          configure(:allow_disk_use, true)
+        end
+
         # Allows the query to get partial results if some shards are down.
         #
         # @example Allow partial results.
@@ -185,7 +193,9 @@ module Mongo
           pipeline << { :'$limit' => opts[:limit] } if opts[:limit]
           pipeline << { :'$group' => { _id: 1, n: { :'$sum' => 1 } } }
 
-          opts.select! { |k, _| [:hint, :max_time_ms, :read, :collation, :session].include?(k) }
+          opts = opts.select { |k, _| [:hint, :max_time_ms, :read, :collation, :session].include?(k) }
+          opts[:collation] ||= collation
+
           first = aggregate(pipeline, opts).first
           return 0 unless first
           first['n'].to_i
@@ -603,7 +613,7 @@ module Mongo
                   :session => session,
                 }.merge!(options))
           cmd.execute(server, client: client).cursor_ids.map do |cursor_id|
-            result = if server.features.find_command_enabled?
+            result = if server.with_connection { |connection| connection.features }.find_command_enabled?
               Operation::GetMore.new({
                 :selector => {:getMore => BSON::Int64.new(cursor_id),
                              :collection => collection.name},

data/lib/mongo/collection/view/writable.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2019 MongoDB, Inc.
+# Copyright (C) 2014-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -39,10 +39,10 @@ module Mongo
         # @option opts [ Hash ] :projection The fields to include or exclude in the returned doc.
         # @option opts [ Hash ] :sort The key and direction pairs by which the result set
         #   will be sorted.
-        # @option opts [ Hash ] :write_concern The write concern options.
-        #   Defaults to the collection's write concern.
         # @option opts [ Hash ] :collation The collation to use.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
         #
         # @return [ BSON::Document, nil ] The document, if found.
         #
@@ -52,12 +52,17 @@ module Mongo
           cmd[:fields] = projection if projection
           cmd[:sort] = sort if sort
           cmd[:maxTimeMS] = max_time_ms if max_time_ms
+          if opts[:bypass_document_validation]
+            cmd[:bypassDocumentValidation] = true
+          end
 
           with_session(opts) do |session|
             applied_write_concern = applied_write_concern(session)
             cmd[:writeConcern] = applied_write_concern.options if applied_write_concern
             write_with_retry(session, applied_write_concern) do |server, txn_num|
               apply_collation!(cmd, server, opts)
+              apply_hint!(cmd, server, opts.merge(write_concern: applied_write_concern))
+
               Operation::Command.new(
                   :selector => cmd,
                   :db_name => database.name,
@@ -83,9 +88,9 @@ module Mongo
         # @option opts [ true, false ] :upsert Whether to upsert if the document doesn't exist.
         # @option opts [ true, false ] :bypass_document_validation Whether or
         #   not to skip document level validation.
-        # @option opts [ Hash ] :write_concern The write concern options.
-        #   Defaults to the collection's write concern.
         # @option opts [ Hash ] :collation The collation to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
         #
         # @return [ BSON::Document ] The document.
         #
@@ -111,12 +116,12 @@ module Mongo
         # @option opts [ true, false ] :upsert Whether to upsert if the document doesn't exist.
         # @option opts [ true, false ] :bypass_document_validation Whether or
         #   not to skip document level validation.
-        # @option opts [ Hash ] :write_concern The write concern options.
-        #   Defaults to the collection's write concern.
         # @option opts [ Hash ] :collation The collation to use.
         # @option opts [ Array ] :array_filters A set of filters specifying to which array elements
         # an update should apply.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
         #
         # @return [ BSON::Document ] The document.
         #
@@ -139,6 +144,8 @@ module Mongo
             write_with_retry(session, applied_write_concern) do |server, txn_num|
               apply_collation!(cmd, server, opts)
               apply_array_filters!(cmd, server, opts)
+              apply_hint!(cmd, server, opts.merge(write_concern: applied_write_concern))
+
               Operation::Command.new(
                   :selector => cmd,
                   :db_name => database.name,
@@ -159,6 +166,10 @@ module Mongo
         #
         # @option opts [ Hash ] :collation The collation to use.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
+        # @option opts [ Hash ] :write_concern The write concern options.
+        #   Can be :w => Integer, :fsync => Boolean, :j => Boolean.
         #
         # @return [ Result ] The response from the database.
         #
@@ -166,14 +177,21 @@ module Mongo
         def delete_many(opts = {})
           delete_doc = { Operation::Q => filter, Operation::LIMIT => 0 }
           with_session(opts) do |session|
-            write_concern = write_concern_with_session(session)
+            write_concern = if opts[:write_concern]
+              WriteConcern.get(opts[:write_concern])
+            else
+              write_concern_with_session(session)
+            end
             nro_write_with_retry(session, write_concern) do |server|
               apply_collation!(delete_doc, server, opts)
+              apply_hint!(delete_doc, server, opts.merge(write_concern: write_concern))
+
               Operation::Delete.new(
                   :deletes => [ delete_doc ],
                   :db_name => collection.database.name,
                   :coll_name => collection.name,
                   :write_concern => write_concern,
+                  :bypass_document_validation => !!opts[:bypass_document_validation], 
                   :session => session
               ).execute(server, client: client)
             end
@@ -189,6 +207,10 @@ module Mongo
         #
         # @option opts [ Hash ] :collation The collation to use.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
+        # @option opts [ Hash ] :write_concern The write concern options.
+        #   Can be :w => Integer, :fsync => Boolean, :j => Boolean.
         #
         # @return [ Result ] The response from the database.
         #
@@ -196,14 +218,21 @@ module Mongo
         def delete_one(opts = {})
           delete_doc = { Operation::Q => filter, Operation::LIMIT => 1 }
           with_session(opts) do |session|
-            write_concern = write_concern_with_session(session)
+            write_concern = if opts[:write_concern]
+              WriteConcern.get(opts[:write_concern])
+            else
+              write_concern_with_session(session)
+            end
             write_with_retry(session, write_concern) do |server, txn_num|
               apply_collation!(delete_doc, server, opts)
+              apply_hint!(delete_doc, server, opts.merge(write_concern: write_concern))
+
               Operation::Delete.new(
                   :deletes => [ delete_doc ],
                   :db_name => collection.database.name,
                   :coll_name => collection.name,
                   :write_concern => write_concern,
+                  :bypass_document_validation => !!opts[:bypass_document_validation],
                   :session => session,
                   :txn_num => txn_num
               ).execute(server, client: client)
@@ -225,6 +254,10 @@ module Mongo
         #   not to skip document level validation.
         # @option opts [ Hash ] :collation The collation to use.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
+        # @option opts [ Hash ] :write_concern The write concern options.
+        #   Can be :w => Integer, :fsync => Boolean, :j => Boolean.
         #
         # @return [ Result ] The response from the database.
         #
@@ -237,10 +270,16 @@ module Mongo
             update_doc['upsert'] = true
           end
           with_session(opts) do |session|
-            write_concern = write_concern_with_session(session)
+            write_concern = if opts[:write_concern]
+              WriteConcern.get(opts[:write_concern])
+            else
+              write_concern_with_session(session)
+            end
+
             write_with_retry(session, write_concern) do |server, txn_num|
               apply_collation!(update_doc, server, opts)
               apply_array_filters!(update_doc, server, opts)
+              apply_hint!(update_doc, server, opts.merge(write_concern: write_concern))
 
               Operation::Update.new(
                   :updates => [ update_doc ],
@@ -271,6 +310,10 @@ module Mongo
         # @option opts [ Array ] :array_filters A set of filters specifying to
         #   which array elements an update should apply.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
+        # @option opts [ Hash ] :write_concern The write concern options.
+        #   Can be :w => Integer, :fsync => Boolean, :j => Boolean.
         #
         # @return [ Result ] The response from the database.
         #
@@ -284,10 +327,16 @@ module Mongo
             update_doc['upsert'] = true
           end
           with_session(opts) do |session|
-            write_concern = write_concern_with_session(session)
+            write_concern = if opts[:write_concern]
+              WriteConcern.get(opts[:write_concern])
+            else
+              write_concern_with_session(session)
+            end
             nro_write_with_retry(session, write_concern) do |server|
               apply_collation!(update_doc, server, opts)
               apply_array_filters!(update_doc, server, opts)
+              apply_hint!(update_doc, server, opts.merge(write_concern: write_concern))
+
               Operation::Update.new(
                   :updates => [ update_doc ],
                   :db_name => collection.database.name,
@@ -316,6 +365,10 @@ module Mongo
         # @option opts [ Array ] :array_filters A set of filters specifying to
         #   which array elements an update should apply.
         # @option opts [ Session ] :session The session to use.
+        # @option opts [ Hash | String ] :hint The index to use for this operation.
+        #   May be specified as a Hash (e.g. { _id: 1 }) or a String (e.g. "_id_").
+        # @option opts [ Hash ] :write_concern The write concern options.
+        #   Can be :w => Integer, :fsync => Boolean, :j => Boolean.
         #
         # @return [ Result ] The response from the database.
         #
@@ -328,10 +381,15 @@ module Mongo
             update_doc['upsert'] = true
           end
           with_session(opts) do |session|
-            write_concern = write_concern_with_session(session)
+            write_concern = if opts[:write_concern]
+              WriteConcern.get(opts[:write_concern])
+            else
+              write_concern_with_session(session)
+            end
             write_with_retry(session, write_concern) do |server, txn_num|
               apply_collation!(update_doc, server, opts)
               apply_array_filters!(update_doc, server, opts)
+              apply_hint!(update_doc, server, opts.merge(write_concern: write_concern))
 
               Operation::Update.new(
                   :updates => [ update_doc ],
@@ -348,6 +406,28 @@ module Mongo
 
         private
 
+        def apply_hint!(doc, server, opts)
+          if hint = opts[:hint]
+            features = server.with_connection do |connection|
+              connection.description.features
+            end
+
+            write_concern = opts[:write_concern]
+            if write_concern && !write_concern.acknowledged?
+              raise Error::UnsupportedOption.hint_error(unacknowledged_write: true)
+            end
+
+            if doc.key?(:findAndModify) &&
+                !features.find_and_modify_option_validation_enabled?
+              raise Error::UnsupportedOption.hint_error
+            elsif !features.update_delete_option_validation_enabled?
+              raise Error::UnsupportedOption.hint_error
+            end
+
+            doc[:hint] = opts[:hint]
+          end
+        end
+
         def apply_array_filters!(doc, server, opts = {})
           if filters = opts[:array_filters] || opts[ARRAY_FILTERS]
             validate_array_filters!(server, filters)
@@ -356,7 +436,7 @@ module Mongo
         end
 
         def validate_array_filters!(server, filters)
-          if filters && !server.features.array_filters_enabled?
+          if filters && !server.with_connection { |connection| connection.features }.array_filters_enabled?
             raise Error::UnsupportedArrayFilters.new
           end
         end

data/lib/mongo/crypt.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/auto_decryption_context.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/auto_encrypter.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/auto_encryption_context.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/binary.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/binding.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/context.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/data_key_context.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

data/lib/mongo/crypt/encryption_io.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2019 MongoDB, Inc.
+# Copyright (C) 2019-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -251,38 +251,55 @@ module Mongo
         host, port = endpoint.split(':')
         port ||= 443 # Default port for AWS KMS API
 
+        # Create TCPSocket and set nodelay option
+        tcp_socket = TCPSocket.open(host, port)
         begin
-          # Create TCPSocket and set nodelay option
-          tcp_socket = TCPSocket.open(host, port)
           tcp_socket.setsockopt(::Socket::IPPROTO_TCP, ::Socket::TCP_NODELAY, 1)
 
           ssl_socket = OpenSSL::SSL::SSLSocket.new(tcp_socket)
-          ssl_socket.sync_close = true # tcp_socket will be closed when ssl_socket is closed
-          ssl_socket.hostname = "#{host}:#{port}" # perform SNI
+          begin
+            # tcp_socket will be closed when ssl_socket is closed
+            ssl_socket.sync_close = true
+            # perform SNI
+            ssl_socket.hostname = "#{host}:#{port}"
+
+            Timeout.timeout(
+              SOCKET_TIMEOUT,
+              Error::SocketTimeoutError,
+              "KMS socket connection timed out after #{SOCKET_TIMEOUT} seconds",
+            ) do
+              ssl_socket.connect
+            end
 
-          Timeout.timeout(
-            SOCKET_TIMEOUT,
-            Error::SocketTimeoutError,
-            'Socket connection timed out'
-          ) do
-            ssl_socket.connect
+            yield(ssl_socket)
+          ensure
+            begin
+              Timeout.timeout(
+                SOCKET_TIMEOUT,
+                Error::SocketTimeoutError,
+                'KMS SSL socket close timed out'
+              ) do
+                ssl_socket.sysclose
+              end
+            rescue
+            end
           end
-
-          yield(ssl_socket)
-        rescue => e
-          raise Error::KmsError, "Error decrypting data key. #{e.class}: #{e.message}"
         ensure
-          # If there is an error during socket creation, the
-          # ssl_socket object won't exist in this scope and this line will
-          # raise an exception
-          Timeout.timeout(
-            SOCKET_TIMEOUT,
-            Error::SocketTimeoutError,
-            'Socket close timed out'
-          ) do
-            ssl_socket.sysclose rescue nil
+          # Still close tcp socket manually in case ssl socket creation
+          # fails.
+          begin
+            Timeout.timeout(
+              SOCKET_TIMEOUT,
+              Error::SocketTimeoutError,
+              'KMS TCP socket close timed out'
+            ) do
+              tcp_socket.close
+            end
+          rescue
           end
         end
+      rescue => e
+        raise Error::KmsError, "Error decrypting data key: #{e.class}: #{e.message}"
       end
     end
   end