mongo 2.11.4 → 2.12.3

data/spec/mongo/operation/read_preference_op_msg_spec.rb

@@ -0,0 +1,194 @@
+require 'spec_helper'
+
+describe Mongo::Operation::SessionsSupported do
+
+  let(:selector) do
+    BSON::Document.new(name: 'test')
+  end
+
+  let(:options) do
+    {}
+  end
+
+  let(:cluster) do
+    double('cluster').tap do |cluster|
+      allow(cluster).to receive(:single?).and_return(single?)
+    end
+  end
+
+  let(:operation) do
+    Class.new do
+      include Mongo::Operation::SessionsSupported
+    end.new.tap do |op|
+      allow(op).to receive(:read).and_return(read_pref)
+      allow(op).to receive(:selector).and_return(selector)
+      allow(op).to receive(:options).and_return(options)
+    end
+  end
+
+  let(:server) do
+    double('server').tap do |server|
+      allow(server).to receive(:cluster).and_return(cluster)
+      allow(server).to receive(:mongos?).and_return(mongos?)
+      allow(server).to receive(:standalone?).and_return(standalone?)
+    end
+  end
+
+  describe '#add_read_preference' do
+
+    let(:read_pref) do
+      Mongo::ServerSelector.get(:mode => mode)
+    end
+
+    let(:actual) do
+      sel = operation.send(:selector).dup
+      operation.send(:add_read_preference, sel, server)
+      sel
+    end
+
+    let(:expected_read_preference) do
+      {mode: mode.to_s.gsub(/_(.)/) { $1.upcase }}
+    end
+
+    shared_examples_for 'adds read preference' do
+
+      let(:expected) do
+        selector.merge(:$readPreference => expected_read_preference)
+      end
+
+      it 'adds read preference' do
+        expect(actual).to eq(expected)
+      end
+    end
+
+    shared_examples_for 'does not modify selector' do
+
+      it 'does not modify selector' do
+        expect(actual).to eq(selector)
+      end
+    end
+
+    shared_examples_for 'does not send read preference' do
+      ([nil] + %i(primary primary_preferred secondary secondary_preferred nearest)).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'does not modify selector'
+        end
+      end
+    end
+
+    shared_examples_for 'sends user-specified read preference' do
+      %i(primary primary_preferred secondary secondary_preferred nearest).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+
+      context "when read preference mode is nil" do
+        let(:mode) { nil }
+
+        let(:expected_read_preference) do
+          {mode: 'primary'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+    end
+
+    shared_examples_for 'changes read preference to allow secondary reads' do
+
+      %i(primary_preferred secondary secondary_preferred nearest).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+
+      context "when read preference mode is primary" do
+        let(:mode) { :primary }
+
+        let(:expected_read_preference) do
+          {mode: 'primaryPreferred'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+
+      context "when read preference mode is nil" do
+        let(:mode) { nil }
+
+        let(:expected_read_preference) do
+          {mode: 'primaryPreferred'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+    end
+
+    context 'in single topology' do
+      let(:single?) { true }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+        let(:mongos?) { false }
+
+        it_behaves_like 'does not send read preference'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'changes read preference to allow secondary reads'
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'changes read preference to allow secondary reads'
+      end
+    end
+
+    context 'not in single topology' do
+      let(:single?) { false }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+        let(:mongos?) { false }
+
+        it_behaves_like 'does not send read preference'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'sends user-specified read preference'
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'sends user-specified read preference'
+      end
+    end
+  end
+end

data/spec/mongo/operation/remove_user_spec.rb

@@ -22,7 +22,7 @@ describe Mongo::Operation::RemoveUser do
     context 'when user removal was successful' do
 
       let!(:response) do
-        operation.execute(root_authorized_primary)
+        operation.execute(root_authorized_primary, client: nil)
       end
 
       it 'removes the user from the database' do
@@ -33,12 +33,12 @@ describe Mongo::Operation::RemoveUser do
     context 'when removal was not successful' do
 
       before do
-        operation.execute(root_authorized_primary)
+        operation.execute(root_authorized_primary, client: nil)
       end
 
       it 'raises an exception' do
         expect {
-          operation.execute(root_authorized_primary)
+          operation.execute(root_authorized_primary, client: nil)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/update/bulk_spec.rb

@@ -98,7 +98,7 @@ describe Mongo::Operation::Update do
         end
 
         it 'updates the document' do
-          op.bulk_execute(authorized_primary)
+          op.bulk_execute(authorized_primary, client: nil)
           expect(authorized_collection.find(field: 'blah').count).to eq(1)
         end
       end
@@ -122,7 +122,7 @@ describe Mongo::Operation::Update do
         end
 
         it 'updates the documents' do
-          op.bulk_execute(authorized_primary)
+          op.bulk_execute(authorized_primary, client: nil)
           expect(authorized_collection.find(field: 'blah').count).to eq(2)
         end
       end
@@ -154,7 +154,7 @@ describe Mongo::Operation::Update do
         context 'when write concern is acknowledged' do
 
           it 'aborts after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            failing_update.bulk_execute(authorized_primary, client: nil)
             expect(authorized_collection.find(other: 'blah').count).to eq(0)
           end
         end
@@ -166,7 +166,7 @@ describe Mongo::Operation::Update do
           end
 
           it 'aborts after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            failing_update.bulk_execute(authorized_primary, client: nil)
             expect(authorized_collection.find(other: 'blah').count).to eq(0)
           end
         end
@@ -199,7 +199,7 @@ describe Mongo::Operation::Update do
         context 'when write concern is acknowledged' do
 
           it 'does not abort after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            failing_update.bulk_execute(authorized_primary, client: nil)
             expect(authorized_collection.find(other: 'blah').count).to eq(1)
           end
         end
@@ -211,7 +211,7 @@ describe Mongo::Operation::Update do
           end
 
           it 'does not abort after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            failing_update.bulk_execute(authorized_primary, client: nil)
             expect(authorized_collection.find(other: 'blah').count).to eq(1)
           end
         end

data/spec/mongo/operation/update/op_msg_spec.rb

@@ -108,12 +108,7 @@ describe Mongo::Operation::Update::OpMsg do
       end
 
       let(:expected_payload_1) do
-        {
-            type: 1,
-            payload: { identifier: 'updates',
-                       sequence: updates
-            }
-        }
+        Mongo::Protocol::Msg::Section1.new('updates', updates)
       end
 
       let(:session) do
@@ -150,6 +145,8 @@ describe Mongo::Operation::Update::OpMsg do
         end
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
+          # Mocks on features are incompatible with linting
+          skip_if_linting
 
           let(:expected_global_args) do
             global_args.dup.tap do |args|

data/spec/mongo/operation/update_spec.rb

@@ -100,7 +100,7 @@ describe Mongo::Operation::Update do
         end
 
         let(:result) do
-          update.execute(authorized_primary)
+          update.execute(authorized_primary, client: nil)
         end
 
         it 'updates the document' do
@@ -128,7 +128,7 @@ describe Mongo::Operation::Update do
 
         it 'raises an exception' do
           expect {
-            update.execute(authorized_primary)
+            update.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -152,7 +152,7 @@ describe Mongo::Operation::Update do
         end
 
         let(:result) do
-          update.execute(authorized_primary)
+          update.execute(authorized_primary, client: nil)
         end
 
         it 'updates the documents' do
@@ -180,7 +180,7 @@ describe Mongo::Operation::Update do
 
         it 'raises an exception' do
           expect {
-            update.execute(authorized_primary)
+            update.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -193,7 +193,7 @@ describe Mongo::Operation::Update do
 
         it 'raises an error' do
           expect {
-            update.execute(authorized_primary)
+            update.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::MaxBSONSize)
         end
       end
@@ -205,7 +205,7 @@ describe Mongo::Operation::Update do
         end
 
         let(:result) do
-          update.execute(authorized_primary)
+          update.execute(authorized_primary, client: nil)
         end
 
         it 'inserts the document' do
@@ -243,7 +243,7 @@ describe Mongo::Operation::Update do
       end
 
       let(:result) do
-        update.execute(authorized_primary)
+        update.execute(authorized_primary, client: nil)
       end
 
       before do

data/spec/mongo/operation/update_user_spec.rb

@@ -35,7 +35,7 @@ describe Mongo::Operation::UpdateUser do
     context 'when user update was successful' do
 
       let!(:response) do
-        operation.execute(root_authorized_primary)
+        operation.execute(root_authorized_primary, client: nil)
       end
 
       it 'updates the user in the database' do

data/spec/mongo/protocol/compressed_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require 'lite_spec_helper'
 
 describe Mongo::Protocol::Compressed do
 
-  let(:original_message) { Mongo::Protocol::Query.new(SpecConfig.instance.test_db, TEST_COLL, { ping: 1 }) }
+  let(:original_message) { Mongo::Protocol::Query.new(SpecConfig.instance.test_db, 'protocol-test', { ping: 1 }) }
   let(:compressor) { 'zlib' }
   let(:level)      { nil }
 
@@ -53,7 +53,6 @@ describe Mongo::Protocol::Compressed do
     end
 
     context 'when the original message is not replyable' do
-      min_server_fcv '3.6'
 
       let(:original_message) do
         Mongo::Protocol::Msg.new([:more_to_come], {}, { ping: 1 })

data/spec/mongo/protocol/delete_spec.rb

@@ -1,16 +1,17 @@
-require 'spec_helper'
+require 'lite_spec_helper'
+require 'support/shared/protocol'
 
 describe Mongo::Protocol::Delete do
 
   let(:opcode)   { 2006 }
   let(:db)       { SpecConfig.instance.test_db }
-  let(:coll)     { TEST_COLL }
-  let(:ns)       { "#{db}.#{coll}" }
+  let(:collection_name) { 'protocol-test' }
+  let(:ns)       { "#{db}.#{collection_name}" }
   let(:selector) { { :name => 'Tyler' } }
   let(:options)     { Hash.new }
 
   let(:message) do
-    described_class.new(db, coll, selector, options)
+    described_class.new(db, collection_name, selector, options)
   end
 
   describe '#initialize' do
@@ -41,7 +42,7 @@ describe Mongo::Protocol::Delete do
 
       context 'when the fields are equal' do
         let(:other) do
-          described_class.new(db, coll, selector, options)
+          described_class.new(db, collection_name, selector, options)
         end
 
         it 'returns true' do
@@ -51,7 +52,7 @@ describe Mongo::Protocol::Delete do
 
       context 'when the database is not equal' do
         let(:other) do
-          described_class.new('tyler', coll, selector, options)
+          described_class.new('tyler', collection_name, selector, options)
         end
 
         it 'returns false' do
@@ -71,7 +72,7 @@ describe Mongo::Protocol::Delete do
 
       context 'when the selector is not equal' do
         let(:other) do
-          described_class.new(db, coll, { :a => 1 }, options)
+          described_class.new(db, collection_name, { :a => 1 }, options)
         end
 
         it 'returns false' do
@@ -81,7 +82,7 @@ describe Mongo::Protocol::Delete do
 
       context 'when the options are not equal' do
         let(:other) do
-          described_class.new(db, coll, selector, :flags => [:single_remove])
+          described_class.new(db, collection_name, selector, :flags => [:single_remove])
         end
 
         it 'returns false' do

data/spec/mongo/protocol/get_more_spec.rb

@@ -1,16 +1,17 @@
-require 'spec_helper'
+require 'lite_spec_helper'
+require 'support/shared/protocol'
 
 describe Mongo::Protocol::GetMore do
 
   let(:opcode)    { 2005 }
   let(:db)        { SpecConfig.instance.test_db }
-  let(:coll)      { TEST_COLL }
-  let(:ns)        { "#{db}.#{coll}" }
+  let(:collection_name) { 'protocol-test' }
+  let(:ns)        { "#{db}.#{collection_name}" }
   let(:limit)     { 25 }
   let(:cursor_id) { 12345 }
 
   let(:message) do
-    described_class.new(db, coll, limit, cursor_id)
+    described_class.new(db, collection_name, limit, cursor_id)
   end
 
   describe '#initialize' do
@@ -34,7 +35,7 @@ describe Mongo::Protocol::GetMore do
 
       context 'when the fields are equal' do
         let(:other) do
-          described_class.new(db, coll, limit, cursor_id)
+          described_class.new(db, collection_name, limit, cursor_id)
         end
 
         it 'returns true' do
@@ -44,7 +45,7 @@ describe Mongo::Protocol::GetMore do
 
       context 'when the database is not equal' do
         let(:other) do
-          described_class.new('tyler', coll, limit, cursor_id)
+          described_class.new('tyler', collection_name, limit, cursor_id)
         end
 
         it 'returns false' do
@@ -64,7 +65,7 @@ describe Mongo::Protocol::GetMore do
 
       context 'when the limit is not equal' do
         let(:other) do
-          described_class.new(db, coll, 123, cursor_id)
+          described_class.new(db, collection_name, 123, cursor_id)
         end
 
         it 'returns false' do
@@ -74,7 +75,7 @@ describe Mongo::Protocol::GetMore do
 
       context 'when the cursor id is not equal' do
         let(:other) do
-          described_class.new(db, coll, limit, 7777)
+          described_class.new(db, collection_name, limit, 7777)
         end
 
         it 'returns false' do