mongo 2.11.4 → 2.12.3

data/spec/mongo/operation/insert/op_msg_spec.rb

@@ -106,12 +106,7 @@ describe Mongo::Operation::Insert::OpMsg do
       end
 
       let!(:expected_payload_1) do
-        {
-            type: 1,
-            payload: { identifier: 'documents',
-                       sequence: op.documents
-            }
-        }
+        Mongo::Protocol::Msg::Section1.new('documents', op.documents)
       end
 
       let(:session) do
@@ -158,6 +153,8 @@ describe Mongo::Operation::Insert::OpMsg do
         end
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
+          # Mocks on features are incompatible with linting
+          skip_if_linting
 
           let(:expected_global_args) do
             global_args.dup.tap do |args|

data/spec/mongo/operation/insert_spec.rb

@@ -83,7 +83,7 @@ describe Mongo::Operation::Insert do
       end
 
       let(:inserted_ids) do
-        insert.execute(authorized_primary).inserted_ids
+        insert.execute(authorized_primary, client: nil).inserted_ids
       end
 
       let(:collection_ids) do
@@ -112,7 +112,7 @@ describe Mongo::Operation::Insert do
       context 'when the insert succeeds' do
 
         let!(:response) do
-          insert.execute(authorized_primary)
+          insert.execute(authorized_primary, client: nil)
         end
 
         it 'reports the correct written count' do
@@ -144,8 +144,8 @@ describe Mongo::Operation::Insert do
 
         it 'raises an error' do
           expect {
-            failing_insert.execute(authorized_primary)
-            failing_insert.execute(authorized_primary)
+            failing_insert.execute(authorized_primary, client: nil)
+            failing_insert.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -163,7 +163,7 @@ describe Mongo::Operation::Insert do
         end
 
         let!(:response) do
-          insert.execute(authorized_primary)
+          insert.execute(authorized_primary, client: nil)
         end
 
         it 'reports the correct written count' do
@@ -195,8 +195,8 @@ describe Mongo::Operation::Insert do
 
         it 'raises an error' do
           expect {
-            failing_insert.execute(authorized_primary)
-            failing_insert.execute(authorized_primary)
+            failing_insert.execute(authorized_primary, client: nil)
+            failing_insert.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -221,8 +221,8 @@ describe Mongo::Operation::Insert do
 
         it 'raises an error' do
           expect {
-            failing_insert.execute(authorized_primary)
-            failing_insert.execute(authorized_primary)
+            failing_insert.execute(authorized_primary, client: nil)
+            failing_insert.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
 
@@ -236,13 +236,13 @@ describe Mongo::Operation::Insert do
 
         it 'raises an error' do
           expect {
-            insert.execute(authorized_primary)
+            insert.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::MaxBSONSize)
         end
 
         it 'does not insert the document' do
           expect {
-            insert.execute(authorized_primary)
+            insert.execute(authorized_primary, client: nil)
           }.to raise_error(Mongo::Error::MaxBSONSize)
           expect(authorized_collection.find.count).to eq(0)
         end
@@ -273,7 +273,7 @@ describe Mongo::Operation::Insert do
       end
 
       let(:response) do
-        op.execute(authorized_primary)
+        op.execute(authorized_primary, client: nil)
       end
 
       it 'uses op codes instead of write commands' do

data/spec/mongo/operation/map_reduce_spec.rb

@@ -97,7 +97,7 @@ describe Mongo::Operation::MapReduce do
     context 'when the map/reduce succeeds' do
 
       let(:response) do
-        op.execute(authorized_primary)
+        op.execute(authorized_primary, client: nil)
       end
 
       it 'returns the response' do
@@ -117,7 +117,7 @@ describe Mongo::Operation::MapReduce do
 
       it 'raises an exception' do
         expect {
-          op.execute(authorized_primary)
+          op.execute(authorized_primary, client: nil)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/read_preference_legacy_spec.rb

@@ -0,0 +1,351 @@
+require 'spec_helper'
+
+describe Mongo::Operation::ReadPreferenceSupported do
+
+  let(:selector) do
+    { name: 'test' }
+  end
+
+  let(:options) do
+    {}
+  end
+
+  let(:cluster) do
+    double('cluster').tap do |cluster|
+      allow(cluster).to receive(:single?).and_return(single?)
+    end
+  end
+
+  let(:operation) do
+    Class.new do
+      include Mongo::Operation::ReadPreferenceSupported
+    end.new.tap do |op|
+      allow(op).to receive(:read).and_return(read_pref)
+      allow(op).to receive(:selector).and_return(selector)
+      allow(op).to receive(:options).and_return(options)
+    end
+  end
+
+  let(:server) do
+    double('server').tap do |server|
+      allow(server).to receive(:cluster).and_return(cluster)
+      allow(server).to receive(:mongos?).and_return(mongos?)
+      allow(server).to receive(:standalone?).and_return(standalone?)
+    end
+  end
+
+  describe '#add_slave_ok_flag_maybe' do
+
+    let(:actual) do
+      operation.send(:add_slave_ok_flag_maybe, operation.send(:options), server)
+    end
+
+    shared_examples_for 'sets the slave_ok flag as expected' do
+      it 'sets the slave_ok flag as expected' do
+        expect(actual).to eq(expected)
+      end
+    end
+
+    shared_examples_for 'never sets slave_ok' do
+
+      let(:expected) do
+        { }
+      end
+
+      context 'when no read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+
+      context 'when primary read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get(:mode => :primary) }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+
+      context 'when secondary read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get(:mode => :secondary) }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+    end
+
+    shared_examples_for 'always sets slave_ok' do
+
+      let(:expected) do
+        { :flags => [ :slave_ok ] }
+      end
+
+      context 'when no read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+
+      context 'when primary read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get(:mode => :primary) }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+
+      context 'when secondary read preference is specified' do
+        let(:read_pref) { Mongo::ServerSelector.get(:mode => :secondary) }
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+    end
+
+    shared_examples_for 'sets slave_ok if read preference is specified and is not primary' do
+
+      context 'when there is no read preference set' do
+
+        let(:read_pref) { Mongo::ServerSelector.get }
+
+        let(:expected) do
+          { }
+        end
+
+        it_behaves_like 'sets the slave_ok flag as expected'
+      end
+
+      context 'when there is a read preference' do
+
+        context 'when the read preference requires the slave_ok flag' do
+
+          let(:read_pref) { Mongo::ServerSelector.get(:mode => :secondary) }
+
+          let(:expected) do
+            { :flags => [ :slave_ok ] }
+          end
+
+          it_behaves_like 'sets the slave_ok flag as expected'
+        end
+
+        context 'when the read preference does not require the slave_ok flag' do
+
+          let(:read_pref) { Mongo::ServerSelector.get(:mode => :primary) }
+
+          let(:expected) do
+            { }
+          end
+
+          it_behaves_like 'sets the slave_ok flag as expected'
+        end
+      end
+    end
+
+    context 'when the topology is Single' do
+
+      let(:single?) { true }
+      let(:mongos?) { false }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+
+        it_behaves_like 'never sets slave_ok'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'always sets slave_ok'
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'always sets slave_ok'
+      end
+    end
+
+    context 'when the topology is not Single' do
+
+      let(:single?) { false }
+      let(:mongos?) { false }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+
+        it_behaves_like 'never sets slave_ok'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'sets slave_ok if read preference is specified and is not primary'
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'sets slave_ok if read preference is specified and is not primary'
+      end
+    end
+  end
+
+  describe '#update_selector_for_read_pref' do
+
+    let(:read_pref) do
+      Mongo::ServerSelector.get(:mode => mode)
+    end
+
+    # Behavior of sending $readPreference is the same regardless of topology.
+    shared_examples_for '$readPreference in the command' do
+      let(:actual) do
+        operation.send(:update_selector_for_read_pref, operation.send(:selector), server)
+      end
+
+      let(:expected_read_preference) do
+        {mode: mode.to_s.gsub(/_(.)/) { $1.upcase }}
+      end
+
+      shared_examples_for 'adds read preference moving existing contents to $query' do
+
+        let(:expected) do
+          { :$query => selector, :$readPreference => expected_read_preference }
+        end
+
+        it 'moves existing selector contents under $query and adds read preference' do
+          expect(actual).to eq(expected)
+        end
+
+        context 'when the selector already has $query in it' do
+
+          let(:selector) do
+            { :$query => { :name => 'test' },
+              :$orderby => { :name => -1 } }
+          end
+
+          let(:expected) do
+            selector.merge(:$readPreference => expected_read_preference)
+          end
+
+          it 'keeps existing $query and adds read preference' do
+            expect(actual).to eq(expected)
+          end
+        end
+      end
+
+      shared_examples_for 'does not modify selector' do
+
+        it 'does not modify selector' do
+          expect(actual).to eq(selector)
+        end
+      end
+
+      shared_examples_for 'does not send read preference' do
+        ([nil] + %i(primary primary_preferred secondary secondary_preferred nearest)).each do |_mode|
+          active_mode = _mode
+
+          context "when read preference mode is #{active_mode}" do
+            let(:mode) { active_mode }
+
+            it_behaves_like 'does not modify selector'
+          end
+        end
+      end
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+        let(:mongos?) { false }
+
+        it_behaves_like 'does not send read preference'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        context 'when the read preference mode is nil' do
+
+          let(:mode) { nil }
+
+          it_behaves_like 'does not modify selector'
+        end
+
+        context 'when the read preference mode is primary' do
+
+          let(:mode) { :primary }
+
+          it_behaves_like 'does not modify selector'
+        end
+
+        context 'when the read preference mode is primary_preferred' do
+
+          let(:mode) { :primary_preferred }
+
+          it_behaves_like 'adds read preference moving existing contents to $query'
+        end
+
+        context 'when the read preference mode is secondary' do
+
+          let(:mode) { :secondary }
+
+          it_behaves_like 'adds read preference moving existing contents to $query'
+        end
+
+        context 'when the read preference mode is secondary_preferred' do
+
+          let(:mode) { :secondary_preferred }
+
+          it_behaves_like 'does not modify selector'
+
+          context 'when there are fields in the selector besides :mode' do
+            let(:read_pref) do
+              Mongo::ServerSelector.get(:mode => mode, tag_sets: ['dc' => 'nyc'])
+            end
+
+            let(:expected_read_preference) do
+              {mode: mode.to_s.gsub(/_(.)/) { $1.upcase }, tags: ['dc' => 'nyc']}
+            end
+
+            it_behaves_like 'adds read preference moving existing contents to $query'
+          end
+        end
+
+        context 'when the read preference mode is nearest' do
+
+          let(:mode) { :nearest }
+
+          it_behaves_like 'adds read preference moving existing contents to $query'
+        end
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        # $readPreference is not sent to replica set nodes running legacy
+        # servers - the allowance of secondary reads is handled by slave_ok
+        # flag.
+        it_behaves_like 'does not send read preference'
+      end
+    end
+
+    context 'in single topology' do
+      let(:single?) { true }
+
+      it_behaves_like '$readPreference in the command'
+    end
+
+    context 'not in single topology' do
+      let(:single?) { false }
+
+      it_behaves_like '$readPreference in the command'
+    end
+  end
+end