mongo 2.11.2 → 2.13.0.beta1

data/spec/mongo/operation/read_preference_op_msg_spec.rb

@@ -0,0 +1,304 @@
+require 'spec_helper'
+
+describe Mongo::Operation::SessionsSupported do
+  # https://jira.mongodb.org/browse/RUBY-2224
+  skip_if_linting
+
+  let(:selector) do
+    BSON::Document.new(name: 'test')
+  end
+
+  let(:options) do
+    {}
+  end
+
+  let(:cluster) do
+    double('cluster').tap do |cluster|
+      allow(cluster).to receive(:single?).and_return(single?)
+    end
+  end
+
+  let(:operation) do
+    Class.new do
+      include Mongo::Operation::SessionsSupported
+    end.new.tap do |op|
+      allow(op).to receive(:read).and_return(read_pref)
+      allow(op).to receive(:selector).and_return(selector)
+      allow(op).to receive(:options).and_return(options)
+    end
+  end
+
+  let(:description) do
+    double('description').tap do |description|
+      allow(description).to receive(:mongos?).and_return(mongos?)
+      allow(description).to receive(:standalone?).and_return(standalone?)
+    end
+  end
+
+  let(:server) do
+    double('server').tap do |server|
+      allow(server).to receive(:cluster).and_return(cluster)
+    end
+  end
+
+  let(:connection) do
+    double('connection').tap do |connection|
+      allow(connection).to receive(:server).and_return(server)
+      allow(connection).to receive(:description).and_return(description)
+    end
+  end
+
+  describe '#add_read_preference' do
+
+    let(:read_pref) do
+      Mongo::ServerSelector.get(:mode => mode)
+    end
+
+    let(:actual) do
+      sel = operation.send(:selector).dup
+      operation.send(:add_read_preference, sel, connection)
+      sel
+    end
+
+    let(:expected_read_preference) do
+      {mode: mode.to_s.gsub(/_(.)/) { $1.upcase }}
+    end
+
+    shared_examples_for 'adds read preference' do
+
+      let(:expected) do
+        selector.merge(:$readPreference => expected_read_preference)
+      end
+
+      it 'adds read preference' do
+        expect(actual).to eq(expected)
+      end
+    end
+
+    shared_examples_for 'does not modify selector' do
+
+      it 'does not modify selector' do
+        expect(actual).to eq(selector)
+      end
+    end
+
+    shared_examples_for 'does not send read preference' do
+      ([nil] + %i(primary primary_preferred secondary secondary_preferred nearest)).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'does not modify selector'
+        end
+      end
+    end
+
+    shared_examples_for 'sends user-specified read preference' do
+      %i(primary primary_preferred secondary secondary_preferred nearest).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+
+      context "when read preference mode is nil" do
+        let(:mode) { nil }
+
+        let(:expected_read_preference) do
+          {mode: 'primary'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+    end
+
+    shared_examples_for 'changes read preference to allow secondary reads' do
+
+      %i(primary_preferred secondary secondary_preferred nearest).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+
+      context "when read preference mode is primary" do
+        let(:mode) { :primary }
+
+        let(:expected_read_preference) do
+          {mode: 'primaryPreferred'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+
+      context "when read preference mode is nil" do
+        let(:mode) { nil }
+
+        let(:expected_read_preference) do
+          {mode: 'primaryPreferred'}
+        end
+
+        it_behaves_like 'adds read preference'
+      end
+    end
+
+    shared_examples_for 'sends read preference correctly for mongos' do
+      %i(primary_preferred secondary nearest).each do |_mode|
+        active_mode = _mode
+
+        context "when read preference mode is #{active_mode}" do
+          let(:mode) { active_mode }
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+
+      context 'when read preference mode is primary' do
+        let(:mode) { 'primary' }
+        it_behaves_like 'does not modify selector'
+      end
+
+      context 'when read preference mode is secondary_preferred' do
+        let(:mode) { 'secondary_preferred' }
+
+        let(:read_pref) do
+          Mongo::ServerSelector.get(mode: mode, tag_sets: tag_sets)
+        end
+
+        let(:tag_sets) { nil }
+
+        context 'without tag_sets specified' do
+          it_behaves_like 'does not modify selector'
+        end
+
+        context 'with empty tag_sets' do
+          let(:tag_sets) { [] }
+
+          it_behaves_like 'does not modify selector'
+        end
+
+        context 'with tag_sets specified' do
+          let(:tag_sets) { [{ dc: 'ny' }] }
+
+          let(:expected_read_preference) do
+            { mode: 'secondaryPreferred', tags: tag_sets }
+          end
+
+          it_behaves_like 'adds read preference'
+        end
+      end
+    end
+
+    context 'in single topology' do
+      let(:single?) { true }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+        let(:mongos?) { false }
+
+        it_behaves_like 'does not send read preference'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'sends read preference correctly for mongos'
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'changes read preference to allow secondary reads'
+      end
+    end
+
+    context 'not in single topology' do
+      let(:single?) { false }
+
+      context 'when the server is a standalone' do
+
+        let(:standalone?) { true }
+        let(:mongos?) { false }
+
+        it_behaves_like 'does not send read preference'
+      end
+
+      context 'when the server is a mongos' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { true }
+
+        it_behaves_like 'sends read preference correctly for mongos'
+
+        context 'when read preference mode is secondary_preferred' do
+          let(:read_pref) do
+            Mongo::ServerSelector.get(
+              mode: mode,
+              tag_sets: tag_sets,
+              hedge: hedge
+            )
+          end
+
+          let(:mode) { 'secondary_preferred' }
+          let(:tag_sets) { nil }
+          let(:hedge) { nil }
+
+          context 'when tag_sets and hedge are not specified' do
+            it_behaves_like 'does not modify selector'
+          end
+
+          context 'when tag_sets are specified' do
+            let(:tag_sets) { [{ dc: 'ny' }] }
+
+            let(:expected_read_preference) do
+              { mode: 'secondaryPreferred', tags: tag_sets }
+            end
+
+            it_behaves_like 'adds read preference'
+          end
+
+          context 'when hedge is specified' do
+            let(:hedge) { { enabled: true } }
+
+            let(:expected_read_preference) do
+              { mode: 'secondaryPreferred', hedge: hedge }
+            end
+
+            it_behaves_like 'adds read preference'
+          end
+
+          context 'when hedge and tag_sets are specified' do
+            let(:hedge) { { enabled: true } }
+            let(:tag_sets) { [{ dc: 'ny' }] }
+
+            let(:expected_read_preference) do
+              { mode: 'secondaryPreferred', tags: tag_sets, hedge: hedge }
+            end
+
+            it_behaves_like 'adds read preference'
+          end
+        end
+      end
+
+      context 'when the server is a replica set member' do
+
+        let(:standalone?) { false }
+        let(:mongos?) { false }
+
+        it_behaves_like 'sends user-specified read preference'
+      end
+    end
+  end
+end

data/spec/mongo/operation/remove_user_spec.rb

@@ -22,7 +22,7 @@ describe Mongo::Operation::RemoveUser do
     context 'when user removal was successful' do
 
       let!(:response) do
-        operation.execute(root_authorized_primary)
+        operation.execute(root_authorized_primary, client: nil)
       end
 
       it 'removes the user from the database' do
@@ -33,12 +33,12 @@ describe Mongo::Operation::RemoveUser do
     context 'when removal was not successful' do
 
       before do
-        operation.execute(root_authorized_primary)
+        operation.execute(root_authorized_primary, client: nil)
       end
 
       it 'raises an exception' do
         expect {
-          operation.execute(root_authorized_primary)
+          operation.execute(root_authorized_primary, client: nil)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/result_spec.rb

@@ -2,8 +2,13 @@ require 'spec_helper'
 
 describe Mongo::Operation::Result do
 
+  let(:description) do
+    Mongo::Server::Description.new(double('description address'),
+      'minWireVersion' => 0, 'maxWireVersion' => 2)
+  end
+
   let(:result) do
-    described_class.new(reply)
+    described_class.new(reply, description)
   end
 
   let(:cursor_id) { 0 }

data/spec/mongo/operation/update/bulk_spec.rb

@@ -98,7 +98,9 @@ describe Mongo::Operation::Update do
         end
 
         it 'updates the document' do
-          op.bulk_execute(authorized_primary)
+          authorized_primary.with_connection do |connection|
+            op.bulk_execute(connection, client: nil)
+          end
           expect(authorized_collection.find(field: 'blah').count).to eq(1)
         end
       end
@@ -122,7 +124,9 @@ describe Mongo::Operation::Update do
         end
 
         it 'updates the documents' do
-          op.bulk_execute(authorized_primary)
+          authorized_primary.with_connection do |connection|
+            op.bulk_execute(connection, client: nil)
+          end
           expect(authorized_collection.find(field: 'blah').count).to eq(2)
         end
       end
@@ -154,7 +158,9 @@ describe Mongo::Operation::Update do
         context 'when write concern is acknowledged' do
 
           it 'aborts after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            authorized_primary.with_connection do |connection|
+              failing_update.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find(other: 'blah').count).to eq(0)
           end
         end
@@ -166,7 +172,9 @@ describe Mongo::Operation::Update do
           end
 
           it 'aborts after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            authorized_primary.with_connection do |connection|
+              failing_update.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find(other: 'blah').count).to eq(0)
           end
         end
@@ -199,7 +207,9 @@ describe Mongo::Operation::Update do
         context 'when write concern is acknowledged' do
 
           it 'does not abort after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            authorized_primary.with_connection do |connection|
+              failing_update.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find(other: 'blah').count).to eq(1)
           end
         end
@@ -211,7 +221,9 @@ describe Mongo::Operation::Update do
           end
 
           it 'does not abort after first error' do
-            failing_update.bulk_execute(authorized_primary)
+            authorized_primary.with_connection do |connection|
+              failing_update.bulk_execute(connection, client: nil)
+            end
             expect(authorized_collection.find(other: 'blah').count).to eq(1)
           end
         end

data/spec/mongo/operation/update/command_spec.rb

@@ -68,6 +68,8 @@ describe Mongo::Operation::Update::Command do
   end
 
   describe 'write concern' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when write concern is not specified' do
 
@@ -93,6 +95,8 @@ describe Mongo::Operation::Update::Command do
   end
 
   describe '#message' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when the server does not support OP_MSG' do
       max_server_version '3.4'

data/spec/mongo/operation/update/op_msg_spec.rb

@@ -23,6 +23,15 @@ describe Mongo::Operation::Update::OpMsg do
 
   let(:op) { described_class.new(spec) }
 
+  let(:connection) do
+    double('connection').tap do |connection|
+      allow(connection).to receive(:server).and_return(authorized_primary)
+      allow(connection).to receive(:features).and_return(authorized_primary.features)
+      allow(connection).to receive(:description).and_return(authorized_primary.description)
+      allow(connection).to receive(:cluster_time).and_return(authorized_primary.cluster_time)
+    end
+  end
+
   describe '#initialize' do
 
     context 'spec' do
@@ -68,6 +77,8 @@ describe Mongo::Operation::Update::OpMsg do
   end
 
   describe 'write concern' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when write concern is not specified' do
 
@@ -80,19 +91,21 @@ describe Mongo::Operation::Update::OpMsg do
       end
 
       it 'does not include write concern in the selector' do
-        expect(op.send(:command, authorized_primary)[:writeConcern]).to be_nil
+        expect(op.send(:command, connection)[:writeConcern]).to be_nil
       end
     end
 
     context 'when write concern is specified' do
 
       it 'includes write concern in the selector' do
-        expect(op.send(:command, authorized_primary)[:writeConcern]).to eq(write_concern.options)
+        expect(op.send(:command, connection)[:writeConcern]).to eq(write_concern.options)
       end
     end
   end
 
   describe '#message' do
+    # https://jira.mongodb.org/browse/RUBY-2224
+    skip_if_linting
 
     context 'when the server supports OP_MSG' do
       min_server_fcv '3.6'
@@ -108,12 +121,7 @@ describe Mongo::Operation::Update::OpMsg do
       end
 
       let(:expected_payload_1) do
-        {
-            type: 1,
-            payload: { identifier: 'updates',
-                       sequence: updates
-            }
-        }
+        Mongo::Protocol::Msg::Section1.new('updates', updates)
       end
 
       let(:session) do
@@ -131,7 +139,7 @@ describe Mongo::Operation::Update::OpMsg do
         it 'creates the correct OP_MSG message' do
           authorized_client.command(ping:1)
           expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-          op.send(:message, authorized_primary)
+          op.send(:message, connection)
         end
       end
 
@@ -146,10 +154,12 @@ describe Mongo::Operation::Update::OpMsg do
         it 'creates the correct OP_MSG message' do
           authorized_client.command(ping:1)
           expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-          op.send(:message, authorized_primary)
+          op.send(:message, connection)
         end
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
+          # Mocks on features are incompatible with linting
+          skip_if_linting
 
           let(:expected_global_args) do
             global_args.dup.tap do |args|
@@ -159,19 +169,14 @@ describe Mongo::Operation::Update::OpMsg do
 
           before do
             session.instance_variable_set(:@options, { implicit: true })
-            # Topology is standalone, hence there is exactly one server
-            authorized_primary.monitor.stop!
           end
 
           it 'creates the correct OP_MSG message' do
             RSpec::Mocks.with_temporary_scope do
-              # Override description as it gets replaced on every connection
-              description = authorized_primary.description
-              allow(authorized_primary).to receive(:description).and_return(description)
-              allow(description.features).to receive(:sessions_enabled?).and_return(false)
+              expect(connection.features).to receive(:sessions_enabled?).and_return(false)
 
               expect(Mongo::Protocol::Msg).to receive(:new).with([], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end
@@ -204,7 +209,7 @@ describe Mongo::Operation::Update::OpMsg do
             it 'does not send a session id in the command' do
               authorized_client.command(ping:1)
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
 
@@ -221,7 +226,7 @@ describe Mongo::Operation::Update::OpMsg do
             it 'creates the correct OP_MSG message' do
               authorized_client.command(ping:1)
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end
@@ -245,7 +250,7 @@ describe Mongo::Operation::Update::OpMsg do
             authorized_client.command(ping:1)
             RSpec::Mocks.with_temporary_scope do
               expect(Mongo::Protocol::Msg).to receive(:new).with([:more_to_come], {}, expected_global_args, expected_payload_1)
-              op.send(:message, authorized_primary)
+              op.send(:message, connection)
             end
           end
         end