mongo 2.11.2 → 2.13.0.beta1

data/spec/mongo/auth/user/view_spec.rb

@@ -2,8 +2,10 @@ require 'spec_helper'
 
 describe Mongo::Auth::User::View do
 
+  let(:database) { root_authorized_client.database }
+
   let(:view) do
-    described_class.new(root_authorized_client.database)
+    described_class.new(database)
   end
 
   before do
@@ -51,6 +53,39 @@ describe Mongo::Auth::User::View do
 
   describe '#create' do
 
+    context 'when password is not provided' do
+
+      let(:database) { root_authorized_client.use('$external').database }
+
+      let(:username) { 'passwordless-user' }
+
+      let(:response) do
+        view.create(
+          username,
+          # https://stackoverflow.com/questions/55939832/mongodb-external-database-cannot-create-new-user-with-user-defined-role
+          roles: [{role: 'read', db: 'admin'}],
+        )
+      end
+
+      before do
+        begin
+          view.remove(username)
+        rescue Mongo::Error::OperationFailure
+          # can be user not found, ignore
+        end
+      end
+
+      it 'creates the user' do
+        view.info(username).should == []
+
+        lambda do
+          response
+        end.should_not raise_error
+
+        view.info(username).first['user'].should == username
+      end
+    end
+
     context 'when a session is not used' do
 
       let!(:response) do
@@ -74,8 +109,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -162,8 +196,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -212,8 +245,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end

data/spec/mongo/auth/user_spec.rb

@@ -47,7 +47,7 @@ describe Mongo::Auth::User do
       it 'raises ArgumentError' do
         expect do
           user
-        end.to raise_error(Mongo::Auth::InvalidMechanism, ":invalid is invalid, please use one of the following mechanisms: :mongodb_cr, :mongodb_x509, :plain, :scram, :scram256")
+        end.to raise_error(Mongo::Auth::InvalidMechanism, ":invalid is invalid, please use one of the following mechanisms: :aws, :gssapi, :mongodb_cr, :mongodb_x509, :plain, :scram, :scram256")
       end
     end
 
@@ -325,4 +325,16 @@ describe Mongo::Auth::User do
       end
     end
   end
+
+  describe '#spec' do
+    context 'when no password and no roles are set' do
+      let(:user) do
+        described_class.new(user: 'foo')
+      end
+
+      it 'is a hash with empty roles' do
+        user.spec.should == {roles: []}
+      end
+    end
+  end
 end

data/spec/mongo/auth/x509/conversation_spec.rb

@@ -10,7 +10,7 @@ describe Mongo::Auth::X509::Conversation do
   end
 
   let(:conversation) do
-    described_class.new(user)
+    described_class.new(user, double('connection'))
   end
 
   describe '#start' do

data/spec/mongo/auth/x509_spec.rb

@@ -23,7 +23,7 @@ describe Mongo::Auth::X509 do
       end
 
       it 'works' do
-        described_class.new(user)
+        described_class.new(user, connection)
       end
     end
 
@@ -35,7 +35,7 @@ describe Mongo::Auth::X509 do
 
       it 'raises InvalidConfiguration' do
         expect do
-          described_class.new(user)
+          described_class.new(user, connection)
         end.to raise_error(Mongo::Auth::InvalidConfiguration, /User specifies auth source 'foo', but the only valid auth source for X.509 is '\$external'/)
       end
     end
@@ -44,22 +44,26 @@ describe Mongo::Auth::X509 do
   describe '#login' do
     # When x509 auth is configured, the login would work and this test
     # requires the login to fail.
-    require_no_x509_auth
+    require_no_external_user
 
     context 'when the user is not authorized for the database' do
 
+      before do
+        connection.connect!
+      end
+
       let(:x509) do
-        described_class.new(user)
+        described_class.new(user, connection)
       end
 
       let(:login) do
-        x509.login(connection).documents[0]
+        x509.login.documents[0]
       end
 
-      it 'logs the user into the connection' do
-        expect {
-          x509.login(connection)
-        }.to raise_error(Mongo::Auth::Unauthorized)
+      it 'attempts to log the user into the connection' do
+        expect do
+          x509.login
+        end.to raise_error(Mongo::Auth::Unauthorized)
       end
     end
   end

data/spec/mongo/auth_spec.rb

@@ -11,7 +11,7 @@ describe Mongo::Auth do
       end
 
       let(:cr) do
-        described_class.get(user)
+        described_class.get(user, double('connection'))
       end
 
       it 'returns CR' do
@@ -26,7 +26,7 @@ describe Mongo::Auth do
       end
 
       let(:x509) do
-        described_class.get(user)
+        described_class.get(user, double('connection'))
       end
 
       it 'returns X509' do
@@ -41,7 +41,7 @@ describe Mongo::Auth do
       end
 
       let(:ldap) do
-        described_class.get(user)
+        described_class.get(user, double('connection'))
       end
 
       it 'returns LDAP' do
@@ -57,7 +57,7 @@ describe Mongo::Auth do
 
       it 'raises an error' do
         expect {
-          described_class.get(user)
+          described_class.get(user, double('connection'))
         }.to raise_error(Mongo::Auth::InvalidMechanism)
       end
     end

data/spec/mongo/bulk_write/result_spec.rb

@@ -84,19 +84,23 @@ describe Mongo::BulkWrite::Result do
 
     context 'with top level error' do
       let(:results_document) do
-        {'writeErrors' => {
-          'ok' => 0,
-          'errmsg' => 'not master',
-          'code' => 10107,
-          'codeName' => 'NotMaster',
-        }}
+        {
+          'writeErrors' => [
+            {
+              'ok' => 0,
+              'errmsg' => 'not master',
+              'code' => 10107,
+              'codeName' => 'NotMaster',
+            }
+          ]
+        }
       end
 
       it 'raises BulkWriteError' do
         expect do
           subject.validate!
         # BulkWriteErrors don't have any messages on them
-        end.to raise_error(Mongo::Error::BulkWriteError, nil)
+        end.to raise_error(Mongo::Error::BulkWriteError, /not master/)
       end
     end
 

data/spec/mongo/bulk_write_spec.rb

@@ -235,6 +235,44 @@ describe Mongo::BulkWrite do
             expect(authorized_collection.find(_id: 0).count).to eq(0)
           end
 
+          context 'when the write has specified a hint option' do
+            let(:requests) do
+              [{
+                 delete_one: {
+                   filter: { _id: 1 },
+                   hint: '_id_',
+                 }
+               }]
+            end
+
+            context 'with unacknowledged write concern' do
+              let(:bulk_write) do
+                described_class.new(
+                  collection,
+                  requests,
+                  options.merge(write_concern: { w: 0 })
+                )
+              end
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+              end
+            end
+
+            # Functionality on more recent servers is sufficiently covered by spec tests.
+            context 'on server versions < 3.4' do
+              max_server_fcv '3.2'
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+              end
+            end
+          end
+
           context 'when a session is provided' do
 
             let(:operation) do
@@ -348,6 +386,44 @@ describe Mongo::BulkWrite do
           end
 
           context 'when bulk executing update_one' do
+            context 'when the write has specified a hint option' do
+              let(:requests) do
+                [{
+                   update_one: {
+                     filter: { _id: 1 },
+                     update: { '$set' => { 'x.$[i].y' => 5 } },
+                     hint: '_id_',
+                   }
+                 }]
+              end
+
+              # Functionality on more recent servers is sufficiently covered by spec tests.
+              context 'on server versions < 3.4' do
+                max_server_fcv '3.2'
+
+                it 'raises a client-side error' do
+                  expect do
+                    bulk_write.execute
+                  end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+                end
+              end
+
+              context 'with unacknowledged write concern' do
+                let(:bulk_write) do
+                  described_class.new(
+                    collection,
+                    requests,
+                    options.merge(write_concern: { w: 0 })
+                  )
+                end
+
+                it 'raises a client-side error' do
+                  expect do
+                    bulk_write.execute
+                  end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+                end
+              end
+            end
 
             context 'when the write has specified arrayFilters' do
 
@@ -392,6 +468,45 @@ describe Mongo::BulkWrite do
           end
 
           context 'when bulk executing update_many' do
+            context 'when the write has specified a hint option' do
+              let(:requests) do
+                [{
+                   update_many: {
+                     filter: { '$or' => [{ _id: 1 }, { _id: 2 }]},
+                     update: { '$set' => { 'x.$[i].y' => 5 } },
+                     hint: '_id_',
+                   }
+                 }]
+              end
+
+              # Functionality on more recent servers is sufficiently covered by spec tests.
+              context 'on server versions < 3.4' do
+                max_server_fcv '3.2'
+
+                it 'raises a client-side error' do
+                  expect do
+                    bulk_write.execute
+                  end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+                end
+              end
+
+              context 'with unacknowledged write concern' do
+                let(:bulk_write) do
+                  described_class.new(
+                    collection,
+                    requests,
+                    options.merge(write_concern: { w: 0 })
+                  )
+                end
+
+                it 'raises a client-side error' do
+                  expect do
+                    bulk_write.execute
+                  end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+                end
+              end
+            end
+
 
             context 'when the write has specified arrayFilters' do
 
@@ -639,6 +754,44 @@ describe Mongo::BulkWrite do
             expect(authorized_collection.find(_id: 0).count).to eq(0)
           end
 
+          context 'when the write has specified a hint option' do
+            let(:requests) do
+              [{
+                 delete_many: {
+                   filter: { _id: 1 },
+                   hint: '_id_',
+                 }
+               }]
+            end
+
+            # Functionality on more recent servers is sufficiently covered by spec tests.
+            context 'on server versions < 3.4' do
+              max_server_fcv '3.2'
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+              end
+            end
+
+            context 'with unacknowledged write concern' do
+              let(:bulk_write) do
+                described_class.new(
+                  collection,
+                  requests,
+                  options.merge(write_concern: { w: 0 })
+                )
+              end
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+              end
+            end
+          end
+
           context 'when a session is provided' do
 
             let(:operation) do
@@ -918,6 +1071,45 @@ describe Mongo::BulkWrite do
             expect(authorized_collection.find(_id: 0).first[:name]).to eq('test')
           end
 
+          context 'when a hint option is provided' do
+            let(:requests) do
+              [{
+                replace_one: {
+                  filter: { _id: 0 },
+                  replacements: { name: 'test' },
+                  hint: '_id_'
+                }
+              }]
+            end
+
+            # Functionality on more recent servers is sufficiently covered by spec tests.
+            context 'on server versions < 3.4' do
+              max_server_fcv '3.2'
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The MongoDB server handling this request does not support the hint option on this command./)
+              end
+            end
+
+            context 'with unacknowledged write concern' do
+              let(:bulk_write) do
+                described_class.new(
+                  collection,
+                  requests,
+                  options.merge(write_concern: { w: 0 })
+                )
+              end
+
+              it 'raises a client-side error' do
+                expect do
+                  bulk_write.execute
+                end.to raise_error(Mongo::Error::UnsupportedOption, /The hint option cannot be specified on an unacknowledged write operation/)
+              end
+            end
+          end
+
           context 'when a session is provided' do
 
             let(:operation) do
@@ -1141,13 +1333,17 @@ describe Mongo::BulkWrite do
             end
 
             context 'when the number of updates exceeds the max batch size' do
+              # Test uses doubles for server descriptions, doubles are
+              # incompatible with freezing which linting does for descriptions
+              skip_if_linting
 
               let(:batch_size) do
                 11
               end
 
               before do
-                allow(client.cluster.next_primary).to receive(:max_write_batch_size).and_return(batch_size - 1)
+                allow_any_instance_of(Mongo::Server::Description).to \
+                  receive(:max_write_batch_size).and_return(batch_size - 1)
               end
 
               let(:requests) do
@@ -1814,13 +2010,21 @@ describe Mongo::BulkWrite do
       end
 
       context 'when the operations need to be split' do
+        # Test uses doubles for server descriptions, doubles are
+        # incompatible with freezing which linting does for descriptions
+        skip_if_linting
 
         let(:batch_size) do
           11
         end
 
+        let(:connection) do
+          server = client.cluster.next_primary
+        end
+
         before do
-          allow(client.cluster.next_primary).to receive(:max_write_batch_size).and_return(batch_size - 1)
+          allow_any_instance_of(Mongo::Server::Description).to \
+            receive(:max_write_batch_size).and_return(batch_size - 1)
         end
 
         context 'when a write error occurs' do
@@ -1924,11 +2128,11 @@ describe Mongo::BulkWrite do
             end
 
             let(:first_txn_number) do
-              started_events[-2].command['txnNumber'].value
+              Utils.int64_value(started_events[-2].command['txnNumber'])
             end
 
             let(:second_txn_number) do
-              started_events[-1].command['txnNumber'].value
+              Utils.int64_value(started_events[-1].command['txnNumber'])
             end
 
             it 'inserts the documents' do