mollie-api-ruby 4.0.0 → 4.0.1

data/examples/subscriptions/get.rb

@@ -1,4 +1,4 @@
 subscription = Mollie::Customer::Subscription.get(
-  "sub_rVKGtNd6s3",
-  customer_id: "cst_5a2pPrwaWy"
+  'sub_rVKGtNd6s3',
+  customer_id: 'cst_5a2pPrwaWy'
 )

data/examples/subscriptions/list.rb

@@ -1 +1 @@
-subscriptions = Mollie::Customer::Subscription.all(customer_id: "cst_5a2pPrwaWy")
+subscriptions = Mollie::Customer::Subscription.all(customer_id: 'cst_5a2pPrwaWy')

data/examples/subscriptions/update.rb

@@ -1,5 +1,5 @@
 subscription = Mollie::Customer::Subscription.update(
   'sub_rVKGtNd6s3',
-  customer_id: 'cst_5a2pPrwaWy'
+  customer_id: 'cst_5a2pPrwaWy',
   amount: { value: '20.00', currency: 'EUR' }
 )

data/lib/cacert.pem

@@ -1,7 +1,7 @@
 ##
 ## Bundle of CA Root Certificates
 ##
-## Certificate data from Mozilla as of: Fri Jun  1 09:01:33 2018 GMT
+## Certificate data from Mozilla as of: Tue Sep  4 09:47:40 2018 GMT
 ##
 ## This is a bundle of X.509 certificates of public Certificate Authorities
 ## (CA). These were automatically extracted from Mozilla's root certificates
@@ -14,7 +14,7 @@
 ## Just configure this file as the SSLCACertificateFile.
 ##
 ## Conversion done with mk-ca-bundle.pl version 1.27.
-## SHA256: 704f02707ec6b4c4a7597a8c6039b020def11e64f3ef0605a9c3543d48038a57
+## SHA256: c80f571d9f4ebca4a91e0ad3a546f263153d71afffc845c6f8f52ce9d1a2e8ec
 ##
 
 
@@ -2635,30 +2635,6 @@ kbcFgKyLmZJ956LYBws2J+dIeWCKw9cTXPhyQN9Ky8+ZAAoACxGV2lZFA4gKn2fQ1XmxqI1AbQ3C
 ekD6819kR5LLU7m7Wc5P/dAVUwHY3+vZ5nbv0CO7O6l5s9UCKc2Jo5YPSjXnTkLAdc0Hz+Ys63su
 -----END CERTIFICATE-----
 
-TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H5
-====================================================
------BEGIN CERTIFICATE-----
-MIIEJzCCAw+gAwIBAgIHAI4X/iQggTANBgkqhkiG9w0BAQsFADCBsTELMAkGA1UEBhMCVFIxDzAN
-BgNVBAcMBkFua2FyYTFNMEsGA1UECgxEVMOcUktUUlVTVCBCaWxnaSDEsGxldGnFn2ltIHZlIEJp
-bGnFn2ltIEfDvHZlbmxpxJ9pIEhpem1ldGxlcmkgQS7Fni4xQjBABgNVBAMMOVTDnFJLVFJVU1Qg
-RWxla3Ryb25payBTZXJ0aWZpa2EgSGl6bWV0IFNhxJ9sYXnEsWPEsXPEsSBINTAeFw0xMzA0MzAw
-ODA3MDFaFw0yMzA0MjgwODA3MDFaMIGxMQswCQYDVQQGEwJUUjEPMA0GA1UEBwwGQW5rYXJhMU0w
-SwYDVQQKDERUw5xSS1RSVVNUIEJpbGdpIMSwbGV0acWfaW0gdmUgQmlsacWfaW0gR8O8dmVubGnE
-n2kgSGl6bWV0bGVyaSBBLsWeLjFCMEAGA1UEAww5VMOcUktUUlVTVCBFbGVrdHJvbmlrIFNlcnRp
-ZmlrYSBIaXptZXQgU2HEn2xhecSxY8Sxc8SxIEg1MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB
-CgKCAQEApCUZ4WWe60ghUEoI5RHwWrom/4NZzkQqL/7hzmAD/I0Dpe3/a6i6zDQGn1k19uwsu537
-jVJp45wnEFPzpALFp/kRGml1bsMdi9GYjZOHp3GXDSHHmflS0yxjXVW86B8BSLlg/kJK9siArs1m
-ep5Fimh34khon6La8eHBEJ/rPCmBp+EyCNSgBbGM+42WAA4+Jd9ThiI7/PS98wl+d+yG6w8z5UNP
-9FR1bSmZLmZaQ9/LXMrI5Tjxfjs1nQ/0xVqhzPMggCTTV+wVunUlm+hkS7M0hO8EuPbJbKoCPrZV
-4jI3X/xml1/N1p7HIL9Nxqw/dV8c7TKcfGkAaZHjIxhT6QIDAQABo0IwQDAdBgNVHQ4EFgQUVpkH
-HtOsDGlktAxQR95DLL4gwPswDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8wDQYJKoZI
-hvcNAQELBQADggEBAJ5FdnsXSDLyOIspve6WSk6BGLFRRyDN0GSxDsnZAdkJzsiZ3GglE9Rc8qPo
-BP5yCccLqh0lVX6Wmle3usURehnmp349hQ71+S4pL+f5bFgWV1Al9j4uPqrtd3GqqpmWRgqujuwq
-URawXs3qZwQcWDD1YIq9pr1N5Za0/EKJAWv2cMhQOQwt1WbZyNKzMrcbGW3LM/nfpeYVhDfwwvJl
-lpKQd/Ct9JDpEXjXk4nAPQu6KfTomZ1yju2dL+6SfaHx/126M2CFYv4HAqGEVka+lgqaE9chTLd8
-B59OTj+RdPsnnRHM3eaxynFNExc5JsUpISuTKWqW+qtB4Uu2NQvAmxU=
------END CERTIFICATE-----
-
 Certinomis - Root CA
 ====================
 -----BEGIN CERTIFICATE-----

data/lib/mollie.rb

@@ -5,7 +5,6 @@ require 'bigdecimal'
 require 'net/https'
 
 module Mollie
-
 end
 
 require 'mollie/exception'

data/lib/mollie/amount.rb

@@ -7,7 +7,7 @@ module Mollie
     end
 
     def value=(val)
-      @value = BigDecimal.new(val.to_s)
+      @value = BigDecimal(val.to_s)
     end
 
     def to_h

data/lib/mollie/base.rb

@@ -15,7 +15,7 @@ module Mollie
 
     class << self
       def create(data = {})
-        request("POST", nil, data) do |response|
+        request('POST', nil, data) do |response|
           new(response)
         end
       end
@@ -24,25 +24,25 @@ module Mollie
         id      = nil
         data    = {}
 
-        request("GET", id, data, options) do |response|
+        request('GET', id, data, options) do |response|
           Mollie::List.new(response, self)
         end
       end
 
       def get(id, options = {})
-        request("GET", id, {}, options) do |response|
+        request('GET', id, {}, options) do |response|
           new(response)
         end
       end
 
       def update(id, data = {})
-        request("PATCH", id, data) do |response|
+        request('PATCH', id, data) do |response|
           new(response)
         end
       end
 
       def delete(id, options = {})
-        request("DELETE", id, options)
+        request('DELETE', id, options)
       end
 
       def request(method, id = 0, data = {}, options = {})
@@ -52,15 +52,15 @@ module Mollie
       end
 
       def id_param
-        "#{name.downcase.split("::")[-1]}_id".to_sym
+        "#{name.downcase.split('::')[-1]}_id".to_sym
       end
 
       def parent_id
-        "#{name.downcase.split("::")[-2]}_id".to_sym
+        "#{name.downcase.split('::')[-2]}_id".to_sym
       end
 
       def resource_name(parent_id = nil)
-        path = name.downcase.split("::").slice(1..-1).map(&Util.method(:pluralize))
+        path = name.downcase.split('::').slice(1..-1).map(&Util.method(:pluralize))
 
         if path.size == 2 && parent_id
           path.join("/#{parent_id}/")

data/lib/mollie/chargeback.rb

@@ -1,6 +1,5 @@
 module Mollie
   class Chargeback < Base
-
     attr_accessor :id,
                   :payment,
                   :amount,
@@ -10,18 +9,26 @@ module Mollie
                   :reversed_at,
                   :_links
 
-    alias_method :links, :_links
+    alias links _links
 
     def reversed?
       !!reversed_at
     end
 
     def reversed_at=(reversed_at)
-      @reversed_at = Time.parse(reversed_at) rescue nil
+      @reversed_at = begin
+                       Time.parse(reversed_at)
+                     rescue StandardError
+                       nil
+                     end
     end
 
     def created_at=(created_at)
-      @created_at = Time.parse(created_at) rescue nil
+      @created_at = begin
+                      Time.parse(created_at)
+                    rescue StandardError
+                      nil
+                    end
     end
 
     def amount=(amount)
@@ -37,10 +44,9 @@ module Mollie
     end
 
     def settlement(options = {})
-      settlement_id = Util.extract_id(links, "settlement")
+      settlement_id = Util.extract_id(links, 'settlement')
       return if settlement_id.nil?
       Settlement.get(settlement_id, options)
     end
-
   end
 end

data/lib/mollie/client.rb

@@ -1,10 +1,10 @@
 module Mollie
   class Client
-    API_ENDPOINT = 'https://api.mollie.com'
-    API_VERSION  = 'v2'
+    API_ENDPOINT = 'https://api.mollie.com'.freeze
+    API_VERSION  = 'v2'.freeze
 
-    MODE_TEST = 'test'
-    MODE_LIVE = 'live'
+    MODE_TEST = 'test'.freeze
+    MODE_LIVE = 'live'.freeze
 
     class << self
       attr_accessor :configuration
@@ -66,9 +66,9 @@ module Mollie
       api_key      = http_body.delete(:api_key) || query.delete(:api_key) || @api_key
       api_endpoint = http_body.delete(:api_endpoint) || query.delete(:api_endpoint) || @api_endpoint
 
-      if query.length > 0
+      unless query.empty?
         camelized_query = Util.camelize_keys(query)
-        path            += "?#{build_nested_query(camelized_query)}"
+        path += "?#{build_nested_query(camelized_query)}"
       end
 
       uri                = URI.parse(api_endpoint)
@@ -81,19 +81,19 @@ module Mollie
       when 'GET'
         request = Net::HTTP::Get.new(path)
       when 'POST'
-        http_body.delete_if { |k, v| v.nil? }
+        http_body.delete_if { |_k, v| v.nil? }
         request      = Net::HTTP::Post.new(path)
         request.body = Util.camelize_keys(http_body).to_json
       when 'PATCH'
-        http_body.delete_if { |k, v| v.nil? }
+        http_body.delete_if { |_k, v| v.nil? }
         request      = Net::HTTP::Patch.new(path)
         request.body = Util.camelize_keys(http_body).to_json
       when 'DELETE'
-        http_body.delete_if { |k, v| v.nil? }
+        http_body.delete_if { |_k, v| v.nil? }
         request      = Net::HTTP::Delete.new(path)
         request.body = Util.camelize_keys(http_body).to_json
       else
-        raise Mollie::Exception.new("Invalid HTTP Method: #{http_method}")
+        raise Mollie::Exception, "Invalid HTTP Method: #{http_method}"
       end
 
       request['Accept']        = 'application/json'
@@ -104,8 +104,8 @@ module Mollie
       begin
         response = client.request(request)
       rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, EOFError,
-        Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError => e
-        raise Mollie::Exception.new(e.message)
+             Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError => e
+        raise Mollie::Exception, e.message
       end
 
       http_code = response.code.to_i
@@ -126,17 +126,17 @@ module Mollie
     def build_nested_query(value, prefix = nil)
       case value
       when Array
-        value.map { |v|
+        value.map do |v|
           build_nested_query(v, "#{prefix}[]")
-        }.join("&")
+        end.join('&')
       when Hash
-        value.map { |k, v|
+        value.map do |k, v|
           build_nested_query(v, prefix ? "#{prefix}[#{escape(k)}]" : escape(k))
-        }.reject(&:empty?).join('&')
+        end.reject(&:empty?).join('&')
       when nil
         prefix
       else
-        raise ArgumentError, "value must be a Hash" if prefix.nil?
+        raise ArgumentError, 'value must be a Hash' if prefix.nil?
         "#{prefix}=#{escape(value)}"
       end
     end

data/lib/mollie/customer/mandate.rb

@@ -1,9 +1,9 @@
 module Mollie
   class Customer
     class Mandate < Base
-      STATUS_VALID   = "valid"
-      STATUS_INVALID = "invalid"
-      STATUS_PENDING = "pending"
+      STATUS_VALID   = 'valid'.freeze
+      STATUS_INVALID = 'invalid'.freeze
+      STATUS_PENDING = 'pending'.freeze
 
       attr_accessor :id,
                     :status,
@@ -14,14 +14,18 @@ module Mollie
                     :created_at,
                     :_links
 
-      alias_method :links, :_links
+      alias links _links
 
       def details=(details)
         @details = OpenStruct.new(details) if details.is_a?(Hash)
       end
 
       def created_at=(created_at)
-        @created_at = Time.parse(created_at.to_s) rescue nil
+        @created_at = begin
+                        Time.parse(created_at.to_s)
+                      rescue StandardError
+                        nil
+                      end
       end
 
       def valid?
@@ -37,7 +41,7 @@ module Mollie
       end
 
       def customer(options = {})
-        customer_id = Util.extract_id(links, "customer")
+        customer_id = Util.extract_id(links, 'customer')
         Customer.get(customer_id, options)
       end
     end

data/lib/mollie/customer/subscription.rb

@@ -1,11 +1,11 @@
 module Mollie
   class Customer
     class Subscription < Base
-      STATUS_ACTIVE    = "active"
-      STATUS_PENDING   = "pending" # Waiting for a valid mandate.
-      STATUS_CANCELED  = "canceled"
-      STATUS_SUSPENDED = "suspended" # Active, but mandate became invalid.
-      STATUS_COMPLETED = "completed"
+      STATUS_ACTIVE    = 'active'.freeze
+      STATUS_PENDING   = 'pending'.freeze # Waiting for a valid mandate.
+      STATUS_CANCELED  = 'canceled'.freeze
+      STATUS_SUSPENDED = 'suspended'.freeze # Active, but mandate became invalid.
+      STATUS_COMPLETED = 'completed'.freeze
 
       attr_accessor :id,
                     :customer_id,
@@ -41,11 +41,19 @@ module Mollie
       end
 
       def created_at=(created_at)
-        @created_at = Time.parse(created_at.to_s) rescue nil
+        @created_at = begin
+                        Time.parse(created_at.to_s)
+                      rescue StandardError
+                        nil
+                      end
       end
 
       def canceled_at=(canceled_at)
-        @canceled_at = Time.parse(canceled_at.to_s) rescue nil
+        @canceled_at = begin
+                         Time.parse(canceled_at.to_s)
+                       rescue StandardError
+                         nil
+                       end
       end
 
       def amount=(amount)

data/lib/mollie/exception.rb

@@ -2,7 +2,7 @@ module Mollie
   class Exception < StandardError
   end
 
-  class RequestError < Exception
+  class RequestError < RuntimeError
     attr_accessor :status, :title, :detail, :field, :links
 
     def initialize(error)

data/lib/mollie/invoice.rb

@@ -1,8 +1,8 @@
 module Mollie
   class Invoice < Base
-    STATUS_OPEN    = "open"
-    STATUS_PAID    = "paid"
-    STATUS_OVERDUE = "overdue"
+    STATUS_OPEN    = 'open'.freeze
+    STATUS_PAID    = 'paid'.freeze
+    STATUS_OVERDUE = 'overdue'.freeze
 
     class Line < Base
       attr_accessor :period, :description, :count, :vat_percentage, :amount
@@ -25,7 +25,7 @@ module Mollie
                   :lines,
                   :_links
 
-    alias_method :links, :_links
+    alias links _links
 
     def open?
       status == STATUS_OPEN
@@ -52,11 +52,19 @@ module Mollie
     end
 
     def issued_at=(issued_at)
-      @issued_at = Time.parse(issued_at) rescue nil
+      @issued_at = begin
+                     Time.parse(issued_at)
+                   rescue StandardError
+                     nil
+                   end
     end
 
     def due_at=(due_at)
-      @due_at = Time.parse(due_at) rescue nil
+      @due_at = begin
+                  Time.parse(due_at)
+                rescue StandardError
+                  nil
+                end
     end
 
     def lines=(lines)

data/lib/mollie/list.rb

@@ -3,19 +3,19 @@ module Mollie
     include Enumerable
 
     attr_accessor :klass, :items, :_links
-    alias_method :links, :_links
+    alias links _links
 
     def initialize(list_attributes, klass)
       @klass = klass
 
-      if list_attributes['_embedded']
-        list_attributes['items'] ||= list_attributes['_embedded'].fetch(klass.resource_name, [])
-      else
-        list_attributes['items'] ||= []
-      end
+      list_attributes['items'] ||= if list_attributes['_embedded']
+                                     list_attributes['_embedded'].fetch(klass.resource_name, [])
+                                   else
+                                     []
+                                   end
       super list_attributes
 
-      @items = self.items.map do |attributes|
+      @items = items.map do |attributes|
         klass.new attributes
       end
     end
@@ -25,9 +25,7 @@ module Mollie
     end
 
     def next(options = {})
-      if links['next'].nil?
-        return self.class.new({}, klass)
-      end
+      return self.class.new({}, klass) if links['next'].nil?
 
       href = URI.parse(links['next']['href'])
       query = URI.decode_www_form(href.query).to_h
@@ -36,9 +34,7 @@ module Mollie
     end
 
     def previous(options = {})
-      if links['previous'].nil?
-        return self.class.new({}, klass)
-      end
+      return self.class.new({}, klass) if links['previous'].nil?
 
       href = URI.parse(links['previous']['href'])
       query = URI.decode_www_form(href.query).to_h