mollie-api-ruby 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d2b2306f3e3c4a027d9b0eeca909f303ebe89be4
-  data.tar.gz: 0ff02d85a7fc3608abccdf5ad76e7c53e4040c31
+SHA256:
+  metadata.gz: dc0a692631f366a82801cfacbddd3a374feb23c4246cad015f5d5d28442bbe6f
+  data.tar.gz: 13bab05f6eee4826daaf8147e696fc1c5b8fd828a35e3dd56697ef756e97ac77
 SHA512:
-  metadata.gz: 372a9ac1d7c37a4f0009210ca2afebf55b63d255ef548a2acaad85dec36ada88697d4460bca79daa5490d7b7722a2702c9bd7115af6b7e4cfeeb67a1f1bab28c
-  data.tar.gz: ab9251c647ae11dddfa13bb064f5e36cedc08087e1840730fd89c9fd62798d6ba5b08dc3b244852e2ca9527cb76bd14a60134388b45ecd689258cab3313827ea
+  metadata.gz: 0eca2506d8f26e6de42661531956513f04292d59f87711ac8b26e584b9fd61d8c905bfaa68da20c96a7b2d08eedf8edfc955f7b9cc4658cbe3e663611f66bfde
+  data.tar.gz: 2d9c0f92e0349014398dae906afe85cc32ecf32d8a8c2fe739bbbae2d0ad85f8563bdc0b56f357e1f238cf1f0f4424f0d95c5110555d67f3d0b20e3b816b945d

data/.rubocop.yml

@@ -0,0 +1,10 @@
+inherit_from: .rubocop_todo.yml
+
+Lint/UselessAssignment:
+  Exclude:
+    - 'examples/**/*'
+
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Exclude:
+    - 'test/run-test.rb'

data/.rubocop_todo.yml

@@ -0,0 +1,92 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-08-19 13:42:13 +0200 using RuboCop version 0.58.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'mollie-api-ruby.gemspec'
+
+# Offense count: 45
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/mollie/amount.rb'
+    - 'lib/mollie/chargeback.rb'
+    - 'lib/mollie/client.rb'
+    - 'lib/mollie/customer.rb'
+    - 'lib/mollie/customer/mandate.rb'
+    - 'lib/mollie/customer/subscription.rb'
+    - 'lib/mollie/invoice.rb'
+    - 'lib/mollie/organization.rb'
+    - 'lib/mollie/payment.rb'
+    - 'lib/mollie/profile.rb'
+    - 'lib/mollie/refund.rb'
+    - 'lib/mollie/settlement.rb'
+
+# Offense count: 15
+Metrics/AbcSize:
+  Max: 227
+
+# Offense count: 7
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 295
+
+# Offense count: 1
+Metrics/CyclomaticComplexity:
+  Max: 13
+
+# Offense count: 37
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 140
+
+# Offense count: 1
+Metrics/PerceivedComplexity:
+  Max: 10
+
+# Offense count: 1
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at
+Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'lib/mollie/client.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'test/mollie/client_test.rb'
+
+# Offense count: 21
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 2
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/mollie/base.rb'
+    - 'lib/mollie/chargeback.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/mollie/util.rb'
+    - 'test/mollie/client_test.rb'
+
+# Offense count: 164
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 157

data/.travis.yml

@@ -6,9 +6,11 @@ rvm:
  - 2.3.0
 matrix:
 deploy:
+  gem: mollie-api-ruby
   provider: rubygems
   api_key:
-    secure: eBq3/esJILG/1rs9mYwD/6QEybpiElDihqRO6sPH17D9e+lMYVXsaBxrBQutWLB9i7V176mbN/z/VR/fHbj8/xDYEuKzTnFwaROZpckX0dmwp8SRdBA1Lleq/zeQwhjeOLSSAJBxZXTSJcKQ5YQaUvojVIh1ky+rAz20QxyYHV8=
+    secure: "JdYKjK+AZNNviyAW92ta16Kk/u1gLTyvUVjoiSrGchsMmx8pN107MERpn5klFzOTKcnmMn+h3eA0RzhsuA+eFBfd5X58kNlXzXzKzKvOKmjrH69jiUWAJ5PmepacvsKMCAovOOtkskFzifKUUkrkPv87KO1J97wsZ4ASX6q3MRs="
   on:
     tags: true
+    repo: mollie/mollie-api-ruby
     rvm: 2.3.0

data/CHANGELOG.md

@@ -7,7 +7,7 @@ All notable changes to this project will be documented in this file.
 #### 4.0 - 2018-07-23
 
   - Migrated to the v2 API
-    Refer to the [migration guide](/docs/migration_v3_x.md) for a complete list of changes
+  - Refer to the [migration guide](/docs/migration_v3_x.md) for a complete list of changes
   - Dropped Ruby 2.0.0 support.
 
 #### 3.1.0 - ....

data/Gemfile

@@ -1,3 +1,3 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 gemspec

data/Rakefile

@@ -1,6 +1,5 @@
 task default: %w[test]
 
 task :test do
-  ruby "test/run-test.rb"
+  ruby 'test/run-test.rb'
 end
-

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "mollie"
+require 'bundler/setup'
+require 'mollie'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,6 +10,6 @@ require "mollie"
 # require "pry"
 # Pry.start
 
-require "irb"
-require "pp"
+require 'irb'
+require 'pp'
 IRB.start(__FILE__)

data/docs/migration_v2_2_x.md

@@ -50,7 +50,7 @@ Change the client calls to Resource calls
 #)
 
 payment = Mollie::Payment.create(
-  amount:       { amount: '10.00', currency: 'EUR' },
+  amount:       { value: '10.00', currency: 'EUR' },
   description:  'My first API payment',
   redirect_url: 'https://webshop.example.org/order/12345/',
   webhook_url:  'https://webshop.example.org/mollie-webhook/'

data/docs/migration_v3_x.md

@@ -1,7 +1,7 @@
 # Migration from v3.x
 
-Please refer to [Migrating from v1 to v2](https://docs.mollie.com/migrating-v1-to-v2)
-for a general overview of the switch to Mollie v2 API.
+Version 4.x of the Ruby client uses the v2 Mollie API. Please refer to [Migrating from v1 to v2](https://docs.mollie.com/migrating-v1-to-v2)
+for a general overview of the changes introduced by the new Mollie API.
 
 Code examples can be found in the [/examples](/examples) folder.
 

data/examples/chargebacks/get.rb

@@ -1,4 +1,4 @@
 chargeback = Mollie::Payment::Chargeback.get(
-  "chb_n9z0tp",
-  payment_id: "tr_7UhSN1zuXS"
+  'chb_n9z0tp',
+  payment_id: 'tr_7UhSN1zuXS'
 )

data/examples/customers/create-payment.rb

@@ -1,6 +1,6 @@
 payment = Mollie::Customer::Payment.create(
-  customer_id:  "cst_8wmqcHMN4U",
-  amount:       { value: "10.00", currency: "EUR" },
-  description:  "First payment",
-  redirect_url: "https://webshop.example.org/order/12345/"
+  customer_id:  'cst_8wmqcHMN4U',
+  amount:       { value: '10.00', currency: 'EUR' },
+  description:  'First payment',
+  redirect_url: 'https://webshop.example.org/order/12345/'
 )

data/examples/customers/create.rb

@@ -1,5 +1,5 @@
 customer = Mollie::Customer.create(
-  name:     "John",
-  email:    "john@example.com",
-  locale:   "en_US"
+  name:     'John',
+  email:    'john@example.com',
+  locale:   'en_US'
 )

data/examples/customers/delete.rb

@@ -1 +1 @@
-Mollie::Customer.delete("cst_8wmqcHMN4U")
+Mollie::Customer.delete('cst_8wmqcHMN4U')

data/examples/customers/get.rb

@@ -1 +1 @@
-customer = Mollie::Customer.get("cst_8wmqcHMN4U")
+customer = Mollie::Customer.get('cst_8wmqcHMN4U')

data/examples/customers/list-payments.rb

@@ -1 +1 @@
-payments = Mollie::Customer::Payment.all(customer_id: "cst_8wmqcHMN4U")
+payments = Mollie::Customer::Payment.all(customer_id: 'cst_8wmqcHMN4U')

data/examples/customers/update.rb

@@ -1,4 +1,4 @@
 customer = Mollie::Customer.update(
-  "cst_8wmqcHMN4U",
-  email: "otherjohn@example.com"
+  'cst_8wmqcHMN4U',
+  email: 'otherjohn@example.com'
 )

data/examples/invoices/get.rb

@@ -1 +1 @@
-invoice = Mollie::Invoice.get("inv_xBEbP9rvAq")
+invoice = Mollie::Invoice.get('inv_xBEbP9rvAq')

data/examples/mandates/create.rb

@@ -1,9 +1,9 @@
 mandate = Mollie::Customer::Mandate.create(
-  customer_id:       "cst_4qqhO89gsT",
-  method:            "directdebit",
-  consumer_name:     "John Doe",
-  consumer_account:  "NL55INGB0000000000",
-  consumer_bic:      "INGBNL2A",
-  signature_date:    "2018-05-07",
-  mandate_reference: "YOUR-COMPANY-MD13804",
+  customer_id:       'cst_4qqhO89gsT',
+  method:            'directdebit',
+  consumer_name:     'John Doe',
+  consumer_account:  'NL55INGB0000000000',
+  consumer_bic:      'INGBNL2A',
+  signature_date:    '2018-05-07',
+  mandate_reference: 'YOUR-COMPANY-MD13804'
 )

data/examples/mandates/delete.rb

@@ -1 +1 @@
-Mollie::Customer::Mandate.delete("mdt_h3gAaD5zP", customer_id: "cst_4qqhO89gsT")
+Mollie::Customer::Mandate.delete('mdt_h3gAaD5zP', customer_id: 'cst_4qqhO89gsT')

data/examples/mandates/get.rb

@@ -1 +1 @@
-mandate = Mollie::Customer::Mandate.get("mdt_h3gAaD5zP", customer_id: "cst_4qqhO89gsT")
+mandate = Mollie::Customer::Mandate.get('mdt_h3gAaD5zP', customer_id: 'cst_4qqhO89gsT')

data/examples/mandates/list.rb

@@ -1 +1 @@
-mandates = Mollie::Customer::Mandate.all(customer_id: "cst_4qqhO89gsT")
+mandates = Mollie::Customer::Mandate.all(customer_id: 'cst_4qqhO89gsT')

data/examples/methods/get.rb

@@ -1,4 +1,4 @@
-method = Mollie::Method.get("ideal")
+method = Mollie::Method.get('ideal')
 
 # Include iDEAL issuers
-method = Mollie::Method.get("ideal", include: "issuers")
+method = Mollie::Method.get('ideal', include: 'issuers')

data/examples/organisations/get.rb

@@ -1 +1 @@
-organization = Mollie::Organization.get("org_1234567")
+organization = Mollie::Organization.get('org_1234567')

data/examples/payments/delete.rb

@@ -1 +1 @@
-Mollie::Payment.delete("tr_7UhSN1zuXS")
+Mollie::Payment.delete('tr_7UhSN1zuXS')

data/examples/payments/get-customer.rb

@@ -1,2 +1,2 @@
-payment  = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment  = Mollie::Payment.get('tr_7UhSN1zuXS')
 customer = payment.customer

data/examples/payments/get-mandate.rb

@@ -1,2 +1,2 @@
-payment = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment = Mollie::Payment.get('tr_7UhSN1zuXS')
 mandate = payment.mandate

data/examples/payments/get-settlement.rb

@@ -1,2 +1,2 @@
-payment = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment = Mollie::Payment.get('tr_7UhSN1zuXS')
 settlement = payment.settlement

data/examples/payments/get-subscription.rb

@@ -1,2 +1,2 @@
-payment = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment = Mollie::Payment.get('tr_7UhSN1zuXS')
 subscription = payment.subscription

data/examples/payments/get.rb

@@ -1 +1 @@
-payment = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment = Mollie::Payment.get('tr_7UhSN1zuXS')

data/examples/payments/webhook.rb

@@ -1,4 +1,4 @@
-payment = Mollie::Payment.get("tr_7UhSN1zuXS")
+payment = Mollie::Payment.get('tr_7UhSN1zuXS')
 
 if payment.paid?
   #

data/examples/permissions/get.rb

@@ -1 +1 @@
-permission = Mollie::Permission.get("payments.read")
+permission = Mollie::Permission.get('payments.read')

data/examples/profiles/create.rb

@@ -1,8 +1,8 @@
 profile = Mollie::Profile.create(
-  name:         "My website name",
-  website:      "https://www.mywebsite.com",
-  email:        "info@mywebsite.com",
-  phone:        "+31208202070",
-  categoryCode: "5399",
-  mode:         "live"
+  name:         'My website name',
+  website:      'https://www.mywebsite.com',
+  email:        'info@mywebsite.com',
+  phone:        '+31208202070',
+  categoryCode: '5399',
+  mode:         'live'
 )

data/examples/profiles/delete.rb

@@ -1 +1 @@
-Mollie::Profile.delete("pfl_v9hTwCvYqw")
+Mollie::Profile.delete('pfl_v9hTwCvYqw')

data/examples/profiles/get.rb

@@ -1 +1 @@
-profile = Mollie::Profile.get("pfl_v9hTwCvYqw")
+profile = Mollie::Profile.get('pfl_v9hTwCvYqw')

data/examples/profiles/list-chargebacks.rb

@@ -1,2 +1,2 @@
-profile     = Profile.get("pfl_v9hTwCvYqw")
+profile     = Profile.get('pfl_v9hTwCvYqw')
 chargebacks = profile.chargebacks

data/examples/profiles/list-methods.rb

@@ -1,2 +1,2 @@
-profile = Profile.get("pfl_v9hTwCvYqw")
+profile = Profile.get('pfl_v9hTwCvYqw')
 methods = profile.methods

data/examples/profiles/list-payments.rb

@@ -1,2 +1,2 @@
-profile  = Profile.get("pfl_v9hTwCvYqw")
+profile  = Profile.get('pfl_v9hTwCvYqw')
 payments = profile.payments

data/examples/profiles/list-refunds.rb

@@ -1,2 +1,2 @@
-profile = Profile.get("pfl_v9hTwCvYqw")
+profile = Profile.get('pfl_v9hTwCvYqw')
 refunds = profile.refunds

data/examples/profiles/update.rb

@@ -1,5 +1,5 @@
 profile = Mollie::Profile.update(
-  "pfl_v9hTwCvYqw",
-  name:    "My website name",
-  website: "https://www.mywebsite.com"
+  'pfl_v9hTwCvYqw',
+  name:    'My website name',
+  website: 'https://www.mywebsite.com'
 )

data/examples/refunds/create.rb

@@ -1,5 +1,5 @@
 refund = Mollie::Payment::Refund.create(
-  payment_id:  "tr_7UhSN1zuXS",
-  amount:      { value: "5.00", currency: "EUR" },
-  description: "Did not like it"
+  payment_id:  'tr_7UhSN1zuXS',
+  amount:      { value: '5.00', currency: 'EUR' },
+  description: 'Did not like it'
 )

data/examples/refunds/delete.rb

@@ -1,4 +1,4 @@
 Mollie::Payment::Refund.delete(
-  "re_4qqhO89gsT",
-  payment_id: "tr_7UhSN1zuXS"
+  're_4qqhO89gsT',
+  payment_id: 'tr_7UhSN1zuXS'
 )

data/examples/refunds/get.rb

@@ -1,4 +1,4 @@
 refund = Mollie::Payment::Refund.get(
-  "re_4qqhO89gsT",
-  payment_id: "tr_7UhSN1zuXS"
+  're_4qqhO89gsT',
+  payment_id: 'tr_7UhSN1zuXS'
 )

data/examples/settlements/get.rb

@@ -1 +1 @@
-settlement = Mollie::Settlement.get("stl_jDk30akdN")
+settlement = Mollie::Settlement.get('stl_jDk30akdN')

data/examples/settlements/list-chargebacks.rb

@@ -1 +1 @@
-chargebacks = Mollie::Settlement::Chargeback.all(settlement_id: "stl_jDk30akdN")
+chargebacks = Mollie::Settlement::Chargeback.all(settlement_id: 'stl_jDk30akdN')

data/examples/settlements/list-payments.rb

@@ -1 +1 @@
-payments = Mollie::Settlement::Payment.all(settlement_id: "stl_jDk30akdN")
+payments = Mollie::Settlement::Payment.all(settlement_id: 'stl_jDk30akdN')

data/examples/settlements/list-refunds.rb

@@ -1 +1 @@
-refunds = Mollie::Settlement::Refund.all(settlement_id: "stl_jDk30akdN")
+refunds = Mollie::Settlement::Refund.all(settlement_id: 'stl_jDk30akdN')

data/examples/subscriptions/create.rb

@@ -1,8 +1,8 @@
 subscription = Mollie::Customer::Subscription.create(
-  customer_id: "cst_5a2pPrwaWy",
-  amount:      { value: "20.00", currency: "EUR" },
+  customer_id: 'cst_5a2pPrwaWy',
+  amount:      { value: '20.00', currency: 'EUR' },
   times:       4,
-  interval:    "3 months",
-  description: "Quarterly payment",
-  webhook_url: "https://webshop.example.org/payments/webhook/"
+  interval:    '3 months',
+  description: 'Quarterly payment',
+  webhook_url: 'https://webshop.example.org/payments/webhook/'
 )

data/examples/subscriptions/delete.rb

@@ -1,4 +1,4 @@
 Mollie::Customer::Subscription.delete(
-  "sub_rVKGtNd6s3",
-  customer_id: "cst_5a2pPrwaWy"
+  'sub_rVKGtNd6s3',
+  customer_id: 'cst_5a2pPrwaWy'
 )