mno-enterprise-api 3.1.4 → 3.2.0

data/spec/controllers/mno_enterprise/jpi/v1/admin/app_answers_controller_spec.rb

@@ -0,0 +1,45 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::Admin::AppAnswersController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+
+    #===============================================
+    # Assignments
+    #===============================================
+    let(:user) { build(:user, :admin, :with_organizations) }
+    let(:organization) { user.organizations.first }
+    let(:question) { build(:app_question) }
+
+    before { api_stub_for(get: "/organization/#{organization.id}", response: from_api(organization)) }
+    before { api_stub_for(get: "/users/#{user.id}/organizations", response: from_api([organization])) }
+    before { api_stub_for(get: "/users/#{user.id}", response: from_api(user)) }
+    before { api_stub_for(get: "/app_questions/#{question.id}", response: from_api(question)) }
+    before { sign_in user }
+
+    let(:answer_1) { build(:app_answer, question_id: 'qid') }
+    let(:expected_hash_for_answer_1) do
+      attrs = %w(id description status user_id user_name organization_id organization_name app_id question_id app_name)
+      answer_1.attributes.slice(*attrs).merge({'type' => 'Answer', 'created_at' => answer_1.created_at.as_json, 'updated_at' => answer_1.updated_at.as_json})
+    end
+
+    describe 'POST #create', focus: true do
+      let(:params) { {description: 'A Review', foo: 'bar'} }
+
+      before do
+        api_stub_for(post: "/app_answers", response: from_api(answer_1))
+        api_stub_for(get: "/app_answers/#{answer_1.id}", response: from_api(answer_1))
+      end
+
+      subject { post :create, app_answer: params, question_id: question.id }
+
+      it 'renders the new review' do
+        expect(JSON.parse(subject.body)).to include('app_answer' => expected_hash_for_answer_1)
+      end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/admin/app_comments_controller_spec.rb

@@ -0,0 +1,45 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::Admin::AppCommentsController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+
+    #===============================================
+    # Assignments
+    #===============================================
+    let(:user) { build(:user, :admin, :with_organizations) }
+    let(:organization) { user.organizations.first }
+    let(:feedback) { build(:app_feedback) }
+
+    before { api_stub_for(get: "/organization/#{organization.id}", response: from_api(organization)) }
+    before { api_stub_for(get: "/users/#{user.id}/organizations", response: from_api([organization])) }
+    before { api_stub_for(get: "/users/#{user.id}", response: from_api(user)) }
+    before { api_stub_for(get: "/app_feedbacks/#{feedback.id}", response: from_api(feedback)) }
+    before { sign_in user }
+
+    let(:comment_1) { build(:app_comment, feedback_id: 'fid') }
+    let(:expected_hash_for_comment_1) do
+      attrs = %w(id description status user_id user_name organization_id organization_name type app_id feedback_id app_name)
+      comment_1.attributes.slice(*attrs).merge({'type'=>'Comment', 'created_at' => comment_1.created_at.as_json, 'updated_at' => comment_1.updated_at.as_json})
+    end
+
+    describe 'POST #create', focus: true do
+      let(:params) { {description: 'A Review', foo: 'bar'} }
+
+      before do
+        api_stub_for(post: "/app_comments", response: from_api(comment_1))
+        api_stub_for(get: "/app_comments/#{comment_1.id}", response: from_api(comment_1))
+      end
+
+      subject { post :create, app_comment: params, feedback_id: feedback.id }
+
+      it 'renders the new review' do
+        expect(JSON.parse(subject.body)).to include('app_comment' => expected_hash_for_comment_1)
+      end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/admin/app_instances_controller_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+# TODO: spec AppInstance response
+module MnoEnterprise
+  include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
+
+  describe Jpi::V1::Admin::AppInstancesController, type: :controller do
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    let(:user) { build(:user, :admin, :with_organizations) }
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    describe 'DELETE #destroy' do
+      # Stub AppInstance
+      let(:app_instance) { build(:app_instance) }
+      before { api_stub_for(get: "/app_instances/#{app_instance.id}", respond_with: app_instance)}
+      before { api_stub_for(delete: "/app_instances/#{app_instance.id}", response: ->{ app_instance.status = 'terminated'; from_api(app_instance) }) }
+
+      subject { delete :destroy, id: app_instance.id }
+
+      it_behaves_like "a jpi v1 admin action"
+
+      it { subject; expect(app_instance.status).to eq('terminated') }
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/admin/app_reviews_controller_spec.rb

@@ -0,0 +1,103 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
+
+  describe Jpi::V1::Admin::AppReviewsController, type: :controller do
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env['HTTP_ACCEPT'] = 'application/json' }
+    let(:user) { build(:user, :admin, :with_organizations) }
+    let(:app_review) { build(:app_review, user: user) }
+    before do
+      api_stub_for(get: '/app_reviews', response: from_api([app_review]))
+      api_stub_for(get: "/app_reviews/#{app_review.id}", response: from_api(app_review))
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    def partial_hash_for_app_review(app_review)
+      {
+        'id' => app_review.id,
+        'rating' => app_review.rating,
+        'description' => app_review.description,
+        'status' => app_review.status,
+        'app_id' => app_review.app_id,
+        'app_name' => app_review.app_name,
+        'user_id' => app_review.user_id,
+        'user_name' => app_review.user_name,
+        'organization_id' => app_review.organization_id,
+        'organization_name' => app_review.organization_name,
+        'type'       => app_review.type,
+        'created_at' => app_review.created_at,
+        'updated_at' => app_review.updated_at,
+      }
+    end
+
+    def hash_for_app_review(app_review)
+      {
+        'app_review' => partial_hash_for_app_review(app_review)
+      }
+    end
+
+    def hash_for_app_reviews(app_reviews)
+      {
+        'app_reviews' => app_reviews.map { |o| partial_hash_for_app_review(o) }
+      }
+    end
+
+
+    describe '#index' do
+      subject { get :index }
+
+      it_behaves_like "a jpi v1 admin action"
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a list of app_review' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_app_reviews([app_review]).to_json))
+        end
+      end
+    end
+
+    describe 'GET #show' do
+      subject { get :show, id: app_review.id }
+
+      it_behaves_like "a jpi v1 admin action"
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a complete description of the app_review' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_app_review(app_review).to_json))
+        end
+      end
+    end
+
+
+    describe 'PUT #update' do
+      subject { put :update, id: app_review.id, app_review: {status: 'rejected'} }
+
+      before do
+        sign_in user
+        api_stub_for(put: "/app_reviews/#{app_review.id}", response: -> { app_review.status = 'rejected'; from_api(app_review) })
+      end
+
+      it_behaves_like "a jpi v1 admin action"
+
+      context 'success' do
+        before { subject }
+
+        it { expect(response).to be_success }
+
+        # Test that the app_review is updated by testing the api endpoint was called
+        it { expect(app_review.status).to eq('rejected') }
+      end
+    end
+
+
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/admin/audit_events_controller_spec.rb

@@ -2,7 +2,8 @@ require 'rails_helper'
 
 module MnoEnterprise
   describe Jpi::V1::Admin::AuditEventsController, type: :controller do
-    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
+
     render_views
     routes { MnoEnterprise::Engine.routes }
     before { request.env["HTTP_ACCEPT"] = 'application/json' }
@@ -10,15 +11,9 @@ module MnoEnterprise
     #===============================================
     # Assignments
     #===============================================
-    # Stub controller ability
-    # let!(:ability) { stub_ability }
-    # before { allow(ability).to receive(:can?).with(any_args).and_return(true) }
-
-    # # Stub user and user call
+    # Stub user and user call
     let(:user) { FactoryGirl.build(:user, :admin) }
     before { api_stub_for(get: "/users/#{user.id}", response: from_api(user)) }
-    # before { api_stub_for(get: '/users?filter%5Bemail%5D&limit=1', response: from_api(nil)) }
-
     before { sign_in user }
 
     let(:audit_event) { FactoryGirl.build(:audit_event) }
@@ -27,13 +22,7 @@ module MnoEnterprise
     describe 'GET #index' do
       subject { get :index }
 
-      # TODO it_behaves_like for admin
-      # it_behaves_like 'jpi v1 protected action'
-
-      it 'is successful' do
-        subject
-        expect(response).to be_success
-      end
+      it_behaves_like 'a jpi v1 admin action'
 
       context 'sucess' do
         it 'assigns @audit_events' do

data/spec/controllers/mno_enterprise/jpi/v1/admin/cloud_apps_controller_spec.rb

@@ -2,6 +2,7 @@ require 'rails_helper'
 
 module MnoEnterprise
   describe Jpi::V1::Admin::CloudAppsController, type: :controller do
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
     render_views
     routes { MnoEnterprise::Engine.routes }
     before { request.env["HTTP_ACCEPT"] = 'application/json' }
@@ -24,7 +25,9 @@ module MnoEnterprise
 
       describe "#index" do
         subject { get :index }
-        
+
+        it_behaves_like 'a jpi v1 admin action'
+
         it 'returns the cloud aplications' do
           subject
           expect(JSON.parse(response.body)).to eq({"cloud_apps"=>[{"id"=>app.id, "uid"=>app.uid, "name"=>app.name, "api_key"=>app.api_key, "tiny_description"=>app.tiny_description, "description"=>app.description, "metadata_url"=>nil, "details"=>nil, "terms_url"=>app.terms_url}]})
@@ -37,6 +40,8 @@ module MnoEnterprise
 
         before { allow(MnoEnterprise::App).to receive(:find) { app } }
 
+        it_behaves_like 'a jpi v1 admin action'
+
         it 'assigns the cloud app' do
           subject
           expect(assigns[:cloud_app]).to eq(app)
@@ -61,7 +66,9 @@ module MnoEnterprise
 
       describe "#regenerate_api_key" do
         subject { put :regenerate_api_key, id: app.id }
-        
+
+        it_behaves_like 'a jpi v1 admin action'
+
         it 'regenerates the API key' do
           expect_any_instance_of(MnoEnterprise::App).to receive(:regenerate_api_key!)
           subject
@@ -70,7 +77,9 @@ module MnoEnterprise
 
       describe "#refresh_metadata" do
         subject { put :refresh_metadata, id: app.id, metadata_url: 'http://test.com' }
-        
+
+        it_behaves_like 'a jpi v1 admin action'
+
         context 'with a valid response' do
           it 'refreshes the metadata' do
             expect(subject).to render_template(:show)

data/spec/controllers/mno_enterprise/jpi/v1/admin/invites_controller_spec.rb

@@ -2,6 +2,7 @@ require 'rails_helper'
 
 module MnoEnterprise
   RSpec.describe Jpi::V1::Admin::InvitesController do
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
     routes { MnoEnterprise::Engine.routes }
     before { request.env['HTTP_ACCEPT'] = 'application/json' }
 
@@ -42,6 +43,9 @@ module MnoEnterprise
     describe 'POST #create' do
       subject { post :create, user_id: invitee.id, organization_id: organization.id }
 
+      before { allow(SystemNotificationMailer).to receive(:organization_invite).with(invite).and_return(message_delivery) }
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'existing user' do
         it 'sends the invitation email' do
           expect(SystemNotificationMailer).to receive(:organization_invite).with(invite).and_return(message_delivery)

data/spec/controllers/mno_enterprise/jpi/v1/admin/invoices_controller_spec.rb

@@ -2,6 +2,7 @@ require 'rails_helper'
 
 module MnoEnterprise
   describe Jpi::V1::Admin::InvoicesController, type: :controller do
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
     render_views
     routes { MnoEnterprise::Engine.routes }
     before { request.env["HTTP_ACCEPT"] = 'application/json' }
@@ -56,6 +57,8 @@ module MnoEnterprise
     describe '#index' do
       subject { get :index }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -69,6 +72,8 @@ module MnoEnterprise
     describe 'GET #show' do
       subject { get :show, id: invoice.id }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -82,6 +87,8 @@ module MnoEnterprise
     describe 'GET #current_billing_amount' do
       subject { get :current_billing_amount }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'with an old MnoHub' do
         let(:tenant) { build(:old_tenant) }
 
@@ -110,6 +117,8 @@ module MnoEnterprise
     describe 'GET #last_invoicing_amount' do
       subject { get :last_invoicing_amount }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -125,6 +134,8 @@ module MnoEnterprise
     describe 'GET #outstanding_amount' do
       subject { get :outstanding_amount }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
         let(:outstanding_amount) { {'outstanding_amount' => {"amount"=>"1789.86", "currency"=>"AUD"}} }
@@ -139,6 +150,8 @@ module MnoEnterprise
     describe 'GET #last_portfolio_amount' do
       subject { get :last_portfolio_amount }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -155,6 +168,8 @@ module MnoEnterprise
     describe 'GET #last_commission_amount' do
       subject { get :last_commission_amount }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
         let(:last_commission_amount) { {'last_commission_amount' => {"amount"=>"4123.45", "currency"=>"AUD"}} }

data/spec/controllers/mno_enterprise/jpi/v1/admin/organizations_controller_spec.rb

@@ -3,6 +3,8 @@ require 'rails_helper'
 module MnoEnterprise
   describe Jpi::V1::Admin::OrganizationsController, type: :controller do
     include MnoEnterprise::TestingSupport::OrganizationsSharedHelpers
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
+
     render_views
     routes { MnoEnterprise::Engine.routes }
     before { request.env["HTTP_ACCEPT"] = 'application/json' }
@@ -43,7 +45,9 @@ module MnoEnterprise
     let(:credit_card) { build(:credit_card, organization: organization) }
 
     before do
-      allow_any_instance_of(MnoEnterprise::User).to receive(:organizations).and_return([organization]) # ???
+      organizations = [organization]
+      allow(organizations).to receive(:loaded?).and_return(true)
+      allow_any_instance_of(MnoEnterprise::User).to receive(:organizations).and_return(organizations)
       api_stub_for(get: "/organizations/#{organization.id}/invoices", response: from_api([invoice]))
       api_stub_for(get: "/organizations", response: from_api([organization]))
       api_stub_for(get: "/organizations/#{organization.id}", response: from_api(organization))
@@ -75,6 +79,8 @@ module MnoEnterprise
     describe '#index' do
       subject { get :index }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -89,6 +95,8 @@ module MnoEnterprise
     describe 'GET #show' do
       subject { get :show, id: organization.id }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -104,6 +112,8 @@ module MnoEnterprise
     describe 'GET #in_arrears' do
       subject { get :in_arrears }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       context 'success' do
         before { subject }
 
@@ -120,6 +130,8 @@ module MnoEnterprise
 
       subject { post :create, organization: params }
 
+      it_behaves_like 'a jpi v1 admin action'
+
       it 'creates the organization' do
         expect(MnoEnterprise::Organization).to receive(:create).with(params.slice(:name)) { organization }
         subject
@@ -153,6 +165,8 @@ module MnoEnterprise
       context 'with existing user' do
         before { allow(MnoEnterprise::User).to receive(:find_by) { user } }
 
+        it_behaves_like 'a jpi v1 admin action'
+
         it 'creates an invite' do
           subject
           expect(@api_call).to be true
@@ -166,6 +180,8 @@ module MnoEnterprise
         let(:new_user) { build(:user, params.slice(:email, :name, :surname, :phone)) }
         before { allow(controller).to receive(:create_unconfirmed_user) { new_user } }
 
+        it_behaves_like 'a jpi v1 admin action'
+
         it 'creates a user' do
           expect(controller).to receive(:create_unconfirmed_user) { new_user }
           subject