mno-enterprise-api 3.1.4 → 3.2.0

data/spec/controllers/mno_enterprise/jpi/v1/team_controller_spec.rb

@@ -49,12 +49,15 @@ module MnoEnterprise
     before { allow(ability).to receive(:can?).with(any_args).and_return(true) }
 
     # Stub user and user call
+    let!(:app) { build(:app) }
     let(:user) { build(:user, :with_organizations) }
     let(:user2) { build(:user, :with_organizations, name: "Joe") }
     let(:organization) { build(:organization) }
     let(:team) { build(:team, organization: organization) }
-    let(:app_instance) { build(:app_instance) }
+    let(:app_instance) { build(:app_instance, app: app, app_id: app.id) }
     before do
+      api_stub_for(get: '/apps', response: from_api([app]))
+      api_stub_for(get: "/apps/#{app.id}", response: from_api(app))
       api_stub_for(get: "/users/#{user.id}", response: from_api(user))
       api_stub_for(get: "/users/#{user.id}/organizations", response: from_api(organization))
       api_stub_for(post: "/organizations", response: from_api(organization))

data/spec/controllers/mno_enterprise/pages_controller_spec.rb

@@ -31,6 +31,19 @@ module MnoEnterprise
       end
     end
 
+    describe 'GET #launch with parameters' do
+      let(:app_instance) { build(:app_instance) }
+      before { sign_in user }
+      subject { get :launch, id: app_instance.uid, specific_parameters: 'specific_parameters_value' }
+
+      it_behaves_like "a navigatable protected user action"
+
+      it 'redirects to the mno enterprise launch page with a web token and extra params' do
+        subject
+        expect(response).to redirect_to(MnoEnterprise.router.launch_url(app_instance.uid, wtk: MnoEnterprise.jwt({user_id: user.uid}), specific_parameters: 'specific_parameters_value'))
+      end
+    end
+
     describe 'GET #app_access_unauthorized' do
       subject { get :app_access_unauthorized }
       before { subject }
@@ -49,5 +62,13 @@ module MnoEnterprise
       it { expect(response).to be_success }
     end
 
+    describe 'GET #terms' do
+      before { api_stub_for(get: "/apps", response: from_api([build(:app)])) }
+
+      subject { get :terms }
+      before { subject }
+      it { expect(response).to be_success }
+    end
+
   end
 end

data/spec/controllers/mno_enterprise/provision_controller_spec.rb

@@ -1,5 +1,9 @@
 require 'rails_helper'
 
+def mnoe_home_path
+  controller.send(:mnoe_home_path)
+end
+
 module MnoEnterprise
   describe ProvisionController, type: :controller do
     render_views
@@ -27,39 +31,73 @@ module MnoEnterprise
         it { expect(response).to redirect_to(new_user_registration_path) }
       end
 
-      # TODO: ability to add app instances for an organization
-      describe 'signed in and missing organization with multiple organizations available' do
-        let(:params_org_id) { nil }
+      context 'signed in' do
         let(:authorized) { true }
         before do
-          allow_any_instance_of(User).to receive(:organizations).and_return([organization, organization])
+          allow_any_instance_of(User).to receive(:organizations).and_return(organizations)
           sign_in user
-          allow(ability).to receive(:can?).with(any_args).and_return(authorized)
+          allow(ability).to receive(:cannot?).with(:manage_app_instances, organization).and_return(!authorized)
           subject
         end
 
-        it { expect(response).to render_template('mno_enterprise/provision/_select_organization') }
+        context 'without organization_id' do
+          let(:params_org_id) { nil }
 
-        describe "unauthorized" do
-          let(:authorized) { false }
-          it { expect(response).to redirect_to(root_path) }
-        end
-      end
+          context 'with multiple organizations available' do
+            let(:organizations) { [organization, organization] }
+            it { expect(response).to render_template('mno_enterprise/provision/_select_organization') }
+          end
 
-      describe 'signed in and missing organization with one organization available' do
-        let(:params_org_id) { nil }
-        let(:authorized) { true }
-        before do
-          sign_in user
-          allow(ability).to receive(:can?).with(any_args).and_return(authorized)
-          subject
+          context 'with one organization available' do
+            let(:organizations) { [organization] }
+
+            it { expect(response).to render_template('mno_enterprise/provision/_provision_apps') }
+            it { expect(assigns[:organization]).to eq(organization) }
+
+            describe "unauthorized" do
+              let(:authorized) { false }
+
+              let(:error_fragment) { "#?#{URI.encode_www_form([['flash', {msg: "Unfortunately you do not have permission to purchase products for this organization", type: :error}.to_json]])}" }
+
+              it 'redirect to the dashboard with an error message' do
+                expect(response).to redirect_to(mnoe_home_path + error_fragment)
+              end
+            end
+          end
         end
 
-        it { expect(response).to render_template('mno_enterprise/provision/_provision_apps') }
-        describe "unauthorized" do
-          let(:authorized) { false }
-          it { expect(response).to redirect_to(root_path) }
+        context 'with organization_id' do
+          let(:organizations) { [organization, organization] }
+
+          context 'authorized' do
+            it { expect(response).to render_template('mno_enterprise/provision/_provision_apps') }
+          end
+
+          context 'unauthorized' do
+            let(:authorized) { false }
+            context 'with multiple organizations available' do
+              let(:organizations) { [organization, organization] }
+
+              it 'display an errors message and display the list of organization' do
+                subject
+                expect(controller).to set_flash.now[:alert] #.to('Unfortunately you do not have permission to purchase products for this organization')
+                expect(response).to be_success
+              end
+
+              it { expect(response).to render_template('mno_enterprise/provision/_select_organization') }
+            end
+
+            context 'with one organization available' do
+              let(:organizations) { [organization] }
+              let(:error_fragment) { "#?#{URI.encode_www_form([['flash', {msg: "Unfortunately you do not have permission to purchase products for this organization", type: :error}.to_json]])}" }
+
+              it 'redirect to the dashboard with an error message' do
+                expect(response).to redirect_to(mnoe_home_path + error_fragment)
+              end
+            end
+          end
         end
+
       end
     end
 
@@ -87,6 +125,11 @@ module MnoEnterprise
         end
 
         it { expect(response).to be_success }
+
+        it 'deletes the previous url from session to avoid double provisioning' do
+          subject
+          expect(session[:previous_url]).to be_nil
+        end
       end
     end
 

data/spec/controllers/mno_enterprise/webhook/o_auth_controller_spec.rb

@@ -80,7 +80,7 @@ module MnoEnterprise
       it_behaves_like 'a navigatable protected user action'
       it_behaves_like 'a user protected resource'
 
-      it { subject; expect(response).to redirect_to(redirect_url) }
+      it { subject; expect(response).to redirect_to redirect_url }
     end
 
     describe 'GET #sync' do

data/spec/jobs/mno_enterprise/event_logger_job_spec.rb

@@ -0,0 +1,11 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  RSpec.describe EventLoggerJob, type: :job do
+    it 'dispatch the notification to the event logger' do
+      args = ['app_destroy', 1, 'App destroyed', 'Xero', build(:app_instance)]
+      expect(EventLogger).to receive(:send_info).with(*args)
+      EventLoggerJob.perform_now(:info, *args)
+    end
+  end
+end

data/spec/lib/mno_enterprise/audit_events_listener_spec.rb

@@ -0,0 +1,28 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  RSpec.describe AuditEventsListener do
+
+    def info_data(user)
+      {
+        data: {
+          key: 'user_update_password',
+          user_id: user.id,
+          description: 'User password change',
+          metadata: user.email,
+          subject_type: user.class.name,
+          subject_id: user.id
+        }
+      }
+    end
+
+    let(:user) { build(:user) }
+
+    describe '#info' do
+      subject { MnoEnterprise::AuditEventsListener.new.info('user_update_password', user.id, 'User password change', user.class.name, user.id, user.email) }
+
+      it { expect(subject.code).to eq(200) }
+      it { expect(subject.request.options[:body]).to eq(info_data(user)) }
+    end
+  end
+end

data/spec/lib/mno_enterprise/intercom_events_listener_spec.rb

@@ -0,0 +1,110 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  RSpec.describe IntercomEventsListener do
+    let(:app) { build(:app) }
+    let(:app_instance) { build(:app_instance, app: app, organization_id: organization.id) }
+    let(:user) { build(:user) }
+    let(:organization) { build(:organization) }
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      api_stub_for(get: "/users/#{user.id}/organizations", response: from_api([organization]))
+      api_stub_for(get: "/organizations/#{organization.id}/app_instances", response: from_api([app_instance]))
+    end
+
+    # Stub Intercom client
+    let(:tags) { double('tags') }
+    let(:events) { double('events') }
+    let(:users) { double('users') }
+    let(:client) { double('client', users: users, events: events, tags: tags) }
+    before do
+      expect(Intercom::Client).to receive(:new).with(app_id: MnoEnterprise.intercom_app_id, api_key: MnoEnterprise.intercom_api_key).and_return(client)
+    end
+
+    let(:expected_user_data) {
+      {
+        user_id: user.id,
+        name: [user.name, user.surname].join(' '),
+        email: user.email,
+        created_at: user.created_at.to_i,
+        last_seen_ip: user.last_sign_in_ip,
+        custom_attributes: {phone: user.phone},
+        update_last_request_at: true,
+        companies:[
+          {
+            company_id: organization.id,
+            name: organization.name,
+            created_at: organization.created_at.to_i,
+            custom_attributes: {
+              industry: organization.industry,
+              size: organization.size,
+              credit_card_details: organization.credit_card?,
+              app_count: organization.app_instances.count,
+              app_list: organization.app_instances.map { |app| app.name }.to_sentence
+            }
+          }
+        ]
+      }
+    }
+
+    describe '#info' do
+      context 'when the user already exist in intercom' do
+        before { allow(users).to receive(:find) }
+        subject { described_class.new }
+
+        it 'add an event when an password is changed' do
+          expect(events).to receive(:create).with(hash_including(email: user.email, user_id: user.id, event_name: 'user-update-password'))
+          subject.info('user_update_password', user.id, 'User password change', user.class.name, user.id, user.email)
+        end
+
+        it 'add an event when an app is added' do
+          expect(events).to receive(:create).with(hash_including(email: user.email, user_id: user.id, event_name: 'added-app-' + app.nid, metadata: {type: 'single', app_list: app.nid}))
+          subject.info('app_add', user.id, 'App Added', app_instance.class.name, app_instance.id, {name: app_instance.name, app_nid: app_instance.app.nid} )
+        end
+
+        it 'add an event when an app is launched' do
+          expect(events).to receive(:create).with(hash_including(email: user.email, user_id: user.id, event_name: 'launched-app-' + app.nid))
+          subject.info('app_launch', user.id, 'App Launched', app_instance.class.name, app_instance.id, {name: app_instance.name, app_nid: app_instance.app.nid} )
+        end
+
+      end
+      context 'when the user does not exist in intercom' do
+        before do
+          allow(users).to receive(:find).and_raise(Intercom::ResourceNotFound.new('not found'))
+          expect(users).to receive(:create).with(expected_user_data)
+        end
+
+        it 'add an event when an password is changed' do
+          expect(events).to receive(:create).with(hash_including(email: user.email, event_name: 'user-update-password'))
+          subject.info('user_update_password', user.id, 'User password change', user.class.name, user.id, user.email)
+        end
+      end
+    end
+
+    describe '#update_intercom_user' do
+      subject { described_class.new.update_intercom_user(user) }
+      before { allow(users).to receive(:create) }
+
+      it 'updates the user' do
+        expect(users).to receive(:create).with(expected_user_data)
+        subject
+      end
+
+      context 'when the user has an external_id' do
+        before { user.external_id = '132456' }
+        it 'updates the user' do
+          expect(users).to receive(:create).with(hash_including(custom_attributes: { phone: user.phone, external_id: '132456' }))
+          subject
+        end
+      end
+
+      context 'when the user has a source' do
+        before { user.meta_data = {source: 'acme'}}
+        it 'tags the user' do
+          expect(tags).to receive(:tag).with(name: 'acme', users: [{user_id: user.id}])
+          subject
+        end
+      end
+    end
+  end
+end

data/spec/mailer/mno_enterprise/system_notification_mailer_spec.rb

@@ -14,6 +14,10 @@ module MnoEnterprise
       { first_name: user.name, last_name: user.surname, full_name: "#{user.name} #{user.surname}".strip }
     end
 
+    def recipient(user)
+      { name: "#{user.name} #{user.surname}".strip, email: user.email }
+    end
+
     def invite_vars(org_invite)
       new_user = !org_invite.user.confirmed?
 
@@ -31,63 +35,95 @@ module MnoEnterprise
       }
     end
 
+    # Custom matcher to DRY the code
+    # TODO: extract to `testing_support`? Still dependent on local variables
+    RSpec::Matchers.define :send_the_correct_user_email do |template, extra_user_vars|
+      match do |block|
+        expect(MnoEnterprise::MailClient).to receive(:deliver).with(
+          template,
+          SystemNotificationMailer::DEFAULT_SENDER,
+          recipient(user),
+          user_vars(user).merge(extra_user_vars)
+        )
+        block.call
+        true
+      end
+
+      description do
+        "send the correct user email (\"#{template}\")"
+      end
+
+      supports_block_expectations
+    end
+
     describe 'confirmation_instructions' do
       describe 'new user' do
-        it 'sends the right email' do
-          expect(MnoEnterprise::MailClient).to receive(:deliver).with('confirmation-instructions',
-            SystemNotificationMailer::DEFAULT_SENDER,
-            { name: "#{user.name} #{user.surname}".strip, email: user.email },
-            user_vars(user).merge(confirmation_link: routes.user_confirmation_url(confirmation_token: token))
+        let(:user) { build(:user, :unconfirmed) }
+        it do
+          expect {
+            subject.confirmation_instructions(user,token).deliver_now
+          }.to send_the_correct_user_email(
+                 'confirmation-instructions',
+                 confirmation_link: routes.user_confirmation_url(confirmation_token: token)
           )
-        
-          subject.confirmation_instructions(user,token).deliver_now
         end
       end
-      
+
       describe 'existing user with new email address' do
-        before { allow_any_instance_of(MnoEnterprise::User).to receive(:confirmed?).and_return(true) }
-        before { allow_any_instance_of(MnoEnterprise::User).to receive(:unconfirmed_email?).and_return(true) }
-        
-        it 'sends the right email' do
-          expect(MnoEnterprise::MailClient).to receive(:deliver).with('reconfirmation-instructions',
+        before { user.unconfirmed_email = 'unconfirmed@test.com' }
+
+        it 'sends confirmation to new and old email address' do
+          expect(MnoEnterprise::MailClient).to receive(:deliver).with(
+            'reconfirmation-instructions',
             SystemNotificationMailer::DEFAULT_SENDER,
-            { name: "#{user.name} #{user.surname}".strip, email: user.email },
+            recipient(user).merge(email: 'unconfirmed@test.com'),
             user_vars(user).merge(confirmation_link: routes.user_confirmation_url(confirmation_token: token))
           )
-        
-          subject.confirmation_instructions(user,token).deliver_now
+
+          expect {
+            subject.confirmation_instructions(user,token).deliver_now
+          }.to send_the_correct_user_email(
+                 'email-change',
+                 unconfirmed_email: 'unconfirmed@test.com'
+          )
         end
       end
     end
-    
+
     describe 'reset_password_instructions' do
-      it 'sends the right email' do
-        expect(MnoEnterprise::MailClient).to receive(:deliver).with('reset-password-instructions',
-          SystemNotificationMailer::DEFAULT_SENDER,
-          { name: "#{user.name} #{user.surname}".strip, email: user.email },
-          user_vars(user).merge(reset_password_link: routes.edit_user_password_url(reset_password_token: token))
+      it do
+        expect {
+          subject.reset_password_instructions(user,token).deliver_now
+        }.to send_the_correct_user_email(
+               'reset-password-instructions',
+               reset_password_link: routes.edit_user_password_url(reset_password_token: token)
         )
-        
-        subject.reset_password_instructions(user,token).deliver_now
       end
     end
-    
+
     describe 'unlock_instructions' do
-      it 'sends the right email' do
-        expect(MnoEnterprise::MailClient).to receive(:deliver).with('unlock-instructions',
-          SystemNotificationMailer::DEFAULT_SENDER,
-          { name: "#{user.name} #{user.surname}".strip, email: user.email },
-          user_vars(user).merge(unlock_link: routes.user_unlock_url(unlock_token: token))
+      it do
+        expect {
+          subject.unlock_instructions(user,token).deliver_now
+        }.to send_the_correct_user_email(
+               'unlock-instructions',
+               unlock_link: routes.user_unlock_url(unlock_token: token)
         )
-        
-        subject.unlock_instructions(user,token).deliver_now
       end
     end
-    
+
+    describe 'password_change' do
+      it 'sends an email to notify the user' do
+        expect {
+          subject.password_change(user).deliver_now
+        }.to send_the_correct_user_email('password-change', {})
+      end
+    end
+
     describe 'organization_invite' do
       let(:invitee) { build(:user) }
       let(:org_invite) { build(:org_invite, user: invitee, referrer: user) }
-      
+
       context 'when invitee is a confirmed user' do
         it 'sends the right email' do
           expect(MnoEnterprise::MailClient).to receive(:deliver).with('organization-invite-existing-user',
@@ -95,21 +131,21 @@ module MnoEnterprise
             { name: "#{invitee.name} #{invitee.surname}".strip, email: invitee.email },
             invite_vars(org_invite).merge(confirmation_link: routes.org_invite_url(id: org_invite.id, token: org_invite.token))
           )
-        
+
           subject.organization_invite(org_invite).deliver_now
         end
       end
-      
+
       context 'when inviteee is an unconfirmed user' do
         let(:invitee) { build(:user, :unconfirmed) }
-        
+
         it 'sends the right email' do
           expect(MnoEnterprise::MailClient).to receive(:deliver).with('organization-invite-new-user',
             SystemNotificationMailer::DEFAULT_SENDER,
             { email: invitee.email },
             invite_vars(org_invite).merge(confirmation_link: routes.user_confirmation_url(confirmation_token: invitee.confirmation_token))
           )
-        
+
           subject.organization_invite(org_invite).deliver_now
         end
       end
@@ -117,14 +153,13 @@ module MnoEnterprise
     end
 
     describe 'deletion_request_instructions' do
-      it 'sends the correct email' do
-        expect(MnoEnterprise::MailClient).to receive(:deliver).with('deletion-request-instructions',
-          SystemNotificationMailer::DEFAULT_SENDER,
-          { name: "#{user.name} #{user.surname}".strip, email: user.email },
-          user_vars(user).merge(terminate_account_link: routes.deletion_request_url(deletion_request))
-        )
-
-        subject.deletion_request_instructions(user,deletion_request).deliver_now
+      it do
+        expect {
+          subject.deletion_request_instructions(user,deletion_request).deliver_now
+        }.to send_the_correct_user_email(
+               'deletion-request-instructions',
+               terminate_account_link: routes.deletion_request_url(deletion_request)
+             )
       end
     end