mms-api 0.1.5 → 0.2.0

data/lib/mms/resource/host.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::Host < Resource
-
     attr_accessor :name
     attr_accessor :hostname
     attr_accessor :port
@@ -30,12 +28,12 @@ module MMS
       MMS::Resource::Snapshot.find(@client, group.id, nil, @id, id)
     end
 
-    def snapshots(page = 1, limit = 1000)
+    def snapshots(page = 1, limit = 100)
       if @snapshots.empty?
         @client.get('/groups/' + group.id + '/hosts/' + @id + '/snapshots?pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |snapshot|
           s = MMS::Resource::Snapshot.new
-          s.set_client(@client)
-          s.set_data(snapshot)
+          s.client(@client)
+          s.data(snapshot)
 
           @snapshots.push s
         end
@@ -58,18 +56,18 @@ module MMS
     # @param [MMS::Client] client
     # @param [String] group_id
     # @param [String] id
-    # @returns [Hash]
+    # @return [Hash]
     def self._find(client, group_id, id)
       client.get('/groups/' + group_id + '/hosts/' + id)
     end
 
-    # @returns [Array<MMS::Resource::Metric>]
+    # @return [Array<MMS::Resource::Metric>]
     def metrics
       if @metric_list.empty?
         @client.get('/groups/' + group.id + '/hosts/' + @id + '/metrics').each do |metric|
           m = MMS::Resource::Metric.new
-          m.set_client(@client)
-          m.set_data(metric)
+          m.client(@client)
+          m.data(metric)
 
           @metric_list.push m
         end
@@ -77,8 +75,6 @@ module MMS
       @metric_list
     end
 
-    private
-
     def _from_hash(data)
       @hostname = data['hostname']
       @port = data['port']
@@ -99,6 +95,5 @@ module MMS
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/resource/metric.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::Metric < Resource
-
     attr_accessor :name
     attr_accessor :units
     attr_accessor :granularity
@@ -12,7 +10,7 @@ module MMS
     end
 
     # @param [Hash] options
-    # @returns [Array<Hash>]
+    # @return [Array<Hash>]
     def data_points(options = {})
       series = []
       metric_data = get_metric_data(options)
@@ -31,7 +29,7 @@ module MMS
     # @param [String] group_id
     # @param [String] host_id
     # @param [String] metric_name
-    # @returns [Hash]
+    # @return [Hash]
     def self._find(client, group_id, host_id, metric_name)
       client.get('/groups/' + group_id + '/hosts/' + host_id + '/metrics/' + metric_name)
     end
@@ -39,12 +37,12 @@ module MMS
     private
 
     # @param [Hash] options
-    # @param [String] name
-    # @returns [Hash]
+    # @param [String] d_name
+    # @return [Hash]
     def get_metric_data(options = {}, d_name = '')
       params = options.map { |k, v| "#{k}=#{v}" }.join('&')
       ret = client.get("/groups/#{@data['groupId']}/hosts/#{@data['hostId']}/metrics/#{@data['metricName']}/#{d_name}?#{params}")
-      ret.delete("links")
+      ret.delete('links')
       ret
     end
 

data/lib/mms/resource/restore_job.rb

@@ -1,9 +1,7 @@
 require 'date'
 
 module MMS
-
   class Resource::RestoreJob < Resource
-
     attr_accessor :name
 
     # this is source point from where RestoreJob was created
@@ -44,17 +42,17 @@ module MMS
     end
 
     def table_row
-      time_str = DateTime.parse(@timestamp).strftime("%m/%d/%Y %H:%M")
+      time_str = DateTime.parse(@timestamp).strftime('%m/%d/%Y %H:%M')
       [time_str, @snapshot_id, @name, @status_name, @point_in_time, @delivery_method_name, @delivery_status_name]
     end
 
     def table_section
       [
         table_row,
-        [@id, "#{cluster.name} (#{cluster.id})", {:value => '', :colspan => 5}],
-        ['', cluster.group.name, {:value => '', :colspan => 5}],
-        [{:value => 'download url:', :colspan => 7}],
-        [{:value => @delivery_url || '(waiting for link)', :colspan => 7}],
+        [@id, "#{cluster.name} (#{cluster.id})", { value: '', colspan: 5 }],
+        ['', cluster.group.name, { value: '', colspan: 5 }],
+        [{ value: 'download url:', colspan: 7 }],
+        [{ value: @delivery_url || '(waiting for link)', colspan: 7 }],
         :separator
       ]
     end
@@ -64,7 +62,7 @@ module MMS
     end
 
     def self._find(client, group_id, cluster_id, host_id, id)
-      host_id.nil? ? self._find_by_cluster(client, group_id, cluster_id, id) : self._find_by_host(client, group_id, host_id, id)
+      host_id.nil? ? _find_by_cluster(client, group_id, cluster_id, id) : _find_by_host(client, group_id, host_id, id)
     end
 
     def self._find_by_host(client, group_id, host_id, id)
@@ -86,7 +84,7 @@ module MMS
       @delivery_method_name = data['delivery']['methodName'] unless data['delivery'].nil?
       @delivery_status_name = data['delivery']['statusName'] unless data['delivery'].nil?
       @delivery_url = data['delivery']['url'] unless data['delivery'].nil?
-      @name = DateTime.parse(@created).strftime("%Y-%m-%d %H:%M:%S")
+      @name = DateTime.parse(@created).strftime('%Y-%m-%d %H:%M:%S')
       @cluster_id = data['clusterId']
       @group_id = data['groupId']
       @host_id = data['hostId']

data/lib/mms/resource/snapshot.rb

@@ -1,9 +1,7 @@
 require 'date'
 
 module MMS
-
   class Resource::Snapshot < Resource
-
     attr_accessor :name
 
     attr_accessor :complete
@@ -20,12 +18,12 @@ module MMS
 
     # @return [TrueClass, FalseClass]
     def is_config
-      @parts.length == 1 and @parts.first['typeName'] == 'REPLICA_SET' and !@parts.first['hostId'].nil?
+      @parts.length == 1 && @parts.first['typeName'] == 'REPLICA_SET' && !@parts.first['hostId'].nil?
     end
 
     # @return [TrueClass, FalseClass]
     def is_replica
-      @parts.length == 1 and @parts.first['typeName'] == 'REPLICA_SET' and !@parts.first['clusterId'].nil?
+      @parts.length == 1 && @parts.first['typeName'] == 'REPLICA_SET' && !@parts.first['clusterId'].nil?
     end
 
     # @return [String, NilClass]
@@ -59,17 +57,17 @@ module MMS
 
     # @return [Array<MMS::Resource::RestoreJob>]
     def create_restorejob
-      data = {:snapshotId => @id}
+      data = { snapshotId: @id }
       job_data_list = @client.post '/groups/' + cluster.group.id + '/clusters/' + cluster.id + '/restoreJobs', data
 
       if job_data_list.nil?
-        raise MMS::ResourceError.new("Cannot create job from snapshot `#{self.id}`", self)
+        fail MMS::ResourceError.new("Cannot create job from snapshot `#{id}`", self)
       end
 
       job_data_list.map do |job_data|
         j = MMS::Resource::RestoreJob.new
-        j.set_client(@client)
-        j.set_data(job_data)
+        j.client(@client)
+        j.data(job_data)
         j
       end
     end
@@ -84,8 +82,8 @@ module MMS
       rows << :separator
       part_count = 0
       @parts.each do |part|
-        file_size_mb = part['fileSizeBytes'].to_i / (1024*1024)
-        rows << [{:value => "part #{part_count}", :colspan => 4, :alignment => :right}, part['typeName'], part['replicaSetName'], "#{file_size_mb} MB"]
+        file_size_mb = part['fileSizeBytes'].to_i / (1024 * 1024)
+        rows << [{ value: "part #{part_count}", colspan: 4, alignment: :right }, part['typeName'], part['replicaSetName'], "#{file_size_mb} MB"]
         part_count += 1
       end
       rows << :separator
@@ -102,7 +100,7 @@ module MMS
     # @param [String] id
     # @return [MMS::Resource::Snapshot]
     def self._find(client, group_id, cluster_id, host_id, id)
-      host_id.nil? ? self._find_by_cluster(client, group_id, cluster_id, id) : self._find_by_host(client, group_id, host_id, id)
+      host_id.nil? ? _find_by_cluster(client, group_id, cluster_id, id) : _find_by_host(client, group_id, host_id, id)
     end
 
     def self._find_by_cluster(client, group_id, cluster_id, id)
@@ -122,12 +120,11 @@ module MMS
       @expires = data['expires']
       @parts = data['parts']
       @is_possibly_inconsistent = data['isPossiblyInconsistent']
-      @name = @created_date.nil? ? @id : DateTime.parse(@created_date).strftime("%Y-%m-%d %H:%M:%S")
+      @name = @created_date.nil? ? @id : DateTime.parse(@created_date).strftime('%Y-%m-%d %H:%M:%S')
     end
 
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/resource/snapshot_schedule.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::SnapshotSchedule < Resource
-
     attr_accessor :name
 
     attr_accessor :snapshot_interval_hours
@@ -18,14 +16,14 @@ module MMS
 
     def table_row
       [
-          cluster.group.name,
-          cluster.name,
-          @snapshot_interval_hours,
-          @snapshot_retention_days,
-          @cluster_checkpoint_interval_min,
-          @daily_snapshot_retention_days,
-          @weekly_snapshot_retention_weeks,
-          @monthly_snapshot_retention_months,
+        cluster.group.name,
+        cluster.name,
+        @snapshot_interval_hours,
+        @snapshot_retention_days,
+        @cluster_checkpoint_interval_min,
+        @daily_snapshot_retention_days,
+        @weekly_snapshot_retention_weeks,
+        @monthly_snapshot_retention_months
       ]
     end
 
@@ -34,7 +32,7 @@ module MMS
     end
 
     def self.table_header
-      ['Group', 'Cluster', 'IntervalHours', 'RetentionDays', 'CheckpointIntervalMin', 'RetentionDays', 'RetentionWeeks', 'RetentionMonths']
+      %w(Group Cluster IntervalHours RetentionDays CheckpointIntervalMin RetentionDays RetentionWeeks RetentionMonths)
     end
 
     def self._find(client, group_id, cluster_id)
@@ -55,6 +53,5 @@ module MMS
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/version.rb

@@ -1,3 +1,3 @@
 module MMS
-  VERSION = '0.1.5'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mms-api
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Cargo Media
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-11 00:00:00.000000000 Z
+date: 2015-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http-digest_auth
@@ -82,6 +82,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement