mms-api 0.1.5 → 0.2.0

data/lib/mms/client.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Client
-
     attr_accessor :username
     attr_accessor :apikey
     attr_accessor :url
@@ -28,6 +26,19 @@ module MMS
       _request(Net::HTTP::Post, @url + path, @username, @apikey, data)
     end
 
+    # @param [String] path
+    # @return [Hash]
+    def delete(path)
+      _request(Net::HTTP::Delete, @url + path, @username, @apikey, nil)
+    end
+
+    # @param [String] path
+    # @param [Hash] data
+    # @return [Hash]
+    def patch(path, data)
+      _request(Net::HTTP::Patch, @url + path, @username, @apikey, data)
+    end
+
     private
 
     # @param [Net::HTTPRequest] http_method
@@ -37,22 +48,21 @@ module MMS
     # @param [Hash] data
     # @return [Hash]
     def _request(http_method, path, username, password, data = nil)
-
       digest_auth = Net::HTTP::DigestAuth.new
       digest_auth.next_nonce
 
       uri = URI.parse path
-      uri.user= CGI.escape(username)
-      uri.password= CGI.escape(password)
+      uri.user = CGI.escape(username)
+      uri.password = CGI.escape(password)
 
       http = Net::HTTP.new uri.host, uri.port
       http.use_ssl = (uri.scheme == 'https')
 
-      req = http_method.new(uri.request_uri, {'Content-Type' => 'application/json'})
+      req = http_method.new(uri.request_uri, 'Content-Type' => 'application/json')
       res = http.request req
 
-      raise 'Invalid method' unless http_method.kind_of? Class and http_method < Net::HTTPRequest
-      req = http_method.new(uri.request_uri, {'Content-Type' => 'application/json'})
+      fail 'Invalid method' unless http_method.is_a?(Class) && http_method < Net::HTTPRequest
+      req = http_method.new(uri.request_uri, 'Content-Type' => 'application/json')
       method_name = http_method.name.split('::').last.upcase
       auth = digest_auth.auth_header(uri, res['WWW-Authenticate'], method_name)
       req.add_field 'Authorization', auth
@@ -61,16 +71,15 @@ module MMS
       response = http.request req
       response_json = JSON.parse response.body
 
-      unless response.code == 200 or response_json['error'].nil?
+      unless response.code == 200 || response_json['error'].nil?
         msg = "http 'get' error for url `#{url}`"
         msg = response_json['detail'] unless response_json['detail'].nil?
 
-        raise MMS::AuthError.new(msg, req, response) if response.code == '401'
-        raise MMS::ApiError.new(msg, req, response)
+        fail MMS::AuthError.new(msg, req, response) if response.code == '401'
+        fail MMS::ApiError.new(msg, req, response)
       end
 
-      (response_json.nil? or response_json['results'].nil?) ? response_json : response_json['results']
+      (response_json.nil? || response_json['results'].nil?) ? response_json : response_json['results']
     end
-
   end
 end

data/lib/mms/config.rb

@@ -1,57 +1,28 @@
 module MMS
-
   class Config
-
     default = {
-        username: proc {
-          nil
-        },
-        apikey: proc {
-          nil
-        },
-        apiurl: proc {
-          [api_protocol, '://', api_host, ':', api_port, api_path, '/', api_version].join.to_s
-        },
-        limit: proc {
-          10
-        },
-        api_protocol: proc {
-          'https'
-        },
-        api_host: proc {
-          'mms.mongodb.com'
-        },
-        api_port: proc {
-          '443'
-        },
-        api_path: proc {
-          '/api/public'
-        },
-        api_version: proc {
-          'v1.0'
-        },
-        default_group_id: proc {
-          nil
-        },
-        default_cluster_id: proc {
-          nil
-        },
-        config_path: proc {
-          Dir.home + '/.mms-api'
-        }
+      username: proc { nil },
+      apikey: proc { nil },
+      apiurl: proc { [api_protocol, '://', api_host, ':', api_port, api_path, '/', api_version].join.to_s },
+      limit: proc { 10 },
+      api_protocol: proc { 'https' },
+      api_host: proc { 'mms.mongodb.com' },
+      api_port: proc { '443' },
+      api_path: proc { '/api/public' },
+      api_version: proc { 'v1.0' },
+      default_group_id: proc { nil },
+      default_cluster_id: proc { nil },
+      config_path: proc { Dir.home + '/.mms-api' }
     }
 
     default.each do |key, value|
       define_method(key) do
-        if default[key].equal?(value)
-          default[key] = instance_eval(&value)
-        end
+        default[key] = instance_eval(&value) if default[key].equal?(value)
         default[key]
       end
-      define_method("#{key}=") do |value|
-        default[key] = value
+      define_method("#{key}=") do |val|
+        default[key] = val
       end
     end
-
   end
 end

data/lib/mms/errors.rb

@@ -1,7 +1,5 @@
 module MMS
-
-  class RuntimeError < StandardError;
-
+  class RuntimeError < StandardError
     # @param [String] message
     # @param [Net::HTTPRequest] request
     # @param [Net::HTTPResponse] response
@@ -14,11 +12,9 @@ module MMS
 
     attr_reader :request
     attr_reader :response
-
   end
 
   class ResourceError < StandardError
-
     # @param [String] message
     # @param [MMS::Resource] resource
     def initialize(message, resource)
@@ -28,19 +24,15 @@ module MMS
     end
 
     attr_reader :resource
-
   end
 
   class ApiError < RuntimeError
-
-    def initialize(message, request, response)
+    def initialize(_message, request, response)
       super("API Response error! Code: #{response.code}, body: #{response.body}", request, response)
     end
-
   end
 
   class AuthError < RuntimeError; end
 
   class ConfigError < StandardError; end
-
 end

data/lib/mms/resource.rb

@@ -1,19 +1,18 @@
 module MMS
-
   class Resource
-
     attr_accessor :id
     attr_accessor :data
 
     attr_accessor :client
+    attr_writer :client
 
     # @param [MMS::Client] client
-    def set_client(client)
+    def client(client)
       @client = client
     end
 
     # @param [Hash] data
-    def set_data(data)
+    def data(data)
       @data = data
       from_hash(data)
       MMS::Cache.instance.set(cache_key(@id), data)
@@ -33,31 +32,31 @@ module MMS
 
     # @return [Array<String>]
     def table_row
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
     # @return [Array]
     def table_section
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
     # @return [Array<String>]
     def self.table_header
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
-    def _load(id)
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+    def _load(_id)
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
-    # @param [Hash] data
-    def _from_hash(data)
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+    # @param [Hash] _data
+    def _from_hash(_data)
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
     # @return [Hash]
     def _to_hash
-      raise("`#{__method__}` is not implemented for `#{self.class.name}`")
+      fail("`#{__method__}` is not implemented for `#{self.class.name}`")
     end
 
     def invalidate_cache
@@ -65,18 +64,17 @@ module MMS
     end
 
     # @param [MMS::Client] client
-    # @param arguments...
+    # @param [Hash] arguments
     # @return self
     def self.find(client, *arguments)
-      cache_key = self.cache_key(arguments.last())
+      cache_key = self.cache_key(arguments.last)
       data = MMS::Cache.instance.get(cache_key)
-      unless data
-        data = self._find(client, *arguments)
-      end
 
-      resource = self.new
-      resource.set_client(client)
-      resource.set_data(data)
+      data = _find(client, *arguments) unless data
+
+      resource = new
+      resource.client(client)
+      resource.data(data)
       resource
     end
 
@@ -87,8 +85,7 @@ module MMS
     end
 
     def self.cache_key(id)
-      "Class::#{self.name}:#{id}"
+      "Class::#{name}:#{id}"
     end
-
   end
 end

data/lib/mms/resource/alert.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::Alert < Resource
-
     attr_accessor :name
 
     attr_accessor :type_name
@@ -19,14 +17,13 @@ module MMS
       MMS::Resource::Group.find(@client, @data['groupId'])
     end
 
-
     # @param [Time, Integer] time
     # @param [String] description
     # @return [TrueClass, FalseClass]
     def ack(time, description)
       data = {
-          :acknowledgedUntil => time.to_i,
-          :acknowledgementComment => description
+        acknowledgedUntil: time.to_i,
+        acknowledgementComment: description
       }
       alert = @client.post '/groups/' + group.id + '/alerts/' + @id, data
       !alert.nil?
@@ -39,7 +36,7 @@ module MMS
     def table_section
       rows = []
       rows << table_row
-      rows << [{:value => "AlertId: #{@id}   GroupId: #{group.id}", :colspan => 9, :alignment => :left}]
+      rows << [{ value: "AlertId: #{@id}   GroupId: #{group.id}", colspan: 9, alignment: :left }]
       rows << :separator
       rows
     end
@@ -75,6 +72,5 @@ module MMS
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/resource/backup_config.rb

@@ -1,9 +1,7 @@
 require 'date'
 
 module MMS
-
   class Resource::BackupConfig < Resource
-
     attr_accessor :cluster_id
     attr_accessor :excluded_namespaces
     attr_accessor :group_id
@@ -60,6 +58,5 @@ module MMS
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/resource/cluster.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::Cluster < Resource
-
     attr_accessor :name
     attr_accessor :shard_name
     attr_accessor :replicaset_name
@@ -24,12 +22,12 @@ module MMS
       MMS::Resource::Snapshot.find(@client, group.id, @id, nil, id)
     end
 
-    def snapshots(page = 1, limit = 1000)
+    def snapshots(page = 1, limit = 100)
       if @snapshots.empty?
         @client.get('/groups/' + group.id + '/clusters/' + @id + '/snapshots?pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |snapshot|
           s = MMS::Resource::Snapshot.new
-          s.set_client(@client)
-          s.set_data(snapshot)
+          s.client(@client)
+          s.data(snapshot)
 
           @snapshots.push s
         end
@@ -41,16 +39,15 @@ module MMS
       MMS::Resource::SnapshotSchedule.find(@client, group.id, @id)
     end
 
-    def restorejobs(page = 1, limit = 1000)
+    def restorejobs(page = 1, limit = 100)
       if @restorejobs.empty?
         @client.get('/groups/' + group.id + '/clusters/' + @id + '/restoreJobs?pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |job|
-
           job['clusterId'] = @id
           job['groupId'] = group.id
 
           j = MMS::Resource::RestoreJob.new
-          j.set_client(@client)
-          j.set_data(job)
+          j.client(@client)
+          j.data(job)
 
           @restorejobs.push j
         end
@@ -70,13 +67,13 @@ module MMS
       job_data_list = @client.post('/groups/' + group.id + '/clusters/' + @id + '/restoreJobs', data)
 
       if job_data_list.nil?
-        raise MMS::ResourceError.new("Cannot create job from snapshot `#{self.id}`", self)
+        fail MMS::ResourceError.new("Cannot create job from snapshot `#{id}`", self)
       end
 
       job_data_list.map do |job_data|
         j = MMS::Resource::RestoreJob.new
-        j.set_client(@client)
-        j.set_data(job_data)
+        j.client(@client)
+        j.data(job_data)
         j
       end
     end
@@ -97,8 +94,6 @@ module MMS
       client.get('/groups/' + group_id + '/clusters/' + id)
     end
 
-    private
-
     def _from_hash(data)
       @name = data['clusterName']
       @shard_name = data['shardName']
@@ -110,6 +105,5 @@ module MMS
     def _to_hash
       @data
     end
-
   end
 end

data/lib/mms/resource/group.rb

@@ -1,7 +1,5 @@
 module MMS
-
   class Resource::Group < Resource
-
     attr_reader :name
     attr_reader :active_agent_count
     attr_reader :replicaset_count
@@ -18,12 +16,12 @@ module MMS
     # @param [Integer] page
     # @param [Integer] limit
     # @return [Array<MMS::Resource::Host>]
-    def hosts(page = 1, limit = 1000)
+    def hosts(page = 1, limit = 100)
       host_list = []
       @client.get('/groups/' + @id + '/hosts?pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |host|
         h = MMS::Resource::Host.new
-        h.set_client(@client)
-        h.set_data(host)
+        h.client(@client)
+        h.data(host)
 
         host_list.push h
       end
@@ -34,12 +32,12 @@ module MMS
     # @param [Integer] limit
     # @param [String] status
     # @return [Array<MMS::Resource::Alert>]
-    def alerts(page = 1, limit = 1000, status = 'OPEN')
+    def alerts(page = 1, limit = 100, status = 'OPEN')
       alert_list = []
       @client.get('/groups/' + @id + '/alerts?status=' + status + '&pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |alert|
         a = MMS::Resource::Alert.new
-        a.set_client(@client)
-        a.set_data(alert)
+        a.client(@client)
+        a.data(alert)
 
         alert_list.push a
       end
@@ -55,12 +53,12 @@ module MMS
     # @param [Integer] page
     # @param [Integer] limit
     # @return [Array<MMS::Resource::Cluster>]
-    def clusters(page = 1, limit = 1000)
+    def clusters(page = 1, limit = 100)
       if @clusters.empty?
         @client.get('/groups/' + @id + '/clusters?pageNum=' + page.to_s + '&itemsPerPage=' + limit.to_s).each do |cluster|
           c = MMS::Resource::Cluster.new
-          c.set_client(@client)
-          c.set_data(cluster)
+          c.client(@client)
+          c.data(cluster)
 
           @clusters.push c
         end
@@ -78,8 +76,8 @@ module MMS
       if @backup_configs.empty?
         @client.get('/groups/' + @id + '/backupConfigs').each do |backup_config|
           bc = MMS::Resource::BackupConfig.new
-          bc.set_client(@client)
-          bc.set_data(backup_config)
+          bc.client(@client)
+          bc.data(backup_config)
 
           @backup_configs.push bc
         end
@@ -95,7 +93,7 @@ module MMS
         begin
           snapshot = cluster.snapshot(id)
           break unless snapshot.nil?
-        rescue MMS::ApiError => e
+        rescue MMS::ApiError => _e
           # Snapshot is not available on this cluster. Skip it!
         end
       end
@@ -104,7 +102,7 @@ module MMS
           begin
             snapshot = host.snapshot(id)
             break unless snapshot.nil?
-          rescue MMS::ApiError => e
+          rescue MMS::ApiError => _e
             # Snapshot is not available on this host. Skip it!
           end
         end