mixlib-versioning 1.1.0 → 1.2.1

data/spec/mixlib/versioning/versioning_spec.rb

@@ -16,33 +16,33 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Mixlib::Versioning do
   subject { described_class }
 
-  let(:version_string) { '11.0.0' }
+  let(:version_string) { "11.0.0" }
 
-  describe '.parse' do
-    describe 'parsing when format type is specified' do
+  describe ".parse" do
+    describe "parsing when format type is specified" do
       {
-        '11.0.8' => {
+        "11.0.8" => {
           format_type: :semver,
           expected_format: Mixlib::Versioning::Format::SemVer,
         },
-        '11.1.1' => {
+        "11.1.1" => {
           format_type: :rubygems,
           expected_format: Mixlib::Versioning::Format::Rubygems,
         },
-        '11.1.1.alpha.1' => {
+        "11.1.1.alpha.1" => {
           format_type: :rubygems,
           expected_format: Mixlib::Versioning::Format::Rubygems,
         },
-        '11.1.1-alpha.1' => {
+        "11.1.1-alpha.1" => {
           format_type: :opscode_semver,
           expected_format: Mixlib::Versioning::Format::OpscodeSemVer,
         },
-        '11.1.1-rc.2' => {
+        "11.1.1-rc.2" => {
           format_type: :opscode_semver,
           expected_format: Mixlib::Versioning::Format::SemVer,
         },
@@ -59,21 +59,21 @@ describe Mixlib::Versioning do
             context "format type as a: #{format_type.class}" do
               it "parses version string as: #{options[:expected_format]}" do
                 result = subject.parse(version_string, format_type)
-                result.should be_a(expected_format)
+                expect(result).to be_a(expected_format)
               end # it
             end # context
           end # each
         end # context
       end # each_pair
 
-      describe 'invalid format type specified' do
+      describe "invalid format type specified" do
         [
           :poop,
-          'poop',
+          "poop",
           Mixlib::Versioning,
         ].each do |invalid_format_type|
           context "invalid format as a: #{invalid_format_type.class}" do
-            it 'raises a Mixlib::Versioning::UnknownFormatError' do
+            it "raises a Mixlib::Versioning::UnknownFormatError" do
               expect { subject.parse(version_string, invalid_format_type) }.to raise_error(Mixlib::Versioning::UnknownFormatError)
             end # it
           end # context
@@ -81,89 +81,89 @@ describe Mixlib::Versioning do
       end # describe
     end # describe
 
-    describe 'parsing with automatic format detection' do
+    describe "parsing with automatic format detection" do
       {
-        '11.0.8' => Mixlib::Versioning::Format::SemVer,
-        '11.0.8-1' => Mixlib::Versioning::Format::SemVer,
-        '11.0.8.rc.1' => Mixlib::Versioning::Format::Rubygems,
-        '11.0.8.rc.1-1' => Mixlib::Versioning::Format::Rubygems,
-        '11.0.8-rc.1' => Mixlib::Versioning::Format::OpscodeSemVer,
+        "11.0.8" => Mixlib::Versioning::Format::SemVer,
+        "11.0.8-1" => Mixlib::Versioning::Format::SemVer,
+        "11.0.8.rc.1" => Mixlib::Versioning::Format::Rubygems,
+        "11.0.8.rc.1-1" => Mixlib::Versioning::Format::Rubygems,
+        "11.0.8-rc.1" => Mixlib::Versioning::Format::OpscodeSemVer,
 
-        '10.18.2' => Mixlib::Versioning::Format::SemVer,
-        '10.18.2-poop' => Mixlib::Versioning::Format::SemVer,
-        '10.18.2.poop' => Mixlib::Versioning::Format::Rubygems,
-        '10.18.2.poop-1' => Mixlib::Versioning::Format::Rubygems,
+        "10.18.2" => Mixlib::Versioning::Format::SemVer,
+        "10.18.2-poop" => Mixlib::Versioning::Format::SemVer,
+        "10.18.2.poop" => Mixlib::Versioning::Format::Rubygems,
+        "10.18.2.poop-1" => Mixlib::Versioning::Format::Rubygems,
 
-        '12.1.1+20130311134422' => Mixlib::Versioning::Format::OpscodeSemVer,
-        '12.1.1-rc.3+20130311134422' => Mixlib::Versioning::Format::OpscodeSemVer,
-        '12.1.1+20130308110833.git.2.94a1dde' => Mixlib::Versioning::Format::OpscodeSemVer,
+        "12.1.1+20130311134422" => Mixlib::Versioning::Format::OpscodeSemVer,
+        "12.1.1-rc.3+20130311134422" => Mixlib::Versioning::Format::OpscodeSemVer,
+        "12.1.1+20130308110833.git.2.94a1dde" => Mixlib::Versioning::Format::OpscodeSemVer,
 
-        '10.16.2-49-g21353f0' => Mixlib::Versioning::Format::GitDescribe,
-        '10.16.2-49-g21353f0-1' => Mixlib::Versioning::Format::GitDescribe,
-        '10.16.2.rc.2-49-g21353f0' => Mixlib::Versioning::Format::GitDescribe,
-        '10.16.2-rc.2-49-g21353f0' => Mixlib::Versioning::Format::GitDescribe,
+        "10.16.2-49-g21353f0" => Mixlib::Versioning::Format::GitDescribe,
+        "10.16.2-49-g21353f0-1" => Mixlib::Versioning::Format::GitDescribe,
+        "10.16.2.rc.2-49-g21353f0" => Mixlib::Versioning::Format::GitDescribe,
+        "10.16.2-rc.2-49-g21353f0" => Mixlib::Versioning::Format::GitDescribe,
       }.each_pair do |version_string, expected_format|
         context version_string do
           let(:version_string) { version_string }
           it "parses version string as: #{expected_format}" do
-            subject.parse(version_string).should be_a(expected_format)
+            expect(subject.parse(version_string)).to be_a(expected_format)
           end # it
         end # context
       end # each_pair
 
-      describe 'version_string cannot be parsed' do
-        let(:version_string) { 'A.B.C' }
-        it 'returns nil' do
-          subject.parse(version_string).should be_nil
+      describe "version_string cannot be parsed" do
+        let(:version_string) { "A.B.C" }
+        it "returns nil" do
+          expect(subject.parse(version_string)).to be_nil
         end
       end
     end # describe "parsing with automatic format detection"
 
-    describe 'parsing an Mixlib::Versioning::Format object' do
-      it 'returns the same object' do
+    describe "parsing an Mixlib::Versioning::Format object" do
+      it "returns the same object" do
         v = Mixlib::Versioning.parse(version_string)
         result = subject.parse(v)
-        v.should be result
+        expect(v).to be result
       end
     end
 
-    describe 'when formats are given' do
-      context 'when the format is not in the list' do
-        let(:version_string) { '10.16.2-rc.2-49-g21353f0' }
-        it 'returns nil when the array contains a Mixlib::Versioning::Format' do
-          subject.parse(version_string, [Mixlib::Versioning::Format::Rubygems]).should be_nil
+    describe "when formats are given" do
+      context "when the format is not in the list" do
+        let(:version_string) { "10.16.2-rc.2-49-g21353f0" }
+        it "returns nil when the array contains a Mixlib::Versioning::Format" do
+          expect(subject.parse(version_string, [Mixlib::Versioning::Format::Rubygems])).to be_nil
         end
 
-        it 'returns nil when the array contains a string' do
-          subject.parse(version_string, ['rubygems']).should be_nil
+        it "returns nil when the array contains a string" do
+          expect(subject.parse(version_string, ["rubygems"])).to be_nil
         end
 
-        it 'returns nil when the array contains a symbol' do
-          subject.parse(version_string, [:rubygems]).should be_nil
+        it "returns nil when the array contains a symbol" do
+          expect(subject.parse(version_string, [:rubygems])).to be_nil
         end
       end
 
-      context 'when the format is in the list' do
-        let(:version_string) { '10.16.2-rc.2-49-g21353f0' }
+      context "when the format is in the list" do
+        let(:version_string) { "10.16.2-rc.2-49-g21353f0" }
         let(:expected_format) { Mixlib::Versioning::Format::GitDescribe }
-        it 'returns nil when the array contains a Mixlib::Versioning::Format' do
-          subject.parse(version_string, [expected_format]).should be_a(expected_format)
+        it "returns nil when the array contains a Mixlib::Versioning::Format" do
+          expect(subject.parse(version_string, [expected_format])).to be_a(expected_format)
         end
 
-        it 'returns nil when the array contains a string' do
-          subject.parse(version_string, ['git_describe']).should be_a(expected_format)
+        it "returns nil when the array contains a string" do
+          expect(subject.parse(version_string, ["git_describe"])).to be_a(expected_format)
         end
 
-        it 'returns nil when the array contains a symbol' do
-          subject.parse(version_string, [:git_describe]).should be_a(expected_format)
+        it "returns nil when the array contains a symbol" do
+          expect(subject.parse(version_string, [:git_describe])).to be_a(expected_format)
         end
       end
     end
   end # describe .parse
 
-  describe '.find_target_version' do
+  describe ".find_target_version" do
     let(:all_versions) do
-      %w(
+      %w{
         11.0.0-beta.1
         11.0.0-rc.1
         11.0.0
@@ -172,7 +172,7 @@ describe Mixlib::Versioning do
         11.0.2-alpha.0
         11.0.2-alpha.0+2013041116332
         11.0.2
-      )
+      }
     end
     let(:filter_version) { nil }
     let(:use_prerelease_versions) { false }
@@ -182,99 +182,99 @@ describe Mixlib::Versioning do
         all_versions,
         filter_version,
         use_prerelease_versions,
-        use_build_versions,
+        use_build_versions
       )
     end
 
     {
       nil => {
-        releases_only: '11.0.2',
-        prerelease_versions: '11.0.2-alpha.0',
-        build_versions: '11.0.1+2013031116332',
-        prerelease_and_build_versions: '11.0.2-alpha.0+2013041116332',
+        releases_only: "11.0.2",
+        prerelease_versions: "11.0.2-alpha.0",
+        build_versions: "11.0.1+2013031116332",
+        prerelease_and_build_versions: "11.0.2-alpha.0+2013041116332",
       },
-      '11.0.0' => {
-        releases_only: '11.0.0',
-        prerelease_versions: '11.0.0-rc.1',
+      "11.0.0" => {
+        releases_only: "11.0.0",
+        prerelease_versions: "11.0.0-rc.1",
         build_versions: nil,
         prerelease_and_build_versions: nil,
       },
-      '11.0.2' => {
-        releases_only: '11.0.2',
-        prerelease_versions: '11.0.2-alpha.0',
+      "11.0.2" => {
+        releases_only: "11.0.2",
+        prerelease_versions: "11.0.2-alpha.0",
         build_versions: nil,
-        prerelease_and_build_versions: '11.0.2-alpha.0+2013041116332',
+        prerelease_and_build_versions: "11.0.2-alpha.0+2013041116332",
       },
-      '11.0.2' => {
-        releases_only: '11.0.2',
-        prerelease_versions: '11.0.2-alpha.0',
+      "11.0.2" => { # rubocop: disable Lint/DuplicatedKey
+        releases_only: "11.0.2",
+        prerelease_versions: "11.0.2-alpha.0",
         build_versions: nil,
-        prerelease_and_build_versions: '11.0.2-alpha.0+2013041116332',
+        prerelease_and_build_versions: "11.0.2-alpha.0+2013041116332",
       },
-      '11.0.2-alpha.0' => {
-        releases_only: '11.0.2-alpha.0',
-        prerelease_versions: '11.0.2-alpha.0',
-        build_versions: '11.0.2-alpha.0+2013041116332',
-        prerelease_and_build_versions: '11.0.2-alpha.0+2013041116332',
+      "11.0.2-alpha.0" => {
+        releases_only: "11.0.2-alpha.0",
+        prerelease_versions: "11.0.2-alpha.0",
+        build_versions: "11.0.2-alpha.0+2013041116332",
+        prerelease_and_build_versions: "11.0.2-alpha.0+2013041116332",
       },
     }.each_pair do |filter_version, options|
       context "filter version of: #{filter_version}" do
         let(:filter_version) { filter_version }
         let(:expected_version) { options[:releases_only] }
 
-        it 'finds the most recent release version' do
-          subject_find.should eq Mixlib::Versioning.parse(expected_version)
+        it "finds the most recent release version" do
+          expect(subject_find).to eq Mixlib::Versioning.parse(expected_version)
         end
 
-        context 'include pre-release versions' do
+        context "include pre-release versions" do
           let(:use_prerelease_versions) { true }
           let(:expected_version) { options[:prerelease_versions] }
 
-          it 'finds the most recent pre-release version' do
-            subject_find.should eq Mixlib::Versioning.parse(expected_version)
+          it "finds the most recent pre-release version" do
+            expect(subject_find).to eq Mixlib::Versioning.parse(expected_version)
           end # it
         end # context
 
-        context 'include build versions' do
+        context "include build versions" do
           let(:use_build_versions) { true }
           let(:expected_version) { options[:build_versions] }
 
-          it 'finds the most recent build version' do
-            subject_find.should eq Mixlib::Versioning.parse(expected_version)
+          it "finds the most recent build version" do
+            expect(subject_find).to eq Mixlib::Versioning.parse(expected_version)
           end # it
         end # context
 
-        context 'include pre-release and build versions' do
+        context "include pre-release and build versions" do
           let(:use_prerelease_versions) { true }
           let(:use_build_versions) { true }
           let(:expected_version) { options[:prerelease_and_build_versions] }
 
-          it 'finds the most recent pre-release build version' do
-            subject_find.should eq Mixlib::Versioning.parse(expected_version)
+          it "finds the most recent pre-release build version" do
+            expect(subject_find).to eq Mixlib::Versioning.parse(expected_version)
           end # it
         end # context
       end # context
     end # each_pair
 
-    describe 'all_versions argument is a mix of String and Mixlib::Versioning::Format instances' do
+    describe "all_versions argument is a mix of String and Mixlib::Versioning::Format instances" do
       let(:all_versions) do
         [
-          '11.0.0-beta.1',
-          '11.0.0-rc.1',
-          Mixlib::Versioning.parse('11.0.0'),
+          "11.0.0-beta.1",
+          "11.0.0-rc.1",
+          Mixlib::Versioning.parse("11.0.0"),
         ]
       end
 
-      it 'correctly parses the array' do
-        subject_find.should eq Mixlib::Versioning.parse('11.0.0')
+      it "correctly parses the array" do
+        expect(subject_find).to eq Mixlib::Versioning.parse("11.0.0")
       end
     end # describe
 
-    describe 'filter_version argument is an instance of Mixlib::Versioning::Format' do
-      let(:filter_version) { Mixlib::Versioning::Format::SemVer.new('11.0.0') }
+    describe "filter_version argument is an instance of Mixlib::Versioning::Format" do
+      let(:filter_version) { Mixlib::Versioning::Format::SemVer.new("11.0.0") }
 
-      it 'finds the correct version' do
-        subject_find.should eq Mixlib::Versioning.parse('11.0.0')
+      it "finds the correct version" do
+        expect(subject_find).to eq Mixlib::Versioning.parse("11.0.0")
       end
     end
   end # describe

data/spec/spec_helper.rb

@@ -16,19 +16,20 @@
 # limitations under the License.
 #
 
-require 'mixlib/versioning'
+require "mixlib/versioning"
+require "rspec/its"
 
 # load all shared examples and shared contexts
-Dir[File.expand_path('../support/**/*.rb', __FILE__)].each do |file|
+Dir[File.expand_path("../support/**/*.rb", __FILE__)].each do |file|
   require(file)
 end
 
 RSpec.configure do |config|
   # a little syntactic sugar
-  config.alias_it_should_behave_like_to :it_has_behavior, 'has behavior:'
+  config.alias_it_should_behave_like_to :it_has_behavior, "has behavior:"
 
   # Use color in STDOUT
-  config.color_enabled = true
+  config.color = true
 
   # Use color not only in STDOUT but also in pagers and files
   config.tty = true
@@ -36,8 +37,6 @@ RSpec.configure do |config|
   # run the examples in random order
   config.order = :rand
 
-  # specify metadata with symobls only (ie no '=> true' required)
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end

data/spec/support/shared_examples/basic_semver.rb

@@ -16,9 +16,9 @@
 # limitations under the License.
 #
 
-shared_examples 'Basic SemVer' do
-  it_has_behavior 'parses valid version strings', {
-    '1.2.3' => {
+shared_examples "Basic SemVer" do
+  it_has_behavior "parses valid version strings", {
+    "1.2.3" => {
       major: 1,
       minor: 2,
       patch: 3,
@@ -32,9 +32,9 @@ shared_examples 'Basic SemVer' do
     },
   }
 
-  it_has_behavior 'rejects invalid version strings', {
-    'a.1.1' => 'non-numeric MAJOR',
-    '1.a.1' => 'non-numeric MINOR',
-    '1.1.a' => 'non-numeric PATCH',
+  it_has_behavior "rejects invalid version strings", {
+    "a.1.1" => "non-numeric MAJOR",
+    "1.a.1" => "non-numeric MINOR",
+    "1.1.a" => "non-numeric PATCH",
   }
 end

data/spec/support/shared_examples/behaviors/comparable.rb

@@ -16,28 +16,28 @@
 # limitations under the License.
 #
 
-shared_examples 'comparable' do |version_matrix|
-  describe '#<' do
+shared_examples "comparable" do |version_matrix|
+  describe "#<" do
     version_matrix.each_slice(2) do |a, b|
       it "confirms that #{a} is less-than #{b}" do
         expect(described_class.new(a) < b).to be true
-        expect(described_class.new(a) > b).to be false
+        expect(b < described_class.new(a)).to be false
       end
     end
   end
 
-  describe '#<=' do
+  describe "#<=" do
     version_matrix.each_slice(2) do |a, b|
       it "confirms that #{a} less-than or equal to #{b}" do
         expect(described_class.new(a) <= b).to be true
         expect(described_class.new(a) <= a).to be true
-        expect(described_class.new(a) > b).to be false
-        expect(described_class.new(a) == b).to be false
+        expect(b <= described_class.new(a)).to be false
+        expect(b < described_class.new(a)).to be false
       end
     end
   end
 
-  describe '#==' do
+  describe "#==" do
     version_matrix.each do |v|
       it "confirms that #{v} is equal to #{v}" do
         expect(described_class.new(v) == v).to be true
@@ -47,30 +47,30 @@ shared_examples 'comparable' do |version_matrix|
     end
   end
 
-  describe '#>' do
+  describe "#>" do
     version_matrix.reverse.each_slice(2) do |a, b|
       it "confirms that #{a} is greather-than #{b}" do
         expect(described_class.new(a) > b).to be true
-        expect(described_class.new(a) < b).to be false
+        expect(b > described_class.new(a)).to be false
       end
     end
   end
 
-  describe '#>=' do
+  describe "#>=" do
     version_matrix.reverse.each_slice(2) do |a, b|
       it "confirms that #{a} greater-than or equal to #{b}" do
         expect(described_class.new(a) >= b).to be true
         expect(described_class.new(a) >= a).to be true
-        expect(described_class.new(a) < b).to be false
-        expect(described_class.new(a) == b).to be false
+        expect(b >= described_class.new(a)).to be false
+        expect(b > described_class.new(a)).to be false
       end
     end
   end
 
-  describe '#between?' do
+  describe "#between?" do
     let(:versions) { version_matrix.map { |v| described_class.new(v) }.sort }
 
-    it 'comfirms that a version is between the oldest and latest release' do
+    it "comfirms that a version is between the oldest and latest release" do
       min, max = versions.minmax.map(&:to_s)
       middle = versions[versions.size / 2].to_s
       expect(described_class.new(middle).between?(min, max)).to be true