mixlib-versioning 1.1.0 → 1.2.1

data/spec/mixlib/versioning/format/partial_semver_spec.rb

@@ -0,0 +1,121 @@
+#
+# Author:: Seth Chisamore (<schisamo@chef.io>)
+# Author:: Ryan Hass (<rhass@chef.io>)
+# Copyright:: Copyright (c) 2017 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Mixlib::Versioning::Format::PartialSemVer do
+  subject { described_class.new(version_string) }
+
+  it_has_behavior "serializable", [
+    "1",
+    "12",
+    "1.2",
+    "1.23",
+    "12.3",
+    "12.34",
+  ]
+
+  it_has_behavior "sortable" do
+    let(:unsorted_version_strings) do
+      %w{
+        2
+        1.1
+        1
+        1.0
+        2.0
+        1.2
+      }
+    end
+    let(:sorted_version_strings) do
+      %w{
+        1
+        1.0
+        1.1
+        1.2
+        2
+        2.0
+      }
+    end
+    let(:min) { "1" }
+    let(:max) { "2.0" }
+  end # it_has_behavior
+
+  it_has_behavior "filterable" do
+    let(:unsorted_version_strings) do
+      %w{
+        2
+        1.1
+        1
+        1.0
+        2.0
+        1.2
+        12.0
+        12
+      }
+    end
+    let(:release_versions) do
+      %w{
+        2.0
+        1.1
+        1.0
+        1.0
+        2.0
+        1.2
+        12.0
+        12.0
+      }
+    end
+  end # it_has_behavior
+
+  it_has_behavior "comparable", [
+    "1", "2",
+    "1", "1.1",
+    "1.1", "2",
+    "1.1", "1.2"
+  ]
+
+  it_has_behavior "comparable_types", [
+    "0.1", { value: "1.0.0.pre.1", class: Mixlib::Versioning::Format::Rubygems },
+    "0.1", { value: "1.0.0-rc.1", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1", { value: "1.0.1", class: Mixlib::Versioning::Format::Rubygems },
+    "1", { value: "1.0.1", class: Mixlib::Versioning::Format::SemVer },
+    "1", { value: "1.0.1", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1", { value: "1.0.0-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe },
+    "1", { value: "2.0.0", class: Mixlib::Versioning::Format::Rubygems },
+    "1", { value: "2.0.0", class: Mixlib::Versioning::Format::SemVer },
+    "1", { value: "2.0.0-rc.1", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1", { value: "2.0.0-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe },
+    "1", { value: "1.1.0", class: Mixlib::Versioning::Format::Rubygems },
+    "1", { value: "1.1.0", class: Mixlib::Versioning::Format::SemVer },
+    "1", { value: "1.1.0", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1", { value: "1.1.0-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe },
+    "1.1", { value: "1.1.1", class: Mixlib::Versioning::Format::Rubygems },
+    "1.1", { value: "1.1.1", class: Mixlib::Versioning::Format::SemVer },
+    "1.1", { value: "1.1.1", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1.1", { value: "1.1.1-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe },
+    "1.1", { value: "2.0.0", class: Mixlib::Versioning::Format::Rubygems },
+    "1.1", { value: "2.0.0", class: Mixlib::Versioning::Format::SemVer },
+    "1.1", { value: "2.0.0", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1.1", { value: "2.0.0-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe },
+    "1.1", { value: "1.2.0", class: Mixlib::Versioning::Format::Rubygems },
+    "1.1", { value: "1.2.0", class: Mixlib::Versioning::Format::SemVer },
+    "1.1", { value: "1.2.0", class: Mixlib::Versioning::Format::OpscodeSemVer },
+    "1.1", { value: "1.2.0-1-gdeadbee-1", class: Mixlib::Versioning::Format::GitDescribe }
+  ]
+end # describe

data/spec/mixlib/versioning/format/rubygems_spec.rb

@@ -16,15 +16,15 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Mixlib::Versioning::Format::Rubygems do
   subject { described_class.new(version_string) }
 
-  it_should_behave_like 'Basic SemVer'
+  it_should_behave_like "Basic SemVer"
 
-  it_has_behavior 'parses valid version strings', {
-    '10.1.1' => {
+  it_has_behavior "parses valid version strings", {
+    "10.1.1" => {
       major: 10,
       minor: 1,
       patch: 1,
@@ -35,35 +35,35 @@ describe Mixlib::Versioning::Format::Rubygems do
       build?: false,
       release_build?: false,
       prerelease_build?: false,
-      iteration: 0,
+      iteration: nil,
     },
-    '10.1.1.alpha.1' => {
+    "10.1.1.alpha.1" => {
       major: 10,
       minor: 1,
       patch: 1,
-      prerelease: 'alpha.1',
+      prerelease: "alpha.1",
       build: nil,
       release?: false,
       prerelease?: true,
       build?: false,
       release_build?: false,
       prerelease_build?: false,
-      iteration: 0,
+      iteration: nil,
     },
-    '11.0.8.rc.3' => {
+    "11.0.8.rc.3" => {
       major: 11,
       minor: 0,
       patch: 8,
-      prerelease: 'rc.3',
+      prerelease: "rc.3",
       build: nil,
       release?: false,
       prerelease?: true,
       build?: false,
       release_build?: false,
       prerelease_build?: false,
-      iteration: 0,
+      iteration: nil,
     },
-    '11.0.8-33' => {
+    "11.0.8-33" => {
       major: 11,
       minor: 0,
       patch: 8,
@@ -76,11 +76,11 @@ describe Mixlib::Versioning::Format::Rubygems do
       prerelease_build?: false,
       iteration: 33,
     },
-    '11.0.8.rc.3-1' => {
+    "11.0.8.rc.3-1" => {
       major: 11,
       minor: 0,
       patch: 8,
-      prerelease: 'rc.3',
+      prerelease: "rc.3",
       build: nil,
       release?: false,
       prerelease?: true,
@@ -91,67 +91,67 @@ describe Mixlib::Versioning::Format::Rubygems do
     },
   }
 
-  it_has_behavior 'rejects invalid version strings', {
-    '1.1.1-rutro' => 'dash for pre-release delimeter',
+  it_has_behavior "rejects invalid version strings", {
+    "1.1.1-rutro" => "dash for pre-release delimeter",
   }
 
-  it_has_behavior 'serializable', [
-    '1.0.0',
-    '1.0.0.alpha.1',
-    '1.0.0.beta',
+  it_has_behavior "serializable", [
+    "1.0.0",
+    "1.0.0.alpha.1",
+    "1.0.0.beta",
   ]
 
-  it_has_behavior 'sortable' do
+  it_has_behavior "sortable" do
     let(:unsorted_version_strings) do
-      %w(
+      %w{
         1.0.0.beta.2
         1.3.7.alpha.0
         1.0.0.alpha
         1.0.0.rc.1
         1.0.0
-      )
+      }
     end
     let(:sorted_version_strings) do
-      %w(
+      %w{
         1.0.0.alpha
         1.0.0.beta.2
         1.0.0.rc.1
         1.0.0
         1.3.7.alpha.0
-      )
+      }
     end
-    let(:min) { '1.0.0.alpha' }
-    let(:max) { '1.3.7.alpha.0' }
+    let(:min) { "1.0.0.alpha" }
+    let(:max) { "1.3.7.alpha.0" }
   end
 
   # The +Rubygems+ format only produces release and prerelease versions.
-  it_has_behavior 'filterable' do
+  it_has_behavior "filterable" do
     let(:unsorted_version_strings) do
-      %w(
+      %w{
         1.0.0.beta.2
         1.3.7.alpha.0
         1.0.0.alpha
         1.0.0.rc.1
         1.0.0
-      )
+      }
     end
-    let(:release_versions) { %w(1.0.0) }
+    let(:release_versions) { %w{1.0.0} }
     let(:prerelease_versions) do
-      %w(
+      %w{
         1.0.0.beta.2
         1.3.7.alpha.0
         1.0.0.alpha
         1.0.0.rc.1
-      )
+      }
     end
   end
 
-  it_has_behavior 'comparable', [
-    '0.1.0', '0.2.0',
-    '1.0.0.alpha.1', '1.0.0',
-    '1.2.3.alpha', '1.2.3.alpha.1',
-    '2.4.5.alpha', '2.4.5.beta',
-    '3.0.0.beta.1', '3.0.0.rc.1',
-    '3.1.2.rc.42', '3.1.2'
+  it_has_behavior "comparable", [
+    "0.1.0", "0.2.0",
+    "1.0.0.alpha.1", "1.0.0",
+    "1.2.3.alpha", "1.2.3.alpha.1",
+    "2.4.5.alpha", "2.4.5.beta",
+    "3.0.0.beta.1", "3.0.0.rc.1",
+    "3.1.2.rc.42", "3.1.2"
   ]
 end

data/spec/mixlib/versioning/format/semver_spec.rb

@@ -16,23 +16,23 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Mixlib::Versioning::Format::SemVer do
   subject { described_class.new(version_string) }
 
   it_should_behave_like Mixlib::Versioning::Format::SemVer
 
-  it_has_behavior 'serializable', [
-    '1.0.0',
-    '1.0.0-alpha.1',
-    '1.0.0-alpha.1+some.build.version',
-    '1.0.0+build.build.build',
+  it_has_behavior "serializable", [
+    "1.0.0",
+    "1.0.0-alpha.1",
+    "1.0.0-alpha.1+some.build.version",
+    "1.0.0+build.build.build",
   ]
 
-  it_has_behavior 'sortable' do
+  it_has_behavior "sortable" do
     let(:unsorted_version_strings) do
-      %w(
+      %w{
         1.0.0-beta.2
         1.0.0-alpha
         1.0.0-alpha.july
@@ -45,10 +45,10 @@ describe Mixlib::Versioning::Format::SemVer do
         1.3.7+build.2.b8f12d7
         1.3.7+build.11.e0f985a
         1.3.7+build
-      )
+      }
     end
     let(:sorted_version_strings) do
-      %w(
+      %w{
         1.0.0-alpha
         1.0.0-alpha.1
         1.0.0-alpha.july
@@ -61,15 +61,15 @@ describe Mixlib::Versioning::Format::SemVer do
         1.3.7+build
         1.3.7+build.2.b8f12d7
         1.3.7+build.11.e0f985a
-      )
+      }
     end
-    let(:min) { '1.0.0-alpha' }
-    let(:max) { '1.3.7+build.11.e0f985a' }
+    let(:min) { "1.0.0-alpha" }
+    let(:max) { "1.3.7+build.11.e0f985a" }
   end # it_has_behavior
 
-  it_has_behavior 'filterable' do
+  it_has_behavior "filterable" do
     let(:unsorted_version_strings) do
-      %w(
+      %w{
         1.0.0-beta.2
         1.0.0-alpha
         1.0.0-rc.1+build.1
@@ -81,48 +81,48 @@ describe Mixlib::Versioning::Format::SemVer do
         1.3.7+build.2.b8f12d7
         1.3.7+build.11.e0f985a
         1.3.7+build
-      )
+      }
     end
     let(:release_versions) do
-      %w(
-        1.0.0      )
+      %w{
+        1.0.0      }
     end
     let(:prerelease_versions) do
-      %w(
+      %w{
         1.0.0-beta.2
         1.0.0-alpha
         1.0.0-beta.11
         1.0.0-rc.1
         1.0.0-alpha.1
-      )
+      }
     end
     let(:build_versions) do
-      %w(
+      %w{
         1.0.0-rc.1+build.1
         1.0.0+0.3.7
         1.3.7+build.2.b8f12d7
         1.3.7+build.11.e0f985a
         1.3.7+build
-      )
+      }
     end
     let(:release_build_versions) do
-      %w(
+      %w{
         1.0.0+0.3.7
         1.3.7+build.2.b8f12d7
         1.3.7+build.11.e0f985a
         1.3.7+build
-      )
+      }
     end
     let(:prerelease_build_versions) do
-      %w(
-        1.0.0-rc.1+build.1      )
+      %w{
+        1.0.0-rc.1+build.1      }
     end
   end # it_has_behavior
 
-  it_has_behavior 'comparable', [
-    '0.1.0', '0.2.0',
-    '1.0.0-alpha.1', '1.0.0',
-    '1.2.3', '1.2.3+build.123',
-    '2.0.0-beta.1', '2.0.0-beta.1+build.123'
+  it_has_behavior "comparable", [
+    "0.1.0", "0.2.0",
+    "1.0.0-alpha.1", "1.0.0",
+    "1.2.3", "1.2.3+build.123",
+    "2.0.0-beta.1", "2.0.0-beta.1+build.123"
   ]
 end # describe

data/spec/mixlib/versioning/format_spec.rb

@@ -1,6 +1,8 @@
 #
 # Author:: Seth Chisamore (<schisamo@chef.io>)
+# Author:: Ryan Hass (<rhass@chef.io>)
 # Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Copyright:: Copyright (c) 2017 Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,42 +18,42 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Mixlib::Versioning::Format do
-  describe '#initialize' do
+  describe "#initialize" do
     subject { described_class.new(version_string) }
-    let(:version_string) { '11.0.0' }
+    let(:version_string) { "11.0.0" }
 
-    it 'descendants must override #parse' do
-      expect { subject }.to raise_error
+    it "descendants must override #parse" do
+      expect { subject }.to raise_error(StandardError)
     end
   end
 
-  describe '.for' do
+  describe ".for" do
     subject { described_class }
 
     [
       :rubygems,
-      'rubygems',
+      "rubygems",
       Mixlib::Versioning::Format::Rubygems,
     ].each do |format_type|
       context 'format_type is a: #{format_type.class}' do
         let(:format_type) { format_type }
-        it 'returns the correct format class' do
-          subject.for(format_type).should eq Mixlib::Versioning::Format::Rubygems
+        it "returns the correct format class" do
+          expect(subject.for(format_type)).to eq Mixlib::Versioning::Format::Rubygems
         end # it
       end # context
     end # each
 
-    describe 'unknown format_type' do
+    describe "unknown format_type" do
       [
         :poop,
-        'poop',
+        "poop",
         Mixlib::Versioning,
       ].each do |invalid_format_type|
         context 'format_type is a: #{invalid_format_type.class}' do
-          it 'raises a Mixlib::Versioning::UnknownFormatError' do
+          it "raises a Mixlib::Versioning::UnknownFormatError" do
             expect { subject.for(invalid_format_type) }.to raise_error(Mixlib::Versioning::UnknownFormatError)
           end # it
         end # context
@@ -59,3 +61,28 @@ describe Mixlib::Versioning::Format do
     end # describe
   end # describe ".for"
 end # describe Mixlib::Versioning::Format
+
+describe Mixlib::Versioning do
+  versions = [
+    "1", "1.0.0",
+    "1.2", "1.2.0"
+  ]
+
+  describe "#==" do
+    formats = described_class::DEFAULT_FORMATS.select do |klass|
+      unless klass.name == "Mixlib::Versioning::Format::PartialSemVer" || klass.name == "Mixlib::Versioning::Format::GitDescribe"
+        klass
+      end
+    end
+
+    formats.each do |format|
+      context "#{format}" do
+        versions.each_slice(2) do |a, b|
+          it "parsed value #{a} is equal to #{format} parsed value #{b}" do
+            expect(described_class.parse(a) == format.new(b)).to be true
+          end
+        end
+      end # context
+    end # formats.each
+  end # describe "#=="
+end # describe Mixlib::Version