metric_fu 2.0.0 → 2.0.1

data/spec/generators/rails_best_practices_spec.rb

@@ -9,15 +9,15 @@ describe RailsBestPractices do
       practices.emit
     end
   end
-  
+
   describe "analyze method" do
     before :each do
       output = <<-HERE.gsub(/^[^\S\n]*/, "")
       ./app/views/admin/testimonials/_form.html.erb:17 - replace instance variable with local variable
       ./app/controllers/admin/campaigns_controller.rb:24,45,68,85 - use before_filter for show,edit,update,destroy
-      
+
       go to http://wiki.github.com/flyerhzm/rails_best_practices to see how to solve these errors.
-      
+
       Found 2 errors.
       HERE
       MetricFu::Configuration.run {}
@@ -25,11 +25,11 @@ describe RailsBestPractices do
       practices.instance_variable_set(:@output, output)
       @results = practices.analyze
     end
-    
+
     it "should get the total" do
       @results[:total].should == ["Found 2 errors."]
     end
-    
+
     it "should get the problems" do
       @results[:problems].size.should == 2
       @results[:problems].first.should == { :line => "17",
@@ -40,7 +40,7 @@ describe RailsBestPractices do
         :file => "./app/controllers/admin/campaigns_controller.rb" }
     end
   end
-  
+
   describe "to_h method" do
     it "should put things into a hash" do
       MetricFu::Configuration.run {}

data/spec/generators/rcov_spec.rb

@@ -1,13 +1,13 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe MetricFu::Rcov do
-  
+
   before :each do
     MetricFu::Configuration.run {}
     File.stub!(:directory?).and_return(true)
     @rcov = MetricFu::Rcov.new('base_dir')
   end
-  
+
   describe "emit" do
     before :each do
       @rcov.stub!(:puts)
@@ -20,7 +20,7 @@ describe MetricFu::Rcov do
       Dir.should_receive(:mkdir).with(MetricFu::Rcov.metric_directory)
       @rcov.emit
     end
-    
+
     it "should set the RAILS_ENV" do
       FileUtils.stub!(:rm_rf)
       Dir.stub!(:mkdir)
@@ -29,7 +29,7 @@ describe MetricFu::Rcov do
       @rcov.emit
     end
   end
-  
+
   describe "with RCOV_OUTPUT fed into" do
     before :each do
       MetricFu.rcov[:external] = nil
@@ -38,7 +38,7 @@ describe MetricFu::Rcov do
             and_return(mock("io", :read => RCOV_OUTPUT))
       @files = @rcov.analyze
     end
-    
+
     describe "analyze" do
       it "should compute percent of lines run" do
         @files["lib/templates/awesome/awesome_template.rb"][:percent_run].should == 13
@@ -72,14 +72,14 @@ describe MetricFu::Rcov do
       FileUtils.should_not_receive(:rm_rf)
       @rcov.emit
     end
-    
+
     it "should open the external rcov analysis file" do
       File.should_receive(:open).
             with(MetricFu.rcov[:external]).
             and_return(mock("io", :read => RCOV_OUTPUT))
       @files = @rcov.analyze
     end
-    
+
   end
 
 
@@ -107,18 +107,18 @@ Finished in 2.517686 seconds
 lib/templates/awesome/awesome_template.rb
 ================================================================================
    require 'fileutils'
-   
+
    class AwesomeTemplate < MetricFu::Template
-   
+
      def write
 !!     # Getting rid of the crap before and after the project name from integrity
 !!     @name = File.basename(Dir.pwd).gsub(/^\w+-|-\w+$/, "")
-!! 
+!!
 !!     # Copy Bluff javascripts to output directory
 !!     Dir[File.join(this_directory, '..', 'javascripts', '*')].each do |f|
 !!       FileUtils.copy(f, File.join(MetricFu.output_directory, File.basename(f)))
 !!     end
-!! 
+!!
 !!     report.each_pair do |section, contents|
 !!       if template_exists?(section)
 !!         create_instance_var(section, contents)
@@ -128,7 +128,7 @@ lib/templates/awesome/awesome_template.rb
 !!         MetricFu.report.save_output(html, MetricFu.output_directory, fn)
 !!       end
 !!     end
-!! 
+!!
 !!     # Instance variables we need should already be created from above
 !!     if template_exists?('index')
 !!       @html = erbify('index')
@@ -137,18 +137,18 @@ lib/templates/awesome/awesome_template.rb
 !!       MetricFu.report.save_output(html, MetricFu.output_directory, fn)
 !!     end
 !!   end
-   
+
      def this_directory
 !!     File.dirname(__FILE__)
 !!   end
 !! end
-   
+
 ================================================================================
 lib/templates/standard/standard_template.rb
 ================================================================================
    class StandardTemplate < MetricFu::Template
-   
-   
+
+
      def write
 !!     report.each_pair do |section, contents|
 !!       if template_exists?(section)
@@ -158,7 +158,7 @@ lib/templates/standard/standard_template.rb
 !!         MetricFu.report.save_output(html, MetricFu.output_directory, fn)
 !!       end
 !!     end
-!! 
+!!
 !!     # Instance variables we need should already be created from above
 !!     if template_exists?('index')
 !!       html = erbify('index')
@@ -166,7 +166,7 @@ lib/templates/standard/standard_template.rb
 !!       MetricFu.report.save_output(html, MetricFu.output_directory, fn)
 !!     end
 !!   end
-   
+
      def this_directory
 !!     File.dirname(__FILE__)
 !!   end

data/spec/generators/reek_spec.rb

@@ -11,7 +11,7 @@ describe Reek do
       reek.emit
     end
   end
-  
+
   describe "analyze method" do
     before :each do
       @lines = <<-HERE
@@ -36,37 +36,37 @@ NewlineController#some_method calls current_user.<< "new line\n" multiple times
       reek.instance_variable_set(:@output, @lines)
       @matches = reek.analyze
     end
-      
+
     it "should find the code smell's method name" do
       smell = @matches.first[:code_smells].first
       smell[:method].should == "ActivityReportsController#authorize_user"
     end
-    
+
     it "should find the code smell's type" do
       smell = @matches[1][:code_smells].first
       smell[:type].should == "Nested Iterators"
     end
-    
+
     it "should find the code smell's message" do
       smell = @matches[1][:code_smells].first
       smell[:message].should == "is nested"
     end
-    
+
     it "should find the code smell's type" do
       smell = @matches.first
       smell[:file_path].should == "app/controllers/activity_reports_controller.rb"
     end
-    
+
     it "should NOT insert nil smells into the array when there's a newline in the method call" do
       @matches.last[:code_smells].should == @matches.last[:code_smells].compact
-      @matches.last.should == {:file_path=>"app/controllers/newline_controller.rb", 
-                                :code_smells=>[{:type=>"Duplication", 
-                                                  :method=>"\"", 
+      @matches.last.should == {:file_path=>"app/controllers/newline_controller.rb",
+                                :code_smells=>[{:type=>"Duplication",
+                                                  :method=>"\"",
                                                   :message=>"multiple times"}]}
       # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
     end
   end
-  
+
 end
 
 describe Reek do

data/spec/generators/roodi_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
-describe Roodi do 
+describe Roodi do
   describe "emit" do
     it "should add config options when present" do
       MetricFu::Configuration.run do |config|
@@ -10,7 +10,7 @@ describe Roodi do
       roodi.should_receive(:`).with(/-config=lib\/config\/roodi_config\.yml/).and_return("")
       roodi.emit
     end
-    
+
     it "should NOT add config options when NOT present" do
       MetricFu::Configuration.run do |config|
         config.roodi = {:dirs_to_roodi => []}

data/spec/generators/saikuro_spec.rb

@@ -1,5 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
- 
+
 describe Saikuro do
   describe "to_h method" do
     before :all do
@@ -14,7 +14,7 @@ describe Saikuro do
     it "should find the filename of a file" do
       @output[:saikuro][:files].first[:filename].should == 'users_controller.rb'
     end
- 
+
     it "should find the name of the classes" do
       @output[:saikuro][:classes].first[:name].should == "UsersController"
       @output[:saikuro][:classes][1][:name].should == "SessionsController"
@@ -24,11 +24,11 @@ describe Saikuro do
       @output[:saikuro][:methods].first[:name].should == "UsersController#create"
       @output[:saikuro][:methods].first[:complexity].should == 4
     end
- 
+
     it "should find the complexity of a method" do
       @output[:saikuro][:methods].first[:complexity].should == 4
     end
- 
+
     it "should find the lines of a method" do
       @output[:saikuro][:methods].first[:lines].should == 15
     end
@@ -39,13 +39,13 @@ describe Saikuro do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
       saikuro = MetricFu::Saikuro.new
- 
+
       MetricFu.saikuro[:input_directory] = ["app", "lib"]
-  
+
       saikuro.format_directories.should == "\"app | lib\""
     end
   end
- 
+
   describe Saikuro::SFile do
     describe "getting elements from a Saikuro result file" do
      it "should parse nested START/END sections" do

data/spec/generators/stats_spec.rb

@@ -10,7 +10,7 @@ describe Stats do
       stats.emit
     end
   end
-  
+
   describe "analyze method" do
     before :each do
       @lines =  <<-HERE.gsub(/^\s*/, "")
@@ -38,19 +38,19 @@ describe Stats do
       File.should_receive(:open).and_return(mock("file", :read => @lines))
       @results = stats.analyze
     end
-    
+
     it "should get code Lines Of Code" do
       @results[:codeLOC].should == 915
     end
-    
+
     it "should get test Lines Of Code" do
       @results[:testLOC].should == 2226
     end
-    
+
     it "should get code to test ratio" do
       @results[:code_to_test_ratio].should == 2.4
     end
-    
+
     it "should get data on models" do
       model_data = @results[:lines].find {|line| line[:name] == "Models"}
       model_data[:classes].should == 9
@@ -61,7 +61,7 @@ describe Stats do
       model_data[:loc_per_method].should == 7
     end
   end
-  
+
   describe "to_h method" do
     it "should put things into a hash" do
       MetricFu::Configuration.run {}

data/spec/graphs/engines/gchart_spec.rb

@@ -18,12 +18,12 @@ describe MetricFu::GchartGrapher do
       grapher.instance_variable_get(:@max_value).should == 10
       grapher.instance_variable_get(:@yaxis).should == [0, 2, 4, 6, 8, 10]
     end
-    
+
     it "should set max value of the graph above largest value" do
       grapher = Object.new.extend(MetricFu::GchartGrapher)
       grapher.determine_y_axis_scale([19])
       grapher.instance_variable_get(:@max_value).should == 20
-      
+
       grapher.determine_y_axis_scale([20])
       grapher.instance_variable_get(:@max_value).should == 25
     end
@@ -34,7 +34,7 @@ describe "Gchart graphers" do
   before :each do
     MetricFu::Configuration.run {|config| config.graph_engine = :gchart}
   end
-  
+
   describe "FlayGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = FlayGchartGrapher.new
@@ -49,7 +49,7 @@ describe "Gchart graphers" do
       grapher.graph!
     end
   end
-  
+
   describe "FlogGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = FlogGchartGrapher.new
@@ -68,7 +68,7 @@ describe "Gchart graphers" do
       grapher.graph!
     end
   end
-  
+
   describe "RcovGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = RcovGchartGrapher.new
@@ -85,7 +85,7 @@ describe "Gchart graphers" do
       grapher.graph!
     end
   end
-  
+
   describe "ReekGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = ReekGchartGrapher.new
@@ -102,7 +102,7 @@ describe "Gchart graphers" do
       grapher.graph!
     end
   end
-  
+
   describe "RoodiGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = RoodiGchartGrapher.new
@@ -117,7 +117,7 @@ describe "Gchart graphers" do
       grapher.graph!
     end
   end
-  
+
   describe "StatsGchartGrapher graph! method" do
     it "should set static values for graph" do
       grapher = StatsGchartGrapher.new

data/spec/graphs/flog_grapher_spec.rb

@@ -4,7 +4,7 @@ describe MetricFu::FlogGrapher do
   before :each do
     MetricFu.configuration
     @flog_grapher = MetricFu::FlogGrapher.new
-    
+
   end
 
   it "should respond to flog_total, flog_average and labels" do
@@ -27,24 +27,24 @@ describe MetricFu::FlogGrapher do
       100.times do |i|
         methods["method_name_#{i}"] = {:score => i.to_f}
       end
-      
+
       @metrics = {:flog => {:total => 111.1,
                             :average => 7.7,
                             :method_containers => [ {:methods => methods } ] } }
       @date = "1/2"
     end
-    
+
     it "should push to top_five_percent_average" do
       average = (99.0 + 98.0 + 97.0 + 96.0 + 95.0) / 5.0
-      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)      
+      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)
       @flog_grapher.get_metrics(@metrics, @date)
     end
-    
+
     it "should push 9.9 to flog_average" do
       @flog_grapher.flog_average.should_receive(:push).with(7.7)
       @flog_grapher.get_metrics(@metrics, @date)
     end
-    
+
     context "when metrics were not generated" do
       before(:each) do
         @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "metric_missing.yml")))
@@ -90,7 +90,7 @@ describe MetricFu::FlogGrapher do
       end
     end
   end
-  
+
   describe "responding to #get_metrics with legacy data" do
     before(:each) do
       @metrics = YAML::load(File.open(File.join(File.dirname(__FILE__), "..", "resources", "yml", "20090630.yml")))
@@ -100,7 +100,7 @@ describe MetricFu::FlogGrapher do
 
     it "should push to top_five_percent_average" do
       average = (73.6 + 68.5 + 66.1 + 46.6 + 44.8 + 44.1 + 41.2 + 36.0) / 8.0
-      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)      
+      @flog_grapher.top_five_percent_average.should_receive(:push).with(average)
       @flog_grapher.get_metrics(@metrics, @date)
     end
   end