metric_fu 2.0.0 → 2.0.1

data/spec/base/generator_spec.rb

@@ -19,7 +19,7 @@ describe MetricFu::Generator do
   end
 
   before(:each) do
-    @concrete_class = ConcreteClass.new 
+    @concrete_class = ConcreteClass.new
   end
 
   describe "ConcreteClass#class_name" do
@@ -91,7 +91,7 @@ describe MetricFu::Generator do
       ConcreteClass.generate_report
     end
   end
-  
+
   describe '@concrete_class should have hook methods for '\
            +'[before|after]_[emit|analyze|to_h]' do
 
@@ -105,7 +105,7 @@ describe MetricFu::Generator do
         @concrete_class.respond_to?("after_#{meth}".to_sym).should be_true
       end
     end
-      
+
     it "should respond to #before_to_h" do
       @concrete_class.respond_to?("before_to_h".to_sym).should be_true
     end
@@ -129,7 +129,7 @@ describe MetricFu::Generator do
   end
 
   describe "#generate_report (in a concrete class)" do
-    
+
     %w[emit analyze].each do |meth|
       it "should call #before_#{meth}" do
         @concrete_class.should_receive("before_#{meth}")
@@ -146,12 +146,12 @@ describe MetricFu::Generator do
         @concrete_class.generate_report
       end
     end
-    
+
     it "should call #before_to_h" do
       @concrete_class.should_receive("before_to_h")
       @concrete_class.generate_report
     end
-    
+
     it "should call #to_h" do
       @concrete_class.should_receive(:to_h)
       @concrete_class.generate_report
@@ -160,7 +160,7 @@ describe MetricFu::Generator do
   end
 
   describe "path filter" do
-    
+
     context "given a list of paths" do
 
       before do
@@ -173,14 +173,14 @@ describe MetricFu::Generator do
                   lib/bad/two.rb
                   lib/bad/three.rb
                   lib/worse/four.rb)
-        @container = create_construct 
+        @container = create_construct
         @paths.each do |path|
           @container.file(path)
         end
         @old_dir = Dir.pwd
         Dir.chdir(@container)
       end
-      
+
       after do
         Dir.chdir(@old_dir)
         @container.destroy!
@@ -219,5 +219,5 @@ describe MetricFu::Generator do
 
 
   end
-  
+
 end

data/spec/base/graph_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe MetricFu do
-  
+
   describe "responding to #graph" do
     it "should return an instance of Graph" do
       MetricFu.graph.should be_a(Graph)
@@ -10,15 +10,52 @@ describe MetricFu do
 end
 
 describe MetricFu::Graph do
-  
+
   before(:each) do
     @graph = MetricFu::Graph.new
   end
-  
+
   describe "responding to #add with gchart enabled" do
     it 'should instantiate a grapher and push it to clazz' do
       @graph.clazz.should_receive(:push).with(an_instance_of(RcovGchartGrapher))
       @graph.add("rcov", 'gchart')
     end
-  end  
+  end
+
+  describe "responding to #add with gchart enabled" do
+    it 'should instantiate a grapher and push it to clazz' do
+      @graph.clazz.should_receive(:push).with(an_instance_of(RcovGchartGrapher))
+      @graph.add("rcov", 'gchart')
+    end
+  end 
+
+  describe "setting the date on the graph" do
+    before(:each) do
+      @graph.stub!(:puts)
+    end
+
+    it "should set the date once for one data point" do
+      Dir.should_receive(:[]).and_return(["metric_fu/tmp/_data/20101105.yml"])
+      File.should_receive(:join)
+      File.should_receive(:open).and_return("Metrics")
+      mock_grapher = stub
+      mock_grapher.should_receive(:get_metrics).with("Metrics", "11/5")
+      mock_grapher.should_receive(:graph!)
+     
+      @graph.clazz = [mock_grapher]
+      @graph.generate
+    end
+
+    it "should set the date when the data directory isn't in the default place" do
+      Dir.should_receive(:[]).and_return(["/some/kind/of/weird/directory/somebody/configured/_data/20101105.yml"])
+      File.should_receive(:join)
+      File.should_receive(:open).and_return("Metrics")
+      mock_grapher = stub
+      mock_grapher.should_receive(:get_metrics).with("Metrics", "11/5")
+      mock_grapher.should_receive(:graph!)
+
+      @graph.clazz = [mock_grapher]
+      @graph.generate
+    end
+  end 
 end

data/spec/base/line_numbers_spec.rb

@@ -1,62 +1,62 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
-describe LineNumbers do
-  
+describe MetricFu::LineNumbers do
+
   describe "in_method?" do
     it "should know if a line is NOT in a method" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.in_method?(2).should == false
     end
-  
+
     it "should know if a line is in an instance method" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.in_method?(8).should == true
     end
-  
+
     it "should know if a line is in an class method" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.in_method?(3).should == true
     end
   end
-  
+
   describe "method_at_line" do
     it "should know the name of an instance method at a particular line" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.method_at_line(8).should == "Foo#what"
     end
-    
+
     it "should know the name of a class method at a particular line" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.method_at_line(3).should == "Foo::awesome"
     end
-    
+
     it "should know the name of a private method at a particular line" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.method_at_line(28).should == "Foo#whoop"
     end
-    
+
     it "should know the name of a class method defined in a 'class << self block at a particular line" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/foo.rb"))
       ln.method_at_line(23).should == "Foo::neat"
     end
-    
+
     it "should know the name of an instance method at a particular line in a file with two classes" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/two_classes.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/two_classes.rb"))
       ln.method_at_line(3).should == "Foo#stuff"
       ln.method_at_line(9).should == "Bar#stuff"
     end
-    
+
     it "should work with modules" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/module.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/module.rb"))
       ln.method_at_line(4).should == 'KickAss#get_beat_up?'
     end
-    
+
     it "should work with module surrounding class" do
-      ln = LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/module_surrounds_class.rb"))
+      ln = MetricFu::LineNumbers.new(File.read(File.dirname(__FILE__) + "/../resources/line_numbers/module_surrounds_class.rb"))
       ln.method_at_line(5).should == "StuffModule::ThingClass#do_it"
       # ln.method_at_line(12).should == "StuffModule#blah" #why no work?
     end
 
   end
-  
+
 end

data/spec/base/report_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe MetricFu do
-  
+
   describe "#report" do
     it 'should return an instance of Report' do
       MetricFu.report.instance_of?(Report).should be(true)
@@ -68,9 +68,9 @@ describe MetricFu::Report do
     before(:each) do
       @config = mock('configuration')
     end
-    
+
     describe 'when the platform is os x ' do
-      
+
       before(:each) do
         @config.should_receive(:platform).and_return('darwin')
       end
@@ -81,7 +81,7 @@ describe MetricFu::Report do
           @config.should_receive(:is_cruise_control_rb?).and_return(true)
           MetricFu.stub!(:configuration).and_return(@config)
         end
-        
+
         it 'should return false' do
           @report.open_in_browser?.should be_false
         end
@@ -99,12 +99,12 @@ describe MetricFu::Report do
         end
       end
     end
-    
+
     describe 'when the platform is not os x ' do
       before(:each) do
         @config.should_receive(:platform).and_return('other')
       end
-      
+
       describe 'and we are in cruise control' do
         before(:each) do
           MetricFu.stub!(:configuration).and_return(@config)
@@ -119,14 +119,14 @@ describe MetricFu::Report do
         before(:each) do
           MetricFu.stub!(:configuration).and_return(@config)
         end
-        
+
         it 'should return false' do
           @report.open_in_browser?.should be_false
         end
       end
     end
   end
-  
+
 
   describe '#show_in_browser' do
     it 'should call open with the passed directory' do
@@ -134,6 +134,6 @@ describe MetricFu::Report do
       @report.should_receive(:system).with("open my_dir/index.html")
       @report.show_in_browser('my_dir')
     end
-    
+
   end
 end

data/spec/generators/churn_spec.rb

@@ -1,14 +1,14 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Churn do
-  
+
   describe "analyze method" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
       @changes = {"lib/generators/flog.rb"=>2, "lib/metric_fu.rb"=>3}
     end
-    
+
     it "should be empty on error" do
       churn = MetricFu::Churn.new
       churn.instance_variable_set(:@output, "fatal: Not a git repository")
@@ -24,13 +24,13 @@ describe Churn do
     end
 
   end
-  
+
   describe "to_h method" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
     end
-    
+
     it "should put the changes into a hash" do
       churn = MetricFu::Churn.new
       churn.instance_variable_set(:@churn, {:churn => 'results'})

data/spec/generators/flay_spec.rb

@@ -1,16 +1,16 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
-describe Flay do 
+describe Flay do
   describe "emit method" do
     it "should look at the dirs" do
       MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => ['app', 'lib'], :filetypes => ['rb']  } }
       File.stub!(:directory?).and_return(true)
-      @flay = MetricFu::Flay.new('base_dir')    
+      @flay = MetricFu::Flay.new('base_dir')
 
       @flay.should_receive(:`).with("flay  app lib")
       output = @flay.emit
     end
-    
+
     it "should limit flay scores by the minimum_score" do
       MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => [], :minimum_score => 99 } }
       File.stub!(:directory?).and_return(true)
@@ -20,7 +20,7 @@ describe Flay do
       output = @flay.emit
     end
   end
-  
+
   describe "analyze method" do
     before :each do
       lines = <<-HERE
@@ -42,7 +42,7 @@ Total score (lower is better) = 246
       @flay = MetricFu::Flay.new('base_dir')
       @flay.instance_variable_set(:@output, lines)
     end
-    
+
     it "should analyze and return matches" do
       @flay.analyze.should == [ ["Total score (lower is better) = 246"],
                                 ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
@@ -55,47 +55,47 @@ Total score (lower is better) = 246
                                   "app/controllers/primary_sites_controller.rb:89"] ]
     end
   end
-  
+
   describe "to_h method" do
-            
+
     before :each do
-      lines = [ ["Total score (lower is better) = 284"], 
-                  ["\n1) IDENTICAL code found in :or (mass*2 = 68)", 
-                    "app/controllers/link_targets_controller.rb:57", 
-                    "app/controllers/primary_sites_controller.rb:138"], 
-                  ["2) Similar code found in :if (mass = 64)", 
-                    "app/controllers/primary_sites_controller.rb:75", 
-                    "app/controllers/primary_sites_controller.rb:76", 
-                    "app/controllers/primary_sites_controller.rb:88", 
-                    "app/controllers/primary_sites_controller.rb:89"], 
-                  ["3) Similar code found in :defn (mass = 40)", 
-                    "app/controllers/link_targets_controller.rb:40", 
-                    "app/controllers/primary_sites_controller.rb:98"], 
-                  ["4) Similar code found in :defn (mass = 38)", 
-                    "app/controllers/link_targets_controller.rb:13", 
-                    "app/controllers/primary_sites_controller.rb:50"], 
-                  ["5) Similar code found in :defn (mass = 38)", 
-                    "app/models/primary_site.rb:104", 
-                    "app/models/primary_site.rb:109"], 
-                  ["6) Similar code found in :call (mass = 36)", 
-                    "app/controllers/bookmarklet_integration_controller.rb:6", 
+      lines = [ ["Total score (lower is better) = 284"],
+                  ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
+                    "app/controllers/link_targets_controller.rb:57",
+                    "app/controllers/primary_sites_controller.rb:138"],
+                  ["2) Similar code found in :if (mass = 64)",
+                    "app/controllers/primary_sites_controller.rb:75",
+                    "app/controllers/primary_sites_controller.rb:76",
+                    "app/controllers/primary_sites_controller.rb:88",
+                    "app/controllers/primary_sites_controller.rb:89"],
+                  ["3) Similar code found in :defn (mass = 40)",
+                    "app/controllers/link_targets_controller.rb:40",
+                    "app/controllers/primary_sites_controller.rb:98"],
+                  ["4) Similar code found in :defn (mass = 38)",
+                    "app/controllers/link_targets_controller.rb:13",
+                    "app/controllers/primary_sites_controller.rb:50"],
+                  ["5) Similar code found in :defn (mass = 38)",
+                    "app/models/primary_site.rb:104",
+                    "app/models/primary_site.rb:109"],
+                  ["6) Similar code found in :call (mass = 36)",
+                    "app/controllers/bookmarklet_integration_controller.rb:6",
                     "app/controllers/bookmarklet_integration_controller.rb:17"]]
-                    
+
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
       flay = MetricFu::Flay.new('base_dir')
       flay.instance_variable_set(:@matches, lines)
       @results = flay.to_h
     end
-  
+
     it "should find the total_score" do
       @results[:flay][:total_score].should == '284'
     end
-  
+
     it "should have 6 matches" do
       @results[:flay][:matches].size.should == 6
     end
-    
+
     it "should capture info for match" do
       @results[:flay][:matches].first[:reason].should =~ /IDENTICAL/
       @results[:flay][:matches].first[:matches].first[:name].should =~ /link_targets_controller/

data/spec/generators/flog_spec.rb

@@ -5,7 +5,7 @@ describe Flog do
     File.stub!(:directory?).and_return(true)
     @flog = MetricFu::Flog.new('base_dir')
   end
-  
+
   describe "emit method" do
     it "should look for files and flog them" do
       Dir.should_receive(:glob).with("lib/**/*.rb").and_return(["found/file.rb"])
@@ -15,41 +15,41 @@ describe Flog do
       @flog.emit
     end
   end
-  
+
   describe "analyze method" do
     it "should harvest the flog information and put it into method_containers" do
       first_full_method_name = "ClassName#first_method_name"
       second_full_method_name = "ClassName#second_method_name"
-      
+
       flogger = mock('flogger', :calls => {first_full_method_name => {:branch => 11.1, :puts => 1.1},
-                                           second_full_method_name => {:branch => 22.2, :puts => 2.2}}, 
+                                           second_full_method_name => {:branch => 22.2, :puts => 2.2}},
                                 :method_locations => {first_full_method_name => '/file/location.rb:11',
-                                                      second_full_method_name => '/file/location.rb:22'}, 
+                                                      second_full_method_name => '/file/location.rb:22'},
                                 :totals => {first_full_method_name => 11.11,
                                             second_full_method_name => 22.22})
       @flog.instance_variable_set(:@flogger, flogger)
       @flog.analyze
       method_containers = @flog.instance_variable_get(:@method_containers)
       method_containers.size.should == 1
-      
-      expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11", 
-                                                              :score=>11.11, 
-                                                              :operators=>{ :branch=>11.1, 
+
+      expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11",
+                                                              :score=>11.11,
+                                                              :operators=>{ :branch=>11.1,
                                                                             :puts=>1.1}},
-                           "ClassName#second_method_name" => {:path=>"/file/location.rb:22", 
-                                                              :score=>22.22, 
-                                                              :operators=>{ :branch=>22.2, 
-                                                                            :puts=>2.2}}}, 
+                           "ClassName#second_method_name" => {:path=>"/file/location.rb:22",
+                                                              :score=>22.22,
+                                                              :operators=>{ :branch=>22.2,
+                                                                            :puts=>2.2}}},
                 :path=>"/file/location.rb",
                 :average_score=>((11.11 + 22.22) / 2.0),
                 :total_score=>33.33,
                 :highest_score=>22.22,
                 :name=>"ClassName"}
-                
+
       method_containers["ClassName"].to_h.should == expected
     end
   end
-  
+
   describe "to_h method" do
     it "should make-a nice hash" do
       flogger = mock('flogger', :total => 111.1, :average => 7.3)
@@ -58,13 +58,13 @@ describe Flog do
                            :ignore_me_2 =>  mock('container_2', :highest_score => 33.3, :to_h => 'container_2'),
                            :ignore_me_3 =>  mock('container_3', :highest_score => 22.2, :to_h => 'container_3')}
       @flog.instance_variable_set(:@method_containers, method_containers)
-      
+
       expected = {:flog => { :total => 111.1,
                   :average => 7.3,
                   :method_containers => ['container_2', 'container_3', 'container_1']}}
-      
+
       @flog.to_h.should == expected
     end
-    
+
   end
 end