metasploit-model 0.30.2 → 1.0.0.pre.rails.pre.4.0

data/spec/lib/metasploit/model/version_spec.rb

@@ -1,3 +1,139 @@
-RSpec.describe Metasploit::Model::Version do
-  it_should_behave_like 'Metasploit::Version Version Module'
-end
+require 'spec_helper'
+
+describe Metasploit::Model::Version do
+  context 'CONSTANTS' do
+    context 'MAJOR' do
+      subject(:major) do
+        described_class::MAJOR
+      end
+
+      it { should be_a Integer }
+    end
+
+    context 'MINOR' do
+      subject(:minor) do
+        described_class::MINOR
+      end
+
+      it { should be_a Integer }
+    end
+
+    context 'PATCH' do
+      subject(:patch) do
+        described_class::PATCH
+      end
+
+      it { should be_a Integer }
+    end
+
+    pull_request = ENV['TRAVIS_PULL_REQUEST']
+
+    # a pull request cannot check PRERELEASE because it will be tested in the target branch, but the source itself
+    # is from the source branch and so has the source branch PRERELEASE.
+    #
+    # PRERELEASE can only be set appropriately for a merge by merging to the target branch and then updating PRERELEASE
+    # on the target branch before committing and/or pushing to github and travis-ci.
+    if pull_request.nil? || pull_request == 'false'
+      context 'PREPRELEASE' do
+        subject(:prerelease) do
+          described_class::PRERELEASE
+        end
+
+        branch = ENV['TRAVIS_BRANCH']
+
+        if branch.blank?
+          branch = `git rev-parse --abbrev-ref HEAD`.strip
+        end
+
+        if branch == 'master'
+          it 'does not have a PRERELEASE' do
+            expect(defined? described_class::PRERELEASE).to be_nil
+          end
+        else
+          branch_regex = /\A(?<type>bug|chore|feature|staging)(\/(?<story>[^\/]+))?\/(?<prerelease>[^\/]+)\z/
+          match = branch.match(branch_regex)
+
+          if match
+            it 'matches the branch relative name' do
+              expect(prerelease).to eq(match[:prerelease])
+            end
+          else
+            tag_regex = /\Av(?<major>\d+).(?<minor>\d+).(?<patch>\d+)(\.pre\.(?<prerelease>.*))?\z/
+            # travis-ci sets TRAVIS_BRANCH to the tag name for tag builds
+            match = branch.match(tag_regex)
+
+            if match
+              tag_prerelease = match[:prerelease]
+
+              if tag_prerelease
+                it 'matches the tag prerelease converted from a gem version to a VERSION' do
+                  expect(prerelease).to eq(tag_prerelease.gsub('.pre.', '-'))
+                end
+              else
+                it 'does not have a PRERELEASE' do
+                  expect(defined? described_class::PRERELEASE).to be_nil
+                end
+              end
+            else
+              it 'has a abbreviated reference that can be parsed for prerelease' do
+                fail "Do not know how to parse #{branch.inspect} for PRERELEASE"
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+
+  context 'full' do
+    subject(:full) do
+      described_class.full
+    end
+
+    #
+    # lets
+    #
+
+    let(:major) do
+      1
+    end
+
+    let(:minor) do
+      2
+    end
+
+    let(:patch) do
+      3
+    end
+
+    before(:each) do
+      stub_const("#{described_class}::MAJOR", major)
+      stub_const("#{described_class}::MINOR", minor)
+      stub_const("#{described_class}::PATCH", patch)
+    end
+
+    context 'with PRERELEASE' do
+      let(:prerelease) do
+        'prerelease'
+      end
+
+      before(:each) do
+        stub_const("#{described_class}::PRERELEASE", prerelease)
+      end
+
+      it 'is <major>.<minor>.<patch>-<prerelease>' do
+        expect(full).to eq("#{major}.#{minor}.#{patch}-#{prerelease}")
+      end
+    end
+
+    context 'without PRERELEASE' do
+      before(:each) do
+        hide_const("#{described_class}::PRERELEASE")
+      end
+
+      it 'is <major>.<minor>.<patch>' do
+        expect(full).to eq("#{major}.#{minor}.#{patch}")
+      end
+    end
+  end
+end

data/spec/lib/metasploit/model/visitation/visit_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Visitation::Visit do
+require 'spec_helper'
+
+describe Metasploit::Model::Visitation::Visit do
   let(:base_class) do
     described_class = self.described_class
 
@@ -52,15 +54,15 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
         end
 
         it 'should return Array(Metasploit::Model::Visitation::Visitor)' do
-          expect(visit).to be_an Array
-          expect(visit.length).to eq(1)
-          expect(visit.first).to be_a Metasploit::Model::Visitation::Visitor
+          visit.should be_an Array
+          visit.length.should == 1
+          visit.first.should be_a Metasploit::Model::Visitation::Visitor
         end
 
         it 'should add Metasploit::Model::Visitation::Visitor to visitor_by_module_name' do
           visitor = visit.first
 
-          expect(base_class.visitor_by_module_name[mod.name]).to eq(visitor)
+          base_class.visitor_by_module_name[mod.name].should == visitor
         end
       end
 
@@ -86,22 +88,18 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
         end
 
         it 'should return Array<Metasploit::Model::Visitation::Visitor>' do
-          expect(visit).to be_an Array
-          expect(visit.length).to eq(module_names.length)
-
-          expect(
-              visit.all? { |visitor|
-                visitor.is_a? Metasploit::Model::Visitation::Visitor
-              }
-          ).to eq(true)
+          visit.should be_an Array
+          visit.length.should == module_names.length
+
+          visit.all? { |visitor|
+            visitor.is_a? Metasploit::Model::Visitation::Visitor
+          }.should be_true
         end
 
         it 'should each Metasploit::Model::Visitation::Visitor to visitor_by_module_name' do
-          expect(
-              module_names.all? { |module_name|
-                visit.include? base_class.visitor_by_module_name[module_name]
-              }
-          ).to eq(true)
+          module_names.all? { |module_name|
+            visit.include? base_class.visitor_by_module_name[module_name]
+          }.should be_true
         end
       end
     end
@@ -160,7 +158,7 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
       end
 
       it 'should return visitor from visitor_by_module' do
-        expect(visitor).to eq(klass_visitor)
+        visitor.should == klass_visitor
       end
     end
 
@@ -189,13 +187,13 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
         end
 
         it 'should return ancestor visitor' do
-          expect(visitor).to eq(ancestor_visitor)
+          visitor.should == ancestor_visitor
         end
 
         it 'should cache ancestor visitor as visitor for klass in visitor_by_module' do
           visitor
 
-          expect(base_class.visitor_by_module[klass]).to eq(ancestor_visitor)
+          base_class.visitor_by_module[klass].should == ancestor_visitor
         end
       end
 
@@ -205,13 +203,13 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
         end
 
         it 'should return ancestor visitor' do
-          expect(visitor).to eq(ancestor_visitor)
+          visitor.should == ancestor_visitor
         end
 
         it 'should cache ancestor visitor as visitor for klass in visitor_by_module' do
           visitor
 
-          expect(base_class.visitor_by_module[klass]).to eq(ancestor_visitor)
+          base_class.visitor_by_module[klass].should == ancestor_visitor
         end
       end
 
@@ -231,7 +229,7 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
     end
 
     it 'should default to empty Hash' do
-      expect(visitor_by_module).to eq({})
+      visitor_by_module.should == {}
     end
   end
 
@@ -241,7 +239,7 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
     end
 
     it 'should default to empty Hash' do
-      expect(visitor_by_module_name).to eq({})
+      visitor_by_module_name.should == {}
     end
   end
 
@@ -276,13 +274,13 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
     end
 
     it 'should find visitor for node.class' do
-      expect(base_class).to receive(:visitor).with(node.class).and_call_original
+      base_class.should_receive(:visitor).with(node.class).and_call_original
 
       visit
     end
 
     it 'should visit on visitor' do
-      expect(@visitor).to receive(:visit).with(base_instance, node)
+      @visitor.should_receive(:visit).with(base_instance, node)
 
       visit
     end
@@ -311,7 +309,7 @@ RSpec.describe Metasploit::Model::Visitation::Visit do
       end
 
       it "should be able to call visit from inside a visitor's block" do
-        expect(visit).to eq(leaf_node)
+        visit.should == leaf_node
       end
     end
   end

data/spec/matchers/validate_nilness_of_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 RSpec.describe 'validate_nilness_of' do
   let(:record) {
     record_class.new

data/spec/spec_helper.rb

@@ -14,95 +14,22 @@ SimpleCov.formatter = Coveralls::SimpleCov::Formatter
 
 require File.expand_path('../dummy/config/environment.rb',  __FILE__)
 require 'rspec/rails'
+require 'rspec/autorun'
 
-# Use find_all_by_name instead of find_by_name as find_all_by_name will return pre-release versions
-gem_specification = Gem::Specification.find_all_by_name('metasploit-version').first
+# full backtrace in logs so its easier to trace errors
+Rails.backtrace_cleaner.remove_silencers!
 
-roots = [
-    Metasploit::Model::Engine.root.to_path,
-    gem_specification.gem_dir
-]
+spec_pathname = Metasploit::Model::Engine.root.join('spec')
 
-roots.each do |root|
-  Dir[File.join(root, 'spec', 'support', '**', '*.rb')].each do |f|
-    require f
-  end
+Dir[spec_pathname.join('support', '**', '*.rb')].each do |f|
+  require f
 end
 
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #     # => "be bigger than 2"
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
-  end
-
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-
   config.before(:suite) do
     # this must be explicitly set here because it should always be spec/tmp for w/e project is using
     # Metasploit::Model::Spec to handle file system clean up.
-    Metasploit::Model::Spec.temporary_pathname = Metasploit::Model::Engine.root.join('spec', 'tmp')
+    Metasploit::Model::Spec.temporary_pathname = spec_pathname.join('tmp')
     # Clean up any left over files from a previously aborted suite
     Metasploit::Model::Spec.remove_temporary_pathname
 
@@ -113,4 +40,7 @@ RSpec.configure do |config|
   config.after(:each) do
     Metasploit::Model::Spec.remove_temporary_pathname
   end
+
+  config.mock_with :rspec
+  config.order = :random
 end

data/spec/support/shared/contexts/metasploit/model/search/operator/union/children.rb

@@ -1,4 +1,4 @@
-RSpec.shared_context 'Metasploit::Model::Search::Operator::Group::Union#children' do
+shared_context 'Metasploit::Model::Search::Operator::Group::Union#children' do
   subject(:children) do
     operator.children(formatted_value)
   end

data/spec/support/shared/examples/metasploit/model/search/operation/value/integer.rb

@@ -1,4 +1,4 @@
-RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer' do
+shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer' do
   let(:operation_class) do
     described_class
   end
@@ -8,7 +8,7 @@ RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer'
       operation_class
     end
 
-    it { is_expected.to include Metasploit::Model::Search::Operation::Value::Integer }
+    it { should include Metasploit::Model::Search::Operation::Value::Integer }
   end
 
   context '#value' do
@@ -26,7 +26,7 @@ RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer'
       end
 
       it 'should pass through Integer' do
-        expect(value).to eq(formatted_value)
+        value.should == formatted_value
       end
     end
 
@@ -40,7 +40,7 @@ RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer'
       end
 
       it 'should convert String to Integer' do
-        expect(value).to eq(integer)
+        value.should == integer
       end
     end
 
@@ -54,11 +54,11 @@ RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer'
       end
 
       it 'should not extract the number' do
-        expect(value).not_to eq(integer)
+        value.should_not == integer
       end
 
       it 'should pass through the full value' do
-        expect(value).to eq(formatted_value)
+        value.should == formatted_value
       end
     end
 
@@ -68,11 +68,11 @@ RSpec.shared_examples_for 'Metasploit::Model::Search::Operation::Value::Integer'
       end
 
       it 'should not truncate Float to Integer' do
-        expect(value).not_to eq(formatted_value.to_i)
+        value.should_not == formatted_value.to_i
       end
 
       it 'should pass through Float' do
-        expect(value).to eq(formatted_value)
+        value.should == formatted_value
       end
     end
   end