metasploit-model 0.30.2 → 1.0.0.pre.rails.pre.4.0

data/spec/app/models/metasploit/model/search/operation/date_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Date do
   context 'validation' do
     context 'value' do
       before(:each) do
@@ -23,7 +25,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
         end
 
         it 'should not record error' do
-          expect(errors).not_to include(error)
+          errors.should_not include(error)
         end
       end
 
@@ -33,7 +35,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
         end
 
         it 'should record error' do
-          expect(errors).to include(error)
+          errors.should include(error)
         end
       end
     end
@@ -54,7 +56,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
       end
 
       it 'should be passed in Date' do
-        expect(value).to eq(formatted_value)
+        value.should == formatted_value
       end
     end
 
@@ -69,7 +71,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
         end
 
         it 'should be parsed Date' do
-          expect(value).to eq(date)
+          value.should == date
         end
       end
 
@@ -79,7 +81,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Date, type: :model do
         end
 
         it 'should pass through value' do
-          expect(value).to be formatted_value
+          value.should be formatted_value
         end
       end
     end

data/spec/app/models/metasploit/model/search/operation/group/base_spec.rb

@@ -1,13 +1,15 @@
-RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Group::Base do
   subject(:group) do
     described_class.new
   end
 
-  it { is_expected.to be_a Metasploit::Model::Search::Operation::Base }
+  it { should be_a Metasploit::Model::Search::Operation::Base }
 
   context 'validations' do
     context 'children' do
-      it { is_expected.to ensure_length_of(:children).is_at_least(1).with_short_message('is too short (minimum is 1 child)') }
+      it { should ensure_length_of(:children).is_at_least(1).with_short_message('is too short (minimum is 1 child)') }
 
       context '#children_valid' do
         subject(:children_valid) do
@@ -46,25 +48,25 @@ RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model d
           context 'with all valid' do
             before(:each) do
               children.each do |child|
-                allow(child).to receive(:valid?).and_return(true)
+                child.stub(valid?: true)
               end
             end
 
             it 'does not add error on :children' do
               group.valid?
 
-              expect(group.errors[:children]).not_to include(error)
+              group.errors[:children].should_not include(error)
             end
           end
 
           context 'with later valid' do
             before(:each) do
-              allow(children.first).to receive(:valid?).and_return(false)
-              allow(children.second).to receive(:valid?).and_return(true)
+              children.first.stub(valid?: false)
+              children.second.stub(valid?: true)
             end
 
             it 'does not short-circuit and validates all children' do
-              expect(children.second).to receive(:valid?).and_return(true)
+              children.second.should_receive(:valid?).and_return(true)
 
               children_valid
             end
@@ -72,7 +74,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model d
             it 'should add error on :children' do
               group.valid?
 
-              expect(group.errors[:children]).to include(error)
+              group.errors[:children].should include(error)
             end
           end
         end
@@ -85,7 +87,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model d
           it 'does not add error on :children' do
             group.valid?
 
-            expect(group.errors[:children]).not_to include(error)
+            group.errors[:children].should_not include(error)
           end
         end
       end
@@ -98,7 +100,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model d
     end
 
     context 'default' do
-      it { is_expected.to eq([]) }
+      it { should == [] }
     end
 
     context 'with attribute' do
@@ -115,7 +117,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Group::Base, type: :model d
       end
 
       it 'is the value passed with :children to #new' do
-        expect(children).to eq(expected_children)
+        children.should == expected_children
       end
     end
   end

data/spec/app/models/metasploit/model/search/operation/group/intersection_spec.rb

@@ -1,3 +1,5 @@
-RSpec.describe Metasploit::Model::Search::Operation::Group::Intersection, type: :model do
-  it { is_expected.to be_a Metasploit::Model::Search::Operation::Group::Base }
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Group::Intersection do
+  it { should be_a Metasploit::Model::Search::Operation::Group::Base }
 end

data/spec/app/models/metasploit/model/search/operation/group/union_spec.rb

@@ -1,3 +1,5 @@
-RSpec.describe Metasploit::Model::Search::Operation::Group::Union, type: :model do
-  it { is_expected.to be_a Metasploit::Model::Search::Operation::Group::Base }
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Group::Union do
+  it { should be_a Metasploit::Model::Search::Operation::Group::Base }
 end

data/spec/app/models/metasploit/model/search/operation/integer_spec.rb

@@ -1,6 +1,8 @@
-RSpec.describe Metasploit::Model::Search::Operation::Integer, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Integer do
   context 'validation' do
-    it { is_expected.to validate_numericality_of(:value).only_integer }
+    it { should validate_numericality_of(:value).only_integer }
   end
 
   it_should_behave_like 'Metasploit::Model::Search::Operation::Value::Integer'

data/spec/app/models/metasploit/model/search/operation/null_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operation::Null, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Null do
   context 'validation' do
     context 'operator' do
       context 'null' do
@@ -39,7 +41,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Null, type: :model do
           end
 
           it 'should not record error' do
-            expect(errors).not_to include(error)
+            errors.should_not include(error)
           end
         end
 
@@ -49,11 +51,11 @@ RSpec.describe Metasploit::Model::Search::Operation::Null, type: :model do
           end
 
           it 'should record error' do
-            expect(errors).to include(error)
+            errors.should include(error)
           end
 
           it 'should have no other errors, so that it would be valid without this type check on operator' do
-            expect(operation.errors.size).to eq(1)
+            operation.errors.size.should == 1
           end
         end
       end

data/spec/app/models/metasploit/model/search/operation/set/integer_spec.rb

@@ -1,5 +1,7 @@
-RSpec.describe Metasploit::Model::Search::Operation::Set::Integer, type: :model do
-  it { is_expected.to be_a Metasploit::Model::Search::Operation::Set }
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Set::Integer do
+  it { should be_a Metasploit::Model::Search::Operation::Set }
 
   it_should_behave_like 'Metasploit::Model::Search::Operation::Value::Integer'
 end

data/spec/app/models/metasploit/model/search/operation/set/string_spec.rb

@@ -1,5 +1,7 @@
-RSpec.describe Metasploit::Model::Search::Operation::Set::String, type: :model do
-  it { is_expected.to be_a Metasploit::Model::Search::Operation::Set }
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Set::String do
+  it { should be_a Metasploit::Model::Search::Operation::Set }
 
   it_should_behave_like 'Metasploit::Model::Search::Operation::Value::String'
 end

data/spec/app/models/metasploit/model/search/operation/set_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operation::Set, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::Set do
   subject(:set) do
     described_class.new(
         operator: operator,
@@ -95,7 +97,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Set, type: :model do
               attribute_set.sample
             end
 
-            it { is_expected.not_to include(error) }
+            it { should_not include(error) }
           end
 
           context 'without value in attribute_set' do
@@ -103,7 +105,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Set, type: :model do
               :not_an_member
             end
 
-            it { is_expected.to include(error) }
+            it { should include(error) }
           end
         end
 
@@ -116,7 +118,7 @@ RSpec.describe Metasploit::Model::Search::Operation::Set, type: :model do
             nil
           end
 
-          it { is_expected.not_to include(error) }
+          it { should_not include(error) }
         end
       end
     end

data/spec/app/models/metasploit/model/search/operation/string_spec.rb

@@ -1,6 +1,8 @@
-RSpec.describe Metasploit::Model::Search::Operation::String, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operation::String do
   context 'validation' do
-    it { is_expected.to validate_presence_of(:value) }
+    it { should validate_presence_of(:value) }
   end
 
   it_should_behave_like 'Metasploit::Model::Search::Operation::Value::String'

data/spec/app/models/metasploit/model/search/operator/association_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operator::Association, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operator::Association do
   subject(:operator) do
     described_class.new(
         :association => association,
@@ -14,11 +16,11 @@ RSpec.describe Metasploit::Model::Search::Operator::Association, type: :model do
     double('Metasploit::Model::Search::Operator::Base')
   end
 
-  it { is_expected.to be_a Metasploit::Model::Search::Operator::Base }
+  it { should be_a Metasploit::Model::Search::Operator::Base }
 
   context 'validations' do
-    it { is_expected.to validate_presence_of(:association) }
-    it { is_expected.to validate_presence_of(:source_operator) }
+    it { should validate_presence_of(:association) }
+    it { should validate_presence_of(:source_operator) }
   end
 
   context '#help' do
@@ -49,7 +51,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Association, type: :model do
       'source_operator_name'
     }
 
-    it { is_expected.to be_a Symbol }
+    it { should be_a Symbol }
 
     it 'should be <association>.<source_operator.name>' do
       expect(name).to eq :"#{association}.#{source_operator_name}"
@@ -79,7 +81,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Association, type: :model do
       }
     }
 
-    it { is_expected.to be_a Metasploit::Model::Search::Operation::Association }
+    it { should be_a Metasploit::Model::Search::Operation::Association }
 
     context 'Metasploit::Model::Search::Operation::Association' do
       context '#operator' do

data/spec/app/models/metasploit/model/search/operator/attribute_spec.rb

@@ -1,5 +1,7 @@
-RSpec.describe Metasploit::Model::Search::Operator::Attribute, type: :model do
-  it { is_expected.to be_a Metasploit::Model::Search::Operator::Single }
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operator::Attribute do
+  it { should be_a Metasploit::Model::Search::Operator::Single }
 
   context 'CONSTANTS' do
     context 'TYPES' do
@@ -7,30 +9,30 @@ RSpec.describe Metasploit::Model::Search::Operator::Attribute, type: :model do
         described_class::TYPES
       end
 
-      it { is_expected.to include(:boolean) }
-      it { is_expected.to include(:date) }
+      it { should include(:boolean) }
+      it { should include(:date) }
       it {
-        is_expected.to include(
+        should include(
                    {
                        set: :integer
                    }
                )
       }
       it {
-        is_expected.to include(
+        should include(
                    {
                        set: :string
                    }
                )
       }
-      it { is_expected.to include(:integer) }
-      it { is_expected.to include(:string) }
+      it { should include(:integer) }
+      it { should include(:string) }
     end
   end
 
   context 'validations' do
-    it { is_expected.to validate_presence_of(:attribute) }
-    it { is_expected.to ensure_inclusion_of(:type).in_array(described_class::TYPES) }
+    it { should validate_presence_of(:attribute) }
+    it { should validate_inclusion_of(:type).in_array(described_class::TYPES) }
   end
 
   context '#attribute_enumerable' do
@@ -75,7 +77,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Attribute, type: :model do
       end
 
       it 'should be #klass #<attribute>_set' do
-        expect(attribute_set).to eq(expected_attribute_set)
+        attribute_set.should == expected_attribute_set
       end
     end
   end
@@ -96,7 +98,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Attribute, type: :model do
     end
 
     it 'should be #attribute' do
-      expect(name).to eq(attribute)
+      name.should == attribute
     end
   end
 end

data/spec/app/models/metasploit/model/search/operator/base_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operator::Base, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operator::Base do
   subject(:operator) do
     described_class.new
   end
@@ -10,12 +12,12 @@ RSpec.describe Metasploit::Model::Search::Operator::Base, type: :model do
 
     before(:each) do
       # have to stub since it's not implemented on base
-      allow(operator).to receive(:name).and_return(name)
+      operator.stub(name: name)
     end
   end
 
   context 'validations' do
-    it { is_expected.to validate_presence_of(:klass) }
+    it { should validate_presence_of(:klass) }
   end
 
   context '#name' do

data/spec/app/models/metasploit/model/search/operator/delegation_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
+require 'spec_helper'
+
+describe Metasploit::Model::Search::Operator::Delegation do
   subject(:operator) do
     described_class.new(
         :klass => klass
@@ -9,7 +11,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
     Class.new
   end
 
-  it { is_expected.to be_a Metasploit::Model::Search::Operator::Base }
+  it { should be_a Metasploit::Model::Search::Operator::Base }
 
   context 'operator_name' do
     subject(:operator_name) do
@@ -30,7 +32,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
       end
 
       it 'should remove namespace' do
-        expect(operator_name).to eq(base_name.downcase.to_sym)
+        operator_name.should == base_name.downcase.to_sym
       end
     end
 
@@ -40,7 +42,7 @@ RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
       end
 
       it 'should convert name to underscore' do
-        expect(operator_name).to eq(:camel_case)
+        operator_name.should == :camel_case
       end
     end
   end
@@ -65,21 +67,17 @@ RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
     end
 
     before(:each) do
-      outer_search_operator_by_name = search_operator_by_name
-
-      klass.send(:define_singleton_method, :search_operator_by_name) do
-        outer_search_operator_by_name
-      end
+      klass.stub(:search_operator_by_name => search_operator_by_name)
     end
 
     it 'should convert formatted_operator to Symbol' do
-      expect(formatted_operator).to receive(:to_sym)
+      formatted_operator.should_receive(:to_sym)
 
       named_operator
     end
 
     it 'should look up operator name in search_operator_by_name of #klass' do
-      expect(named_operator).to eq(search_operator)
+      named_operator.should == search_operator
     end
 
     context 'with name not in klass.search_operator_by_name' do
@@ -102,9 +100,9 @@ RSpec.describe Metasploit::Model::Search::Operator::Delegation, type: :model do
 
     it 'should delegate to operator_name' do
       operator_name = double('Operator Name')
-      allow(operator.class).to receive(:operator_name).and_return(operator_name)
+      operator.class.stub(:operator_name => operator_name)
 
-      expect(name).to eq(operator_name)
+      name.should == operator_name
     end
   end
 end