metar-parser 1.2.0 → 1.2.1

data/spec/{unit/temperature_spec.rb → temperature_spec.rb}

@@ -4,15 +4,15 @@ require "spec_helper"
 describe Metar::Temperature do
   context '.parse' do
     it 'understands numbers' do
-      t = Metar::Temperature.parse( '5' )
+      t = Metar::Temperature.parse('5')
 
-      expect(t.value).to be_within( 0.01 ).of( 5.0 )
+      expect(t.value).to be_within(0.01).of(5.0)
     end
 
     it 'treats an M-prefix as a negative indicator' do
-      t = Metar::Temperature.parse( 'M5' )
+      t = Metar::Temperature.parse('M5')
 
-      expect(t.value).to be_within( 0.01 ).of( -5.0 )
+      expect(t.value).to be_within(0.01).of(-5.0)
     end
 
     it 'returns nil for other values' do
@@ -23,14 +23,14 @@ describe Metar::Temperature do
 
   context '#to_s' do
     it 'abbreviates the units' do
-      t = Metar::Temperature.new( 5 )
+      t = Metar::Temperature.new(5)
 
       expect(t.to_s).to eq('5°C')
     end
 
     it 'rounds to the nearest degree' do
-      expect(Metar::Temperature.new( 5.1 ).to_s).to eq('5°C')
-      expect(Metar::Temperature.new( 5.5 ).to_s).to eq('6°C')
+      expect(Metar::Temperature.new(5.1).to_s).to eq('5°C')
+      expect(Metar::Temperature.new(5.5).to_s).to eq('6°C')
     end
   end
 end

data/spec/{unit/variable_wind_spec.rb → variable_wind_spec.rb}

@@ -3,29 +3,28 @@ require "spec_helper"
 describe Metar::VariableWind do
   context '.parse' do
     it 'understands nnn + V + nnn' do
-      vw = Metar::VariableWind.parse( '090V180' )
+      vw = Metar::VariableWind.parse('090V180')
 
-      expect(vw.direction1.value).to eq( 90.0)
+      expect(vw.direction1.value).to eq(90.0)
       expect(vw.direction2.value).to eq(180.0)
     end
 
     it 'accepts 360, rounding to 0 - 1' do
-      vw = Metar::VariableWind.parse( '360V090' )
+      vw = Metar::VariableWind.parse('360V090')
 
-      expect(vw.direction1.value).to eq(  0.0)
-      expect(vw.direction2.value).to eq( 90.0)
+      expect(vw.direction1.value).to eq(0.0)
+      expect(vw.direction2.value).to eq(90.0)
     end
 
-
     it 'accepts 360, rounding to 0 - 2' do
-      vw = Metar::VariableWind.parse( '090V360' )
+      vw = Metar::VariableWind.parse('090V360')
 
-      expect(vw.direction1.value).to eq( 90.0)
-      expect(vw.direction2.value).to eq(  0.0)
+      expect(vw.direction1.value).to eq(90.0)
+      expect(vw.direction2.value).to eq(0.0)
     end
 
     it 'returns nil for other' do
-      vw = Metar::VariableWind.parse( 'XXX' )
+      vw = Metar::VariableWind.parse('XXX')
 
       expect(vw).to be_nil
     end
@@ -33,7 +32,7 @@ describe Metar::VariableWind do
 
   context '#to_s' do
     it 'renders compatible values as compass directions' do
-      vw = Metar::VariableWind.parse( '090V180' )
+      vw = Metar::VariableWind.parse('090V180')
 
       expect(vw.to_s).to eq('E - S')
     end

data/spec/{unit/vertical_visibility_spec.rb → vertical_visibility_spec.rb}

@@ -8,7 +8,7 @@ RSpec::Matchers.define :be_distance do |expected|
       false
     elsif distance.value.nil? && expected.nil?
       true
-    elsif ( distance.value - expected ).abs > 0.01
+    elsif (distance.value - expected).abs > 0.01
       false
     else
       true

data/spec/{unit/visibility_spec.rb → visibility_spec.rb}

@@ -1,11 +1,11 @@
 # encoding: utf-8
 require "spec_helper"
 
-RSpec::Matchers.define :be_visibility do | distance, direction, comparator |
-  match do | visibility |
-    if    visibility.nil? && [ distance, direction, comparator ].all?( &:nil? )
+RSpec::Matchers.define :be_visibility do |distance, direction, comparator|
+  match do |visibility|
+    if    visibility.nil? && [ distance, direction, comparator ].all?(&:nil?)
       true
-    elsif visibility.nil? != [ distance, direction, comparator ].all?( &:nil? )
+    elsif visibility.nil? != [ distance, direction, comparator ].all?(&:nil?)
       false
     elsif visibility.distance.nil?   != distance.nil?
       false
@@ -13,11 +13,11 @@ RSpec::Matchers.define :be_visibility do | distance, direction, comparator |
       false
     elsif visibility.comparator.nil? != comparator.nil?
       false
-    elsif visibility.distance.is_a?( Metar::Distance ) && (visibility.distance.value - distance).abs > 0.01
+    elsif visibility.distance.is_a?(Metar::Distance)&& (visibility.distance.value - distance).abs > 0.01
       false
-    elsif visibility.direction.is_a?( M9t::Direction ) && (visibility.direction.value - direction).abs > 0.01
+    elsif visibility.direction.is_a?(M9t::Direction)&& (visibility.direction.value - direction).abs > 0.01
       false
-    elsif comparator.is_a?( Symbol )                   && visibility.comparator != comparator
+    elsif comparator.is_a?(Symbol)                   && visibility.comparator != comparator
       false
     else
       true
@@ -47,7 +47,6 @@ describe Metar::Visibility do
   end
 
   context '#to_s' do
-
     before :each do
       @locale = I18n.locale
       I18n.locale = :it
@@ -58,15 +57,15 @@ describe Metar::Visibility do
     end
 
     [
-      [ 'with distance',                           :en, [ :set, nil,  nil ],        '4km' ],
-      [ 'with distance and direction',             :en, [ :set, :set, nil ],        '4km ESE' ],
-      [ 'with distance and comparator',            :en, [ :set, nil,  :less_than ], 'less than 4km' ],
-      [ 'with distance, direction and comparator', :en, [ :set, :set, :more_than ], 'more than 4km ESE' ],
-      [ 'with distance and direction',             :it, [ :set, :set, nil ],        '4km ESE' ],
-      [ 'with distance, direction and comparator', :it, [ :set, :set, :more_than ], 'piú di 4km ESE' ],
-    ].each do | docstring, locale, ( distance, direction, comparator ), expected |
-      distance  = Metar::Distance.new( 4321 ) if distance  == :set
-      direction = M9t::Direction.new( 123 )   if direction == :set
+      ['with distance',                           :en, [ :set, nil,  nil ],        '4km'],
+      ['with distance and direction',             :en, [ :set, :set, nil ],        '4km ESE'],
+      ['with distance and comparator',            :en, [ :set, nil,  :less_than ], 'less than 4km'],
+      ['with distance, direction and comparator', :en, [ :set, :set, :more_than ], 'more than 4km ESE'],
+      ['with distance and direction',             :it, [ :set, :set, nil ],        '4km ESE'],
+      ['with distance, direction and comparator', :it, [ :set, :set, :more_than ], 'piú di 4km ESE'],
+    ].each do |docstring, locale, (distance, direction, comparator), expected|
+      distance  = Metar::Distance.new(4321) if distance  == :set
+      direction = M9t::Direction.new(123)   if direction == :set
 
       example docstring + " (#{locale})" do
         I18n.locale = locale
@@ -75,8 +74,5 @@ describe Metar::Visibility do
         expect(value).to eq(expected)
       end
     end
-
   end
-
 end
-

data/spec/weather_phenomenon_spec.rb

@@ -0,0 +1,66 @@
+# encoding: utf-8
+require "spec_helper"
+
+RSpec::Matchers.define :be_weather_phenomenon do |modifier, descriptor, phenomenon|
+  match do |wp|
+    if wp.nil? && phenomenon.nil?
+      true
+    elsif wp.nil?       != phenomenon.nil?
+      false
+    elsif wp.phenomenon != phenomenon
+      false
+    elsif wp.modifier   != modifier
+      false
+    elsif wp.descriptor != descriptor
+      false
+    else
+      true
+    end
+  end
+end
+
+describe Metar::WeatherPhenomenon do
+  context '.parse' do
+    [
+      ['simple phenomenon',                  'BR',     [nil,      nil,            'mist']],
+      ['descriptor + phenomenon',            'BCFG',   [nil,      'patches of',   'fog']],
+      ['thunderstorm and rain',              'TSRA',   [nil,      'thunderstorm and', 'rain']],
+      ['intensity + phenomenon',             '+RA',    ['heavy',  nil,            'rain']],
+      ['intensity + proximity + phenomenon', '-VCTSRA', ['nearby light', 'thunderstorm and', 'rain']],
+      ['2 phenomena: SN RA',                 'SNRA',   [nil,      nil,            'snow and rain']],
+      ['2 phenomena: RA DZ',                 'RADZ',   [nil,      nil,            'rain and drizzle']],
+      ['modifier + descriptor + phenomenon', 'VCDRFG', ['nearby', 'low drifting', 'fog']],
+      ['returns nil for unmatched',          'FUBAR',  [nil,      nil,            nil]],
+    ].each do |docstring, raw, expected|
+      example docstring do
+        expect(Metar::WeatherPhenomenon.parse(raw)).to be_weather_phenomenon(*expected)
+      end
+    end
+  end
+
+  context '#to_s' do
+    before :all do
+      @locale = I18n.locale
+      I18n.locale = :it
+    end
+
+    after :all do
+      I18n.locale = @locale
+    end
+
+    [
+      ['simple phenomenon',       :en, [ nil,    nil,          'mist'],    'mist'],
+      ['simple phenomenon',       :it, [ nil,    nil,          'mist'],    'foschia'],
+      ['descriptor + phenomenon', :en, [ nil,    'patches of', 'fog'],     'patches of fog'],
+      ['thunderstorm and rain',   :en, [ nil,    'thunderstorm and', 'rain'],  'thunderstorm and rain'],
+      ['modifier + phenomenon',   :en, ['heavy', nil,          'drizzle'], 'heavy drizzle'],
+      ['modifier + descriptor + phenomenon', :en, ['heavy', 'freezing', 'drizzle'], 'heavy freezing drizzle'],
+    ].each do |docstring, locale, (modifier, descriptor, phenomenon), expected|
+      example docstring + " (#{locale})" do
+        I18n.locale = locale
+        expect(Metar::WeatherPhenomenon.new(phenomenon, modifier, descriptor).to_s).to eq(expected)
+      end
+    end
+  end
+end
+

data/spec/{unit/wind_spec.rb → wind_spec.rb}

@@ -3,26 +3,26 @@ require "spec_helper"
 
 RSpec::Matchers.define :be_wind do |direction, speed, gusts|
   match do |wind|
-    if wind.nil?              && [direction, speed, gusts].all?(&:nil?)
+    if wind.nil? && [direction, speed, gusts].all?(&:nil?)
       true
     elsif wind.nil?
       false
     elsif wind.direction.nil? != direction.nil?
       false
-    elsif wind.speed.nil?     != speed.nil?
+    elsif wind.speed.nil? != speed.nil?
       false
-    elsif wind.gusts.nil?     != gusts.nil?
+    elsif wind.gusts.nil? != gusts.nil?
       false
-    elsif direction.is_a?(Symbol)         && wind.direction != direction
+    elsif direction.is_a?(Symbol) && wind.direction != direction
       false
     elsif direction.is_a?(M9t::Direction) && (wind.direction.value - direction).abs > 0.01
       false
-    elsif speed.is_a?(Symbol)             && wind.speed     != speed
-       false
-    elsif speed.is_a?(Metar::Speed)       && (wind.speed.value - speed).abs > 0.01
+    elsif speed.is_a?(Symbol) && wind.speed != speed
+      false
+    elsif speed.is_a?(Metar::Speed) && (wind.speed.value - speed).abs > 0.01
+      false
+    elsif !wind.gusts.nil? && (wind.gusts.value - gusts).abs > 0.01
       false
-    elsif ! wind.gusts.nil?               && (wind.gusts.value - gusts).abs > 0.01
-       false
     else
       true
     end
@@ -37,7 +37,7 @@ describe Metar::Wind do
       ['understands 5 digits + KMH',                         '12345KMH',    [123.0, 12.50, nil]],
       ['understands 5 digits + MPS',                         '12345MPS',    [123.0, 45.00, nil]],
       ['understands 5 digits + KT',                          '12345KT',     [123.0, 23.15, nil]],
-      ['rounds 360 down to 0',                               '36045KT',     [  0.0, 23.15, nil]],
+      ['rounds 360 down to 0',                               '36045KT',     [0.0,   23.15, nil]],
       ['returns nil for directions outside 0 to 360',        '88845KT',     [nil,   nil,   nil]],
       # +gusts
       ['understands 5 digits + G + 2 digits',                '12345G67',    [123.0, 12.50, 18.61]],
@@ -103,4 +103,3 @@ describe Metar::Wind do
     end
   end
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metar-parser
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Joe Yates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -150,7 +164,6 @@ files:
 - COPYING
 - README.md
 - Rakefile
-- bin/parse_raw.rb
 - lib/metar.rb
 - lib/metar/data.rb
 - lib/metar/parser.rb
@@ -162,24 +175,25 @@ files:
 - locales/en.yml
 - locales/it.yml
 - locales/pt-BR.yml
+- spec/data_spec.rb
+- spec/distance_spec.rb
+- spec/i18n_spec.rb
+- spec/parser_spec.rb
+- spec/pressure_spec.rb
+- spec/raw_spec.rb
+- spec/remark_spec.rb
+- spec/report_spec.rb
+- spec/runway_visible_range_spec.rb
+- spec/sky_condition_spec.rb
 - spec/spec_helper.rb
-- spec/unit/distance_spec.rb
-- spec/unit/i18n_spec.rb
-- spec/unit/parser_spec.rb
-- spec/unit/pressure_spec.rb
-- spec/unit/raw_spec.rb
-- spec/unit/remark_spec.rb
-- spec/unit/report_spec.rb
-- spec/unit/runway_visible_range_spec.rb
-- spec/unit/sky_condition_spec.rb
-- spec/unit/speed_spec.rb
-- spec/unit/station_spec.rb
-- spec/unit/temperature_spec.rb
-- spec/unit/variable_wind_spec.rb
-- spec/unit/vertical_visibility_spec.rb
-- spec/unit/visibility_spec.rb
-- spec/unit/weather_phenomenon_spec.rb
-- spec/unit/wind_spec.rb
+- spec/speed_spec.rb
+- spec/station_spec.rb
+- spec/temperature_spec.rb
+- spec/variable_wind_spec.rb
+- spec/vertical_visibility_spec.rb
+- spec/visibility_spec.rb
+- spec/weather_phenomenon_spec.rb
+- spec/wind_spec.rb
 homepage: http://github.com/joeyates/metar-parser
 licenses: []
 metadata: {}
@@ -191,7 +205,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -204,21 +218,22 @@ signing_key:
 specification_version: 4
 summary: A Ruby gem for worldwide weather reports
 test_files:
-- spec/unit/runway_visible_range_spec.rb
-- spec/unit/weather_phenomenon_spec.rb
-- spec/unit/temperature_spec.rb
-- spec/unit/i18n_spec.rb
-- spec/unit/pressure_spec.rb
-- spec/unit/remark_spec.rb
-- spec/unit/speed_spec.rb
-- spec/unit/vertical_visibility_spec.rb
-- spec/unit/parser_spec.rb
-- spec/unit/visibility_spec.rb
-- spec/unit/report_spec.rb
-- spec/unit/raw_spec.rb
-- spec/unit/distance_spec.rb
-- spec/unit/wind_spec.rb
-- spec/unit/sky_condition_spec.rb
-- spec/unit/station_spec.rb
-- spec/unit/variable_wind_spec.rb
+- spec/runway_visible_range_spec.rb
+- spec/weather_phenomenon_spec.rb
+- spec/temperature_spec.rb
+- spec/i18n_spec.rb
+- spec/pressure_spec.rb
+- spec/remark_spec.rb
+- spec/speed_spec.rb
+- spec/vertical_visibility_spec.rb
+- spec/parser_spec.rb
+- spec/visibility_spec.rb
+- spec/data_spec.rb
+- spec/report_spec.rb
+- spec/raw_spec.rb
+- spec/distance_spec.rb
+- spec/wind_spec.rb
+- spec/sky_condition_spec.rb
+- spec/station_spec.rb
+- spec/variable_wind_spec.rb
 has_rdoc: 

data/bin/parse_raw.rb

@@ -1,27 +0,0 @@
-#!/usr/bin/env ruby
-
-=begin
-
-Use the data downloaded by 'download_raw.rb' to bulk test the Report
-
-=end
-
-require 'yaml'
-require File.join(File.expand_path(File.dirname(__FILE__) + '/../lib'), 'metar')
-
-filename = File.join(File.expand_path(File.dirname(__FILE__) + '/../data'), "stations.yml")
-stations = YAML.load_file(filename)
-
-stations.each_pair do |cccc, raw_text|
-  raw = Metar::Raw.new(cccc, raw_text)
-  report = nil
-  begin
-    report = Metar::Report.new(raw)
-    $stdout.print '.'
-  rescue => e
-    $stderr.puts "#{ raw.metar }"
-    $stderr.puts "  Error: #{ e }"
-    $stdout.print 'E'
-  end
-  $stdout.flush
-end

data/spec/unit/pressure_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-describe Metar::Pressure do
-  context '.parse' do
-    it 'interprets the Q prefix as hectopascals' do
-      expect(Metar::Pressure.parse( 'Q1300' ).value).to be_within( 0.01 ).of( 1.3 )
-    end
-
-    it 'interprets the A prefix as inches of mercury' do
-      expect(Metar::Pressure.parse( 'A1234' ).value).to be_within( 0.01 ).of( 0.42 )
-    end
-
-    it 'require 4 digits' do
-      expect(Metar::Pressure.parse( 'Q12345' )).to be_nil
-      expect(Metar::Pressure.parse( 'A123' )).to be_nil
-    end
-
-    it 'returns nil for nil' do
-      expect(Metar::Pressure.parse( nil )).to be_nil
-    end
-  end
-end

data/spec/unit/runway_visible_range_spec.rb

@@ -1,88 +0,0 @@
-# encoding: utf-8
-require "spec_helper"
-
-RSpec::Matchers.define :be_runway_visible_range do | designator, visibility1, visibility2, tendency |
-  match do | rvr |
-    if rvr.nil?                && designator.nil?
-      true
-    elsif rvr.nil?             != designator.nil?
-      false
-    elsif rvr.visibility1.nil? != visibility1.nil?
-      false
-    elsif rvr.visibility2.nil? != visibility2.nil?
-      false
-    elsif rvr.tendency.nil? != tendency.nil?
-      false
-    elsif ! visibility1.nil? &&
-          ( ( rvr.visibility1.distance.value - visibility1[0] ).abs > 0.01 ||
-            rvr.visibility1.comparator != visibility1[ 2 ] )
-      false
-    elsif ! visibility2.nil? &&
-          ( ( rvr.visibility2.distance.value - visibility2[0] ).abs > 0.02 ||
-            rvr.visibility2.comparator != visibility2[2] )
-      false
-    elsif tendency != rvr.tendency
-      false
-    else
-      true
-    end
-  end
-end
-
-describe Metar::RunwayVisibleRange do
-
-  context '.parse' do
-
-    [
-      [ 'understands R + nn + / + nnnn',     'R12/3400',        [ '12',  [3400.00, nil, nil],        nil,                nil ] ],
-      [ 'understands runway positions: RLC', 'R12L/3400',       [ '12L', [3400.00, nil, nil],        nil,                nil ] ],
-      [ 'understands comparators: PM',       'R12/P3400',       [ '12',  [3400.00, nil, :more_than], nil,                nil ] ],
-      [ 'understands tendencies: NUD',       'R12/3400U',       [ '12',  [3400.00, nil, nil],        nil,                :improving ] ],
-      [ 'understands feet',                  'R12/3400FT',      [ '12',  [1036.32, nil, nil],        nil,                nil ] ],
-      [ 'understands second visibilities (m)',  'R26/0750V1200U',  [ '12', [ 750.0,  nil, nil],     [1200.0, nil, nil], :improving ] ],
-      [ 'understands second visibilities (ft)', 'R12/3400V1800FT', [ '12', [1036.32, nil, nil],     [548.64, nil, nil], nil ] ],
-      [ 'returns nil for nil',               nil,               [ nil,   nil,                        nil,                nil ] ],
-    ].each do | docstring, raw, expected |
-      example docstring do
-        expect(Metar::RunwayVisibleRange.parse(raw)).to be_runway_visible_range( *expected )
-      end
-    end
-
-  end
-
-  context '#to_s' do
-
-    before :all do
-      @locale = I18n.locale
-      I18n.locale = :it
-    end
-
-    after :all do
-      I18n.locale = @locale
-    end
-
-    [
-      [ 'v1',        :en, [ [3400.00, nil, nil], nil,                 nil ], 'runway 14: 3400m' ],
-      [ 'v1 and v2',       :en,  [ [3400.00, nil, nil], [1900.00, nil, nil], nil ], 'runway 14: from 3400m to 1900m' ],
-      [ 'v1 and tendency', :en, [ [3400.00, nil, nil], nil,                 :improving ], 'runway 14: 3400m improving' ],
-    ].each do | docstring, locale, ( visibility1, visibility2, tendency ), expected |
-      d1 = Metar::Distance.new( visibility1[0] )
-      v1 = Metar::Visibility.new( d1, visibility1[1], visibility1[2] )
-      v2 =
-        if ! visibility2.nil?
-          d2 = Metar::Distance.new( visibility2[0] )
-          Metar::Visibility.new( d2, visibility2[1], visibility2[2] )
-        else
-          nil
-        end
-
-      example docstring + " (#{locale})" do
-        I18n.locale = locale
-        expect(Metar::RunwayVisibleRange.new('14', v1, v2, tendency).to_s).to eq(expected)
-      end
-    end
-
-  end
-
-end
-

data/spec/unit/speed_spec.rb

@@ -1,45 +0,0 @@
-require "spec_helper"
-
-describe Metar::Speed do
-  context '.parse' do
-    it 'returns nil for nil' do
-      speed = Metar::Speed.parse( nil )
-
-      expect(speed).to be_nil
-    end
-
-    it 'parses knots' do
-      speed = Metar::Speed.parse( '5KT' )
-
-      expect(speed).to be_a( Metar::Speed )
-      expect(speed.value).to be_within( 0.01 ).of( 2.57 )
-    end
-
-    it 'parses meters per second' do
-      speed = Metar::Speed.parse( '7MPS' )
-
-      expect(speed).to be_a( Metar::Speed )
-      expect(speed.value).to be_within( 0.01 ).of( 7.00 )
-    end
-
-    it 'parses kilometers per hour' do
-      speed = Metar::Speed.parse( '14KMH' )
-
-      expect(speed).to be_a( Metar::Speed )
-      expect(speed.value).to be_within( 0.01 ).of( 3.89 )
-    end
-
-    it 'trates straight numbers as kilomters per hour' do
-      speed = Metar::Speed.parse( '14' )
-
-      expect(speed).to be_a( Metar::Speed )
-      expect(speed.value).to be_within( 0.01 ).of( 3.89 )
-    end
-
-    it 'returns nil for other strings' do
-      speed = Metar::Speed.parse( '' )
-
-      expect(speed).to be_nil
-    end
-  end
-end

data/spec/unit/weather_phenomenon_spec.rb

@@ -1,66 +0,0 @@
-# encoding: utf-8
-require "spec_helper"
-
-RSpec::Matchers.define :be_weather_phenomenon do | modifier, descriptor, phenomenon  |
-  match do | wp |
-    if wp.nil? && phenomenon.nil?
-      true
-    elsif wp.nil?       != phenomenon.nil?
-      false
-    elsif wp.phenomenon != phenomenon
-      false
-    elsif wp.modifier   != modifier
-      false
-    elsif wp.descriptor != descriptor
-      false
-    else
-      true
-    end
-  end
-end
-
-describe Metar::WeatherPhenomenon do
-  context '.parse' do
-    [
-      [ 'simple phenomenon',                  'BR',     [ nil,      nil,            'mist' ] ],
-      [ 'descriptor + phenomenon',            'BCFG',   [ nil,      'patches of',   'fog'  ] ],
-      [ 'thunderstorm and rain',              'TSRA',   [ nil,      'thunderstorm and', 'rain' ] ],
-      [ 'intensity + phenomenon',             '+RA',    [ 'heavy',  nil,            'rain' ] ],
-      [ 'intensity + proximity + phenomenon', '-VCTSRA', [ 'nearby light', 'thunderstorm and', 'rain' ] ],
-      [ '2 phenomena: SN RA',                 'SNRA',   [ nil,      nil,            'snow and rain' ] ],
-      [ '2 phenomena: RA DZ',                 'RADZ',   [ nil,      nil,            'rain and drizzle' ] ],
-      [ 'modifier + descriptor + phenomenon', 'VCDRFG', [ 'nearby', 'low drifting', 'fog'  ] ],
-      [ 'returns nil for unmatched',          'FUBAR',  [ nil,      nil,            nil  ] ],
-    ].each do | docstring, raw, expected |
-      example docstring do
-        expect(Metar::WeatherPhenomenon.parse( raw )).to be_weather_phenomenon(*expected)
-      end
-    end
-  end
-
-  context '#to_s' do
-    before :all do
-      @locale = I18n.locale
-      I18n.locale = :it
-    end
-
-    after :all do
-      I18n.locale = @locale
-    end
-
-    [
-      [ 'simple phenomenon',       :en, [ nil,    nil,          'mist' ],    'mist' ],
-      [ 'simple phenomenon',       :it, [ nil,    nil,          'mist' ],    'foschia' ],
-      [ 'descriptor + phenomenon', :en, [ nil,    'patches of', 'fog' ],     'patches of fog' ],
-      [ 'thunderstorm and rain',   :en, [ nil,    'thunderstorm and', 'rain' ],  'thunderstorm and rain' ],
-      [ 'modifier + phenomenon',   :en, ['heavy', nil,          'drizzle' ], 'heavy drizzle' ],
-      [ 'modifier + descriptor + phenomenon', :en, ['heavy', 'freezing', 'drizzle' ], 'heavy freezing drizzle' ],
-    ].each do | docstring, locale, ( modifier, descriptor, phenomenon ), expected |
-      example docstring + " (#{locale})" do
-        I18n.locale = locale
-        expect(Metar::WeatherPhenomenon.new( phenomenon, modifier, descriptor ).to_s).to eq(expected)
-      end
-    end
-  end
-end
-