metar-parser 1.2.0 → 1.2.1

data/spec/{unit/raw_spec.rb → raw_spec.rb}

@@ -76,8 +76,8 @@ describe Metar::Raw::Metar do
       let(:raw_metar) { "OPPS 3123Z 23006KT 4000 HZ SCT040 SCT100 17/12 Q1011" }
 
       it "throws an error" do
-        expect { subject.time }.
-          to raise_error(RuntimeError, /6 digit/)
+        expect { subject.time }
+          .to raise_error(RuntimeError, /6 digit/)
       end
     end
 
@@ -85,8 +85,8 @@ describe Metar::Raw::Metar do
       let(:raw_metar) { "OPPS 332359Z 23006KT 4000 HZ SCT040 SCT100 17/12 Q1011" }
 
       it "throws an error" do
-        expect { subject.time }.
-          to raise_error(RuntimeError, /at most 31/)
+        expect { subject.time }
+          .to raise_error(RuntimeError, /at most 31/)
       end
     end
 
@@ -94,8 +94,8 @@ describe Metar::Raw::Metar do
       let(:raw_metar) { "OPPS 002359Z 23006KT 4000 HZ SCT040 SCT100 17/12 Q1011" }
 
       it "throws an error" do
-        expect { subject.time }.
-          to raise_error(RuntimeError, /greater than 0/)
+        expect { subject.time }
+          .to raise_error(RuntimeError, /greater than 0/)
       end
     end
   end
@@ -157,6 +157,10 @@ describe Metar::Raw::Noaa do
   end
 
   context '.fetch' do
+    before do
+      allow(ftp).to receive(:retrbinary).and_yield("chunk 1\n").and_yield("chunk 2\n")
+    end
+
     it 'uses the connection' do
       Metar::Raw::Noaa.fetch('the_cccc')
 
@@ -170,51 +174,40 @@ describe Metar::Raw::Noaa do
     end
 
     it 'returns the data' do
-      def ftp.retrbinary(*args, &block)
-        block.call "chunk 1\n"
-        block.call "chunk 2\n"
-      end
       raw = Metar::Raw::Noaa.fetch('the_cccc')
 
       expect(raw).to eq("chunk 1\nchunk 2\n")
     end
 
-    it 'retries retrieval once' do
-      def ftp.attempt
-        @attempt
-      end
-      def ftp.attempt=(a)
-        @attempt = a
-      end
-      ftp.attempt = 0
-      def ftp.retrbinary(*args, &block)
-        self.attempt = self.attempt + 1
-        raise Net::FTPTempError if self.attempt == 1
-        block.call "chunk 1\n"
-        block.call "chunk 2\n"
+    context 'if retrieval fails once' do
+      before do
+        @attempt = 0
+
+        allow(ftp).to receive(:retrbinary) do |_args, &block|
+          @attempt += 1
+          raise Net::FTPTempError if @attempt == 1
+          block.call "chunk 1\n"
+          block.call "chunk 2\n"
+        end
       end
- 
-      raw = Metar::Raw::Noaa.fetch('the_cccc')
 
-      expect(raw).to eq("chunk 1\nchunk 2\n")
-    end
+      it 'retries' do
+        raw = Metar::Raw::Noaa.fetch('the_cccc')
 
-    it 'fails with an error, if retrieval fails twice' do
-      def ftp.attempt
-        @attempt
-      end
-      def ftp.attempt=(a)
-        @attempt = a
+        expect(raw).to eq("chunk 1\nchunk 2\n")
       end
-      ftp.attempt = 0
-      def ftp.retrbinary(*args, &block)
-        self.attempt = self.attempt + 1
-        raise Net::FTPTempError
+    end
+
+    context 'if retrieval fails twice' do
+      before do
+        allow(ftp).to receive(:retrbinary).and_raise(Net::FTPTempError)
       end
 
-      expect do
-        Metar::Raw::Noaa.fetch('the_cccc')
-      end.to raise_error(RuntimeError, /failed 2 times/)
+      it 'fails with an error' do
+        expect do
+          Metar::Raw::Noaa.fetch('the_cccc')
+        end.to raise_error(RuntimeError, /failed 2 times/)
+      end
     end
   end
 

data/spec/{unit/remark_spec.rb → remark_spec.rb}

@@ -1,5 +1,5 @@
 require "spec_helper"
- 
+
 describe Metar::Remark do
   context '.parse' do
     it 'delegate to subclasses' do
@@ -21,22 +21,18 @@ describe Metar::Remark do
           expect(Metar::Remark.parse(raw)).to be_temperature_extreme(*expected)
         end
       end
-
     end
 
     context '24-hour maximum and minimum' do
-
       it 'returns minimum and maximum' do
         max, min = Metar::Remark.parse('400461006')
 
         expect(max).to be_temperature_extreme(:maximum,  4.6)
         expect(min).to be_temperature_extreme(:minimum, -0.6)
       end
-
     end
 
     context 'pressure tendency' do
-
       it 'steady_then_decreasing' do
         pt = Metar::Remark.parse('58033')
 
@@ -44,31 +40,26 @@ describe Metar::Remark do
         expect(pt.character).to eq(:steady_then_decreasing)
         expect(pt.value).to eq(3.3)
       end
-
     end
 
     context '3-hour and 6-hour precipitation' do
-
       it '60009' do
         pr = Metar::Remark.parse('60009')
-        
+
         expect(pr).to be_a(Metar::Precipitation)
         expect(pr.period).to eq(3)
         expect(pr.amount.value).to eq(0.002286)
       end
-
     end
 
     context '24-hour precipitation' do
-
       it '70015' do
         pr = Metar::Remark.parse('70015')
-        
+
         expect(pr).to be_a(Metar::Precipitation)
         expect(pr.period).to eq(24)
         expect(pr.amount.value).to eq(0.003810)
       end
-
     end
 
     context 'automated station' do
@@ -84,22 +75,18 @@ describe Metar::Remark do
           expect(aut.type).to eq(expected[1])
         end
       end
-
     end
 
     context 'sea-level pressure' do
-
       it 'SLP125' do
         slp = Metar::Remark.parse('SLP125')
 
         expect(slp).to be_a(Metar::SeaLevelPressure)
         expect(slp.pressure.value).to eq(0.0125)
       end
-
     end
 
     context 'hourly temperature and dew point' do
-
       it 'T00640036' do
         htm = Metar::Remark.parse('T00641036')
 
@@ -107,17 +94,12 @@ describe Metar::Remark do
         expect(htm.temperature.value).to eq(6.4)
         expect(htm.dew_point.value).to eq(-3.6)
       end
-
     end
-
   end
-
 end
 
 describe Metar::Lightning do
-
   context '.parse_chunks' do
-
     [
       ['direction',                        'LTG SE',            [:default,      nil, ['SE']]],
       ['distance direction',               'LTG DSNT SE',       [:default, 16093.44, ['SE']]],
@@ -151,7 +133,7 @@ describe Metar::Lightning do
     it 'fails if the first chunk is not LTGnnn' do
       expect do
         Metar::Lightning.parse_chunks(['FOO'])
-      end.                        to        raise_error(RuntimeError, /not lightning/)
+      end.to raise_error(RuntimeError, /not lightning/)
     end
 
     it "doesn't not fail if all chunks are parsed" do
@@ -161,8 +143,5 @@ describe Metar::Lightning do
 
       expect(chunks).to eq([])
     end
-
   end
-
 end
-

data/spec/{unit/report_spec.rb → report_spec.rb}

@@ -6,10 +6,10 @@ describe Metar::Report do
     let(:parser) do
       double(
         Metar::Parser,
-        :station_code => station_code,
-        :date         => Date.parse(metar_date),
-        :time         => Time.parse(metar_datetime),
-        :observer     => :real
+        station_code: station_code,
+        date:         Date.parse(metar_date),
+        time:         Time.parse(metar_datetime),
+        observer:     :real
       )
     end
     let(:station_code) { "SSSS" }
@@ -17,7 +17,9 @@ describe Metar::Report do
     let(:metar_date) { "2008/05/06" }
     let(:metar_time) { "10:56" }
     let(:metar_datetime) { "#{metar_date} #{metar_time}" }
-    let(:station) { double(Metar::Station, :name => 'Airport 1', :country => 'Wwwwww') }
+    let(:station) do
+      double(Metar::Station, name: 'Airport 1', country: 'Wwwwww')
+    end
 
     before do
       allow(Metar::Station).to receive(:find_by_cccc).with(station_code) { station }
@@ -82,7 +84,7 @@ describe Metar::Report do
           :temperature,
           :dew_point,
           :sea_level_pressure,
-        ].each do | attribute |
+        ].each do |attribute|
           example attribute do
             allow(parser).to receive(attribute) { attribute.to_s }
 
@@ -91,7 +93,7 @@ describe Metar::Report do
         end
 
         context "#sky_summary" do
-          let(:conditions1) { double(:to_summary => "skies1") }
+          let(:conditions1) { double(to_summary: "skies1") }
 
           it "returns the summary" do
             allow(parser).to receive(:sky_conditions) { [conditions1] }
@@ -107,7 +109,7 @@ describe Metar::Report do
 
           it "uses the last, if there is more than 1" do
             @skies1 = double("sky_conditions1")
-            @skies2 = double("sky_conditions2", :to_summary => "skies2")
+            @skies2 = double("sky_conditions2", to_summary: "skies2")
             allow(parser).to receive(:sky_conditions) { [@skies1, @skies2] }
 
             expect(subject.sky_summary).to eq("skies2")
@@ -117,28 +119,28 @@ describe Metar::Report do
 
       context "joined" do
         it "#runway_visible_range" do
-          @rvr1 = double("rvr1", :to_s => "rvr1")
-          @rvr2 = double("rvr2", :to_s => "rvr2")
+          @rvr1 = double("rvr1", to_s: "rvr1")
+          @rvr2 = double("rvr2", to_s: "rvr2")
           allow(parser).to receive(:runway_visible_range) { [@rvr1, @rvr2] }
 
           expect(subject.runway_visible_range).to eq("rvr1, rvr2")
         end
 
         it "#present_weather" do
-          allow(parser).to receive(:present_weather) { ["pw1", "pw2"] }
+          allow(parser).to receive(:present_weather) { %w(pw1 pw2) }
 
           expect(subject.present_weather).to eq("pw1, pw2")
         end
 
         it "#remarks" do
-          allow(parser).to receive(:remarks) { ["rem1", "rem2"] }
+          allow(parser).to receive(:remarks) { %w(rem1 rem2) }
 
           expect(subject.remarks).to eq("rem1, rem2")
         end
 
         it '#sky_conditions' do
-          sky1 = double('sky1', :to_s => 'sky1')
-          sky2 = double('sky2', :to_s => 'sky2')
+          sky1 = double('sky1', to_s: 'sky1')
+          sky2 = double('sky2', to_s: 'sky2')
           allow(parser).to receive(:sky_conditions) { [sky1, sky2] }
 
           expect(subject.sky_conditions).to eq("sky1, sky2")
@@ -147,8 +149,8 @@ describe Metar::Report do
     end
 
     context '#to_s' do
-      let(:sky1) { double('sky1', :to_summary => 'sky1') }
-      let(:sky2) { double('sky2', :to_summary => 'sky2') }
+      let(:sky1) { double('sky1', to_summary: 'sky1') }
+      let(:sky2) { double('sky2', to_summary: 'sky2') }
 
       before do
         allow(parser).to receive(:wind) { "wind" }

data/spec/runway_visible_range_spec.rb

@@ -0,0 +1,81 @@
+# encoding: utf-8
+require "spec_helper"
+
+RSpec::Matchers.define :be_runway_visible_range do |designator, visibility1, visibility2, tendency|
+  match do |rvr|
+    if rvr.nil?                && designator.nil?
+      true
+    elsif rvr.nil?             != designator.nil?
+      false
+    elsif rvr.visibility1.nil? != visibility1.nil?
+      false
+    elsif rvr.visibility2.nil? != visibility2.nil?
+      false
+    elsif rvr.tendency.nil? != tendency.nil?
+      false
+    elsif ! visibility1.nil? &&
+          ((rvr.visibility1.distance.value - visibility1[0]).abs > 0.01 ||
+            rvr.visibility1.comparator != visibility1[ 2 ])
+      false
+    elsif ! visibility2.nil? &&
+          ((rvr.visibility2.distance.value - visibility2[0]).abs > 0.02 ||
+            rvr.visibility2.comparator != visibility2[2])
+      false
+    elsif tendency != rvr.tendency
+      false
+    else
+      true
+    end
+  end
+end
+
+describe Metar::RunwayVisibleRange do
+  context '.parse' do
+    [
+      ['understands R + nn + / + nnnn',     'R12/3400',        ['12',  [3400.00, nil, nil],        nil,                nil]],
+      ['understands runway positions: RLC', 'R12L/3400',       ['12L', [3400.00, nil, nil],        nil,                nil]],
+      ['understands comparators: PM',       'R12/P3400',       ['12',  [3400.00, nil, :more_than], nil,                nil]],
+      ['understands tendencies: NUD',       'R12/3400U',       ['12',  [3400.00, nil, nil],        nil,                :improving]],
+      ['understands feet',                  'R12/3400FT',      ['12',  [1036.32, nil, nil],        nil,                nil]],
+      ['understands second visibilities (m)',  'R26/0750V1200U',  ['12', [ 750.0,  nil, nil],     [1200.0, nil, nil], :improving]],
+      ['understands second visibilities (ft)', 'R12/3400V1800FT', ['12', [1036.32, nil, nil],     [548.64, nil, nil], nil]],
+      ['returns nil for nil',               nil,               [nil,   nil,                        nil,                nil]],
+    ].each do |docstring, raw, expected|
+      example docstring do
+        expect(Metar::RunwayVisibleRange.parse(raw)).to be_runway_visible_range(*expected)
+      end
+    end
+  end
+
+  context '#to_s' do
+    before :all do
+      @locale = I18n.locale
+      I18n.locale = :it
+    end
+
+    after :all do
+      I18n.locale = @locale
+    end
+
+    [
+      ['v1',        :en, [[3400.00, nil, nil], nil,                 nil], 'runway 14: 3400m'],
+      ['v1 and v2',       :en,  [[3400.00, nil, nil], [1900.00, nil, nil], nil ], 'runway 14: from 3400m to 1900m'],
+      ['v1 and tendency', :en, [[3400.00, nil, nil], nil,                 :improving ], 'runway 14: 3400m improving'],
+    ].each do |docstring, locale, (visibility1, visibility2, tendency), expected|
+      d1 = Metar::Distance.new(visibility1[0])
+      v1 = Metar::Visibility.new(d1, visibility1[1], visibility1[2])
+      v2 =
+        if ! visibility2.nil?
+          d2 = Metar::Distance.new(visibility2[0])
+          Metar::Visibility.new(d2, visibility2[1], visibility2[2])
+        else
+          nil
+        end
+
+      example docstring + " (#{locale})" do
+        I18n.locale = locale
+        expect(Metar::RunwayVisibleRange.new('14', v1, v2, tendency).to_s).to eq(expected)
+      end
+    end
+  end
+end

data/spec/{unit/sky_condition_spec.rb → sky_condition_spec.rb}

@@ -68,4 +68,3 @@ describe Metar::SkyCondition do
     end
   end
 end
-

data/spec/spec_helper.rb

@@ -9,7 +9,7 @@ if RUBY_VERSION > '1.9'
   end
 end
 
-require File.expand_path( File.dirname(__FILE__) + '/../lib/metar' )
+require File.expand_path(File.dirname(__FILE__) + '/../lib/metar')
 
 RSpec::Matchers.define :be_temperature_extreme do |extreme, value|
   match do |remark|

data/spec/speed_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe Metar::Speed do
+  context '.parse' do
+    it 'returns nil for nil' do
+      speed = Metar::Speed.parse(nil)
+
+      expect(speed).to be_nil
+    end
+
+    it 'parses knots' do
+      speed = Metar::Speed.parse('5KT')
+
+      expect(speed).to be_a(Metar::Speed)
+      expect(speed.value).to be_within(0.01).of(2.57)
+    end
+
+    it 'parses meters per second' do
+      speed = Metar::Speed.parse('7MPS')
+
+      expect(speed).to be_a(Metar::Speed)
+      expect(speed.value).to be_within(0.01).of(7.00)
+    end
+
+    it 'parses kilometers per hour' do
+      speed = Metar::Speed.parse('14KMH')
+
+      expect(speed).to be_a(Metar::Speed)
+      expect(speed.value).to be_within(0.01).of(3.89)
+    end
+
+    it 'trates straight numbers as kilomters per hour' do
+      speed = Metar::Speed.parse('14')
+
+      expect(speed).to be_a(Metar::Speed)
+      expect(speed.value).to be_within(0.01).of(3.89)
+    end
+
+    it 'returns nil for other strings' do
+      speed = Metar::Speed.parse('')
+
+      expect(speed).to be_nil
+    end
+  end
+end

data/spec/{unit/station_spec.rb → station_spec.rb}

@@ -4,10 +4,10 @@ require "spec_helper"
 require "stringio"
 
 RSpec::Matchers.define :have_attribute do |attribute|
-  match do | object |
-    if ! object.respond_to?( attribute )
+  match do |object|
+    if !object.respond_to?(attribute)
       false
-    elsif object.method( attribute ).arity != 0
+    elsif object.method(attribute).arity != 0
       false
     else
       true
@@ -16,11 +16,10 @@ RSpec::Matchers.define :have_attribute do |attribute|
 end
 
 describe Metar::Station do
-  let(:file) { double(File) }
-
   context "using structures" do
     before do
-      allow(Metar::Station).to receive(:open).with(Metar::Station::NOAA_STATION_LIST_URL) { nsd_file }
+      allow(Metar::Station).to receive(:open)
+        .with(Metar::Station::NOAA_STATION_LIST_URL) { nsd_file }
     end
 
     context ".countries" do
@@ -69,18 +68,36 @@ describe Metar::Station do
       end
     end
 
+    ##
+    # NOAA Station list fields:
+    #
+    # 0    1  2   3          45     6 7      8       9      10      11  12  13
+    # PPPP;00;000;Airport P1;;Ppppp;1;11-03S;055-24E;11-03S;055-24E;000;000;P\r
+    #
+    # 0 - CCCC
+    # 1 - ?
+    # 2 - ?
+    # 3 - name of station
+    # 4 - state
+    # 5 - country
+    # 6 - ?
+    # 7 - latitude1
+    # 8 - longitude1
+    # 9 - latitude2
+    # 10 - longitude2
+    # 11 - ?
+    # 12 - ?
+    # 13 - ?
+    #
     def nsd_file
-#0    1  2   3    4     5       6 7        8         9        10        11  12  13
-#CCCC;??;???;name;state;country;?;latitude;longitude;latitude;longitude;???;???;?
-      nsd_text =<<EOT
-PPPP;00;000;Airport P1;;Ppppp;1;11-03S;055-24E;11-03S;055-24E;000;000;P
-AAAA;00;000;Airport A1;;Aaaaa;1;11-03S;055-24E;11-03S;055-24E;000;000;P
-AAAB;00;000;Airport A2;;Aaaaa;1;11-03S;055-24E;11-03S;055-24E;000;000;P
-BBBA;00;000;Airport B1;;Bbbbb;1;11-03S;055-24E;11-03S;055-24E;000;000;P
-EOT
-      StringIO.new( nsd_text )
+      nsd_text = <<-EOT.gsub(/^\s{8}/, "")
+        PPPP;00;000;Airport P1;;Ppppp;1;11-03S;055-24E;11-03S;055-24E;000;000;P\r
+        AAAA;00;000;Airport A1;;Aaaaa;1;11-03S;055-24E;11-03S;055-24E;000;000;P\r
+        AAAB;00;000;Airport A2;;Aaaaa;1;11-03S;055-24E;11-03S;055-24E;000;000;P\r
+        BBBA;00;000;Airport B1;;Bbbbb;1;11-03S;055-24E;11-03S;055-24E;000;000;P\r
+      EOT
+      StringIO.new(nsd_text)
     end
-
   end
 
   context ".to_longitude" do
@@ -103,58 +120,72 @@ EOT
     end
   end
 
-  def noaa_data
+  let(:cccc) { "DDDD" }
+  let(:name) { "Station name" }
+  let(:state) { "State" }
+  let(:country) { "Country" }
+  let(:noaa_raw) do
+    cccc +
+      ";00;000;" +
+      name + ";" +
+      state + ";" +
+      country + ";1;11-03S;055-24E;11-03S;055-24E;000;000;P"
+  end
+  let(:noaa_data) do
     {
-      :cccc      => "DDDD",
-      :name      => "Station name",
-      :state     => "State",
-      :country   => "Country",
-      :longitude => "055-24E",
-      :latitude  => "11-03S",
-      :raw       => "DDDD;00;000;Station name;State;Country;1;11-03S;055-24E;11-03S;055-24E;000;000;P",
+      cccc:      cccc,
+      name:      name,
+      state:     state,
+      country:   country,
+      longitude: "055-24E",
+      latitude:  "11-03S",
+      raw:       noaa_raw,
     }
   end
 
   context "attributes" do
-     subject { Metar::Station.new("DDDD", noaa_data) }
-     it { should have_attribute(:cccc)     }
-     it { should have_attribute(:code)     }
-     it { should have_attribute(:name)     }
-     it { should have_attribute(:state)    }
-     it { should have_attribute(:country)  }
-     it { should have_attribute(:longitude) }
-     it { should have_attribute(:latitude) }
-     it { should have_attribute(:raw)      }
+    subject { Metar::Station.new("DDDD", noaa_data) }
+    it { should have_attribute(:cccc)     }
+    it { should have_attribute(:code)     }
+    it { should have_attribute(:name)     }
+    it { should have_attribute(:state)    }
+    it { should have_attribute(:country)  }
+    it { should have_attribute(:longitude) }
+    it { should have_attribute(:latitude) }
+    it { should have_attribute(:raw)      }
   end
-  
+
   context "initialization" do
-     it "should fail if cccc is missing" do
-       expect do
-         Metar::Station.new( nil, {} )
-       end.to raise_error(RuntimeError, /must not be nil/)      
-     end
-  
-     it "should fail if cccc is empty" do
-       expect do
-         Metar::Station.new("", {})
-       end.to raise_error( RuntimeError, /must not be empty/)      
-     end
-   
+    it "should fail if cccc is missing" do
+      expect do
+        Metar::Station.new(nil, {})
+      end.to raise_error(RuntimeError, /must not be nil/)
+    end
+
+    it "should fail if cccc is empty" do
+      expect do
+        Metar::Station.new("", {})
+      end.to raise_error(RuntimeError, /must not be empty/)
+    end
+
     context "with noaa data" do
       subject { Metar::Station.new("DDDD", noaa_data) }
 
-      specify { expect(subject.cccc).to eq("DDDD") }
-      specify { expect(subject.name).to eq("Station name") }
-      specify { expect(subject.state).to eq("State") }
-      specify { expect(subject.country).to eq("Country") }
+      specify { expect(subject.cccc).to eq(cccc) }
+      specify { expect(subject.name).to eq(name) }
+      specify { expect(subject.state).to eq(state) }
+      specify { expect(subject.country).to eq(country) }
       specify { expect(subject.longitude).to eq(55.4) }
       specify { expect(subject.latitude).to eq(-11.05) }
-      specify { expect(subject.raw).to eq("DDDD;00;000;Station name;State;Country;1;11-03S;055-24E;11-03S;055-24E;000;000;P") }
+      specify { expect(subject.raw).to eq(noaa_raw) }
     end
   end
 
   context "object navigation" do
-    let(:raw) { double(Metar::Raw, :metar => "PAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910 RMK AO2 P0000", :time => "2010/02/06 16:10") }
+    let(:metar) do
+      "PAIL 061610Z 24006KT 1 3/4SM -SN BKN016 OVC030 M17/M20 A2910"
+    end
+    let(:raw) { double(Metar::Raw, metar: metar, time: "2010/02/06 16:10") }
 
     before do
       # TODO: hack - once parser returns station this can be removed