mercury_banking 0.5.38 → 0.7.0

data/lib/mercury_banking/cli/reports.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MercuryBanking
   module CLI
     # Module for report-related commands
@@ -9,11 +11,11 @@ module MercuryBanking
           no_commands do
             # The balance_sheet method has been moved to the Financials module
           end
-          
+
           desc 'statement ACCOUNT_NAME', 'Generate a statement for a specific account and period'
           method_option :start, type: :string, default: '2020-01-01', desc: 'Start date for statement (YYYY-MM-DD)'
           method_option :end, type: :string, desc: 'End date for statement (YYYY-MM-DD)'
-          method_option :format, type: :string, default: 'text', enum: ['text', 'json', 'csv'], desc: 'Output format'
+          method_option :format, type: :string, default: 'text', enum: %w[text json csv], desc: 'Output format'
           method_option :save, type: :string, desc: 'Save statement to specified file'
           method_option :debug, type: :boolean, default: false, desc: 'Show debug information about balance calculation'
           def statement(account_name)
@@ -22,117 +24,119 @@ module MercuryBanking
               end_date = options[:end]
               format = options[:format]
               debug = options[:debug]
-              
+
               # Find the account by name
               accounts = client.accounts
               account = accounts.find { |a| a["name"] == account_name }
-              
+
               unless account
                 puts "Error: Account '#{account_name}' not found. Available accounts:"
                 accounts.each { |a| puts "- #{a['name']}" }
                 return
               end
-              
+
               # Get transactions for the account
               transactions = client.get_transactions(account["id"], start_date)
-              
+
               # Filter by end date if specified
               if end_date
                 end_date_obj = Date.parse(end_date)
                 transactions = transactions.select do |t|
-                  transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                  transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
                   transaction_date <= end_date_obj
                 end
               end
-              
+
               if transactions.empty?
                 puts "No transactions found for the specified period."
                 return
               end
-              
+
               # Sort transactions by date
               transactions = transactions.sort_by do |t|
                 date = t["postedAt"] || t["createdAt"]
                 Time.parse(date)
               end
-              
+
               # Calculate opening and closing balances
               current_balance = account["currentBalance"]
               closing_balance = current_balance
-              
-              if debug
-                puts "Debug: Current balance from Mercury API: $#{format("%.2f", current_balance)}"
-              end
-              
+
+              puts "Debug: Current balance from Mercury API: $#{format('%.2f', current_balance)}" if debug
+
               # Subtract all transactions that occurred after the end date
               if end_date
                 end_date_obj = Date.parse(end_date)
                 after_end_date_transactions = transactions.select do |t|
-                  transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                  transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
                   transaction_date > end_date_obj
                 end
-                
+
                 if debug && after_end_date_transactions.any?
                   puts "Debug: Transactions after end date (#{end_date}):"
                   after_end_date_transactions.each do |t|
                     date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
-                    puts "  #{date}: $#{format("%.2f", t["amount"])}"
+                    puts "  #{date}: $#{format('%.2f', t['amount'])}"
                   end
                 end
-                
+
                 after_end_date_sum = after_end_date_transactions.sum { |t| t["amount"] }
                 closing_balance = current_balance - after_end_date_sum
-                
-                if debug
-                  puts "Debug: Sum of transactions after end date: $#{format("%.2f", after_end_date_sum)}"
-                  puts "Debug: Closing balance at end date: $#{format("%.2f", closing_balance)}"
-                end
-              else
+
                 if debug
-                  puts "Debug: No end date specified, closing balance equals current balance"
+                  puts "Debug: Sum of transactions after end date: $#{format('%.2f', after_end_date_sum)}"
+                  puts "Debug: Closing balance at end date: $#{format('%.2f', closing_balance)}"
                 end
+              elsif debug
+                puts "Debug: No end date specified, closing balance equals current balance"
               end
-              
+
               # Calculate opening balance by subtracting all transactions in the period
               opening_balance = closing_balance
-              
-              if debug
-                puts "Debug: Transactions in the statement period:"
-              end
-              
+
+              puts "Debug: Transactions in the statement period:" if debug
+
               transactions_sum = 0
               transactions.each do |t|
                 amount = t["amount"]
                 transactions_sum += amount
-                
+
                 if debug
                   date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
-                  puts "  #{date}: $#{format("%.2f", amount)}"
+                  puts "  #{date}: $#{format('%.2f', amount)}"
                 end
-                
+
                 opening_balance -= amount
               end
-              
+
               if debug
-                puts "Debug: Sum of transactions in period: $#{format("%.2f", transactions_sum)}"
-                puts "Debug: Opening balance calculation: $#{format("%.2f", closing_balance)} - $#{format("%.2f", transactions_sum)} = $#{format("%.2f", opening_balance)}"
+                puts "Debug: Sum of transactions in period: $#{format('%.2f', transactions_sum)}"
+                puts "Debug: Opening balance calculation: $#{format('%.2f',
+                                                                    closing_balance)} - $#{format('%.2f',
+                                                                                                  transactions_sum)} = $#{format(
+                                                                                                    '%.2f', opening_balance
+                                                                                                  )}"
               end
-              
+
               # Generate statement based on format
               case format
               when 'text'
-                generate_text_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, options[:save], debug)
+                generate_text_statement(account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                        options[:save], debug)
               when 'json'
-                generate_json_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, options[:save])
+                generate_json_statement(account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                        options[:save])
               when 'csv'
-                generate_csv_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, options[:save])
+                generate_csv_statement(account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                       options[:save])
               end
             end
           end
-          
+
           private
-          
-          def generate_text_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, save_path, debug = false)
+
+          def generate_text_statement(account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                      save_path, debug = false)
             # Create statement header
             statement = []
             statement << "Mercury Banking Statement"
@@ -140,13 +144,13 @@ module MercuryBanking
             statement << "Period: #{start_date} to #{end_date || 'present'}"
             statement << "Generated on: #{Time.now.strftime('%Y-%m-%d %H:%M:%S')}"
             statement << ""
-            statement << "Opening Balance: $#{format("%.2f", opening_balance)}"
+            statement << "Opening Balance: $#{format('%.2f', opening_balance)}"
             statement << ""
             statement << "Transactions:"
-            statement << "-" * 80
-            statement << "Date".ljust(12) + "Description".ljust(40) + "Amount".ljust(15) + "Balance"
-            statement << "-" * 80
-            
+            statement << ("-" * 80)
+            statement << ("#{'Date'.ljust(12)}#{'Description'.ljust(40)}#{'Amount'.ljust(15)}Balance")
+            statement << ("-" * 80)
+
             # Add transactions
             running_balance = opening_balance
             transactions.each do |t|
@@ -155,13 +159,15 @@ module MercuryBanking
               description = description.length > 37 ? "#{description[0..34]}..." : description
               amount = t["amount"]
               running_balance += amount
-              
-              statement << date.ljust(12) + description.ljust(40) + format("$%.2f", amount).rjust(15) + format("$%.2f", running_balance).rjust(15)
+
+              statement << (date.ljust(12) + description.ljust(40) + format("$%.2f",
+                                                                            amount).rjust(15) + format("$%.2f",
+                                                                                                       running_balance).rjust(15))
             end
-            
-            statement << "-" * 80
-            statement << "Closing Balance: $#{format("%.2f", closing_balance)}"
-            
+
+            statement << ("-" * 80)
+            statement << "Closing Balance: $#{format('%.2f', closing_balance)}"
+
             if debug
               statement << ""
               statement << "Debug Information:"
@@ -169,7 +175,7 @@ module MercuryBanking
               statement << "- Closing balance is the current balance adjusted for any transactions after the end date"
               statement << "- Running balance starts with the opening balance and adds each transaction amount"
             end
-            
+
             # Output or save
             if save_path
               File.write(save_path, statement.join("\n"))
@@ -178,8 +184,9 @@ module MercuryBanking
               puts statement.join("\n")
             end
           end
-          
-          def generate_json_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, save_path)
+
+          def generate_json_statement(account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                      save_path)
             # Format transactions
             formatted_transactions = transactions.map do |t|
               {
@@ -189,7 +196,7 @@ module MercuryBanking
                 status: t["status"]
               }
             end
-            
+
             # Create statement object
             statement = {
               account: {
@@ -208,10 +215,10 @@ module MercuryBanking
               transactions: formatted_transactions,
               generated_at: Time.now.iso8601
             }
-            
+
             # Output or save
             json_output = JSON.pretty_generate(statement)
-            
+
             if save_path
               File.write(save_path, json_output)
               puts "Statement saved to #{save_path}"
@@ -219,19 +226,20 @@ module MercuryBanking
               puts json_output
             end
           end
-          
-          def generate_csv_statement(account, transactions, opening_balance, closing_balance, start_date, end_date, save_path)
+
+          def generate_csv_statement(_account, transactions, opening_balance, closing_balance, start_date, end_date,
+                                     save_path)
             require 'csv'
-            
+
             # Prepare CSV data
             csv_data = []
-            
+
             # Add header row
-            csv_data << ["Date", "Description", "Amount", "Balance", "Status"]
-            
+            csv_data << %w[Date Description Amount Balance Status]
+
             # Add opening balance row
             csv_data << [start_date, "Opening Balance", "", opening_balance, ""]
-            
+
             # Add transactions
             running_balance = opening_balance
             transactions.each do |t|
@@ -239,18 +247,18 @@ module MercuryBanking
               description = t["bankDescription"] || t["externalMemo"] || "Unknown transaction"
               amount = t["amount"]
               running_balance += amount
-              
+
               csv_data << [date, description, amount, running_balance, t["status"]]
             end
-            
+
             # Add closing balance row
             csv_data << [end_date || Time.now.strftime("%Y-%m-%d"), "Closing Balance", "", closing_balance, ""]
-            
+
             # Output or save
             csv_output = CSV.generate do |csv|
               csv_data.each { |row| csv << row }
             end
-            
+
             if save_path
               File.write(save_path, csv_output)
               puts "Statement saved to #{save_path}"
@@ -262,4 +270,4 @@ module MercuryBanking
       end
     end
   end
-end 
+end

data/lib/mercury_banking/cli/transactions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MercuryBanking
   module CLI
     # Module for transaction-related commands
@@ -6,89 +8,91 @@ module MercuryBanking
       def self.included(base)
         base.class_eval do
           include MercuryBanking::Formatters::ExportFormatter
-          
+
           desc 'transactions_download', 'Download all Mercury transactions as CSV files'
           method_option :output_dir, type: :string, default: 'transactions', desc: 'Directory to save transaction files'
-          method_option :start_date, type: :string, default: '2020-01-01', desc: 'Start date for transactions (YYYY-MM-DD)'
+          method_option :start_date, type: :string, default: '2020-01-01',
+                                     desc: 'Start date for transactions (YYYY-MM-DD)'
           method_option :end_date, type: :string, desc: 'End date for transactions (YYYY-MM-DD)'
-          method_option :format, type: :string, default: 'csv', enum: ['csv', 'beancount', 'ledger', 'all'], desc: 'Output format (csv, beancount, ledger, or all)'
+          method_option :format, type: :string, default: 'csv', enum: %w[csv beancount ledger all],
+                                 desc: 'Output format (csv, beancount, ledger, or all)'
           method_option :verbose, type: :boolean, default: false, desc: 'Show detailed debug information'
           def transactions_download
             with_api_client do |client|
               # Create output directory if it doesn't exist
               output_dir = options[:output_dir]
               FileUtils.mkdir_p(output_dir)
-              
+
               # Get all accounts
               accounts = client.accounts
-              
+
               # Get start and end dates
               start_date = options[:start_date]
               end_date = options[:end_date]
-              
+
               # Get format
               format = options[:format] || 'all'
-              
+
               # Get verbose option
               verbose = options[:verbose]
-              
+
               # For each account, get transactions and save to file
               accounts.each do |account|
                 account_id = account["id"]
                 account_name = account["name"]
                 account_number = account["accountNumber"]
-                
+
                 puts "Fetching transactions for #{account_name} (#{account_id})..."
-                
+
                 # Get all transactions for this account
                 transactions = client.get_transactions(account_id, start_date)
-                
+
                 # Add account information to each transaction
                 transactions.each do |transaction|
                   transaction["accountName"] = account_name
                   transaction["accountId"] = account_id
                   transaction["accountNumber"] = account_number
                 end
-                
+
                 # Filter by end date if specified
                 if end_date
                   end_date_obj = Date.parse(end_date)
                   transactions = transactions.select do |t|
-                    transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                    transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
                     transaction_date <= end_date_obj
                   end
                 end
-                
+
                 if transactions.empty?
                   puts "No transactions found for #{account_name}."
                   next
                 end
-                
+
                 # Group transactions by month
                 transactions_by_month = {}
-                
+
                 transactions.each do |t|
                   # Get the month from the transaction date
-                  date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                  date = Date.parse(t["postedAt"] || t["createdAt"])
                   month_key = "#{date.year}-#{date.month.to_s.rjust(2, '0')}"
-                  
+
                   # Initialize the month array if it doesn't exist
                   transactions_by_month[month_key] ||= []
-                  
+
                   # Add the transaction to the month array
                   transactions_by_month[month_key] << t
                 end
-                
+
                 # For each month, save transactions to file
                 transactions_by_month.each do |month, month_transactions|
                   # Use the full account number for the filename
                   account_number = account["accountNumber"]
-                  
+
                   # Create filenames for different formats
                   csv_filename = File.join(output_dir, "#{month}-Mercury-#{account_number}.csv")
                   beancount_filename = File.join(output_dir, "#{month}-Mercury-#{account_number}.beancount")
                   ledger_filename = File.join(output_dir, "#{month}-Mercury-#{account_number}.ledger")
-                  
+
                   # Export transactions in the requested format
                   case format
                   when 'csv'
@@ -103,20 +107,20 @@ module MercuryBanking
                   when 'all'
                     export_to_csv(month_transactions, csv_filename, [], verbose)
                     puts "Exported #{month_transactions.size} transactions to #{csv_filename}"
-                    
+
                     export_to_beancount(month_transactions, beancount_filename, [], verbose)
                     puts "Exported #{month_transactions.size} transactions to #{beancount_filename}"
-                    
+
                     export_to_ledger(month_transactions, ledger_filename, [], verbose)
                     puts "Exported #{month_transactions.size} transactions to #{ledger_filename}"
                   end
                 end
               end
-              
+
               puts "\nTransaction export complete. Files saved to #{output_dir}/ directory."
             end
           end
-          
+
           desc "transactions ACCOUNT_ID_OR_NUMBER", "List transactions for an account with their status"
           method_option :limit, type: :numeric, default: 10, desc: "Number of transactions to show"
           method_option :start, type: :string, desc: "Start date (YYYY-MM-DD)"
@@ -128,77 +132,75 @@ module MercuryBanking
             with_api_client do |client|
               # Find the account by ID or account number
               account = find_account(client, account_id_or_number)
-              
+
               if account.nil?
                 puts "Account not found: #{account_id_or_number}"
                 return
               end
-              
+
               account_id = account["id"]
-              
+
               # Get transactions with optional date filters
               start_date = options[:start]
               end_date = options[:end]
-              
-              puts "Fetching transactions for #{account["name"]}..."
+
+              puts "Fetching transactions for #{account['name']}..."
               transactions = client.get_transactions(account_id, start_date)
-              
+
               # Add account information to each transaction
               transactions.each do |transaction|
                 transaction["accountName"] = account["name"]
                 transaction["accountId"] = account["id"]
                 transaction["accountNumber"] = account["accountNumber"]
               end
-              
+
               # Filter by end date if specified
               if end_date
                 end_date_obj = Date.parse(end_date)
                 transactions = transactions.select do |t|
-                  transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                  transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
                   transaction_date <= end_date_obj
                 end
               end
-              
+
               # Filter by status if specified
-              if options[:status]
-                transactions = transactions.select { |t| t["status"] == options[:status] }
-              end
-              
+              transactions = transactions.select { |t| t["status"] == options[:status] } if options[:status]
+
               # Limit the number of transactions
               limit = options[:limit]
-              transactions = transactions.take(limit) if limit > 0
-              
+              transactions = transactions.take(limit) if limit.positive?
+
               # Export to CSV if requested
               if options[:csv]
                 export_to_csv(transactions, options[:csv])
                 puts "Exported #{transactions.size} transactions to #{options[:csv]}"
                 return
               end
-              
+
               # Output in JSON format if requested
               if options[:json]
                 puts JSON.pretty_generate(transactions)
                 return
               end
-              
+
               # Create a table for display
               table = Terminal::Table.new
-              table.title = "Transactions for #{account["name"]}"
-              table.headings = ['Date', 'Description', 'Amount', 'Status']
-              
+              table.title = "Transactions for #{account['name']}"
+              table.headings = %w[Date Description Amount Status]
+
               transactions.each do |t|
-                date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                date = Date.parse(t["postedAt"] || t["createdAt"])
                 description = t["bankDescription"] || t["externalMemo"] || "Unknown"
                 amount = t["amount"]
                 status = t["status"]
-                
+
                 table.add_row [date, description, "$#{amount}", status]
               end
-              
+
               puts table
             end
           end
-          
+
           # Helper methods that should not be exposed as commands
           no_commands do
             # Helper method to sort transactions chronologically
@@ -209,24 +211,20 @@ module MercuryBanking
                 Time.parse(timestamp)
               end
             end
-            
+
             # Helper method to find an account by ID or account number
             def find_account(client, account_id_or_number)
               accounts = client.accounts
-              
+
               # Try to find by ID first
               account = accounts.find { |a| a["id"] == account_id_or_number }
-              
+
               # If not found by ID, try by account number
-              if account.nil?
-                account = accounts.find { |a| a["accountNumber"] == account_id_or_number }
-              end
-              
+              account = accounts.find { |a| a["accountNumber"] == account_id_or_number } if account.nil?
+
               # If still not found, try by the last 4 digits of the account number
-              if account.nil?
-                account = accounts.find { |a| a["accountNumber"]&.end_with?(account_id_or_number) }
-              end
-              
+              account = accounts.find { |a| a["accountNumber"]&.end_with?(account_id_or_number) } if account.nil?
+
               account
             end
           end
@@ -234,4 +232,4 @@ module MercuryBanking
       end
     end
   end
-end 
+end