mercury_banking 0.5.38 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd83aeec4085d1c49fe77f7ca68fbc0b7c215dc37deafba3b36a20da0e7f46c4
-  data.tar.gz: 102b6b607353df20f4494c758935fe3f3517a2a4c95fca8440f9598b364d4f71
+  metadata.gz: 5c388af3fd079eacd9a2ba3fbc78a137ecb57352bd7deda55bcebbb372149126
+  data.tar.gz: 5665853a81cb64eb76128d70a60a3d830b732fa9ae9096ab2f6bae2d5ea858fd
 SHA512:
-  metadata.gz: 06a9d7eea59264a65f07ef4073189c390b8b0d025bdbeced8af797d06f67066e14cd704db814ad61ebaedd03c0682171a5604b2be295463751808b2ddc2057b5
-  data.tar.gz: b4898456ae09b4cceb0bf6a23c01fe7f860073fd76d069f1b70c0e5a4fc8c266ce52999351dfc319178730cea7779c9649076c43398604aaeadf9824ce9d8d49
+  metadata.gz: 8161c1c7afb40e33bb6dd29dbd843d01b969616be1ef4ed45983c2ea65dc2047344ca204e3043085351f8da86822e11ab015d56c4fa077400dd0982047186f75
+  data.tar.gz: 97f6fa41b322f94b53a4b69ee9255ceeb9083f3ec5934f35fc1b3952166aa9b0e16767a6460c688d0d7e4cd9aa6f43d65b1eeb3bac0eedb9f519c6679c11aab9

data/.rubocop.yml

@@ -1,6 +1,7 @@
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.0
   NewCops: enable
+  SuggestExtensions: false
 
 # Disable the rule that changes $? to $CHILD_STATUS
 Style/GlobalVars:
@@ -14,4 +15,47 @@ Style/SpecialGlobalVars:
 
 # Allow slightly longer methods since we've already done significant refactoring
 Metrics/MethodLength:
-  Max: 25  # Default is 10, we're increasing it to 25 
+  Max: 50  # Default is 10, we're increasing it to 50
+  Exclude:
+    - 'spec/**/*'
+
+# Disable enforcement of single quotes over double quotes
+Style/StringLiterals:
+  Enabled: false 
+
+# Increase line length limit
+Layout/LineLength:
+  Max: 150
+  Exclude:
+    - 'spec/**/*'
+
+# Increase block length limit for specs and complex methods
+Metrics/BlockLength:
+  Max: 100
+  Exclude:
+    - 'spec/**/*'
+
+# Increase class and module length limits
+Metrics/ClassLength:
+  Max: 150
+
+Metrics/ModuleLength:
+  Max: 500
+
+# Increase complexity limits
+Metrics/AbcSize:
+  Max: 75
+
+Metrics/CyclomaticComplexity:
+  Max: 30
+
+Metrics/PerceivedComplexity:
+  Max: 30
+
+# Increase parameter list limit
+Metrics/ParameterLists:
+  Max: 12
+
+# Allow optional boolean parameters
+Style/OptionalBooleanParameter:
+  Enabled: false 

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [0.7.0] - 2025-03-11
+### Changed
+- Simplified gem functionality to focus on core features
+- Removed balance sheet generation and only kept balance checking functionality
+- Removed all reconciliation functionality (reconcile, reconcile_all, reconciliation_status, unreconcile)
+- Added new `balancecheck` command that checks ledger balances against Mercury account balances
+- Reduced dependencies by removing unnecessary modules and imports
+
+## [0.6.0] - 2025-03-10
+### Changed
+- Major code refactoring to improve code quality and maintainability
+- Extracted helper methods into separate modules
+- Reduced method complexity and size
+- Fixed various RuboCop issues
+- Improved code organization by separating concerns
+
 ## [0.5.34] - 2025-03-10
 ### Fixed
 - Added missing `thor` gem dependency to fix LoadError when running CLI commands

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 ruby '3.3.5'
@@ -5,22 +7,21 @@ ruby '3.3.5'
 # Specify your gem's dependencies in mercury_banking.gemspec
 gemspec
 
-gem 'dotenv'
 gem 'activesupport'
-gem 'terminal-table'
-gem 'pry'
-gem 'webmock', '~> 3.18'
-gem 'thor'
-gem 'symmetric-encryption'
+gem 'base64'
+gem 'csv'
+gem 'dead_end', require: false  # Helps find syntax errors
+gem 'debride', require: false   # Finds unused code
+gem 'dotenv'
 gem 'lockbox'
+gem 'pry'
 gem 'rake', '~> 13.0'
 gem 'rspec', '~> 3.0'
 gem 'rubocop', require: false
 gem 'rubocop-performance', require: false
-gem 'rubocop-rspec', require: false
 gem 'rubocop-rake', require: false
-gem 'dead_end', require: false  # Helps find syntax errors
-gem 'debride', require: false   # Finds unused code
-gem 'csv'
-gem 'base64'
-
+gem 'rubocop-rspec', require: false
+gem 'symmetric-encryption'
+gem 'terminal-table'
+gem 'thor'
+gem 'webmock', '~> 3.18'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mercury_banking (0.5.38)
+    mercury_banking (0.7.0)
       activesupport (~> 7.0.0)
       dotenv (~> 2.8)
       fiddle (~> 1.1)

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "mercury_banking"

data/bin/mercury

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'thor'
 require 'mercury_banking'
@@ -14,4 +15,4 @@ require 'mercury_banking/cli'
 require 'symmetric-encryption'
 
 # Start the CLI
-MercuryBanking::CLI::Main.start(ARGV) 
+MercuryBanking::CLI::Main.start(ARGV)

data/lib/mercury_banking/api.rb

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
 module MercuryBanking
+  # API client for Mercury Banking
+  # Handles all API requests to the Mercury Banking API
   class API
     def initialize(secret)
       @api_key = secret
@@ -40,10 +44,8 @@ module MercuryBanking
     end
 
     def validate_body(body, path)
-      if body["errors"]
-        raise "#{@api_key} access to #{path} errored with #{body["errors"]["message"]}"
-      end
-      
+      raise "#{@api_key} access to #{path} errored with #{body['errors']['message']}" if body["errors"]
+
       body
     end
 
@@ -86,6 +88,7 @@ module MercuryBanking
     def find_account_by_number(account_number)
       account = accounts.find { |a| a["accountNumber"] == account_number.to_s }
       raise "Account with number #{account_number} not found" unless account
+
       account
     end
 
@@ -93,37 +96,35 @@ module MercuryBanking
       account = get_account(account_id)
       account['currentBalance']
     end
-    
+
     # /account/:id/transactions
     def get_transactions(account_id, start_date = nil)
       path = "account/#{account_id}/transactions"
       path += "?start=#{start_date}" if start_date
       get(path)["transactions"]
     end
-    
+
     # Get transactions from all accounts
     def get_all_transactions(start_date = nil)
       all_transactions = []
-      
+
       accounts.each do |account|
-        begin
-          account_transactions = get_transactions(account["id"], start_date)
-          # Add account information to each transaction
-          account_transactions.each do |transaction|
-            transaction["accountName"] = account["name"]
-            transaction["accountId"] = account["id"]
-            transaction["accountNumber"] = account["accountNumber"]
-          end
-          all_transactions.concat(account_transactions)
-        rescue StandardError => e
-          puts "Warning: Could not fetch transactions for account #{account["name"]}: #{e.message}" unless ENV['MERCURY_SILENT']
+        account_transactions = get_transactions(account["id"], start_date)
+        # Add account information to each transaction
+        account_transactions.each do |transaction|
+          transaction["accountName"] = account["name"]
+          transaction["accountId"] = account["id"]
+          transaction["accountNumber"] = account["accountNumber"]
         end
+        all_transactions.concat(account_transactions)
+      rescue StandardError => e
+        puts "Warning: Could not fetch transactions for account #{account['name']}: #{e.message}" unless ENV['MERCURY_SILENT']
       end
-      
+
       # Sort all transactions by date (newest first)
       all_transactions.sort_by { |t| t["createdAt"] || "" }.reverse
     end
-    
+
     # /account/:id/transactions/:id
     def transaction(account_id, transaction_id)
       path = "account/#{account_id}/transaction/#{transaction_id}"
@@ -158,10 +159,12 @@ module MercuryBanking
       post(rec.json, 'recipients')
       new_recipient = find_recipient(name: name)
       raise "Couldn't add account #{name}" unless new_recipient
+
       puts "Successfully added #{new_recipient['name']}" if new_recipient
     end
 
-    def update_recipient(name:, address:, email:, city:, region:, postal_code:, country:, account_number:, routing_number:, recipient_id:)
+    def update_recipient(name:, address:, email:, city:, region:, postal_code:, country:, account_number:,
+                         routing_number:, recipient_id:)
       rec = MercuryBanking::Recipient.new(
         name: name,
         address: address,
@@ -179,7 +182,7 @@ module MercuryBanking
     def transfer(recipient_id:, amount:, account_id:, note: nil, external: nil)
       payload = { recipientId: recipient_id, amount: amount, paymentMethod: 'ach',
                   note: note, externalMemo: external, idempotencyKey: "#{recipient_id}-#{amount}-#{note}-#{external}" }
-      self.post(payload, "account/#{account_id}/transactions")
+      post(payload, "account/#{account_id}/transactions")
     end
   end
-end 
+end

data/lib/mercury_banking/cli/accounts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MercuryBanking
   module CLI
     # Module for account-related commands
@@ -6,51 +8,49 @@ module MercuryBanking
       def self.included(base)
         base.class_eval do
           desc 'accounts', 'Display all accounts'
-          method_option :format, type: :string, default: 'table', enum: ['table', 'json'], desc: 'Output format (table or json)'
+          method_option :format, type: :string, default: 'table', enum: %w[table json],
+                                 desc: 'Output format (table or json)'
           def accounts
             with_api_client do |client|
               accounts = client.accounts
-              
+
               if options[:json] || options[:format] == 'json'
                 puts JSON.pretty_generate(accounts)
               else
                 display_accounts_table(accounts)
               end
-              
+
               puts "You have #{accounts.count} account/s" unless options[:json]
             end
           end
 
-          desc 'balance ACCOUNT_ID_OR_NUMBER', "Display the current balance of an account (using account number from accounts table)"
+          desc 'balance ACCOUNT_ID_OR_NUMBER',
+               "Display the current balance of an account (using account number from accounts table)"
           def balance(account_identifier)
             with_api_client do |client|
               # Determine if we're dealing with an account ID or account number
               account_id = nil
-              if account_identifier.match?(/^\d+$/) && !account_identifier.include?('-')
-                begin
-                  account = client.find_account_by_number(account_identifier)
-                  account_id = account["id"]
-                rescue => e
-                  # If not found by number, assume it's an ID
-                  account_id = account_identifier
-                  account = client.get_account(account_id)
-                end
-              else
+              begin
+                account = client.find_account_by_number(account_identifier)
+                account_id = account['id']
+              rescue StandardError
+                # If not found by number, assume it's an ID
                 account_id = account_identifier
-                account = client.get_account(account_id)
               end
-              
+
+              account = client.get_account(account_id)
+
               balance = client.balance(account_id)
-              
+
               if options[:json]
                 puts JSON.pretty_generate({
-                  'account_id' => account_id,
-                  'account_number' => account['accountNumber'],
-                  'name' => account['name'],
-                  'balance' => balance
-                })
+                                            'account_id' => account_id,
+                                            'account_number' => account['accountNumber'],
+                                            'name' => account['name'],
+                                            'balance' => balance
+                                          })
               else
-                puts "#{account['name']} (#{account['accountNumber']}): $#{format("%.2f", balance)}"
+                puts "#{account['name']} (#{account['accountNumber']}): $#{format('%.2f', balance)}"
               end
             end
           end
@@ -58,4 +58,4 @@ module MercuryBanking
       end
     end
   end
-end 
+end

data/lib/mercury_banking/cli/base.rb

@@ -1,3 +1,11 @@
+# frozen_string_literal: true
+
+require 'logger'
+require 'symmetric-encryption'
+require 'json'
+require 'base64'
+require 'fileutils'
+
 module MercuryBanking
   module CLI
     # Base module for CLI functionality
@@ -6,7 +14,7 @@ module MercuryBanking
       def with_api_client
         api_key = get_api_key
         raise "API key not found. Please run 'mercury set_key' first." unless api_key
-        
+
         client = MercuryBanking::API.new(api_key)
         yield client
       rescue StandardError => e
@@ -18,41 +26,55 @@ module MercuryBanking
         exit 1
       end
 
-      # Get the API key from the encrypted storage
+      # Get API key by decrypting the stored encrypted key
       def get_api_key
-        config_path = File.join(Dir.home, '.mercury-banking', 'api_key.enc')
-        key_path = File.join(Dir.home, '.mercury-banking', 'key_config.json')
-        
-        unless File.exist?(config_path) && File.exist?(key_path)
-          raise "API key not found. Please run 'mercury set_key' first."
+        config_dir = File.join(Dir.home, '.mercury-banking')
+        key_config_path = File.join(config_dir, 'key_config.json')
+        api_key_path = File.join(config_dir, 'api_key.enc')
+
+        unless File.exist?(key_config_path) && File.exist?(api_key_path)
+          return nil
         end
+
+        # Load the cipher configuration
+        cipher_config = JSON.parse(File.read(key_config_path))
+        
+        # Recreate the cipher
+        cipher = SymmetricEncryption::Cipher.new(
+          key: Base64.strict_decode64(cipher_config['key']),
+          iv: Base64.strict_decode64(cipher_config['iv']),
+          cipher_name: cipher_config['cipher_name']
+        )
+
+        # Set the cipher as the primary one
+        SymmetricEncryption.cipher = cipher
         
-        begin
-          key_config = JSON.parse(File.read(key_path))
-          
-          # Initialize the SymmetricEncryption with the loaded cipher
-          cipher = SymmetricEncryption::Cipher.new(
-            key: Base64.strict_decode64(key_config['key']),
-            iv: Base64.strict_decode64(key_config['iv']),
-            cipher_name: key_config['cipher_name'] || 'aes-256-cbc'
-          )
-          
-          # Set the cipher as the primary one
-          SymmetricEncryption.cipher = cipher
-          
-          encrypted_key = File.read(config_path)
-          cipher.decrypt(encrypted_key)
-        rescue => e
-          puts "Error decrypting API key: #{e.message}"
+        # Load and decrypt the API key
+        encrypted_key = File.read(api_key_path)
+        cipher.decrypt(encrypted_key)
+      rescue StandardError => e
+        puts "Error decrypting API key: #{e.message}" unless options[:json]
+        nil
+      end
+
+      # Get the API key from the configuration file (legacy method)
+      def api_key
+        config_path = File.join(Dir.home, '.mercury', 'config')
+        key_path = File.join(Dir.home, '.mercury', 'key')
+
+        unless File.exist?(config_path) && File.exist?(key_path)
+          puts "Error: Mercury API key not found. Please run 'mercury configure' first."
           exit 1
         end
+
+        File.read(key_path).strip
       end
 
       # Log transfer details
       def log_transfer(from, to, amount, note, status)
         log_dir = File.join(Dir.home, '.mercury-banking', 'logs')
         FileUtils.mkdir_p(log_dir)
-        
+
         log_file = File.join(log_dir, 'transfers.log')
         File.open(log_file, 'a') do |f|
           f.puts "#{Time.now.iso8601},\"#{from}\",\"#{to}\",\"#{amount}\",\"#{note}\",\"#{status}\""
@@ -65,4 +87,4 @@ module MercuryBanking
       end
     end
   end
-end 
+end