mercury_banking 0.5.37 → 0.6.0

data/lib/mercury_banking/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mercury_banking/cli/base'
 require 'mercury_banking/cli/accounts'
 require 'mercury_banking/cli/reports'
@@ -20,90 +22,91 @@ module MercuryBanking
       include MercuryBanking::Formatters::TableFormatter
       include MercuryBanking::Formatters::ExportFormatter
       include MercuryBanking::Reports::BalanceSheet
-      
+
       # Add global option for JSON output
       class_option :json, type: :boolean, default: false, desc: 'Output in JSON format'
-      
+
       map %w[--version -v] => :version
-      
+
       # Add version banner to help output
       def self.banner(command, _namespace = nil, _subcommand = false)
         "#{basename} #{command.usage}"
       end
-      
+
       def self.help(shell, _subcommand = false)
         shell.say "Mercury Banking CLI v#{MercuryBanking::VERSION} - Command-line interface for Mercury Banking API"
         shell.say
         super
       end
-      
+
       # Handle Thor deprecation warning
       def self.exit_on_failure?
         true
       end
-      
+
       desc 'version', 'Display Mercury Banking CLI version'
       def version
         if options[:json]
           puts JSON.pretty_generate({
-            'name' => 'mercury-banking',
-            'version' => MercuryBanking::VERSION,
-            'ruby_version' => RUBY_VERSION
-          })
+                                      'name' => 'mercury-banking',
+                                      'version' => MercuryBanking::VERSION,
+                                      'ruby_version' => RUBY_VERSION
+                                    })
         else
           puts "Mercury Banking CLI v#{MercuryBanking::VERSION} (Ruby #{RUBY_VERSION})"
         end
       end
-      
+
       desc 'set_key', 'Sets and encrypts the API key'
       def set_key
         # Create the .mercury-banking directory if it doesn't exist
         config_dir = File.join(Dir.home, '.mercury-banking')
         FileUtils.mkdir_p(config_dir)
-        
+
         # Generate a random key and IV for encryption
         key = SecureRandom.random_bytes(32)
         iv = SecureRandom.random_bytes(16)
-        
+
         # Create a cipher config
         cipher_config = {
           key: Base64.strict_encode64(key),
           iv: Base64.strict_encode64(iv),
           cipher_name: 'aes-256-cbc'
         }
-        
+
         # Save the cipher config to a file
         key_config_path = File.join(config_dir, 'key_config.json')
         File.write(key_config_path, JSON.pretty_generate(cipher_config))
-        
+
         # Initialize the SymmetricEncryption with the generated cipher
         cipher = SymmetricEncryption::Cipher.new(
           key: key,
           iv: iv,
           cipher_name: 'aes-256-cbc'
         )
-        
+
         # Set the cipher as the primary one
         SymmetricEncryption.cipher = cipher
-        
+
         # Get the API key from the user
         api_key = ask('Enter your Mercury API key:')
-        
+
         # Encrypt the API key
         encrypted_key = cipher.encrypt(api_key)
-        
+
         # Save the encrypted API key to a file
         api_key_path = File.join(config_dir, 'api_key.enc')
         File.write(api_key_path, encrypted_key)
-        
+
         puts "API key encrypted and saved to #{api_key_path}"
       end
-      
+
       desc 'transactions ACCOUNT_ID_OR_NUMBER', 'List transactions for an account with their status'
       method_option :start, type: :string, default: '2020-01-01', desc: 'Start date for transactions (YYYY-MM-DD)'
       method_option :end, type: :string, desc: 'End date for transactions (YYYY-MM-DD)'
       method_option :status, type: :string, desc: 'Filter by transaction status (e.g., sent, failed, pending)'
-      method_option :format, type: :string, default: 'table', enum: ['table', 'json'], desc: 'Output format (table or json)'
+      method_option :format, type: :string, default: 'table', enum: %w[table json],
+                             desc: 'Output format (table or json)'
       method_option :search, type: :string, desc: 'Search for transactions by description'
       def transactions(account_identifier)
         with_api_client do |client|
@@ -113,36 +116,34 @@ module MercuryBanking
             begin
               account = client.find_account_by_number(account_identifier)
               account_id = account["id"]
-            rescue => e
-              # If not found by number, assume it's an ID
-              account_id = account_identifier
-              account = client.get_account(account_id)
+            rescue StandardError
+              # Handle error without assigning to unused variable
+              puts "Error: Could not find account with identifier #{account_identifier}"
+              return []
             end
           else
             account_id = account_identifier
             account = client.get_account(account_id)
           end
-          
+
           # Get transactions for the account
           start_date = options[:start]
           end_date = options[:end]
-          
+
           transactions = client.get_transactions(account_id, start_date)
-          
+
           # Filter by end date if specified
           if end_date
             end_date_obj = Date.parse(end_date)
             transactions = transactions.select do |t|
-              transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+              transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
               transaction_date <= end_date_obj
             end
           end
-          
+
           # Filter by status if specified
-          if options[:status]
-            transactions = transactions.select { |t| t["status"] == options[:status] }
-          end
-          
+          transactions = transactions.select { |t| t["status"] == options[:status] } if options[:status]
+
           # Filter by search term if specified
           if options[:search]
             search_term = options[:search].downcase
@@ -151,7 +152,7 @@ module MercuryBanking
               description.downcase.include?(search_term)
             end
           end
-          
+
           if options[:json] || options[:format] == 'json'
             # Format transactions for JSON output
             formatted_transactions = transactions.map do |t|
@@ -167,21 +168,21 @@ module MercuryBanking
                 'reason_for_failure' => t["reasonForFailure"]
               }
             end
-            
+
             puts JSON.pretty_generate({
-              'account_id' => account_id,
-              'account_name' => account['name'],
-              'account_number' => account['accountNumber'],
-              'total_transactions' => transactions.size,
-              'transactions' => formatted_transactions
-            })
+                                        'account_id' => account_id,
+                                        'account_name' => account['name'],
+                                        'account_number' => account['accountNumber'],
+                                        'total_transactions' => transactions.size,
+                                        'transactions' => formatted_transactions
+                                      })
           else
             # Display transactions in a table
             puts "Transactions for #{account['name']} (#{account['accountNumber']})"
             puts "Period: #{start_date} to #{end_date || 'present'}"
             puts "Total transactions: #{transactions.size}"
             puts
-            
+
             rows = transactions.map do |t|
               date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
               description = t["bankDescription"] || t["externalMemo"] || "Unknown transaction"
@@ -191,19 +192,20 @@ module MercuryBanking
               kind = t["kind"]
               reconciled = false
               failure_reason = t["reasonForFailure"] || ""
-              
+
               [t["id"], date, description, amount, status, kind, reconciled, failure_reason]
             end
-            
+
             table = ::Terminal::Table.new(
-              headings: ['Transaction ID', 'Date', 'Description', 'Amount', 'Status', 'Type', 'Reconciled', 'Failure Reason'],
+              headings: ['Transaction ID', 'Date', 'Description', 'Amount', 'Status', 'Type', 'Reconciled',
+                         'Failure Reason'],
               rows: rows
             )
-            
+
             puts table
           end
         end
       end
     end
   end
-end 
+end

data/lib/mercury_banking/formatters/export_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MercuryBanking
   module Formatters
     # Formatter for exporting transactions to different formats
@@ -8,7 +10,7 @@ module MercuryBanking
           file.puts "; Mercury Bank Transactions Export"
           file.puts "; Generated on #{Time.now.strftime('%Y-%m-%d %H:%M:%S')}"
           file.puts
-          
+
           # Add account declarations to ensure ledger recognizes them
           accounts = transactions.map { |t| t["accountName"] || "Mercury Account" }.uniq
           accounts.each do |account|
@@ -17,7 +19,7 @@ module MercuryBanking
           file.puts "account Expenses:Unknown"
           file.puts "account Income:Unknown"
           file.puts
-          
+
           # Debug: Show what accounts are being created
           if verbose
             puts "Creating ledger file with the following accounts:"
@@ -25,13 +27,13 @@ module MercuryBanking
               puts "- Assets:#{account}"
             end
           end
-          
+
           # Filter out failed transactions
           valid_transactions = transactions.reject { |t| t["status"] == "failed" }
-          
+
           # Sort transactions chronologically by timestamp
           sorted_transactions = sort_transactions_chronologically(valid_transactions)
-          
+
           sorted_transactions.each do |t|
             # Get the full timestamp for precise ordering
             timestamp = t["postedAt"] || t["createdAt"]
@@ -41,63 +43,60 @@ module MercuryBanking
             amount = t["amount"].to_f
             account_name = t["accountName"] || "Mercury Account"
             transaction_id = t["id"]
-            
+
             # Check if this transaction is reconciled
             is_reconciled = reconciled_transactions.include?(transaction_id)
-            
+
             # Sanitize description for ledger format - replace newlines with spaces and escape semicolons
             description = description.gsub(/[\r\n]+/, ' ').gsub(/;/, '\\;')
-            
+
             # Ensure the description doesn't start with characters that could be interpreted as a date
             # or other ledger syntax elements
-            if description =~ /^\d/ || description =~ /^[v#]/ || description =~ /^\s*\d{4}/ || description =~ /^\s*\d{2}\/\d{2}/
+            if description =~ /^\d/ || description =~ /^[v#]/ || description =~ /^\s*\d{4}/ || description =~ %r{^\s*\d{2}/\d{2}}
               description = "- #{description}"
             end
-            
+
             # Format the transaction with proper indentation and alignment
             file.puts "#{date} #{is_reconciled ? '* ' : ''}#{description}"
             file.puts "    ; Transaction ID: #{transaction_id}"
             file.puts "    ; Timestamp: #{timestamp}"
             file.puts "    ; Time: #{time}"
-            file.puts "    ; Status: #{t["status"]}"
-            
+            file.puts "    ; Status: #{t['status']}"
+
             # Add reconciliation metadata
-            if is_reconciled
-              file.puts "    ; :reconciled: true"
-            end
-            
+            file.puts "    ; :reconciled: true" if is_reconciled
+
             # Add counterparty information if available
             if t["counterpartyName"]
               # Sanitize counterparty name
               counterparty = t["counterpartyName"].gsub(/[\r\n]+/, ' ').gsub(/;/, '\\;')
               file.puts "    ; Counterparty: #{counterparty}"
             end
-            
+
             # Add additional metadata if available
             if t["externalMemo"] && t["externalMemo"] != description
               # Sanitize memo
               memo = t["externalMemo"].gsub(/[\r\n]+/, ' ').gsub(/;/, '\\;')
               file.puts "    ; Memo: #{memo}"
             end
-            
+
             # Add the postings
-            if amount > 0
+            file.puts "    Assets:#{account_name}  $#{format('%.2f', amount)}"
+            if amount.positive?
               # Credit (money coming in)
-              file.puts "    Assets:#{account_name}  $#{format('%.2f', amount)}"
               file.puts "    Income:Unknown  $#{format('%.2f', -amount)}"
             else
               # Debit (money going out)
-              file.puts "    Assets:#{account_name}  $#{format('%.2f', amount)}"
               file.puts "    Expenses:Unknown  $#{format('%.2f', amount.abs)}"
             end
             file.puts
           end
         end
-        
+
         puts "Verifying ledger file validity..."
         verify_ledger_file(output_file, verbose)
       end
-      
+
       # Sort transactions chronologically by timestamp
       def sort_transactions_chronologically(transactions)
         transactions.sort_by do |t|
@@ -106,65 +105,68 @@ module MercuryBanking
           Time.parse(timestamp)
         end
       end
-      
+
       # Verify that the ledger file is valid
       def verify_ledger_file(output_file, verbose = false)
-        begin
-          # Debug: Verify the ledger file is valid
-          cmd = "ledger -f #{output_file} balance"
-          output = `#{cmd}`
-          
-          if $?.success?
-            if verbose
-              puts "Ledger verification output: #{output}"
-              
-              # Show all accounts in the ledger file
-              cmd = "ledger -f #{output_file} accounts"
-              output = `#{cmd}`
-              
-              if $?.success?
-                puts "All accounts in the ledger file:"
-                puts output
-              else
-                puts "Warning: Could not list accounts in the ledger file."
-                puts "This may indicate a problem with the file format, but the balance command succeeded."
-              end
+        # Debug: Verify the ledger file is valid
+        cmd = "ledger -f #{output_file} balance"
+        output = `#{cmd}`
+
+        if $?.success?
+          if verbose
+            puts "Ledger verification output: #{output}"
+
+            # Show all accounts in the ledger file
+            cmd = "ledger -f #{output_file} accounts"
+            output = `#{cmd}`
+
+            if $?.success?
+              puts "All accounts in the ledger file:"
+              puts output
+            else
+              puts "Warning: Could not list accounts in the ledger file."
+              puts "This may indicate a problem with the file format, but the balance command succeeded."
             end
-          else
-            puts "Warning: Ledger verification failed. The file may contain formatting issues."
-            puts "Error output: #{output}"
-            
-            # Try to identify problematic lines
-            cmd = "grep -n '^[0-9]' #{output_file} | head -10"
-            problematic_lines = `#{cmd}`
-            puts "First few transaction lines for inspection:"
-            puts problematic_lines
           end
-        rescue => e
-          puts "Error during ledger verification: #{e.message}"
-          puts "This doesn't necessarily mean the file is invalid, but there may be issues with the ledger command."
+        else
+          puts "Warning: Ledger verification failed. The file may contain formatting issues."
+          puts "Error output: #{output}"
+
+          # Try to identify problematic lines
+          cmd = "grep -n '^[0-9]' #{output_file} | head -10"
+          problematic_lines = `#{cmd}`
+          puts "First few transaction lines for inspection:"
+          puts problematic_lines
         end
+      rescue StandardError => e
+        puts "Error during ledger verification: #{e.message}"
+        puts "This doesn't necessarily mean the file is invalid, but there may be issues with the ledger command."
       end
-      
+
       # Export transactions to beancount format
       def export_to_beancount(transactions, output_file, reconciled_transactions = [], verbose = false)
         File.open(output_file, 'w') do |file|
           file.puts "; Mercury Bank Transactions Export"
           file.puts "; Generated on #{Time.now.strftime('%Y-%m-%d %H:%M:%S')}"
           file.puts
-          
+
           # Filter out failed transactions
           valid_transactions = transactions.reject { |t| t["status"] == "failed" }
-          
+
           # Get unique account names for debug output
           if verbose
-            accounts = valid_transactions.map { |t| t["accountName"] || "Mercury" }.map { |name| name.gsub(/[^a-zA-Z0-9]/, '-') }.uniq
+            # First get all account names
+            account_names = valid_transactions.map do |t|
+              t["accountName"] || "Mercury"
+            end
+            # Then clean and make unique
+            accounts = account_names.map { |name| name.gsub(/[^a-zA-Z0-9]/, '-') }.uniq
             puts "Creating beancount file with the following accounts:"
             accounts.each do |account|
               puts "- Assets:#{account}"
             end
           end
-          
+
           valid_transactions.each do |t|
             date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
             description = t["bankDescription"] || t["externalMemo"] || "Unknown transaction"
@@ -172,18 +174,18 @@ module MercuryBanking
             account_name = t["accountName"] || "Mercury"
             account_name = account_name.gsub(/[^a-zA-Z0-9]/, '-')
             transaction_id = t["id"]
-            
+
             # Check if this transaction is reconciled
             is_reconciled = reconciled_transactions.include?(transaction_id)
             flag = is_reconciled ? "*" : "!"
-            
+
             # Sanitize description for beancount format
             description = description.gsub(/[\r\n]+/, ' ').gsub(/"/, '\\"')
-            
+
             file.puts "#{date} #{flag} \"#{description}\""
             file.puts "  ; Transaction ID: #{transaction_id}"
-            file.puts "  ; Status: #{t["status"]}"
-            
+            file.puts "  ; Status: #{t['status']}"
+
             # Add reconciliation metadata
             if is_reconciled
               file.puts "  reconciled: \"true\""
@@ -192,29 +194,29 @@ module MercuryBanking
               file.puts "  reconciled: \"false\""
               file.puts "  reconciled_at: \"\""
             end
-            
-            if amount < 0
-              file.puts "  Expenses:Unknown  #{format("%.2f", amount.abs)} USD"
-              file.puts "  Assets:#{account_name}  #{format("%.2f", amount)} USD"
+
+            if amount.negative?
+              file.puts "  Expenses:Unknown  #{format('%.2f', amount.abs)} USD"
+              file.puts "  Assets:#{account_name}  #{format('%.2f', amount)} USD"
             else
-              file.puts "  Assets:#{account_name}  #{format("%.2f", amount)} USD"
-              file.puts "  Income:Unknown  #{format("%.2f", -amount)} USD"
+              file.puts "  Assets:#{account_name}  #{format('%.2f', amount)} USD"
+              file.puts "  Income:Unknown  #{format('%.2f', -amount)} USD"
             end
             file.puts
           end
         end
       end
-      
+
       # Export transactions to hledger format
       def export_to_hledger(transactions, output_file, reconciled_transactions = [], verbose = false)
         File.open(output_file, 'w') do |file|
           file.puts "; Mercury Bank Transactions Export"
           file.puts "; Generated on #{Time.now.strftime('%Y-%m-%d %H:%M:%S')}"
           file.puts
-          
+
           # Filter out failed transactions
           valid_transactions = transactions.reject { |t| t["status"] == "failed" }
-          
+
           # Get unique account names for debug output
           if verbose
             accounts = valid_transactions.map { |t| t["accountName"] || "Mercury Account" }.uniq
@@ -223,25 +225,25 @@ module MercuryBanking
               puts "- Assets:#{account}"
             end
           end
-          
+
           valid_transactions.each do |t|
             date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
             description = t["bankDescription"] || t["externalMemo"] || "Unknown transaction"
             amount = t["amount"].to_f
             account_name = t["accountName"] || "Mercury Account"
             transaction_id = t["id"]
-            
+
             # Check if this transaction is reconciled
             is_reconciled = reconciled_transactions.include?(transaction_id)
             status_marker = is_reconciled ? " * " : " ! "
-            
+
             # Sanitize description for hledger format
             description = description.gsub(/[\r\n]+/, ' ').gsub(/;/, '\\;')
-            
+
             file.puts "#{date}#{status_marker}#{description}"
             file.puts "    ; Transaction ID: #{transaction_id}"
-            file.puts "    ; Status: #{t["status"]}"
-            
+            file.puts "    ; Status: #{t['status']}"
+
             # Add reconciliation metadata
             if is_reconciled
               file.puts "    reconciled: true"
@@ -250,57 +252,57 @@ module MercuryBanking
               file.puts "    reconciled: false"
               file.puts "    reconciled-at:"
             end
-            
-            if amount < 0
-              file.puts "    Expenses:Unknown  $#{format("%.2f", amount.abs)}"
-              file.puts "    Assets:#{account_name}  $#{format("%.2f", amount)}"
+
+            if amount.negative?
+              file.puts "    Expenses:Unknown  $#{format('%.2f', amount.abs)}"
+              file.puts "    Assets:#{account_name}  $#{format('%.2f', amount)}"
             else
-              file.puts "    Assets:#{account_name}  $#{format("%.2f", amount)}"
-              file.puts "    Income:Unknown  $#{format("%.2f", -amount)}"
+              file.puts "    Assets:#{account_name}  $#{format('%.2f', amount)}"
+              file.puts "    Income:Unknown  $#{format('%.2f', -amount)}"
             end
             file.puts
           end
         end
       end
-      
+
       # Export transactions to CSV format
       def export_to_csv(transactions, output_file, reconciled_transactions = [], verbose = false)
         require 'csv'
-        
+
         CSV.open(output_file, 'w') do |csv|
           # Write header
           csv << ['Date', 'Description', 'Amount', 'Account', 'Transaction ID', 'Status', 'Reconciled', 'Reconciled At']
-          
+
           # Filter out failed transactions
           valid_transactions = transactions.reject { |t| t["status"] == "failed" }
-          
+
           if verbose
             puts "Creating CSV file with #{valid_transactions.size} transactions"
             puts "CSV columns: Date, Description, Amount, Account, Transaction ID, Status, Reconciled, Reconciled At"
           end
-          
+
           # Write transactions
           valid_transactions.each do |t|
             date = t["postedAt"] ? Time.parse(t["postedAt"]).strftime("%Y-%m-%d") : Time.parse(t["createdAt"]).strftime("%Y-%m-%d")
             description = t["bankDescription"] || t["externalMemo"] || "Unknown transaction"
-            
+
             # Replace newlines with spaces for CSV format
             description = description.gsub(/[\r\n]+/, ' ')
-            
+
             amount = t["amount"].to_f
             account_name = t["accountName"] || "Mercury Account"
             transaction_id = t["id"]
             status = t["status"]
-            
+
             # Check if this transaction is reconciled
             is_reconciled = reconciled_transactions.include?(transaction_id)
             reconciled = is_reconciled ? "Yes" : "No"
             reconciled_at = is_reconciled ? Time.now.strftime("%Y-%m-%d") : ""
-            
+
             csv << [date, description, amount, account_name, transaction_id, status, reconciled, reconciled_at]
           end
         end
       end
     end
   end
-end 
+end