mercury_banking 0.5.37 → 0.6.0

data/lib/mercury_banking/cli/financials.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mercury_banking/cli/base'
 require 'mercury_banking/formatters/export_formatter'
 require 'mercury_banking/reports/balance_sheet'
@@ -11,202 +13,124 @@ module MercuryBanking
         include MercuryBanking::CLI::Base
         include MercuryBanking::Formatters::ExportFormatter
         include MercuryBanking::Reports::BalanceSheet
-        
+        # BalanceSheetHelper will be included after it's defined
+
         desc "balancesheet", "Generate a balance sheet report and cross-check with Mercury account balances"
         method_option :format, type: :string, default: 'ledger', desc: 'Accounting format to use (ledger or beancount)'
         method_option :start, type: :string, default: '2020-01-01', desc: 'Start date for transactions (YYYY-MM-DD)'
         method_option :end, type: :string, desc: 'End date for transactions (YYYY-MM-DD)'
         method_option :save_report, type: :string, desc: 'Save report output to specified file'
         method_option :verbose, type: :boolean, default: false, desc: 'Show detailed debug information'
-        method_option :ledger_file, type: :string, desc: 'Use an existing ledger file instead of fetching transactions from Mercury'
+        method_option :ledger_file, type: :string,
+                                    desc: 'Use an existing ledger file instead of fetching transactions from Mercury'
         def balancesheet
           # Call the balance_sheet method directly
           balance_sheet
         end
-        
+
         # Methods that should not be exposed as commands
         no_commands do
           # Implementation of the balance sheet functionality
           def balance_sheet
-            # If a ledger file is provided, use it directly
-            if options[:ledger_file]
-              ledger_file = options[:ledger_file]
-              format = options[:format]
-              end_date = options[:end]
-              verbose = options[:verbose]
-              
-              puts "Using existing ledger file: #{ledger_file}"
-              
-              if !File.exist?(ledger_file)
-                puts "Error: Ledger file not found at #{ledger_file}"
-                return
-              end
-              
-              # Generate balance sheet from the ledger file
-              case format
-              when 'ledger'
-                balance_sheet_output = generate_ledger_balance_sheet(ledger_file, end_date)
-                if balance_sheet_output
-                  puts "\n=== Balance Sheet ===\n"
-                  puts balance_sheet_output
-                  
-                  # Save report to file if requested
-                  if options[:save_report]
-                    File.write(options[:save_report], balance_sheet_output)
-                    puts "\nReport saved to #{options[:save_report]}"
-                  end
-                else
-                  puts "Failed to generate balance sheet from ledger file."
-                end
-              when 'beancount'
-                balance_sheet_output = generate_beancount_balance_sheet(ledger_file, end_date)
-                if balance_sheet_output
-                  puts "\n=== Balance Sheet ===\n"
-                  puts balance_sheet_output
-                  
-                  # Save report to file if requested
-                  if options[:save_report]
-                    File.write(options[:save_report], balance_sheet_output)
-                    puts "\nReport saved to #{options[:save_report]}"
-                  end
-                else
-                  puts "Failed to generate balance sheet from beancount file."
-                end
-              else
-                puts "Unsupported format: #{format}. Please use 'ledger' or 'beancount'."
-              end
-              
+            client = MercuryBanking::Client.new
+            accounts = client.get_accounts
+
+            if options[:ledger_file] && File.exist?(options[:ledger_file])
+              process_existing_ledger_file(options[:ledger_file], options[:format], options[:save_report], options[:verbose])
               return
             end
-            
-            # Otherwise, fetch data from Mercury API
-            with_api_client do |client|
-              # Get current account balances from Mercury
-              accounts = client.accounts
-              
-              # Create a mapping of account names to balances
-              mercury_balances = {}
-              accounts.each do |account|
-                mercury_balances[account['name']] = account['currentBalance']
-              end
-              
-              # Get all transactions for the balance sheet
-              start_date = options[:start]
-              end_date = options[:end]
-              format = options[:format]
-              verbose = options[:verbose]
-              
-              date_range = "since #{start_date}"
-              date_range += " until #{end_date}" if end_date
-              
-              puts "Fetching transactions for all accounts #{date_range}..."
-              
-              transactions = client.get_all_transactions(start_date)
-              
-              # Filter by end date if specified
-              if end_date
-                end_date_obj = Date.parse(end_date)
-                transactions = transactions.select do |t|
-                  transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
-                  transaction_date <= end_date_obj
-                end
-              end
-              
-              if transactions.empty?
-                puts "No transactions found to generate balance sheet."
-                return
-              end
-              
-              # Create a temporary file
-              require 'tempfile'
-              temp_file = Tempfile.new(['mercury_transactions', ".#{format}"])
-              output_file = temp_file.path
-              
-              # Export transactions in the specified format
-              case format
-              when 'ledger'
-                export_to_ledger(transactions, output_file, [], verbose)
-                balance_sheet_output = generate_ledger_balance_sheet(output_file, end_date)
-              when 'beancount'
-                export_to_beancount(transactions, output_file, [], verbose)
-                balance_sheet_output = generate_beancount_balance_sheet(output_file, end_date)
-              else
-                puts "Unsupported format: #{format}. Please use 'ledger' or 'beancount'."
-                temp_file.unlink
-                return
-              end
-              
-              # Parse the balance sheet output to extract account balances
-              ledger_balances = parse_balance_sheet_output(balance_sheet_output, format, verbose)
-              
-              # Cross-check Mercury balances with ledger balances
-              puts "\n=== Balance Sheet Cross-Check ==="
-              puts "Mercury Account".ljust(30) + "Mercury Balance".ljust(15) + "Ledger Balance".ljust(15) + "Difference"
-              puts "-" * 75
-              
-              total_diff = 0
-              mercury_balances.each do |account_name, mercury_balance|
-                # Find the corresponding ledger account (might be prefixed with Assets:)
-                ledger_account_key = ledger_balances.keys.find { |k| k.include?(account_name) }
-                
-                # Debug information
-                if verbose
-                  puts "Looking for Mercury account '#{account_name}' in ledger accounts:"
-                  ledger_balances.keys.each do |k|
-                    puts "  - #{k} (match: #{k.include?(account_name) ? 'Yes' : 'No'})"
-                  end
-                end
-                
-                ledger_balance = ledger_account_key ? ledger_balances[ledger_account_key] : 0
-                
-                # Calculate difference
-                diff = mercury_balance - ledger_balance
-                total_diff += diff.abs
-                
-                # Format for display
-                mercury_balance_str = format("$%.2f", mercury_balance)
-                ledger_balance_str = format("$%.2f", ledger_balance)
-                diff_str = format("$%.2f", diff)
-                
-                # Add warning marker for differences
-                diff_marker = diff.abs > 0.01 ? " ⚠️" : ""
-                
-                puts account_name.ljust(30) + mercury_balance_str.ljust(15) + ledger_balance_str.ljust(15) + diff_str + diff_marker
-              end
-              
-              puts "-" * 75
-              puts "Total Discrepancy: #{format("$%.2f", total_diff)}"
-              
-              if total_diff > 0.01
-                puts "\n⚠️ Warning: There are discrepancies between Mercury account balances and the ledger balance sheet."
-                puts "This could be due to:"
-                puts "  - Transactions not yet recorded in the ledger"
-                puts "  - Incorrect categorization of transactions"
-                puts "  - Timing differences between when transactions were recorded"
-              else
-                puts "\n✓ Balance sheet matches Mercury account balances."
-              end
-              
-              # Save report to file if requested
-              if options[:save_report] && balance_sheet_output
-                full_report = balance_sheet_output + "\n\n" + "=== Balance Sheet Cross-Check ===\n"
-                mercury_balances.each do |account_name, mercury_balance|
-                  ledger_account_key = ledger_balances.keys.find { |k| k.include?(account_name) }
-                  ledger_balance = ledger_account_key ? ledger_balances[ledger_account_key] : 0
-                  diff = mercury_balance - ledger_balance
-                  full_report += "#{account_name}: Mercury $#{format("%.2f", mercury_balance)} vs Ledger $#{format("%.2f", ledger_balance)} (Diff: $#{format("%.2f", diff)})\n"
-                end
-                
-                File.write(options[:save_report], full_report)
-                puts "\nReport saved to #{options[:save_report]}"
-              end
-              
-              # Clean up temporary file
+
+            # Fetch all transactions from all accounts
+            transactions = fetch_all_transactions(client, accounts, options[:end])
+            puts "Found #{transactions.length} transactions across #{accounts.length} accounts."
+
+            # Get current balances for all Mercury accounts
+            mercury_balances = get_mercury_balances(accounts)
+
+            # Create a temporary file for exporting transactions
+            temp_file, output_file = create_temp_file(options[:format])
+
+            # Export transactions and generate balance sheet
+            balance_sheet_output = export_and_generate_balance_sheet(
+              transactions,
+              output_file,
+              options[:format],
+              options[:end],
+              options[:verbose]
+            )
+
+            # If balance sheet generation failed, exit
+            unless balance_sheet_output
+              temp_file.close
               temp_file.unlink
+              return
             end
+
+            # Parse the balance sheet output to get account balances
+            ledger_balances = {}
+            balance_sheet_output.each_line do |line|
+              next unless line.strip.start_with?('Assets:')
+
+              parts = line.strip.split(/\s+/)
+              account = parts.first
+              amount = parts.last.gsub(/[$,]/, '').to_f
+              ledger_balances[account] = amount
+            end
+
+            # Display cross-check between Mercury and ledger balances
+            display_balance_cross_check(mercury_balances, ledger_balances, options[:verbose])
+
+            # Save full report to file if requested
+            save_full_report(balance_sheet_output, mercury_balances, ledger_balances, options[:save_report]) if options[:save_report]
+
+            # Clean up temporary file
+            temp_file.close
+            temp_file.unlink
+          end
+
+          # Process an existing ledger file
+          def process_existing_ledger_file(ledger_file, format, save_path, _verbose)
+            puts "Using existing ledger file: #{ledger_file}"
+
+            # Determine the format based on file extension if not specified
+            unless format
+              format = File.extname(ledger_file).delete('.').downcase
+              puts "Detected format: #{format}"
+            end
+
+            # Generate balance sheet based on format
+            balance_sheet_output = process_ledger_format(ledger_file, format)
+
+            # If balance sheet generation failed, exit
+            return unless balance_sheet_output
+
+            # Save report to file if requested
+            return unless save_path
+
+            File.write(save_path, balance_sheet_output)
+            puts "\nReport saved to #{save_path}"
+          end
+
+          # Process ledger format file
+          def process_ledger_format(ledger_file, format)
+            case format
+            when 'ledger'
+              generate_ledger_balance_sheet(ledger_file)
+            when 'beancount'
+              generate_beancount_balance_sheet(ledger_file)
+            else
+              puts "Unsupported format: #{format}. Please use 'ledger' or 'beancount'."
+              nil
+            end
+          end
+
+          # Helper method to save a report to a file
+          def save_report_to_file(content, file_path)
+            File.write(file_path, content)
+            puts "\nReport saved to #{file_path}"
           end
         end
-        
+
         desc "incomestatement", "Generate an income statement report"
         method_option :format, type: :string, default: 'ledger', desc: 'Accounting format to use (ledger or beancount)'
         method_option :start, type: :string, default: '2020-01-01', desc: 'Start date for transactions (YYYY-MM-DD)'
@@ -217,35 +141,35 @@ module MercuryBanking
           # Access the parent class to call with_api_client
           parent_class = self.class.parent_class
           parent_instance = parent_class.new
-          
+
           parent_instance.with_api_client do |client|
             # Get all transactions for the income statement
             start_date = options[:start]
             end_date = options[:end]
             format = options[:format]
             verbose = options[:verbose]
-            
+
             date_range = "since #{start_date}"
             date_range += " until #{end_date}" if end_date
-            
+
             puts "Fetching transactions for all accounts #{date_range}..."
-            
+
             transactions = client.get_all_transactions(start_date)
-            
+
             # Filter by end date if specified
             if end_date
               end_date_obj = Date.parse(end_date)
               transactions = transactions.select do |t|
-                transaction_date = t["postedAt"] ? Date.parse(t["postedAt"]) : Date.parse(t["createdAt"])
+                transaction_date = Date.parse(t["postedAt"] || t["createdAt"])
                 transaction_date <= end_date_obj
               end
             end
-            
+
             # Create a temporary file
             require 'tempfile'
             temp_file = Tempfile.new(['mercury_transactions', ".#{format}"])
             output_file = temp_file.path
-            
+
             # Export transactions in the specified format
             case format
             when 'ledger'
@@ -257,12 +181,13 @@ module MercuryBanking
             else
               puts "Unsupported format: #{format}. Please use 'ledger' or 'beancount'."
               temp_file.unlink
-              return
+              income_statement_output = nil
+              break # Use break instead of return to exit the loop
             end
-            
-            # Display the income statement
-            puts income_statement_output
-            
+
+            # Display the income statement if it exists
+            puts income_statement_output if income_statement_output
+
             # Save the report to a file if requested
             if options[:save_report]
               File.open(options[:save_report], 'w') do |file|
@@ -270,33 +195,160 @@ module MercuryBanking
               end
               puts "\nReport saved to #{options[:save_report]}"
             end
-            
+
             # Clean up the temporary file
             temp_file.unlink
           end
         end
-        
+
         # Store reference to parent class
         class << self
           attr_accessor :parent_class
         end
       end
-      
+
       # Add financial report commands to the CLI class
       def self.included(base)
         base.class_eval do
           # Register the financials command
           desc "financials SUBCOMMAND", "Financial reporting commands"
           subcommand "financials", FinancialsCommand
-          
+
           # Set the parent class for the subcommand
           FinancialsCommand.parent_class = base
-          
+
           # Remove the old methods with underscores if they exist
           remove_method :financials_balancesheet if method_defined?(:financials_balancesheet)
           remove_method :financials_incomestatement if method_defined?(:financials_incomestatement)
         end
       end
     end
+
+    # Module for balance sheet related functionality
+    module BalanceSheetHelper
+      # Fetch all transactions from all accounts
+      def fetch_all_transactions(client, accounts, end_date)
+        transactions = []
+        accounts.each do |account|
+          account_id = account['id']
+          account_transactions = client.get_transactions(account_id)
+
+          # Filter by end date if provided
+          if end_date
+            account_transactions = account_transactions.select do |t|
+              t['postedAt'] && Date.parse(t['postedAt']) <= Date.parse(end_date)
+            end
+          end
+
+          transactions.concat(account_transactions)
+        end
+        transactions
+      end
+
+      # Get current balances for all Mercury accounts
+      def get_mercury_balances(accounts)
+        mercury_balances = {}
+        accounts.each do |account|
+          mercury_balances[account['name']] = account['currentBalance']
+        end
+        mercury_balances
+      end
+
+      # Create a temporary file for exporting transactions
+      def create_temp_file(format)
+        require 'tempfile'
+        temp_file = Tempfile.new(['mercury_transactions', ".#{format}"])
+        [temp_file, temp_file.path]
+      end
+
+      # Export transactions and generate balance sheet
+      def export_and_generate_balance_sheet(transactions, output_file, format, end_date, verbose)
+        case format
+        when 'ledger'
+          export_to_ledger(transactions, output_file, [], verbose)
+          generate_ledger_balance_sheet(output_file, end_date)
+        when 'beancount'
+          export_to_beancount(transactions, output_file, [], verbose)
+          generate_beancount_balance_sheet(output_file, end_date)
+        else
+          puts "Unsupported format: #{format}. Please use 'ledger' or 'beancount'."
+          nil
+        end
+      end
+
+      # Display cross-check between Mercury and ledger balances
+      def display_balance_cross_check(mercury_balances, ledger_balances, verbose)
+        puts "\n=== Balance Sheet Cross-Check ==="
+        puts "#{'Mercury Account'.ljust(30)}#{'Mercury Balance'.ljust(15)}#{'Ledger Balance'.ljust(15)}Difference"
+        puts "-" * 75
+
+        total_diff = 0
+        mercury_balances.each do |account_name, mercury_balance|
+          # Find the corresponding ledger account (might be prefixed with Assets:)
+          ledger_account_key = ledger_balances.keys.find { |k| k.include?(account_name) }
+
+          # Debug information
+          if verbose
+            puts "Looking for Mercury account '#{account_name}' in ledger accounts:"
+            ledger_balances.each_key do |k|
+              puts "  - #{k} (match: #{k.include?(account_name) ? 'Yes' : 'No'})"
+            end
+          end
+
+          ledger_balance = ledger_account_key ? ledger_balances[ledger_account_key] : 0
+
+          # Calculate difference
+          diff = mercury_balance - ledger_balance
+          total_diff += diff.abs
+
+          # Format for display
+          mercury_balance_str = format("$%.2f", mercury_balance)
+          ledger_balance_str = format("$%.2f", ledger_balance)
+          diff_str = format("$%.2f", diff)
+
+          # Add warning marker for differences
+          diff_marker = diff.abs > 0.01 ? " ⚠️" : ""
+
+          puts account_name.ljust(30) + mercury_balance_str.ljust(15) + ledger_balance_str.ljust(15) + diff_str + diff_marker
+        end
+
+        puts "-" * 75
+        puts "Total Discrepancy: #{format('$%.2f', total_diff)}"
+
+        if total_diff > 0.01
+          puts "\n⚠️ Warning: There are discrepancies between Mercury account balances and the ledger balance sheet."
+          puts "This could be due to:"
+          puts "  - Transactions not yet recorded in the ledger"
+          puts "  - Incorrect categorization of transactions"
+          puts "  - Timing differences between when transactions were recorded"
+        else
+          puts "\n✓ Balance sheet matches Mercury account balances."
+        end
+      end
+
+      # Save full report to file
+      def save_full_report(balance_sheet_output, mercury_balances, ledger_balances, save_path)
+        full_report = "#{balance_sheet_output}\n\n=== Balance Sheet Cross-Check ===\n"
+        mercury_balances.each do |account_name, mercury_balance|
+          ledger_account_key = ledger_balances.keys.find { |k| k.include?(account_name) }
+          ledger_balance = ledger_account_key ? ledger_balances[ledger_account_key] : 0
+          diff = mercury_balance - ledger_balance
+
+          # Format the report line with proper line breaks
+          report_line = "#{account_name}: "
+          report_line += "Mercury $#{format('%.2f', mercury_balance)} "
+          report_line += "vs Ledger $#{format('%.2f', ledger_balance)} "
+          report_line += "(Diff: $#{format('%.2f', diff)})\n"
+
+          full_report += report_line
+        end
+
+        File.write(save_path, full_report)
+        puts "\nReport saved to #{save_path}"
+      end
+    end
   end
-end 
+end
+
+# Include the BalanceSheetHelper module in the FinancialsCommand class
+MercuryBanking::CLI::Financials::FinancialsCommand.include(MercuryBanking::CLI::BalanceSheetHelper)