memfs 0.5.0 → 2.0.0

data/spec/fileutils_spec.rb

@@ -2,9 +2,9 @@ require 'date'
 require 'fileutils'
 require 'spec_helper'
 
-describe FileUtils do
+RSpec.describe FileUtils do
   before :each do
-    MemFs::File.umask(0020)
+    MemFs::File.umask(0o020)
     MemFs.activate!
 
     described_class.mkdir '/test'
@@ -17,26 +17,32 @@ describe FileUtils do
   describe '.cd' do
     it 'changes the current working directory' do
       described_class.cd '/test'
-      expect(described_class.pwd).to eq('/test')
+      expect(described_class.pwd).to eq(expected_path('/test'))
     end
 
-    it 'returns nil' do
-      expect(described_class.cd('/test')).to be_nil
+    if MemFs.ruby_version_gte?('2.6')
+      it 'returns 0' do
+        expect(described_class.cd('/test')).to eq 0
+      end
+    else
+      it 'returns nil' do
+        expect(described_class.cd('/test')).to be_nil
+      end
     end
 
     it "raises an error when the given path doesn't exist" do
-      expect { described_class.cd('/nowhere') }.to raise_specific_error(Errno::ENOENT)
+      expect { described_class.cd('/nowhere') }.to raise_error(Errno::ENOENT)
     end
 
     it 'raises an error when the given path is not a directory' do
       described_class.touch('/test-file')
-      expect { described_class.cd('/test-file') }.to raise_specific_error(Errno::ENOTDIR)
+      expect { described_class.cd('/test-file') }.to raise_error(Errno::ENOTDIR)
     end
 
     context 'when called with a block' do
       it 'changes current working directory for the block execution' do
         described_class.cd '/test' do
-          expect(described_class.pwd).to eq('/test')
+          expect(described_class.pwd).to eq(expected_path('/test'))
         end
       end
 
@@ -53,11 +59,11 @@ describe FileUtils do
 
       it 'changes directory to the last target of the link chain' do
         described_class.cd('/test-link')
-        expect(described_class.pwd).to eq('/test')
+        expect(described_class.pwd).to eq(expected_path('/test'))
       end
 
       it "raises an error if the last target of the link chain doesn't exist" do
-        expect { described_class.cd('/nowhere-link') }.to raise_specific_error(Errno::ENOENT)
+        expect { described_class.cd('/nowhere-link') }.to raise_error(Errno::ENOENT)
       end
     end
   end
@@ -65,24 +71,24 @@ describe FileUtils do
   describe '.chmod' do
     it 'changes permission bits on the named file to the bit pattern represented by mode' do
       described_class.touch '/test-file'
-      described_class.chmod 0777, '/test-file'
-      expect(File.stat('/test-file').mode).to eq(0100777)
+      described_class.chmod 0o777, '/test-file'
+      expect(File.stat('/test-file').mode).to eq(0o100777)
     end
 
     it 'changes permission bits on the named files (in list) to the bit pattern represented by mode' do
       described_class.touch ['/test-file', '/test-file2']
-      described_class.chmod 0777, ['/test-file', '/test-file2']
-      expect(File.stat('/test-file2').mode).to eq(0100777)
+      described_class.chmod 0o777, ['/test-file', '/test-file2']
+      expect(File.stat('/test-file2').mode).to eq(0o100777)
     end
 
     it 'returns an array containing the file names' do
       file_names = %w[/test-file /test-file2]
       described_class.touch file_names
-      expect(described_class.chmod(0777, file_names)).to eq(file_names)
+      expect(described_class.chmod(0o777, file_names)).to eq(file_names)
     end
 
     it 'raises an error if an entry does not exist' do
-      expect { described_class.chmod(0777, '/test-file') }.to raise_specific_error(Errno::ENOENT)
+      expect { described_class.chmod(0o777, '/test-file') }.to raise_error(Errno::ENOENT)
     end
 
     context 'when the named file is a symlink' do
@@ -93,13 +99,13 @@ describe FileUtils do
 
       context 'when File responds to lchmod' do
         it 'changes the mode on the link' do
-          described_class.chmod(0777, '/test-link')
-          expect(File.lstat('/test-link').mode).to eq(0100777)
+          described_class.chmod(0o777, '/test-link')
+          expect(File.lstat('/test-link').mode).to eq(0o100777)
         end
 
         it "doesn't change the mode of the link's target" do
           mode = File.lstat('/test-file').mode
-          described_class.chmod(0777, '/test-link')
+          described_class.chmod(0o777, '/test-link')
           expect(File.lstat('/test-file').mode).to eq(mode)
         end
       end
@@ -109,7 +115,7 @@ describe FileUtils do
           allow_any_instance_of(described_class::Entry_).to \
             receive_messages(have_lchmod?: false)
           mode = File.lstat('/test-link').mode
-          described_class.chmod(0777, '/test-link')
+          described_class.chmod(0o777, '/test-link')
           expect(File.lstat('/test-link').mode).to eq(mode)
         end
       end
@@ -122,18 +128,18 @@ describe FileUtils do
     end
 
     it 'changes the permission bits on the named entry' do
-      described_class.chmod_R(0777, '/test')
-      expect(File.stat('/test').mode).to eq(0100777)
+      described_class.chmod_R(0o777, '/test')
+      expect(File.stat('/test').mode).to eq(0o100777)
     end
 
     it 'changes the permission bits on any sub-directory of the named entry' do
-      described_class.chmod_R(0777, '/')
-      expect(File.stat('/test').mode).to eq(0100777)
+      described_class.chmod_R(0o777, '/')
+      expect(File.stat('/test').mode).to eq(0o100777)
     end
 
     it 'changes the permission bits on any descendant file of the named entry' do
-      described_class.chmod_R(0777, '/')
-      expect(File.stat('/test/test-file').mode).to eq(0100777)
+      described_class.chmod_R(0o777, '/')
+      expect(File.stat('/test/test-file').mode).to eq(0o100777)
     end
   end
 
@@ -296,9 +302,12 @@ describe FileUtils do
 
     context 'when +src+ does not exist' do
       it 'raises an exception' do
+        expected_exception =
+          RUBY_VERSION >= '2.4.0' ? Errno::ENOENT : RuntimeError
+
         expect {
           described_class.copy_entry('/test-file', '/test-copy')
-        }.to raise_specific_error(RuntimeError)
+        }.to raise_error(expected_exception)
       end
     end
 
@@ -308,7 +317,7 @@ describe FileUtils do
       before :each do
         described_class.touch('/test-file')
         described_class.chown(1042, 1042, '/test-file')
-        described_class.chmod(0777, '/test-file')
+        described_class.chmod(0o777, '/test-file')
         _fs.find('/test-file').mtime = time
         described_class.copy_entry('/test-file', '/test-copy', true)
       end
@@ -322,7 +331,7 @@ describe FileUtils do
       end
 
       it 'preserves permissions' do
-        expect(File.stat('/test-copy').mode).to eq(0100777)
+        expect(File.stat('/test-copy').mode).to eq(0o100777)
       end
 
       it 'preserves modified time' do
@@ -382,7 +391,7 @@ describe FileUtils do
       it 'raises an error' do
         expect {
           described_class.cp('/test-file', '/test-file')
-        }.to raise_specific_error(ArgumentError)
+        }.to raise_error(ArgumentError)
       end
     end
 
@@ -400,7 +409,7 @@ describe FileUtils do
           described_class.touch(['/dest', '/test-file2'])
           expect {
             described_class.cp(['/test-file', '/test-file2'], '/dest')
-          }.to raise_specific_error(Errno::ENOTDIR)
+          }.to raise_error(Errno::ENOTDIR)
         end
       end
     end
@@ -465,8 +474,8 @@ describe FileUtils do
 
     context 'when +:mode+ is set' do
       it 'changes the permission mode to +mode+' do
-        expect(File).to receive(:chmod).with(0777, '/test-file2')
-        described_class.install('/test-file', '/test-file2', mode: 0777)
+        expect(File).to receive(:chmod).with(0o777, '/test-file2')
+        described_class.install('/test-file', '/test-file2', mode: 0o777)
       end
     end
 
@@ -474,7 +483,7 @@ describe FileUtils do
       it 'raises an exception' do
         expect {
           described_class.install('/test-file', '/test-file')
-        }.to raise_exception(ArgumentError)
+        }.to raise_error ArgumentError
       end
     end
 
@@ -527,7 +536,7 @@ describe FileUtils do
           described_class.touch('/test-file2')
           expect {
             described_class.ln('/test-file', '/test-file2')
-          }.to raise_specific_error(SystemCallError)
+          }.to raise_error(SystemCallError)
         end
 
         context 'and +:force+ is set' do
@@ -552,7 +561,7 @@ describe FileUtils do
           described_class.touch(['/test-file2', '/not-a-dir'])
           expect {
             described_class.ln(['/test-file', '/test-file2'], '/not-a-dir')
-          }.to raise_specific_error(Errno::ENOTDIR)
+          }.to raise_error(Errno::ENOTDIR)
         end
       end
     end
@@ -587,7 +596,7 @@ describe FileUtils do
         it 'raises an exeption' do
           expect {
             described_class.ln_s('/test-file', '/not-a-dir')
-          }.to raise_specific_error(Errno::EEXIST)
+          }.to raise_error(Errno::EEXIST)
         end
 
         context 'and +:force+ is set' do
@@ -618,7 +627,7 @@ describe FileUtils do
         it 'raises an error' do
           expect {
             described_class.ln_s(['/test-file', '/test-file2'], '/not-a-dir')
-          }.to raise_specific_error(Errno::ENOTDIR)
+          }.to raise_error(Errno::ENOTDIR)
         end
       end
     end
@@ -653,9 +662,9 @@ describe FileUtils do
     context 'when passing options' do
       context 'when passing mode parameter' do
         it 'creates directory with specified permissions' do
-          described_class.mkdir('/test-dir', mode: 0654)
+          described_class.mkdir('/test-dir', mode: 0o654)
           expect(File.exist?('/test-dir')).to be true
-          expect(File.stat('/test-dir').mode).to eq(0100654)
+          expect(File.stat('/test-dir').mode).to eq(0o100654)
         end
       end
 
@@ -667,8 +676,6 @@ describe FileUtils do
         end
       end
     end
-
-
   end
 
   describe '.mkdir_p' do
@@ -697,9 +704,9 @@ describe FileUtils do
     context 'when passing options' do
       context 'when passing mode parameter' do
         it 'creates directory with specified permissions' do
-          described_class.mkdir_p('/test-dir', mode: 0654)
+          described_class.mkdir_p('/test-dir', mode: 0o654)
           expect(File.exist?('/test-dir')).to be true
-          expect(File.stat('/test-dir').mode).to eq(0100654)
+          expect(File.stat('/test-dir').mode).to eq(0o100654)
         end
       end
 
@@ -758,7 +765,7 @@ describe FileUtils do
   describe '.pwd' do
     it 'returns the name of the current directory' do
       described_class.cd '/test'
-      expect(described_class.pwd).to eq('/test')
+      expect(described_class.pwd).to eq(expected_path('/test'))
     end
   end
 
@@ -808,28 +815,28 @@ describe FileUtils do
     end
 
     it 'removes a file system entry +path+' do
-      described_class.chmod(0755, '/')
+      described_class.chmod(0o755, '/')
       described_class.remove_entry_secure('/test-dir')
       expect(Dir.exist?('/test-dir')).to be false
     end
 
     context 'when +path+ is a directory' do
       it 'removes it recursively' do
-        described_class.chmod(0755, '/')
+        described_class.chmod(0o755, '/')
         described_class.remove_entry_secure('/test-dir')
         expect(Dir.exist?('/test-dir/test-sub-dir')).to be false
       end
 
       context 'and is word writable' do
         it 'calls chown(2) on it' do
-          described_class.chmod(01777, '/')
+          described_class.chmod(0o1777, '/')
           directory = _fs.find('/test-dir')
           expect(directory).to receive(:uid=).at_least(:once)
           described_class.remove_entry_secure('/test-dir')
         end
 
         it 'calls chmod(2) on all sub directories' do
-          described_class.chmod(01777, '/')
+          described_class.chmod(0o1777, '/')
           directory = _fs.find('/test-dir')
           expect(directory).to receive(:mode=).at_least(:once)
           described_class.remove_entry_secure('/test-dir')
@@ -867,7 +874,7 @@ describe FileUtils do
 
     it 'cannot remove a directory' do
       described_class.mkdir('/test-dir')
-      expect { described_class.rm('/test-dir') }.to raise_specific_error(Errno::EPERM)
+      expect { described_class.rm('/test-dir') }.to raise_error(Errno::EPERM)
     end
 
     context 'when +:force+ is set' do
@@ -882,7 +889,9 @@ describe FileUtils do
 
   describe '.rm_f' do
     it 'calls rm with +:force+ set to true' do
-      expect(described_class).to receive(:rm).with('test', force: true)
+      expect(described_class)
+        .to receive(:rm).with('test', a_hash_including(force: true))
+
       described_class.rm_f('test')
     end
   end
@@ -917,7 +926,9 @@ describe FileUtils do
 
   describe '.rm_rf' do
     it 'calls rm with +:force+ set to true' do
-      expect(described_class).to receive(:rm_r).with('test', force: true)
+      expect(described_class)
+        .to receive(:rm_r).with('test', a_hash_including(force: true))
+
       described_class.rm_rf('test')
     end
   end
@@ -942,13 +953,30 @@ describe FileUtils do
         described_class.touch('/test-dir/test-file')
       end
 
-      it 'ignores errors' do
-        expect { described_class.rmdir('/test-dir') }.not_to raise_error
-      end
+      if RUBY_VERSION >= '2.5.0'
+        it 'raises an error' do
+          expect { described_class.rmdir('/test-dir') }
+            .to raise_error(Errno::ENOTEMPTY)
+        end
+
+        it 'doesn’t remove the directory' do
+          begin
+            described_class.rmdir('/test-dir')
+          rescue Errno::ENOTEMPTY
+            # noop
+          end
 
-      it "doesn't remove the directory" do
-        described_class.rmdir('/test-dir')
-        expect(Dir.exist?('/test-dir')).to be true
+          expect(Dir.exist?('/test-dir')).to be true
+        end
+      else
+        it 'ignores errors' do
+          expect { described_class.rmdir('/test-dir') }.not_to raise_error
+        end
+
+        it 'doesn’t remove the directory' do
+          described_class.rmdir('/test-dir')
+          expect(Dir.exist?('/test-dir')).to be true
+        end
       end
     end
   end