massive_record 0.2.0 → 0.2.1.rc1

data/spec/orm/cases/mass_assignment_security_spec.rb

@@ -0,0 +1,97 @@
+require 'spec_helper'
+require 'orm/models/person'
+
+describe "mass assignment security" do
+  def restore_mass_assignment_security_policy_after(klass)
+    accessible_attributes = klass._accessible_attributes
+    protected_attributes = klass._protected_attributes
+    active_authorizer = klass._active_authorizer
+
+    yield
+
+    klass._accessible_attributes = accessible_attributes
+    klass._protected_attributes = protected_attributes
+    klass._active_authorizer = active_authorizer
+  end
+
+
+
+  describe "settings and defaults" do
+    subject { Person }
+    its(:attributes_protected_by_default ) { should include 'id', Person.inheritance_attribute }
+    its(:protected_attributes) { should include 'id', Person.inheritance_attribute }
+
+
+    describe "#attr_accessible" do
+      it "sets attributes accessible" do
+        restore_mass_assignment_security_policy_after Person do
+          Person.class_eval do
+            attr_accessible :age
+          end
+
+          Person.accessible_attributes.should include 'age'
+        end
+      end
+    end
+
+    describe "#attr_protected" do
+      it "sets attributes protected" do
+        restore_mass_assignment_security_policy_after Person do
+          Person.class_eval do
+            attr_protected :age
+          end
+
+          Person.protected_attributes.should include 'age'
+        end
+      end
+    end
+  end
+
+  describe "access test on" do
+    describe Person do
+      context "when only age is accessible" do
+        it "sets age with mass assignment" do
+          restore_mass_assignment_security_policy_after Person do
+            Person.class_eval do
+              attr_accessible :age
+            end
+
+            Person.new(:age => 33).age.should eq 33
+          end
+        end
+
+        it "does not set name with mass assignment" do
+          restore_mass_assignment_security_policy_after Person do
+            Person.class_eval do
+              attr_accessible :age
+            end
+
+            Person.new(:name => 'Thorbjorn').name.should be_nil
+          end
+        end
+      end
+
+      context "when only age is protected" do
+        it "does not set age with mass assignment" do
+          restore_mass_assignment_security_policy_after Person do
+            Person.class_eval do
+              attr_protected :age
+            end
+
+            Person.new(:age => 33).age.should be_nil
+          end
+        end
+
+        it "sets name with mass assignment" do
+          restore_mass_assignment_security_policy_after Person do
+            Person.class_eval do
+              attr_protected :age
+            end
+
+            Person.new(:name => 'Thorbjorn').name.should eq "Thorbjorn"
+          end
+        end
+      end
+    end
+  end
+end

data/spec/orm/cases/persistence_spec.rb

@@ -15,27 +15,27 @@ describe "persistence" do
     end
 
     it "should be persisted if saved" do
-      model = TestClass.new :id => "id1"
+      model = TestClass.new "id1"
       model.save
       model.should be_persisted
     end
 
     it "should be destroyed when destroyed" do
-      model = TestClass.new :id => "id1"
+      model = TestClass.new "id1"
       model.save
       model.destroy
       model.should be_destroyed
     end
 
     it "should not be persisted if destroyed" do
-      model = TestClass.new :id => "id1"
+      model = TestClass.new "id1"
       model.save
       model.destroy
       model.should_not be_persisted
     end
 
     it "should be possible to create new objects" do
-      TestClass.create(:id => "id1").should be_persisted
+      TestClass.create("id1").should be_persisted
     end
 
     it "should raise an error if validation fails on save!" do
@@ -91,23 +91,28 @@ describe "persistence" do
     end
 
     it "should return a row with id set" do
-      Person.new({:id => "foo"}).send(:row_for_record).id.should == "foo"
+      Person.new("foo").send(:row_for_record).id.should == "foo"
     end
 
     it "should return a row with table set" do
-      Person.new({:id => "foo"}).send(:row_for_record).table.should == Person.table
+      Person.new("foo").send(:row_for_record).table.should == Person.table
     end
   end
   
   describe "#attributes_to_row_values_hash" do
     before do
-      @person = Person.new({ :id => "new_id", :name => "Vincent", :points => 15 })
+      @person = Person.new("new_id", :name => "Vincent", :points => 15)
     end
     
     it "should include the 'pts' field in the database which has 'points' as an alias" do
       @person.send(:attributes_to_row_values_hash)["base"].keys.should include("pts")
       @person.send(:attributes_to_row_values_hash)["base"].keys.should_not include("points")
     end
+
+    it "should include integer value, even if it is set as string" do
+      @person.age = "20"
+      @person.send(:attributes_to_row_values_hash)["info"]["age"].should == 20
+    end
   end
 
 
@@ -116,7 +121,7 @@ describe "persistence" do
       include MockMassiveRecordConnection
 
       before do
-        @person = Person.create! :id => "new_id", :name => "Thorbjorn", :age => "22"
+        @person = Person.create! "new_id", :name => "Thorbjorn", :age => "22"
       end
 
       it "should update given attriubte when valid" do
@@ -134,7 +139,7 @@ describe "persistence" do
       include MockMassiveRecordConnection
 
       before do
-        @person = Person.create! :id => "new_id", :name => "Thorbjorn", :age => "22"
+        @person = Person.create! "new_id", :name => "Thorbjorn", :age => "22"
       end
 
       it "should update given attriubtes when valid" do
@@ -162,7 +167,7 @@ describe "persistence" do
       end
 
       it "should delegate save to update if its a persisted record" do
-        person = Person.new :id => 14, :name => "Bob", :age => 33
+        person = Person.new '14', :name => "Bob", :age => 33
         person.should_receive(:new_record?).and_return(false)
         person.should_receive(:update)
         person.save
@@ -171,6 +176,7 @@ describe "persistence" do
 
     describe "database test" do
       include SetUpHbaseConnectionBeforeAll
+      include SetTableNamesToTestTable
       
       describe "create" do
         describe "when table does not exists" do
@@ -187,7 +193,7 @@ describe "persistence" do
               end
             end
 
-            @new_instance = @new_class.new :id => "id_of_foo", :foo => "bar"
+            @new_instance = @new_class.new "id_of_foo", :foo => "bar"
           end
 
           after do
@@ -220,13 +226,38 @@ describe "persistence" do
           include CreatePersonBeforeEach
 
           it "should store (create) new objects" do
-            person = Person.new :id => "new_id", :name => "Thorbjorn", :age => "22"
+            person = Person.new "new_id", :name => "Thorbjorn", :age => "22"
             person.save!
             person_from_db = Person.find(person.id)
             person_from_db.should == person
             person_from_db.name.should == "Thorbjorn"
           end
         end
+
+        it "raises an error if id already exists" do
+          check_was = Person.check_record_uniqueness_on_create
+          Person.check_record_uniqueness_on_create = true
+
+          Person.create! "foo", :name => "Thorbjorn", :age => "22"
+          expect {
+            Person.create! "foo", :name => "Anders", :age => "22"
+          }.to raise_error MassiveRecord::ORM::RecordNotUnique
+
+          Person.find("foo").name.should eq "Thorbjorn"
+          
+          Person.check_record_uniqueness_on_create = check_was
+        end
+
+        it "raises no error if exist checking is turned off" do
+          check_was = Person.check_record_uniqueness_on_create
+          Person.check_record_uniqueness_on_create = false
+
+          Person.create! "foo", :name => "Thorbjorn", :age => "22"
+          Person.create! "foo", :name => "Anders", :age => "22" # This will result in an "update"
+          Person.find("foo").name.should eq "Anders"
+
+          Person.check_record_uniqueness_on_create = check_was
+        end
       end
 
       describe "update" do
@@ -292,7 +323,7 @@ describe "persistence" do
       include MockMassiveRecordConnection
 
       before do
-        @person = Person.new :id => "id1"
+        @person = Person.new "id1"
         @person.stub!(:new_record?).and_return(false)
         @row = MassiveRecord::Wrapper::Row.new({:id => @person.id, :table => @person.class.table})
         @person.should_receive(:row_for_record).and_return(@row)
@@ -333,7 +364,7 @@ describe "persistence" do
       include SetTableNamesToTestTable
 
       before do
-        @person = Person.create! :id => "id1", :name => "Thorbjorn", :age => 29
+        @person = Person.create! "id1", :name => "Thorbjorn", :age => 29
       end
 
       it "should be removed by destroy" do
@@ -355,7 +386,7 @@ describe "persistence" do
 
       describe "#destroy_all" do
         it "should remove all when calling remove_all" do
-          Person.create! :id => "id2", :name => "Going to die :-(", :age => 99
+          Person.create! "id2", :name => "Going to die :-(", :age => 99
           Person.destroy_all
           Person.all.length.should == 0
         end
@@ -365,7 +396,7 @@ describe "persistence" do
         end
 
         it "should destroy all even if it is above 10 rows (obviously)" do
-          15.times { |i| Person.create! :id => "id-#{i}", :name => "Going to die :-(", :age => i + 20 }
+          15.times { |i| Person.create! "id-#{i}", :name => "Going to die :-(", :age => i + 20 }
           Person.destroy_all
           Person.all.length.should == 0
         end
@@ -380,7 +411,7 @@ describe "persistence" do
       include MockMassiveRecordConnection
 
       before do
-        @person = Person.create! :id => "id1", :name => "Thorbjorn", :age => 29
+        @person = Person.create! "id1", :name => "Thorbjorn", :age => 29
       end
 
       it "should being able to increment age" do
@@ -414,7 +445,7 @@ describe "persistence" do
       include SetTableNamesToTestTable
 
       before do
-        @person = Person.create! :id => "id1", :name => "Thorbjorn", :age => 29
+        @person = Person.create! "id1", :name => "Thorbjorn", :age => 29
       end
 
       it "should delegate it's call to increment" do
@@ -428,11 +459,44 @@ describe "persistence" do
         @person.age.should == 30
       end
 
-      it "should be able to do atomic increments" do
-        @person.atomic_increment!(:age).should == 30
-        @person.age.should == 30
-        @person.reload
-        @person.age.should == 30
+
+      describe "atomic increments" do
+        it "should be able to do atomic increments on existing objects" do
+          @person.atomic_increment!(:age).should == 30
+          @person.age.should == 30
+          @person.reload
+          @person.age.should == 30
+        end
+
+        it "is a persisted record after incrementation" do
+          person = Person.new('id2')
+          person.atomic_increment!(:age).should eq 1
+          person.should be_persisted
+        end
+
+        it "increments correctly when value is '1'" do
+          old_ensure = MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings
+          MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings = true
+
+          person = Person.new('id2')
+          person.atomic_increment!(:age).should eq 1
+
+          atomic_field = Person.attributes_schema['age']
+
+          # Enter incompatible data, number as string.
+          Person.table.find("id2").tap do |row|
+            row.update_column(
+              atomic_field.column_family.name,
+              atomic_field.name,
+              MassiveRecord::ORM::Base.coder.dump(1)
+            )
+            row.save
+          end
+
+          person.atomic_increment!(:age).should eq 2
+
+          MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings = old_ensure
+        end
       end
     end
   end
@@ -442,7 +506,7 @@ describe "persistence" do
       include MockMassiveRecordConnection
 
       before do
-        @person = Person.create! :id => "id1", :name => "Thorbjorn", :age => 29
+        @person = Person.create! "id1", :name => "Thorbjorn", :age => 29
       end
 
       it "should being able to decrement age" do
@@ -476,7 +540,7 @@ describe "persistence" do
       include SetTableNamesToTestTable
 
       before do
-        @person = Person.create! :id => "id1", :name => "Thorbjorn", :age => 29
+        @person = Person.create! "id1", :name => "Thorbjorn", :age => 29
       end
 
       it "should delegate it's call to decrement" do
@@ -496,17 +560,58 @@ describe "persistence" do
     include MockMassiveRecordConnection
 
     it "should raise an error if new record is read only and you try to save it" do
-      person = Person.new :id => "id1", :name => "Thorbjorn", :age => 29
+      person = Person.new "id1", :name => "Thorbjorn", :age => 29
       person.readonly!
       lambda { person.save }.should raise_error MassiveRecord::ORM::ReadOnlyRecord
     end
 
     it "should raise an error if record is read only and you try to save it" do
-      person = Person.create :id => "id1", :name => "Thorbjorn", :age => 29
+      person = Person.create "id1", :name => "Thorbjorn", :age => 29
       person.should be_persisted
 
       person.readonly!
       lambda { person.save }.should raise_error MassiveRecord::ORM::ReadOnlyRecord
     end
   end
+
+  describe "id as int" do
+    include SetUpHbaseConnectionBeforeAll
+    include SetTableNamesToTestTable
+
+    it "saves id as string and reloads correctly" do
+      person = Person.new :name => "Thorbjorn", :age => 29
+      person.id = 1
+      person.save!
+
+      person.reload
+      person.id.should == "1"
+    end
+  end
+
+
+  describe "attributes with nil value" do
+    include SetUpHbaseConnectionBeforeAll
+    include SetTableNamesToTestTable
+
+
+    subject do
+      Person.create!("id", {
+        :name => "Thorbjorn",
+        :age => 22,
+        :points => 1,
+        :addresses => {'home' => 'Here'},
+        :status => true
+      })
+    end
+
+    %w(points addresses status).each do |attr|
+      it "removes the cell from hbase when #{attr} is set to nil" do
+        subject[attr] = nil
+        subject.save!
+
+        raw_values = Person.table.find(subject.id).values
+        raw_values[subject.attributes_schema[attr].unique_name].should be_nil
+      end
+    end
+  end
 end

data/spec/orm/cases/single_table_inheritance_spec.rb

@@ -8,7 +8,7 @@ describe "Single table inheritance" do
 
   [Friend, BestFriend, BestFriend::SuperBestFriend].each do |klass|
     describe klass do
-      let(:subject) { klass.new(:id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true) }
+      let(:subject) { klass.new("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true) }
 
       its(:type) { should == klass.to_s }
 
@@ -20,7 +20,7 @@ describe "Single table inheritance" do
   end
 
   it "should not set type if record being saved is base class" do
-    person = Person.new :id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true
+    person = Person.new "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true
     person.type.should be_nil
   end
 end

data/spec/orm/cases/time_zone_awareness_spec.rb

@@ -0,0 +1,157 @@
+require 'spec_helper'
+require 'orm/models/test_class'
+require 'orm/models/person'
+
+describe "Time zone awareness" do
+  include TimeZoneHelper
+
+  describe "configuration" do
+    it "should have a default time zone configuration" do
+      TestClass.default_timezone.should eq :local
+    end
+
+    it "should have default time zone awareness" do
+      TestClass.time_zone_aware_attributes.should eq false
+    end
+
+    it "should by default skip no attributes when doing time zone conversions" do
+      TestClass.skip_time_zone_conversion_for_attributes.should eq []
+    end
+
+    it "should be possible to skip some attributes in TestClass while Person is untuched" do
+      TestClass.skip_time_zone_conversion_for_attributes = [:test]
+      TestClass.skip_time_zone_conversion_for_attributes.should include :test
+      Person.skip_time_zone_conversion_for_attributes.should be_empty
+    end
+  end
+
+
+  describe "when to do conversion" do
+    let(:field) { MassiveRecord::ORM::Schema::Field.new :name => 'tested_at' }
+
+    it "should do conversion when attribute is time" do
+      in_time_zone "utc" do
+        field.type = :time
+        TestClass.send(:time_zone_conversion_on_field?, field).should be_true
+      end
+    end
+
+    it "should not do conversion if time_zone_aware_attributes is false" do
+      field.type = :time
+      TestClass.time_zone_aware_attributes = false
+      TestClass.send(:time_zone_conversion_on_field?, field).should be_false
+    end
+
+    it "should not do conversion when attribute name is included in skip list" do
+      field.type = :time
+      TestClass.skip_time_zone_conversion_for_attributes = ['tested_at']
+      TestClass.send(:time_zone_conversion_on_field?, field).should be_false
+      TestClass.skip_time_zone_conversion_for_attributes = []
+    end
+
+    it "should not do conversion when attribute is string field" do
+      field.type = :string
+      TestClass.send(:time_zone_conversion_on_field?, field).should be_false
+    end
+  end
+
+
+
+  describe "conversion on attribute" do
+    include SetUpHbaseConnectionBeforeAll
+    include SetTableNamesToTestTable
+
+    subject { TestClass.new "test" }
+    let(:tz_europe) { "Europe/Stockholm" }
+    let(:tz_us) { "Pacific Time (US & Canada)" }
+
+    let(:time_as_string) { "2010-10-10 10:10:10" }
+
+    it "should be nil when set to nil" do
+      in_time_zone tz_europe do
+        subject.tested_at = nil
+        subject.tested_at.should be_nil
+      end
+    end
+
+    it "should return time as TimeWithZone when attribute accessed directly" do
+      in_time_zone tz_europe do
+        subject.tested_at = time_as_string
+        subject.tested_at.should be_instance_of ActiveSupport::TimeWithZone
+      end
+    end
+
+    it "should return time as TimeWithZone when attribute accessed through read_attribute" do
+      in_time_zone tz_europe do
+        subject.tested_at = time_as_string
+        subject.read_attribute(:tested_at).should be_instance_of ActiveSupport::TimeWithZone
+      end
+    end
+
+    it "should return time in local time" do
+      in_time_zone tz_europe do
+        subject.tested_at = time_as_string
+        subject.tested_at.time_zone.should eq ActiveSupport::TimeZone[tz_europe]
+
+        in_time_zone tz_us do
+          subject.tested_at.time_zone.should eq ActiveSupport::TimeZone[tz_us]
+        end
+      end
+    end
+
+    it "should return correct time in other time zones" do
+      utc_time = Time.utc(2010, 1, 1)
+      us_time = utc_time.in_time_zone(tz_us)
+
+      in_time_zone tz_europe do
+        subject.tested_at = us_time
+        subject.tested_at.should eq utc_time
+      end
+    end
+
+    it "should return correct times after save" do
+      utc_time = Time.now.utc
+      europe_time = utc_time.in_time_zone(tz_europe)
+      us_time = utc_time.in_time_zone(tz_us)
+
+      in_time_zone tz_europe do
+        subject.tested_at = europe_time
+        subject.save!
+      end
+
+      subject.reload
+
+      in_time_zone tz_us do
+        subject.tested_at.to_s.should eq us_time.to_s
+      end
+    end
+
+    it "should store time in DB format" do
+      utc_time = Time.now.utc
+      europe_time = utc_time.in_time_zone(tz_europe)
+
+      in_time_zone tz_europe do
+        subject.tested_at = europe_time
+        subject.save!
+      end
+
+      subject.reload
+      subject.tested_at.to_s.should eq utc_time.to_s
+
+      in_time_zone tz_europe do
+        subject.tested_at.to_s.should eq europe_time.to_s
+      end
+    end
+
+    it "should store time in DB format, raw check" do
+      in_time_zone tz_europe do
+        subject.tested_at = time_as_string
+        subject.save!
+
+        r = TestClass.table.find("test")
+        cell = r.columns["test_family:tested_at"]
+        cell.value.should eq MassiveRecord::ORM::Base.coder.dump(Time.zone.parse(time_as_string).utc)
+      end
+    end
+  end
+end