massive_record 0.2.0 → 0.2.1.rc1

data/spec/orm/cases/base_spec.rb

@@ -175,7 +175,7 @@ describe MassiveRecord::ORM::Base do
     end
 
     it "should return the id if persisted" do
-      TestClass.create!(:id => 1).to_param.should == "1"
+      TestClass.create!(1).to_param.should == "1"
     end
   end
 
@@ -185,7 +185,7 @@ describe MassiveRecord::ORM::Base do
     end
 
     it "should return id in an array persisted" do
-      TestClass.create!(:id => "1").to_key.should == ["1"]
+      TestClass.create!("1").to_key.should == ["1"]
     end
   end
 
@@ -215,7 +215,7 @@ describe MassiveRecord::ORM::Base do
 
     it "should start with the record's id if it has any" do
       @person.id = 3
-      @person.inspect.should include "#<Person id: 3,"
+      @person.inspect.should include '#<Person id: "3",'
     end
 
     it "should start with the record's id if it has any" do
@@ -286,7 +286,7 @@ describe MassiveRecord::ORM::Base do
   
   describe "#clone" do
     before do
-      @test_object = TestClass.create!(:id => "1", :foo => 'bar')
+      @test_object = TestClass.create!("1", :foo => 'bar')
       @clone_object = @test_object.clone
     end
     
@@ -313,4 +313,18 @@ describe MassiveRecord::ORM::Base do
       Person.coder.should be_instance_of MassiveRecord::ORM::Coders::JSON
     end
   end
+
+  describe "id as first argument to" do
+    [:new, :create, :create!].each do |creation_method|
+      describe creation_method do
+        it "sets first argument as records id" do
+          TestClass.send(creation_method, "idfirstarg").id.should == "idfirstarg"
+        end
+
+        it "sets first argument as record id, hash as it's attribute" do
+          TestClass.send(creation_method, "idfirstarg", foo: 'works').foo.should == 'works'
+        end
+      end
+    end
+  end
 end

data/spec/orm/cases/callbacks_spec.rb

@@ -175,7 +175,7 @@ describe "callbacks for" do
   end
 
   it "create should run in correct order" do
-    thorbjorn = CallbackDeveloper.create :id => "dummy"
+    thorbjorn = CallbackDeveloper.create "dummy"
     thorbjorn.history.should == [
       [:after_initialize, :method],
       [:after_initialize, :string],

data/spec/orm/cases/default_id_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+require 'orm/models/model_without_default_id'
+
+describe ModelWithoutDefaultId do
+  include MockMassiveRecordConnection
+  #include SetUpHbaseConnectionBeforeAll
+  #include SetTableNamesToTestTable
+
+  context "with auto increment id" do
+    its(:id) { be_nil }
+    its(:auto_increment_id) { be_true }
+
+    it "sets id to what next_id returns" do
+      subject.should_receive(:next_id).and_return 1
+      subject.save
+      subject.id.should eq "1"
+    end
+
+    it "does nothing if the id is set before create" do
+      subject.id = 2
+      subject.should_not_receive(:next_id)
+      subject.save
+      subject.id.should eq "2"
+    end
+  end
+
+  context "without auto increment id" do
+    before(:all) { subject.class.auto_increment_id = false }
+    after(:all) { subject.class.auto_increment_id = true }
+
+    its(:id) { be_nil }
+    its(:auto_increment_id) { be_false }
+
+    it "raises error as expected when id is missing" do
+      expect { subject.save }.to raise_error MassiveRecord::ORM::IdMissing
+    end
+  end
+end

data/spec/orm/cases/default_values_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe "default values" do
+  include SetUpHbaseConnectionBeforeAll 
+  include SetTableNamesToTestTable
+
+  subject do
+    Person.new("id", {
+      :name => "Thorbjorn",
+      :age => 22,
+      :points => 1
+    })
+  end
+
+  context "new record" do
+    its(:addresses) { should eq Hash.new }
+    its(:points) { should eq 1 }
+    its(:status) { should eq false }
+    its(:phone_numbers) { should eq [] }
+  end
+
+  context "persisted record" do
+    before do
+      subject.addresses = nil
+      subject.points = nil
+      subject.status = nil
+      subject.phone_numbers = nil
+      subject.save!
+      subject.reload
+    end
+
+    its(:addresses) { should be_nil }
+    its(:points) { should be_nil }
+    its(:status) { should be_nil }
+    its(:phone_numbers) { should eq [] }
+  end
+end

data/spec/orm/cases/dirty_spec.rb

@@ -5,7 +5,7 @@ describe "dirty" do
     include MockMassiveRecordConnection
 
     before do
-      @person = Person.new :id => 1, :name => "Alice", :age => 20, :email => "foo@bar.com"
+      @person = Person.new '1', :name => "Alice", :age => 20, :email => "foo@bar.com"
     end
 
     it "should not be changed after created" do
@@ -22,6 +22,30 @@ describe "dirty" do
       @person.should be_changed
     end
 
+    it "should notice changes in boolean values from false to true" do
+      @person.status = !@person.status
+      @person.should be_status_changed
+    end
+
+    it "should notice changes in boolean values from true to false" do
+      @person.status = true
+      @person.save
+      @person.status = false
+      @person.should be_status_changed
+    end
+
+    it "should not consider age set as string to the same as integer a change" do
+      @person.age = "20"
+      @person.should_not be_age_changed
+    end
+
+    it "should not consider age set as string back to original value a change" do
+      @person.age = 30
+      @person.age = "20"
+      @person.should_not be_age_changed
+    end
+
+
     it "should know when a attribute is set to it's original value" do
       original_name = @person.name
       @person.name = "Bob"

data/spec/orm/cases/encoding_spec.rb

@@ -9,7 +9,7 @@ describe "encoding" do
     include SetTableNamesToTestTable
 
     before do
-      @person = Person.create! :id => "new_id", :name => "Thorbjørn", :age => "22"
+      @person = Person.create! "new_id", :name => "Thorbjørn", :age => "22"
       @person_from_db = Person.find(@person.id)
     end
 
@@ -39,11 +39,11 @@ describe "encoding" do
     end
 
     it "should be able to store UTF-8 encoded strings" do
-      @row_from_db.values["info:name"].should == "Thorbjørn"
+      @row_from_db.values["info:name"].force_encoding(Encoding::UTF_8).should == "Thorbjørn"
     end
 
     it "should return string as UTF-8 encoded strings" do
-      @row_from_db.values["info:name"].encoding.should == Encoding::UTF_8
+      @row_from_db.values["info:name"].encoding.should == Encoding::BINARY
     end
   end
 end

data/spec/orm/cases/finder_default_scope.rb

@@ -1,12 +1,13 @@
 require 'spec_helper'
 require 'orm/models/person'
+require 'orm/models/test_class'
 
 describe "Default scope in" do
   include SetUpHbaseConnectionBeforeAll
   include SetTableNamesToTestTable
 
   describe Person do
-    let(:subject) { Person.new :id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
+    let(:subject) { Person.new "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
 
     before do
       subject.save!
@@ -49,5 +50,11 @@ describe "Default scope in" do
       person.points.should == 111
       person.name.should be_nil
     end
+
+    it "should not share scopes between classes" do
+      Person.class_eval { default_scope :select => :base }
+      Person.default_scoping.should be_instance_of MassiveRecord::ORM::Finders::Scope
+      TestClass.default_scoping.should be_nil
+    end
   end
 end

data/spec/orm/cases/finder_scope_spec.rb

@@ -217,8 +217,8 @@ describe MassiveRecord::ORM::Finders::Scope do
     include SetTableNamesToTestTable
 
     describe "with a person" do
-      let(:person_1) { Person.create :id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
-      let(:person_2) { Person.create :id => "ID2", :name => "Person2", :email => "two@person.com", :age => 22, :points => 222, :status => false }
+      let(:person_1) { Person.create "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
+      let(:person_2) { Person.create "ID2", :name => "Person2", :email => "two@person.com", :age => 22, :points => 222, :status => false }
 
       before do
         person_1.save!

data/spec/orm/cases/finders_spec.rb

@@ -23,21 +23,6 @@ describe "finders" do
       lambda { Person.find }.should raise_error ArgumentError
     end
 
-    it "should simply return nil on first if table does not exists" do
-      Person.table.should_receive(:exists?).and_return false
-      Person.first.should be_nil
-    end
-
-    it "should raise record not found error on find if table does not exists" do
-      Person.table.should_receive(:exists?).and_return false
-      lambda { Person.find(1) }.should raise_error MassiveRecord::ORM::RecordNotFound
-    end
-
-    it "should simply return empty array if table does not exists" do
-      Person.table.should_receive(:exists?).and_return false
-      Person.all.should == []
-    end
-
     it "should raise RecordNotFound if id is nil" do
       lambda { Person.find(nil) }.should raise_error MassiveRecord::ORM::RecordNotFound
     end
@@ -164,10 +149,15 @@ describe "finders" do
       @bob = Person.find("ID2")
     end
 
-    it "should return nil if id is not found" do
+    it "should raise record not found error" do
       lambda { Person.find("not_found") }.should raise_error MassiveRecord::ORM::RecordNotFound
     end
 
+    it "should raise MassiveRecord::ORM::RecordNotFound error if table does not exist" do
+      Person.table.destroy
+      expect { Person.find("id") }.to raise_error MassiveRecord::ORM::RecordNotFound
+    end
+
     it "should return the person object when found" do
       @person.name.should == "John Doe"
       @person.email.should == "john@base.com"
@@ -185,7 +175,7 @@ describe "finders" do
     end
 
     it "should find all persons, even if it is more than 10" do
-      15.times { |i| Person.create! :id => "id-#{i}", :name => "Going to die :-(", :age => i + 20 }
+      15.times { |i| Person.create! "id-#{i}", :name => "Going to die :-(", :age => i + 20 }
       Person.all.length.should > 10
     end
 
@@ -214,7 +204,7 @@ describe "finders" do
     end
 
     it "should not do a thing if table does not exist" do
-      Person.table.should_receive(:exists?).and_return false
+      Person.table.destroy
 
       counter = 0
 

data/spec/orm/cases/id_factory_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 require 'orm/models/person'
 
 describe "id factory" do
+  subject { MassiveRecord::ORM::IdFactory.instance }
+
   it "should be a singleton" do
     MassiveRecord::ORM::IdFactory.included_modules.should include(Singleton)
   end
@@ -10,32 +12,28 @@ describe "id factory" do
     describe "dry" do
       include MockMassiveRecordConnection
 
-      before do
-        @factory = MassiveRecord::ORM::IdFactory.instance
-      end
-
       it "should respond to next_for" do
-        @factory.should respond_to :next_for
+        subject.should respond_to :next_for
       end
 
       it "should use incomming table name if it's a string" do
-        @factory.should_receive(:next_id).with(hash_including(:table => "test_table"))
-        @factory.next_for "test_table"
+        subject.should_receive(:next_id).with(hash_including(:table => "test_table"))
+        subject.next_for "test_table"
       end
 
       it "should use incomming table name if it's a symbol" do
-        @factory.should_receive(:next_id).with(hash_including(:table => "test_table"))
-        @factory.next_for :test_table
+        subject.should_receive(:next_id).with(hash_including(:table => "test_table"))
+        subject.next_for :test_table
       end
 
       it "should ask object for it's table name if it responds to that" do
         Person.should_receive(:table_name).and_return("people")
-        @factory.should_receive(:next_id).with(hash_including(:table => "people"))
-        @factory.next_for(Person)
+        subject.should_receive(:next_id).with(hash_including(:table => "people"))
+        subject.next_for(Person)
       end
 
       it "should have class method next_for and delegate it to it's instance" do
-        @factory.should_receive(:next_for).with("cars")
+        subject.should_receive(:next_for).with("cars")
         MassiveRecord::ORM::IdFactory.next_for("cars")
       end
     end
@@ -46,29 +44,48 @@ describe "id factory" do
       include SetUpHbaseConnectionBeforeAll
       include SetTableNamesToTestTable
 
-      before do
-        @factory = MassiveRecord::ORM::IdFactory.instance
-      end
-
       after do
         MassiveRecord::ORM::IdFactory.destroy_all
-        MassiveRecord::ORM::IdFactory.instance_variable_set(:@instance, nil)
       end
 
       it "should increment start a new sequence on 1" do
-        @factory.next_for(Person).should == 1
+        subject.next_for(Person).should == 1
       end
 
       it "should increment value one by one" do
         5.times do |index|
           expected_id = index + 1
-          @factory.next_for(Person).should == expected_id
+          subject.next_for(Person).should == expected_id
         end
       end
 
       it "should maintain ids separate for each table" do
-        3.times { @factory.next_for(Person) }
-        @factory.next_for("cars").should == 1
+        3.times { subject.next_for(Person) }
+        subject.next_for("cars").should == 1
+      end
+
+
+      describe "old string representation of integers" do
+        it "increments correctly when value is '1'" do
+          old_ensure = MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings
+          MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings = true
+
+          subject.next_for(Person)
+
+          # Enter incompatible data, number as string.
+          MassiveRecord::ORM::IdFactory.table.first.tap do |row|
+            row.update_column(
+              MassiveRecord::ORM::IdFactory::COLUMN_FAMILY_FOR_TABLES,
+              Person.table_name,
+              MassiveRecord::ORM::Base.coder.dump(1)
+            )
+            row.save
+          end
+
+          subject.next_for(Person).should eq 2
+
+          MassiveRecord::ORM::Base.backward_compatibility_integers_might_be_persisted_as_strings = old_ensure
+        end
       end
     end
   end

data/spec/orm/cases/log_subscriber_spec.rb

@@ -0,0 +1,133 @@
+require 'spec_helper'
+require "active_support/log_subscriber/test_helper"
+
+describe "log subscriber" do
+  include ActiveSupport::BufferedLogger::Severity
+
+  include SetUpHbaseConnectionBeforeAll
+  include SetTableNamesToTestTable
+
+  let(:level) { DEBUG }
+  subject { ActiveSupport::LogSubscriber::TestHelper::MockLogger.new(level) }
+
+  before do
+    @old_logger = MassiveRecord::ORM::Base.logger
+    @notifier = ActiveSupport::Notifications::Fanout.new
+
+    ActiveSupport::LogSubscriber.colorize_logging = false
+
+    MassiveRecord::ORM::Base.logger = subject
+    ActiveSupport::Notifications.notifier = @notifier
+
+    MassiveRecord::ORM::LogSubscriber.attach_to :massive_record
+  end
+
+  after do
+    MassiveRecord::ORM::Base.logger = @old_logger
+    ActiveSupport::Notifications.notifier = nil
+  end
+
+
+
+  context "debug" do
+    it "should have nothing loged to begin with" do
+      subject.logged(:debug).size.should be_zero
+    end
+
+
+    describe "loading records" do
+      it "should have one lined log to debug when doing a all" do
+        Person.all
+        wait
+        subject.logged(:debug).size.should eq 1
+      end
+
+      it "should include a the class name of what is loading, time it took, a description about what has been done" do
+        Person.all
+        wait
+        subject.logged(:debug).last.should match /Person.+?load.+?([\d.]+).+?all/
+      end
+
+      it "should have one log line when doing first" do
+        Person.first
+        wait
+        subject.logged(:debug).size.should eq 1
+      end
+
+      it "should have some clue written that it is first" do
+        Person.first
+        wait
+        subject.logged(:debug).first.should include "options: [:all, {:limit=>1}]"
+      end
+
+      it "should have one log when doing find" do
+        Person.find("dummy") rescue nil
+        wait
+        subject.logged(:debug).first.should include 'options: ["dummy", {}]'
+      end
+    end
+
+    
+    describe "store records" do
+      before do
+        @person = Person.create! "first", :name => "Name", :age => 20
+        wait
+      end
+
+      describe "create" do
+        it "should have one line log when creating a record" do
+          subject.logged(:debug).size.should eq 1
+        end
+
+        it "should include class of what is being save, time it took an what kind of save it was" do
+          subject.logged(:debug).first.should match /Person.+?save.+?([\d.]+).+?create/
+        end
+      end
+
+      describe "update" do
+        before do
+          # Resetting the logger. Kinda hackish, might break if MockLogger changes internal implementation
+          subject.instance_variable_set(:@logged, Hash.new { |h,k| h[k] = [] })
+          @person.name = "New Name"
+          @person.save!
+        end
+
+        it "should have one line log when updating a record" do
+          subject.logged(:debug).size.should eq 1
+        end
+
+        it "should include class of what is being save, time it took an what kind of save it was" do
+          subject.logged(:debug).first.should match /Person.+?save.+?([\d.]+).+?update.+?id: first/
+        end
+
+        it "should include a list of attributes which was updated" do
+          subject.logged(:debug).first.should match /attributes: name/
+        end
+      end
+    end
+  end
+
+
+  context "info" do
+    let(:level) { INFO }
+
+    it "should have nothing logged to begin with" do
+      subject.logged(:debug).size.should be_zero
+    end
+
+    it "should have nothing logged when doing an all call" do
+      Person.all
+      wait
+      subject.logged(:debug).size.should be_zero
+    end
+  end
+
+
+
+
+  private
+
+  def wait
+    @notifier.wait
+  end
+end