marty 2.5.2 → 2.5.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (181) hide show
  1. checksums.yaml +5 -5
  2. data/.gitignore +4 -0
  3. data/.rubocop.yml +7 -0
  4. data/.rubocop_todo.yml +11 -589
  5. data/Gemfile +9 -9
  6. data/Gemfile.lock +1 -1
  7. data/Rakefile +1 -3
  8. data/app/components/marty/api_auth_view.rb +3 -3
  9. data/app/components/marty/api_config_view.rb +8 -8
  10. data/app/components/marty/api_log_view.rb +16 -20
  11. data/app/components/marty/auth_app.rb +6 -6
  12. data/app/components/marty/base_rule_view.rb +27 -19
  13. data/app/components/marty/config_view.rb +12 -9
  14. data/app/components/marty/data_grid_view.rb +26 -26
  15. data/app/components/marty/delorean_rule_view.rb +0 -1
  16. data/app/components/marty/event_view.rb +27 -27
  17. data/app/components/marty/extras/layout.rb +26 -26
  18. data/app/components/marty/extras/misc.rb +2 -2
  19. data/app/components/marty/grid.rb +13 -13
  20. data/app/components/marty/grid_append_only.rb +0 -1
  21. data/app/components/marty/import_type_view.rb +13 -13
  22. data/app/components/marty/import_view.rb +17 -16
  23. data/app/components/marty/log_view.rb +16 -14
  24. data/app/components/marty/main_auth_app.rb +59 -59
  25. data/app/components/marty/main_auth_app/client/main_auth_app.js +3 -3
  26. data/app/components/marty/mcfly_grid_panel.rb +10 -10
  27. data/app/components/marty/new_posting_form.rb +11 -11
  28. data/app/components/marty/new_posting_window.rb +0 -1
  29. data/app/components/marty/posting_grid.rb +12 -13
  30. data/app/components/marty/promise_view.rb +6 -6
  31. data/app/components/marty/report_form.rb +50 -53
  32. data/app/components/marty/report_select.rb +27 -27
  33. data/app/components/marty/reporting.rb +4 -4
  34. data/app/components/marty/script_form.rb +40 -42
  35. data/app/components/marty/script_grid.rb +24 -24
  36. data/app/components/marty/script_tester.rb +40 -42
  37. data/app/components/marty/scripting.rb +25 -27
  38. data/app/components/marty/simple_app.rb +24 -9
  39. data/app/components/marty/tag_grid.rb +12 -13
  40. data/app/components/marty/user_view.rb +35 -35
  41. data/app/controllers/marty/application_controller.rb +3 -4
  42. data/app/controllers/marty/components_controller.rb +1 -1
  43. data/app/controllers/marty/delayed_job_controller.rb +1 -0
  44. data/app/controllers/marty/diagnostic/controller.rb +4 -6
  45. data/app/controllers/marty/job_controller.rb +6 -6
  46. data/app/controllers/marty/report_controller.rb +11 -11
  47. data/app/controllers/marty/rpc_controller.rb +15 -16
  48. data/app/helpers/marty/script_set.rb +4 -4
  49. data/app/models/marty/api_auth.rb +4 -5
  50. data/app/models/marty/api_config.rb +1 -1
  51. data/app/models/marty/base.rb +9 -8
  52. data/app/models/marty/base_rule.rb +18 -13
  53. data/app/models/marty/config.rb +4 -5
  54. data/app/models/marty/data_grid.rb +157 -181
  55. data/app/models/marty/delorean_rule.rb +63 -62
  56. data/app/models/marty/enum.rb +1 -1
  57. data/app/models/marty/event.rb +56 -59
  58. data/app/models/marty/helper.rb +38 -6
  59. data/app/models/marty/import_type.rb +6 -6
  60. data/app/models/marty/log.rb +3 -2
  61. data/app/models/marty/name_validator.rb +3 -2
  62. data/app/models/marty/pg_enum.rb +3 -4
  63. data/app/models/marty/posting.rb +20 -24
  64. data/app/models/marty/promise.rb +28 -30
  65. data/app/models/marty/script.rb +30 -28
  66. data/app/models/marty/tag.rb +8 -8
  67. data/app/models/marty/token.rb +2 -2
  68. data/app/models/marty/user.rb +24 -23
  69. data/app/models/marty/vw_promise.rb +10 -11
  70. data/config/routes.rb +2 -2
  71. data/delorean/blame_report.dl +268 -0
  72. data/{spec/dummy/delorean/fields.dl → delorean/marty_fields.dl} +8 -0
  73. data/delorean/table_report.dl +34 -0
  74. data/docker-compose.dummy.yml +2 -3
  75. data/lib/marty/aws/base.rb +8 -8
  76. data/lib/marty/aws/request.rb +4 -4
  77. data/lib/marty/cache_adapters/mcfly_ruby_cache.rb +1 -0
  78. data/lib/marty/content_handler.rb +25 -25
  79. data/lib/marty/data_change.rb +49 -71
  80. data/lib/marty/data_conversion.rb +20 -28
  81. data/lib/marty/data_exporter.rb +25 -28
  82. data/lib/marty/data_importer.rb +25 -27
  83. data/lib/marty/engine.rb +1 -2
  84. data/lib/marty/json_schema.rb +22 -24
  85. data/lib/marty/logger.rb +6 -9
  86. data/lib/marty/mcfly_model.rb +20 -24
  87. data/lib/marty/migrations.rb +37 -35
  88. data/lib/marty/monkey.rb +33 -33
  89. data/lib/marty/permissions.rb +18 -18
  90. data/lib/marty/promise_job.rb +17 -17
  91. data/lib/marty/promise_proxy.rb +6 -6
  92. data/lib/marty/relation.rb +6 -7
  93. data/lib/marty/rpc_call.rb +13 -12
  94. data/lib/marty/rule_script_set.rb +32 -28
  95. data/lib/marty/schema_helper.rb +37 -51
  96. data/lib/marty/util.rb +25 -24
  97. data/lib/marty/version.rb +1 -1
  98. data/lib/marty/xl.rb +121 -115
  99. data/make-dummy.mk +3 -0
  100. data/marty.gemspec +21 -21
  101. data/other/marty/api/base.rb +34 -35
  102. data/other/marty/diagnostic/aws/ec2_instance.rb +8 -8
  103. data/other/marty/diagnostic/base.rb +13 -14
  104. data/other/marty/diagnostic/collection.rb +2 -1
  105. data/other/marty/diagnostic/connections.rb +8 -6
  106. data/other/marty/diagnostic/database.rb +1 -0
  107. data/other/marty/diagnostic/delayed_job_version.rb +7 -9
  108. data/other/marty/diagnostic/delayed_job_worker_total_count.rb +1 -1
  109. data/other/marty/diagnostic/delayed_job_workers.rb +1 -1
  110. data/other/marty/diagnostic/environment_variables.rb +17 -15
  111. data/other/marty/diagnostic/fatal.rb +1 -1
  112. data/other/marty/diagnostic/node.rb +5 -9
  113. data/other/marty/diagnostic/nodes.rb +7 -5
  114. data/other/marty/diagnostic/packer.rb +7 -7
  115. data/other/marty/diagnostic/reporter.rb +24 -27
  116. data/other/marty/diagnostic/version.rb +3 -5
  117. data/script/rails +2 -1
  118. data/spec/controllers/application_controller_spec.rb +6 -6
  119. data/spec/controllers/delayed_job_controller_spec.rb +4 -4
  120. data/spec/controllers/diagnostic/controller_spec.rb +59 -60
  121. data/spec/controllers/job_controller_spec.rb +68 -69
  122. data/spec/controllers/rpc_controller_spec.rb +353 -359
  123. data/spec/controllers/rpc_import_spec.rb +15 -16
  124. data/spec/dummy/delorean/blame_report.dl +110 -15
  125. data/spec/dummy/delorean/data_report.dl +4 -4
  126. data/spec/dummy/delorean/marty_fields.dl +63 -0
  127. data/spec/dummy/delorean/table_report.dl +34 -0
  128. data/spec/features/auth_app_spec.rb +1 -2
  129. data/spec/features/data_import_spec.rb +2 -3
  130. data/spec/features/enum_spec.rb +42 -46
  131. data/spec/features/jobs_dashboard_spec.rb +14 -8
  132. data/spec/features/log_view_spec.rb +40 -43
  133. data/spec/features/reporting_spec.rb +15 -15
  134. data/spec/features/rule_spec.rb +195 -190
  135. data/spec/features/scripting_spec.rb +17 -20
  136. data/spec/features/scripting_test_spec.rb +32 -33
  137. data/spec/features/user_view_spec.rb +15 -17
  138. data/spec/job_helper.rb +11 -11
  139. data/spec/lib/data_blame_spec.rb +82 -0
  140. data/spec/lib/data_exporter_spec.rb +31 -32
  141. data/spec/lib/data_importer_spec.rb +382 -395
  142. data/spec/lib/delorean_query_spec.rb +117 -119
  143. data/spec/lib/json_schema_spec.rb +382 -392
  144. data/spec/lib/logger_spec.rb +23 -24
  145. data/spec/lib/mcfly_model_spec.rb +112 -109
  146. data/spec/lib/migrations_spec.rb +10 -10
  147. data/spec/lib/struct_compare_spec.rb +6 -6
  148. data/spec/lib/table_report_spec.rb +90 -0
  149. data/spec/lib/xl_spec.rb +63 -65
  150. data/spec/lib/xl_styles_spec.rb +16 -19
  151. data/spec/models/api_auth_spec.rb +30 -30
  152. data/spec/models/config_spec.rb +32 -32
  153. data/spec/models/data_grid_spec.rb +642 -655
  154. data/spec/models/event_spec.rb +96 -88
  155. data/spec/models/import_type_spec.rb +20 -20
  156. data/spec/models/posting_spec.rb +35 -35
  157. data/spec/models/promise_spec.rb +5 -5
  158. data/spec/models/rule_spec.rb +280 -269
  159. data/spec/models/script_spec.rb +27 -18
  160. data/spec/models/user_spec.rb +9 -9
  161. data/spec/other/diagnostic/base_spec.rb +20 -19
  162. data/spec/other/diagnostic/collection_spec.rb +6 -5
  163. data/spec/other/diagnostic/delayed_job_version_spec.rb +1 -1
  164. data/spec/other/diagnostic/delayed_job_workers_spec.rb +8 -8
  165. data/spec/other/diagnostic/reporter_spec.rb +31 -33
  166. data/spec/spec_helper.rb +5 -5
  167. data/spec/support/chromedriver.rb +3 -5
  168. data/spec/support/components/netzke_combobox.rb +1 -1
  169. data/spec/support/components/netzke_grid.rb +17 -17
  170. data/spec/support/custom_matchers.rb +2 -2
  171. data/spec/support/download_helper.rb +1 -1
  172. data/spec/support/helper.rb +1 -2
  173. data/spec/support/netzke.rb +31 -31
  174. data/spec/support/performance_helper.rb +8 -8
  175. data/spec/support/post_run_logger.rb +1 -2
  176. data/spec/support/setup.rb +1 -4
  177. data/spec/support/shared_connection.rb +2 -2
  178. data/spec/support/structure_compare.rb +21 -22
  179. data/spec/support/suite.rb +1 -2
  180. data/spec/support/users.rb +5 -6
  181. metadata +32 -26
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA256:
3
- metadata.gz: 0e2ef16fafc3a32c5dec5c48aa505d4276c14add9e68c29d9842e3f5dcb39b00
4
- data.tar.gz: 3b7e63e047f6cce70265292b02b2036fd6a9475953f84a3d12a4e1a8759e876e
2
+ SHA1:
3
+ metadata.gz: 53eaa6a1c747d6de4678a9cb296ed875b104248a
4
+ data.tar.gz: c4802cc1fe02de8dbc8b815cff1f9bca82cd62d0
5
5
  SHA512:
6
- metadata.gz: 9880d63476cb87bb29639f55f4dbb2af530d458defa1308122da189dfc83f1d1b43784ab662ca819b35afb493b079b3e1de8bb6f3e793ff74d007547ecf60a7c
7
- data.tar.gz: ae50272cbdc9bde5f4217a0d7bb7ebb2d3d66e8a2df7529704e5d01bb432e8cc119f3cfaeb30b4b6faad190f1adf6819bcec018382885f46773af80c33400490
6
+ metadata.gz: acae0b97b8e531aec9b83fe55017df4f8198623e6730bc20032727f748d3bf4ffcd096f6c99098cde698a75c502f26aa31a315d3c63974c956966376b4dc8f59
7
+ data.tar.gz: 0bb663290959c749e9e8e5a37100fb77949c3b66231d979f149cc21b3f94b173d3f83ffc2d6a3e4235ca278ca2bc7ca770fe6f5092936d53e8d5a6abcb611f3b
data/.gitignore CHANGED
@@ -27,3 +27,7 @@ spec/dummy/.sass-cache
27
27
  /spec/dummy/public/extjs
28
28
  .rspec
29
29
  .rspec-results
30
+
31
+ # Files with command history for docker
32
+ .bash_history.docker
33
+ .pry_history.docker
@@ -1,6 +1,7 @@
1
1
  inherit_from: .rubocop_todo.yml
2
2
 
3
3
  AllCops:
4
+ TargetRubyVersion: 2.3.3
4
5
  Exclude:
5
6
  - 'db/**/*'
6
7
  - 'spec/dummy/**/*'
@@ -9,3 +10,9 @@ AllCops:
9
10
  - 'lib/tasks/marty_tasks.rake'
10
11
  - !ruby/regexp /old_and_unused\.rb$/
11
12
 
13
+ Layout/DotPosition:
14
+ EnforcedStyle: 'trailing'
15
+
16
+ Style/StringLiterals:
17
+ Enabled: true
18
+ EnforcedStyle: single_quotes
@@ -6,42 +6,6 @@
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 7
10
- # Cop supports --auto-correct.
11
- # Configuration parameters: TreatCommentsAsGroupSeparators, Include.
12
- # Include: **/*.gemfile, **/Gemfile, **/gems.rb
13
- Bundler/OrderedGems:
14
- Exclude:
15
- - 'Gemfile'
16
-
17
- # Offense count: 2
18
- # Cop supports --auto-correct.
19
- # Configuration parameters: TreatCommentsAsGroupSeparators, Include.
20
- # Include: **/*.gemspec
21
- Gemspec/OrderedDependencies:
22
- Exclude:
23
- - 'marty.gemspec'
24
-
25
- # Offense count: 4
26
- # Cop supports --auto-correct.
27
- # Configuration parameters: EnforcedStyle, IndentationWidth.
28
- # SupportedStyles: outdent, indent
29
- Layout/AccessModifierIndentation:
30
- Exclude:
31
- - 'app/components/marty/mcfly_grid_panel.rb'
32
- - 'app/models/marty/token.rb'
33
- - 'app/models/marty/user.rb'
34
- - 'spec/dummy/app/models/gemini/extras/settlement_import.rb'
35
-
36
- # Offense count: 18
37
- # Cop supports --auto-correct.
38
- Layout/AlignArray:
39
- Exclude:
40
- - 'app/components/marty/user_view.rb'
41
- - 'db/migrate/201_create_marty_events.rb'
42
- - 'lib/marty/monkey.rb'
43
- - 'spec/models/rule_spec.rb'
44
-
45
9
  # Offense count: 526
46
10
  # Cop supports --auto-correct.
47
11
  # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
@@ -51,44 +15,6 @@ Layout/AlignArray:
51
15
  Layout/AlignHash:
52
16
  Enabled: false
53
17
 
54
- # Offense count: 39
55
- # Cop supports --auto-correct.
56
- # Configuration parameters: EnforcedStyle, IndentationWidth.
57
- # SupportedStyles: with_first_parameter, with_fixed_indentation
58
- Layout/AlignParameters:
59
- Enabled: false
60
-
61
- # Offense count: 9
62
- # Cop supports --auto-correct.
63
- # Configuration parameters: EnforcedStyleAlignWith.
64
- # SupportedStylesAlignWith: either, start_of_block, start_of_line
65
- Layout/BlockAlignment:
66
- Exclude:
67
- - 'app/components/marty/mcfly_grid_panel.rb'
68
- - 'lib/marty/schema_helper.rb'
69
- - 'spec/features/log_view_spec.rb'
70
- - 'spec/features/reporting_spec.rb'
71
- - 'spec/features/scripting_test_spec.rb'
72
- - 'spec/lib/mcfly_model_spec.rb'
73
-
74
- # Offense count: 32
75
- # Cop supports --auto-correct.
76
- Layout/BlockEndNewline:
77
- Exclude:
78
- - 'app/components/marty/api_log_view.rb'
79
- - 'app/components/marty/config_view.rb'
80
- - 'app/components/marty/log_view.rb'
81
- - 'app/models/marty/delorean_rule.rb'
82
- - 'lib/marty/monkey.rb'
83
- - 'other/marty/diagnostic/connections.rb'
84
- - 'other/marty/diagnostic/environment_variables.rb'
85
- - 'spec/lib/mcfly_model_spec.rb'
86
- - 'spec/models/data_grid_spec.rb'
87
- - 'spec/models/event_spec.rb'
88
- - 'spec/models/rule_spec.rb'
89
- - 'spec/models/script_spec.rb'
90
- - 'spec/support/structure_compare.rb'
91
-
92
18
  # Offense count: 2
93
19
  # Cop supports --auto-correct.
94
20
  # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
@@ -105,180 +31,6 @@ Layout/ClosingHeredocIndentation:
105
31
  - 'spec/support/components/netzke_combobox.rb'
106
32
  - 'spec/support/components/netzke_grid.rb'
107
33
 
108
- # Offense count: 38
109
- # Cop supports --auto-correct.
110
- Layout/ClosingParenthesisIndentation:
111
- Exclude:
112
- - 'app/components/marty/base_rule_view.rb'
113
- - 'app/components/marty/report_form.rb'
114
- - 'app/components/marty/report_select.rb'
115
- - 'app/components/marty/script_tester.rb'
116
- - 'app/controllers/marty/job_controller.rb'
117
- - 'app/models/marty/data_grid.rb'
118
- - 'lib/marty/data_change.rb'
119
- - 'lib/marty/data_importer.rb'
120
- - 'lib/marty/migrations.rb'
121
- - 'lib/marty/promise_job.rb'
122
- - 'spec/controllers/job_controller_spec.rb'
123
- - 'spec/dummy/app/components/gemini/my_rule_view.rb'
124
- - 'spec/lib/data_importer_spec.rb'
125
- - 'spec/models/data_grid_spec.rb'
126
- - 'spec/models/rule_spec.rb'
127
-
128
- # Offense count: 7
129
- # Cop supports --auto-correct.
130
- Layout/CommentIndentation:
131
- Exclude:
132
- - 'app/components/marty/base_rule_view.rb'
133
- - 'app/models/marty/data_grid.rb'
134
- - 'app/models/marty/token.rb'
135
- - 'spec/dummy/db/schema.rb'
136
-
137
- # Offense count: 2
138
- # Cop supports --auto-correct.
139
- # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
140
- # SupportedStylesAlignWith: start_of_line, def
141
- Layout/DefEndAlignment:
142
- Exclude:
143
- - 'spec/dummy/db/migrate/20171221095312_create_gemini_my_rules.rb'
144
- - 'spec/dummy/db/migrate/20171221095359_create_gemini_xyz_rules.rb'
145
-
146
- # Offense count: 218
147
- # Cop supports --auto-correct.
148
- # Configuration parameters: EnforcedStyle.
149
- # SupportedStyles: leading, trailing
150
- Layout/DotPosition:
151
- Enabled: false
152
-
153
- # Offense count: 6
154
- # Cop supports --auto-correct.
155
- # Configuration parameters: AllowBorderComment, AllowMarginComment.
156
- Layout/EmptyComment:
157
- Exclude:
158
- - 'spec/lib/json_schema_spec.rb'
159
-
160
- # Offense count: 64
161
- # Cop supports --auto-correct.
162
- Layout/EmptyLineAfterGuardClause:
163
- Enabled: false
164
-
165
- # Offense count: 39
166
- # Cop supports --auto-correct.
167
- # Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
168
- Layout/EmptyLineBetweenDefs:
169
- Exclude:
170
- - 'app/components/marty/base_rule_view.rb'
171
- - 'app/components/marty/import_view.rb'
172
- - 'app/models/marty/base_rule.rb'
173
- - 'app/models/marty/data_grid.rb'
174
- - 'app/models/marty/delorean_rule.rb'
175
- - 'db/migrate/411_create_vw_promises.rb'
176
- - 'lib/marty/rule_script_set.rb'
177
- - 'other/marty/diagnostic/node.rb'
178
- - 'spec/dummy/app/components/gemini/my_rule_view.rb'
179
- - 'spec/dummy/app/models/gemini/my_rule.rb'
180
- - 'spec/dummy/app/models/gemini/xyz_rule.rb'
181
- - 'spec/dummy/lib/gemini/xyz_rule_script_set.rb'
182
- - 'spec/dummy/public/extjs/classic/theme-base/sass/utils.rb'
183
- - 'spec/features/rule_spec.rb'
184
- - 'spec/support/structure_compare.rb'
185
-
186
- # Offense count: 17
187
- # Cop supports --auto-correct.
188
- Layout/EmptyLines:
189
- Exclude:
190
- - 'Rakefile'
191
- - 'app/models/marty/api_auth.rb'
192
- - 'lib/marty/monkey.rb'
193
- - 'lib/marty/promise_job.rb'
194
- - 'lib/marty/schema_helper.rb'
195
- - 'other/marty/diagnostic/node.rb'
196
- - 'spec/controllers/rpc_controller_spec.rb'
197
- - 'spec/controllers/rpc_import_spec.rb'
198
- - 'spec/features/enum_spec.rb'
199
- - 'spec/features/scripting_spec.rb'
200
- - 'spec/lib/json_schema_spec.rb'
201
- - 'spec/lib/xl_spec.rb'
202
- - 'spec/lib/xl_styles_spec.rb'
203
- - 'spec/models/event_spec.rb'
204
-
205
- # Offense count: 12
206
- # Cop supports --auto-correct.
207
- Layout/EmptyLinesAroundAccessModifier:
208
- Exclude:
209
- - 'app/components/marty/mcfly_grid_panel.rb'
210
- - 'app/controllers/marty/rpc_controller.rb'
211
- - 'app/models/marty/data_grid.rb'
212
- - 'app/models/marty/token.rb'
213
- - 'app/models/marty/user.rb'
214
- - 'lib/marty/aws/base.rb'
215
- - 'lib/marty/json_schema.rb'
216
- - 'lib/marty/migrations.rb'
217
- - 'other/marty/diagnostic/aws/ec2_instance.rb'
218
- - 'other/marty/diagnostic/reporter.rb'
219
- - 'spec/dummy/app/models/gemini/extras/settlement_import.rb'
220
- - 'spec/support/netzke.rb'
221
-
222
- # Offense count: 2
223
- # Cop supports --auto-correct.
224
- Layout/EmptyLinesAroundArguments:
225
- Exclude:
226
- - 'lib/marty/aws/base.rb'
227
- - 'spec/dummy/app/models/gemini/enum_state.rb'
228
-
229
- # Offense count: 42
230
- # Cop supports --auto-correct.
231
- # Configuration parameters: EnforcedStyle.
232
- # SupportedStyles: empty_lines, no_empty_lines
233
- Layout/EmptyLinesAroundBlockBody:
234
- Enabled: false
235
-
236
- # Offense count: 27
237
- # Cop supports --auto-correct.
238
- # Configuration parameters: EnforcedStyle.
239
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
240
- Layout/EmptyLinesAroundClassBody:
241
- Enabled: false
242
-
243
- # Offense count: 5
244
- # Cop supports --auto-correct.
245
- Layout/EmptyLinesAroundExceptionHandlingKeywords:
246
- Exclude:
247
- - 'app/components/marty/import_view.rb'
248
- - 'app/components/marty/report_form.rb'
249
- - 'app/components/marty/script_tester.rb'
250
- - 'other/marty/api/base.rb'
251
-
252
- # Offense count: 9
253
- # Cop supports --auto-correct.
254
- Layout/EmptyLinesAroundMethodBody:
255
- Exclude:
256
- - 'app/models/marty/base_rule.rb'
257
- - 'app/models/marty/data_grid.rb'
258
- - 'lib/marty/data_conversion.rb'
259
- - 'lib/marty/json_schema.rb'
260
- - 'lib/marty/mcfly_model.rb'
261
- - 'lib/marty/promise_job.rb'
262
- - 'lib/marty/xl.rb'
263
- - 'spec/controllers/rpc_controller_spec.rb'
264
- - 'spec/support/users.rb'
265
-
266
- # Offense count: 10
267
- # Cop supports --auto-correct.
268
- # Configuration parameters: EnforcedStyle.
269
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
270
- Layout/EmptyLinesAroundModuleBody:
271
- Exclude:
272
- - 'app/models/marty/pg_enum.rb'
273
- - 'lib/marty/json_schema.rb'
274
- - 'spec/lib/data_exporter_spec.rb'
275
- - 'spec/lib/data_importer_spec.rb'
276
- - 'spec/lib/delorean_query_spec.rb'
277
- - 'spec/lib/json_schema_spec.rb'
278
- - 'spec/lib/mcfly_model_spec.rb'
279
- - 'spec/support/chromedriver.rb'
280
- - 'spec/support/setup.rb'
281
-
282
34
  # Offense count: 56
283
35
  # Cop supports --auto-correct.
284
36
  # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
@@ -292,32 +44,6 @@ Layout/EndAlignment:
292
44
  Layout/ExtraSpacing:
293
45
  Enabled: false
294
46
 
295
- # Offense count: 44
296
- # Cop supports --auto-correct.
297
- # Configuration parameters: EnforcedStyle, IndentationWidth.
298
- # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
299
- Layout/FirstParameterIndentation:
300
- Enabled: false
301
-
302
- # Offense count: 42
303
- # Cop supports --auto-correct.
304
- # Configuration parameters: EnforcedStyle, IndentationWidth.
305
- # SupportedStyles: special_inside_parentheses, consistent, align_brackets
306
- Layout/IndentArray:
307
- Enabled: false
308
-
309
- # Offense count: 7
310
- # Cop supports --auto-correct.
311
- # Configuration parameters: IndentationWidth.
312
- Layout/IndentAssignment:
313
- Exclude:
314
- - 'app/controllers/marty/report_controller.rb'
315
- - 'app/models/marty/data_grid.rb'
316
- - 'app/models/marty/delorean_rule.rb'
317
- - 'lib/marty/xl.rb'
318
- - 'other/marty/api/base.rb'
319
- - 'spec/lib/data_importer_spec.rb'
320
-
321
47
  # Offense count: 136
322
48
  # Cop supports --auto-correct.
323
49
  # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -344,61 +70,12 @@ Layout/IndentHash:
344
70
  Layout/IndentHeredoc:
345
71
  Enabled: false
346
72
 
347
- # Offense count: 25
348
- # Cop supports --auto-correct.
349
- # Configuration parameters: EnforcedStyle.
350
- # SupportedStyles: normal, rails
351
- Layout/IndentationConsistency:
352
- Exclude:
353
- - 'app/components/marty/config_view.rb'
354
- - 'app/models/marty/data_grid.rb'
355
- - 'app/models/marty/user.rb'
356
- - 'spec/features/log_view_spec.rb'
357
- - 'spec/features/reporting_spec.rb'
358
- - 'spec/features/scripting_test_spec.rb'
359
- - 'spec/lib/data_exporter_spec.rb'
360
- - 'spec/lib/data_importer_spec.rb'
361
- - 'spec/lib/delorean_query_spec.rb'
362
- - 'spec/lib/mcfly_model_spec.rb'
363
- - 'spec/models/data_grid_spec.rb'
364
- - 'spec/other/diagnostic/reporter_spec.rb'
365
-
366
73
  # Offense count: 230
367
74
  # Cop supports --auto-correct.
368
75
  # Configuration parameters: Width, IgnoredPatterns.
369
76
  Layout/IndentationWidth:
370
77
  Enabled: false
371
78
 
372
- # Offense count: 23
373
- # Cop supports --auto-correct.
374
- Layout/LeadingCommentSpace:
375
- Enabled: false
376
-
377
- # Offense count: 15
378
- # Cop supports --auto-correct.
379
- # Configuration parameters: EnforcedStyle.
380
- # SupportedStyles: symmetrical, new_line, same_line
381
- Layout/MultilineArrayBraceLayout:
382
- Exclude:
383
- - 'app/components/marty/api_config_view.rb'
384
- - 'app/components/marty/report_form.rb'
385
- - 'lib/marty/data_conversion.rb'
386
- - 'lib/marty/monkey.rb'
387
- - 'lib/marty/schema_helper.rb'
388
- - 'other/marty/diagnostic/environment_variables.rb'
389
- - 'spec/dummy/app/models/gemini/fannie_bup.rb'
390
- - 'spec/dummy/app/models/gemini/streamline_type.rb'
391
- - 'spec/dummy/db/migrate/20171222150100_add_rule_indices.rb'
392
- - 'spec/features/log_view_spec.rb'
393
- - 'spec/lib/data_importer_spec.rb'
394
- - 'spec/models/event_spec.rb'
395
- - 'spec/support/suite.rb'
396
-
397
- # Offense count: 160
398
- # Cop supports --auto-correct.
399
- Layout/MultilineBlockLayout:
400
- Enabled: false
401
-
402
79
  # Offense count: 44
403
80
  # Cop supports --auto-correct.
404
81
  # Configuration parameters: EnforcedStyle.
@@ -447,126 +124,6 @@ Layout/MultilineOperationIndentation:
447
124
  - 'spec/models/script_spec.rb'
448
125
  - 'spec/support/shared_connection.rb'
449
126
 
450
- # Offense count: 4
451
- # Cop supports --auto-correct.
452
- Layout/SpaceAfterColon:
453
- Exclude:
454
- - 'app/models/marty/helper.rb'
455
- - 'lib/marty/aws/request.rb'
456
- - 'spec/controllers/rpc_controller_spec.rb'
457
-
458
- # Offense count: 165
459
- # Cop supports --auto-correct.
460
- Layout/SpaceAfterComma:
461
- Enabled: false
462
-
463
- # Offense count: 13
464
- # Cop supports --auto-correct.
465
- # Configuration parameters: EnforcedStyleInsidePipes.
466
- # SupportedStylesInsidePipes: space, no_space
467
- Layout/SpaceAroundBlockParameters:
468
- Exclude:
469
- - 'app/components/marty/base_rule_view.rb'
470
- - 'app/models/marty/delorean_rule.rb'
471
- - 'lib/marty/rule_script_set.rb'
472
- - 'spec/dummy/app/models/gemini/xyz_rule.rb'
473
- - 'spec/dummy/lib/gemini/xyz_rule_script_set.rb'
474
- - 'spec/features/rule_spec.rb'
475
- - 'spec/models/rule_spec.rb'
476
- - 'spec/support/custom_matchers.rb'
477
-
478
- # Offense count: 108
479
- # Cop supports --auto-correct.
480
- # Configuration parameters: EnforcedStyle.
481
- # SupportedStyles: space, no_space
482
- Layout/SpaceAroundEqualsInParameterDefault:
483
- Enabled: false
484
-
485
- # Offense count: 4
486
- # Cop supports --auto-correct.
487
- Layout/SpaceAroundKeyword:
488
- Exclude:
489
- - 'lib/marty/json_schema.rb'
490
- - 'spec/dummy/public/extjs/classic/theme-base/sass/overrides.rb'
491
-
492
- # Offense count: 696
493
- # Cop supports --auto-correct.
494
- # Configuration parameters: AllowForAlignment.
495
- Layout/SpaceAroundOperators:
496
- Enabled: false
497
-
498
- # Offense count: 116
499
- # Cop supports --auto-correct.
500
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
501
- # SupportedStyles: space, no_space
502
- # SupportedStylesForEmptyBraces: space, no_space
503
- Layout/SpaceBeforeBlockBraces:
504
- Enabled: false
505
-
506
- # Offense count: 3
507
- # Cop supports --auto-correct.
508
- Layout/SpaceBeforeComma:
509
- Exclude:
510
- - 'other/marty/api/base.rb'
511
- - 'spec/models/posting_spec.rb'
512
-
513
- # Offense count: 146
514
- # Cop supports --auto-correct.
515
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
516
- # SupportedStyles: space, no_space, compact
517
- # SupportedStylesForEmptyBrackets: space, no_space
518
- Layout/SpaceInsideArrayLiteralBrackets:
519
- Exclude:
520
- - 'lib/marty/data_exporter.rb'
521
- - 'lib/marty/xl.rb'
522
- - 'spec/dummy/db/seeds.rb'
523
- - 'spec/features/log_view_spec.rb'
524
- - 'spec/lib/json_schema_spec.rb'
525
-
526
- # Offense count: 356
527
- # Cop supports --auto-correct.
528
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
529
- # SupportedStyles: space, no_space
530
- # SupportedStylesForEmptyBraces: space, no_space
531
- Layout/SpaceInsideBlockBraces:
532
- Enabled: false
533
-
534
- # Offense count: 1027
535
- # Cop supports --auto-correct.
536
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
537
- # SupportedStyles: space, no_space, compact
538
- # SupportedStylesForEmptyBraces: space, no_space
539
- Layout/SpaceInsideHashLiteralBraces:
540
- Enabled: false
541
-
542
- # Offense count: 5
543
- # Cop supports --auto-correct.
544
- # Configuration parameters: EnforcedStyle.
545
- # SupportedStyles: space, no_space
546
- Layout/SpaceInsideParens:
547
- Exclude:
548
- - 'app/models/marty/posting.rb'
549
- - 'lib/marty/xl.rb'
550
- - 'spec/models/data_grid_spec.rb'
551
-
552
- # Offense count: 6
553
- # Cop supports --auto-correct.
554
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
555
- # SupportedStyles: space, no_space
556
- # SupportedStylesForEmptyBrackets: space, no_space
557
- Layout/SpaceInsideReferenceBrackets:
558
- Exclude:
559
- - 'lib/marty/data_conversion.rb'
560
- - 'lib/marty/data_exporter.rb'
561
- - 'lib/marty/permissions.rb'
562
-
563
- # Offense count: 1
564
- # Cop supports --auto-correct.
565
- # Configuration parameters: EnforcedStyle.
566
- # SupportedStyles: space, no_space
567
- Layout/SpaceInsideStringInterpolation:
568
- Exclude:
569
- - 'spec/dummy/app/models/gemini/extras/settlement_import.rb'
570
127
 
571
128
  # Offense count: 11
572
129
  # Cop supports --auto-correct.
@@ -800,7 +357,7 @@ Metrics/MethodLength:
800
357
  # Offense count: 12
801
358
  # Configuration parameters: CountComments.
802
359
  Metrics/ModuleLength:
803
- Max: 675
360
+ Max: 690
804
361
 
805
362
  # Offense count: 13
806
363
  # Configuration parameters: CountKeywordArgs.
@@ -1018,23 +575,6 @@ Style/BarePercentLiterals:
1018
575
  - 'spec/models/config_spec.rb'
1019
576
  - 'spec/support/netzke.rb'
1020
577
 
1021
- # Offense count: 155
1022
- # Cop supports --auto-correct.
1023
- # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
1024
- # SupportedStyles: line_count_based, semantic, braces_for_chaining
1025
- # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
1026
- # FunctionalMethods: let, let!, subject, watch
1027
- # IgnoredMethods: lambda, proc, it
1028
- Style/BlockDelimiters:
1029
- Enabled: false
1030
-
1031
- # Offense count: 126
1032
- # Cop supports --auto-correct.
1033
- # Configuration parameters: EnforcedStyle.
1034
- # SupportedStyles: braces, no_braces, context_dependent
1035
- Style/BracesAroundHashParameters:
1036
- Enabled: false
1037
-
1038
578
  # Offense count: 21
1039
579
  Style/CaseEquality:
1040
580
  Exclude:
@@ -1524,22 +1064,6 @@ Style/PerlBackrefs:
1524
1064
  Exclude:
1525
1065
  - 'lib/marty/migrations.rb'
1526
1066
 
1527
- # Offense count: 3
1528
- # Cop supports --auto-correct.
1529
- # Configuration parameters: EnforcedStyle.
1530
- # SupportedStyles: short, verbose
1531
- Style/PreferredHashMethods:
1532
- Exclude:
1533
- - 'app/models/marty/script.rb'
1534
- - 'lib/marty/data_conversion.rb'
1535
- - 'lib/marty/monkey.rb'
1536
-
1537
- # Offense count: 1
1538
- # Cop supports --auto-correct.
1539
- Style/Proc:
1540
- Exclude:
1541
- - 'app/models/marty/delorean_rule.rb'
1542
-
1543
1067
  # Offense count: 6
1544
1068
  # Cop supports --auto-correct.
1545
1069
  # Configuration parameters: EnforcedStyle.
@@ -1550,54 +1074,6 @@ Style/RaiseArgs:
1550
1074
  - 'spec/dummy/public/extjs/classic/theme-base/sass/overrides.rb'
1551
1075
  - 'spec/dummy/public/extjs/classic/theme-base/sass/utils.rb'
1552
1076
 
1553
- # Offense count: 1
1554
- # Cop supports --auto-correct.
1555
- Style/RandomWithOffset:
1556
- Exclude:
1557
- - 'spec/models/data_grid_spec.rb'
1558
-
1559
- # Offense count: 16
1560
- # Cop supports --auto-correct.
1561
- Style/RedundantBegin:
1562
- Exclude:
1563
- - 'app/controllers/marty/diagnostic/controller.rb'
1564
- - 'app/controllers/marty/rpc_controller.rb'
1565
- - 'app/models/marty/data_grid.rb'
1566
- - 'app/models/marty/delorean_rule.rb'
1567
- - 'app/models/marty/event.rb'
1568
- - 'app/models/marty/promise.rb'
1569
- - 'lib/marty/json_schema.rb'
1570
- - 'lib/marty/logger.rb'
1571
- - 'lib/marty/rule_script_set.rb'
1572
- - 'other/marty/api/base.rb'
1573
- - 'other/marty/diagnostic/node.rb'
1574
- - 'other/marty/diagnostic/version.rb'
1575
- - 'spec/other/diagnostic/reporter_spec.rb'
1576
- - 'spec/support/setup.rb'
1577
- - 'spec/support/structure_compare.rb'
1578
-
1579
- # Offense count: 6
1580
- # Cop supports --auto-correct.
1581
- Style/RedundantParentheses:
1582
- Exclude:
1583
- - 'spec/models/data_grid_spec.rb'
1584
-
1585
- # Offense count: 6
1586
- # Cop supports --auto-correct.
1587
- # Configuration parameters: AllowMultipleReturnValues.
1588
- Style/RedundantReturn:
1589
- Exclude:
1590
- - 'app/controllers/marty/report_controller.rb'
1591
- - 'lib/marty/content_handler.rb'
1592
- - 'spec/dummy/public/extjs/classic/theme-base/sass/utils.rb'
1593
- - 'spec/dummy/public/extjs/modern/theme-base/sass/utils.rb'
1594
- - 'spec/support/components/netzke_grid.rb'
1595
-
1596
- # Offense count: 79
1597
- # Cop supports --auto-correct.
1598
- Style/RedundantSelf:
1599
- Enabled: false
1600
-
1601
1077
  # Offense count: 6
1602
1078
  # Cop supports --auto-correct.
1603
1079
  # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -1616,13 +1092,6 @@ Style/RegexpLiteral:
1616
1092
  Style/RescueModifier:
1617
1093
  Enabled: false
1618
1094
 
1619
- # Offense count: 61
1620
- # Cop supports --auto-correct.
1621
- # Configuration parameters: EnforcedStyle.
1622
- # SupportedStyles: implicit, explicit
1623
- Style/RescueStandardError:
1624
- Enabled: false
1625
-
1626
1095
  # Offense count: 6
1627
1096
  # Cop supports --auto-correct.
1628
1097
  # Configuration parameters: AllowAsExpressionSeparator.
@@ -1641,13 +1110,6 @@ Style/Semicolon:
1641
1110
  Style/SpecialGlobalVars:
1642
1111
  EnforcedStyle: use_perl_names
1643
1112
 
1644
- # Offense count: 4433
1645
- # Cop supports --auto-correct.
1646
- # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
1647
- # SupportedStyles: single_quotes, double_quotes
1648
- Style/StringLiterals:
1649
- Enabled: false
1650
-
1651
1113
  # Offense count: 1
1652
1114
  # Cop supports --auto-correct.
1653
1115
  # Configuration parameters: EnforcedStyle.
@@ -1668,22 +1130,6 @@ Style/StructInheritance:
1668
1130
  Style/SymbolArray:
1669
1131
  EnforcedStyle: brackets
1670
1132
 
1671
- # Offense count: 36
1672
- # Cop supports --auto-correct.
1673
- # Configuration parameters: IgnoredMethods.
1674
- # IgnoredMethods: respond_to, define_method
1675
- Style/SymbolProc:
1676
- Exclude:
1677
- - 'app/components/marty/base_rule_view.rb'
1678
- - 'app/models/marty/posting.rb'
1679
- - 'other/marty/diagnostic/collection.rb'
1680
- - 'other/marty/diagnostic/node.rb'
1681
- - 'spec/lib/xl_spec.rb'
1682
- - 'spec/lib/xl_styles_spec.rb'
1683
- - 'spec/models/rule_spec.rb'
1684
- - 'spec/other/diagnostic/collection_spec.rb'
1685
- - 'spec/support/performance_helper.rb'
1686
-
1687
1133
  # Offense count: 7
1688
1134
  # Cop supports --auto-correct.
1689
1135
  # Configuration parameters: EnforcedStyle, AllowSafeAssignment.
@@ -1721,24 +1167,6 @@ Style/TrailingCommaInArrayLiteral:
1721
1167
  Style/TrailingCommaInHashLiteral:
1722
1168
  Enabled: false
1723
1169
 
1724
- # Offense count: 2
1725
- # Cop supports --auto-correct.
1726
- Style/UnlessElse:
1727
- Exclude:
1728
- - 'lib/marty/xl.rb'
1729
- - 'spec/dummy/public/extjs/classic/theme-base/sass/overrides.rb'
1730
-
1731
- # Offense count: 8
1732
- # Cop supports --auto-correct.
1733
- Style/UnneededInterpolation:
1734
- Exclude:
1735
- - 'app/components/marty/main_auth_app.rb'
1736
- - 'lib/marty/rule_script_set.rb'
1737
- - 'spec/controllers/job_controller_spec.rb'
1738
- - 'spec/dummy/public/extjs/classic/theme-base/sass/utils.rb'
1739
- - 'spec/dummy/public/extjs/modern/theme-base/sass/utils.rb'
1740
- - 'spec/support/netzke.rb'
1741
-
1742
1170
  # Offense count: 12
1743
1171
  # Cop supports --auto-correct.
1744
1172
  Style/UnneededPercentQ:
@@ -1747,12 +1175,6 @@ Style/UnneededPercentQ:
1747
1175
  - 'spec/features/rule_spec.rb'
1748
1176
  - 'spec/models/config_spec.rb'
1749
1177
 
1750
- # Offense count: 1
1751
- # Cop supports --auto-correct.
1752
- Style/WhileUntilDo:
1753
- Exclude:
1754
- - 'app/models/marty/promise.rb'
1755
-
1756
1178
  # Offense count: 133
1757
1179
  # Cop supports --auto-correct.
1758
1180
  # Configuration parameters: WordRegex.
@@ -1761,17 +1183,17 @@ Style/WordArray:
1761
1183
  EnforcedStyle: percent
1762
1184
  MinSize: 18
1763
1185
 
1764
- # Offense count: 5
1765
- # Cop supports --auto-correct.
1766
- Style/ZeroLengthPredicate:
1767
- Exclude:
1768
- - 'app/components/marty/main_auth_app.rb'
1769
- - 'app/models/marty/data_grid.rb'
1770
- - 'app/models/marty/vw_promise.rb'
1771
- - 'lib/marty/permissions.rb'
1772
-
1773
1186
  # Offense count: 247
1774
1187
  # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
1775
1188
  # URISchemes: http, https
1776
1189
  Metrics/LineLength:
1777
- Max: 275
1190
+ Max: 100
1191
+
1192
+ Style/FrozenStringLiteralComment:
1193
+ Enabled: false
1194
+
1195
+ Style/SafeNavigation:
1196
+ Enabled: false
1197
+
1198
+ Style/NumericPredicate:
1199
+ Enabled: false