marty 2.5.2 → 2.5.4

data/spec/features/scripting_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 feature 'under Applications menu, Scripting workflows', js: true do
-
   before(:all) do
     self.use_transactional_tests = false
 
@@ -41,27 +40,26 @@ feature 'under Applications menu, Scripting workflows', js: true do
   def populate_test_scripts
     lastid = nil
 
-    with_user("dev2") {
-
+    with_user('dev2') do
       Marty::Script.
         load_script_bodies({
-                             "A1" => "#1\n",
-                             "A2" => "#2\n",
-                             "A3" => "#3\n",
-                             "A4" => "#4\n",
-                             "A5" => "#5\n",
+                             'A1' => "#1\n",
+                             'A2' => "#2\n",
+                             'A3' => "#3\n",
+                             'A4' => "#4\n",
+                             'A5' => "#5\n",
                            }, Date.today)
 
       # create 3 additional tags and modify A5 in the process
-      (1..3).each { |i|
-        body = Marty::Script.find_by(name: "A5").body
+      (1..3).each do |i|
+        body = Marty::Script.find_by(name: 'A5').body
 
         Marty::Script.
           load_script_bodies({
-                               "A5" => body + "##{i}\n"
+                               'A5' => body + "##{i}\n"
                              }, Date.today + i.minute)
-      }
-    }
+      end
+    end
   end
 
   it 'adding scripts and tags & ensure proper validations' do
@@ -87,7 +85,7 @@ feature 'under Applications menu, Scripting workflows', js: true do
     and_by 'select the new script' do
       wait_for_ajax
       within(:gridpanel, 'script_grid', match: :first) do
-        expect(script_grid.get_row_vals(6)).to netzke_include({:name=>"Xyz", :tag=>"DEV"})
+        expect(script_grid.get_row_vals(6)).to netzke_include(:name => 'Xyz', :tag => 'DEV')
         script_grid.select_row(6)
       end
     end
@@ -211,7 +209,6 @@ feature 'under Applications menu, Scripting workflows', js: true do
     script_grid = netzke_find('script_grid')
     tag_grid = netzke_find('tag_grid')
 
-
     by 'select tag row 2' do
       wait_for_ajax
       tag_grid.select_row(2)
@@ -224,7 +221,7 @@ feature 'under Applications menu, Scripting workflows', js: true do
 
     and_by 'form displays correct body' do
       wait_for_ajax
-      expect(page).to have_content "1 #5 2 #1 3 #2 4 #3"
+      expect(page).to have_content '1 #5 2 #1 3 #2 4 #3'
     end
 
     and_by 'select different tag' do
@@ -238,7 +235,7 @@ feature 'under Applications menu, Scripting workflows', js: true do
 
     and_by 'form displays updated body' do
       wait_for_ajax
-      expect(page).to have_content "1 #5 2 #1"
+      expect(page).to have_content '1 #5 2 #1'
     end
   end
 
@@ -274,7 +271,7 @@ feature 'under Applications menu, Scripting workflows', js: true do
       script_grid.select_row(1)
       script_grid.select_row(5)
       wait_for_ajax
-      expect(page).not_to have_content "1 #123 2 #456"
+      expect(page).not_to have_content '1 #123 2 #456'
       script_grid.select_row(1)
     end
 
@@ -291,8 +288,8 @@ feature 'under Applications menu, Scripting workflows', js: true do
       tag_grid.select_row(2)
       wait_for_ajax
       script_grid.select_row(5)
-      expect(page).to have_content "1 #123 2 #456"
-      expect(tag_grid.get_row_vals(2)).to netzke_include({:comment=>"ABCD"})
+      expect(page).to have_content '1 #123 2 #456'
+      expect(tag_grid.get_row_vals(2)).to netzke_include(:comment => 'ABCD')
     end
   end
 

data/spec/features/scripting_test_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 feature 'under Applications menu, Scripting (debug) workflows', js: true do
-
   before(:all) do
     @clean_file = "/tmp/clean_#{Process.pid}.psql"
     save_clean_db(@clean_file)
@@ -46,18 +45,18 @@ C:
     a = 456.0 + p0
 DELOREAN
 
-    with_user("dev1") { |u|
+    with_user('dev1') do |u|
       Marty::Script.
         load_script_bodies({
-                             "M1" => sample_script,
-                             "M2" => sample_script.gsub(/a/, "aa").gsub(/b/, "bb"),
+                             'M1' => sample_script,
+                             'M2' => sample_script.gsub(/a/, 'aa').gsub(/b/, 'bb'),
                            }, Date.today)
 
       # add a DEV version of M1.
-      s = Marty::Script.find_by(obsoleted_dt: 'infinity', name: "M1")
-      s.body = sample_script.gsub(/A/, "AA") + '    e =? "hello"'
+      s = Marty::Script.find_by(obsoleted_dt: 'infinity', name: 'M1')
+      s.body = sample_script.gsub(/A/, 'AA') + '    e =? "hello"'
       s.save!
-    }
+    end
   end
 
   def populate_sample_scripts2
@@ -75,16 +74,16 @@ B: A
     p =? 5
 DELOREAN
 
-    with_user("dev1") { |u|
+    with_user('dev1') do |u|
       Marty::Script.
         load_script_bodies({
-                             "M3" => sample_script2,
+                             'M3' => sample_script2,
                            }, Date.today + 2.minute)
-    }
+    end
   end
 
   def tab_press tab_text
-    #we need a separate method for tab clicks
+    # we need a separate method for tab clicks
     wait_for_element do
         find_by_id(ext_button_id(tab_text), visible: :all).click
         true
@@ -108,7 +107,7 @@ DELOREAN
     and_by 'compute attrs with bad params' do
       wait_for_ajax
       wait_for_element do
-        fill_in('attrs', with: "A.a; A.b; B.a; C.a")
+        fill_in('attrs', with: 'A.a; A.b; B.a; C.a')
         true
       end
       fill_in('params', with: "a = 1.1\nc = 2.2")
@@ -135,7 +134,7 @@ DELOREAN
     end
 
     and_by 'compute new attrs & bad params (div by 0)' do
-      fill_in('attrs', with: "B.e")
+      fill_in('attrs', with: 'B.e')
       fill_in('params', with: "a = 0\n")
       press('Compute')
     end
@@ -160,8 +159,8 @@ DELOREAN
 
     and_by 'compute attrs with empty params' do
       wait_for_ajax
-      fill_in('attrs', with: "A.a")
-      fill_in('params', with: "")
+      fill_in('attrs', with: 'A.a')
+      fill_in('params', with: '')
       press('Compute')
     end
 
@@ -172,7 +171,7 @@ DELOREAN
     end
 
     and_by 'compute attrs that without necessary params' do
-      fill_in('attrs', with: "C.e")
+      fill_in('attrs', with: 'C.e')
       press('Compute')
     end
 
@@ -191,8 +190,8 @@ DELOREAN
 
     and_by 'compute attrs with good params' do
       wait_for_ajax
-      fill_in('attrs', with: "B.aa")
-      fill_in('params', with: "aa = 111")
+      fill_in('attrs', with: 'B.aa')
+      fill_in('params', with: 'aa = 111')
       press('Compute')
     end
 
@@ -219,7 +218,7 @@ DELOREAN
     and_by 'use bad attributes' do
       wait_for_ajax
       wait_for_element do
-        fill_in('attrs', with: "A; y; >")
+        fill_in('attrs', with: 'A; y; >')
         true
       end
       press('Compute')
@@ -233,7 +232,7 @@ DELOREAN
 
     and_by 'use bad node' do
       wait_for_ajax
-      fill_in('attrs', with: ">.<")
+      fill_in('attrs', with: '>.<')
       press('Compute')
     end
 
@@ -245,7 +244,7 @@ DELOREAN
 
     and_by 'use good attr' do
       wait_for_ajax
-      fill_in('attrs', with: "A.a")
+      fill_in('attrs', with: 'A.a')
       press('Compute')
     end
 
@@ -257,7 +256,7 @@ DELOREAN
 
     and_by 'use undefined attr' do
       wait_for_ajax
-      fill_in('attrs', with: "A.new")
+      fill_in('attrs', with: 'A.new')
       press('Compute')
     end
 
@@ -284,7 +283,7 @@ DELOREAN
     and_by 'use good attr' do
       wait_for_ajax
       wait_for_element do
-        fill_in('attrs', with: "C.p; B.p")
+        fill_in('attrs', with: 'C.p; B.p')
         true
       end
       press('Compute')
@@ -299,7 +298,7 @@ DELOREAN
 
     and_by 'add a good param' do
       wait_for_ajax
-      fill_in('params', with: "p = 7")
+      fill_in('params', with: 'p = 7')
       press('Compute')
     end
 
@@ -312,8 +311,8 @@ DELOREAN
 
     and_by 'use good attr' do
       wait_for_ajax
-      fill_in('attrs', with: "C.pc; B.pc")
-      fill_in('params', with: "")
+      fill_in('attrs', with: 'C.pc; B.pc')
+      fill_in('params', with: '')
       press('Compute')
     end
 
@@ -324,11 +323,11 @@ DELOREAN
       expect(result).to have_content 'B.pc = 9'
     end
 
-     and_by 'use bad attr' do
-      wait_for_ajax
-      fill_in('attrs', with: "C.pc; B.pc; A.pc;")
-      fill_in('params', with: "")
-      press('Compute')
+    and_by 'use bad attr' do
+     wait_for_ajax
+     fill_in('attrs', with: 'C.pc; B.pc; A.pc;')
+     fill_in('params', with: '')
+     press('Compute')
     end
 
     and_by 'see error' do
@@ -339,8 +338,8 @@ DELOREAN
 
     and_by 'use good attr & params' do
       wait_for_ajax
-      fill_in('attrs', with: "C.pc; B.pc")
-      fill_in('params', with: "p = 123.0")
+      fill_in('attrs', with: 'C.pc; B.pc')
+      fill_in('params', with: 'p = 123.0')
       press('Compute')
     end
 

data/spec/features/user_view_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 feature 'under Sytem menu, User Management worflows', js: true do
-
   def go_to_user_view
     press('System')
     press('User Management')
@@ -15,7 +14,7 @@ feature 'under Sytem menu, User Management worflows', js: true do
       expect(page).not_to have_content 'User Management'
     end
 
-    ensure_on("/#userView")
+    ensure_on('/#userView')
   end
 
   # Checkbox Helpers
@@ -78,33 +77,32 @@ feature 'under Sytem menu, User Management worflows', js: true do
 
     and_by 'check row got edited' do
       wait_for_ajax
-      expect(user_view.get_row_vals(2)).to netzke_include({
-        :login=>"new_login",
-        :firstname=>"new_fname",
-        :lastname=>"new_lname",
-        :active=>true,
-        :roles=>"User Manager,Viewer",
-        })
+      expect(user_view.get_row_vals(2)).to netzke_include(
+        :login => 'new_login',
+        :firstname => 'new_fname',
+        :lastname => 'new_lname',
+        :active => true,
+        :roles => 'User Manager,Viewer',
+      )
     end
 
     and_by 'delete user fails' do
       user_view.select_row(2)
-      press("Delete")
-      press("Yes")
-      expect(find(:msg)).to have_content("Users cannot be deleted - set " +
+      press('Delete')
+      press('Yes')
+      expect(find(:msg)).to have_content('Users cannot be deleted - set ' +
                                          "'Active' to false to disable the " +
-                                         "account")
+                                         'account')
       user_view.select_row(1)
-      press("Delete")
-      press("Yes")
-      expect(find(:msg)).to have_content("You cannot delete your own account")
+      press('Delete')
+      press('Yes')
+      expect(find(:msg)).to have_content('You cannot delete your own account')
 
       expect(user_view.row_count).to eq 2
     end
   end
 
   describe 'check user permissions & what buttons appear' do
-
     before(:all) do
       populate_test_users
     end

data/spec/job_helper.rb

@@ -4,7 +4,7 @@ class StringIO
   end
 end
 
-NAME_A   = "PromiseA2"
+NAME_A   = 'PromiseA2'
 SCRIPT_A = <<EOS
 Y:
     q =? nil
@@ -18,7 +18,7 @@ Y:
     f = Y(s=s) | ["d"]
 EOS
 
-NAME_B   = "PromiseB"
+NAME_B   = 'PromiseB'
 SCRIPT_B = <<EOS
 Y:
     result = [{"a": i, "b": i*i} for i in [1,2,3]]
@@ -30,7 +30,7 @@ Z:
     title  = "Root#{NAME_B}"
 EOS
 
-NAME_C   = "PromiseC"
+NAME_C   = 'PromiseC'
 SCRIPT_C = <<EOS
 Y:
     node =?
@@ -40,7 +40,7 @@ Z:
     title  = "#{NAME_C}"
 EOS
 
-NAME_D   = "PromiseD"
+NAME_D   = 'PromiseD'
 SCRIPT_D = <<EOS
 Y:
     arg =?
@@ -52,7 +52,7 @@ Z:
     title  = "#{NAME_D}"
 EOS
 
-NAME_E   = "PromiseE"
+NAME_E   = 'PromiseE'
 SCRIPT_E = <<EOS
 X:
     x = 'x'*10
@@ -60,14 +60,14 @@ Z:
     result = [X() | "x" for i in [1,2,3,4,5,6]]
 EOS
 
-NAME_F   = "PromiseF"
+NAME_F   = 'PromiseF'
 SCRIPT_F = <<EOS
 import #{NAME_E}
 Z:
     result = #{NAME_E}::X() | "x"
 EOS
 
-NAME_G   = "PromiseG"
+NAME_G   = 'PromiseG'
 SCRIPT_G = <<EOS
 U:
     result  = [123]
@@ -79,7 +79,7 @@ V:
     result = A(p_title="#{NAME_G}") | "result"
 EOS
 
-NAME_H   = "PromiseH"
+NAME_H   = 'PromiseH'
 SCRIPT_H = <<EOS
 Y:
     q =? nil
@@ -87,21 +87,21 @@ Y:
     d = [Y(q=i) | ['a'] for i in [1, 2]]
 EOS
 
-NAME_I = "PromiseI"
+NAME_I = 'PromiseI'
 SCRIPT_I = <<EOS
 SLEEPER:
     secs =? nil
     a = Gemini::Helper.sleep(secs) && secs
 EOS
 
-NAME_J = "PromiseJ"
+NAME_J = 'PromiseJ'
 SCRIPT_J = <<EOS
 FAILER:
     dummy =? nil
     a = ERR('I had an error')
 EOS
 
-NAME_K = "PromiseK"
+NAME_K = 'PromiseK'
 SCRIPT_K = <<EOS
 LOGGER:
     msgid =? nil

data/spec/lib/data_blame_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe 'Blame Report', slow: true do
+  U = 'marty marty'
+  BC = 'Conv Fixed 30'
+
+  before do
+    marty_whodunnit
+
+    Marty::Script.load_scripts(nil, Time.zone.now)
+
+    time1 = Time.zone.parse '2019-01-23 05:14:50 -0800'
+    time2 = Time.zone.parse '2019-01-24 05:14:50 -0800'
+    time3 = Time.zone.parse '2019-01-25 05:14:50 -0800'
+    time4 = Time.zone.parse '2019-01-26 05:14:50 -0800'
+    time5 = Time.zone.parse '2019-01-27 05:14:50 -0800'
+
+    posting = Marty::Posting.do_create('BASE', time3 - 2.hours, 'base posting')
+    @pt_name = Marty::Posting.find_by_name(posting.name).name
+
+    bc = Gemini::BudCategory.create(name: 'Conv Fixed 30', created_dt: time1)
+    bc2 = Gemini::BudCategory.create(name: 'Govt Fixed 30', created_dt: time1)
+
+    fannie_bup1 = Gemini::FannieBup.create(bud_category: bc,
+                                           note_rate: 2.250,
+                                           buy_up: 1.123,
+                                           buy_down: 2.345,
+                                           settlement_mm: 12,
+                                           settlement_yy: 2012,
+                                           created_dt: time1
+                                          )
+
+    fannie_bup2 = Gemini::FannieBup.create(bud_category: bc2,
+                                           note_rate: 2.250,
+                                           buy_up: 2.123,
+                                           buy_down: 3.345,
+                                           settlement_mm: 22,
+                                           settlement_yy: 2014,
+                                           created_dt: time4
+                                          )
+
+    fannie_bup2.destroy!
+    fannie_bup2.reload
+    o_dt = fannie_bup2.obsoleted_dt.to_s
+
+    fannie_bup1.update!(buy_up: 1.125, created_dt: time2)
+    fannie_bup1.update!(buy_up: 1.126, created_dt: time4)
+    fannie_bup1.update!(buy_up: 1.127, created_dt: time5)
+
+    @res0 = [
+      [time2.to_s, U, '', '', nil, BC, 2.25, 12, 2012, 1.125, 2.345],
+      [time4.to_s, U, '', '', nil, BC, 2.25, 12, 2012, 1.126, 2.345],
+      [time5.to_s, U, '', '', nil, BC, 2.25, 12, 2012, 1.127, 2.345],
+      [time4.to_s, U, o_dt, U, nil, 'Govt Fixed 30', 2.25, 22, 2014,
+       2.123, 3.345]
+    ].freeze
+  end
+
+  it 'should generate Data Blame report' do
+    ws = Marty::Script.evaluate(
+      nil, 'BlameReport', 'DataBlameReport', 'result',
+      # "class_list" param, defaults to all
+      'pt_name1' => @pt_name,
+      'pt_name2' => 'NOW',
+    )
+
+    sp = Marty::Xl.spreadsheet(ws)
+    file = Tempfile.new('file.xlsx')
+    expect { sp.serialize(file) }.to_not raise_error
+
+    expect(sp.workbook.worksheets.map(&:name)).
+      to eq(['GeminiFannieBup'])
+
+    expect(sp.workbook.worksheets.count).to eq 1
+    expect(sp.workbook.worksheets[0].rows.count).to eq 5
+
+    @res0.each_with_index do |rec, i|
+      cells = sp.workbook.worksheets[0].rows[i + 1].cells.map(&:value)
+      expect(Set.new(cells[1..-1])).to eq Set.new(rec)
+    end
+  end
+end