marty 2.5.2 → 2.5.4

data/spec/features/jobs_dashboard_spec.rb

@@ -6,16 +6,16 @@ describe 'Jobs Dashboard', type: :feature, js: true, capybara: true do
                                     firstname: 'other',
                                     lastname: 'other',
                                     active: true)
-    Marty::Promise.create title: "Test Job 1",
+    Marty::Promise.create title: 'Test Job 1',
       user: Marty::User.find_by(login: 'marty'),
       cformat: 'csv',
       start_dt: Time.now
-    Marty::Promise.create title: "Test Job 2",
+    Marty::Promise.create title: 'Test Job 2',
       user: other_user,
       cformat: 'csv',
       start_dt: Time.now
 
-    visit "/"
+    visit '/'
     all 'span', text: 'Sign in', minimum: 1
     find(ext_button_id('Sign in')).click
     fill_in 'Login', with: 'marty'
@@ -25,29 +25,35 @@ describe 'Jobs Dashboard', type: :feature, js: true, capybara: true do
 
     find(ext_button_id('Applications')).click
     find(ext_menuitem_id('Jobs Dashboard')).click
-    page_title = I18n.t("jobs.promise_view")
+    page_title = I18n.t('jobs.promise_view')
     expect(page).to have_content(page_title)
 
     sleep 1
 
     expect(tree_row_count(page_title)).to eq(2)
 
-    fill_in "live_search_text", with: 'marty'
+    fill_in 'live_search_text', with: 'marty'
     sleep 1
     expect(tree_row_count(page_title)).to eq(1)
   end
 
   def ext_button_id title
-    id = page.evaluate_script("Ext.ComponentQuery.query(\"button{isVisible(true)}[text='#{title}']\")[0].id")
+    id = page.evaluate_script(
+      "Ext.ComponentQuery.query(\"button{isVisible(true)}[text='#{title}']\")[0].id"
+    )
     "##{id}"
   end
 
   def ext_menuitem_id title
-    id = page.evaluate_script("Ext.ComponentQuery.query(\"menuitem[text='#{title}']\")[0].id")
+    id = page.evaluate_script(
+      "Ext.ComponentQuery.query(\"menuitem[text='#{title}']\")[0].id"
+    )
     "##{id}"
   end
 
   def tree_row_count name
-    page.evaluate_script("Ext.ComponentQuery.query('treepanel[title=\"#{name}\"]')[0].getStore().getCount()")
+    page.evaluate_script(
+      "Ext.ComponentQuery.query('treepanel[title=\"#{name}\"]')[0].getStore().getCount()"
+    )
   end
 end

data/spec/features/log_view_spec.rb

@@ -1,30 +1,28 @@
 require 'spec_helper'
 
 feature 'logger view', js: true, capybara: true do
-
   before(:all) do
     self.use_transactional_tests = false
     Marty::Log.delete_all
 
     info_s = { info: 'message' }
     error_s = [1, 2, 3, { error: 'message' }]
-    fatal_s = ["string", 123, { fatal: "message", another_key: 'value' }]
+    fatal_s = ['string', 123, { fatal: 'message', another_key: 'value' }]
     Marty::Logger.info('info message', nil)
     Marty::Logger.error('error message', error_s)
     Marty::Logger.fatal('fatal message', fatal_s)
 
-    Marty::Log.create!(message_type: "debug",
-                       message: "hi mom",
-                       details: ["one", "two", 3, 4.0],
+    Marty::Log.create!(message_type: 'debug',
+                       message: 'hi mom',
+                       details: ['one', 'two', 3, 4.0],
                        timestamp: Time.zone.now - 5.days)
 
-    Marty::Log.create!(message_type: "warn",
-                       message: "all your base",
+    Marty::Log.create!(message_type: 'warn',
+                       message: 'all your base',
                        details: [5],
                        timestamp: Time.zone.now - 10.days)
 
-    @ts = Marty::Log.select(:timestamp).order(timestamp: :desc).map do
-      |(ts)|
+    @ts = Marty::Log.select(:timestamp).order(timestamp: :desc).map do |(ts)|
       Time.zone.at(ts[:timestamp]).strftime('%Y-%m-%dT%H:%M:%S.%L%:z')
     end
 
@@ -40,47 +38,46 @@ feature 'logger view', js: true, capybara: true do
   end
 
   let(:logview) { netzke_find('log_view') }
-  it "updates views correctly" do
+  it 'updates views correctly' do
     log_in_as('marty')
     press('System')
     show_submenu('Log Maintenance')
     press('View Log')
     wait_for_ajax
 
-    exp_types = ["fatal", "error", "info", "debug", "warn"]
-    exp_messages = ["fatal message", "error message",
-                    "info message", "hi mom", "all your base"]
-    exp_details = [ "[\"string\", 123, {\"fatal\"=>\"message\", "\
+    exp_types = ['fatal', 'error', 'info', 'debug', 'warn']
+    exp_messages = ['fatal message', 'error message',
+                    'info message', 'hi mom', 'all your base']
+    exp_details = ['["string", 123, {"fatal"=>"message", '\
                      "\"another_key\"=>\"value\"}]\n",
-                    "[1, 2, 3, {\"error\"=>\"message\"}]\n",
-                    "nil\n",
-                    "[\"one\", \"two\", 3, 4.0]\n",
-                    "[5]\n"
-                  ]
-   [[nil, 5], [7, 4], [3, 3], [0, 0]].each do |days, exp_count|
-      if days
-        press('System')
-        show_submenu('Log Maintenance')
-        press('Cleanup Log Table')
-        wait_for_ajax
-        find(:xpath, "//input[contains(@id, 'textfield')]", wait: 5).set(days)
-        press('OK')
-        wait_for_ready
-        find('.x-tool-refresh').click
-        wait_for_ready
-      end
-      wait_for_ajax
-      cnt = logview.row_count()
-      expect(cnt).to eq(exp_count)
-      types = logview.get_col_vals('message_type', cnt, 0)
-      messages = logview.get_col_vals('message', cnt, 0)
-      details = logview.get_col_vals('details', cnt, 0).
-                  map { |d| CGI.unescapeHTML(d) }
-      ts = logview.get_col_vals('timestamp_custom', cnt, 0)
-      expect(ts).to eq(@ts.slice(0,exp_count))
-      expect(types).to eq(exp_types.slice(0,exp_count))
-      expect(messages).to eq(exp_messages.slice(0,exp_count))
-      expect(details).to eq(exp_details.slice(0,exp_count))
+                   "[1, 2, 3, {\"error\"=>\"message\"}]\n",
+                   "nil\n",
+                   "[\"one\", \"two\", 3, 4.0]\n",
+                   "[5]\n"]
+    [[nil, 5], [7, 4], [3, 3], [0, 0]].each do |days, exp_count|
+       if days
+         press('System')
+         show_submenu('Log Maintenance')
+         press('Cleanup Log Table')
+         wait_for_ajax
+         find(:xpath, "//input[contains(@id, 'textfield')]", wait: 5).set(days)
+         press('OK')
+         wait_for_ready
+         find('.x-tool-refresh').click
+         wait_for_ready
+       end
+       wait_for_ajax
+       cnt = logview.row_count()
+       expect(cnt).to eq(exp_count)
+       types = logview.get_col_vals('message_type', cnt, 0)
+       messages = logview.get_col_vals('message', cnt, 0)
+       details = logview.get_col_vals('details', cnt, 0).
+                   map { |d| CGI.unescapeHTML(d) }
+       ts = logview.get_col_vals('timestamp_custom', cnt, 0)
+       expect(ts).to eq(@ts.slice(0, exp_count))
+       expect(types).to eq(exp_types.slice(0, exp_count))
+       expect(messages).to eq(exp_messages.slice(0, exp_count))
+       expect(details).to eq(exp_details.slice(0, exp_count))
     end
   end
 end

data/spec/features/reporting_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 feature 'under Applications menu, Reports workflows', js: true do
   before(:all) do
-    SOME_DATE = "20130520"
-    SOME_TIME = "1200"
+    SOME_DATE = '20130520'
+    SOME_TIME = '1200'
     SOME_DT   = "#{SOME_DATE} #{SOME_TIME} PST8PDT"
     @clean_file = "/tmp/clean_#{Process.pid}.psql"
     save_clean_db(@clean_file)
@@ -32,7 +32,7 @@ feature 'under Applications menu, Reports workflows', js: true do
   end
 
   def populate_sample_reports
-    a_report  = <<DELOREAN
+    a_report = <<DELOREAN
 PostingField:
     field_label = "Posting"
     xtype       = ":combo"
@@ -76,24 +76,24 @@ DD: BB
     result = 444
 DELOREAN
 
-    with_user("dev1") { |u|
+    with_user('dev1') do |u|
       Marty::Posting.do_create('BASE', SOME_DT, 'a comment')
 
       Marty::Script.
-        load_script_bodies({ "SomeReport" => a_report, },
+        load_script_bodies({ 'SomeReport' => a_report, },
                            Date.today)
 
       Marty::Script.
-        load_script_bodies({ "SomeReport" =>
+        load_script_bodies({ 'SomeReport' =>
                              a_report +
                              "CC: BB\n    title=\"CC\"\n    result = 123" },
                            Date.today + 1.minute)
-    }
+    end
   end
 
   def select_node node_name
     wait_for_ajax
-    #hacky: assumes only 1 combobox without label
+    # hacky: assumes only 1 combobox without label
     within(:gridpanel, 'report_select', match: :first) do
       # hacky, hardcoding netzkecombobox dropdown arrow name
       arrow = find(:input, 'nodename')['data-componentid'] + '-trigger-picker'
@@ -131,12 +131,12 @@ DELOREAN
       select_node('CC (csv)')
     end
 
-     and_by 'fill form' do
-      wait_for_ajax
+    and_by 'fill form' do
+     wait_for_ajax
 
-      within(:gridpanel, 'report_form', match: :first) do
-        fill_in('Note Rate', with: '3.00')
-      end
+     within(:gridpanel, 'report_form', match: :first) do
+       fill_in('Note Rate', with: '3.00')
+     end
     end
 
     and_by 'do Background Report with delayed jobs' do
@@ -202,7 +202,7 @@ DELOREAN
       # hidden field that causes results to be inlined
       set_field_value('true', 'textfield', 'selected_testing')
 
-      press("Generate Report")
+      press('Generate Report')
     end
 
     wait_for_element do
@@ -284,7 +284,7 @@ DELOREAN
       wait_for_ajax
       set_field_value('XYZ', '', 'pt_name')
       set_field_value('true', 'textfield', 'selected_testing')
-      press("Generate URL")
+      press('Generate URL')
       wait_for_ajax
 
       within_window(switch_to_window(windows.last)) do

data/spec/features/rule_spec.rb

@@ -10,29 +10,32 @@ feature 'rule view', js: true do
     dt = DateTime.parse('2017-1-1')
     p = File.expand_path('../../fixtures/csv/rule', __FILE__)
     [Marty::DataGrid, Gemini::XyzRule, Gemini::MyRule].each do |klass|
-      f = "%s/%s.csv" % [p, klass.to_s.sub(/(Gemini|Marty)::/,'')]
-      Marty::DataImporter.do_import(klass, File.read(f), dt, nil, nil, ",")
+      f = '%s/%s.csv' % [p, klass.to_s.sub(/(Gemini|Marty)::/, '')]
+      Marty::DataImporter.do_import(klass, File.read(f), dt, nil, nil, ',')
     end
   end
   after(:all) do
     restore_clean_db(@save_file)
   end
   def go_to_my_rules
-    press("Pricing Config.")
-    press("My Rules")
+    press('Pricing Config.')
+    press('My Rules')
     expect(page).to have_content 'My Rules'
   end
+
   def go_to_xyz_rules
-    press("Pricing Config.")
-    press("Xyz Rules")
+    press('Pricing Config.')
+    press('Xyz Rules')
     expect(page).to have_content 'Xyz Rules'
   end
+
   def col_id(v, col)
     run_js <<-JS
            #{ext_var(v.grid, 'grid')}
            return #{ext_find(ext_arg('gridcolumn', text: col), 'grid')}.id
      JS
   end
+
   # click_checkbox in marty_rspec not working here for some reason
   def click_checkbox(name)
     q = %Q(checkbox[fieldLabel="#{name}"])
@@ -43,9 +46,9 @@ feature 'rule view', js: true do
   end
 
   # click_col in marty_rspec is not reliable
-  def click_column(rv,name)
+  def click_column(rv, name)
     cid = col_id(rv, name)
-    c = find('#'+cid)
+    c = find('#' + cid)
     c.select_option   #   .click does not work reliably
     c.send_keys(' ')
     # wait_for_ajax and wait_for_ready do not work here,
@@ -53,33 +56,36 @@ feature 'rule view', js: true do
     sleep 1.0
   end
 
-  def column_filter(rv,name,value)
+  def column_filter(rv, name, value)
     cid = col_id(rv, name)
-    c = find('#'+cid)
+    c = find('#' + cid)
     c.send_keys([:down, :down, :down, :down, :right, value, :return])
     sleep 1.0
   end
-  def column_filter_toggle(rv,name)
+
+  def column_filter_toggle(rv, name)
     cid = col_id(rv, name)
-    c = find('#'+cid)
+    c = find('#' + cid)
     c.send_keys([:down, :down, :down, :down, ' ', :escape])
     sleep 1.0
   end
+
   # idx 0 is the start dt, 1 is the end dt
   def date_fill_in(idx, value)
     dt = all(:xpath, "//input[contains(@name, 'datefield')]")[idx]
     dt.native.clear()
     dt.native.send_keys(value)
   end
-  def time_fill_in(idx,value)
+
+  def time_fill_in(idx, value)
     tm = all(:xpath, "//input[contains(@name, 'timefield')]")[idx]
     tm.native.clear()
     tm.native.send_keys(value)
   end
-  it "rule workflow" do
+  it 'rule workflow' do
     log_in_as('marty')
     go_to_my_rules
-    mrv = netzke_find("my_rule_view")
+    mrv = netzke_find('my_rule_view')
     # test required field
     press('Add')
     wait_for_ajax
@@ -94,108 +100,108 @@ feature 'rule view', js: true do
     time_fill_in(0, '11:03:01')
     date_fill_in(1, '2030-01-01')
     time_fill_in(1, '08:03:01')
-    press("OK")
+    press('OK')
     wait_for_ajax
     expect(mrv.row_count()).to eq(9)
-    expect(mrv.get_row_vals(1)).to include({"name"=>"abc",
-                                            "rule_type"=>"SimpleRule",
-                                            "start_dt"=>"2013-01-01T11:03:01",
-                                            "end_dt"=>"2030-01-01T08:03:01",
-                                            "other_flag"=>false,
-                                            "g_array"=>"",
-                                            "g_single"=>"",
-                                            "g_string"=>"",
-                                            "g_bool"=>nil,
-                                            "g_nullbool"=>"",
-                                            "g_bool_def"=>nil,
-                                            "g_nbool_def"=>"False",
-                                            "g_range"=>nil,
-                                            "g_integer"=>nil,
-                                            "g_has_default"=>"string default",
-                                            "computed_guards"=>"",
-                                            "grids"=>"",
-                                            "results"=>"",
-                                           })
+    expect(mrv.get_row_vals(1)).to include('name' => 'abc',
+                                            'rule_type' => 'SimpleRule',
+                                            'start_dt' => '2013-01-01T11:03:01',
+                                            'end_dt' => '2030-01-01T08:03:01',
+                                            'other_flag' => false,
+                                            'g_array' => '',
+                                            'g_single' => '',
+                                            'g_string' => '',
+                                            'g_bool' => nil,
+                                            'g_nullbool' => '',
+                                            'g_bool_def' => nil,
+                                            'g_nbool_def' => 'False',
+                                            'g_range' => nil,
+                                            'g_integer' => nil,
+                                            'g_has_default' => 'string default',
+                                            'computed_guards' => '',
+                                            'grids' => '',
+                                            'results' => '',
+                                          )
 
     r = Gemini::MyRule.find_by(obsoleted_dt: 'infinity', name: 'abc')
-    expect(r.attributes).to include({"user_id"=>1,
-                                     "o_user_id"=>nil,
-                                     "name"=>"abc",
-                                     "engine"=>"Gemini::MyRuleScriptSet",
-                                     "rule_type"=>"SimpleRule",
-                                     "simple_guards"=>{"g_bool"=>false,
-                                                       "g_bool_def"=>false,
-                                                       "g_nbool_def"=>false,
-                                                       "g_has_default"=>
-                                                       "string default"},
-                                     "computed_guards"=>{},
-                                     "grids"=>{},
-                                     "results"=>{},
-                                    })
+    expect(r.attributes).to include('user_id' => 1,
+                                     'o_user_id' => nil,
+                                     'name' => 'abc',
+                                     'engine' => 'Gemini::MyRuleScriptSet',
+                                     'rule_type' => 'SimpleRule',
+                                     'simple_guards' => { 'g_bool' => false,
+                                                       'g_bool_def' => false,
+                                                       'g_nbool_def' => false,
+                                                       'g_has_default' =>
+                                                       'string default' },
+                                     'computed_guards' => {},
+                                     'grids' => {},
+                                     'results' => {},
+                                   )
     # type validation (string with values list)
     mrv.select_row(1)
-    press("Edit")
+    press('Edit')
     # type validation (range)
-    netzke_find("String list Guard", 'combobox').select_values("Hi Mom")
-    click_checkbox("Bool Guard")
-    click_checkbox("Other")
-    netzke_find("NullBool Guard", 'combobox').select_values("False")
-    netzke_find('Array Guard', 'combobox').select_values("G1V1,G1V3")
-    netzke_find('Single Guard', 'combobox').select_values("G2V2")
+    netzke_find('String list Guard', 'combobox').select_values('Hi Mom')
+    click_checkbox('Bool Guard')
+    click_checkbox('Other')
+    netzke_find('NullBool Guard', 'combobox').select_values('False')
+    netzke_find('Array Guard', 'combobox').select_values('G1V1,G1V3')
+    netzke_find('Single Guard', 'combobox').select_values('G2V2')
     fill_in(:g_integer, with: 123)
-    fill_in(:g_range, with: "asfd")
-    press("OK")
+    fill_in(:g_range, with: 'asfd')
+    press('OK')
     wait_for_ajax
     expect(page).to have_content("Wrong type for 'g_range'")
     # validate rule
-    fill_in(:g_range, with: "<=100")
-    netzke_find('Grid1', 'combobox').select_values("DataGrid1")
-    netzke_find('Grid2', 'combobox').select_values("DataGrid2")
-    fill_in("Defaulted String", with: "12345")
-    press("OK")
+    fill_in(:g_range, with: '<=100')
+    netzke_find('Grid1', 'combobox').select_values('DataGrid1')
+    netzke_find('Grid2', 'combobox').select_values('DataGrid2')
+    fill_in('Defaulted String', with: '12345')
+    press('OK')
     wait_for_ajax
-    exp = {"name"=>"abc",
-           "rule_type"=>"SimpleRule",
-           "start_dt"=>"2013-01-01T11:03:01",
-           "end_dt"=>"2030-01-01T08:03:01",
-           "other_flag"=>true,
-           "g_array"=>"G1V1,G1V3",
-           "g_single"=>"G2V2",
-           "g_string"=>"Hi Mom",
-           "g_bool"=>true,
-           "g_nullbool"=>"False",
-           "g_range"=>"<=100",
-           "g_integer"=>123,
-           "g_has_default"=>"12345",
-           "computed_guards"=>"",
-           "grids"=>"{\"grid1\":\"DataGrid1\",\"grid2\":\"DataGrid2\"}",
-           "results"=>"",
+    exp = { 'name' => 'abc',
+           'rule_type' => 'SimpleRule',
+           'start_dt' => '2013-01-01T11:03:01',
+           'end_dt' => '2030-01-01T08:03:01',
+           'other_flag' => true,
+           'g_array' => 'G1V1,G1V3',
+           'g_single' => 'G2V2',
+           'g_string' => 'Hi Mom',
+           'g_bool' => true,
+           'g_nullbool' => 'False',
+           'g_range' => '<=100',
+           'g_integer' => 123,
+           'g_has_default' => '12345',
+           'computed_guards' => '',
+           'grids' => '{"grid1":"DataGrid1","grid2":"DataGrid2"}',
+           'results' => '',
           }
-    r = Gemini::MyRule.lookup('infinity','abc')
-    expect(r["simple_guards"]["g_nullbool"]).to eq(false)
+    r = Gemini::MyRule.lookup('infinity', 'abc')
+    expect(r['simple_guards']['g_nullbool']).to eq(false)
     expect(mrv.get_row_vals(1)).to include(exp)
     # grid edits
-    press("Edit")
-    netzke_find('Grid2', 'combobox').select_values("---")
-    press("OK")
+    press('Edit')
+    netzke_find('Grid2', 'combobox').select_values('---')
+    press('OK')
     wait_for_ajax
-    expect(mrv.get_row_vals(1)).to include(exp+{"grids"=>
-                                                "{\"grid1\":\"DataGrid1\"}"})
-    press("Edit")
-    netzke_find("NullBool Guard", 'combobox').select_values("---")
-    press("OK")
+    expect(mrv.get_row_vals(1)).to include(exp + { 'grids' =>
+                                                '{"grid1":"DataGrid1"}' })
+    press('Edit')
+    netzke_find('NullBool Guard', 'combobox').select_values('---')
+    press('OK')
     wait_for_ajax
-    expect(mrv.get_row_vals(1)).to include(exp+{"g_nullbool"=>"",
-                                                "grids"=>
-                                                "{\"grid1\":\"DataGrid1\"}"})
-    r = Gemini::MyRule.lookup('infinity','abc')
-    expect(r["simple_guards"]).not_to include('g_nullbool')
+    expect(mrv.get_row_vals(1)).to include(exp + { 'g_nullbool' => '',
+                                                'grids' =>
+                                                '{"grid1":"DataGrid1"}' })
+    r = Gemini::MyRule.lookup('infinity', 'abc')
+    expect(r['simple_guards']).not_to include('g_nullbool')
     # computed fields
-    press("Edit")
+    press('Edit')
 
     # bad form - BaseRuleView#simple_to_hash will raise
     fill_in(:computed_guards, with: 'sadf asdf ljsf')
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'computed_guards': Syntax error on line 1"
     expect(page).to have_content(exp)
@@ -204,7 +210,7 @@ feature 'rule view', js: true do
 
     # lhs is not identifier - BaseRuleView#simple_to_has will raise
     fill_in(:computed_guards, with: '0sadf = 123j')
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'computed_guards': Syntax error on line 1"
     expect(page).to have_content(exp)
@@ -212,14 +218,14 @@ feature 'rule view', js: true do
 
     # bad rhs - delorean compile will raise
     fill_in(:computed_guards, with: 'var = 123j')
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'computed_guards': Syntax error"
     expect(page).to have_content(exp)
     sleep 2
 
     fill_in(:computed_guards, with: %Q(var1 = "good"\nvar2 = 123\nvar3 = 123j))
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'computed_guards': Syntax error"
     expect(page).to have_content(exp)
@@ -227,14 +233,14 @@ feature 'rule view', js: true do
 
     fill_in(:computed_guards, with: '')
     fill_in(:results, with: %Q(var1 = "good"\nvar2 = 123\nvar3 = 123j))
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'results': Syntax error"
     expect(page).to have_content(exp)
     sleep 2
 
     fill_in(:results, with: %Q(abc = "def"\ndef = 5\nxyz=def+10\nsadf asdf lsf))
-    press("OK")
+    press('OK')
     wait_for_ajax
     exp = "Computed - Error in rule 'abc' field 'results': Syntax error"
     expect(page).to have_content(exp)
@@ -243,8 +249,8 @@ feature 'rule view', js: true do
     fill_in(:results,
             with: %Q(abc = "def"\ndef = "abc"\nklm = "3"\nabc = "xyz"))
     exp = "Computed - Error in rule 'abc' field 'results': Keyword 'abc' specified more"\
-          " than once (line 4)"
-    press("OK")
+          ' than once (line 4)'
+    press('OK')
     wait_for_ajax
     expect(page).to have_content(exp)
     sleep 2
@@ -265,20 +271,20 @@ klm = 3 +
 EOL
 
     fill_in(:results, with: multi_line)
-    press("OK")
+    press('OK')
     wait_for_ajax
 
     # re-edit twice to make sure re-indentation and stripping are correct
-    press("Edit")
+    press('Edit')
     wait_for_ajax
     expect(find_field(:results).value).to eq(multi_line_fixed.chomp)
-    press("OK")
+    press('OK')
     wait_for_ajax
 
-    press("Edit")
+    press('Edit')
     wait_for_ajax
     expect(find_field(:results).value).to eq(multi_line_fixed.chomp)
-    press("OK")
+    press('OK')
     wait_for_ajax
 
     # when stored in rule, all lines of a multi line value s/b stripped
@@ -286,121 +292,121 @@ EOL
     expect(r.results['klm']).to eq("3 +\n4 +\nif true then 5 else 0")
 
     # make sure change of key/value order is recognized as a change
-    press("Edit")
+    press('Edit')
     wait_for_ajax
     val = find_field(:results).value.lines
     val[-1] += "\n"
     newval = (val[1..-1] + val[0..0]).join
     fill_in(:results, with: newval)
-    press("OK")
+    press('OK')
     wait_for_ajax
-    press("Edit")
+    press('Edit')
     wait_for_ajax
-    val = find_field(:results).value+"\n"
+    val = find_field(:results).value + "\n"
     expect(val).to eq(newval)
-    press("OK")
+    press('OK')
     wait_for_ajax
 
-    exp =<<EOL
+    exp = <<EOL
 simple_result  = "c value"
 computed_value = if paramb
                  then param1 / (grid1_grid_result||1)
                  else (grid2_grid_result||1) / param1
 EOL
     names = mrv.get_col_vals(:name, 9, 0)
-    idx = names.index{|n|n=='Rule3'}+1
+    idx = names.index { |n| n == 'Rule3' } + 1
     mrv.select_row(idx)
-    press("Edit")
+    press('Edit')
     expect(find_field(:results).value).to eq(exp.chomp)
-    press("OK")
+    press('OK')
     wait_for_ajax
 
-    press("Dup in form")
-    netzke_find('Single Guard', 'combobox').select_values("G2V3")
-    press("OK")
+    press('Dup in form')
+    netzke_find('Single Guard', 'combobox').select_values('G2V3')
+    press('OK')
     wait_for_ajax
     expect(page).to have_content(/record must be unique/)
 
-    press("Cancel")
+    press('Cancel')
     # column sorting, etc
     go_to_xyz_rules
-    xrv = netzke_find("xyz_rule_view")
-    expect(page).to have_content("Rule type")
-    expect(xrv.get_col_vals(:name, 5, 0)).to eq(["ZRule1", "ZRule2",
-                                                 "ZRule3", "ZRule4",
-                                                 "ZRule5"])
+    xrv = netzke_find('xyz_rule_view')
+    expect(page).to have_content('Rule type')
+    expect(xrv.get_col_vals(:name, 5, 0)).to eq(['ZRule1', 'ZRule2',
+                                                 'ZRule3', 'ZRule4',
+                                                 'ZRule5'])
     xrv.select_row(1)
-    press("Edit")
-    fill_in("Range Guard 1", with: "[100,200)")
-    fill_in("Range Guard 2", with: "[30,40)")
-    press("OK")
+    press('Edit')
+    fill_in('Range Guard 1', with: '[100,200)')
+    fill_in('Range Guard 2', with: '[30,40)')
+    press('OK')
     wait_for_ajax
-    r = Gemini::XyzRule.get_matches('infinity', {}, {"g_range1"=> 150,
-                                                     "g_range2"=> 35})
+    r = Gemini::XyzRule.get_matches('infinity', {},  'g_range1' => 150,
+                                                     'g_range2' => 35)
 
     expect(r.to_a.count).to eq(1)
-    exp = {"user_id"=>1,
-           "o_user_id"=>nil,
-           "name"=>"ZRule1",
-           "engine"=>"Gemini::XyzRuleScriptSet",
-           "rule_type"=>"ZRule",
-           "start_dt"=>DateTime.parse("2017-1-1 08:01:00"),
-           "simple_guards"=>{"g_bool"=>false,
-                             "g_date"=>"2017-1-1",
-                             "g_range1"=>"[100,200)",
-                             "g_range2"=>"[30,40)",
-                             "g_string"=>"aaa",
-                             "g_integer"=>"5",
-                             "g_datetime"=>"2017-1-1 12:00:01"},
-           "computed_guards"=>{},
-           "grids"=>{"grid1"=>"DataGrid1"},
-           "results"=>
-           {"bvlen"=>"base_value.length",
-            "bv"=>"base_value"}}
+    exp = { 'user_id' => 1,
+           'o_user_id' => nil,
+           'name' => 'ZRule1',
+           'engine' => 'Gemini::XyzRuleScriptSet',
+           'rule_type' => 'ZRule',
+           'start_dt' => DateTime.parse('2017-1-1 08:01:00'),
+           'simple_guards' => { 'g_bool' => false,
+                             'g_date' => '2017-1-1',
+                             'g_range1' => '[100,200)',
+                             'g_range2' => '[30,40)',
+                             'g_string' => 'aaa',
+                             'g_integer' => '5',
+                             'g_datetime' => '2017-1-1 12:00:01' },
+           'computed_guards' => {},
+           'grids' => { 'grid1' => 'DataGrid1' },
+           'results' =>
+           { 'bvlen' => 'base_value.length',
+            'bv' => 'base_value' } }
 
     expect(r.first.as_json).to include(exp)
-    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(["aaa", "bbb", "ccc", "ddd",
-                                                     "eee", "eee", "eee", "eee"])
-    click_column(xrv, "String list Guard")
-    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(["eee", "eee", "eee", "eee",
-                                                     "ddd", "ccc", "bbb", "aaa"])
-    column_filter(xrv, "String list Guard", "eee")
+    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(['aaa', 'bbb', 'ccc', 'ddd',
+                                                     'eee', 'eee', 'eee', 'eee'])
+    click_column(xrv, 'String list Guard')
+    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(['eee', 'eee', 'eee', 'eee',
+                                                     'ddd', 'ccc', 'bbb', 'aaa'])
+    column_filter(xrv, 'String list Guard', 'eee')
     rc = xrv.row_count
-    expect(xrv.get_col_vals(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee"])
-    column_filter_toggle(xrv, "String list Guard")
+    expect(xrv.get_col_vals(:g_string, rc, 0)).to eq(['eee', 'eee', 'eee', 'eee'])
+    column_filter_toggle(xrv, 'String list Guard')
     rc = xrv.row_count
-    expect(xrv.get_col_vals(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee",
-                                                    "ddd", "ccc", "bbb", "aaa"])
-    column_filter(xrv, "Grids", "Grid1")
+    expect(xrv.get_col_vals(:g_string, rc, 0)).to eq(['eee', 'eee', 'eee', 'eee',
+                                                      'ddd', 'ccc', 'bbb', 'aaa'])
+    column_filter(xrv, 'Grids', 'Grid1')
     rc = xrv.row_count
     # netzke reports jsonb as string
-    expect(xrv.get_col_vals(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid1"}),
-                                                 %Q({"grid1":"DataGrid1"})])
-    column_filter_toggle(xrv, "Grids")
+    expect(xrv.get_col_vals(:grids, rc, 0)).to eq([%Q({"grid1":"DataGrid1"}),
+                                                   %Q({"grid1":"DataGrid1"})])
+    column_filter_toggle(xrv, 'Grids')
     rc = xrv.row_count
-    expect(xrv.get_col_vals(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid3"}),
-                                                 %Q({"grid1":"DataGrid3"}),
-                                                 %Q({"grid1":"DataGrid3"}),
-                                                 %Q({"grid1":"DataGrid3"}),
-                                                 %Q({"grid1":"DataGrid3"}),
-                                                 %Q({"grid1":"DataGrid2"}),
-                                                 %Q({"grid1":"DataGrid1"}),
-                                                 %Q({"grid1":"DataGrid1"})])
-    press("Applications")
-    press("Data Grids")
-    dgv = netzke_find("data_grid_view")
+    expect(xrv.get_col_vals(:grids, rc, 0)).to eq([%Q({"grid1":"DataGrid3"}),
+                                                   %Q({"grid1":"DataGrid3"}),
+                                                   %Q({"grid1":"DataGrid3"}),
+                                                   %Q({"grid1":"DataGrid3"}),
+                                                   %Q({"grid1":"DataGrid3"}),
+                                                   %Q({"grid1":"DataGrid2"}),
+                                                   %Q({"grid1":"DataGrid1"}),
+                                                   %Q({"grid1":"DataGrid1"})])
+    press('Applications')
+    press('Data Grids')
+    dgv = netzke_find('data_grid_view')
     cvs = dgv.get_col_vals(:name, 4, 0)
-    ind1 = cvs.index("DataGrid1")+1
-    ind4 = cvs.index("DataGrid4")+1
+    ind1 = cvs.index('DataGrid1') + 1
+    ind4 = cvs.index('DataGrid4') + 1
     dgv.select_row(ind1)
-    press("Edit")
-    fill_in("Name", with: "DataGrid1 new")
-    press("OK")
+    press('Edit')
+    fill_in('Name', with: 'DataGrid1 new')
+    press('OK')
     wait_for_ajax
     dgv.select_row(ind4)
-    press("Edit")
-    fill_in("Name", with: "DataGrid4 new")
-    press("OK")
+    press('Edit')
+    fill_in('Name', with: 'DataGrid4 new')
+    press('OK')
     wait_for_ajax
 
     go_to_xyz_rules
@@ -408,9 +414,9 @@ EOL
 
     names = xrv.get_col_vals(:name, 5, 0)
     gvs = xrv.get_col_vals(:grids, 5, 0)
-    g1h = {"grid1"=>"DataGrid1 new"}
-    expect(JSON.parse(gvs[names.index("ZRule1")])).to eq(g1h)
-    expect(JSON.parse(gvs[names.index("ZRule2")])).to eq(g1h)
+    g1h = { 'grid1' => 'DataGrid1 new' }
+    expect(JSON.parse(gvs[names.index('ZRule1')])).to eq(g1h)
+    expect(JSON.parse(gvs[names.index('ZRule2')])).to eq(g1h)
 
     go_to_my_rules
     wait_for_ajax
@@ -420,9 +426,8 @@ EOL
     rvs = mrv.get_col_vals(:results, 9, 0)
     expect(JSON.parse(gvs[names.index('abc')])).to eq(g1h)
     expect(JSON.parse(gvs[names.index('Rule2b')])).to eq(g1h +
-                                                         {"grid2"=>"DataGrid2"})
-    expect(JSON.parse(rvs[names.index('Rule5')])["other_grid"]).to eq(
-                                                                     '"DataGrid4 new"')
-
+                                                         { 'grid2' => 'DataGrid2' })
+    expect(JSON.parse(rvs[names.index('Rule5')])['other_grid']).to eq(
+      '"DataGrid4 new"')
   end
 end