mail_manager 3.0.0 → 3.2.0

data/spec/test_app/spec/features/navigation_spec.rb

@@ -0,0 +1,9 @@
+require 'rails_helper'
+
+RSpec.feature "Navigation" do
+  it "has a link for contacts", js: true do
+    visit "#{MailManager.site_url}/mail_manager/mailings"
+    click_link "Contacts"
+    expect(page.body).to have_content("Listing Contacts")
+  end
+end

data/spec/test_app/spec/helpers/mail_manager/layout_helper_spec.rb

@@ -0,0 +1,41 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::LayoutHelper, :type => :helper do
+  describe "#title" do
+    it "translates what you give it and returns when translation exists" do
+      expect(helper.title("mail_manager/mailing.edit.title", subject: "Bonkers", 
+        default: "Edit my 'Bonkers'")
+      ).to eq("<h1>Edit Bonkers</h1>")
+      and_it "then returns the same thing ... without the h1 tags on the subsequent call" do
+        expect(helper.title).to eq "Edit Bonkers"
+      end
+    end
+    it "translates to your default when your translation name doesn't exist" do
+      expect(helper.title("my.nonsense.title", subject: "Bonkers", 
+        default: "Edit my 'Bonkers'")
+      ).to eq("<h1>Edit my 'Bonkers'</h1>")
+      and_it "then returns the same thing ... without the h1 tags on the subsequent call" do
+        expect(helper.title).to eq "Edit my 'Bonkers'"
+      end
+    end
+  end
+  describe "#site_url" do
+    it "returns the mail manager's site_url setting as a helper" do
+      expect{helper.site_url}.not_to raise_error
+      expect(helper.site_url).to eq(MailManager.site_url)
+    end
+  end
+  describe "#show_title?" do
+    it "returns the mail manager's show_title setting as a helper" do
+      expect{helper.show_title?}.not_to raise_error
+      expect(helper.show_title?).to eq(MailManager.show_title)
+    end
+  end
+  describe "#use_show_for_resources?" do
+    it "returns the mail manager's use_show_for_resources setting as a helper" do
+      expect{helper.use_show_for_resources?}.not_to raise_error
+      expect(helper.use_show_for_resources?).to eq(MailManager.use_show_for_resources)
+    end
+  end
+  
+end

data/spec/test_app/spec/helpers/mail_manager/subscriptions_helper_spec.rb

@@ -0,0 +1,14 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::SubscriptionsHelper, :type => :helper do
+  describe "#contactable_subscriptions_selector" do
+    it "creates a subform for a contact's mailing list subscriptions" do
+      FactoryGirl.create(:mailing_list, name: "Peeps", defaults_to_active: true)
+      FactoryGirl.create(:mailing_list, name: "Others", defaults_to_active: false)
+      form_for MailManager::Contact.new, url: '/mail_manager/contacts', method: :post do |f|
+        expect(contactable_subscriptions_selector(f)).to match /Peeps/
+        expect(contactable_subscriptions_selector(f)).to match /Others/
+      end
+    end
+  end
+end

data/spec/test_app/spec/models/delayed/mailer_spec.rb

@@ -0,0 +1,27 @@
+require 'rails_helper'
+
+class BreakMe < Struct.new(:bob)
+  def perform
+    raise "I don't work!#{bob}"
+  end
+end
+
+RSpec.describe Delayed::Mailer do
+  it "sends an email when a job fails" do
+    Delayed::Worker.delay_jobs = true
+    Delayed::Worker.max_attempts = 0
+    Delayed::Job.delete_all
+    ActionMailer::Base.deliveries.clear
+    previous_method = ActionMailer::Base.delivery_method
+    ActionMailer::Base.delivery_method = :test
+    Delayed::Job.enqueue BreakMe.new("Funk")
+    Delayed::Worker.new(name: 'Bunk').work_off
+    Debugging::wait_until_success do
+      expect(ActionMailer::Base.deliveries.count).to eq(1)
+      expect(ActionMailer::Base.deliveries.first.body).to match /I don't work!Funk/
+    end
+    Delayed::Worker.delay_jobs = false
+    ActionMailer::Base.delivery_method = previous_method
+  end
+end
+

data/spec/test_app/spec/models/delayed/status_job_spec.rb

@@ -0,0 +1,13 @@
+require 'rails_helper'
+
+RSpec.describe Delayed::StatusJob do
+  it "recreates itself on success" do
+    Delayed::Worker.delay_jobs = true
+    Delayed::StatusJob.new.perform
+    expect(Delayed::Job.count).to eq(1)
+    expect(Delayed::Job.first.handler).to match /Delayed::StatusJob/
+    expect(Delayed::Job.first.run_at.utc.to_i).to be_within(5).of(
+      1.minute.from_now.utc.to_i
+    )
+  end
+end

data/spec/test_app/spec/models/delayed/status_spec.rb

@@ -0,0 +1,37 @@
+require 'rails_helper'
+
+RSpec.describe Delayed::Status do
+  before(:each) do 
+    Delayed::Worker.delay_jobs = true
+  end
+  after(:each) do
+    Timecop.return
+    Delayed::Worker.delay_jobs = false
+  end
+  it "Creates a status job when invoked and it doesn't yet exist" do
+    expect(Delayed::Status.ok?).to be true
+    expect(Delayed::Job.count).to eq(1)
+    expect(Delayed::Job.first.handler).to match /Delayed::StatusJob/
+    Timecop.travel 20.minutes.from_now
+    and_it "gripes when the status job is overdue for a run by the specified time" do
+      expect{Delayed::Status.ok?(15.minutes)}.to raise_error(
+        Delayed::StatusException, /Status job hasn't run for \d+ seconds/
+      )
+    end
+    and_it "gripes when the status job is overdue for a run for 15 minutes" do
+      expect{Delayed::Status.ok?}.to raise_error(
+        Delayed::StatusException, /Status job hasn't run for \d+ seconds/
+      )
+    end
+    and_it "is OK when the status job is overdue for only 20 minutes and you ask about 25" do
+      expect{Delayed::Status.ok?(25.minutes)}.not_to raise_error
+    end
+  end
+  it "gripes when you have failed jobs" do
+    Delayed::Status.ok?
+    Delayed::Job.first.update_attribute(:failed_at, Time.now.utc)
+    expect{Delayed::Status.ok?}.to raise_error(
+      Delayed::StatusException, "There are 1 failed jobs!"
+    )
+  end
+end

data/spec/test_app/spec/models/mail_manager/bounce_spec.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
-require 'spec_helper'
+require 'rails_helper'
 
-describe MailManager::Bounce do
+RSpec.describe MailManager::Bounce do
   context "when checking pop account" do
     it "should not blow up when mail contains a bad extended char" do
       Delayed::Worker.delay_jobs = true
@@ -9,9 +9,29 @@ describe MailManager::Bounce do
       MailManager::BounceJob.new.perform
       Delayed::Worker.delay_jobs = false
     end
+    it "should run every 10 minutes when there is mail on the current run" do
+      Delayed::Worker.delay_jobs = true
+      send_bounce('bad_utf8_chars.eml')
+      MailManager::BounceJob.new.perform
+      expect(Delayed::Job.count).to eq(1)
+      expect(Delayed::Job.first.run_at.utc.to_i).to be_within(5).of(
+        10.minutes.from_now.utc.to_i
+      )
+      Delayed::Worker.delay_jobs = false
+    end
+    it "should run every 120 minutes when there is no mail on the current check" do
+      Delayed::Worker.delay_jobs = true
+      MailManager::BounceJob.new.perform
+      Delayed::Job.delete_all
+      MailManager::BounceJob.new.perform
+      expect(Delayed::Job.count).to eq(1)
+      expect(Delayed::Job.first.run_at.utc.to_i).to be_within(5).of(
+        120.minutes.from_now.utc.to_i
+      )
+      Delayed::Worker.delay_jobs = false
+    end
   end
   def send_bounce(filename)
-    PostOffice.start_post_office
     mail = Mail.new(File.read(File.join(Rails.root,'spec','support','files',filename)))
     mail.delivery_method :smtp
     mail.delivery_method.settings.merge!(ActionMailer::Base.smtp_settings)

data/spec/test_app/spec/models/mail_manager/engine_spec.rb

@@ -0,0 +1,79 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::Engine do
+  it "knows its asset path" do
+    expect(MailManager.assets_path).to eq(File.join(MailManager::PLUGIN_ROOT, 'assets'))
+  end
+  context "when authentication is not needed" do
+    before(:each) do
+      MailManager.requires_authentication = false
+      MailManager.authorized_roles = []
+    end
+    it "authorizes a nil user" do
+      expect(MailManager.authorized?(nil)).to be true
+    end
+    it "authorizes an actual User" do 
+      expect(MailManager.authorized?(FactoryGirl.create(:user))).to be true
+    end
+  end
+  context "when only authentication is needed" do
+    before(:each) do
+      MailManager.requires_authentication = true
+      MailManager.authorized_roles = []
+    end
+    after(:each) do 
+      MailManager.requires_authentication = false
+    end
+    it "won't authorize a nil user" do
+      expect(MailManager.authorized?(nil)).to be false
+    end
+    it "authorizes an actual User" do 
+      expect(MailManager.authorized?(FactoryGirl.create(:user))).to be true
+    end
+  end
+  context "when authentication is needed with role 'admin'" do
+    before(:each) do
+      MailManager.requires_authentication = true
+      MailManager.authorized_roles = ['admin']
+    end
+    after(:each) do 
+      MailManager.requires_authentication = false
+      MailManager.authorized_roles = []
+    end
+    it "won't authorizes a nil user" do
+      expect(MailManager.authorized?(nil)).to be false
+    end
+    it "won't authorizes an object that doesn't respond to 'role' or 'roles'" do
+      expect(MailManager.authorized?(MailManager::Contact.new)).to be false
+    end
+    it "authorizes an actual User with roles ['admin']" do 
+      expect(MailManager.authorized?(FactoryGirl.create(:admin_user))).to be true
+    end
+    it "authorizes an actual User with role 'admin'" do 
+      expect(MailManager.authorized?(FactoryGirl.create(:admin_user_with_role))).to be true
+    end
+    it "won't authorize the user if they aren't an admin(admin role)" do
+      expect(MailManager.authorized?(FactoryGirl.create(:user))).to be false
+    end
+    context "and a roles_method is given" do
+      before(:each) do
+        MailManager.roles_method = "roles"
+      end
+      after(:each) do
+        MailManager.roles_method = nil
+      end
+      it "won't authorize if the user doesn't have that method" do
+        expect(MailManager.authorized?(FactoryGirl.create(:admin_user_with_role))).to be false
+      end
+      it "won't authorize a nil user" do
+        expect(MailManager.authorized?(nil)).to be false
+      end
+      it "won't authorize a users without the mentioned roles" do
+        expect(MailManager.authorized?(FactoryGirl.create(:user))).to be false
+      end
+      it "authorizes a user with the mentioned roles and method" do
+        expect(MailManager.authorized?(FactoryGirl.create(:user))).to be false
+      end
+    end
+  end
+end

data/spec/test_app/spec/models/mail_manager/mailable_spec.rb

@@ -0,0 +1,10 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::Mailable do
+  let(:mailable) {FactoryGirl.build(:mailable)}
+  it "responds to mailable attributes for creating a mailing's content" do
+    expect(mailable).to respond_to (:email_html) 
+    expect(mailable).to respond_to (:email_text) 
+    expect(mailable).to respond_to (:name) 
+  end
+end

data/spec/test_app/spec/models/mail_manager/mailer_spec.rb

@@ -1,9 +1,41 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe MailManager::Mailer do
+RSpec.describe MailManager::Mailer do
   it "Can fetch images from https servers" do
     image_url = 'https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRwNmnMYLBp2Sw9vg-snbZ_GKONKo_WY0f3S1ETL2era2DZKKqD'
     data = MailManager::Mailer.fetch(image_url)
     expect(data.to_s[0..100]).to include('JFIF')
+    and_it "knows a jpeg when getting extension from its data" do
+      expect(MailManager::Mailer.get_extension_from_data(data)).to eq "JPEG"
+    end
   end
-end
+  context "can get an image's extension from its data" do
+    it "for gifs" do
+      image = MailManager::Mailer.fetch("file://" + File.join(MailManager::PLUGIN_ROOT, 'app','assets','images','mail_manager','BottomRight.gif'))
+      expect(MailManager::Mailer.get_extension_from_data(image).upcase).to eq 'GIF'
+    end
+    it "for garbage data" do
+      image = "THIS IS NOT AN IMAGE BLAH BHAL"
+      expect(MailManager::Mailer.get_extension_from_data(image).upcase).to eq ''
+    end
+  end
+  it "sets its delivery methods correctly" do
+    mail = Mail.new
+    ActionMailer::Base.delivery_method = :smtp
+    previous_settings = ActionMailer::Base.smtp_settings
+    ActionMailer::Base.smtp_settings = smtp_settings = {
+      domain: 'example.com',
+      address: 'mail.lvh.me',
+      port: 587,
+      password: 'Secret1!',
+      user_name: 'bobo',
+      enable_starttls_auto: true,
+      authentication: :plain,
+    }
+    MailManager::Mailer.set_mail_settings(mail)
+    expect(mail.delivery_method.settings.values.map(&:to_s).select(&:present?).sort).to eq(
+      smtp_settings.values.select(&:present?).map(&:to_s).sort
+    )
+    ActionMailer::Base.smtp_settings = previous_settings
+  end
+end 

data/spec/test_app/spec/models/mail_manager/mailing_list_spec.rb

@@ -1,15 +1,15 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe MailManager::MailingList do
+RSpec.describe MailManager::MailingList do
   context "a valid mailing list" do
     before(:each) do
       @mailing_list = FactoryGirl.build(:mailing_list)
     end
     it "must have a name" do 
-      @mailing_list.name.present?.should == true
-      @mailing_list.valid?.should == true
+      expect(@mailing_list.name.present?).to eq true
+      expect(@mailing_list.valid?).to eq true
       @mailing_list.name = nil
-      @mailing_list.valid?.should == false
+      expect(@mailing_list.valid?).to eq false
     end
   end
 end

data/spec/test_app/spec/models/mail_manager/mailing_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::Mailing do
+  let(:valid_attributes) {FactoryGirl.attributes_for(:mailing)}
+  let(:invalid_attributes) {FactoryGirl.attributes_for(:mailing).delete(
+    'from_email_address')
+  }
+  before(:each) do
+    ActionMailer::Base.delivery_method = :test
+    Delayed::Worker.delay_jobs = false
+    ActionMailer::Base.deliveries.clear
+  end
+  it "sets its initial status properly" do
+    attributes = valid_attributes
+    attributes.delete('status')
+    attributes.delete('status_updated_at')
+    mailing = MailManager::Mailing.new(attributes)
+    mailing.save
+    expect(mailing.status.to_s).to eq('pending')
+    expect(mailing.status_changed_at).not_to be nil
+  end
+  it "will soft delete a mailing" do
+    mailing = MailManager::Mailing.create(valid_attributes)
+    mailing.delete
+    expect(MailManager::Mailing.count).to eq 0
+    expect(MailManager::Mailing.deleted.count).to eq 1
+  end
+  it "doesn't include images when configured to not do so for a domain" do
+    # should be in config
+    image_url = "http://www.lone-star.net/graphics/lst_header_logo.png"
+    expect(MailManager.dont_include_images_domains).to include('yahoo.com')
+    mailing = FactoryGirl.create(:mailing, include_images: true)
+    mailing.mailable.update_attribute(:email_html, mailing.mailable.email_html.gsub(%r#file://.*/iReach_logo.gif#,image_url))
+    mailing.send_test_message('bobo@yahoo.com')
+    html_body = ActionMailer::Base.deliveries.last.parts.last.body
+    expect(html_body).to match /#{image_url}/
+    expect(html_body).not_to match %r#cid:#
+  end
+  it "doesn't include images when include_images is false" do
+    # should be in config
+    image_url = "http://www.lone-star.net/graphics/lst_header_logo.png"
+    expect(MailManager.dont_include_images_domains).to include('yahoo.com')
+    mailing = FactoryGirl.create(:mailing, include_images: false)
+    mailing.mailable.update_attribute(:email_html, mailing.mailable.email_html.gsub(%r#file://.*/iReach_logo.gif#,image_url))
+    mailing.send_test_message('bobo@example.com')
+    html_body = ActionMailer::Base.deliveries.last.parts.last.body
+    expect(html_body).to match /#{image_url}/
+    expect(html_body).not_to match %r#cid:#
+  end
+  it "does include images when its configuration doesn't exclude an email domain" do
+    image_url = "http://www.lone-star.net/graphics/lst_header_logo.png"
+    expect(MailManager.dont_include_images_domains).not_to include('example.com')
+    mailing = FactoryGirl.create(:mailing, include_images: true)
+    mailing.mailable.update_attribute(:email_html, mailing.mailable.email_html.gsub(%r#file://.*/iReach_logo.gif#,image_url))
+    mailing.send_test_message('bobo@example.com')
+    html_body = ActionMailer::Base.deliveries.last.to_s =~ /cid:=/
+  end
+end

data/spec/test_app/spec/models/mail_manager/message_spec.rb

@@ -0,0 +1,112 @@
+require 'rails_helper'
+
+RSpec.describe MailManager::Message do
+  def message
+    @message
+  end
+  before(:each) do 
+    @message = FactoryGirl.create(:message)
+  end
+  describe "concerning statuses" do
+    it "starts in :pending" do
+      expect(message.status).to eq('pending')
+    end
+    it "goes to 'sent' on a deliver" do
+      message.save
+      message.deliver
+      expect(message.status).to eq('sent')
+    end
+    it "goes to 'failed_address' on a message bounce" do
+      pending "need to get a failed worthy bounce!"
+      raise "not tested"
+    end
+    it "stays 'sent' on a temporary message bounce" do
+      pending "need to get a temporary bounce!"
+      raise "not tested"
+    end
+    it "goes to 'processing' while it is being sent" do
+      pending "figure this out... its in the middle of a deliver"
+      raise "not tested"
+    end
+    describe "and can't be delivered unless it is currently pending or ready" do
+      it "when pending can be delivered" do
+        expect(message.can_deliver?).to be true
+      end
+      it "when ready can be delivered" do
+        message.change_status('ready')
+        expect(message.can_deliver?).to be true
+      end
+      it "when processing cannot be delivered" do
+        message.change_status('processing')
+        expect(message.can_deliver?).to be false
+      end
+      it "when sent cannot be delivered" do
+        message.change_status('sent')
+        expect(message.can_deliver?).to be false
+      end
+      it "when failed cannot be delivered" do
+        message.change_status('failed')
+        expect(message.can_deliver?).to be false
+      end
+    end
+  end
+
+  it "has a email_address_with_name when a name is present on the contact" do
+    contact = message.contact
+    expect(message.email_address_with_name).to eq(%Q|"#{contact.full_name}" <#{contact.email_address}>|)
+    and_it "only has email when the contact has no name" do
+      message.contact.update_attributes(first_name: nil, last_name: nil)
+      expect(message.email_address_with_name).to eq(contact.email_address)
+    end
+  end
+
+  it "knows its mailing's subject" do
+    expect(message.subject).to eq(message.mailing.subject)
+  end
+
+  it "knows its contact's full name" do
+    expect(message.full_name).to eq(message.contact.full_name)
+  end
+
+  context "concerning a deleted contact" do
+    before(:each) do
+      @contact = MailManager::Contact.find(message.contact_id)
+      @contact.delete
+      @message = MailManager::Message.find(message.id)
+    end
+    it "doesn't blow up when asking for full_name" do
+      expect(message.full_name).to eq @contact.full_name
+    end
+    it "doesn't blow up when asking for email_address" do
+      expect(message.email_address).to eq @contact.email_address
+    end
+  end
+
+  context "concerning a nil contact" do
+    before(:each) do
+      MailManager::Contact.where(id: message.contact_id).delete_all
+      @message = MailManager::Message.find(message.id)
+    end
+    it "doesn't blow up when asking for full_name" do
+      expect(message.full_name).to eq nil
+    end
+    it "doesn't blow up when asking for email_address" do
+      expect(message.email_address).to eq nil
+    end
+  end
+
+  describe "concerning a contact's data" do 
+    it "will substitute values into messages" do
+      pending "not tested" 
+      raise "not tested"
+    end
+  end
+
+  describe "concerning a registerd contactable's data" do 
+    it "will substitute values into messages" do
+      pending "not tested" 
+      raise "not tested"
+    end
+  end
+
+end