mail_manager 3.0.0 → 3.2.0

data/spec/test_app/spec/controllers/users_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 # This spec was generated by rspec-rails when you ran the scaffold generator.
 # It demonstrates how one might use RSpec to specify the controller code that
@@ -18,51 +18,57 @@ require 'spec_helper'
 # Message expectations are only used when there is no simpler way to specify
 # that an instance is receiving a specific message.
 
-describe UsersController do
+RSpec.describe UsersController, :type => :controller do
 
   # This should return the minimal set of attributes required to create a valid
   # User. As you add validations to User, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) { FactoryGirl.attributes_for(:user) }
+  let(:valid_attributes) {
+    FactoryGirl.attributes_for(:user)
+  }
+
+  let(:invalid_attributes) {
+    FactoryGirl.attributes_for(:user, email: nil)
+  }
 
   # This should return the minimal set of values that should be in the session
   # in order to pass any filters (e.g. authentication) defined in
   # UsersController. Be sure to keep this updated too.
   let(:valid_session) { {} }
 
-  describe "GET index" do
+  describe "GET #index" do
     it "assigns all users as @users" do
       user = User.create! valid_attributes
       get :index, {}, valid_session
-      assigns(:users).should eq([user])
+      expect(assigns(:users)).to eq([user])
     end
   end
 
-  describe "GET show" do
+  describe "GET #show" do
     it "assigns the requested user as @user" do
       user = User.create! valid_attributes
       get :show, {:id => user.to_param}, valid_session
-      assigns(:user).should eq(user)
+      expect(assigns(:user)).to eq(user)
     end
   end
 
-  describe "GET new" do
+  describe "GET #new" do
     it "assigns a new user as @user" do
       get :new, {}, valid_session
-      assigns(:user).should be_a_new(User)
+      expect(assigns(:user)).to be_a_new(User)
     end
   end
 
-  describe "GET edit" do
+  describe "GET #edit" do
     it "assigns the requested user as @user" do
       user = User.create! valid_attributes
       get :edit, {:id => user.to_param}, valid_session
-      assigns(:user).should eq(user)
+      expect(assigns(:user)).to eq(user)
     end
   end
 
-  describe "POST create" do
-    describe "with valid params" do
+  describe "POST #create" do
+    context "with valid params" do
       it "creates a new User" do
         expect {
           post :create, {:user => valid_attributes}, valid_session
@@ -71,78 +77,73 @@ describe UsersController do
 
       it "assigns a newly created user as @user" do
         post :create, {:user => valid_attributes}, valid_session
-        assigns(:user).should be_a(User)
-        assigns(:user).should be_persisted
+        expect(assigns(:user)).to be_a(User)
+        expect(assigns(:user)).to be_persisted
       end
 
       it "redirects to the created user" do
         post :create, {:user => valid_attributes}, valid_session
-        response.should redirect_to(User.last)
+        expect(response).to redirect_to(User.last)
       end
     end
 
-    describe "with invalid params" do
+    context "with invalid params" do
       it "assigns a newly created but unsaved user as @user" do
-        # Trigger the behavior that occurs when invalid params are submitted
-        User.any_instance.stub(:save).and_return(false)
-        post :create, {:user => { "first_name" => "invalid value" }}, valid_session
-        assigns(:user).should be_a_new(User)
+        post :create, {:user => invalid_attributes}, valid_session
+        expect(assigns(:user)).to be_a_new(User)
       end
 
       it "re-renders the 'new' template" do
-        # Trigger the behavior that occurs when invalid params are submitted
-        User.any_instance.stub(:save).and_return(false)
-        post :create, {:user => { "first_name" => "invalid value" }}, valid_session
-        response.should render_template("new")
+        post :create, {:user => invalid_attributes}, valid_session
+        expect(response).to render_template("new")
       end
     end
   end
 
-  describe "PUT update" do
-    describe "with valid params" do
+  describe "PUT #update" do
+    context "with valid params" do
+      let(:new_attributes) {
+        FactoryGirl.attributes_for(:user) 
+      }
+
       it "updates the requested user" do
         user = User.create! valid_attributes
-        # Assuming there are no other users in the database, this
-        # specifies that the User created on the previous line
-        # receives the :update_attributes message with whatever params are
-        # submitted in the request.
-        User.any_instance.should_receive(:update_attributes).with({ "first_name" => "MyString" })
-        put :update, {:id => user.to_param, :user => { "first_name" => "MyString" }}, valid_session
+        put :update, {:id => user.to_param, :user => new_attributes}, valid_session
+        user = User.find(user.id)
+        new_attributes.each_pair do |key,value|
+          expect(user.send(key)).to eq(value)
+        end
       end
 
       it "assigns the requested user as @user" do
         user = User.create! valid_attributes
         put :update, {:id => user.to_param, :user => valid_attributes}, valid_session
-        assigns(:user).should eq(user)
+        expect(assigns(:user)).to eq(user)
       end
 
       it "redirects to the user" do
         user = User.create! valid_attributes
         put :update, {:id => user.to_param, :user => valid_attributes}, valid_session
-        response.should redirect_to(user)
+        expect(response).to redirect_to(user)
       end
     end
 
-    describe "with invalid params" do
+    context "with invalid params" do
       it "assigns the user as @user" do
         user = User.create! valid_attributes
-        # Trigger the behavior that occurs when invalid params are submitted
-        User.any_instance.stub(:save).and_return(false)
-        put :update, {:id => user.to_param, :user => { "first_name" => "invalid value" }}, valid_session
-        assigns(:user).should eq(user)
+        put :update, {:id => user.to_param, :user => invalid_attributes}, valid_session
+        expect(assigns(:user)).to eq(user)
       end
 
       it "re-renders the 'edit' template" do
         user = User.create! valid_attributes
-        # Trigger the behavior that occurs when invalid params are submitted
-        User.any_instance.stub(:save).and_return(false)
-        put :update, {:id => user.to_param, :user => { "first_name" => "invalid value" }}, valid_session
-        response.should render_template("edit")
+        put :update, {:id => user.to_param, :user => invalid_attributes}, valid_session
+        expect(response).to render_template("edit")
       end
     end
   end
 
-  describe "DELETE destroy" do
+  describe "DELETE #destroy" do
     it "destroys the requested user" do
       user = User.create! valid_attributes
       expect {
@@ -153,7 +154,7 @@ describe UsersController do
     it "redirects to the users list" do
       user = User.create! valid_attributes
       delete :destroy, {:id => user.to_param}, valid_session
-      response.should redirect_to(users_url)
+      expect(response).to redirect_to(users_url)
     end
   end
 

data/spec/test_app/spec/factories/_functions.rb

@@ -0,0 +1,27 @@
+def random_bool
+  Kernel.rand(2) == 1
+end
+
+def random_int(min,max)
+  count = max - min + 1
+  Kernel.rand(count) + min
+end
+
+def random_decimal(min,max,precision=2)
+  multiplier = 10 ** precision
+  count = max - min + 1
+  puts "multiplier: #{multiplier}"
+  (Kernel.rand(count * multiplier) + min * multiplier).to_f / multiplier
+end
+
+def random_value(values)
+  values[random_int(0,(values.length-1))]
+end
+
+def generate_plain_text_from_html(html)
+  IO.popen('lynx -stdin --dump','w+') do |lynx|
+    lynx.write html
+    lynx.close_write
+    lynx.readlines.join
+  end
+end

data/spec/test_app/spec/factories/contacts.rb

@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :contact, class: MailManager::Contact do
+    first_name          {Faker::Name.first_name}
+    last_name           {Faker::Name.first_name}
+    email_address       {Faker::Internet.email}
+  end
+end

data/spec/test_app/spec/factories/mail_manager_bounces.rb

@@ -0,0 +1,13 @@
+FactoryGirl.define do
+  factory :bounce, :class => 'MailManager::Bounce' do
+    status {random_value([:needs_manual_intervention,:unprocessed,:dismissed,
+      :resolved,:invalid
+    ])}
+    #status_changed_at {Time.now}
+    #bounce_message 
+    #comments 
+    #message nil
+    #mailing nil
+  end
+
+end

data/spec/test_app/spec/factories/mailable.rb

@@ -0,0 +1,8 @@
+FactoryGirl.define do
+  factory :mailable, class: MailManager::Mailable do
+    name        {Faker::Company.bs.split(/\s+/).map(&:capitalize).join(" ")}
+    email_html  {|a| %Q|<html><head><title>#{a.name}</title></head><body><h1>#{a.name}</h1><p><img src="file://#{MailManager::PLUGIN_ROOT}/app/assets/images/mail_manager/iReach_logo.gif"/><br/>#{Faker::Lorem.paragraphs.join("</p><p>")}</p></body></html>|}
+    email_text  {|a| generate_plain_text_from_html(a.email_html)}
+  end
+end
+

data/spec/test_app/spec/factories/mailings.rb

@@ -1,6 +1,12 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
 
 FactoryGirl.define do
-  factory :mailing do
+  factory :mailing, class: MailManager::Mailing do
+    subject             {Faker::Company.bs.split(/\s+/).map(&:capitalize).join(' ')}
+    from_email_address  {Faker::Internet.email}
+    scheduled_at        {Time.now.utc}
+    mailable_type       "MailManager::Mailable"
+    mailable_id         {(MailManager::Mailable.first || FactoryGirl.create(:mailable)).id}
+    include_images      {random_int(0,1)}
   end
 end

data/spec/test_app/spec/factories/message.rb

@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :message, class: MailManager::Message do
+    mailing             {MailManager::Mailing.first || FactoryGirl.create(:mailing)} 
+    contact             {MailManager::Contact.first || FactoryGirl.create(:contact)}
+    from_email_address  {|a| a.contact.email_address}
+  end
+end

data/spec/test_app/spec/factories/users.rb

@@ -1,10 +1,22 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
-
-FactoryGirl.define do
-  factory :user do
-    first_name {Faker::Name.first_name}
-    last_name {Faker::Name.last_name}
-    email {Faker::Internet.email}
-    phone {Faker::PhoneNumber.phone_number}
+begin
+  FactoryGirl.define do
+    factory :user do
+      first_name {Faker::Name.first_name}
+      last_name {Faker::Name.last_name}
+      email {Faker::Internet.email}
+      phone {Faker::PhoneNumber.phone_number}
+      factory :admin_user do
+        last_name 'admin'
+      end
+    end
+    factory :admin_user_with_role, class: UserWithRole do
+      first_name {Faker::Name.first_name}
+      last_name 'admin'
+      email {Faker::Internet.email}
+      phone {Faker::PhoneNumber.phone_number}
+    end
   end
+rescue FactoryGirl::DuplicateDefinitionError => e
+  # this is ok ... duplicates when iReach uses it
 end

data/spec/test_app/spec/features/mail_manager/bounce_spec.rb

@@ -0,0 +1,73 @@
+require 'rails_helper'
+
+RSpec.feature MailManager::Bounce do
+  context "without any bounces" do
+    it "should render the page" do
+      visit mail_manager.bounces_path
+      expect(page.status_code).to eq(200)
+      expect(page.body).to match /Listing Bounces/
+    end
+    it "should render the page when an unsent mailing exists" do
+      FactoryGirl.create(:mailing)
+      visit mail_manager.bounces_path
+      expect(page.status_code).to eq(200)
+      expect(page.body).to match /Listing Bounces/
+    end
+    context "when searching", js: true do
+      before(:each) do
+        @mailing1 = FactoryGirl.create(:mailing)
+        @mailing2 = FactoryGirl.create(:mailing)
+        @bounce1 = FactoryGirl.create(:bounce, mailing_id: @mailing1.id, status: 'needs_manual_intervention') 
+        @bounce2 = FactoryGirl.create(:bounce, mailing_id: @mailing2.id, status: 'resolved') 
+        @bounce3 = FactoryGirl.create(:bounce, status: 'invalid') 
+        @mailing1.reload
+        @mailing2.reload
+      end
+      it "filters by mailing", js: true do
+        visit "/mail_manager/bounces"
+        select "#{@mailing1.subject} (#{I18n.l @mailing1.status_changed_at}) (#{@mailing1.bounces.size})", from: "Mailing:"
+        expect(page).to have_css("#view_bounce_#{@bounce1.id}", count: 1)
+        expect(page).to have_content("View",count: 1)
+      end
+      it "shows them all", js: true do
+        visit "/mail_manager/bounces"
+        expect(page).to have_css("#view_bounce_#{@bounce1.id}", count: 1)
+        expect(page).to have_css("#view_bounce_#{@bounce2.id}", count: 1)
+        expect(page).to have_css("#view_bounce_#{@bounce3.id}", count: 1)
+        expect(page).to have_content("View",count: 3)
+      end
+      it "filters by 'Needs Attention' status" do
+        visit "/mail_manager/bounces"
+        select "Needs Attention", from: "Status:"
+        expect(page).to have_css("#view_bounce_#{@bounce1.id}", count: 1)
+        expect(page).to have_content("View",count: 1)
+      end
+      it "filters by 'Resolved' status" do
+        visit "/mail_manager/bounces"
+        select "Resolved", from: "Status:"
+        expect(page).to have_css("#view_bounce_#{@bounce2.id}", count: 1)
+        expect(page).to have_content("View",count: 1)
+      end
+      it "doesn't show 'invalid' status" do
+        visit "/mail_manager/bounces"
+        expect{select "Invalid", from: "Status:"}.to raise_error
+      end
+      it "filters by 'Resolved' status and mailing" do
+        visit "/mail_manager/bounces"
+        select "Needs Attention", from: "Status:"
+        select "#{@mailing1.subject} (#{I18n.l @mailing1.status_changed_at}) (#{@mailing1.bounces.size})", from: "Mailing:"
+        expect(page).to have_css("#view_bounce_#{@bounce1.id}", count: 1)
+        expect(page).to have_content("View",count: 1)
+      end
+      it "filter by mailing and status can hide all bounces" do
+        visit "/mail_manager/bounces"
+        select "Resolved", from: "Status:"
+        Debugging::wait_until_success do
+          expect(page).to have_content("View",count: 1)
+        end
+        select "#{@mailing1.subject} (#{I18n.l @mailing1.status_changed_at}) (#{@mailing1.bounces.size})", from: "Mailing:"
+        expect(page).to have_content "No bounces"
+      end
+    end
+  end
+end

data/spec/test_app/spec/features/mail_manager/double_opt_in_spec.rb

@@ -0,0 +1,62 @@
+require 'rails_helper'
+
+RSpec.feature "Double Opt In Subscribe" do
+  before(:each) do
+    @mailing_list = FactoryGirl.create(:mailing_list)
+    MailManager::MailingList.update_all("id=1")
+    @mailing_list = MailManager::MailingList.find(1)
+    @other_mailing_list = FactoryGirl.create(:mailing_list)
+  end
+  it "creates a double opt in email when creating a new contact/subscription", truncate: true do
+    ActionMailer::Base.deliveries.clear
+    ActionMailer::Base.delivery_method = :test
+    Delayed::Worker.delay_jobs = false
+    visit "/subscribe.html" 
+    fill_in "First Name", with: "Bobo"
+    fill_in "Last Name", with: "Clown"
+    fill_in "Email", with: "bobo@example.com"
+    click_button "Join"
+    Debugging::wait_until_success do
+      expect(MailManager::Contact.count).to eq 1
+      expect(MailManager::Subscription.count).to eq 1
+    end
+    contact = MailManager::Contact.first
+    subscription = MailManager::Subscription.first
+    expect(subscription.status).to eq 'pending'
+    email = ActionMailer::Base.deliveries.last
+    expect(ActionMailer::Base.deliveries.length).to eq 1
+    expect(email.to_s).to match /Confirm Newsletter Subscription/
+    and_it "email has the login token" do
+      expect(email.to_s).to match /#{contact.login_token}/
+    end
+    and_it "will give a new token if you try to opt in with a token that is more than 3 days old" do
+      Timecop.travel 3.days.from_now
+      old_token = contact.login_token
+      visit "#{MailManager.double_opt_in_path}/#{contact.login_token}"
+      contact = MailManager::Contact.find(contact.id)
+      expect(page).to have_content "Your token has expired"
+      expect(ActionMailer::Base.deliveries.length).to eq 2
+      expect(contact.login_token).not_to eq old_token
+    end
+    and_it "can confirm its subscription" do
+      visit "#{MailManager.double_opt_in_path}/#{contact.login_token}"
+      expect(MailManager::Subscription.count).to eq 1
+      subscription.reload
+      expect(subscription.status).to eq 'active'
+    end
+    Timecop.return
+  end
+  it "doesn't pay attention when the honeypot is submitted" do
+    ActionMailer::Base.deliveries.clear
+    ActionMailer::Base.delivery_method = :test
+    Delayed::Worker.delay_jobs = false
+    visit "/subscribe.html" 
+    fill_in "First Name", with: "Bobo"
+    fill_in "Last Name", with: "Clown"
+    fill_in "Email", with: "bobo@example.com"
+    find(:css, "#company_name").set("FaSchizzle")
+    click_button "Join"
+    expect(MailManager::Contact.count).not_to eq 1
+    expect(MailManager::Subscription.count).not_to eq 1
+  end
+end

data/spec/test_app/spec/features/mail_manager/mailing_spec.rb

@@ -0,0 +1,46 @@
+require 'rails_helper'
+
+RSpec.feature MailManager::Mailing, type: :feature do
+  context "a created mailing" do
+    before(:each) do
+      @mailing = FactoryGirl.create(:mailing)
+    end
+    it "soft deletes from the index page" do
+      visit "/mail_manager/mailings"
+      click_link "Delete"
+      expect(page).to have_content "Mailing successfully deleted"
+      expect(MailManager::Mailing.count).to eq 0
+      expect(MailManager::Mailing.deleted.count).to eq 1
+    end
+    it "doesn't blow up when trying to schedule a mailing with no scheduled_at" do
+      @mailing.update_attribute(:scheduled_at, nil)
+      visit "/mail_manager/mailings"
+      expect{click_link "Schedule"}.to raise_error
+      page.driver.put("/mail_manager/mailings/#{@mailing.id}/schedule")
+      expect(page.status_code).to eq 302
+      visit page.response_headers['Location']
+      expect(page.body).to have_content "Error! You must edit your mailing and set a time for your mailing to run."
+    end
+    it "can be scheduled" do
+      Delayed::Worker.delay_jobs = true
+      visit "/mail_manager/mailings"
+      click_link "Schedule"
+      expect(page).to have_content "Mailing scheduled"
+      @mailing = MailManager::Mailing.find(@mailing)
+      expect(@mailing.status).to eq "scheduled"
+      expect(Delayed::Job.count).to eq 1
+      and_it "can then be cancelled and its job removed" do
+        mailing2 = FactoryGirl.create(:mailing)
+        mailing2.schedule
+        expect(Delayed::Job.count).to eq 2
+        visit "/mail_manager/mailings"
+        click_link "cancel_mailing_#{@mailing.id}"
+        expect(page).to have_content "Mailing cancelled"
+        expect(Delayed::Job.count).to eq 1
+        expect(Delayed::Job.first.payload_object.object.id).to eql mailing2.id
+      end
+      Delayed::Worker.delay_jobs = false
+    end
+  end
+end
+