lolcommits 0.17.2 → 0.17.3

data/lib/lolcommits/test_helpers/git_repo.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Lolcommits
   module TestHelpers
     module GitRepo
@@ -8,11 +6,11 @@ module Lolcommits
       end
 
       def repo_path
-        '/tmp/lolcommits-plugin-test-repo'
+        "/tmp/lolcommits-plugin-test-repo"
       end
 
       def repo_exists?
-        File.directory?(File.expand_path(repo_path, '.git'))
+        File.directory?(File.expand_path(repo_path, ".git"))
       end
 
       def last_commit
@@ -25,7 +23,7 @@ module Lolcommits
         `git init --quiet #{repo_path}`
       end
 
-      def commit_repo_with_message(message = 'test message', file_name: 'test.txt', file_content: 'testing')
+      def commit_repo_with_message(message = "test message", file_name: "test.txt", file_content: "testing")
         setup_repo unless repo_exists?
         `echo '#{file_content}' >> #{repo_path}/#{file_name}`
         `cd #{repo_path} && git add #{file_name}`

data/lib/lolcommits/vcs_info.rb

@@ -1,12 +1,10 @@
-# frozen_string_literal: true
-
 module Lolcommits
   class VCSInfo
-    def self.repo_root?(path = '.')
+    def self.repo_root?(path = ".")
       GitInfo.repo_root?(path) || MercurialInfo.repo_root?(path)
     end
 
-    def self.local_name(path = '.')
+    def self.local_name(path = ".")
       if GitInfo.repo_root?(path)
         GitInfo.local_name(path)
       elsif MercurialInfo.repo_root?(path)

data/lib/lolcommits/version.rb

@@ -1,6 +1,4 @@
-# frozen_string_literal: true
-
 module Lolcommits
-  VERSION  = "0.17.2"
+  VERSION  = "0.17.3"
   GEM_NAME = "lolcommits"
 end

data/lib/lolcommits.rb

@@ -1,41 +1,37 @@
-# frozen_string_literal: true
+require "mini_magick"
+require "fileutils"
+require "git"
+require "open3"
+require "date"
+require "mercurial-ruby"
 
-$LOAD_PATH.unshift File.expand_path('.')
-
-require 'mini_magick'
-require 'fileutils'
-require 'git'
-require 'open3'
-require 'optparse_plus'
-require 'date'
-require 'mercurial-ruby'
-
-require 'lolcommits/version'
-require 'lolcommits/configuration'
-require 'lolcommits/capturer'
-require 'lolcommits/vcs_info'
-require 'lolcommits/installation'
-require 'lolcommits/platform'
-require 'lolcommits/gem_plugin'
-require 'lolcommits/plugin_manager'
-require 'lolcommits/plugin/base'
+require "lolcommits/version"
+require "lolcommits/cli"
+require "lolcommits/configuration"
+require "lolcommits/capturer"
+require "lolcommits/vcs_info"
+require "lolcommits/installation"
+require "lolcommits/platform"
+require "lolcommits/gem_plugin"
+require "lolcommits/plugin_manager"
+require "lolcommits/plugin/base"
 
 # after lolcommits/platform, so that we can do platform-conditional override
-require 'core_ext/mercurial-ruby/command'
-require 'core_ext/mercurial-ruby/shell'
+require "core_ext/mercurial-ruby/command"
+require "core_ext/mercurial-ruby/shell"
 
 # String#encode patched to be Ruby 3.0+ compatible
-require 'core_ext/mercurial-ruby/changed_file'
+require "core_ext/mercurial-ruby/changed_file"
 # Mercurial::ConfigFile#exists? patched to be Ruby 3.2+ compatible
-require 'core_ext/mercurial-ruby/config_file'
+require "core_ext/mercurial-ruby/config_file"
 # Mercurial::Repository.open patched to be Ruby 3.2+ compatible
-require 'core_ext/mercurial-ruby/repository'
+require "core_ext/mercurial-ruby/repository"
 
 # backends
-require 'lolcommits/backends/installation_git'
-require 'lolcommits/backends/installation_mercurial'
-require 'lolcommits/backends/git_info'
-require 'lolcommits/backends/mercurial_info'
+require "lolcommits/backends/installation_git"
+require "lolcommits/backends/installation_mercurial"
+require "lolcommits/backends/git_info"
+require "lolcommits/backends/mercurial_info"
 
 # require runner after all the plugins have been required
-require 'lolcommits/runner'
+require "lolcommits/runner"

data/lolcommits.gemspec

@@ -1,15 +1,11 @@
-# frozen_string_literal: true
-
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'lolcommits/version'
+require_relative 'lib/lolcommits/version'
 
 Gem::Specification.new do |s|
   s.name    = Lolcommits::GEM_NAME.dup
   s.version = Lolcommits::VERSION.dup
 
-  s.authors = ['Matthew Rothenberg', 'Matthew Hutchinson']
-  s.email   = ['mrothenberg@gmail.com', 'matt@hiddenloop.com']
+  s.authors = [ 'Matthew Rothenberg', 'Matthew Hutchinson' ]
+  s.email   = [ 'mrothenberg@gmail.com', 'matt@hiddenloop.com' ]
   s.license = 'LGPL-3.0'
   s.summary = 'Capture webcam image on git commit for lulz.'
 
@@ -24,13 +20,13 @@ Gem::Specification.new do |s|
     'source_code_uri' => 'https://github.com/lolcommits/lolcommits',
     'changelog_uri' => 'https://github.com/lolcommits/lolcommits/blob/master/CHANGELOG.md',
     'bug_tracker_uri' => 'https://github.com/lolcommits/lolcommits/issues',
-    'allowed_push_host' => 'https://rubygems.org'
+    'allowed_push_host' => 'https://rubygems.org',
+'rubygems_mfa_required' => 'true'
   }
 
   s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,features}/*`.split("\n")
   s.executables   = 'lolcommits'
-  s.require_paths = ['lib']
+  s.require_paths = [ 'lib' ]
 
   # non-gem dependencies
   s.required_ruby_version = '>= 3.1'
@@ -38,25 +34,28 @@ Gem::Specification.new do |s|
   s.requirements << 'a webcam'
 
   # core
-  s.add_runtime_dependency('optparse-plus', '~> 3.0.1')
-  s.add_runtime_dependency('mercurial-ruby', '~> 0.7.12')
-  s.add_runtime_dependency('mini_magick', '~> 5.0.1')
-  s.add_runtime_dependency('launchy', '~> 3.0.1')
-  s.add_runtime_dependency('open4', '~> 1.3.4')
-  s.add_runtime_dependency('git', '~> 2.3.0')
-  s.add_runtime_dependency('logger')
-  s.add_runtime_dependency('ostruct')
-  s.add_runtime_dependency('base64')
+  s.add_dependency('base64')
+  s.add_dependency('git', '~> 2.3.3')
+  s.add_dependency('launchy', '~> 3.0.1')
+  s.add_dependency('logger')
+  s.add_dependency('mercurial-ruby', '~> 0.7.12')
+  s.add_dependency('mini_magick', '~> 5.0.1')
+  s.add_dependency('open4', '~> 1.3.4')
+  s.add_dependency('optparse-plus', '~> 3.0.1')
+  s.add_dependency('ostruct')
 
   # included plugins
-  s.add_runtime_dependency('lolcommits-loltext', '~> 0.5.0')
+  s.add_dependency('lolcommits-loltext', '~> 0.5.0')
+
+  # rubocop
+  s.add_dependency('rubocop')
+  s.add_dependency('rubocop-performance')
 
   # development & test gems
   s.add_development_dependency('aruba')
-  s.add_development_dependency('rake')
-  s.add_development_dependency('rdoc')
   s.add_development_dependency('debug')
-  s.add_development_dependency('rubocop')
-  s.add_development_dependency('minitest')
   s.add_development_dependency('ffaker')
+  s.add_development_dependency('minitest')
+  s.add_development_dependency('rake')
+  s.add_development_dependency('rdoc')
 end

data/test/permissions_test.rb

@@ -1,6 +1,4 @@
-# frozen_string_literal: true
-
-require File.expand_path("#{File.dirname(__FILE__)}/test_helper")
+require "test_helper"
 
 class PermissionsTest < Minitest::Test
   #
@@ -8,12 +6,12 @@ class PermissionsTest < Minitest::Test
   # this will test the permissions but only locally, important before building a gem package!
   #
   def test_permissions
-    imagesnap_perms  = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, 'vendor', 'ext', 'imagesnap', 'imagesnap')).mode & 0o777
-    videosnap_perms  = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, 'vendor', 'ext', 'videosnap', 'videosnap')).mode & 0o777
-    commandcam_perms = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, 'vendor', 'ext', 'CommandCam', 'CommandCam.exe')).mode & 0o777
+    imagesnap_perms  = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, "vendor", "ext", "imagesnap", "imagesnap")).mode & 0o777
+    videosnap_perms  = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, "vendor", "ext", "videosnap", "videosnap")).mode & 0o777
+    commandcam_perms = File.lstat(File.join(Lolcommits::Configuration::LOLCOMMITS_ROOT, "vendor", "ext", "CommandCam", "CommandCam.exe")).mode & 0o777
 
-    assert [0o755, 0o775].include?(imagesnap_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: imagesnap_perms}"
-    assert [0o755, 0o775].include?(videosnap_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: videosnap_perms}"
-    assert [0o755, 0o775].include?(commandcam_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: commandcam_perms}"
+    assert [ 0o755, 0o775 ].include?(imagesnap_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: imagesnap_perms}"
+    assert [ 0o755, 0o775 ].include?(videosnap_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: videosnap_perms}"
+    assert [ 0o755, 0o775 ].include?(commandcam_perms), "expected perms of 755/775 but instead got #{format '%<perms>o', perms: commandcam_perms}"
   end
 end

data/test/test_helper.rb

@@ -1,4 +1,2 @@
-# frozen_string_literal: true
-
-require 'lolcommits'
-require 'minitest/autorun'
+require "minitest/autorun"
+require "lolcommits"

metadata

@@ -1,130 +1,129 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits
 version: !ruby/object:Gem::Version
-  version: 0.17.2
+  version: 0.17.3
 platform: ruby
 authors:
 - Matthew Rothenberg
 - Matthew Hutchinson
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-22 00:00:00.000000000 Z
+date: 2025-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: optparse-plus
+  name: base64
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: mercurial-ruby
+  name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.12
+        version: 2.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.12
+        version: 2.3.3
 - !ruby/object:Gem::Dependency
-  name: mini_magick
+  name: launchy
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.1
+        version: 3.0.1
 - !ruby/object:Gem::Dependency
-  name: launchy
+  name: logger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: open4
+  name: mercurial-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.4
+        version: 0.7.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.4
+        version: 0.7.12
 - !ruby/object:Gem::Dependency
-  name: git
+  name: mini_magick
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 5.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 5.0.1
 - !ruby/object:Gem::Dependency
-  name: logger
+  name: open4
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.4
 - !ruby/object:Gem::Dependency
-  name: ostruct
+  name: optparse-plus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.1
 - !ruby/object:Gem::Dependency
-  name: base64
+  name: ostruct
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -152,13 +151,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.5.0
 - !ruby/object:Gem::Dependency
-  name: aruba
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -166,13 +165,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -180,7 +179,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -208,7 +207,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: ffaker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -236,7 +235,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ffaker
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -261,13 +274,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitattributes"
-- ".github/workflows/build.yml"
-- ".github/workflows/push_gem.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
+- ".quickhook/pre-commit/ruby-lint"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -276,8 +286,9 @@ files:
 - PULL_REQUEST_TEMPLATE.md
 - README.md
 - Rakefile
-- bin/console
+- bin/cucumber
 - bin/lolcommits
+- bin/rubocop
 - features/bugs.feature
 - features/lolcommits.feature
 - features/step_definitions/lolcommits_steps.rb
@@ -332,7 +343,6 @@ files:
 - vendor/ext/imagesnap/ReadMeOrDont.rtf
 - vendor/ext/imagesnap/imagesnap
 - vendor/ext/videosnap/videosnap
-homepage: 
 licenses:
 - LGPL-3.0
 metadata:
@@ -341,7 +351,7 @@ metadata:
   changelog_uri: https://github.com/lolcommits/lolcommits/blob/master/CHANGELOG.md
   bug_tracker_uri: https://github.com/lolcommits/lolcommits/issues
   allowed_push_host: https://rubygems.org
-post_install_message: 
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -358,8 +368,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - imagemagick
 - a webcam
-rubygems_version: 3.5.16
-signing_key: 
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Capture webcam image on git commit for lulz.
 test_files: []

data/.gitattributes

@@ -1 +0,0 @@
-* text=auto

data/.github/workflows/push_gem.yml

@@ -1,25 +0,0 @@
-name: Publish gem to RubyGems.org
-
-on:
-  push:
-    tags:
-      - v*
-
-jobs:
-  push:
-    name: Push gem to RubyGems.org
-    runs-on: ubuntu-latest
-
-    permissions:
-      id-token: write
-      contents: write
-
-    steps:
-      - uses: actions/checkout@v4
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          bundler-cache: true
-          ruby-version: ruby
-
-      - uses: rubygems/release-gem@v1

data/.rubocop_todo.yml

@@ -1,97 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2023-05-14 21:38:57 UTC using RuboCop version 1.50.2.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/HeredocIndentation:
-  Exclude:
-    - 'lib/lolcommits/backends/installation_git.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'lib/lolcommits/cli/process_runner.rb'
-
-# Offense count: 15
-# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
-Metrics/AbcSize:
-  Max: 33
-
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 144
-
-# Offense count: 5
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Metrics/CyclomaticComplexity:
-  Max: 10
-
-# Offense count: 20
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
-Metrics/MethodLength:
-  Max: 24
-
-# Offense count: 5
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Metrics/PerceivedComplexity:
-  Max: 10
-
-# Offense count: 26
-# Configuration parameters: AllowedConstants.
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-# SupportedShorthandSyntax: always, never, either, consistent
-Style/HashSyntax:
-  Exclude:
-    - 'lib/lolcommits/gem_plugin.rb'
-    - 'lib/lolcommits/runner.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/MapToHash:
-  Exclude:
-    - 'lib/lolcommits/plugin/base.rb'
-
-# Offense count: 2
-Style/MixinUsage:
-  Exclude:
-    - 'Rakefile'
-    - 'features/support/env.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'Rakefile'
-    - 'features/support/path_helpers.rb'
-    - 'lib/lolcommits/backends/installation_mercurial.rb'
-    - 'lib/lolcommits/cli/fatals.rb'
-    - 'lib/lolcommits/installation.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'lib/lolcommits/version.rb'
-
-# Offense count: 16
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 192