lolcommits 0.17.2 → 0.17.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '088cc7f1206089c7bd38c2fcddfb70b66564cf7ad9aec31d431515107ab8443f'
-  data.tar.gz: fa276c54847eef35ad780762328f15748509bb741b04c5d96b6ebd2b2bea4e1c
+  metadata.gz: 8d8e9cff0aadf2b23edaba08d06365120f9df98f30b8fab33e045c77366e5f6b
+  data.tar.gz: a89d150bc79d4f06a9d4a1b0f56bae48d82f4f743546dba98058d56950709899
 SHA512:
-  metadata.gz: f5e2796f8a1493519602e6027f39e6b6aa644a1dece4e5141de16a6a2d1bd81c677ba2079a4ccf335da0d60b37fa7a79e040cc6887f0c3bde46ce38df9fab7b4
-  data.tar.gz: a17dcd832fcb303dac024e6d5b4a18782c3d58e073a9ae064c69785d2fd428c2b87756d865bcfd2d38fe0d69e2ad32aba62eb23026c0d13ec430c39461a26d23
+  metadata.gz: 80656983ff03c1ad1bfbdb624dd2393b403e2fdc3bfc7ac2d0898eebc377433cf98b64a3d3a97b08d0197662e00942419a07fbb5d5ce53f154db58ba59c16af3
+  data.tar.gz: cbd743c08d7cbb9d34b2bcaeb1e787ea274c41d64efd7f670333861e69363b7ac0bc810e0a6bba4f8cfdf80ed9dbfd9edd069a4730e9d33f5508405e73bf5635

data/.github/workflows/{build.yml → ci.yml}

@@ -1,46 +1,51 @@
-name: Tests, features and style
+name: CI
 
 on:
   push:
-    branches: [ "main" ]
+    branches:
+      - main
   pull_request:
-    branches: [ "main" ]
-
-permissions:
-  contents: read
-
+    branches:
+      - main
 jobs:
-  test:
+  rubocop:
+    name: RuboCop
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Ruby
+    - name: Setup Ruby and install rubocop
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: '3.4'
+        ruby-version: 3.4
         bundler-cache: true
-    - name: Run tests
-      run: bundle exec rake test
-  rubocop:
+    - name: Run rubocop
+      run: bin/rubocop --parallel
+  tests:
+    name: Unit tests
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Ruby
+    - name: Set up Ruby and install gems
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: '3.4'
+        ruby-version: 3.4
         bundler-cache: true
-    - name: Run rubocop
-      run: bundle exec rake rubocop
+    - name: Run tests
+      run: bundle exec rake test
   features:
+    name: ${{ format('Features (Ruby {0})', matrix.ruby-version) }}
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ['3.1', '3.2', '3.3', '3.4']
+        ruby-version:
+          - "3.1"
+          - "3.2"
+          - "3.3"
+          - "3.4"
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Ruby
+    - name: Set up Ruby and install gems
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
@@ -53,12 +58,12 @@ jobs:
       uses: FedericoCarboni/setup-ffmpeg@v3
     - name: Set up mplayer
       run: sudo apt-get install -y mplayer
-    - name: Configure git user name, email
+    - name: Configure Git
       run: |
-        git config user.name $NAME
-        git config user.email $EMAIL
+        git config --global user.name $NAME
+        git config --global user.email $EMAIL
       env:
         NAME: "George Costanza"
         EMAIL: "george.costanza@vandelay.com"
-    - name: Run cucumber features
-      run: bundle exec rake features
+    - name: Run features
+      run: bin/cucumber --publish-quiet -f progress

data/.gitignore

@@ -13,3 +13,5 @@ doc
 *.swo
 vendor/bundle
 .idea
+checksums
+mise.toml

data/.quickhook/pre-commit/ruby-lint

@@ -0,0 +1,3 @@
+#!/bin/sh
+set -e
+grep -E "\.rb$|Rakefile|Gemfile" | xargs ./bin/rubocop --config .rubocop.yml --force-exclusion

data/.rubocop.yml

@@ -1,20 +1,320 @@
+require:
+  - rubocop-performance
+
 AllCops:
-  SuggestExtensions: false
   NewCops: enable
   Exclude:
-    - 'vendor/bundle/**/*'
-    - 'vendor/bundle/**/.*'
-    - '.bundle/**/*'
-    - 'bin/lolcommits'
-    - 'lolcommits.gemspec'
+    - 'vendor/**/*'
+    - 'tmp/**/*'
+  TargetRubyVersion: 3.1
+  SuggestExtensions: false
+
+Naming/InclusiveLanguage:
+  Enabled: true
+  CheckStrings: true
+  FlaggedTerms:
+    ' a offense':
+      Suggestions:
+        - an offense
+    auto-correct:
+      Suggestions:
+        - autocorrect
+    auto_correct:
+      Suggestions:
+        - autocorrect
+    behaviour:
+      Suggestions:
+        - behavior
+    offence:
+      Suggestions:
+        - offense
+
+Naming/PredicateName:
+  # Method define macros for dynamically generated method.
+  MethodDefinitionMacros:
+    - define_method
+    - define_singleton_method
+    - def_node_matcher
+    - def_node_search
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle:
+    - key
+    - table
+  EnforcedColonStyle:
+    - key
+    - table
+
+Layout/EndOfLine:
+  EnforcedStyle: lf
+
+Layout/ClassStructure:
+  Enabled: true
+  Categories:
+    module_inclusion:
+      - include
+      - prepend
+      - extend
+  ExpectedOrder:
+    - module_inclusion
+    - constants
+    - public_class_methods
+    - initializer
+    - instance_methods
+    - protected_methods
+    - private_methods
+
+Layout/RedundantLineBreak:
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  MethodCreatingMethods:
+    - 'def_matcher'
+    - 'def_node_matcher'
 
-Style/IfUnlessModifier:
+Metrics/BlockLength:
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - '*.gemspec'
+
+Performance/DeletePrefix:
+  SafeMultiline: false
+
+Performance/DeleteSuffix:
+  SafeMultiline: false
+
+inherit_mode:
+  merge:
+    - Exclude
+
+# All cops except your using extensions are disabled by default.
+Bundler:
+  Enabled: false
+Layout:
+  Enabled: false
+Lint:
+  Enabled: false
+Metrics:
+  Enabled: false
+Naming:
+  Enabled: false
+Performance:
+  Enabled: false
+  Exclude:
+    - "test/**/*"
+Security:
+  Enabled: false
+Style:
   Enabled: false
 
-Style/StringLiterals:
+# Align `when` with `end`.
+Layout/CaseIndentation:
+  Enabled: true
+  EnforcedStyle: end
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+#
+# We break this rule in context, though, e.g. for private-only concerns,
+# so we leave it disabled.
+Layout/IndentationConsistency:
   Enabled: false
+  EnforcedStyle: indented_internal_methods
+
+# Detect hard tabs, no hard tabs.
+Layout/IndentationStyle:
+  Enabled: true
+
+# Two spaces, no tabs (for indentation).
+#
+# Doesn't behave properly with private-only concerns, so it's disabled.
+Layout/IndentationWidth:
+  Enabled: false
+
+Layout/LeadingCommentSpace:
+  Enabled: true
 
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+# Use `->(x, y) { x + y }` not `-> (x, y) { x + y }`
+Layout/SpaceInLambdaLiteral:
+  Enabled: true
+
+# Use `[ a, [ b, c ] ]` not `[a, [b, c]]`
+# Use `[]` not `[ ]`
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: true
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBrackets: no_space
+
+# Use `%w[ a b ]` not `%w[ a   b ]`.
+Layout/SpaceInsideArrayPercentLiteral:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+# Use `foo { }` not `foo {}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+  EnforcedStyleForEmptyBraces: space
+
+# Use `{ a: 1 }` not `{a:1}`.
+# Use `{}` not `{  }`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBraces: no_space
+
+# Use `foo(bar)` not `foo( bar )`
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Requiring a space is not yet supported as of 0.59.2
+# Use `%w[ foo ]` not `%w[foo]`
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
+  #EnforcedStyle: space
+
+# Use `hash[:key]` not `hash[ :key ]`
+Layout/SpaceInsideReferenceBrackets:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Performance/FlatMap:
+  Enabled: true
+
+# We generally prefer &&/|| but like low-precedence and/or in context
+Style/AndOr:
+  Enabled: false
+
+# Prefer Foo.method over Foo::method
+Style/ColonMethodCall:
+  Enabled: true
+
+Style/DefWithParentheses:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+  EnforcedShorthandSyntax: either
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/ParenthesesAroundCondition:
+  Enabled: true
+
+Style/PercentLiteralDelimiters:
+  Enabled: true
+  PreferredDelimiters:
+    default: "()"
+    "%i": "[]"
+    "%I": "[]"
+    "%r": "{}"
+    "%w": "[]"
+    "%W": "[]"
+
+# Use quotes for string literals when they are enough.
+Style/RedundantPercentQ:
+  Enabled: false
+
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
+Style/StabbyLambdaParentheses:
+  Enabled: true
+
+# Use `"foo"` not `'foo'` unless escaping is required
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+  Include:
+    - "app/**/*"
+    - "config/**/*"
+    - "lib/**/*"
+    - "test/**/*"
+    - "Gemfile"
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
 
-inherit_from: .rubocop_todo.yml
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec