logster 1.2.1 → 1.2.2
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +3 -0
- data/lib/logster/base_store.rb +0 -2
- data/lib/logster/redis_store.rb +5 -3
- data/lib/logster/version.rb +1 -1
- data/test/logster/test_redis_store.rb +28 -0
- metadata +3 -2
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 3410af7ae9feb8efd0c52f4cb7c2867cccd7ea30
|
4
|
+
data.tar.gz: f3c684edca2d1417fc999c7ab8cb449beddfccc1
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: b07a76fbdd0e8d2ba64c9bbbd54f7ecad6e4e3fb113ce082daecd30aa13c56b8b12078c67c3b54bffd0e731b40e19465c142f045efedf6bc7b649291c864f1be
|
7
|
+
data.tar.gz: 115e47a420bd7c69e49885651a555ab2a31eacaad1cbdce5ecf62add358360ad5a0535a017e52e1beee337b5d4ae59c2b0273c42f2dc47769d2254c256ed7299
|
data/README.md
CHANGED
@@ -96,6 +96,9 @@ Logster UI is built using [Ember.js](http://emberjs.com/)
|
|
96
96
|
5. Create a new Pull Request
|
97
97
|
|
98
98
|
# CHANGELOG
|
99
|
+
- 2016-03-22: Version 1.2.2
|
100
|
+
- Fix: Conflicting attributes and method name for `Logster::RedisStore#rate_limits`.
|
101
|
+
- Fix: Rate limit checker was tracking limits too early. It should only track when a message has been bumped or saved.
|
99
102
|
|
100
103
|
- 2016-03-22: Version 1.2.1
|
101
104
|
- Feature: Add method to retrieve current rate from rate limiters.
|
data/lib/logster/base_store.rb
CHANGED
@@ -79,8 +79,6 @@ module Logster
|
|
79
79
|
return if (!msg || (String === msg && msg.empty?)) && skip_empty
|
80
80
|
return if level && severity < level
|
81
81
|
|
82
|
-
check_rate_limits(severity)
|
83
|
-
|
84
82
|
message = Logster::Message.new(severity, progname, msg, opts[:timestamp])
|
85
83
|
|
86
84
|
env = opts[:env] || {}
|
data/lib/logster/redis_store.rb
CHANGED
@@ -97,7 +97,6 @@ module Logster
|
|
97
97
|
|
98
98
|
attr_accessor :redis, :max_backlog, :redis_raw_connection
|
99
99
|
attr_writer :redis_prefix
|
100
|
-
attr_reader :rate_limits
|
101
100
|
|
102
101
|
def initialize(redis = nil)
|
103
102
|
super()
|
@@ -120,6 +119,7 @@ module Logster
|
|
120
119
|
end
|
121
120
|
|
122
121
|
trim
|
122
|
+
check_rate_limits(message.severity)
|
123
123
|
|
124
124
|
true
|
125
125
|
end
|
@@ -143,6 +143,8 @@ module Logster
|
|
143
143
|
@redis.rpush(list_key, message.key)
|
144
144
|
end
|
145
145
|
|
146
|
+
check_rate_limits(message.severity)
|
147
|
+
|
146
148
|
true
|
147
149
|
end
|
148
150
|
|
@@ -286,12 +288,12 @@ module Logster
|
|
286
288
|
@prefix_is_proc ? @redis_prefix.call : @redis_prefix
|
287
289
|
end
|
288
290
|
|
289
|
-
protected
|
290
|
-
|
291
291
|
def rate_limits
|
292
292
|
@rate_limits ||= {}
|
293
293
|
end
|
294
294
|
|
295
|
+
protected
|
296
|
+
|
295
297
|
def clear_solved(count = nil)
|
296
298
|
|
297
299
|
ignores = Set.new(@redis.hkeys(solved_key) || [])
|
data/lib/logster/version.rb
CHANGED
@@ -346,6 +346,34 @@ class TestRedisStore < Minitest::Test
|
|
346
346
|
end
|
347
347
|
end
|
348
348
|
|
349
|
+
def test_rate_limits_only_checks_when_message_is_bumped_or_saved
|
350
|
+
Logster.config.allow_grouping = true
|
351
|
+
Logster.config.application_version = 'abc'
|
352
|
+
|
353
|
+
@store.ignore = [/^ActiveRecord::RecordNotFound/]
|
354
|
+
rate_limit = @store.register_rate_limit_per_minute(Logger::WARN, 0)
|
355
|
+
|
356
|
+
message = @store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
|
357
|
+
assert_equal(1, rate_limit.retrieve_rate)
|
358
|
+
|
359
|
+
@store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
|
360
|
+
assert_equal(2, rate_limit.retrieve_rate)
|
361
|
+
|
362
|
+
@store.solve(message.key)
|
363
|
+
@store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
|
364
|
+
assert_equal(2, rate_limit.retrieve_rate)
|
365
|
+
|
366
|
+
@store.report(Logger::WARN, 'message 2', "Error!")
|
367
|
+
assert_equal(3, rate_limit.retrieve_rate)
|
368
|
+
|
369
|
+
@store.report(Logger::WARN, 'message 3', "ActiveRecord::RecordNotFound")
|
370
|
+
assert_equal(3, rate_limit.retrieve_rate)
|
371
|
+
ensure
|
372
|
+
Logster.config.allow_grouping = false
|
373
|
+
Logster.config.application_version = nil
|
374
|
+
reset_redis
|
375
|
+
end
|
376
|
+
|
349
377
|
def test_rate_limits_with_prefix
|
350
378
|
begin
|
351
379
|
time = Time.now
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: logster
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 1.2.
|
4
|
+
version: 1.2.2
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- UI for viewing logs in Rack
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2016-03-
|
11
|
+
date: 2016-03-29 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: bundler
|
@@ -216,3 +216,4 @@ test_files:
|
|
216
216
|
- test/logster/test_redis_rate_limiter.rb
|
217
217
|
- test/logster/test_redis_store.rb
|
218
218
|
- test/test_helper.rb
|
219
|
+
has_rdoc:
|