logster 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7977f29deaddc757de884805c3ab10ad34979dd
-  data.tar.gz: 6c02e339cc7ee928c4a84d97f8183058ae5a6149
+  metadata.gz: 3410af7ae9feb8efd0c52f4cb7c2867cccd7ea30
+  data.tar.gz: f3c684edca2d1417fc999c7ab8cb449beddfccc1
 SHA512:
-  metadata.gz: 586e6ffde7e7ae5a5e8e11ca762b8f5ed0e94342682cf39e3c12adf0f70da449b657f9dfe04f56efe09e52704221bc08907dcd7f67ad848b91270405cf603600
-  data.tar.gz: c0749406fcf8b7981bd555ca691e3531a41f775acf4909b4f13f106753b144212b57bfddc6c2fca280a75a3d04a6f117973ed46853e478f39616b3bcf34a5254
+  metadata.gz: b07a76fbdd0e8d2ba64c9bbbd54f7ecad6e4e3fb113ce082daecd30aa13c56b8b12078c67c3b54bffd0e731b40e19465c142f045efedf6bc7b649291c864f1be
+  data.tar.gz: 115e47a420bd7c69e49885651a555ab2a31eacaad1cbdce5ecf62add358360ad5a0535a017e52e1beee337b5d4ae59c2b0273c42f2dc47769d2254c256ed7299

data/README.md

@@ -96,6 +96,9 @@ Logster UI is built using [Ember.js](http://emberjs.com/)
 5. Create a new Pull Request
 
 # CHANGELOG
+- 2016-03-22: Version 1.2.2
+  - Fix: Conflicting attributes and method name for `Logster::RedisStore#rate_limits`.
+  - Fix: Rate limit checker was tracking limits too early. It should only track when a message has been bumped or saved.
 
 - 2016-03-22: Version 1.2.1
   - Feature: Add method to retrieve current rate from rate limiters.

data/lib/logster/base_store.rb

@@ -79,8 +79,6 @@ module Logster
       return if (!msg || (String === msg && msg.empty?)) && skip_empty
       return if level && severity < level
 
-      check_rate_limits(severity)
-
       message = Logster::Message.new(severity, progname, msg, opts[:timestamp])
 
       env = opts[:env] || {}

data/lib/logster/redis_store.rb

@@ -97,7 +97,6 @@ module Logster
 
     attr_accessor :redis, :max_backlog, :redis_raw_connection
     attr_writer :redis_prefix
-    attr_reader :rate_limits
 
     def initialize(redis = nil)
       super()
@@ -120,6 +119,7 @@ module Logster
       end
 
       trim
+      check_rate_limits(message.severity)
 
       true
     end
@@ -143,6 +143,8 @@ module Logster
         @redis.rpush(list_key, message.key)
       end
 
+      check_rate_limits(message.severity)
+
       true
     end
 
@@ -286,12 +288,12 @@ module Logster
       @prefix_is_proc ? @redis_prefix.call : @redis_prefix
     end
 
-    protected
-
     def rate_limits
       @rate_limits ||= {}
     end
 
+    protected
+
     def clear_solved(count = nil)
 
       ignores = Set.new(@redis.hkeys(solved_key) || [])

data/lib/logster/version.rb

@@ -1,3 +1,3 @@
 module Logster
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/test/logster/test_redis_store.rb

@@ -346,6 +346,34 @@ class TestRedisStore < Minitest::Test
     end
   end
 
+  def test_rate_limits_only_checks_when_message_is_bumped_or_saved
+    Logster.config.allow_grouping = true
+    Logster.config.application_version = 'abc'
+
+    @store.ignore = [/^ActiveRecord::RecordNotFound/]
+    rate_limit = @store.register_rate_limit_per_minute(Logger::WARN, 0)
+
+    message = @store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
+    assert_equal(1, rate_limit.retrieve_rate)
+
+    @store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
+    assert_equal(2, rate_limit.retrieve_rate)
+
+    @store.solve(message.key)
+    @store.report(Logger::WARN, 'message 1', "Error!", backtrace: 'here')
+    assert_equal(2, rate_limit.retrieve_rate)
+
+    @store.report(Logger::WARN, 'message 2', "Error!")
+    assert_equal(3, rate_limit.retrieve_rate)
+
+    @store.report(Logger::WARN, 'message 3', "ActiveRecord::RecordNotFound")
+    assert_equal(3, rate_limit.retrieve_rate)
+  ensure
+    Logster.config.allow_grouping = false
+    Logster.config.application_version = nil
+    reset_redis
+  end
+
   def test_rate_limits_with_prefix
     begin
       time = Time.now

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logster
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - UI for viewing logs in Rack
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-22 00:00:00.000000000 Z
+date: 2016-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -216,3 +216,4 @@ test_files:
 - test/logster/test_redis_rate_limiter.rb
 - test/logster/test_redis_store.rb
 - test/test_helper.rb
+has_rdoc: