lita-team 1.0.0 → 2.0.0

data/spec/lita/handlers/remove_member_from_team_spec.rb

@@ -0,0 +1,104 @@
+require "spec_helper"
+
+describe Lita::Handlers::RemoveMemberFromTeam,
+         lita_handler: true,
+         additional_lita_handlers:
+          [
+            Lita::Handlers::CreateTeam,
+            Lita::Handlers::BlockTeam,
+            Lita::Handlers::AddMemberToTeam
+          ] do
+  describe "remove member from team" do
+    it "removes a member from the team" do
+      send_command "create testing team"
+      send_command "testing team add mel"
+      send_command "testing team remove mel"
+      expect(replies.last).to eq("mel removed from the testing team")
+    end
+
+    context "me" do
+      it "removes current user from the team" do
+        send_command "create testing team"
+        send_command "testing team add me"
+        send_command "testing team remove me"
+        expect(replies.last).to eq("#{user.name} removed from the testing team")
+      end
+    end
+
+    context "+1" do
+      it "removes current user from the team" do
+        send_command "create testing team"
+        send_command "testing team +1"
+        send_command "testing team -1"
+        expect(replies.last).to eq("#{user.name} removed from the testing team")
+      end
+    end
+
+    context "mention" do
+      it "uses the lita users database" do
+        send_command "create testing team"
+        send_command "testing team add @Test"
+        send_command "testing team remove @Test"
+        expect(replies.last).to eq("Test User removed from the testing team")
+      end
+
+      it "removes @ from non-existing users" do
+        send_command "create testing team"
+        send_command "testing team add @james"
+        send_command "testing team remove @james"
+        expect(replies.last).to eq("james removed from the testing team")
+      end
+    end
+
+    context "there are members in the team" do
+      before do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add james"
+      end
+      context "there is a member in the team" do
+        it "removes the member and displays a message" do
+          send_command "testing team remove james"
+          expect(replies.last).
+            to eq("james removed from the testing team, 1 other is in")
+        end
+      end
+
+      context "there are two or more members in the team" do
+        it "adds the member and shows a message" do
+          send_command "testing team add robert"
+          send_command "testing team remove robert"
+          expect(replies.last).
+            to eq("robert removed from the testing team, 2 others are in")
+        end
+      end
+    end
+
+    context "the member is not in the team" do
+      it "does not remove anyone" do
+        send_command "create testing team"
+        send_command "testing team remove john"
+        expect(replies.last).to eq("john is not on the testing team")
+      end
+    end
+
+    context "team does not exist" do
+      it "does not remove the member" do
+        send_command "testing team remove john"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+
+    context "team blocked" do
+      it "does not remove the member" do
+        send_command "create testing team"
+        send_command "testing team add jhon"
+        send_command "block testing team"
+        send_command "testing team remove jhon"
+        reply =
+          "testing team is blocked. You cannot perform this operation"
+        expect(replies.last).to eq(reply)
+      end
+    end
+  end
+end

data/spec/lita/handlers/team_spec.rb

@@ -1,203 +1,4 @@
 require "spec_helper"
 
 describe Lita::Handlers::Team, lita_handler: true do
-  describe "create team" do
-    it "creates a new team" do
-      send_command "create testing team"
-      expect(replies.last).to eq("testing team created, add some people to it")
-    end
-
-    context "team already exists" do
-      it "does not create a new team" do
-        send_command "create testing team"
-        send_command "create testing team"
-        expect(replies.last).to eq("testing team already exists")
-      end
-    end
-  end
-
-  describe "delete team" do
-    it "deletes a team" do
-      send_command "create testing team"
-      send_command "delete testing team"
-      expect(replies.last).to eq("testing team deleted")
-    end
-
-    context "team does not exist" do
-      it "does not delete a team" do
-        send_command "delete testing team"
-        expect(replies.last).to eq("testing team does not exist")
-      end
-    end
-  end
-
-  describe "list teams" do
-    it "list all teams" do
-      send_command "create testing team"
-      send_command "create qa team"
-      send_command "list teams"
-      expect(replies.last).to eq("Teams:\nqa (0 members)\ntesting (0 members)\n")
-    end
-
-    context "without teams" do
-      it "shows a message" do
-        send_command "list teams"
-        expect(replies.last).to eq("No team has been created so far")
-      end
-    end
-  end
-
-  describe "add member to team" do
-    it "adds a member to the team" do
-      send_command "create testing team"
-      send_command "testing team add john"
-      expect(replies.last).to eq("john added to the testing team")
-    end
-
-    context "me" do
-      it "adds current user to the team" do
-        send_command "create testing team"
-        send_command "testing team add me"
-        expect(replies.last).to eq("#{user.name} added to the testing team")
-      end
-    end
-
-    context "+1" do
-      it "adds current user to the team" do
-        send_command "create testing team"
-        send_command "testing team +1"
-        expect(replies.last).to eq("#{user.name} added to the testing team")
-      end
-    end
-
-    context "there is a member in the team" do
-      it "adds the member and shows a message" do
-        send_command "create testing team"
-        send_command "testing team add john"
-        send_command "testing team add james"
-        expect(replies.last).to eq("james added to the testing team, 1 other is in")
-      end
-    end
-
-    context "there are two or more members in the team" do
-      it "adds the member and shows a message" do
-        send_command "create testing team"
-        send_command "testing team add john"
-        send_command "testing team add james"
-        send_command "testing team add robert"
-        expect(replies.last).to eq("robert added to the testing team, 2 others are in")
-      end
-    end
-
-    context "the member is already in the team" do
-      it "does not add the member to the team" do
-        send_command "create testing team"
-        send_command "testing team add john"
-        send_command "testing team add john"
-        expect(replies.last).to eq("john already in the testing team")
-      end
-    end
-
-    context "team does not exist" do
-      it "does not add the member" do
-        send_command "testing team add john"
-        expect(replies.last).to eq("testing team does not exist")
-      end
-    end
-  end
-
-  describe "remove member from team" do
-    it "removes a member from the team" do
-      send_command "create testing team"
-      send_command "testing team add john"
-      send_command "testing team remove john"
-      expect(replies.last).to eq("john removed from the testing team")
-    end
-
-    context "me" do
-      it "removes current user from the team" do
-        send_command "create testing team"
-        send_command "testing team add me"
-        send_command "testing team remove me"
-        expect(replies.last).to eq("#{user.name} removed from the testing team")
-      end
-    end
-
-    context "-1" do
-      it "removes current user from the team" do
-        send_command "create testing team"
-        send_command "testing team +1"
-        send_command "testing team -1"
-        expect(replies.last).to eq("#{user.name} removed from the testing team")
-      end
-    end
-
-    context "there are two or more members in the team" do
-      it "adds the member and shows a message" do
-        send_command "create testing team"
-        send_command "testing team add john"
-        send_command "testing team add james"
-        send_command "testing team remove john"
-        expect(replies.last).to eq("john removed from the testing team, 1 other is in")
-      end
-    end
-
-    context "the member is not in the team" do
-      it "does not removes the member from the team" do
-        send_command "create testing team"
-        send_command "testing team remove john"
-        expect(replies.last).to eq("john already out of the testing team")
-      end
-    end
-
-    context "team does not exist" do
-      it "does not add the member" do
-        send_command "testing team remove john"
-        expect(replies.last).to eq("testing team does not exist")
-      end
-    end
-  end
-
-  describe "list team" do
-    it "lists the members in the team" do
-      send_command "create testing team"
-      send_command "testing team add james"
-      send_command "testing team add john"
-      send_command "testing team list"
-      expect(replies.last).to eq("testing (2 members):\n1. james\n2. john\n")
-    end
-
-    context "team is empty" do
-      it "shows a message" do
-        send_command "create testing team"
-        send_command "testing team list"
-        expect(replies.last).to eq("There is no one in the testing team currently")
-      end
-    end
-
-    context "team does not exist" do
-      it "shows a message" do
-        send_command "testing team list"
-        expect(replies.last).to eq("testing team does not exist")
-      end
-    end
-  end
-
-  describe "clear team" do
-    it "removes the members of a team" do
-      send_command "create testing team"
-      send_command "testing team add john"
-      send_command "testing team clear"
-      expect(replies.last).to eq("testing team cleared")
-      send_command "testing team list"
-      expect(replies.last).to eq("There is no one in the testing team currently")
-    end
-
-    context "team does not exist" do
-      it "shows a message" do
-        send_command "testing team clear"
-        expect(replies.last).to eq("testing team does not exist")
-      end
-    end
-  end
 end

data/spec/lita/handlers/update_team_spec.rb

@@ -0,0 +1,41 @@
+require "spec_helper"
+
+describe Lita::Handlers::UpdateTeam,
+         lita_handler: true,
+         additional_lita_handlers: Lita::Handlers::CreateTeam do
+  describe "update team" do
+    context "set limit" do
+      it "set limit to a given value" do
+        send_command "create testing team"
+        send_command "testing team set limit 10"
+        expect(replies.last).
+          to eq("testing team limit set to 10")
+      end
+    end
+
+    context "set location" do
+      it "set location to a given value" do
+        send_command "create testing team"
+        send_command "testing team set location local place"
+        reply = "testing team location set to local place"
+        expect(replies.last).to eq(reply)
+      end
+    end
+
+    context "set icon" do
+      it "set icon to a given value" do
+        send_command "create testing team"
+        send_command "testing team set icon :love:"
+        expect(replies.last).
+          to eq("testing team icon set to :love:")
+      end
+    end
+
+    context "team does not exists" do
+      it "does not do anything" do
+        send_command "testing team set limit 10"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require "simplecov"
 require "coveralls"
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+SimpleCov.formatters = [
   SimpleCov::Formatter::HTMLFormatter,
   Coveralls::SimpleCov::Formatter
 ]

data/templates/list_team.erb

@@ -1,9 +1,12 @@
-<% if @team.members.empty? %>
-<%= I18n.t("lita.handlers.team.team_empty", team: @team.name) %>
+<% if @team[:members].empty? %>
+<%= I18n.t('lita.handlers.team.empty', team_name: @team[:name]) %>
 <% else %>
-<%= I18n.t("lita.handlers.team.team_summary", name: @team.name, count: @team.members.count) %>:
-<% @team.members.each_with_index do |member, i| %>
-<%= i + 1 %>. <%= member.name %>
+<%= @team[:name] %>
+
+<%= ":bust_in_silhouette: " + @team[:members].count.to_s %><%= " | " + @team[:icon] if @team[:icon] %><%= " " + @team[:location] if @team[:location] %><%= " | Max: " + @team[:limit].to_s if @team[:limit] %>
+
+<% @team[:members].each_with_index do |(key, member), i| %>
+<%= i + 1 %>. <%= member[:name] %><%= " :point_up:" if member[:confirmed] %>
 
 <% end %>
 <% end %>

data/templates/list_teams.erb

@@ -1,10 +1,4 @@
-<% if @teams.empty? %>
-<%= I18n.t("lita.handlers.team.no_teams_has_been_created") %>
-<% else %>
-<%= I18n.t("lita.handlers.team.teams_title") %>
-
+<%= I18n.t("lita.handlers.team.teams_title") %>:
 <% @teams.each do |team| %>
-<%= I18n.t("lita.handlers.team.team_summary", name: team.name, count: team.members.count) %>
-
-<% end %>
+<%= team[:name] %> (<%= team[:members].count %> :bust_in_silhouette:)
 <% end %>

data/templates/member_added_to_team.erb

@@ -1,4 +1,4 @@
-<%= I18n.t("lita.handlers.team.member_added_to_team", member: @member, team: @team) %>
+<%= I18n.t("lita.handlers.team.member.added", member_name: @member_name, team_name: @team_name) %>
 <% if @count > 0 %>
-<%= I18n.t("lita.handlers.team.members_in_team", count: @count) %>
+<%= I18n.t("lita.handlers.team.members_count", count: @count) %>
 <% end %>

data/templates/member_confirmed.erb

@@ -0,0 +1,4 @@
+<%= I18n.t("lita.handlers.team.member.confirmed", member_name: @member_name, team_name: @team_name) %>
+<% if @count > 0 %>
+<%= I18n.t("lita.handlers.team.unconfirmed_count", count: @count) %>
+<% end %>

data/templates/member_removed_from_team.erb

@@ -1,4 +1,4 @@
-<%= I18n.t("lita.handlers.team.member_removed_from_team", member: @member, team: @team.name) %>
-<% if @team.members.count > 0 %>
-<%= I18n.t("lita.handlers.team.members_in_team", count: @team.members.count) %>
+<%= I18n.t("lita.handlers.team.member.removed", member_name: @member_name, team_name: @team_name) %>
+<% if @count > 0 %>
+<%= I18n.t("lita.handlers.team.members_count", count: @count) %>
 <% end %>

data/templates/team_already_exists.erb

@@ -0,0 +1 @@
+<%= I18n.t('lita.handlers.team.already_exists', team_name: @team_name) %>

data/templates/team_blocked.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.blocked", team_name: @team_name) %>

data/templates/team_cannot_perform_operation.erb

@@ -0,0 +1 @@
+<%= I18n.t('lita.handlers.team.cannot_perform_operation', team_name: @team_name) %>

data/templates/team_created.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.created", team_name: @team_name) %>

data/templates/team_deleted.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.deleted", team_name: @team_name) %>

data/templates/team_not_found.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.not_found", team_name: @team_name) %>

data/templates/team_unblocked.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.unblocked", team_name: @team_name) %>

data/templates/team_updated.erb

@@ -0,0 +1 @@
+<%= I18n.t("lita.handlers.team.updated", team_name: @team_name, attribute: @attribute, value: @value) %>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-team
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Edgar Ortega
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-17 00:00:00.000000000 Z
+date: 2016-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.3'
+        version: '4.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.3'
+        version: '4.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -131,6 +131,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
@@ -138,28 +139,46 @@ files:
 - README.md
 - Rakefile
 - lib/lita-team.rb
-- lib/lita/actions/add_member_to_team.rb
-- lib/lita/actions/base.rb
-- lib/lita/actions/clear_team.rb
-- lib/lita/actions/create_team.rb
-- lib/lita/actions/delete_team.rb
-- lib/lita/actions/list_team.rb
-- lib/lita/actions/list_teams.rb
-- lib/lita/actions/remove_member_from_team.rb
+- lib/lita/handlers/add_member_to_team.rb
+- lib/lita/handlers/block_team.rb
+- lib/lita/handlers/clear_team.rb
+- lib/lita/handlers/confirm_member.rb
+- lib/lita/handlers/create_team.rb
+- lib/lita/handlers/delete_team.rb
+- lib/lita/handlers/list_team.rb
+- lib/lita/handlers/list_teams.rb
+- lib/lita/handlers/remove_member_from_team.rb
 - lib/lita/handlers/team.rb
-- lib/lita/member.rb
-- lib/lita/store/member.rb
-- lib/lita/store/team.rb
-- lib/lita/team.rb
+- lib/lita/handlers/update_team.rb
 - lita-team.gemspec
 - locales/en.yml
+- spec/lita/handlers/add_member_to_team_spec.rb
+- spec/lita/handlers/block_team_spec.rb
+- spec/lita/handlers/clear_team_spec.rb
+- spec/lita/handlers/confirm_member_spec.rb
+- spec/lita/handlers/create_team_spec.rb
+- spec/lita/handlers/delete_team_spec.rb
+- spec/lita/handlers/list_team_spec.rb
+- spec/lita/handlers/list_teams_spec.rb
+- spec/lita/handlers/remove_member_from_team_spec.rb
 - spec/lita/handlers/team_spec.rb
+- spec/lita/handlers/update_team_spec.rb
 - spec/spec_helper.rb
 - templates/.gitkeep
 - templates/list_team.erb
 - templates/list_teams.erb
 - templates/member_added_to_team.erb
+- templates/member_confirmed.erb
+- templates/member_not_on_team.erb
 - templates/member_removed_from_team.erb
+- templates/team_already_exists.erb
+- templates/team_blocked.erb
+- templates/team_cannot_perform_operation.erb
+- templates/team_created.erb
+- templates/team_deleted.erb
+- templates/team_not_found.erb
+- templates/team_unblocked.erb
+- templates/team_updated.erb
 homepage: https://github.com/EdgarOrtegaRamirez/lita-team
 licenses:
 - MIT
@@ -181,10 +200,20 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: create and manage the members of a team with Lita
 test_files:
+- spec/lita/handlers/add_member_to_team_spec.rb
+- spec/lita/handlers/block_team_spec.rb
+- spec/lita/handlers/clear_team_spec.rb
+- spec/lita/handlers/confirm_member_spec.rb
+- spec/lita/handlers/create_team_spec.rb
+- spec/lita/handlers/delete_team_spec.rb
+- spec/lita/handlers/list_team_spec.rb
+- spec/lita/handlers/list_teams_spec.rb
+- spec/lita/handlers/remove_member_from_team_spec.rb
 - spec/lita/handlers/team_spec.rb
+- spec/lita/handlers/update_team_spec.rb
 - spec/spec_helper.rb

data/lib/lita/actions/add_member_to_team.rb

@@ -1,38 +0,0 @@
-module Lita
-  module Actions
-    class AddMemberToTeam < Base
-
-      def call
-        if team
-          count_was = team.members.count
-          if create_member
-            response.reply render_template(:member_added_to_team, member: member_name, team: team_name, count: count_was)
-          else
-            response.reply t(:member_already_in_team, member: member_name, team: team_name)
-          end
-        else
-          response.reply t(:team_not_found, name: team_name)
-        end
-      end
-
-      private
-
-      def team_name
-        response.match_data[1]
-      end
-
-      def member_name
-        response.match_data[3] || response.user.mention_name
-      end
-
-      def team
-        @team ||= Lita::Team.find(team_name)
-      end
-
-      def create_member
-        Lita::Store::Member.create(member_name: member_name, team_name: team_name)
-      end
-
-    end
-  end
-end

data/lib/lita/actions/base.rb

@@ -1,28 +0,0 @@
-module Lita
-  module Actions
-    class Base
-      include Lita::Handler::Common
-
-      attr :response
-      @@template_root = nil
-
-      def initialize(response)
-        @response = response
-      end
-
-      def self.template_root(path = nil)
-        @@template_root = path if path
-        @@template_root
-      end
-
-      def robot
-        response.message.instance_variable_get :"@robot"
-      end
-
-      def translate(key, options = {})
-        I18n.translate("lita.handlers.team.#{key}", options)
-      end
-      alias_method :t, :translate
-    end
-  end
-end

data/lib/lita/actions/clear_team.rb

@@ -1,30 +0,0 @@
-module Lita
-  module Actions
-    class ClearTeam < Base
-
-      def call
-        if team_exists?
-          destroy_members
-          response.reply t(:team_cleared, name: team_name)
-        else
-          response.reply t(:team_not_found, name: team_name)
-        end
-      end
-
-      private
-
-      def team_name
-        response.match_data[1]
-      end
-
-      def team_exists?
-        Lita::Team.find(team_name)
-      end
-
-      def destroy_members
-        Lita::Store::Member.destroy_all(team_name: team_name)
-      end
-
-    end
-  end
-end