lita-team 1.0.0 → 2.0.0

data/lib/lita/handlers/remove_member_from_team.rb

@@ -0,0 +1,63 @@
+module Lita
+  module Handlers
+    class RemoveMemberFromTeam < Handler
+      namespace :team
+      template_root File.expand_path("../../../../templates", __FILE__)
+
+      route(
+        /(\S*) team (-1|remove me|remove (\S*))$/i,
+        :remove,
+        command: true,
+        help:
+        {
+          "<name> team -1" => "remove me from team",
+          "<name> team remove me" => "remove me from team",
+          "<name> team remove <member>" => "remove member from team"
+        }
+      )
+
+      def remove(response)
+        team_name = response.match_data[1]
+        if team = get_team(team_name)
+          if team[:limit] && team[:limit] <= team[:members].count
+            return response.reply(
+              render_template(:team_cannot_perform_operation,
+                              team_name: team_name)
+            )
+          else
+            member_name = (response.match_data[3] ||
+                           response.user.mention_name).delete("@")
+            if team[:members].key?(member_name.to_sym)
+              member = team[:members].delete(member_name.to_sym)
+              count = team[:members].count
+              redis.set(team_name, MultiJson.dump(team))
+              response.reply(
+                render_template(:member_removed_from_team,
+                                team_name: team_name,
+                                member_name: member[:name],
+                                count: count)
+              )
+            else
+              response.reply(
+                t("member.not_in_team",
+                  team_name: team_name,
+                  member_name: member_name)
+              )
+            end
+          end
+        else
+          response.reply(render_template(:team_not_found, team_name: team_name))
+        end
+      end
+
+      private
+
+      def get_team(team_name)
+        data = redis.get(team_name)
+        MultiJson.load(data, symbolize_keys: true) if data
+      end
+
+      Lita.register_handler(self)
+    end
+  end
+end

data/lib/lita/handlers/team.rb

@@ -1,58 +1,7 @@
 module Lita
   module Handlers
-    class Team
-      extend Lita::Handler::ChatRouter
-
-      route(/create (\S*) team/i, command: true, help: {
-        "create <name> team" => "create team called <name>"
-      }) do |response|
-        Lita::Actions::CreateTeam.new(response).call
-      end
-
-      route(/(delete|remove) (\S*) team/i, command: true, help: {
-        "delete <name> team" => "delete team called <name>",
-        "remove <name> team" => "delete team called <name>",
-      }) do |response|
-        Lita::Actions::DeleteTeam.new(response).call
-      end
-
-      route(/list teams/i, command: true, help: {
-        "list teams" => "list all teams"
-      }) do |response|
-        Lita::Actions::ListTeams.new(response).call
-      end
-
-      route(/(\S*) team (\+1|add me|add (\S*))/i, command: true, help: {
-        "<name> team +1" => "add me to team",
-        "<name> team add me" => "add me to team",
-        "<name> team add <user>" => "add user to team",
-      }) do |response|
-        Lita::Actions::AddMemberToTeam.new(response).call
-      end
-
-      route(/(\S*) team (-1|remove me|remove (\S*))/i, command: true, help: {
-        "<name> team -1" => "remove me from team",
-        "<name> team remove me" => "remove me from team",
-        "<name> team remove <user>" => "remove <user> from team",
-      }) do |response|
-        Lita::Actions::RemoveMemberFromTeam.new(response).call
-      end
-
-      route(/(\S*) team (list|show)/i, command: true, help: {
-        "<name> team list" => "list the people in the team",
-        "<name> team show" => "list the people in the team",
-      }) do |response|
-        Lita::Actions::ListTeam.new(response).call
-      end
-
-      route(/(\S*) team (clear|empty)/i, command: true, help: {
-        "<name> team clear" => "clear team list",
-        "<name> team empty" => "clear team list",
-      }) do |response|
-        Lita::Actions::ClearTeam.new(response).call
-      end
+    class Team < Handler
+      Lita.register_handler(self)
     end
-
-    Lita.register_handler(Team)
   end
 end

data/lib/lita/handlers/update_team.rb

@@ -0,0 +1,63 @@
+module Lita
+  module Handlers
+    class UpdateTeam < Handler
+      namespace :team
+      template_root File.expand_path("../../../../templates", __FILE__)
+
+      route(
+        /(\S*) team set (limit|location|icon) (.+)/i,
+        :update,
+        command: true,
+        help: {
+          "<name> team set limit <value>" => "update team members limit",
+          "<name> team set location <value>" => "update team location",
+          "<name> team set icon <value>" => "update team icon"
+        }
+      )
+
+      ATTRIBUTES_MAPPING = {
+        limit: :to_i,
+        location: :to_s,
+        icon: :to_s
+      }.freeze
+
+      def update(response)
+        team_name = response.match_data[1]
+        if team = get_team(team_name)
+          attribute = response.match_data[2].to_sym
+          value = parse_attribute_value(attribute, response.match_data[3])
+          team[attribute] = value
+          save_team(team)
+          response.reply(
+            render_template(:team_updated,
+                            team_name: team_name,
+                            attribute: attribute,
+                            value: value
+                           )
+          )
+        else
+          response.reply(
+            render_template(:team_not_found, team_name: team_name)
+          )
+        end
+      end
+
+      private
+
+      def get_team(team_name)
+        data = redis.get(team_name)
+        MultiJson.load(data, symbolize_keys: true) if data
+      end
+
+      def save_team(team)
+        redis.set(team[:name], MultiJson.dump(team))
+      end
+
+      def parse_attribute_value(attribute, raw_value)
+        raw_value.send(ATTRIBUTES_MAPPING[attribute])
+      end
+
+      Lita.register_handler(self)
+    end
+  end
+end

data/lib/lita-team.rb

@@ -5,21 +5,17 @@ Lita.load_locales Dir[File.expand_path(
 )]
 
 require "lita/handlers/team"
-require "lita/actions/base"
-require "lita/actions/create_team"
-require "lita/actions/delete_team"
-require "lita/actions/list_team"
-require "lita/actions/clear_team"
-require "lita/actions/list_teams"
-require "lita/actions/add_member_to_team"
-require "lita/actions/remove_member_from_team"
-require "lita/store/team"
-require "lita/store/member"
-require "lita/team"
-require "lita/member"
+require "lita/handlers/create_team"
+require "lita/handlers/delete_team"
+require "lita/handlers/block_team"
+require "lita/handlers/list_teams"
+require "lita/handlers/clear_team"
+require "lita/handlers/add_member_to_team"
+require "lita/handlers/remove_member_from_team"
+require "lita/handlers/confirm_member"
+require "lita/handlers/list_team"
+require "lita/handlers/update_team"
 
-template_root = File.expand_path(
-  File.join("..", "..", "templates"), __FILE__
+Lita::Handlers::Team.template_root(
+  File.expand_path(File.join("..", "..", "templates"), __FILE__)
 )
-Lita::Actions::Base.template_root template_root
-Lita::Handlers::Team.template_root template_root

data/lita-team.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-team"
-  spec.version       = "1.0.0"
+  spec.version       = "2.0.0"
   spec.authors       = ["Edgar Ortega"]
   spec.email         = ["edgarortegaramirez@gmail.com"]
   spec.description   = "create and manage the members of a team with Lita"
@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '~> 2.0'
 
-  spec.add_runtime_dependency "lita", ">= 4.3"
+  spec.add_runtime_dependency "lita", ">= 4.7"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "pry-byebug"

data/locales/en.yml

@@ -2,21 +2,27 @@ en:
   lita:
     handlers:
       team:
-        teams_title: "Teams:"
+        created: "%{team_name} team created, add some people to it" 
+        updated: "%{team_name} team %{attribute} set to %{value}"
+        cannot_perform_operation: "%{team_name} team is blocked. You cannot perform this operation"
+        already_exists: "%{team_name} team already exists"
+        not_found: "%{team_name} team does not exist"
+        deleted: "%{team_name} team deleted"
         no_teams_has_been_created: "No team has been created so far"
-        team_not_found: "%{name} team does not exist"
-        team_created: "%{name} team created, add some people to it"
-        team_deleted: "%{name} team deleted"
-        team_already_exists: "%{name} team already exists"
-        member_already_in_team: "%{member} already in the %{team} team"
-        member_added_to_team: "%{member} added to the %{team} team"
-        members_in_team:
+        teams_title: "Teams"
+        blocked: "%{team_name} team blocked"
+        unblocked: "%{team_name} team unblocked"
+        cleared: "%{team_name} team cleared"
+        empty: "There is no one in the %{team_name} team currently"
+        members_count:
           one: ", 1 other is in"
           other: ", %{count} others are in"
-        member_already_out_of_team: "%{member} already out of the %{team} team"
-        member_removed_from_team: "%{member} removed from the %{team} team"
-        team_empty: "There is no one in the %{team} team currently"
-        team_cleared: "%{name} team cleared"
-        team_summary:
-          one: "%{name} (1 member)"
-          other: "%{name} (%{count} members)"
+        unconfirmed_count:
+          one: ", %{count} member has not confirmed yet"
+          other: ", %{count} members have not confirmed yet"
+        member:
+          confirmed: "%{member_name} has been confirmed in the %{team_name} team"
+          already_in_team: "%{member_name} already in the %{team_name} team"
+          not_in_team: "%{member_name} is not on the %{team_name} team"
+          added: "%{member_name} added to the %{team_name} team"
+          removed: "%{member_name} removed from the %{team_name} team"

data/spec/lita/handlers/add_member_to_team_spec.rb

@@ -0,0 +1,92 @@
+require "spec_helper"
+
+describe Lita::Handlers::AddMemberToTeam,
+         lita_handler: true,
+         additional_lita_handlers: [Lita::Handlers::CreateTeam,
+                                    Lita::Handlers::BlockTeam] do
+  describe "add member to team" do
+    it "adds a member to the team" do
+      send_command "create testing team"
+      send_command "testing team add mel"
+      expect(replies.last).to eq("mel added to the testing team")
+    end
+
+    context "me" do
+      it "adds current user to the team" do
+        send_command "create testing team"
+        send_command "testing team add me"
+        expect(replies.last).to eq("#{user.name} added to the testing team")
+      end
+    end
+
+    context "+1" do
+      it "adds current user to the team" do
+        send_command "create testing team"
+        send_command "testing team +1"
+        expect(replies.last).to eq("#{user.name} added to the testing team")
+      end
+    end
+
+    context "mention" do
+      it "uses the lita users database" do
+        send_command "create testing team"
+        send_command "testing team add @Test"
+        expect(replies.last).to eq("Test User added to the testing team")
+      end
+
+      it "removes @ from non-existing users" do
+        send_command "create testing team"
+        send_command "testing team add @james"
+        expect(replies.last).to eq("james added to the testing team")
+      end
+    end
+
+    context "there is a member in the team" do
+      it "adds the member and shows a message" do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add james"
+        expect(replies.last).
+          to eq("james added to the testing team, 1 other is in")
+      end
+    end
+
+    context "there are two or more members in the team" do
+      it "adds the member and shows a message" do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add james"
+        send_command "testing team add robert"
+        expect(replies.last).
+          to eq("robert added to the testing team, 2 others are in")
+      end
+    end
+
+    context "the member is already in the team" do
+      it "does not add the member to the team" do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add john"
+        expect(replies.last).to eq("john already in the testing team")
+      end
+    end
+
+    context "team does not exist" do
+      it "does not add the member" do
+        send_command "testing team add john"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+
+    context "team blocked" do
+      it "does not add the member" do
+        send_command "create testing team"
+        send_command "block testing team"
+        send_command "testing team add john"
+        reply =
+          "testing team is blocked. You cannot perform this operation"
+        expect(replies.last).to eq(reply)
+      end
+    end
+  end
+end

data/spec/lita/handlers/block_team_spec.rb

@@ -0,0 +1,29 @@
+require "spec_helper"
+
+describe Lita::Handlers::BlockTeam,
+         lita_handler: true,
+         additional_lita_handlers: Lita::Handlers::CreateTeam do
+  describe "block team" do
+    it "blocks a team" do
+      send_command "create testing team"
+      send_command "block testing team"
+      expect(replies.last).to eq("testing team blocked")
+    end
+
+    context "team already exists" do
+      it "does not block any team" do
+        send_command "block testing team"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+  end
+
+  describe "unblock team" do
+    it "unblocks a team" do
+      send_command "create testing team"
+      send_command "block testing team"
+      send_command "unblock testing team"
+      expect(replies.last).to eq("testing team unblocked")
+    end
+  end
+end

data/spec/lita/handlers/clear_team_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe Lita::Handlers::ClearTeam,
+         lita_handler: true,
+         additional_lita_handlers: Lita::Handlers::CreateTeam do
+  describe "clear team" do
+    it "removes the members of a team" do
+      send_command "create testing team"
+      send_command "testing team add john"
+      send_command "testing team clear"
+      expect(replies.last).to eq("testing team cleared")
+    end
+
+    context "team does not exist" do
+      it "shows a message" do
+        send_command "testing team clear"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+  end
+end

data/spec/lita/handlers/confirm_member_spec.rb

@@ -0,0 +1,82 @@
+require "spec_helper"
+
+describe Lita::Handlers::ConfirmMember,
+         lita_handler: true,
+         additional_lita_handlers: [Lita::Handlers::CreateTeam,
+                                    Lita::Handlers::AddMemberToTeam] do
+  describe "confirm member attendance" do
+    it "confirm member to the team" do
+      send_command "create testing team"
+      send_command "testing team add mel"
+      send_command "testing team confirm mel"
+      expect(replies.last).
+        to eq("mel has been confirmed in the testing team")
+    end
+
+    context "me" do
+      it "confirm current user to the team" do
+        send_command "create testing team"
+        send_command "testing team add me"
+        send_command "testing team confirm me"
+        expect(replies.last).
+          to eq("#{user.name} has been confirmed in the testing team")
+      end
+    end
+
+    context "mention" do
+      it "uses the lita users database" do
+        send_command "create testing team"
+        send_command "testing team add @Test"
+        send_command "testing team confirm @Test"
+        expect(replies.last).
+          to eq("Test User has been confirmed in the testing team")
+      end
+
+      it "removes @ from non-existing users" do
+        send_command "create testing team"
+        send_command "testing team add @james"
+        send_command "testing team confirm @james"
+        expect(replies.last).
+          to eq("james has been confirmed in the testing team")
+      end
+    end
+
+    context "there is a member in the team" do
+      it "confirmed the member and displays a message" do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add james"
+        send_command "testing team confirm james"
+        expect(replies.last).
+          to match("1 member has not confirmed yet")
+      end
+    end
+
+    context "there are two or more members in the team" do
+      it "confirmed the member and displays a message" do
+        send_command "create testing team"
+        send_command "testing team add john"
+        send_command "testing team add mel"
+        send_command "testing team add james"
+        send_command "testing team confirm james"
+        expect(replies.last).
+          to match("2 members have not confirmed yet")
+      end
+    end
+
+    context "team does not exist" do
+      it "does not confirm the member" do
+        send_command "testing team confirm john"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+
+    context "member not in team" do
+      it "does not confirm the member" do
+        send_command "create testing team"
+        send_command "testing team confirm john"
+        expect(replies.last).to eq("john is not on the testing team")
+      end
+    end
+  end
+end

data/spec/lita/handlers/create_team_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe Lita::Handlers::CreateTeam, lita_handler: true do
+  describe "create team" do
+    it "creates a new team" do
+      send_command "create testing team"
+      expect(replies.last).to eq("testing team created, add some people to it")
+    end
+
+    context "team already exists" do
+      it "does not create a new team" do
+        send_command "create testing team"
+        send_command "create testing team"
+        expect(replies.last).to eq("testing team already exists")
+      end
+    end
+  end
+end

data/spec/lita/handlers/delete_team_spec.rb

@@ -0,0 +1,20 @@
+require "spec_helper"
+
+describe Lita::Handlers::DeleteTeam,
+         lita_handler: true,
+         additional_lita_handlers: Lita::Handlers::CreateTeam do
+  describe "delete team" do
+    it "deletes a team" do
+      send_command "create testing team"
+      send_command "delete testing team"
+      expect(replies.last).to eq("testing team deleted")
+    end
+
+    context "team does not exist" do
+      it "does not delete a team" do
+        send_command "delete testing team"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+  end
+end

data/spec/lita/handlers/list_team_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+describe Lita::Handlers::ListTeam,
+         lita_handler: true,
+         additional_lita_handlers: [Lita::Handlers::CreateTeam,
+                                    Lita::Handlers::AddMemberToTeam,
+                                    Lita::Handlers::ConfirmMember,
+                                    Lita::Handlers::UpdateTeam] do
+  describe "list team" do
+    it "lists the members in the team" do
+      send_command "create testing team"
+      send_command "testing team add james"
+      send_command "testing team add john"
+      send_command "testing team list"
+      expect(replies.last).
+        to eq("testing\n:bust_in_silhouette: 2\n1. james\n2. john\n")
+    end
+
+    it "list team summary" do
+      send_command "create testing team"
+      send_command "testing team add melissa"
+      send_command "update testing team set limit 10"
+      send_command "update testing team set icon :love:"
+      send_command "update testing team set location best place"
+      send_command "testing team list"
+      reply = <<-OUTPUT
+testing
+:bust_in_silhouette: 1 | :love: best place | Max: 10
+1. melissa
+OUTPUT
+      expect(replies.last).to eq(reply)
+    end
+
+    it "lists the members with confirmed tag in the team" do
+      send_command "create testing team"
+      send_command "testing team add james"
+      send_command "testing team add john"
+      send_command "testing team confirm john"
+      send_command "testing team list"
+      reply = <<-OUTPUT
+testing
+:bust_in_silhouette: 2
+1. james
+2. john :point_up:
+OUTPUT
+      expect(replies.last).to eq(reply)
+    end
+
+    context "team is empty" do
+      it "shows a message" do
+        send_command "create testing team"
+        send_command "testing team list"
+        expect(replies.last).
+          to eq("There is no one in the testing team currently")
+      end
+    end
+
+    context "team does not exist" do
+      it "shows a message" do
+        send_command "testing team list"
+        expect(replies.last).to eq("testing team does not exist")
+      end
+    end
+  end
+end

data/spec/lita/handlers/list_teams_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+describe Lita::Handlers::ListTeams,
+         lita_handler: true,
+         additional_lita_handlers: Lita::Handlers::CreateTeam do
+  describe "list teams" do
+    it "list all teams" do
+      send_command "create testing team"
+      send_command "create qa team"
+      send_command "list teams"
+      reply = <<-OUTPUT
+Teams:
+qa (0 :bust_in_silhouette:)
+testing (0 :bust_in_silhouette:)
+OUTPUT
+      expect(replies.last).to eq(reply)
+    end
+
+    context "without teams" do
+      it "shows a message" do
+        send_command "list teams"
+        expect(replies.last).to eq("No team has been created so far")
+      end
+    end
+  end
+end