link_thumbnailer 3.2.0 → 3.4.0

data/spec/scraper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Scraper do
@@ -9,8 +11,8 @@ describe LinkThumbnailer::Scraper do
   let(:instance)  { described_class.new(source, url) }
 
   before do
-    instance.stub(:document).and_return(document)
-    instance.stub(:website).and_return(website)
+    allow(instance).to receive(:document).and_return(document)
+    allow(instance).to receive(:website).and_return(website)
   end
 
   describe '#call' do
@@ -22,10 +24,10 @@ describe LinkThumbnailer::Scraper do
     let(:attributes)              { [:bar] }
     let(:scrapers)                { [prefix_1, prefix_2] }
     let(:action)                  { instance.call }
+    let(:config)                  { double(attributes: attributes, scrapers: scrapers) }
 
     before do
-      instance.stub_chain(:config, :attributes).and_return(attributes)
-      instance.stub_chain(:config, :scrapers).and_return(scrapers)
+      allow(instance).to receive(:config).and_return(config)
     end
 
     context 'when first one return a result' do

data/spec/scrapers/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Scrapers::Base do
@@ -13,7 +15,7 @@ describe LinkThumbnailer::Scrapers::Base do
     let(:action)  { instance.call(attr) }
 
     before do
-      instance.stub(:value).and_return(value)
+      allow(instance).to receive(:value).and_return(value)
     end
 
     it { expect { action }.to change { website.title }.from(nil).to(value) }
@@ -25,7 +27,7 @@ describe LinkThumbnailer::Scrapers::Base do
     let(:action) { instance.send(:model_class) }
 
     before do
-      instance.stub(:attribute_name).and_return(attr)
+      allow(instance).to receive(:attribute_name).and_return(attr)
     end
 
     context 'when internal class exists' do
@@ -40,7 +42,7 @@ describe LinkThumbnailer::Scrapers::Base do
 
       let(:attr) { :foo }
 
-      it { expect { action }.to raise_exception }
+      it { expect { action }.to raise_error(NameError) }
 
     end
 
@@ -54,7 +56,7 @@ describe LinkThumbnailer::Scrapers::Base do
     let(:action)      { instance.send(:modelize, node, text) }
 
     before do
-      instance.stub(:model_class).and_return(model_class)
+      allow(instance).to receive(:model_class).and_return(model_class)
     end
 
     it 'instantiates a new model' do

data/spec/scrapers/opengraph/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Scrapers::Opengraph::Base do
@@ -12,13 +14,13 @@ describe LinkThumbnailer::Scrapers::Opengraph::Base do
     let(:action)  { instance.applicable? }
 
     before do
-      instance.stub(:meta).and_return(meta)
+      allow(instance).to receive(:meta).and_return(meta)
     end
 
     context 'when all node is an opengraph' do
 
       before do
-        instance.stub(:opengraph_node?).and_return(true, true)
+        allow(instance).to receive(:opengraph_node?).and_return(true, true)
       end
 
       it { expect(action).to be_truthy }
@@ -28,7 +30,7 @@ describe LinkThumbnailer::Scrapers::Opengraph::Base do
     context 'when any node is an opengraph' do
 
       before do
-        instance.stub(:opengraph_node?).and_return(true, false)
+        allow(instance).to receive(:opengraph_node?).and_return(true, false)
       end
 
       it { expect(action).to be_truthy }
@@ -38,7 +40,7 @@ describe LinkThumbnailer::Scrapers::Opengraph::Base do
     context 'when no node is an opengraph' do
 
       before do
-        instance.stub(:opengraph_node?).and_return(false, false)
+        allow(instance).to receive(:opengraph_node?).and_return(false, false)
       end
 
       it { expect(action).to be_falsey }
@@ -52,7 +54,7 @@ describe LinkThumbnailer::Scrapers::Opengraph::Base do
     let(:action) { instance.send(:opengraph_node?, node) }
 
     before do
-      node.stub(:attribute).with('name').and_return(attribute_from_name)
+      allow(node).to receive(:attribute).with('name').and_return(attribute_from_name)
     end
 
     context 'with attribute from name valid' do
@@ -68,7 +70,7 @@ describe LinkThumbnailer::Scrapers::Opengraph::Base do
       let(:attribute_from_name) { 'foo' }
 
       before do
-        node.stub(:attribute).with('property').and_return(attribute_from_property)
+        allow(node).to receive(:attribute).with('property').and_return(attribute_from_property)
       end
 
       context 'and attribute from property valid' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'link_thumbnailer'
 require 'rspec'
 require 'webmock/rspec'

data/spec/uri_spec.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe LinkThumbnailer::URI do
+
+  let(:uri)       { 'http://foo.com' }
+  let(:instance)  { described_class.new(uri) }
+
+  describe '#valid?' do
+
+    let(:action) { instance.send(:valid?) }
+
+    context 'when bad format' do
+
+      before do
+        allow(instance).to receive(:attribute).and_return("/invalid/path")
+      end
+
+      it { expect(action).to be_falsey }
+
+    end
+
+    context 'when valid format' do
+
+      before do
+        allow(instance).to receive(:attribute).and_return("http://foo.com")
+      end
+
+      it { expect(action).to be_truthy }
+
+    end
+
+  end
+
+  describe '#to_s' do
+
+    let(:action) { instance.to_s }
+
+    it { expect(action).to eq(uri) }
+
+  end
+
+end

data/spec/video_parser_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::VideoParser do
@@ -8,7 +10,7 @@ describe LinkThumbnailer::VideoParser do
   let(:instance)  { described_class.new(video) }
 
   before do
-    instance.stub(:parser).and_return(parser)
+    allow(instance).to receive(:parser).and_return(parser)
   end
 
   describe '#id' do
@@ -18,7 +20,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when respond to video_id' do
 
       before do
-        parser.stub(:video_id).and_return(1)
+        allow(parser).to receive(:video_id).and_return(1)
       end
 
       it { expect(action).to eq(parser.video_id) }
@@ -28,7 +30,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when do not respond to video_id' do
 
       before do
-        parser.stub(:video_id).and_raise(NoMethodError)
+        allow(parser).to receive(:video_id).and_raise(NoMethodError)
       end
 
       it { expect(action).to be_nil }
@@ -44,8 +46,8 @@ describe LinkThumbnailer::VideoParser do
     context 'when respond to width and height' do
 
       before do
-        parser.stub(:width).and_return(1)
-        parser.stub(:height).and_return(1)
+        allow(parser).to receive(:width).and_return(1)
+        allow(parser).to receive(:height).and_return(1)
       end
 
       it { expect(action).to eq([parser.width, parser.height]) }
@@ -55,8 +57,8 @@ describe LinkThumbnailer::VideoParser do
     context 'when do not respond to width and height' do
 
       before do
-        parser.stub(:width).and_raise(NoMethodError)
-        parser.stub(:height).and_raise(NoMethodError)
+        allow(parser).to receive(:width).and_raise(NoMethodError)
+        allow(parser).to receive(:height).and_raise(NoMethodError)
       end
 
       it { expect(action).to be_empty }
@@ -72,7 +74,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when respond to duration' do
 
       before do
-        parser.stub(:duration).and_return(1)
+        allow(parser).to receive(:duration).and_return(1)
       end
 
       it { expect(action).to eq(parser.duration) }
@@ -82,7 +84,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when do not respond to duration' do
 
       before do
-        parser.stub(:duration).and_raise(NoMethodError)
+        allow(parser).to receive(:duration).and_raise(NoMethodError)
       end
 
       it { expect(action).to be_nil }
@@ -98,7 +100,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when respond to provider' do
 
       before do
-        parser.stub(:provider).and_return(1)
+        allow(parser).to receive(:provider).and_return(1)
       end
 
       it { expect(action).to eq(parser.provider) }
@@ -108,7 +110,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when do not respond to provider' do
 
       before do
-        parser.stub(:provider).and_raise(NoMethodError)
+        allow(parser).to receive(:provider).and_raise(NoMethodError)
       end
 
       it { expect(action).to be_nil }
@@ -124,7 +126,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when respond to embed_code' do
 
       before do
-        parser.stub(:embed_code).and_return('')
+        allow(parser).to receive(:embed_code).and_return('')
       end
 
       it { expect(action).to eq(parser.embed_code) }
@@ -134,7 +136,7 @@ describe LinkThumbnailer::VideoParser do
     context 'when do not respond to embed_code' do
 
       before do
-        parser.stub(:embed_code).and_raise(NoMethodError)
+        allow(parser).to receive(:embed_code).and_raise(NoMethodError)
       end
 
       it { expect(action).to be_nil }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Pierre-Louis Gottfrois
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-05-15 00:00:00.000000000 Z
+date: 2020-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -31,9 +31,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.7.7
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -41,9 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.7.7
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -62,42 +56,42 @@ dependencies:
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: net-http-persistent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.9'
 - !ruby/object:Gem::Dependency
   name: video_info
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.6'
 - !ruby/object:Gem::Dependency
@@ -107,6 +101,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -114,6 +111,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.0
 description: Ruby gem generating thumbnail images from a given URL.
 email:
 - pierrelouis.gottfrois@gmail.com
@@ -123,6 +123,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -156,6 +157,7 @@ files:
 - lib/link_thumbnailer/parser.rb
 - lib/link_thumbnailer/processor.rb
 - lib/link_thumbnailer/railtie.rb
+- lib/link_thumbnailer/response.rb
 - lib/link_thumbnailer/scraper.rb
 - lib/link_thumbnailer/scrapers/base.rb
 - lib/link_thumbnailer/scrapers/default/base.rb
@@ -172,6 +174,7 @@ files:
 - lib/link_thumbnailer/scrapers/opengraph/title.rb
 - lib/link_thumbnailer/scrapers/opengraph/video.rb
 - lib/link_thumbnailer/scrapers/opengraph/videos.rb
+- lib/link_thumbnailer/uri.rb
 - lib/link_thumbnailer/version.rb
 - lib/link_thumbnailer/video_parser.rb
 - link_thumbnailer.gemspec
@@ -180,11 +183,17 @@ files:
 - spec/fixtures/bar.png
 - spec/fixtures/default_from_body.html
 - spec/fixtures/default_from_meta.html
+- spec/fixtures/default_with_few_favicons.html
 - spec/fixtures/foo.png
+- spec/fixtures/google_shift_jis.html
+- spec/fixtures/google_utf8.html
+- spec/fixtures/google_utf8_no_meta_charset.html
 - spec/fixtures/og_not_valid_example.html
 - spec/fixtures/og_valid_example.html
 - spec/fixtures/og_valid_multi_image_example.html
 - spec/fixtures/og_valid_multi_video_example.html
+- spec/fixtures/with_related_path_in_href.html
+- spec/fixtures/with_root_path_in_href.html
 - spec/grader_spec.rb
 - spec/graders/base_spec.rb
 - spec/graders/html_attribute_spec.rb
@@ -202,15 +211,17 @@ files:
 - spec/models/website_spec.rb
 - spec/page_spec.rb
 - spec/processor_spec.rb
+- spec/response_spec.rb
 - spec/scraper_spec.rb
 - spec/scrapers/base_spec.rb
 - spec/scrapers/opengraph/base_spec.rb
 - spec/spec_helper.rb
+- spec/uri_spec.rb
 - spec/video_parser_spec.rb
 homepage: https://github.com/gottfrois/link_thumbnailer
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -225,9 +236,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Ruby gem ranking images from a given URL returning an object containing images
   and website informations.
@@ -237,11 +247,17 @@ test_files:
 - spec/fixtures/bar.png
 - spec/fixtures/default_from_body.html
 - spec/fixtures/default_from_meta.html
+- spec/fixtures/default_with_few_favicons.html
 - spec/fixtures/foo.png
+- spec/fixtures/google_shift_jis.html
+- spec/fixtures/google_utf8.html
+- spec/fixtures/google_utf8_no_meta_charset.html
 - spec/fixtures/og_not_valid_example.html
 - spec/fixtures/og_valid_example.html
 - spec/fixtures/og_valid_multi_image_example.html
 - spec/fixtures/og_valid_multi_video_example.html
+- spec/fixtures/with_related_path_in_href.html
+- spec/fixtures/with_root_path_in_href.html
 - spec/grader_spec.rb
 - spec/graders/base_spec.rb
 - spec/graders/html_attribute_spec.rb
@@ -259,8 +275,10 @@ test_files:
 - spec/models/website_spec.rb
 - spec/page_spec.rb
 - spec/processor_spec.rb
+- spec/response_spec.rb
 - spec/scraper_spec.rb
 - spec/scrapers/base_spec.rb
 - spec/scrapers/opengraph/base_spec.rb
 - spec/spec_helper.rb
+- spec/uri_spec.rb
 - spec/video_parser_spec.rb