link_thumbnailer 3.2.0 → 3.4.0

data/spec/graders/link_density_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Graders::LinkDensity do
@@ -10,8 +12,8 @@ describe LinkThumbnailer::Graders::LinkDensity do
     let(:action) { instance.call }
 
     before do
-      instance.stub(:text).and_return(text)
-      instance.stub(:links).and_return(links)
+      allow(instance).to receive(:text).and_return(text)
+      allow(instance).to receive(:links).and_return(links)
     end
 
     context 'when text length is 0' do

data/spec/graders/position_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Graders::Position do
@@ -12,8 +14,8 @@ describe LinkThumbnailer::Graders::Position do
     context 'when position is 0' do
 
       before do
-        description.stub(:position).and_return(0)
-        description.stub(:candidates_number).and_return(1)
+        allow(description).to receive(:position).and_return(0)
+        allow(description).to receive(:candidates_number).and_return(1)
       end
 
       it { expect(action).to eq(1.0) }
@@ -23,8 +25,8 @@ describe LinkThumbnailer::Graders::Position do
     context 'when position is 1 over 1 candidates' do
 
       before do
-        description.stub(:position).and_return(1)
-        description.stub(:candidates_number).and_return(1)
+        allow(description).to receive(:position).and_return(1)
+        allow(description).to receive(:candidates_number).and_return(1)
       end
 
       it { expect(action).to eq(0.0) }
@@ -34,8 +36,8 @@ describe LinkThumbnailer::Graders::Position do
     context 'when position is 1 over more than 1 candidates' do
 
       before do
-        description.stub(:position).and_return(1)
-        description.stub(:candidates_number).and_return(2)
+        allow(description).to receive(:position).and_return(1)
+        allow(description).to receive(:candidates_number).and_return(2)
       end
 
       it { expect(action).to eq(0.5) }

data/spec/image_comparators/size_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::ImageComparators::Size do

data/spec/image_validator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::ImageValidator do
@@ -11,7 +13,7 @@ describe LinkThumbnailer::ImageValidator do
     let(:action) { instance.call }
 
     before do
-      instance.stub(:blacklist_urls).and_return(blacklist_urls)
+      allow(instance).to receive(:blacklist_urls).and_return(blacklist_urls)
     end
 
     context 'when image url is blacklisted' do

data/spec/model_spec.rb

@@ -1,4 +1,6 @@
 # -*- encoding : utf-8 -*-
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Model do

data/spec/models/description_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Description do
@@ -8,7 +10,7 @@ describe LinkThumbnailer::Models::Description do
   let(:instance)  { described_class.new(node, text) }
 
   before do
-    ::LinkThumbnailer::Grader.should_receive(:new).at_least(1).and_return(grader)
+    expect(LinkThumbnailer::Grader).to receive(:new).at_least(1).times.and_return(grader)
   end
 
   describe '#to_s' do

data/spec/models/favicon_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Favicon do

data/spec/models/image_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Image do
@@ -23,7 +25,7 @@ describe LinkThumbnailer::Models::Image do
     let(:action)  { instance <=> other }
 
     before do
-      instance.stub(:size).and_return([20, 20])
+      allow(instance).to receive(:size).and_return([20, 20])
     end
 
     context 'when other has a smaller image' do
@@ -58,7 +60,7 @@ describe LinkThumbnailer::Models::Image do
     let(:action)    { instance.valid? }
 
     before do
-      instance.stub(:validator).and_return(validator)
+      allow(instance).to receive(:validator).and_return(validator)
     end
 
     it 'calls validator public method' do
@@ -82,8 +84,8 @@ describe LinkThumbnailer::Models::Image do
     }
 
     before do
-      instance.stub(:size).and_return(size)
-      instance.stub(:type).and_return(type)
+      allow(instance).to receive(:size).and_return(size)
+      allow(instance).to receive(:type).and_return(type)
     end
 
     it { expect(action).to eq(result) }

data/spec/models/title_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Title do

data/spec/models/video_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Video do
@@ -33,11 +35,11 @@ describe LinkThumbnailer::Models::Video do
     }
 
     before do
-      instance.stub(:id).and_return(id)
-      instance.stub(:size).and_return(size)
-      instance.stub(:duration).and_return(duration)
-      instance.stub(:provider).and_return(provider)
-      instance.stub(:embed_code).and_return(embed_code)
+      allow(instance).to receive(:id).and_return(id)
+      allow(instance).to receive(:size).and_return(size)
+      allow(instance).to receive(:duration).and_return(duration)
+      allow(instance).to receive(:provider).and_return(provider)
+      allow(instance).to receive(:embed_code).and_return(embed_code)
     end
 
     it { expect(action).to eq(result) }

data/spec/models/website_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Models::Website do
@@ -12,7 +14,7 @@ describe LinkThumbnailer::Models::Website do
     let(:action)  { instance.image = image }
 
     before do
-      image.stub(:valid?).and_return(true)
+      allow(image).to receive(:valid?).and_return(true)
     end
 
     it { expect { action }.to change { instance.images.size }.by(1) }
@@ -27,7 +29,7 @@ describe LinkThumbnailer::Models::Website do
     context 'when image is valid' do
 
       before do
-        image.stub(:valid?).and_return(true)
+        allow(image).to receive(:valid?).and_return(true)
       end
 
       it { expect { action }.to change { instance.images.size }.by(1) }
@@ -37,7 +39,7 @@ describe LinkThumbnailer::Models::Website do
     context 'when image is not valid' do
 
       before do
-        image.stub(:valid?).and_return(false)
+        allow(image).to receive(:valid?).and_return(false)
       end
 
       it { expect { action }.to_not change { instance.images.size } }

data/spec/page_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Page do

data/spec/processor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe LinkThumbnailer::Processor do
@@ -5,14 +7,14 @@ describe LinkThumbnailer::Processor do
   let(:page)      { ::LinkThumbnailer::Page.new(url, {}) }
   let(:instance)  { described_class.new }
   let(:url)       { 'http://foo.com' }
-
   before do
-    LinkThumbnailer.stub(:page).and_return(page)
+    allow(LinkThumbnailer).to receive(:page).and_return(page)
   end
 
   describe '#call' do
 
     let(:action) { instance.call(url) }
+    let(:https_action) { instance.call(https_url) }
 
     context 'when redirect_count is greater than config' do
 
@@ -42,6 +44,16 @@ describe LinkThumbnailer::Processor do
 
     end
 
+    context 'on http unauthorized error' do
+
+      before do
+        stub_request(:get, url).to_return(status: 401, body: '', headers: {})
+      end
+
+      it { expect { action }.to raise_error(LinkThumbnailer::HTTPError) }
+
+    end
+
     context 'on http redirection' do
 
       let(:body) { 'foo' }
@@ -81,7 +93,7 @@ describe LinkThumbnailer::Processor do
     context 'when valid' do
 
       before do
-        instance.stub(:valid_url_format?).and_return(true)
+        allow(instance).to receive(:valid_url_format?).and_return(true)
       end
 
       it 'yields' do
@@ -94,7 +106,7 @@ describe LinkThumbnailer::Processor do
     context 'when not valid' do
 
       before do
-        instance.stub(:valid_url_format?).and_return(false)
+        allow(instance).to receive(:valid_url_format?).and_return(false)
       end
 
       it { expect { instance.send(:with_valid_url) }.to raise_error(LinkThumbnailer::BadUriFormat) }
@@ -106,11 +118,11 @@ describe LinkThumbnailer::Processor do
   describe '#set_http_headers' do
 
     let(:user_agent)  { 'foo' }
-    let(:headers)     { instance.send(:http).headers }
+    let(:headers)     { instance.send(:http).override_headers }
     let(:action)      { instance.send(:set_http_headers) }
 
     before do
-      instance.stub(:user_agent).and_return(user_agent)
+      allow(instance).to receive(:user_agent).and_return(user_agent)
       action
     end
 
@@ -128,7 +140,7 @@ describe LinkThumbnailer::Processor do
       context 'when verify_ssl is true' do
 
         before do
-          instance.stub(:ssl_required?).and_return(true)
+          allow(instance).to receive(:ssl_required?).and_return(true)
           action
         end
 
@@ -139,7 +151,7 @@ describe LinkThumbnailer::Processor do
       context 'when verify_ssl is not true' do
 
         before do
-          instance.stub(:ssl_required?).and_return(false)
+          allow(instance).to receive(:ssl_required?).and_return(false)
           action
         end
 
@@ -154,7 +166,7 @@ describe LinkThumbnailer::Processor do
       let(:http_open_timeout) { 1 }
 
       before do
-        instance.stub(:http_open_timeout).and_return(http_open_timeout)
+        allow(instance).to receive(:http_open_timeout).and_return(http_open_timeout)
         action
       end
 
@@ -167,7 +179,7 @@ describe LinkThumbnailer::Processor do
       let(:http_read_timeout) { 1 }
 
       before do
-        instance.stub(:http_read_timeout).and_return(http_read_timeout)
+        allow(instance).to receive(:http_read_timeout).and_return(http_read_timeout)
         action
       end
 
@@ -179,9 +191,11 @@ describe LinkThumbnailer::Processor do
   describe '#perform_request' do
 
     let(:action) { instance.send(:perform_request) }
+    let(:http) { double }
 
     before do
-      instance.stub_chain(:http, :request).and_return(response)
+      allow(instance).to receive(:http).and_return(http)
+      allow(http).to receive(:request).and_return(response)
     end
 
     context 'when http success' do
@@ -191,13 +205,50 @@ describe LinkThumbnailer::Processor do
       let(:response)  { ::Net::HTTPSuccess.new('', code, body) }
 
       before do
-        response.stub(:body).and_return(body)
+        allow(response).to receive(:body).and_return(body)
       end
 
       it { expect(action).to eq(body) }
 
     end
 
+    context 'when access non-utf8 encoded website' do
+
+      let(:code) { 200 }
+      let(:utf8_encoded_body) { File.read(File.expand_path('fixtures/google_utf8.html', File.dirname(__FILE__))) }
+      let(:shift_jis_encoded_body) { File.read(File.expand_path('fixtures/google_shift_jis.html', File.dirname(__FILE__))) }
+      let(:response) { ::Net::HTTPSuccess.new('', code, body) }
+
+      before do
+        allow(response).to receive(:body).and_return(body)
+      end
+
+      context 'when http success with valid charset provided in Content-Type header' do
+
+        let(:body) { shift_jis_encoded_body }
+
+        before do
+          response['Content-Type'] = 'text/html; charset=Shift-JIS'
+        end
+
+        it { expect(action).to eq(shift_jis_encoded_body) }
+
+      end
+
+      context 'when http success with valid charset provided in Content-Type header' do
+
+        let(:body) { shift_jis_encoded_body }
+
+        before do
+          response['Content-Type'] = 'text/html; charset=Shift_JIS'
+        end
+
+        it { expect(action).to eq(utf8_encoded_body) }
+
+      end
+
+    end
+
     context 'when http redirection' do
 
       let(:code)      { 200 }
@@ -206,8 +257,8 @@ describe LinkThumbnailer::Processor do
       let(:new_url)   { 'http://foo.com/bar' }
 
       before do
-        instance.stub(:redirect_count).and_return(0)
-        instance.stub(:resolve_relative_url).and_return(new_url)
+        allow(instance).to receive(:redirect_count).and_return(0)
+        allow(instance).to receive(:resolve_relative_url).and_return(new_url)
       end
 
       it 'calls call method' do
@@ -229,7 +280,7 @@ describe LinkThumbnailer::Processor do
     let(:action)        { instance.send(:build_absolute_url_for, relative_url).to_s }
 
     before do
-      instance.stub(:url).and_return(url)
+      allow(instance).to receive(:url).and_return(url)
     end
 
     it { expect(action).to eq("#{scheme}://#{host}#{relative_url}") }
@@ -308,7 +359,7 @@ describe LinkThumbnailer::Processor do
     context 'when bad format' do
 
       before do
-        instance.stub(:url).and_return("http://foo.com")
+        allow(instance).to receive(:url).and_return("http://foo.com")
       end
 
       it { expect(action).to be_falsey }
@@ -318,7 +369,7 @@ describe LinkThumbnailer::Processor do
     context 'when valid format' do
 
       before do
-        instance.stub(:url).and_return(URI("http://foo.com"))
+        allow(instance).to receive(:url).and_return(URI("http://foo.com"))
       end
 
       it { expect(action).to be_truthy }
@@ -334,8 +385,8 @@ describe LinkThumbnailer::Processor do
     context 'when redirect count is greater than redirect limit' do
 
       before do
-        instance.stub(:redirect_count).and_return(5)
-        instance.stub(:redirect_limit).and_return(4)
+        allow(instance).to receive(:redirect_count).and_return(5)
+        allow(instance).to receive(:redirect_limit).and_return(4)
       end
 
       it { expect(action).to be_truthy }
@@ -345,8 +396,8 @@ describe LinkThumbnailer::Processor do
     context 'when redirect count is less than redirect limit' do
 
       before do
-        instance.stub(:redirect_count).and_return(4)
-        instance.stub(:redirect_limit).and_return(5)
+        allow(instance).to receive(:redirect_count).and_return(4)
+        allow(instance).to receive(:redirect_limit).and_return(5)
       end
 
       it { expect(action).to be_falsey }
@@ -356,8 +407,8 @@ describe LinkThumbnailer::Processor do
     context 'when redirect count is equal to redirect limit' do
 
       before do
-        instance.stub(:redirect_count).and_return(5)
-        instance.stub(:redirect_limit).and_return(5)
+        allow(instance).to receive(:redirect_count).and_return(5)
+        allow(instance).to receive(:redirect_limit).and_return(5)
       end
 
       it { expect(action).to be_falsey }

data/spec/response_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe LinkThumbnailer::Response do
+  let(:url) { 'https://www.google.co.jp' }
+  let(:page) { ::LinkThumbnailer::Page.new(url, {}) }
+
+  let(:response) do
+    r = ::Net::HTTPSuccess.new('', 200, body_shift_jis)
+    r['Content-Type'] = 'text/html'
+    r.body = body_shift_jis
+    r.instance_variable_set(:@read, true)
+    r
+  end
+
+  let(:instance) { described_class.new(response) }
+
+  let(:body_shift_jis) do
+    File.read(File.expand_path('fixtures/google_shift_jis.html', File.dirname(__FILE__)))
+  end
+
+  let(:body_utf8) do
+    File.read(File.expand_path('fixtures/google_utf8.html', File.dirname(__FILE__)))
+  end
+
+  let(:body_utf8_no_meta_charset) do
+    File.read(File.expand_path('fixtures/google_utf8_no_meta_charset.html', File.dirname(__FILE__)))
+  end
+
+  before do
+    allow(LinkThumbnailer).to receive(:page).and_return(page)
+  end
+
+  describe '#charset' do
+    context 'when charset provided in content-type "Shift_JIS"' do
+      before do
+        response['Content-Type'] = 'text/html; charset=Shift_JIS'
+      end
+
+      it { expect(instance.charset).to eq 'Shift_JIS' }
+    end
+
+    context 'when charset provided in content-type "utf-8"' do
+      before do
+        response['Content-Type'] = 'text/html; charset=utf-8'
+      end
+
+      it { expect(instance.charset).to eq 'utf-8' }
+    end
+
+    context 'when no charset available in content-type and charset provided in meta tag "UTF-8"' do
+      before do
+        response.body = body_utf8
+      end
+      it { expect(instance.charset).to eq 'UTF-8' }
+    end
+
+    context 'when no charset available in content-type and body' do
+      before do
+        response.body = body_utf8_no_meta_charset
+      end
+      it { expect(instance.charset).to eq '' }
+    end
+  end
+
+  describe '#body' do
+    context 'when provide valid charset' do
+      before do
+        response['Content-Type'] = 'text/html; charset=Shift_JIS'
+      end
+
+      it { expect(instance.body).to eq body_utf8 }
+    end
+
+    context 'when provide invalid charset' do
+      before do
+        response['Content-Type'] = 'text/html; charset=Shift-JIS'
+      end
+
+      it { expect(instance.body).to eq body_shift_jis }
+    end
+  end
+end