license_finder 2.1.2 → 3.0.0

data/spec/lib/license_finder/package_managers/bower_spec.rb

@@ -28,7 +28,7 @@ module LicenseFinder
         JSON
 
         allow(Dir).to receive(:chdir).with(Pathname('/fake/path')) { |&block| block.call }
-        allow(subject).to receive(:capture).with('bower list --json -l action').and_return([json, true])
+        allow(subject).to receive(:capture).with('bower list --json -l action --allow-root').and_return([json, true])
 
         expect(subject.current_packages.map { |p| [p.name, p.install_path] }).to eq [
           %w(dependency-library /path/to/thing), %w(another-dependency /path/to/thing2)

data/spec/lib/license_finder/package_managers/bundler_spec.rb

@@ -30,7 +30,7 @@ module LicenseFinder
 
     describe '.current_packages' do
       subject do
-        Bundler.new(ignore_groups: ['dev', 'test'], definition: definition).current_packages
+        Bundler.new(ignored_groups: ['dev', 'test'], definition: definition).current_packages
       end
 
       it "should have 2 dependencies" do

data/spec/lib/license_finder/package_managers/go_dep_spec.rb

@@ -21,6 +21,10 @@ module LicenseFinder
             {
               "ImportPath": "github.com/pivotal/bar",
               "Rev": "3245708abcdef234589450649872346783298736"
+            },
+            {
+              "ImportPath": "code.google.com/foo/bar",
+              "Rev": "3245708abcdef234589450649872346783298735"
             }
           ]
         }'
@@ -30,6 +34,14 @@ module LicenseFinder
         allow(IO).to receive(:read).with('/fake/path/Godeps/Godeps.json').and_return(content.to_s)
       end
 
+      it 'sets the homepage for packages' do
+        packages = subject.current_packages
+
+        expect(packages[0].homepage).to eq("github.com/pivotal/foo")
+        expect(packages[1].homepage).to eq("github.com/pivotal/bar")
+        expect(packages[2].homepage).to eq("code.google.com/foo/bar")
+      end
+
       context 'when dependencies are vendored' do
         before do
           allow(FileTest).to receive(:exist?).with('/fake/path/Godeps/_workspace').and_return(true)
@@ -52,7 +64,8 @@ module LicenseFinder
           it 'list the dependencies with full version' do
             expect(subject.current_packages.map(&:version)).to eq [
               "61164e49940b423ba1f12ddbdf01632ac793e5e9",
-              "3245708abcdef234589450649872346783298736"]
+              "3245708abcdef234589450649872346783298736",
+              "3245708abcdef234589450649872346783298735"]
           end
         end
       end

data/spec/lib/license_finder/package_managers/go_vendor_spec.rb

@@ -39,6 +39,7 @@ module LicenseFinder
         FileUtils.mkdir_p project_path
         FileUtils.touch File.join(project_path, 'main.go')
         FileUtils.mkdir_p File.join(project_path, 'vendor', 'github.com', 'foo', 'bar')
+        FileUtils.mkdir_p File.join(project_path, 'vendor', 'golang.org', 'bar', 'baz')
       end
 
       it 'detects the project as go vendor project' do
@@ -49,9 +50,13 @@ module LicenseFinder
         let(:go_deps) {
           ["github.com/foo/bar", true]
         }
+        let(:std_deps) {
+          ["stdbar/baz", true]
+        }
 
         before do
-          allow(subject).to receive(:capture).with(%q[go list -f '{{join .Deps "\n"}}' ./...]).and_return(go_deps)
+          allow(subject).to receive(:capture).with(%q[go list -f "{{join .Deps \"\n\"}}" ./...]).and_return(go_deps)
+          allow(subject).to receive(:capture).with(%q[go list std]).and_return(std_deps)
           allow(subject).to receive(:capture).with(%q[git rev-list --max-count 1 HEAD]).and_return(["e0ff7ae205f\n", true])
         end
 
@@ -75,7 +80,6 @@ module LicenseFinder
             ["github.com/foo/bar\ngithub.com/foo/bar/baz", true]
           }
 
-          include_examples 'current_packages'
         end
 
         context 'when only sub packages are being used' do
@@ -93,6 +97,23 @@ module LicenseFinder
 
           include_examples 'current_packages'
         end
+
+        context 'when standard packages are being used' do
+          let(:go_deps) {
+            ["github.com/foo/bar\ngolang.org/stdbar/baz", true]
+          }
+
+          include_examples 'current_packages'
+        end
+
+        context 'when standard package names match part of a nonstandard package' do
+          let(:go_deps) {
+            ["github.com/foo/bar/my-stdbar/baz\ngolang.org/stdbar/baz", true]
+          }
+
+          include_examples 'current_packages'
+
+        end
       end
     end
 

data/spec/lib/license_finder/package_managers/go_workspace_spec.rb

@@ -34,9 +34,19 @@ module LicenseFinder
 
       let(:go_list_output) {
         <<HERE
-encoding/json
 gopkg.in/yaml.v2
 github.com/onsi/ginkgo
+myblip/blop-custom
+encoding/json
+golang.org/x/tools/go/ast/astutil
+HERE
+      }
+
+      let(:std_packages) {
+        <<HERE
+go/ast
+blop
+encoding/json
 HERE
       }
 
@@ -44,6 +54,8 @@ HERE
         allow(Dir).to receive(:chdir).with(Pathname.new project_path) { |&b| b.call() }
         allow(FileTest).to receive(:exist?).and_return(false)
         allow(FileTest).to receive(:exist?).with(File.join(project_path, '.envrc')).and_return(true)
+        allow(subject).to receive(:capture).with('go list -f "{{join .Deps \"\n\"}}" ./...').and_return([go_list_output, true])
+        allow(subject).to receive(:capture).with('go list std').and_return([std_packages, true])
       end
 
       it 'changes the directory' do
@@ -52,16 +64,14 @@ HERE
         expect(Dir).to have_received(:chdir)
       end
 
-      it 'returns the skip the standard libs and return lines of the output' do
-        allow(subject).to receive(:capture).with('go list -f \'{{join .Deps "\n"}}\' ./...').and_return([go_list_output, true])
+      it 'lists only non-standard packages' do
         packages = subject.send(:go_list)
-        expect(packages.count).to eq(2)
-        expect(packages).to include 'github.com/onsi/ginkgo'
-        expect(packages).to include 'gopkg.in/yaml.v2'
+        expect(packages.count).to eq(3)
+        expect(packages).to eq(['gopkg.in/yaml.v2', 'github.com/onsi/ginkgo', 'myblip/blop-custom'])
       end
 
       it 'sets gopath to the envrc path' do
-        allow(subject).to receive(:capture).with('go list -f \'{{join .Deps "\n"}}\' ./...') {
+        allow(subject).to receive(:capture).with('go list -f "{{join .Deps \"\n\"}}" ./...') {
           expect(ENV['GOPATH']).to be_nil
           ['', true]
         }
@@ -129,6 +139,12 @@ HERE
         allow(subject).to receive(:git_modules).and_return(git_modules_output)
       end
 
+      it 'sets homepage for the packages' do
+        packages = subject.current_packages
+
+        expect(packages[0].homepage).to eq('bitbucket.org/kardianos/osext')
+      end
+
       describe 'should return an array of go packages' do
         it 'provides package names' do
           packages = subject.current_packages

data/spec/lib/license_finder/package_managers/gradle_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'fakefs/spec_helpers'
 
 module LicenseFinder
   describe Gradle do
@@ -17,6 +18,17 @@ module LicenseFinder
         expect(GradleDependencyFinder).to receive(:new).and_return(dependencies)
       end
 
+      it 'uses the gradle wrapper, if present' do
+        subject = Gradle.new(project_path: Pathname('features/fixtures/gradle-wrapper'))
+        expect(Dir).to receive(:chdir).with(Pathname('features/fixtures/gradle-wrapper')).and_call_original
+        if Platform.windows?
+          expect(subject.package_management_command).to eq('gradlew.bat')
+        else
+          expect(subject.package_management_command).to eq('./gradlew')
+        end
+        subject.current_packages
+      end
+
       it 'uses custom subject command, if provided' do
         subject = Gradle.new(gradle_command: 'subjectfoo', project_path: Pathname('/fake/path'))
         expect(Dir).to receive(:chdir).with(Pathname('/fake/path')) { |&block| block.call }
@@ -27,11 +39,14 @@ module LicenseFinder
       it 'sets the working directory to project_path, if provided' do
         subject = Gradle.new(project_path: Pathname('/Users/foo/bar'))
         expect(Dir).to receive(:chdir).with(Pathname('/Users/foo/bar')) { |&block| block.call }
-        expect(subject).to receive(:capture).with('gradle --console plain downloadLicenses').and_return(['', true])
+        if Platform.windows?
+          expect(subject).to receive(:capture).with('gradle.bat downloadLicenses').and_return(['', true])
+        else
+          expect(subject).to receive(:capture).with('gradle downloadLicenses').and_return(['', true])
+        end
         subject.current_packages
       end
 
-
       context 'when dependencies are found' do
         let(:content) do
           [
@@ -123,5 +138,43 @@ module LicenseFinder
         end
       end
     end
+
+    describe '#active?' do
+      include FakeFS::SpecHelpers
+
+      it 'return true if build.gradle exists' do
+        FakeFS do
+          FileUtils.mkdir_p '/fake/path'
+          FileUtils.touch '/fake/path/build.gradle'
+
+          expect(subject.active?).to be true
+        end
+      end
+
+      context "when there's no build.gradle" do
+        it 'returns false' do
+          expect(subject.active?).to be false
+        end
+      end
+
+      context "when there's a settings.gradle" do
+        it 'uses the build.gradle referenced inside' do
+          SETTINGS_DOT_GRADLE = <<-eos
+rootProject.buildFileName = 'build-alt.gradle'
+          eos
+
+          FakeFS do
+            FileUtils.mkdir_p '/fake/path'
+            File.open('/fake/path/settings.gradle', 'w') do |file|
+              file.write SETTINGS_DOT_GRADLE
+            end
+            FileUtils.touch '/fake/path/build-alt.gradle'
+
+            expect(subject.active?).to be true
+          end
+        end
+      end
+
+    end
   end
 end

data/spec/lib/license_finder/package_managers/maven_package_spec.rb

@@ -2,11 +2,16 @@ require 'spec_helper'
 
 module LicenseFinder
   describe MavenPackage do
+    let(:options) { {} }
     subject do
       described_class.new(
-        "artifactId" => "hamcrest-core",
-        "version" => "4.11",
-        "licenses" => [{ "name" => "MIT" }]
+        {
+          "groupId" => "org.hamcrest",
+          "artifactId" => "hamcrest-core",
+          "version" => "4.11",
+          "licenses" => [{ "name" => "MIT" }],
+        },
+        options
       )
     end
 
@@ -33,6 +38,14 @@ module LicenseFinder
         end
       end
 
+      context 'when include_groups is set to true' do
+        let(:options) { {include_groups: true} }
+
+        it 'includes the group id in the name' do
+          expect(subject.name).to eq("org.hamcrest:hamcrest-core")
+        end
+      end
+
       context "when there are multiple licenses" do
         subject do
           described_class.new(

data/spec/lib/license_finder/package_managers/maven_spec.rb

@@ -2,7 +2,9 @@ require 'spec_helper'
 
 module LicenseFinder
   describe Maven do
-    subject { Maven.new(project_path: Pathname('/fake/path')) }
+    let(:options) { {} }
+
+    subject { Maven.new(options.merge(project_path: Pathname('/fake/path'))) }
 
     it_behaves_like "a PackageManager"
 
@@ -20,21 +22,30 @@ module LicenseFinder
     describe '.current_packages' do
       before do
         allow(Dir).to receive(:chdir).with(Pathname('/fake/path')) { |&block| block.call }
-        allow(subject).to receive(:capture).with('mvn license:download-licenses').and_return(['', true])
+        allow(subject).to receive(:capture).with('mvn org.codehaus.mojo:license-maven-plugin:download-licenses').and_return(['', true])
       end
 
       def stub_license_report(deps)
-        fake_file = double(:license_report, read: license_xml(deps))
-        allow(subject).to receive(:license_report).and_return(fake_file)
+        dependencies = double(:subject_dependency_file, dependencies: [license_xml(deps)])
+        expect(MavenDependencyFinder).to receive(:new).and_return(dependencies)
+      end
+
+      it 'uses the maven wrapper, if present' do
+        subject = Maven.new(project_path: Pathname('features/fixtures/maven-wrapper'))
+        expect(Dir).to receive(:chdir).with(Pathname('features/fixtures/maven-wrapper')).and_call_original
+        expect(subject.package_management_command).to eq('./mvnw').or eq('mvnw.cmd')
+        subject.current_packages
       end
 
       it 'lists all the current packages' do
         stub_license_report("
           <dependency>
+            <groupId>org.otherorg</groupId>
             <artifactId>junit</artifactId>
             <version>4.11</version>
           </dependency>
           <dependency>
+            <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-core</artifactId>
             <version>1.3</version>
            </dependency>
@@ -46,6 +57,23 @@ module LicenseFinder
         ]
       end
 
+      context 'when ignored_groups is used' do
+        subject {
+          Maven.new(options.merge(
+              project_path: Pathname('/fake/path'),
+              ignored_groups: Set.new(%w(system test provided import))
+          ))
+        }
+
+        before do
+          expect(subject).to receive(:capture).with('mvn org.codehaus.mojo:license-maven-plugin:download-licenses -Dlicense.excludedScopes=system,test,provided,import').and_return(['', true])
+        end
+
+        it 'uses skips the specified groups' do
+          subject.current_packages
+        end
+      end
+
       it "handles multiple licenses" do
         stub_license_report("
           <dependency>
@@ -63,6 +91,30 @@ module LicenseFinder
         expect(subject.current_packages.first.licenses.map(&:name)).to eq ['License 1', 'License 2']
       end
 
+      context 'when maven group ids option is enabled' do
+        let(:options) { { maven_include_groups: true } }
+
+        it 'lists all the current packages' do
+          stub_license_report("
+            <dependency>
+              <groupId>junit</groupId>
+              <artifactId>junit</artifactId>
+              <version>4.11</version>
+            </dependency>
+            <dependency>
+              <groupId>org.hamcrest</groupId>
+              <artifactId>hamcrest-core</artifactId>
+              <version>1.3</version>
+            </dependency>
+          ")
+
+          expect(subject.current_packages.map { |p| [p.name, p.version] }).to eq [
+            ["junit:junit", "4.11"],
+            ["org.hamcrest:hamcrest-core", "1.3"]
+          ]
+        end
+      end
+
       it "handles no licenses" do
         stub_license_report("
           <dependency>

data/spec/lib/license_finder/package_managers/merged_package_spec.rb

@@ -29,27 +29,31 @@ module LicenseFinder
     end
 
     describe '#eql?' do
-      it 'returns true when the package names are equal' do
+      it 'returns false when the package names are the same, but the version is different' do
         p1 = MergedPackage.new(Package.new('foo', '1.0.0'), ['/path/to/package1'])
         p2 = MergedPackage.new(Package.new('foo', '2.0.0'), ['/path/to/package2'])
         p3 = MergedPackage.new(Package.new('bar', '1.0.0'), ['/path/to/package3'])
-        expect(p1.eql?(p2)).to eq(true)
+        expect(p1.eql?(p2)).to eq(false)
         expect(p1.eql?(p3)).not_to eq(true)
       end
 
       it 'can handle merged packages that contain other merged packages' do
         p1 = MergedPackage.new(Package.new('foo', '1.0.0'), ['/path/to/package1'])
         p2 = MergedPackage.new(Package.new('foo', '2.0.0'), ['/path/to/package2'])
-        p3 = MergedPackage.new(p2, ['/path/to/package3', '/path/to/package2'])
+        p3 = MergedPackage.new(p1, ['/path/to/package3', '/path/to/package1'])
+        p4 = MergedPackage.new(p2, ['/path/to/package4', '/path/to/package2'])
         expect(p1.eql?(p3)).to eq(true)
+        expect(p1.eql?(p4)).not_to eq(true)
       end
     end
 
     describe 'hash' do
       it 'returns equal hash codes for packages that are equal' do
         p1 = MergedPackage.new(Package.new('foo', '1.0.0'), ['/path/to/package1'])
-        p2 = MergedPackage.new(Package.new('foo', '2.0.0'), ['/path/to/package2'])
+        p2 = MergedPackage.new(Package.new('foo', '1.0.0'), ['/path/to/package2'])
+        p3 = MergedPackage.new(Package.new('foo', '2.0.0'), ['/path/to/package3'])
         expect(p1.hash).to eq(p2.hash)
+        expect(p1.hash).not_to eq(p3.hash)
       end
     end
   end

data/spec/lib/license_finder/package_spec.rb

@@ -153,13 +153,16 @@ module LicenseFinder
     describe '#eql?' do
       it 'returns true if package name matches' do
         p1 = Package.new('package', '0.0.1')
-        p2 = Package.new('package', '0.0.2')
+        p2 = Package.new('package', '0.0.1')
         p3 = Package.new('foo', 'foo')
+        p4 = Package.new('foo', 'foo2')
 
         expect(p1.eql?(p2)).to be true
         expect(p1.eql?(p3)).to be false
+        expect(p3.eql?(p4)).to be false
 
         expect(p1.hash).to eq p2.hash
+        expect(p3.hash).not_to eq p4.hash
       end
     end
 

data/spec/lib/license_finder/reports/csv_report_spec.rb

@@ -35,6 +35,14 @@ module LicenseFinder
       expect(subject.to_s).to eq("gem_a,1.0,Nuget\n")
     end
 
+    it 'supports license_links column' do
+      dep = Package.new('gem_a', '1.0')
+      mit = License.find_by_name("MIT")
+      dep.decide_on_license(mit)
+      subject = described_class.new([dep], columns: %w[name licenses license_links])
+      expect(subject.to_s).to eq("gem_a,MIT,#{mit.url}\n")
+    end
+
     it "does not include columns that should only be in merged reports" do
       dep = Package.new('gem_a', '1.0')
       subject = described_class.new([dep], columns: %w[subproject_paths])