license_finder 2.1.2 → 3.0.0

data/features/fixtures/alternate-build-file-gradle/build-alt.gradle

@@ -0,0 +1,26 @@
+apply plugin: 'java'
+
+sourceCompatibility = 1.5
+version = '1.0'
+
+repositories {
+    mavenCentral()
+}
+
+dependencies {
+    compile group: 'junit', name: 'junit', version: '4.11'
+}
+
+buildscript {
+    repositories {
+        maven {
+            url 'https://plugins.gradle.org/m2/'
+        }
+    }
+
+    dependencies {
+        classpath 'gradle.plugin.nl.javadude.gradle.plugins:license-gradle-plugin:0.12.1'
+    }
+}
+
+apply plugin: 'license'

data/features/fixtures/alternate-build-file-gradle/settings.gradle

@@ -0,0 +1 @@
+rootProject.buildFileName = 'build-alt.gradle'

data/features/fixtures/file-based-libs-gradle/build.gradle

@@ -14,5 +14,5 @@ dependencies {
         )
 
         // Import external libraries that are **not** available to download via repo
-        compile fileTree(dir: 'libs', include: '*.jar')
+        compile fileTree(dir: 'libs', include: ['*.jar'])
 }

data/features/fixtures/gradle-wrapper/build.gradle

@@ -0,0 +1,26 @@
+apply plugin: 'java'
+
+sourceCompatibility = 1.5
+version = '1.0'
+
+repositories {
+    mavenCentral()
+}
+
+dependencies {
+    compile group: 'junit', name: 'junit', version: '4.11'
+}
+
+buildscript {
+    repositories {
+        maven {
+            url 'https://plugins.gradle.org/m2/'
+        }
+    }
+
+    dependencies {
+        classpath 'gradle.plugin.nl.javadude.gradle.plugins:license-gradle-plugin:0.12.1'
+    }
+}
+
+apply plugin: 'license'

data/features/fixtures/gradle-wrapper/gradlew

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+gradle

data/features/fixtures/gradle-wrapper/gradlew.bat

@@ -0,0 +1 @@
+@call gradle.bat

data/features/fixtures/maven-wrapper/mvnw

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+mvn "$@"

data/features/fixtures/maven-wrapper/mvnw.cmd

@@ -0,0 +1,7 @@
+@echo off
+where /q mvn.cmd
+if %ERRORLEVEL% equ 0 (
+    mvn.cmd %*
+) else (
+    mvn.bat %*
+)

data/features/fixtures/maven-wrapper/pom.xml

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>dummy</groupId>
+  <artifactId>dummy</artifactId>
+  <version>1.0-SNAPSHOT</version>
+
+  <dependencies>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>4.11</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>license-maven-plugin</artifactId>
+        <version>1.10</version>
+        <executions>
+          <execution>
+            <id>download-licenses</id>
+            <goals>
+              <goal>download-licenses</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

data/features/support/testing_dsl.rb

@@ -3,11 +3,11 @@ require 'delegate'
 module LicenseFinder
   module TestingDSL
     class User
-      def run_license_finder(path = nil)
+      def run_license_finder(path = nil, options='')
         if path
-          execute_command_in_path('license_finder --quiet', Paths.project("my_app/#{path}"))
+          execute_command_in_path("license_finder --quiet #{options}", Paths.project("my_app/#{path}"))
         else
-          execute_command 'license_finder --quiet'
+          execute_command "license_finder --quiet #{options}"
         end
       end
 
@@ -131,7 +131,7 @@ module LicenseFinder
       end
 
       def install
-        shell_out("bower install 2>/dev/null")
+        shell_out("bower install --allow-root 2>/dev/null")
       end
     end
 
@@ -169,6 +169,12 @@ module LicenseFinder
       end
     end
 
+    class AlternateBuildFileGradleProject < Project
+      def add_dep
+        clone('alternate-build-file-gradle')
+      end
+    end
+
     class GoProject < Project
       def add_dep
         clone('gopath')
@@ -377,7 +383,8 @@ module LicenseFinder
 
       def reset_projects!
         # only destroyed when a test starts, so you can poke around after a failure
-        projects.rmtree if projects.exist?
+        require 'fileutils'
+        FileUtils.rmtree(projects) if projects.exist?
         projects.mkpath
       end
     end

data/lib/license_finder/cli/base.rb

@@ -31,6 +31,7 @@ module LicenseFinder
           :go_full_version,
           :gradle_command,
           :gradle_include_groups,
+          :maven_include_groups,
           :rebar_command,
           :rebar_deps_dir,
           :save

data/lib/license_finder/cli/main.rb

@@ -18,11 +18,12 @@ module LicenseFinder
       }
 
       class_option :format, desc: "The desired output format.", default: 'text', enum: FORMATS.keys
-      class_option :columns, type: :array, desc: "For CSV reports, which columns to print. Pick from: #{CsvReport::AVAILABLE_COLUMNS}", default: %w[name version licenses]
+      class_option :columns, type: :array, desc: "For text or CSV reports, which columns to print. Pick from: #{CsvReport::AVAILABLE_COLUMNS}", default: %w[name version licenses]
       class_option :save, desc: "Save report to a file. Default: 'license_report.csv' in project root.", lazy_default: "license_report"
       class_option :go_full_version, desc: "Whether dependency version should include full version. Only meaningful if used with a Go project. Defaults to false."
       class_option :gradle_include_groups, desc: "Whether dependency name should include group id. Only meaningful if used with a Java/gradle project. Defaults to false."
       class_option :gradle_command, desc: "Command to use when fetching gradle packages. Only meaningful if used with a Java/gradle project. Defaults to 'gradlew' / 'gradlew.bat' if the wrapper is present, otherwise to 'gradle'."
+      class_option :maven_include_groups, desc: "Whether dependency name should include group id. Only meaningful if used with a Java/maven project. Defaults to false."
       class_option :rebar_command, desc: "Command to use when fetching rebar packages. Only meaningful if used with a Erlang/rebar project. Defaults to 'rebar'."
       class_option :rebar_deps_dir, desc: "Path to rebar dependencies directory. Only meaningful if used with a Erlang/rebar project. Defaults to 'deps'."
       class_option :subprojects, type: :array, desc: "Generate a single report for multiple sub-projects. Ex: --subprojects='path/to/project1', 'path/to/project2'"

data/lib/license_finder/configuration.rb

@@ -22,18 +22,7 @@ module LicenseFinder
     end
 
     def gradle_command
-      get(:gradle_command) || (
-        if Platform.windows?
-          wrapper = 'gradlew.bat'
-          gradle = 'gradle.bat'
-        else
-          wrapper = 'gradlew'
-          gradle = 'gradle'
-        end
-
-        executable = File.exist?(wrapper) ? wrapper : gradle
-        "#{executable} --console plain"
-      )
+      get(:gradle_command)
     end
 
     def go_full_version
@@ -44,8 +33,12 @@ module LicenseFinder
       get(:gradle_include_groups)
     end
 
+    def maven_include_groups
+      get(:maven_include_groups)
+    end
+
     def rebar_command
-      get(:rebar_command) || 'rebar'
+      get(:rebar_command)
     end
 
     def rebar_deps_dir

data/lib/license_finder/core.rb

@@ -63,10 +63,11 @@ module LicenseFinder
       PackageManager.current_packages(
         logger: logger,
         project_path: config.project_path,
-        ignore_groups: decisions.ignored_groups,
+        ignored_groups: decisions.ignored_groups,
         go_full_version: config.go_full_version,
         gradle_command: config.gradle_command,
         gradle_include_groups: config.gradle_include_groups,
+        maven_include_groups: config.maven_include_groups,
         rebar_command: config.rebar_command,
         rebar_deps_dir: config.rebar_deps_dir,
       )

data/lib/license_finder/diff.rb

@@ -10,8 +10,8 @@ module LicenseFinder
 
       [].tap do |packages|
         unchanged.each do |package|
-          package_previous = package_with_name(p1, package)
-          package_current = package_with_name(p2, package)
+          package_previous = find_package(p1, package)
+          package_current = find_package(p2, package)
 
           if package_current.licenses == package_previous.licenses
             packages << PackageDelta.unchanged(package_current, package_previous)
@@ -40,8 +40,8 @@ module LicenseFinder
       end
     end
 
-    def self.package_with_name(set, package)
-      set.find { |p| p.name == package.name }
+    def self.find_package(set, package)
+      set.find { |p| p.eql? package}
     end
   end
 end

data/lib/license_finder/package.rb

@@ -99,15 +99,17 @@ module LicenseFinder
     ## EQUALITY
 
     def <=>(other)
-      name <=> other.name
+      eq_name = name <=> other.name
+      return eq_name unless eq_name == 0
+      version <=> other.version
     end
 
     def eql?(other)
-      name == other.name
+      name == other.name && version == other.version
     end
 
     def hash
-      [name].hash
+      [name,version].hash
     end
 
     ## LICENSING

data/lib/license_finder/package_delta.rb

@@ -12,13 +12,10 @@ module LicenseFinder
       pick_package.name
     end
 
-    def current_version
-      @current_package ? @current_package.version : nil
+    def version
+      pick_package.version
     end
 
-    def previous_version
-      @previous_package ? @previous_package.version : nil
-    end
 
     def subproject_paths
       pick_package.subproject_paths

data/lib/license_finder/package_managers/bower.rb

@@ -15,7 +15,7 @@ module LicenseFinder
     private
 
     def bower_output
-      command = 'bower list --json -l action'
+      command = "#{Bower::package_management_command} list --json -l action --allow-root"
       output, success = Dir.chdir(project_path) { capture(command) }
       raise "Command '#{command}' failed to execute: #{output}" unless success
 

data/lib/license_finder/package_managers/bundler.rb

@@ -4,7 +4,7 @@ module LicenseFinder
   class Bundler < PackageManager
     def initialize options={}
       super
-      @ignore_groups = options[:ignore_groups]
+      @ignored_groups = options[:ignored_groups]
       @definition    = options[:definition] # dependency injection for tests
     end
 
@@ -18,12 +18,12 @@ module LicenseFinder
     end
 
     def self.package_management_command
-      "bundler"
+      "bundle"
     end
 
     private
 
-    attr_reader :ignore_groups
+    attr_reader :ignored_groups
 
     def definition
       # DI
@@ -46,7 +46,7 @@ module LicenseFinder
     end
 
     def included_groups
-      definition.groups - ignore_groups.map(&:to_sym)
+      definition.groups - ignored_groups.map(&:to_sym)
     end
 
     def package_path

data/lib/license_finder/package_managers/go_dep.rb

@@ -11,12 +11,18 @@ module LicenseFinder
     def current_packages
       json = JSON.parse(package_path.read)
       # godep includes subpackages as a seperate dependency, we can de-dup that
-      deps = json['Deps'].each do |d|
-        next unless d['ImportPath'].include?('github.com')
 
-        d['ImportPath'] = d['ImportPath'].split('/')[0..2].join('/')
+      dependencies_info = json['Deps'].map do |json|
+        {
+            'Homepage' => homepage(json),
+            'ImportPath' => import_path(json),
+            'InstallPath' => json['InstallPath'],
+            'Rev' => json['Rev']
+        }
+      end
+      dependencies_info.uniq.map do |info|
+        GoPackage.from_dependency(info, install_prefix, @full_version)
       end
-      deps.uniq.map { |dep| GoPackage.from_dependency(dep, install_prefix, @full_version) }
     end
 
     def package_path
@@ -37,5 +43,16 @@ module LicenseFinder
     def workspace_dir
       project_path.join('Godeps/_workspace')
     end
+
+    def homepage(dependency_json)
+      import_path dependency_json
+    end
+
+    def import_path(dependency_json)
+      import_path = dependency_json['ImportPath']
+      return import_path unless import_path.include?('github.com')
+
+      import_path.split('/')[0..2].join('/')
+    end
   end
 end

data/lib/license_finder/package_managers/go_package.rb

@@ -5,7 +5,8 @@ module LicenseFinder
       install_path = hash['InstallPath']
       install_path ||= install_path(prefix.join(name))
       version = full_version ? hash['Rev'] : hash['Rev'][0..6]
-      self.new(name, version, {install_path: install_path, package_manager: "Go" })
+      homepage = hash['Homepage']
+      self.new(name, version, {install_path: install_path, package_manager: "Go", homepage: homepage })
     end
 
     def package_manager

data/lib/license_finder/package_managers/go_vendor.rb

@@ -24,8 +24,8 @@ module LicenseFinder
       project_path.join("vendor")
     end
 
-    def project_sha
-      @project_sha ||= Dir.chdir(project_path) do
+    def project_sha(path)
+      Dir.chdir(path) do
         val = capture('git rev-list --max-count 1 HEAD')
         raise 'git rev-list failed' unless val.last
         val.first.strip
@@ -39,7 +39,7 @@ module LicenseFinder
         GoPackage.from_dependency({
                                    'ImportPath' => dep,
                                    'InstallPath' => package_path.join(dep),
-                                   'Rev' => 'vendored-' + project_sha
+                                   'Rev' => 'vendored-' + project_sha(package_path.join(dep))
                                   }, nil, true)
       end
     end
@@ -56,11 +56,25 @@ module LicenseFinder
         # discovered that `go list' will print a warning and unfortunately exit
         # with status code 1. Setting GOPATH to nil removes those warnings.
         ENV['GOPATH'] = nil
-        val = capture('go list -f \'{{join .Deps "\n"}}\' ./...')
+        val = capture('go list -f "{{join .Deps \"\n\"}}" ./...')
         return [] unless val.last
-        # Select non-standard packages. Standard packages tend to be short
-        # and have less than two slashes
-        val.first.lines.map(&:strip).select { |l| l.split("/").length > 2 }.map { |l| l.split("/")[0..2].join("/") }.uniq
+        # Select non-standard packages. `go list std` returns the list of standard
+        # dependencies. We then filter those dependencies out of the full list of
+        # dependencies.
+        deps = val.first.split("\n")
+        capture('go list std').first.split("\n").each do |std|
+          deps.delete_if do |dep|
+            dep =~ /(\/|^)#{std}(\/|$)/
+          end
+        end
+        deps.map do |d|
+          dep_parts = d.split('/')
+          if dep_parts.length > 2
+            dep_parts[0..2].join('/')
+          else
+            d
+          end
+        end
       end
     end
   end