license_finder 2.1.0.rc4 → 2.1.0.rc5

data/spec/lib/license_finder/package_managers/gradle_package_spec.rb

@@ -18,6 +18,7 @@ module LicenseFinder
     its(:groups) { should == [] } # no way to get groups from gradle?
     its(:children) { should == [] } # no way to get children from gradle?
     its(:install_path) { should be_nil }
+    its(:package_manager) { should eq 'Gradle' }
 
     describe "when file name has a funny format, possibly because it is a jar saved in the project" do
       it "uses a reasonable name and default version" do

data/spec/lib/license_finder/package_managers/gradle_spec.rb

@@ -27,10 +27,11 @@ module LicenseFinder
       it 'sets the working directory to project_path, if provided' do
         subject = Gradle.new(project_path: Pathname('/Users/foo/bar'))
         expect(Dir).to receive(:chdir).with(Pathname('/Users/foo/bar')) { |&block| block.call }
-        expect(subject).to receive(:capture).with('gradle downloadLicenses').and_return(['', true])
+        expect(subject).to receive(:capture).with('gradle --console plain downloadLicenses').and_return(['', true])
         subject.current_packages
       end
 
+
       context 'when dependencies are found' do
         let(:content) do
           [

data/spec/lib/license_finder/package_managers/maven_package_spec.rb

@@ -18,6 +18,7 @@ module LicenseFinder
     its(:groups) { should == [] } # no way to get groups from maven?
     its(:children) { should == [] } # no way to get children from maven?
     its(:install_path) { should be_nil }
+    its(:package_manager) { should eq 'Maven' }
 
     describe "#license_names_from_spec" do
       it "returns the license" do

data/spec/lib/license_finder/package_managers/merged_package_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module LicenseFinder
   describe MergedPackage do
-    let(:package) { Package.new('foo', '1.0.0', spec_licenses: ['MIT']) }
+    let(:package) { Package.new('foo', '1.0.0', spec_licenses: ['MIT'], install_path: '/tmp/foo') }
     let(:subproject_paths) { 'path/to/project/with/foo' }
 
     subject { MergedPackage.new(package, [subproject_paths]) }
@@ -24,6 +24,10 @@ module LicenseFinder
       expect(subject.subproject_paths[0]).to end_with(subproject_paths)
     end
 
+    it 'returns the install path' do
+      expect(subject.install_path).to eq('/tmp/foo')
+    end
+
     describe '#eql?' do
       it 'returns true when the package names are equal' do
         p1 = MergedPackage.new(Package.new('foo', '1.0.0'), ['/path/to/package1'])

data/spec/lib/license_finder/package_managers/npm_package_spec.rb

@@ -26,6 +26,7 @@ module LicenseFinder
     its(:groups) { should == [] } # TODO: put devDependencies in 'dev' group?
     its(:children) { should == ["coffee-script"] }
     its(:install_path) { should eq "some/node/package/path" }
+    its(:package_manager) { should eq 'Npm' }
 
     describe '#license_names_from_spec' do
       let(:node_module1) { {"license" => "MIT"} }

data/spec/lib/license_finder/package_managers/nuget_package_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+module LicenseFinder
+  describe NugetPackage do
+    subject { described_class.new 'nuget_package' }
+
+    its(:package_manager) { should == 'Nuget' }
+  end
+end

data/spec/lib/license_finder/package_managers/nuget_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'fakefs/spec_helpers'
+require 'zip'
 
 module LicenseFinder
   describe Nuget do
@@ -23,6 +24,18 @@ module LicenseFinder
         nuget = Nuget.new project_path: Pathname.new("app")
         expect(nuget.assemblies.map(&:name)).to match_array ['Assembly1', 'Assembly1.Tests', 'Assembly2']
       end
+
+      context 'when packages.config is in .nuget directory' do
+        before do
+          FileUtils.mkdir_p 'app/.nuget'
+          FileUtils.touch 'app/.nuget/packages.config'
+        end
+
+        it "finds dependencies all subdirectories containing a packages.config" do
+          nuget = Nuget.new project_path: Pathname.new("app")
+          expect(nuget.assemblies.map(&:name)).to include('.nuget')
+        end
+      end
     end
 
     describe "#current_packages" do
@@ -76,6 +89,34 @@ module LicenseFinder
                   CoolNewDependency)
         expect(nuget.current_packages.map(&:name).uniq).to match_array(deps)
       end
+
+      # cannot run on JRuby due to https://github.com/fakefs/fakefs/issues/303
+      context 'when there is a .nupkg file', :skip => RUBY_PLATFORM =~ /java/ do
+        before do
+          obscure_dependency_nuspec = <<-HERE
+          <?xml version="1.0"?>
+          <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
+          <metadata>
+            <id>ObscureDependency</id>
+            <version>1.3.15</version>
+            <licenseUrl>http://www.opensource.org/licenses/mit-license.php</licenseUrl>
+          </metadata>
+          </package>
+          HERE
+          File.write("app/packages/ObscureDependency.nuspec", obscure_dependency_nuspec)
+          Dir.chdir 'app/packages' do
+            Zip::File.open('ObscureDependency.1.3.15.nupkg', Zip::File::CREATE) do |zipfile|
+              zipfile.add('ObscureDependency.nuspec', 'ObscureDependency.nuspec')
+            end
+          end
+        end
+
+        it "include the licenseUrl from the nuspec file" do
+          nuget = Nuget.new project_path: Pathname.new("app")
+          obscure_dep = nuget.current_packages.select { |dep| dep.name == 'ObscureDependency' }.first
+          expect(obscure_dep.license_names_from_spec).to eq(['http://www.opensource.org/licenses/mit-license.php'])
+        end
+      end
     end
   end
 end

data/spec/lib/license_finder/package_managers/pip_package_spec.rb

@@ -23,6 +23,7 @@ module LicenseFinder
     its(:groups) { should == [] } # TODO: any way to extract install_requires and tests_require from `pip list` or `pip show`?
     its(:children) { should == ["achild"] }
     its(:install_path) { should eq "jasmine/install/path" }
+    its(:package_manager) { should eq 'Pip' }
 
 
     describe '#license_names_from_spec' do

data/spec/lib/license_finder/package_managers/rebar_package_spec.rb

@@ -19,5 +19,6 @@ module LicenseFinder
     its(:groups) { should == [] }
     its(:children) { should == [] }
     its(:install_path) { should eq "deps/uuid" }
+    its(:package_manager) { should eq 'Rebar' }
   end
 end

data/spec/lib/license_finder/reports/csv_report_spec.rb

@@ -29,6 +29,12 @@ module LicenseFinder
       expect(subject.to_s).to eq("gem_a,1.0,/tmp/gems/gem_a-1.0\n")
     end
 
+    it 'supports package_manager column' do
+      dep = NugetPackage.new('gem_a', '1.0')
+      subject = described_class.new([dep], columns: %w[name version package_manager])
+      expect(subject.to_s).to eq("gem_a,1.0,Nuget\n")
+    end
+
     it "does not include columns that should only be in merged reports" do
       dep = Package.new('gem_a', '1.0')
       subject = described_class.new([dep], columns: %w[subproject_paths])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 2.1.0.rc4
+  version: 2.1.0.rc5
 platform: ruby
 authors:
 - Jacob Maine
@@ -20,7 +20,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-27 00:00:00.000000000 Z
+date: 2016-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,6 +106,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.6.7
+- !ruby/object:Gem::Dependency
+  name: rubyzip
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -256,12 +270,9 @@ files:
 - features/fixtures/multi-module-gradle/module1/build.gradle
 - features/fixtures/multi-module-gradle/module2/build.gradle
 - features/fixtures/multi-module-gradle/settings.gradle
+- features/fixtures/nuget/.nuget/.keep
 - features/fixtures/nuget/Fun.Test/packages.config
 - features/fixtures/nuget/Fun/packages.config
-- features/fixtures/nuget/packages/Microsoft.AspNet.Mvc.4.0.30506.0/.keep
-- features/fixtures/nuget/packages/NUnit.2.6.4/.keep
-- features/fixtures/nuget/packages/Ninject.MVC4.3.2.1.0/.keep
-- features/fixtures/nuget/packages/repositories.config
 - features/fixtures/pom.xml
 - features/fixtures/rebar.config
 - features/fixtures/single-module-gradle/build.gradle
@@ -300,6 +311,7 @@ files:
 - lib/license_finder/license/templates/ISC.txt
 - lib/license_finder/license/templates/LGPL.txt
 - lib/license_finder/license/templates/MIT.txt
+- lib/license_finder/license/templates/MPL2.txt
 - lib/license_finder/license/templates/NewBSD.txt
 - lib/license_finder/license/templates/Python.txt
 - lib/license_finder/license/templates/Ruby.txt
@@ -318,6 +330,7 @@ files:
 - lib/license_finder/package_managers/cocoa_pods_package.rb
 - lib/license_finder/package_managers/go_dep.rb
 - lib/license_finder/package_managers/go_package.rb
+- lib/license_finder/package_managers/go_vendor.rb
 - lib/license_finder/package_managers/go_workspace.rb
 - lib/license_finder/package_managers/gradle.rb
 - lib/license_finder/package_managers/gradle_dependency_finder.rb
@@ -356,13 +369,13 @@ files:
 - release/instructions.md
 - spec/dummy_app/Gemfile
 - spec/fixtures/all_pms/.envrc
+- spec/fixtures/all_pms/.nuget/.keep
 - spec/fixtures/all_pms/Gemfile
 - spec/fixtures/all_pms/Godeps/Godeps.json
 - spec/fixtures/all_pms/Podfile
 - spec/fixtures/all_pms/bower.json
 - spec/fixtures/all_pms/build.gradle
 - spec/fixtures/all_pms/package.json
-- spec/fixtures/all_pms/packages/.keep
 - spec/fixtures/all_pms/pom.xml
 - spec/fixtures/all_pms/rebar.config
 - spec/fixtures/all_pms/requirements.txt
@@ -411,6 +424,8 @@ files:
 - spec/lib/license_finder/package_managers/cocoa_pods_package_spec.rb
 - spec/lib/license_finder/package_managers/cocoa_pods_spec.rb
 - spec/lib/license_finder/package_managers/go_dep_spec.rb
+- spec/lib/license_finder/package_managers/go_package_spec.rb
+- spec/lib/license_finder/package_managers/go_vendor_spec.rb
 - spec/lib/license_finder/package_managers/go_workspace_spec.rb
 - spec/lib/license_finder/package_managers/gradle_package_spec.rb
 - spec/lib/license_finder/package_managers/gradle_spec.rb
@@ -419,6 +434,7 @@ files:
 - spec/lib/license_finder/package_managers/merged_package_spec.rb
 - spec/lib/license_finder/package_managers/npm_package_spec.rb
 - spec/lib/license_finder/package_managers/npm_spec.rb
+- spec/lib/license_finder/package_managers/nuget_package_spec.rb
 - spec/lib/license_finder/package_managers/nuget_spec.rb
 - spec/lib/license_finder/package_managers/pip_package_spec.rb
 - spec/lib/license_finder/package_managers/pip_spec.rb
@@ -460,7 +476,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Audit the OSS licenses of your application's dependencies.

data/features/fixtures/nuget/packages/repositories.config

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<repositories>
-  <repository path="..\Fun.Javascript.Test\packages.config" />
-  <repository path="..\Fun.Test\packages.config" />
-  <repository path="..\Fun\packages.config" />
-</repositories>