license_finder 2.1.0.rc4 → 2.1.0.rc5

data/spec/lib/license_finder/configuration_spec.rb

@@ -53,7 +53,7 @@ module LicenseFinder
           {gradle_command: nil},
           {"gradle_command" => nil}
         )
-        expect(subject.gradle_command).to eq "gradle"
+        expect(subject.gradle_command).to eq "gradle --console plain"
       end
     end
 

data/spec/lib/license_finder/license/definitions_spec.rb

@@ -74,6 +74,18 @@ describe LicenseFinder::License, "MIT" do
   end
 end
 
+describe LicenseFinder::License, "MPL2" do
+  subject { described_class.find_by_name "MPL2" }
+
+  describe "#matches_text?" do
+    it "should return true if the text begins with 'The Mozilla Public License, version 2.0'" do
+      expect(subject).to be_matches_text "Mozilla Public License, version 2.0"
+
+      expect(subject).not_to be_matches_text "Something else\nMozilla Public License, version 2.0"
+    end
+  end
+end
+
 describe LicenseFinder::License, "NewBSD" do
   subject { described_class.find_by_name "NewBSD" }
 

data/spec/lib/license_finder/package_managers/bower_package_spec.rb

@@ -23,6 +23,7 @@ module LicenseFinder
     its(:groups) { should == [] } # TODO: does `bower list` output devDependencies? If so, put them in 'dev' group?
     its(:children) { should == [] } # TODO: get dependencies from dependencies and devDependencies, like NPM
     its(:install_path) { should eq "/path/to/thing" }
+    its(:package_manager) { should eq 'Bower' }
 
     context "when package is NOT installed" do
       subject do

data/spec/lib/license_finder/package_managers/bundler_package_spec.rb

@@ -30,5 +30,6 @@ module LicenseFinder
     its(:children) { should == ['foo'] }
     its(:license_names_from_spec) { should eq ['MIT', 'GPL'] }
     its(:install_path) { should =~ /spec_name-2\.1\.3\z/ }
+    its(:package_manager) { should == "Bundler" }
   end
 end

data/spec/lib/license_finder/package_managers/cocoa_pods_package_spec.rb

@@ -14,6 +14,7 @@ module LicenseFinder
     its(:homepage) { should eq "" }
     its(:groups) { should == [] }
     its(:children) { should == [] }
+    its(:package_manager) { should eq 'CocoaPods' }
 
     describe '#licenses' do
       context "when there's a license" do

data/spec/lib/license_finder/package_managers/go_dep_spec.rb

@@ -57,6 +57,35 @@ module LicenseFinder
         end
       end
 
+      context 'when there are duplicate dependencies' do
+        let(:content) do
+          '{
+	           "ImportPath": "github.com/foo/bar",
+	           "GoVersion": "go1.3",
+	           "Deps": [
+	           	{
+	           		"ImportPath": "github.com/foo/baz/sub1",
+	           		"Rev": "28838aae6e8158e3695cf90e2f0ed2498b68ee1d"
+	           	},
+	           	{
+	           		"ImportPath": "github.com/foo/baz/sub2",
+	           		"Rev": "28838aae6e8158e3695cf90e2f0ed2498b68ee1d"
+	           	},
+	           	{
+	           		"ImportPath": "github.com/foo/baz/sub3",
+	           		"Rev": "28838aae6e8158e3695cf90e2f0ed2498b68ee1d"
+	           	}
+            ]
+          }'
+        end
+
+        it 'should return one dependency only' do
+          packages = subject.current_packages
+          expect(packages.map(&:name)).to eq(['github.com/foo/baz'])
+          expect(packages.map(&:version)).to eq(['28838aa'])
+        end
+      end
+
       context 'when dependencies are not vendored' do
         before do
           ENV['GOPATH'] = '/fake/go/path'

data/spec/lib/license_finder/package_managers/go_package_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+module LicenseFinder
+  describe GoPackage do
+    let(:options) {
+      {
+       'ImportPath' => 'github.com/pivotal/spec_name',
+       'Rev' => '4326c3435332d06b410a2672d28d1343c4059fae',
+      }
+    }
+
+    let(:full_version) { true }
+
+    subject { described_class.from_dependency(options, Pathname.new('/Go/src'), full_version) }
+
+    its(:name) { should == 'github.com/pivotal/spec_name' }
+    its(:version) { should == '4326c3435332d06b410a2672d28d1343c4059fae' }
+    its(:install_path) { should == '/Go/src/github.com/pivotal/spec_name' }
+    its(:package_manager) { should == "Go" }
+
+    context 'when full version is set to false' do
+      let(:full_version) { false }
+
+      its(:version) { should == '4326c34' }
+    end
+
+    context 'when the install path is set in the options' do
+      let(:options) { super().merge('InstallPath' => '/Go/vendor/src/github.com/pivotal/spec_name' ) }
+
+      its(:install_path) { should == '/Go/vendor/src/github.com/pivotal/spec_name' }
+    end
+  end
+end

data/spec/lib/license_finder/package_managers/go_vendor_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+require 'fakefs/spec_helpers'
+
+module LicenseFinder
+  describe GoVendor do
+    include FakeFS::SpecHelpers
+
+    let(:project_path) { '/app' }
+    let(:options) { {} }
+    let(:logger) { double(:logger, active: nil) }
+    subject { GoVendor.new(options.merge(project_path: Pathname(project_path), logger: logger)) }
+
+    context 'when there are go files' do
+      before do
+        FileUtils.mkdir_p project_path
+        FileUtils.touch File.join(project_path, 'main.go')
+        FileUtils.mkdir_p File.join(project_path, 'vendor', 'github.com', 'foo', 'bar')
+      end
+
+      it 'detects the project as go vendor project' do
+        expect(subject.active?).to be true
+      end
+
+      describe '#current_packages' do
+        let(:go_deps) {
+          ["github.com/foo/bar", true]
+        }
+
+        before do
+          allow(subject).to receive(:capture).with(%q[go list -f '{{join .Deps "\n"}}' ./...]).and_return(go_deps)
+          allow(subject).to receive(:capture).with(%q[git rev-list --max-count 1 HEAD]).and_return(["e0ff7ae205f\n", true])
+        end
+
+        RSpec.shared_examples 'current_packages' do |parameter|
+          it 'only returns the parent package' do
+            packages = subject.current_packages
+            expect(packages.count).to eq(1)
+            expect(packages.first.name).to eq('github.com/foo/bar')
+          end
+        end
+
+        include_examples 'current_packages'
+
+        it 'uses the sha of the parent project as the dependency version' do
+          packages = subject.current_packages
+          expect(packages.first.version).to eq('vendored-e0ff7ae205f')
+        end
+
+        context 'when sub packages are being used' do
+          let(:go_deps) {
+            ["github.com/foo/bar\ngithub.com/foo/bar/baz", true]
+          }
+
+          include_examples 'current_packages'
+        end
+
+        context 'when only sub packages are being used' do
+          let(:go_deps) {
+            ["github.com/foo/bar/baz", true]
+          }
+
+          include_examples 'current_packages'
+        end
+
+        context 'when unvendored packages are being used' do
+          let(:go_deps) {
+            ["github.com/foo/bar\ntext/template/parse", true]
+          }
+
+          include_examples 'current_packages'
+        end
+      end
+    end
+
+    context 'when there are go files in subdirectories' do
+      before do
+        FileUtils.mkdir_p project_path
+        FileUtils.mkdir_p File.join(project_path, 'vendor', 'github.com', 'foo', 'bar')
+        FileUtils.touch File.join(project_path, 'vendor', 'github.com', 'foo', 'bar', 'main.go')
+      end
+
+      it 'detects the project as go vendor project' do
+        expect(subject.active?).to be true
+      end
+    end
+
+    context 'if no go files exist' do
+      let(:project_path) { '/ruby_app' }
+
+      before do
+        FileUtils.mkdir_p File.join(project_path, 'vendor')
+      end
+
+      it 'should not mark the project active' do
+        expect(subject.active?).to be false
+      end
+    end
+  end
+end

data/spec/lib/license_finder/package_managers/go_workspace_spec.rb

@@ -4,35 +4,110 @@ module LicenseFinder
   describe GoWorkspace do
     let(:options) { {} }
     let(:logger) { double(:logger, active: nil) }
-    subject { GoWorkspace.new(options.merge(project_path: Pathname('/Users/pivotal/workspace/loggregator'), logger: logger)) }
+    let(:project_path) { '/Users/pivotal/workspace/loggregator'}
+    subject { GoWorkspace.new(options.merge(project_path: Pathname(project_path), logger: logger)) }
+
+    describe '#go_list' do
+
+      let(:go_list_output) {
+        <<HERE
+encoding/json
+github.com/onsi/ginkgo
+HERE
+      }
+
+      before do
+        allow(Dir).to receive(:chdir).with(Pathname.new project_path) { |&b| b.call() }
+        allow(FileTest).to receive(:exist?).and_return(false)
+        allow(FileTest).to receive(:exist?).with(File.join(project_path, '.envrc')).and_return(true)
+      end
+
+      it 'changes the directory' do
+        subject.send(:go_list)
+
+        expect(Dir).to have_received(:chdir)
+      end
+
+      it 'returns the skip the standard libs and return lines of the output' do
+        allow(subject).to receive(:capture).with('go list -f \'{{join .Deps "\n"}}\' ./...').and_return([go_list_output, true])
+        packages = subject.send(:go_list)
+        expect(packages.count).to eq(1)
+        expect(packages.first).to eq('github.com/onsi/ginkgo')
+      end
+
+      it 'sets gopath to the envrc path' do
+        allow(subject).to receive(:capture).with('go list -f \'{{join .Deps "\n"}}\' ./...') {
+          expect(ENV['GOPATH']).to be_nil
+          ['', true]
+        }
+
+        subject.send(:go_list)
+      end
+    end
+
+    describe '#git_modules' do
+      before do
+        allow(FileTest).to receive(:exist?).and_return(false)
+        allow(FileTest).to receive(:exist?).with('/Users/pivotal/workspace/loggregator/.envrc').and_return(true)
+        allow(Dir).to receive(:chdir).with(Pathname.new '/Users/pivotal/workspace/loggregator') { |&b| b.call() }
+      end
+
+      context 'if git submodule status fails' do
+        before do
+          allow(subject).to receive(:capture).with('git submodule status').and_return(['', false])
+        end
+
+        it 'should raise an exception' do
+          expect { subject.send(:git_modules) }.to raise_exception(/git submodule status failed/)
+        end
+      end
+
+      context 'if git submodule status succeeds' do
+        let(:git_submodule_status_output) {
+          <<HERE
+1993eafbef57be29ee8f5eb9d26a22f20ff3c207 src/github.com/GaryBoone/GoStats (heads/master)
+55eb11d21d2a31a3cc93838241d04800f52e823d src/github.com/Sirupsen/logrus (v0.7.3)
+HERE
+        }
+
+        before do
+          allow(subject).to receive(:capture).with('git submodule status').and_return([git_submodule_status_output, true])
+        end
+
+        it 'should return the filtered submodules' do
+          submodules = subject.send(:git_modules)
+          expect(submodules.count).to eq(2)
+          expect(submodules.first.install_path).to eq('/Users/pivotal/workspace/loggregator/src/github.com/GaryBoone/GoStats')
+          expect(submodules.first.revision).to eq('1993eafbef57be29ee8f5eb9d26a22f20ff3c207')
+        end
+      end
+    end
 
     describe '#current_packages' do
-      let(:content) {
-        '_/Users/pivotal/workspace/loggregator/src/bitbucket.org/kardianos/osext
-         _/Users/pivotal/workspace/loggregator/src/bitbucket.org/kardianos/osext/something
-         _/Users/pivotal/workspace/loggregator/src/deaagent
-         _/Users/pivotal/workspace/loggregator/src/deaagent/deaagent
-         _/Users/pivotal/workspace/loggregator/src/deaagent/domain
-         _/Users/pivotal/workspace/loggregator/src/doppler
-         _/Users/pivotal/workspace/loggregator/src/doppler/config
-         _/Users/pivotal/workspace/loggregator/src/doppler/groupedsinks
-         _/Users/pivotal/workspace/loggregator/src/doppler/groupedsinks/firehose_group
-         _/Users/pivotal/workspace/loggregator/src/doppler/groupedsinks/sink_wrapper'
+      let(:git_modules_output) {
+        [GoWorkspace::Submodule.new("/Users/pivotal/workspace/loggregator/src/bitbucket.org/kardianos/osext", "b8a35001b773c267e")]
       }
 
-      let(:git_modules) {
-        "b8a35001b773c267e src/bitbucket.org/kardianos/osext (heads/master)"
+      let(:go_list_output) {
+        [
+         "bitbucket.org/kardianos/osext",
+         "bitbucket.org/kardianos/osext/foo",
+        ]
       }
 
+
       before do
+        allow(FileTest).to receive(:exist?).and_return(true)
+
         allow(Dir).to receive(:chdir).with(Pathname('/Users/pivotal/workspace/loggregator')) { |&block| block.call }
-        allow(subject).to receive(:capture).with('go list -f "{{.ImportPath}} " ./...').and_return([content.to_s, true])
-        allow(subject).to receive(:capture).with('git submodule status').and_return([git_modules, true])
+        allow(subject).to receive(:go_list).and_return(go_list_output)
+        allow(subject).to receive(:git_modules).and_return(git_modules_output)
       end
 
       describe 'should return an array of go packages' do
         it 'provides package names' do
           packages = subject.current_packages
+          expect(packages.count).to eq(1)
           first_package = packages.first
           expect(first_package.name).to eq 'bitbucket.org/kardianos/osext'
           expect(first_package.version).to eq 'b8a3500'
@@ -45,53 +120,118 @@ module LicenseFinder
           expect(packages.count).to eq(1)
         end
 
-        context 'if git submodule status fails' do
-          before do
-            allow(subject).to receive(:capture).with('git submodule status').and_return(['', false])
-          end
-
-          it 'should raise an exception' do
-            expect { subject.current_packages }.to raise_exception(/git submodule status failed/)
-          end
-        end
-
         context 'when requesting the full version' do
           let(:options) { { go_full_version:true } }
           it 'list the dependencies with full version' do
             expect(subject.current_packages.map(&:version)).to eq ["b8a35001b773c267e"]
           end
         end
-      end
 
-      describe '#package_path' do
-        it 'returns the package_path' do
-          expect(subject.package_path).to eq Pathname('/Users/pivotal/workspace/loggregator/.envrc')
+        context 'when the deps are in a vendor directory' do
+          let(:git_modules_output) {
+            [GoWorkspace::Submodule.new("/Users/pivotal/workspace/loggregator/vendor/src/bitbucket.org/kardianos/osext", "b8a35001b773c267e")]
+          }
+
+          it 'reports the right import path' do
+            expect(subject.current_packages.map(&:name)).to include('bitbucket.org/kardianos/osext')
+          end
+
+          it 'reports the right install path' do
+            expect(subject.current_packages.map(&:install_path)).to include('/Users/pivotal/workspace/loggregator/vendor/src/bitbucket.org/kardianos/osext')
+          end
         end
-      end
 
-      describe '#active?' do
-        let(:envrc)   { '/Users/pivotal/workspace/loggregator/.envrc' }
+        context 'when only the subpackage is being used' do
+          let(:go_list_output) {
+            [
+             "bitbucket.org/kardianos/osext/foo",
+            ]
+          }
 
-        it 'returns true when .envrc contains GOPATH' do
-          allow(FileTest).to receive(:exist?).with(envrc).and_return(true)
-          allow(IO).to receive(:read).with(Pathname(envrc)).and_return('export GOPATH=/foo/bar')
-          expect(subject.active?).to eq(true)
+          it 'returns the top level repo name as the import path' do
+            packages = subject.current_packages
+            expect(packages.map(&:name)).to eq(['bitbucket.org/kardianos/osext'])
+          end
         end
 
-        it 'returns false when .envrc does not contain GOPATH' do
-          allow(FileTest).to receive(:exist?).with(envrc).and_return(true)
-          allow(IO).to receive(:read).with(Pathname(envrc)).and_return('this is not an envrc file')
-          expect(subject.active?).to eq(false)
+        context 'when only the subpackage is being used' do
+          let(:git_modules_output) {
+            [GoWorkspace::Submodule.new("/Users/pivotal/workspace/loggregator/vendor/src/github.com/onsi/foo", "e762c377b10053a8b"),
+             GoWorkspace::Submodule.new("/Users/pivotal/workspace/loggregator/vendor/src/github.com/onsi/foobar", "b8a35001b773c267e")]
+          }
+
+          let(:go_list_output) {
+            [
+             "github.com/onsi/foo",
+             "github.com/onsi/foobar",
+            ]
+          }
+
+          it 'returns the top level repo name as the import path' do
+            packages = subject.current_packages
+            expect(packages.map(&:name)).to eq(['github.com/onsi/foo', 'github.com/onsi/foobar'])
+          end
         end
+      end
+    end
+
+    describe '#package_path' do
+      before do
+        allow(FileTest).to receive(:exist?).and_return(true)
+      end
+
+      it 'returns the package_path' do
+        expect(subject.package_path).to eq Pathname('/Users/pivotal/workspace/loggregator')
+      end
+    end
+
+    describe '#active?' do
+      let(:envrc)   { '/Users/pivotal/workspace/loggregator/.envrc' }
+
+      before do
+        allow(FileTest).to receive(:exist?).and_return(false)
+      end
+
+      it 'returns true when .envrc contains GOPATH' do
+        allow(FileTest).to receive(:exist?).with(envrc).and_return(true)
+        allow(IO).to receive(:read).with(Pathname(envrc)).and_return('export GOPATH=/foo/bar')
+        expect(subject.active?).to eq(true)
+      end
+
+      it 'returns false when .envrc does not contain GOPATH' do
+        allow(FileTest).to receive(:exist?).with(envrc).and_return(true)
+        allow(IO).to receive(:read).with(Pathname(envrc)).and_return('this is not an envrc file')
+        expect(subject.active?).to eq(false)
+      end
 
-        it 'returns false when .envrc does not exist' do
-          allow(FileTest).to receive(:exist?).with(envrc).and_return(false)
+      it 'returns false when .envrc does not exist' do
+        expect(subject.active?).to eq(false)
+      end
+
+      it 'logs the active state' do
+        expect(logger).to receive(:active)
+        subject.active?
+      end
+
+      context 'when Godep is present' do
+        let(:godeps)   { '/Users/pivotal/workspace/loggregator/Godeps/Godeps.json' }
+
+        it 'should prefer Godeps over go_workspace' do
+          allow(FileTest).to receive(:exist?).with(Pathname(godeps)).and_return(true)
           expect(subject.active?).to eq(false)
         end
+      end
+
+      context 'when .envrc is present in a parent directory' do
+        subject {
+          GoWorkspace.new(options.merge(project_path: Pathname('/Users/pivotal/workspace/loggregator/src/github.com/foo/bar'),
+                                        logger: logger))
+        }
 
-        it 'logs the active state' do
-          expect(logger).to receive(:active)
-          subject.active?
+        it 'returns true' do
+          allow(FileTest).to receive(:exist?).with(envrc).and_return(true)
+          allow(IO).to receive(:read).with(Pathname(envrc)).and_return('export GOPATH=/foo/bar')
+          expect(subject.active?).to be true
         end
       end
     end