license_finder 2.0.0.rc2 → 2.0.0

data/spec/lib/license_finder/package_managers/pip_package_spec.rb

@@ -10,8 +10,6 @@ module LicenseFinder
       })
     end
 
-    it_behaves_like "a Package"
-
     def make_package(pypi_def)
       described_class.new('jasmine', '1.3.1', "jasmine/install/path", pypi_def)
     end

data/spec/lib/license_finder/package_managers/pip_spec.rb

@@ -11,8 +11,8 @@ module LicenseFinder
       end
 
       def stub_pypi(name, version, response)
-        stub_request(:get, "https://pypi.python.org/pypi/#{name}/#{version}/json").
-          to_return(response)
+        stub_request(:get, "https://pypi.python.org/pypi/#{name}/#{version}/json")
+          .to_return(response)
       end
 
       it 'fetches data from pip' do
@@ -23,41 +23,24 @@ module LicenseFinder
         stub_pypi("jasmine", "1.3.1", status: 200, body: '{}')
         stub_pypi("jasmine-core", "1.3.1", status: 200, body: '{}')
 
-        current_packages = pip.current_packages
-
-        expect(current_packages.size).to eq(2)
-        expect(current_packages.first).to be_a(Package)
+        expect(pip.current_packages.map { |p| [p.name, p.version, p.install_path] }).to eq [
+          ["jasmine", "1.3.1", "jasmine/path/jasmine"],
+          ["jasmine-core", "1.3.1", "jasmine-core/path/jasmine-core"]
+        ]
       end
 
       it "fetches data from pypi" do
         stub_pip [{"name" => "jasmine", "version" => "1.3.1", "location" => "jasmine/path"}].to_json
         stub_pypi("jasmine", "1.3.1", status: 200, body: JSON.generate(info: {summary: "A summary"}))
 
-        expect(PipPackage).to receive(:new).with("jasmine", "1.3.1", "jasmine/path/jasmine", {"summary" => "A summary"}, anything)
-        pip.current_packages
+        expect(pip.current_packages.first.summary).to eq "A summary"
       end
 
       it "ignores pypi if it can't find useful info" do
         stub_pip [{"name" => "jasmine", "version" => "1.3.1", "location" => "jasmine/path"}].to_json
         stub_pypi("jasmine", "1.3.1", status: 404, body: '')
 
-        expect(PipPackage).to receive(:new).with("jasmine", "1.3.1", "jasmine/path/jasmine", {}, anything)
-        pip.current_packages
-      end
-    end
-
-    describe '.active?' do
-      let(:package_path) { double(:requirements_file) }
-      let(:pip) { Pip.new package_path: package_path }
-
-      it 'is true with a requirements.txt file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(pip).to be_active
-      end
-
-      it 'is false without a requirements.txt file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(pip).to_not be_active
+        expect(pip.current_packages.first.summary).to eq ""
       end
     end
   end

data/spec/lib/license_finder/package_spec.rb

@@ -16,8 +16,6 @@ module LicenseFinder
       )
     end
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "a package" }
     its(:version) { should == "1.3.1" }
     its(:summary) { should == "a summary" }
@@ -46,8 +44,8 @@ module LicenseFinder
         license_files = license_names.map do |license_name|
           double(:file, license: License.find_by_name(license_name), path: "some/path")
         end
-        allow(PossibleLicenseFiles).to receive(:find).
-          with("some/package/path").and_return(license_files)
+        allow(LicenseFiles).to receive(:find).with("some/package/path")
+          .and_return(license_files)
       end
 
       it "are not required" do

data/spec/lib/license_finder/packages/activation_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+module LicenseFinder
+  describe Activation do
+    let(:package) { Package.new("p", nil) }
+    let(:license) { License.find_by_name("l") }
+
+    it "reports that a license has been activated for a package" do
+      subject = Activation::Basic.new(package, license)
+      expect(subject.package).to eq package
+      expect(subject.license).to eq license
+    end
+
+    describe Activation::FromDecision do
+      it "logs that it came from a decision" do
+        activation = described_class.new(package, license)
+        subject = capture_stdout { activation.log(Logger::Verbose.new) }
+        expect(subject).to eq "LicenseFinder::Package: package p: found license 'l' from decision\n"
+      end
+    end
+
+    describe Activation::FromSpec do
+      it "logs that it came from a spec" do
+        activation = described_class.new(package, license)
+        subject = capture_stdout { activation.log(Logger::Verbose.new) }
+        expect(subject).to eq "LicenseFinder::Package: package p: found license 'l' from spec\n"
+      end
+    end
+
+    describe Activation::FromFiles do
+      it "logs that it came from some files" do
+        files = [double(:file, path: "x"), double(:file, path: "y")]
+        activation = described_class.new(package, license, files)
+        subject = capture_stdout { activation.log(Logger::Verbose.new) }
+        expect(subject).to eq "LicenseFinder::Package: package p: found license 'l' from file 'x'\nLicenseFinder::Package: package p: found license 'l' from file 'y'\n"
+      end
+    end
+
+    describe Activation::None do
+      it "logs that no licenses could be found" do
+        activation = described_class.new(package, license)
+        subject = capture_stdout { activation.log(Logger::Verbose.new) }
+        expect(subject).to eq "LicenseFinder::Package: package p: no licenses found\n"
+      end
+    end
+  end
+end

data/spec/lib/license_finder/{possible_license_files_spec.rb → packages/license_files_spec.rb}

@@ -1,11 +1,7 @@
 require 'spec_helper'
 
 module LicenseFinder
-  describe PossibleLicenseFiles do
-    def fixture_path(fixture)
-      Pathname.new(__FILE__).dirname.join('..', '..', 'fixtures', fixture)
-    end
-
+  describe LicenseFiles do
     describe "#find" do
       def files_in(fixture)
         root_path = fixture_path(fixture)
@@ -38,7 +34,7 @@ module LicenseFinder
       it "includes files nested inside LICENSE directory" do
         expect(files_in('license_directory')).to match_array(%w[
           COPYING
-          LICENSE/Apache.txt
+          LICENSE/MIT.txt
         ])
       end
 

data/spec/lib/license_finder/packages/licensing_spec.rb

@@ -0,0 +1 @@
+# tested via Package#licenses

data/spec/spec_helper.rb

@@ -24,4 +24,6 @@ RSpec.configure do |config|
       FileUtils.rm_rf(tmp_dir)
     end
   end
+
+  config.include LicenseFinder::TestFixtures
 end

data/spec/support/shared_examples_for_package_manager.rb

@@ -1,5 +1,7 @@
 module LicenseFinder
   shared_examples "a PackageManager" do
+    let(:all_pms) { fixture_path("all_pms") }
+
     it { expect(described_class.ancestors).to include PackageManager }
     it { expect(PackageManager.package_managers).to include described_class }
 
@@ -8,9 +10,20 @@ module LicenseFinder
         logger = double(:logger)
         expect(logger).to receive(:active)
 
-        subject = described_class.new logger: logger
+        subject = described_class.new logger: logger, project_path: all_pms
         subject.active?
       end
     end
+
+    describe '.active?' do
+      it 'is true when package manager file exists' do
+        expect(described_class.new(project_path: all_pms)).to be_active
+      end
+
+      it 'is false without a package manager file' do
+        no_pms = fixture_path("not/a/path")
+        expect(described_class.new(project_path: no_pms)).to_not be_active
+      end
+    end
   end
 end

data/spec/support/test_fixtures.rb

@@ -0,0 +1,7 @@
+module LicenseFinder
+  module TestFixtures
+    def fixture_path(fixture)
+      LicenseFinder::ROOT_PATH.join("..", "..", "spec", "fixtures", fixture)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: license_finder
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc2
+  version: 2.0.0
 platform: ruby
 authors:
 - Jacob Maine
@@ -20,7 +20,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-14 00:00:00.000000000 Z
+date: 2015-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -176,6 +176,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: cocoapods
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
       LicenseFinder works with your package managers to find
       dependencies, detect the licenses of the packages in them, compare
@@ -236,6 +250,7 @@ files:
 - lib/license_finder/cli/project_name.rb
 - lib/license_finder/cli/whitelist.rb
 - lib/license_finder/configuration.rb
+- lib/license_finder/core.rb
 - lib/license_finder/decision_applier.rb
 - lib/license_finder/decisions.rb
 - lib/license_finder/license.rb
@@ -267,16 +282,18 @@ files:
 - lib/license_finder/package_managers/cocoa_pods_package.rb
 - lib/license_finder/package_managers/gradle.rb
 - lib/license_finder/package_managers/gradle_package.rb
-- lib/license_finder/package_managers/manual_package.rb
 - lib/license_finder/package_managers/maven.rb
 - lib/license_finder/package_managers/maven_package.rb
 - lib/license_finder/package_managers/npm.rb
 - lib/license_finder/package_managers/npm_package.rb
 - lib/license_finder/package_managers/pip.rb
 - lib/license_finder/package_managers/pip_package.rb
+- lib/license_finder/packages/activation.rb
+- lib/license_finder/packages/license_files.rb
+- lib/license_finder/packages/licensing.rb
+- lib/license_finder/packages/manual_package.rb
+- lib/license_finder/packages/possible_license_file.rb
 - lib/license_finder/platform.rb
-- lib/license_finder/possible_license_file.rb
-- lib/license_finder/possible_license_files.rb
 - lib/license_finder/report.rb
 - lib/license_finder/reports/csv_report.rb
 - lib/license_finder/reports/erb_report.rb
@@ -290,9 +307,16 @@ files:
 - license_finder.gemspec
 - release/instructions.md
 - spec/feature_helper.rb
+- spec/fixtures/all_pms/Gemfile
+- spec/fixtures/all_pms/Podfile
+- spec/fixtures/all_pms/bower.json
+- spec/fixtures/all_pms/build.gradle
+- spec/fixtures/all_pms/package.json
+- spec/fixtures/all_pms/pom.xml
+- spec/fixtures/all_pms/requirements.txt
 - spec/fixtures/config/license_finder.yml
 - spec/fixtures/license_directory/COPYING
-- spec/fixtures/license_directory/LICENSE/Apache.txt
+- spec/fixtures/license_directory/LICENSE/MIT.txt
 - spec/fixtures/license_names/COPYING.txt
 - spec/fixtures/license_names/LICENSE
 - spec/fixtures/license_names/Licence.rdoc
@@ -329,16 +353,18 @@ files:
 - spec/lib/license_finder/package_managers/pip_package_spec.rb
 - spec/lib/license_finder/package_managers/pip_spec.rb
 - spec/lib/license_finder/package_spec.rb
-- spec/lib/license_finder/possible_license_file_spec.rb
-- spec/lib/license_finder/possible_license_files_spec.rb
+- spec/lib/license_finder/packages/activation_spec.rb
+- spec/lib/license_finder/packages/license_files_spec.rb
+- spec/lib/license_finder/packages/licensing_spec.rb
+- spec/lib/license_finder/packages/possible_license_file_spec.rb
 - spec/lib/license_finder/reports/csv_report_spec.rb
 - spec/lib/license_finder/reports/html_report_spec.rb
 - spec/lib/license_finder/reports/markdown_report_spec.rb
 - spec/lib/license_finder/reports/text_report_spec.rb
 - spec/spec_helper.rb
-- spec/support/shared_examples_for_package.rb
 - spec/support/shared_examples_for_package_manager.rb
 - spec/support/stdout_helpers.rb
+- spec/support/test_fixtures.rb
 homepage: https://github.com/pivotal/LicenseFinder
 licenses:
 - MIT
@@ -354,13 +380,92 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Audit the OSS licenses of your application's dependencies.
-test_files: []
+test_files:
+- features/features/cli_spec.rb
+- features/features/configure/add_dependencies_spec.rb
+- features/features/configure/approve_dependencies_spec.rb
+- features/features/configure/assign_licenses_spec.rb
+- features/features/configure/ignore_dependencies_spec.rb
+- features/features/configure/ignore_groups_spec.rb
+- features/features/configure/name_project_spec.rb
+- features/features/configure/whitelist_licenses_spec.rb
+- features/features/package_managers/bower_spec.rb
+- features/features/package_managers/cocoapods_spec.rb
+- features/features/package_managers/gradle_spec.rb
+- features/features/package_managers/maven_spec.rb
+- features/features/package_managers/npm_spec.rb
+- features/features/package_managers/pip_spec.rb
+- features/features/report/csv_spec.rb
+- features/features/report/html_spec.rb
+- features/fixtures/Podfile
+- features/fixtures/build.gradle
+- features/fixtures/pom.xml
+- features/support/testing_dsl.rb
+- spec/feature_helper.rb
+- spec/fixtures/all_pms/Gemfile
+- spec/fixtures/all_pms/Podfile
+- spec/fixtures/all_pms/bower.json
+- spec/fixtures/all_pms/build.gradle
+- spec/fixtures/all_pms/package.json
+- spec/fixtures/all_pms/pom.xml
+- spec/fixtures/all_pms/requirements.txt
+- spec/fixtures/config/license_finder.yml
+- spec/fixtures/license_directory/COPYING
+- spec/fixtures/license_directory/LICENSE/MIT.txt
+- spec/fixtures/license_names/COPYING.txt
+- spec/fixtures/license_names/LICENSE
+- spec/fixtures/license_names/Licence.rdoc
+- spec/fixtures/license_names/Mit-License
+- spec/fixtures/license_names/README.rdoc
+- spec/fixtures/nested_gem/vendor/LICENSE
+- spec/fixtures/utf8_gem/README
+- spec/lib/license_finder/cli/approvals_spec.rb
+- spec/lib/license_finder/cli/dependencies_spec.rb
+- spec/lib/license_finder/cli/ignored_dependencies_spec.rb
+- spec/lib/license_finder/cli/ignored_groups_spec.rb
+- spec/lib/license_finder/cli/licenses_spec.rb
+- spec/lib/license_finder/cli/main_spec.rb
+- spec/lib/license_finder/cli/project_name_spec.rb
+- spec/lib/license_finder/cli/whitelist_spec.rb
+- spec/lib/license_finder/configuration_spec.rb
+- spec/lib/license_finder/decision_applier_spec.rb
+- spec/lib/license_finder/decisions_spec.rb
+- spec/lib/license_finder/license/definitions_spec.rb
+- spec/lib/license_finder/license_spec.rb
+- spec/lib/license_finder/package_manager_spec.rb
+- spec/lib/license_finder/package_managers/bower_package_spec.rb
+- spec/lib/license_finder/package_managers/bower_spec.rb
+- spec/lib/license_finder/package_managers/bundler_package_spec.rb
+- spec/lib/license_finder/package_managers/bundler_spec.rb
+- spec/lib/license_finder/package_managers/cocoa_pods_package_spec.rb
+- spec/lib/license_finder/package_managers/cocoa_pods_spec.rb
+- spec/lib/license_finder/package_managers/gradle_package_spec.rb
+- spec/lib/license_finder/package_managers/gradle_spec.rb
+- spec/lib/license_finder/package_managers/maven_package_spec.rb
+- spec/lib/license_finder/package_managers/maven_spec.rb
+- spec/lib/license_finder/package_managers/npm_package_spec.rb
+- spec/lib/license_finder/package_managers/npm_spec.rb
+- spec/lib/license_finder/package_managers/pip_package_spec.rb
+- spec/lib/license_finder/package_managers/pip_spec.rb
+- spec/lib/license_finder/package_spec.rb
+- spec/lib/license_finder/packages/activation_spec.rb
+- spec/lib/license_finder/packages/license_files_spec.rb
+- spec/lib/license_finder/packages/licensing_spec.rb
+- spec/lib/license_finder/packages/possible_license_file_spec.rb
+- spec/lib/license_finder/reports/csv_report_spec.rb
+- spec/lib/license_finder/reports/html_report_spec.rb
+- spec/lib/license_finder/reports/markdown_report_spec.rb
+- spec/lib/license_finder/reports/text_report_spec.rb
+- spec/spec_helper.rb
+- spec/support/shared_examples_for_package_manager.rb
+- spec/support/stdout_helpers.rb
+- spec/support/test_fixtures.rb

data/spec/support/shared_examples_for_package.rb

@@ -1,35 +0,0 @@
-module LicenseFinder
-  shared_examples "a Package" do
-    context "logging" do
-      let!(:logger) { Logger::Quiet.new }
-      before { allow(Logger::Default).to receive(:new) { logger } }
-
-      it "logs licenses found in specs" do
-        license_short_name = "foo"
-        license_pretty_name = "pretty foo"
-        license = double(:license, name: license_pretty_name)
-
-        allow(subject).to receive(:license_names_from_spec).and_return([license_short_name])
-        allow(License).to receive(:find_by_name).with(license_short_name) { license }
-
-        expect(logger).to receive(:license).with(anything, subject.name, license_pretty_name, "from spec")
-
-        subject.licenses_from_spec
-      end
-
-      it "logs licenses found in files" do
-        license_short_name = "foo"
-        license_pretty_name = "pretty foo"
-        license_path = "/path/to/license"
-        license = double(:license, name: license_pretty_name)
-        license_file = double(:license_file, license: license, path: license_path)
-
-        allow(subject).to receive(:license_files) { [license_file] }
-
-        expect(logger).to receive(:license).with(anything, subject.name, license_pretty_name, "from file '#{license_path}'")
-
-        subject.licenses_from_files
-      end
-    end
-  end
-end