license_finder 2.0.0.rc2 → 2.0.0

data/spec/lib/license_finder/license_spec.rb

@@ -4,18 +4,17 @@ module LicenseFinder
   describe License do
     describe ".find_by_name" do
       it "should find a registered license" do
-        expect(License.find_by_name("Apache2")).to be_a License
+        license = License.find_by_name("Expat")
+        expect(license.name).to eq "MIT"
       end
 
       it "should make an unrecognized license" do
         license = License.find_by_name("not a known license")
-
-        expect(license).to be_a License
         expect(license.name).to eq "not a known license"
       end
 
       context "making the default license" do
-        it "set the name to 'unknown'" do
+        it "sets the name to 'unknown'" do
           expect(License.find_by_name(nil).name).to eq("unknown")
         end
 
@@ -27,7 +26,8 @@ module LicenseFinder
 
     describe ".find_by_text" do
       it "should find a registered license" do
-        expect(License.find_by_text('This gem is released under the MIT license')).to be_a License
+        license = License.find_by_text('This gem is released under the MIT license')
+        expect(license.name).to eq "MIT"
       end
 
       it "returns nil if not found" do

data/spec/lib/license_finder/package_managers/bower_package_spec.rb

@@ -9,15 +9,12 @@ module LicenseFinder
           "name" => "dependency-library",
           "description" => "description",
           "version" => "1.3.3.7",
-          "main" => "normalize.css",
           "readme" => "some readme stuff",
           "homepage" => "homepage"
         }
       )
     end
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "dependency-library" }
     its(:version) { should == "1.3.3.7" }
     its(:summary) { should == "description" }
@@ -27,7 +24,6 @@ module LicenseFinder
     its(:children) { should == [] } # TODO: get dependencies from dependencies and devDependencies, like NPM
     its(:install_path) { should eq "/path/to/thing" }
 
-
     context "when package is NOT installed" do
       subject do
         described_class.new(

data/spec/lib/license_finder/package_managers/bower_spec.rb

@@ -13,19 +13,13 @@ module LicenseFinder
               "dependency-library": {
                 "canonicalDir": "/path/to/thing",
                 "pkgMeta": {
-                  "name": "dependency-library",
-                  "description": "description",
-                  "version": "1.3.3.7",
-                  "main": "normalize.css"
+                  "name": "dependency-library"
                 }
               },
               "another-dependency": {
                 "canonicalDir": "/path/to/thing2",
                 "pkgMeta": {
-                  "name": "another-dependency",
-                  "description": "description2",
-                  "version": "4.2",
-                  "main": "denormalize.css"
+                  "name": "another-dependency"
                 }
               }
             }
@@ -33,25 +27,10 @@ module LicenseFinder
         JSON
         allow(bower).to receive("`").with(/bower/).and_return(json)
 
-        current_packages = bower.current_packages
-
-        expect(current_packages.size).to eq(2)
-        expect(current_packages.first).to be_a(Package)
-      end
-    end
-
-    describe '.active?' do
-      let(:package_path) { double(:package_file) }
-      let(:bower) { Bower.new package_path: package_path }
-
-      it 'is true with a bower.json file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(bower).to be_active
-      end
-
-      it 'is false without a bower.json file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(bower).to_not be_active
+        expect(bower.current_packages.map { |p| [p.name, p.install_path] }).to eq [
+          ["dependency-library", "/path/to/thing"],
+          ["another-dependency", "/path/to/thing2"]
+        ]
       end
     end
   end

data/spec/lib/license_finder/package_managers/bundler_package_spec.rb

@@ -4,8 +4,6 @@ module LicenseFinder
   describe BundlerPackage do
     subject { described_class.new(gemspec, bundler_dependency) }
 
-    it_behaves_like "a Package"
-
     let(:gemspec) do
       Gem::Specification.new do |s|
         s.name = 'spec_name'

data/spec/lib/license_finder/package_managers/bundler_spec.rb

@@ -52,20 +52,5 @@ module LicenseFinder
         end
       end
     end
-
-    describe '.active?' do
-      let(:package_path) { double(:gemfile_file) }
-      let(:bundler) { Bundler.new package_path: package_path }
-
-      it 'is true with a Gemfile file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(bundler).to be_active
-      end
-
-      it 'is false without a Gemfile file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(bundler).to_not be_active
-      end
-    end
   end
 end

data/spec/lib/license_finder/package_managers/cocoa_pods_package_spec.rb

@@ -7,8 +7,6 @@ module LicenseFinder
     end
     let(:license_text) { nil }
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "Name" }
     its(:version) { should == "1.0.0" }
     its(:summary) { should eq "" }
@@ -38,6 +36,11 @@ module LicenseFinder
       it "returns unknown when there's no license" do
         expect(subject.licenses.map(&:name)).to eq ["unknown"]
       end
+
+      it "respects license decisions" do
+        subject.decide_on_license(License.find_by_name("A"))
+        expect(subject.licenses.map(&:name)).to eq ["A"]
+      end
     end
   end
 end

data/spec/lib/license_finder/package_managers/cocoa_pods_spec.rb

@@ -2,7 +2,8 @@ require 'spec_helper'
 
 module LicenseFinder
   describe CocoaPods do
-    let(:cocoa_pods) { CocoaPods.new }
+    let(:project_path) { fixture_path("all_pms") }
+    let(:cocoa_pods) { CocoaPods.new(project_path: project_path) }
     it_behaves_like "a PackageManager"
 
     def stub_acknowledgments(hash = {})
@@ -19,7 +20,9 @@ module LicenseFinder
     end
 
     def stub_lockfile(pods)
-      allow(YAML).to receive(:load_file).with(Pathname.new("Podfile.lock")).and_return("PODS" => pods)
+      allow(YAML).to receive(:load_file)
+        .with(project_path.join("Podfile.lock"))
+        .and_return("PODS" => pods)
     end
 
     describe '.current_packages' do
@@ -31,46 +34,25 @@ module LicenseFinder
         ])
         stub_acknowledgments
 
-        expect(CocoaPodsPackage).to receive(:new).with("ABTest", "0.0.5", anything)
-        expect(CocoaPodsPackage).to receive(:new).with("JSONKit", "1.5pre", anything)
-        expect(CocoaPodsPackage).to receive(:new).with("OpenUDID", "1.0.0", anything)
-
-        current_packages = cocoa_pods.current_packages
-
-        expect(current_packages.size).to eq(3)
+        expect(cocoa_pods.current_packages.map { |p| [p.name, p.version ] }).to eq [
+          ["ABTest", "0.0.5"],
+          ["JSONKit", "1.5pre"],
+          ["OpenUDID", "1.0.0"]
+        ]
       end
 
       it "passes the license text to the package" do
         stub_lockfile(["Dependency Name (1.0)"])
-        stub_acknowledgments({name: "Dependency Name", license: "License Text"})
+        stub_acknowledgments({name: "Dependency Name", license: "The MIT License"})
 
-        expect(CocoaPodsPackage).to receive(:new).with("Dependency Name", "1.0", "License Text")
-
-        cocoa_pods.current_packages
+        expect(cocoa_pods.current_packages.first.licenses.map(&:name)).to eq ['MIT']
       end
 
       it "handles no licenses" do
         stub_lockfile(["Dependency Name (1.0)"])
         stub_acknowledgments
 
-        expect(CocoaPodsPackage).to receive(:new).with("Dependency Name", "1.0", nil)
-
-        cocoa_pods.current_packages
-      end
-    end
-
-    describe '.active?' do
-      let(:package_path) { double(:package_file) }
-      let(:cocoa_pods) { CocoaPods.new package_path: package_path }
-
-      it 'is true with a Podfile file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(cocoa_pods).to be_active
-      end
-
-      it 'is false without a Podfile file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(cocoa_pods).to_not be_active
+        expect(cocoa_pods.current_packages.first.licenses.map(&:name)).to eq ['unknown']
       end
     end
   end

data/spec/lib/license_finder/package_managers/gradle_package_spec.rb

@@ -9,8 +9,6 @@ module LicenseFinder
       )
     end
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "logback-classic" }
     its(:version) { should == "1.1.1" }
     its(:summary) { should == "" }

data/spec/lib/license_finder/package_managers/gradle_spec.rb

@@ -32,58 +32,34 @@ module LicenseFinder
       end
 
       it 'lists all the current packages' do
-        stub_license_report("""
+        stub_license_report("
           <dependency name='org.springframework:spring-aop:4.0.1.RELEASE'>
-            <file>spring-aop-4.0.1.RELEASE.jar</file>
-            <license name='The Apache Software License, Version 2.0' url='http://www.apache.org/licenses/LICENSE-2.0.txt' />
           </dependency>
           <dependency name='org.springframework:spring-core:4.0.1.RELEASE'>
-            <file>spring-core-4.0.1.RELEASE.jar</file>
-            <license name='The Apache Software License, Version 2.0' url='http://www.apache.org/licenses/LICENSE-2.0.txt' />
           </dependency>
-        """)
+        ")
 
-        current_packages = gradle.current_packages
-
-        expect(current_packages.size).to eq(2)
-        expect(current_packages.first).to be_a(Package)
+        expect(gradle.current_packages.map(&:name)).to eq ['spring-aop', 'spring-core']
       end
 
       it "handles multiple licenses" do
-        stub_license_report("""
-          <dependency>
+        stub_license_report("
+          <dependency name=''>
             <license name='License 1'/>
             <license name='License 2'/>
           </dependency>
-        """)
+        ")
 
-        expect(GradlePackage).to receive(:new).with({"license" => [{"name" => "License 1"}, {"name" => "License 2"}]}, anything)
-        gradle.current_packages
+        expect(gradle.current_packages.first.licenses.map(&:name)).to eq ["License 1", "License 2"]
       end
 
       it "handles an empty list of licenses" do
-        stub_license_report("""
-          <dependency>
+        stub_license_report("
+          <dependency name=''>
           </dependency>
-        """)
-        expect(GradlePackage).to receive(:new).with({}, anything)
-
-        gradle.current_packages
-      end
-    end
-
-    describe '.active?' do
-      let(:package_path) { double(:package_file) }
-      let(:gradle) { Gradle.new package_path: package_path }
-
-      it 'is true with a build.gradle file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(gradle).to be_active
-      end
+        ")
 
-      it 'is false without a build.gradle file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(gradle).to_not be_active
+        expect(gradle.current_packages.first.licenses.map(&:name)).to eq ['unknown']
       end
     end
   end

data/spec/lib/license_finder/package_managers/maven_package_spec.rb

@@ -10,8 +10,6 @@ module LicenseFinder
       )
     end
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "hamcrest-core" }
     its(:version) { should == "4.11" }
     its(:summary) { should == "" }

data/spec/lib/license_finder/package_managers/maven_spec.rb

@@ -18,46 +18,34 @@ module LicenseFinder
 
     describe '.current_packages' do
       before do
-        expect(maven).to receive('`').with(/mvn/)
+        allow(maven).to receive('`').with(/mvn/)
+      end
+
+      def stub_license_report(deps)
+        fake_file = double(:license_report, read: license_xml(deps))
+        allow(maven).to receive(:license_report).and_return(fake_file)
       end
 
       it 'lists all the current packages' do
-        license_xml = license_xml("""
+        stub_license_report("
           <dependency>
-            <groupId>junit</groupId>
             <artifactId>junit</artifactId>
             <version>4.11</version>
-            <licenses>
-              <license>
-                <name>Common Public License Version 1.0</name>
-                <url>http://www.opensource.org/licenses/cpl1.0.txt</url>
-              </license>
-            </licenses>
           </dependency>
           <dependency>
-            <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-core</artifactId>
             <version>1.3</version>
-            <licenses>
-              <license>
-                <name>New BSD License</name>
-                <url>http://www.opensource.org/licenses/bsd-license.php</url>
-                <distribution>repo</distribution>
-              </license>
-            </licenses>
            </dependency>
-        """)
-        fake_file = double(:license_report, read: license_xml)
-        allow(maven).to receive(:license_report).and_return(fake_file)
-
-        current_packages = maven.current_packages
+        ")
 
-        expect(current_packages.size).to eq(2)
-        expect(current_packages.first).to be_a(Package)
+        expect(maven.current_packages.map { |p| [p.name, p.version] }).to eq [
+          ["junit", "4.11"],
+          ["hamcrest-core", "1.3"]
+        ]
       end
 
       it "handles multiple licenses" do
-        license_xml = license_xml("""
+        stub_license_report("
           <dependency>
             <licenses>
               <license>
@@ -68,44 +56,18 @@ module LicenseFinder
               </license>
             </licenses>
           </dependency>
-        """)
+        ")
 
-        fake_file = double(:license_report, read: license_xml)
-        allow(maven).to receive(:license_report).and_return(fake_file)
-
-        expect(MavenPackage).to receive(:new).with({"licenses" => [{"name" => "License 1"}, {"name" => "License 2"}]}, anything)
-        maven.current_packages
+        expect(maven.current_packages.first.licenses.map(&:name)).to eq ['License 1', 'License 2']
       end
 
       it "handles no licenses" do
-        license_xml = license_xml("""
+        stub_license_report("
           <dependency>
-            <licenses>
-            <!-- comment -->
-            </licenses>
           </dependency>
-        """)
-
-        fake_file = double(:license_report, read: license_xml)
-        allow(maven).to receive(:license_report).and_return(fake_file)
-
-        expect(MavenPackage).to receive(:new).with({"licenses" => {}}, anything)
-        maven.current_packages
-      end
-    end
-
-    describe '.active?' do
-      let(:package_path) { double(:package_file) }
-      let(:maven) { Maven.new package_path: package_path }
-
-      it 'is true with a pom.xml file' do
-        allow(package_path).to receive(:exist?).and_return(true)
-        expect(maven.active?).to eq(true)
-      end
+        ")
 
-      it 'is false without a pom.xml file' do
-        allow(package_path).to receive(:exist?).and_return(false)
-        expect(maven.active?).to eq(false)
+        expect(maven.current_packages.first.licenses.map(&:name)).to eq ['unknown']
       end
     end
   end

data/spec/lib/license_finder/package_managers/npm_package_spec.rb

@@ -18,8 +18,6 @@ module LicenseFinder
       )
     end
 
-    it_behaves_like "a Package"
-
     its(:name) { should == "jasmine-node" }
     its(:version) { should == "1.3.1" }
     its(:summary) { should eq "" }

data/spec/lib/license_finder/package_managers/npm_spec.rb

@@ -67,8 +67,6 @@ module LicenseFinder
         current_packages = npm.current_packages
 
         expect(current_packages.map(&:name)).to eq(["depjs", "dep1-1js", "dep2js", "dep2-1js", "dep3js"])
-        expect(current_packages.first).to be_a(Package)
-        expect(current_packages.first.name).to eq("depjs")
       end
 
       it "does not support name version string" do
@@ -96,20 +94,5 @@ module LicenseFinder
         npm.current_packages
       end
     end
-
-    describe '.active?' do
-      let(:package_path) { double(:package_file) }
-      let(:npm) { NPM.new package_path: package_path }
-
-      it 'is true with a package.json file' do
-        allow(package_path).to receive_messages(:exist? => true)
-        expect(npm).to be_active
-      end
-
-      it 'is false without a package.json file' do
-        allow(package_path).to receive_messages(:exist? => false)
-        expect(npm).to_not be_active
-      end
-    end
   end
 end