license_finder 1.0.0.0-java → 1.1.1-java

data/spec/lib/license_finder/package_managers/cocoa_pods_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+module LicenseFinder
+  describe CocoaPods do
+    def stub_acknowledgments(hash = {})
+      plist_json = %{
+        {
+          "PreferenceSpecifiers": [
+            {
+              "FooterText": "#{hash[:license]}",
+              "Title": "#{hash[:name]}"
+            }
+          ]
+        }
+      }
+
+      expect(described_class).to receive(:`).with(/plutil/).and_return(plist_json)
+    end
+
+    def stub_lockfile(pods)
+      allow(YAML).to receive(:load_file).with(Pathname.new("Podfile.lock")).and_return("PODS" => pods)
+    end
+
+    describe '.current_packages' do
+      it 'lists all the current packages' do
+        stub_lockfile([
+          { "ABTest (0.0.5)" => ["OpenUDID"] },
+          "JSONKit (1.5pre)",
+          "OpenUDID (1.0.0)"
+        ])
+        stub_acknowledgments
+
+        expect(CocoaPodsPackage).to receive(:new).with("ABTest", "0.0.5", anything)
+        expect(CocoaPodsPackage).to receive(:new).with("JSONKit", "1.5pre", anything)
+        expect(CocoaPodsPackage).to receive(:new).with("OpenUDID", "1.0.0", anything)
+
+        current_packages = CocoaPods.current_packages
+
+        expect(current_packages.size).to eq(3)
+      end
+
+      it "passes the license text to the package" do
+        stub_lockfile(["Dependency Name (1.0)"])
+        stub_acknowledgments({name: "Dependency Name", license: "License Text"})
+
+        expect(CocoaPodsPackage).to receive(:new).with("Dependency Name", "1.0", "License Text")
+
+        CocoaPods.current_packages
+      end
+
+      it "handles no licenses" do
+        stub_lockfile(["Dependency Name (1.0)"])
+        stub_acknowledgments
+
+        expect(CocoaPodsPackage).to receive(:new).with("Dependency Name", "1.0", nil)
+
+        CocoaPods.current_packages
+      end
+    end
+
+    describe '.active?' do
+      let(:package) { double(:package_file) }
+
+      before do
+        CocoaPods.stub(package_path: package)
+      end
+
+      it 'is true with a Podfile file' do
+        package.stub(:exist? => true)
+        expect(CocoaPods).to be_active
+      end
+
+      it 'is false without a Podfile file' do
+        package.stub(:exist? => false)
+        expect(CocoaPods).to_not be_active
+      end
+    end
+  end
+end

data/spec/lib/license_finder/package_managers/gradle_package_spec.rb

@@ -19,11 +19,10 @@ module LicenseFinder
     its(:name) { should == "logback-classic" }
     its(:version) { should == "1.1.1" }
     its(:description) { should == "" }
-    its(:licenses_from_spec) { should == ["Eclipse Public License - v 1.0"] }
 
     describe "#license" do
       it "returns the license if found" do
-        subject.license.should == "Eclipse Public License - v 1.0"
+        subject.license.name.should == "Eclipse Public License - v 1.0"
       end
 
       context "when there are multiple licenses" do
@@ -40,8 +39,8 @@ module LicenseFinder
           )
         end
 
-        it "returns 'other'" do
-          subject.license.should == 'other'
+        it "returns 'multiple licenses'" do
+          subject.license.name.should == 'multiple licenses: Eclipse Public License - v 1.0, GNU Lesser General Public License'
         end
       end
 
@@ -57,7 +56,7 @@ module LicenseFinder
         end
 
         it "returns 'other' otherwise" do
-          subject.license.should == "other"
+          subject.license.name.should == "other"
         end
       end
     end

data/spec/lib/license_finder/package_managers/gradle_spec.rb

@@ -12,7 +12,8 @@ module LicenseFinder
 
     describe '.current_packages' do
       before do
-        expect(described_class).to receive(:`).with(/gradle downloadLicenses/)
+        allow(LicenseFinder.config).to receive(:gradle_command) { 'gradlefoo' }
+        expect(described_class).to receive(:`).with(/gradlefoo downloadLicenses/)
       end
 
       it 'lists all the current packages' do
@@ -26,7 +27,8 @@ module LicenseFinder
             <license name='The Apache Software License, Version 2.0' url='http://www.apache.org/licenses/LICENSE-2.0.txt' />
           </dependency>
         """)
-        allow(File).to receive(:read).with("build/reports/license/dependency-license.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Gradle).to receive(:license_report).and_return(fake_file)
 
         current_packages = described_class.current_packages
 
@@ -42,7 +44,8 @@ module LicenseFinder
           </dependency>
         """)
 
-        allow(File).to receive(:read).with("build/reports/license/dependency-license.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Gradle).to receive(:license_report).and_return(fake_file)
 
         GradlePackage.should_receive(:new).with("license" => [{"name" => "License 1"}, {"name" => "License 2"}])
         Gradle.current_packages
@@ -55,34 +58,37 @@ module LicenseFinder
           </dependency>
         """)
 
-        allow(File).to receive(:read).with("build/reports/license/dependency-license.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Gradle).to receive(:license_report).and_return(fake_file)
 
         GradlePackage.should_receive(:new).with("license" => [])
         Gradle.current_packages
       end
+
+      it "handles an empty list of licenses" do
+        license_xml = license_xml("")
+
+        fake_file = double(:license_report, read: license_xml)
+        allow(Gradle).to receive(:license_report).and_return(fake_file)
+        Gradle.current_packages
+      end
     end
 
     describe '.active?' do
-      let(:package) { Pathname.new('build.gradle').expand_path }
+      let(:package) { double(:package_file) }
 
-      context 'with a build.gradle file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(true)
-        end
-
-        it 'returns true' do
-          expect(Gradle.active?).to eq(true)
-        end
+      before do
+        Gradle.stub(package_path: package)
       end
 
-      context 'without a build.gradle file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(false)
-        end
+      it 'is true with a build.gradle file' do
+        package.stub(:exist? => true)
+        expect(Gradle).to be_active
+      end
 
-        it 'returns false' do
-          expect(Gradle.active?).to eq(false)
-        end
+      it 'is false without a build.gradle file' do
+        package.stub(:exist? => false)
+        expect(Gradle).to_not be_active
       end
     end
   end

data/spec/lib/license_finder/package_managers/maven_package_spec.rb

@@ -21,11 +21,10 @@ module LicenseFinder
     its(:name) { should == "hamcrest-core" }
     its(:version) { should == "4.11" }
     its(:description) { should == "" }
-    its(:licenses_from_spec) { should == ["Common Public License Version 1.0"] }
 
     describe "#license" do
       it "returns the license if found" do
-        subject.license.should == "Common Public License Version 1.0"
+        subject.license.name.should == "Common Public License Version 1.0"
       end
 
       context "when there are multiple licenses" do
@@ -46,8 +45,8 @@ module LicenseFinder
           )
         end
 
-        it "returns 'other'" do
-          subject.license.should == 'other'
+        it "returns 'multiple licenses'" do
+          subject.license.name.should == 'multiple licenses: Common Public License Version 1.0, Apache 2'
         end
       end
 
@@ -63,7 +62,7 @@ module LicenseFinder
         end
 
         it "returns 'other' otherwise" do
-          subject.license.should == "other"
+          subject.license.name.should == "other"
         end
       end
     end

data/spec/lib/license_finder/package_managers/maven_spec.rb

@@ -44,7 +44,8 @@ module LicenseFinder
             </licenses>
            </dependency>
         """)
-        allow(File).to receive(:read).with("target/generated-resources/licenses.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Maven).to receive(:license_report).and_return(fake_file)
 
         current_packages = Maven.current_packages
 
@@ -66,7 +67,8 @@ module LicenseFinder
           </dependency>
         """)
 
-        allow(File).to receive(:read).with("target/generated-resources/licenses.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Maven).to receive(:license_report).and_return(fake_file)
 
         MavenPackage.should_receive(:new).with("licenses" => [{"name" => "License 1"}, {"name" => "License 2"}])
         Maven.current_packages
@@ -81,7 +83,8 @@ module LicenseFinder
           </dependency>
         """)
 
-        allow(File).to receive(:read).with("target/generated-resources/licenses.xml").and_return(license_xml)
+        fake_file = double(:license_report, read: license_xml)
+        allow(Maven).to receive(:license_report).and_return(fake_file)
 
         MavenPackage.should_receive(:new).with("licenses" => {})
         Maven.current_packages
@@ -89,26 +92,20 @@ module LicenseFinder
     end
 
     describe '.active?' do
-      let(:package) { Pathname.new('pom.xml').expand_path }
+      let(:package) { double(:package_file) }
 
-      context 'with a pom.xml file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(true)
-        end
-
-        it 'returns true' do
-          expect(Maven.active?).to eq(true)
-        end
+      before do
+        allow(Maven).to receive(:package_path).and_return(package)
       end
 
-      context 'without a pom.xml file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(false)
-        end
+      it 'is true with a pom.xml file' do
+        allow(package).to receive(:exist?).and_return(true)
+        expect(Maven.active?).to eq(true)
+      end
 
-        it 'returns false' do
-          expect(Maven.active?).to eq(false)
-        end
+      it 'is false without a pom.xml file' do
+        allow(package).to receive(:exist?).and_return(false)
+        expect(Maven.active?).to eq(false)
       end
     end
   end

data/spec/lib/license_finder/package_managers/npm_package_spec.rb

@@ -32,36 +32,56 @@ module LicenseFinder
       let(:node_module2) { {"licenses" => [{"type" => "BSD"}], "path" => "/some/path"} }
       let(:node_module3) { {"license" => {"type" => "PSF"}, "path" => "/some/path"} }
       let(:node_module4) { {"licenses" => ["MIT"], "path" => "/some/path"} }
+      let(:misdeclared_node_module) { {"licenses" => {"type" => "MIT"}} }
 
       it 'finds the license for both license structures' do
-        NpmPackage.new(node_module1).license.should eq("MIT")
-        NpmPackage.new(node_module2).license.should eq("BSD")
-        NpmPackage.new(node_module3).license.should eq("PSF")
-        NpmPackage.new(node_module4).license.should eq("MIT")
+        NpmPackage.new(node_module1).license.name.should eq("MIT")
+        NpmPackage.new(node_module2).license.name.should eq("BSD")
+        NpmPackage.new(node_module3).license.name.should eq("Python Software Foundation License")
+        NpmPackage.new(node_module4).license.name.should eq("MIT")
+        NpmPackage.new(misdeclared_node_module).license.name.should eq("MIT")
       end
 
-      it "returns a license in a file if detected" do
-        stub_license_files [double(:file, license: 'Detected License')]
+      context "regardless of whether there are licenses in files" do
+        before do
+          stub_license_files [double(:file, license: License.find_by_name('Detected License'))]
+        end
 
-        subject.license.should == "Detected License"
-      end
+        it "returns the license from the spec if there is only one unique license" do
+          package = NpmPackage.new({ "licenses" => ["MIT", "Expat"], "path" => "/path/to/thing" })
+          expect(package.license.name).to eq("MIT")
+        end
 
-      it "returns other if there's more than one license" do
-        package = NpmPackage.new({ "licenses" => ["MIT", "BSD"], "path" => "/some/path" })
-        expect(package.license).to eq("other")
+        it "returns 'multiple licenses' if there's more than one license" do
+          package = NpmPackage.new({ "licenses" => ["MIT", "BSD"], "path" => "/some/path" })
+          expect(package.license.name).to eq("multiple licenses: MIT, BSD")
+        end
       end
 
-      it "returns other if the license from spec and license from files are different" do
-        stub_license_files [double(:file, license: 'Detected License')]
-        package = NpmPackage.new({ "licenses" => ["MIT"], "path" => "some/node/package/path" })
+      context "when there is nothing in the spec" do
+        it "returns a license in a file if only one unique license detected" do
+          stub_license_files([
+            double(:first_file, license: License.find_by_name('MIT')),
+            double(:second_file, license: License.find_by_name('Expat'))
+          ])
 
-        expect(package.license).to eq("other")
-      end
+          subject.license.name.should == "MIT"
+        end
+
+        it "returns 'other' if there are no licenses in files" do
+          stub_license_files []
+
+          subject.license.name.should == "other"
+        end
 
-      it "returns 'other' otherwise" do
-        stub_license_files []
+        it "returns 'other' if there are many licenses in files" do
+          stub_license_files([
+            double(:first_file, license: License.find_by_name('First Detected License')),
+            double(:second_file, license: License.find_by_name('Second Detected License'))
+          ])
 
-        subject.license.should == "other"
+          subject.license.name.should == "multiple licenses: First Detected License, Second Detected License"
+        end
       end
     end
   end

data/spec/lib/license_finder/package_managers/npm_spec.rb

@@ -98,26 +98,20 @@ module LicenseFinder
     end
 
     describe '.active?' do
-      let(:package) { Pathname.new('package.json').expand_path }
+      let(:package) { double(:package_file) }
 
-      context 'with a package.json file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(true)
-        end
-
-        it 'returns true' do
-          expect(NPM.active?).to eq(true)
-        end
+      before do
+        NPM.stub(package_path: package)
       end
 
-      context 'without a package file' do
-        before :each do
-          allow(File).to receive(:exists?).with(package).and_return(false)
-        end
+      it 'is true with a package.json file' do
+        package.stub(:exist? => true)
+        expect(NPM).to be_active
+      end
 
-        it 'returns false' do
-          expect(NPM.active?).to eq(false)
-        end
+      it 'is false without a package.json file' do
+        package.stub(:exist? => false)
+        expect(NPM).to_not be_active
       end
     end
   end

data/spec/lib/license_finder/package_managers/pip_package_spec.rb

@@ -56,7 +56,7 @@ module LicenseFinder
 
           subject = make_package(data)
 
-          expect(subject.license).to eq('MIT')
+          expect(subject.license.name).to eq('MIT')
         end
 
         context "when there's no explicit license" do
@@ -65,15 +65,15 @@ module LicenseFinder
 
             subject = make_package(data)
 
-            expect(subject.license).to eq('Apache 2.0 License')
+            expect(subject.license.name).to eq('Apache 2.0 License')
           end
 
-          it "returns 'other' if there is are multiple licenses in 'classifiers'" do
+          it "returns 'multiple licenses' if there are multiple licenses in 'classifiers'" do
             data = { "classifiers" => [ 'License :: OSI Approved :: Apache 2.0 License', 'License :: OSI Approved :: GPL' ] }
 
             subject = make_package(data)
 
-            expect(subject.license).to eq('other')
+            expect(subject.license.name).to eq('multiple licenses: Apache 2.0 License, GPL')
           end
         end
 
@@ -84,7 +84,7 @@ module LicenseFinder
 
             subject = make_package(data)
 
-            expect(subject.license).to eq('Apache 2.0 License')
+            expect(subject.license.name).to eq('Apache 2.0 License')
           end
         end
       end
@@ -96,13 +96,13 @@ module LicenseFinder
         end
 
         it 'returns license from file' do
-          stub_license_files [double(:license_file, license: 'License from file')]
-          expect(subject.license).to eq('License from file')
+          stub_license_files [double(:license_file, license: License.find_by_name('License from file'))]
+          expect(subject.license.name).to eq('License from file')
         end
 
         it 'returns other if no license can be found' do
           stub_license_files []
-          expect(subject.license).to eq('other')
+          expect(subject.license.name).to eq('other')
         end
       end
     end